date:20181124

[webkit-changes] [238473] trunk/Source

2018-11-24 Thread wenson_hsieh

Title: [238473] trunk/Source








Revision 238473
Author wenson_hs...@apple.com
Date 2018-11-24 17:45:54 -0800 (Sat, 24 Nov 2018)


Log Message
[Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
https://bugs.webkit.org/show_bug.cgi?id=191945

Reviewed by Anders Carlsson.

Source/WebCore:

Run `update-webkit-localizable-strings`.

* en.lproj/Localizable.strings:

Source/WebKit:

Replace some a couple of command undo action name descriptions with "Undo action name", to match all other
edit commands.

* UIProcess/WebEditCommandProxy.cpp:
(WebKit::WebEditCommandProxy::nameForEditAction):

Source/WebKitLegacy/mac:

* WebCoreSupport/WebEditorClient.mm:
(undoNameForEditAction):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/en.lproj/Localizable.strings
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebEditCommandProxy.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (238472 => 238473)

--- trunk/Source/WebCore/ChangeLog	2018-11-25 00:37:06 UTC (rev 238472)
+++ trunk/Source/WebCore/ChangeLog	2018-11-25 01:45:54 UTC (rev 238473)
@@ -1,3 +1,14 @@
+2018-11-24  Wenson Hsieh  
+
+[Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
+https://bugs.webkit.org/show_bug.cgi?id=191945
+
+Reviewed by Anders Carlsson.
+
+Run `update-webkit-localizable-strings`.
+
+* en.lproj/Localizable.strings:
+
 2018-11-24  Sam Weinig  
 
 Remove now unnecessary specialized ListHashSet from InlineItem.h


Modified: trunk/Source/WebCore/en.lproj/Localizable.strings (238472 => 238473)

--- trunk/Source/WebCore/en.lproj/Localizable.strings	2018-11-25 00:37:06 UTC (rev 238472)
+++ trunk/Source/WebCore/en.lproj/Localizable.strings	2018-11-25 01:45:54 UTC (rev 238473)
@@ -187,10 +187,10 @@
 /* Media Controls context menu item */
 "Controls" = "Controls";
 
-/* Convert to ordered list action name */
+/* Undo action name */
 "Convert to Ordered List (Undo action name)" = "Convert to Ordered List";
 
-/* Convert to unordered list action name */
+/* Undo action name */
 "Convert to Unordered List (Undo action name)" = "Convert to Unordered List";
 
 /* Copy context menu item */
@@ -595,12 +595,12 @@
 /* Search in Spotlight context menu item */
 "Search in Spotlight" = "Search in Spotlight";
 
+/* Search the Web context menu item */
+"Search the Web" = "Search the Web";
+
 /* Search with search provider context menu item with provider name inserted */
 "Search with %@" = "Search with %@";
 
-/* Search the Web context menu item */
-"Search the Web" = "Search the Web";
-
 /* Validation message for required file inputs that have no value */
 "Select a file" = "Select a file";
 
@@ -820,6 +820,9 @@
 /* accessibility role description for a URL field. */
 "URL field" = "URL field";
 
+/* Unacceptable TLS certificate error */
+"Unacceptable TLS certificate" = "Unacceptable TLS certificate";
+
 /* Underline context menu item */
 "Underline" = "Underline";
 


Modified: trunk/Source/WebKit/ChangeLog (238472 => 238473)

--- trunk/Source/WebKit/ChangeLog	2018-11-25 00:37:06 UTC (rev 238472)
+++ trunk/Source/WebKit/ChangeLog	2018-11-25 01:45:54 UTC (rev 238473)
@@ -1,5 +1,18 @@
 2018-11-24  Wenson Hsieh  
 
+[Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
+https://bugs.webkit.org/show_bug.cgi?id=191945
+
+Reviewed by Anders Carlsson.
+
+Replace some a couple of command undo action name descriptions with "Undo action name", to match all other
+edit commands.
+
+* UIProcess/WebEditCommandProxy.cpp:
+(WebKit::WebEditCommandProxy::nameForEditAction):
+
+2018-11-24  Wenson Hsieh  
+
 [Cocoa] Add WKWebView SPI to trigger and remove data detection
 https://bugs.webkit.org/show_bug.cgi?id=191918
 


Modified: trunk/Source/WebKit/UIProcess/WebEditCommandProxy.cpp (238472 => 238473)

--- trunk/Source/WebKit/UIProcess/WebEditCommandProxy.cpp	2018-11-25 00:37:06 UTC (rev 238472)
+++ trunk/Source/WebKit/UIProcess/WebEditCommandProxy.cpp	2018-11-25 01:45:54 UTC (rev 238473)
@@ -174,9 +174,9 @@
 // FIXME: We should give internal clients a way to override these undo names. For instance, Mail refers to ordered and unordered lists as "numbered" and "bulleted" lists, respectively,
 // despite the fact that ordered and unordered lists are not necessarily displayed using bullets and numerals.
 case EditAction::ConvertToOrderedList:
-return WEB_UI_STRING_KEY("Convert to Ordered List", "Convert to Ordered List (Undo action name)", "Convert to ordered list action name");
+return WEB_UI_STRING_KEY("Convert to Ordered List", "Convert to Ordered List (Undo action name)", "Undo action name");
 case EditAction::ConvertToUnorderedList:
-

[webkit-changes] [238472] trunk/Source/WebCore

2018-11-24 Thread commit-queue

Title: [238472] trunk/Source/WebCore








Revision 238472
Author commit-qu...@webkit.org
Date 2018-11-24 16:37:06 -0800 (Sat, 24 Nov 2018)


Log Message
Remove now unnecessary specialized ListHashSet from InlineItem.h
https://bugs.webkit.org/show_bug.cgi?id=191946

Patch by Sam Weinig  on 2018-11-24
Reviewed by Zalan Bujtas.

Now that ListHashSet supports raw pointer overloads for smart pointers,
we can fix the FIXME in InlineItem.h and remove the specialized ListHashSet
and ListHashSet::find calls.

* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):
(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):
* layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::InlineFormattingContext::Geometry::runWidth):
* layout/inlineformatting/InlineItem.h:
(WebCore::Layout::InlineItemHashFunctions::hash): Deleted.
(WebCore::Layout::InlineItemHashFunctions::equal): Deleted.
(WebCore::Layout::InlineItemHashTranslator::hash): Deleted.
(WebCore::Layout::InlineItemHashTranslator::equal): Deleted.
* layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::InlineLineBreaker::textWidth const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineItem.h
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238471 => 238472)

--- trunk/Source/WebCore/ChangeLog	2018-11-24 21:06:09 UTC (rev 238471)
+++ trunk/Source/WebCore/ChangeLog	2018-11-25 00:37:06 UTC (rev 238472)
@@ -1,3 +1,27 @@
+2018-11-24  Sam Weinig  
+
+Remove now unnecessary specialized ListHashSet from InlineItem.h
+https://bugs.webkit.org/show_bug.cgi?id=191946
+
+Reviewed by Zalan Bujtas.
+
+Now that ListHashSet supports raw pointer overloads for smart pointers,
+we can fix the FIXME in InlineItem.h and remove the specialized ListHashSet
+and ListHashSet::find calls.
+
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):
+(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):
+* layout/inlineformatting/InlineFormattingContextGeometry.cpp:
+(WebCore::Layout::InlineFormattingContext::Geometry::runWidth):
+* layout/inlineformatting/InlineItem.h:
+(WebCore::Layout::InlineItemHashFunctions::hash): Deleted.
+(WebCore::Layout::InlineItemHashFunctions::equal): Deleted.
+(WebCore::Layout::InlineItemHashTranslator::hash): Deleted.
+(WebCore::Layout::InlineItemHashTranslator::equal): Deleted.
+* layout/inlineformatting/InlineLineBreaker.cpp:
+(WebCore::Layout::InlineLineBreaker::textWidth const):
+
 2018-11-24  Wenson Hsieh  
 
 [Cocoa] Add WKWebView SPI to trigger and remove data detection


Modified: trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp (238471 => 238472)

--- trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp	2018-11-24 21:06:09 UTC (rev 238471)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp	2018-11-25 00:37:06 UTC (rev 238472)
@@ -162,7 +162,7 @@
 uncommitted = { };
 };
 
-for (auto iterator = inlineContent.find(inlineRun.inlineItem()); iterator != inlineContent.end() && remaningLength > 0; ++iterator) {
+for (auto iterator = inlineContent.find(()); iterator != inlineContent.end() && remaningLength > 0; ++iterator) {
 auto& inlineItem = **iterator;
 
 // Skip all non-inflow boxes (floats, out-of-flow positioned elements). They don't participate in the inline run context.
@@ -489,7 +489,7 @@
 auto& inlineContent = inlineFormattingState.inlineContent();
 
 if (lastInlineBoxBeforeContainer) {
-auto iterator = inlineContent.find(*lastInlineBoxBeforeContainer);
+auto iterator = inlineContent.find(lastInlineBoxBeforeContainer);
 firstDescendantInlineBox = (*++iterator).get();
 } else
 firstDescendantInlineBox = inlineContent.first().get();


Modified: trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp (238471 => 238472)

--- trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp	2018-11-24 21:06:09 UTC (rev 238471)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp	2018-11-25 00:37:06 UTC (rev 238472)
@@ -180,7 +180,7 @@
 {
 LayoutUnit width;
 auto startPosition = from;
-auto iterator = inlineContent.find(inlineItem);
+auto iterator = inlineContent.find();
 auto inlineItemEnd = inlineContent.end();
 while (length) {

[webkit-changes] [238471] trunk

2018-11-24 Thread wenson_hsieh

Title: [238471] trunk








Revision 238471
Author wenson_hs...@apple.com
Date 2018-11-24 13:06:09 -0800 (Sat, 24 Nov 2018)


Log Message
[Cocoa] Add WKWebView SPI to trigger and remove data detection
https://bugs.webkit.org/show_bug.cgi?id=191918


Reviewed by Tim Horton.

Source/WebCore:

Add a helper method on DataDetection to remove all data detected links in the given document. See WebKit changes
for more detail.

* editing/cocoa/DataDetection.h:
* editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::removeDataDetectedLinksInDocument):

Source/WebKit:

Adds support for two new WKWebView SPI methods, `-_detectDataWithTypes:completionHandler:` and
`-_removeAllDataDetectedLinks:`, to allow internal WebKit clients to run data detection and add links to data
detected content, or remove all data detected links from the document.

Test: WebKit.AddAndRemoveDataDetectors

* Shared/Cocoa/DataDetectionResult.h:
* Shared/Cocoa/DataDetectionResult.mm:
(WebKit::DataDetectionResult::decode):

Modernize DataDetectionResult's IPC decoding, so that it can be used with reply-based async IPC.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _removeDataDetectedLinks:]):
(-[WKWebView _detectDataWithTypes:completionHandler:]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::detectDataInAllFrames):
(WebKit::WebPageProxy::removeDataDetectedLinks):

Add or remove data detected links from each frame in the page, and then propagate the new data detector
results of the main frame to the UI process (this matches current behavior, where the results of -[WKWebView
_dataDetectionResults] only reflects data detection results in the main frame of the page).

* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::removeDataDetectedLinks):
(WebKit::WebPage::detectDataInAllFrames):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Tools:

Add an API test to exercise the new WebKit SPI.

* TestWebKitAPI/DataDetectorsCoreSPI.h: Added.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
(-[WKWebView synchronouslyDetectDataWithTypes:]):
(-[WKWebView synchronouslyRemoveDataDetectedLinks]):
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::TEST):
(-[TestWKWebView tagsInBody]): Deleted.
(-[TestWKWebView expectElementTagsInOrder:]): Deleted.
(-[TestWKWebView expectElementCount:tagName:]): Deleted.
(-[TestWKWebView expectElementTag:toComeBefore:]): Deleted.

Rename this from `-expectElementCount:tagName:` to `-expectElementCount:querySelector:`.

* TestWebKitAPI/Tests/WebKitCocoa/data-detectors.html: Added.

Add a new test page containing some content that can be data detected.

* TestWebKitAPI/cocoa/TestWKWebView.h:
* TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[WKWebView tagsInBody]):
(-[WKWebView expectElementTagsInOrder:]):
(-[WKWebView expectElementCount:querySelector:]):
(-[WKWebView expectElementTag:toComeBefore:]):

Move some testing helper functions from WKAttachmentTests to a testing category on WKWebView. This allows us to
use `-expectElementCount:querySelector:` in tests outside of WKAttachmentTests.

(-[WKWebView objectByEvaluatingJavaScript:]):
(-[WKWebView objectByEvaluatingJavaScriptWithUserGesture:]):
(-[WKWebView stringByEvaluatingJavaScript:]):

Move some common helper functions from TestWKWebView to a testing category on WKWebView.

(-[TestWKWebView objectByEvaluatingJavaScript:]): Deleted.
(-[TestWKWebView objectByEvaluatingJavaScriptWithUserGesture:]): Deleted.
(-[TestWKWebView stringByEvaluatingJavaScript:]): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/cocoa/DataDetection.h
trunk/Source/WebCore/editing/cocoa/DataDetection.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/DataDetectionResult.h
trunk/Source/WebKit/Shared/Cocoa/DataDetectionResult.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm
trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.h
trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm


Added Paths

trunk/Tools/TestWebKitAPI/DataDetectorsCoreSPI.h
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/data-detectors.html




Diff

Modified: trunk/Source/WebCore/ChangeLog (238470 => 238471)

--- trunk/Source/WebCore/ChangeLog	2018-11-24 18:37:14 UTC (rev 238470)
+++ trunk/Source/WebCore/ChangeLog	2018-11-24 21:06:09 UTC (rev 238471)
@@ -1,3 +1,18 @@
+2018-11-24  Wenson

[webkit-changes] [238470] trunk/Source

2018-11-24 Thread aestes

Title: [238470] trunk/Source








Revision 238470
Author aes...@apple.com
Date 2018-11-24 10:37:14 -0800 (Sat, 24 Nov 2018)


Log Message
[Cocoa] SOFT_LINK_CLASS_FOR_{HEADER,SOURCE} should generate a more concise getter function
https://bugs.webkit.org/show_bug.cgi?id=191899

Reviewed by Dean Jackson.

Source/WebCore:

* editing/cocoa/DataDetection.mm:
* editing/cocoa/FontAttributesCocoa.mm:
* editing/cocoa/FontShadowCocoa.mm:
* platform/cocoa/DataDetectorsCoreSoftLink.h:
* platform/graphics/cocoa/ColorCocoa.mm:
* platform/ios/PlatformScreenIOS.mm:

Source/WebCore/PAL:

* pal/cocoa/PassKitSoftLink.h:
* pal/ios/UIKitSoftLink.h:

Source/WebKit:

* Shared/cocoa/WebCoreArgumentCodersCocoa.mm:
* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
* UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:

Source/WTF:

Currently, SOFT_LINK_CLASS_FOR_HEADER declares a class getter function that includes the
framework name. For example, NSView would have a class getter named
namespace::get_AppKit_NSViewClass().

Including the framework name in the getter is unnecessary. Objective-C classes already exist
in a global namespace, so there is no need to disambiguate class names by framework. This
patch elides the framework name from the getter function. For example, NSView would now have
a getter named namespace::getNSViewClass().

* wtf/cocoa/SoftLinking.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/cocoa/SoftLinking.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h
trunk/Source/WebCore/PAL/pal/ios/UIKitSoftLink.h
trunk/Source/WebCore/editing/cocoa/DataDetection.mm
trunk/Source/WebCore/editing/cocoa/FontAttributesCocoa.mm
trunk/Source/WebCore/editing/cocoa/FontShadowCocoa.mm
trunk/Source/WebCore/platform/cocoa/DataDetectorsCoreSoftLink.h
trunk/Source/WebCore/platform/graphics/cocoa/ColorCocoa.mm
trunk/Source/WebCore/platform/ios/PlatformScreenIOS.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm
trunk/Source/WebKit/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm
trunk/Source/WebKit/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (238469 => 238470)

--- trunk/Source/WTF/ChangeLog	2018-11-24 15:13:15 UTC (rev 238469)
+++ trunk/Source/WTF/ChangeLog	2018-11-24 18:37:14 UTC (rev 238470)
@@ -1,3 +1,21 @@
+2018-11-24  Andy Estes  
+
+[Cocoa] SOFT_LINK_CLASS_FOR_{HEADER,SOURCE} should generate a more concise getter function
+https://bugs.webkit.org/show_bug.cgi?id=191899
+
+Reviewed by Dean Jackson.
+
+Currently, SOFT_LINK_CLASS_FOR_HEADER declares a class getter function that includes the
+framework name. For example, NSView would have a class getter named
+namespace::get_AppKit_NSViewClass().
+
+Including the framework name in the getter is unnecessary. Objective-C classes already exist
+in a global namespace, so there is no need to disambiguate class names by framework. This
+patch elides the framework name from the getter function. For example, NSView would now have
+a getter named namespace::getNSViewClass().
+
+* wtf/cocoa/SoftLinking.h:
+
 2018-11-24  Michael Catanzaro  
 
 CRASH() should call abort() except on Darwin and in developer builds


Modified: trunk/Source/WTF/wtf/cocoa/SoftLinking.h (238469 => 238470)

--- trunk/Source/WTF/wtf/cocoa/SoftLinking.h	2018-11-24 15:13:15 UTC (rev 238469)
+++ trunk/Source/WTF/wtf/cocoa/SoftLinking.h	2018-11-24 18:37:14 UTC (rev 238470)
@@ -378,14 +378,14 @@
 #define SOFT_LINK_PRIVATE_FRAMEWORK_FOR_SOURCE(functionNamespace, framework) \
 SOFT_LINK_PRIVATE_FRAMEWORK_FOR_SOURCE_WITH_EXPORT(functionNamespace, framework, )
 
-#define SOFT_LINK_CLASS_FOR_HEADER(functionNamespace, framework, className) \
+#define SOFT_LINK_CLASS_FOR_HEADER(functionNamespace, className) \
 @class className; \
 namespace functionNamespace { \
-extern Class (*get_##framework##_##className##Class)(); \
+extern Class (*get##className##Class)(); \
 className *alloc##className##Instance(); \
 inline className *alloc##className##Instance() \
 { \
-return [get_##framework##_##className##Class() alloc]; \
+return [get##className##Class() alloc]; \
 } \
 }
 
@@ -393,7 +393,7 @@
 @class className; \
 namespace functionNamespace { \
 static Class init##className(); \
-export Class (*get_##framework##_##className##Class)() = init##className; \
+export Class (*get##className##Class)() = init##className; \
 static Class class##className; \
 \
 static Class className##Function() \
@@ -408,7 +408,7 @@
 framework##Library(); \
 class##className = objc_getClass(#className); \
 RELEASE_ASSERT(class##className); \
-get_##framework##_##className##Class = className##Function; \
+

[webkit-changes] [238469] trunk/Source/WTF

2018-11-24 Thread mcatanzaro

Title: [238469] trunk/Source/WTF








Revision 238469
Author mcatanz...@igalia.com
Date 2018-11-24 07:13:15 -0800 (Sat, 24 Nov 2018)


Log Message
CRASH() should call abort() except on Darwin and in developer builds
https://bugs.webkit.org/show_bug.cgi?id=184408

Reviewed by Daniel Bates.

CRASH() should call abort() except on Darwin and in developer builds, as discussed on
webkit-dev. This should be slightly nicer than dereferencing 0xbadbeef.

On Darwin, CRASH() uses a breakpoint trap, which seems to corrupt the stack on Linux, so we
can't do that.

Continue to call WTFCrash() in developer mode, and make no changes to WTFCrash(), since it
is reportedly useful in nightmare scenarios where core dumps are unavailable.

* wtf/Assertions.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Assertions.h




Diff

Modified: trunk/Source/WTF/ChangeLog (238468 => 238469)

--- trunk/Source/WTF/ChangeLog	2018-11-24 07:17:35 UTC (rev 238468)
+++ trunk/Source/WTF/ChangeLog	2018-11-24 15:13:15 UTC (rev 238469)
@@ -1,3 +1,21 @@
+2018-11-24  Michael Catanzaro  
+
+CRASH() should call abort() except on Darwin and in developer builds
+https://bugs.webkit.org/show_bug.cgi?id=184408
+
+Reviewed by Daniel Bates.
+
+CRASH() should call abort() except on Darwin and in developer builds, as discussed on
+webkit-dev. This should be slightly nicer than dereferencing 0xbadbeef.
+
+On Darwin, CRASH() uses a breakpoint trap, which seems to corrupt the stack on Linux, so we
+can't do that.
+
+Continue to call WTFCrash() in developer mode, and make no changes to WTFCrash(), since it
+is reportedly useful in nightmare scenarios where core dumps are unavailable.
+
+* wtf/Assertions.h:
+
 2018-11-23  Sam Weinig  
 
 Add raw pointer overloads to ListHashSet via SmartPtr specialized functions


Modified: trunk/Source/WTF/wtf/Assertions.h (238468 => 238469)

--- trunk/Source/WTF/wtf/Assertions.h	2018-11-24 07:17:35 UTC (rev 238468)
+++ trunk/Source/WTF/wtf/Assertions.h	2018-11-24 15:13:15 UTC (rev 238469)
@@ -44,6 +44,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #if USE(OS_LOG)
@@ -239,6 +240,8 @@
 WTFBreakpointTrapUnderConstexprContext(); \
 __builtin_unreachable(); \
 } while (0)
+#elif !ENABLE(DEVELOPER_MODE) && !OS(DARWIN)
+#define CRASH() abort()
 #else
 #define CRASH() WTFCrash()
 #define CRASH_UNDER_CONSTEXPR_CONTEXT() WTFCrash()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238473] trunk/Source

[webkit-changes] [238472] trunk/Source/WebCore

[webkit-changes] [238471] trunk

[webkit-changes] [238470] trunk/Source

[webkit-changes] [238469] trunk/Source/WTF

5 matches

Site Navigation

Mail list logo

Footer information