[webkit-changes] [290116] trunk
Title: [290116] trunk Revision 290116 Author megan_gard...@apple.com Date 2022-02-17 23:55:32 -0800 (Thu, 17 Feb 2022) Log Message Draw highlights for Scroll To Text Fragment https://bugs.webkit.org/show_bug.cgi?id=236693 Reviewed by Tim Horton. Source/WebCore: Implement a very basic search for text fragments (this will be properly implemented later) and leverage our Highlight and AppHighlight infrastructures to draw the found ranges for Scroll to Text Fragment and scroll so they are guaranteed to be in view. * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * dom/Document.cpp: (WebCore::Document::commonTeardown): (WebCore::Document::fragmentHighlightRegister): (WebCore::Document::updateHighlightPositions): * dom/Document.h: (WebCore::Document::fragmentHighlightRegisterIfExists): * page/FrameView.cpp: (WebCore::FrameView::scrollToFragment): * rendering/MarkedText.cpp: (WebCore::MarkedText::collectForHighlights): * rendering/MarkedText.h: * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calculateHighlightColor const): * rendering/StyledMarkedText.cpp: (WebCore::resolveStyleForMarkedText): Tools: * TestWebKitAPI/Tests/WebCore/MarkedText.cpp: (WebCore::operator<<): Modified Paths trunk/LayoutTests/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/highlight/AppHighlightStorage.cpp trunk/Source/WebCore/Modules/highlight/HighlightRegister.cpp trunk/Source/WebCore/Modules/highlight/HighlightRegister.h trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/rendering/MarkedText.cpp trunk/Source/WebCore/rendering/MarkedText.h trunk/Source/WebCore/rendering/RenderReplaced.cpp trunk/Source/WebCore/rendering/RenderTheme.cpp trunk/Source/WebCore/rendering/RenderTheme.h trunk/Source/WebCore/rendering/RenderThemeIOS.h trunk/Source/WebCore/rendering/RenderThemeIOS.mm trunk/Source/WebCore/rendering/RenderThemeMac.h trunk/Source/WebCore/rendering/RenderThemeMac.mm trunk/Source/WebCore/rendering/StyledMarkedText.cpp trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebCore/MarkedText.cpp Added Paths trunk/Source/WebCore/dom/FragmentDirectiveRangeFinder.cpp trunk/Source/WebCore/dom/FragmentDirectiveRangeFinder.h Diff Modified: trunk/LayoutTests/TestExpectations (290115 => 290116) --- trunk/LayoutTests/TestExpectations 2022-02-18 07:45:54 UTC (rev 290115) +++ trunk/LayoutTests/TestExpectations 2022-02-18 07:55:32 UTC (rev 290116) @@ -2960,6 +2960,7 @@ imported/w3c/web-platform-tests/css/css-pseudo/highlight-paired-cascade-004.tentative.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-pseudo/highlight-paired-cascade-006.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-pseudo/highlight-styling-002.html [ ImageOnlyFailure ] +# WPT support ::target-text (webkit.org/b/236817) imported/w3c/web-platform-tests/css/css-pseudo/target-text-001.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-pseudo/target-text-002.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-pseudo/target-text-003.html [ ImageOnlyFailure ] @@ -2968,7 +2969,9 @@ imported/w3c/web-platform-tests/css/css-pseudo/target-text-006.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-pseudo/target-text-dynamic-001.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-pseudo/target-text-dynamic-002.html [ ImageOnlyFailure ] +imported/w3c/web-platform-tests/css/css-pseudo/target-text-dynamic-003.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-pseudo/target-text-dynamic-004.html [ ImageOnlyFailure ] +imported/w3c/web-platform-tests/css/css-pseudo/target-text-text-decoration-001.html [ ImageOnlyFailure ] webkit.org/b/177799 accessibility/table-detection.html [ Pass Failure ] Modified: trunk/Source/WebCore/ChangeLog (290115 => 290116) --- trunk/Source/WebCore/ChangeLog 2022-02-18 07:45:54 UTC (rev 290115) +++ trunk/Source/WebCore/ChangeLog 2022-02-18 07:55:32 UTC (rev 290116) @@ -1,3 +1,32 @@ +2022-02-17 Megan Gardner + +Draw highlights for Scroll To Text Fragment +https://bugs.webkit.org/show_bug.cgi?id=236693 + +Reviewed by Tim Horton. + +Implement a very basic search for text fragments (this will be properly implemented later) +and leverage our Highlight and AppHighlight infrastructures to draw the found ranges for +Scroll to Text Fragment and scroll so they are guaranteed to be in view. + +* Sources.txt: +* WebCore.xcodeproj/project.pbxproj: +* dom/Document.cpp: +(WebCore::Document::commonTeardown): +(WebCore::Document::fragmentHighlightRegister): +(WebCore::Document::updateHighlightPositions): +* dom/Document.h: +
[webkit-changes] [290115] trunk/Source/WebKit
Title: [290115] trunk/Source/WebKit
Revision 290115
Author sihui_...@apple.com
Date 2022-02-17 23:45:54 -0800 (Thu, 17 Feb 2022)
Log Message
Exclude new LocalStorage directory from backup on iOS
https://bugs.webkit.org/show_bug.cgi?id=236423
Reviewed by Chris Dumez.
We've been excluding LocalStorage data from backup on iOS since r212555, and we need to make sure this applies
to new LocalStorage directory after migration (r289878).
Manually tested on iOS device.
* NetworkProcess/storage/OriginStorageManager.cpp:
(WebKit::OriginStorageManager::StorageBucket::resolvedLocalStoragePath):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (290114 => 290115)
--- trunk/Source/WebKit/ChangeLog 2022-02-18 05:41:47 UTC (rev 290114)
+++ trunk/Source/WebKit/ChangeLog 2022-02-18 07:45:54 UTC (rev 290115)
@@ -1,3 +1,19 @@
+2022-02-17 Sihui Liu
+
+Exclude new LocalStorage directory from backup on iOS
+https://bugs.webkit.org/show_bug.cgi?id=236423
+
+
+Reviewed by Chris Dumez.
+
+We've been excluding LocalStorage data from backup on iOS since r212555, and we need to make sure this applies
+to new LocalStorage directory after migration (r289878).
+
+Manually tested on iOS device.
+
+* NetworkProcess/storage/OriginStorageManager.cpp:
+(WebKit::OriginStorageManager::StorageBucket::resolvedLocalStoragePath):
+
2022-02-17 Diego Pino Garcia
[GTK] Debian Stable build is broken after r290026
Modified: trunk/Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp (290114 => 290115)
--- trunk/Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp 2022-02-18 05:41:47 UTC (rev 290114)
+++ trunk/Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp 2022-02-18 07:45:54 UTC (rev 290115)
@@ -252,15 +252,18 @@
if (m_shouldUseCustomPaths) {
ASSERT(m_customLocalStoragePath.isEmpty() == m_rootPath.isEmpty());
m_resolvedLocalStoragePath = m_customLocalStoragePath;
-} else {
-auto localStoragePath = LocalStorageManager::localStorageFilePath(typeStoragePath(StorageType::LocalStorage));
-if (!m_customLocalStoragePath.isEmpty() && !FileSystem::fileExists(localStoragePath)) {
-FileSystem::makeAllDirectories(FileSystem::parentPath(localStoragePath));
+} else if (!m_rootPath.isEmpty()) {
+auto localStorageDirectory = typeStoragePath(StorageType::LocalStorage);
+FileSystem::makeAllDirectories(localStorageDirectory);
+FileSystem::excludeFromBackup(localStorageDirectory);
+
+auto localStoragePath = LocalStorageManager::localStorageFilePath(localStorageDirectory);
+if (!m_customLocalStoragePath.isEmpty() && !FileSystem::fileExists(localStoragePath))
WebCore::SQLiteFileSystem::moveDatabaseFile(m_customLocalStoragePath, localStoragePath);
-}
m_resolvedLocalStoragePath = localStoragePath;
-}
+} else
+m_resolvedLocalStoragePath = emptyString();
return m_resolvedLocalStoragePath;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290114] branches/safari-613.1.17.1-branch/Source/WTF/Scripts/Preferences/ WebPreferences.yaml
Title: [290114] branches/safari-613.1.17.1-branch/Source/WTF/Scripts/Preferences/WebPreferences.yaml Revision 290114 Author kocsen_ch...@apple.com Date 2022-02-17 21:41:47 -0800 (Thu, 17 Feb 2022) Log Message Apply patch. rdar://problem/89126114 Modified Paths branches/safari-613.1.17.1-branch/Source/WTF/Scripts/Preferences/WebPreferences.yaml Diff Modified: branches/safari-613.1.17.1-branch/Source/WTF/Scripts/Preferences/WebPreferences.yaml (290113 => 290114) --- branches/safari-613.1.17.1-branch/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2022-02-18 05:34:22 UTC (rev 290113) +++ branches/safari-613.1.17.1-branch/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2022-02-18 05:41:47 UTC (rev 290114) @@ -1606,11 +1606,11 @@ condition: ENABLE(NOTIFICATIONS) defaultValue: WebKitLegacy: - default: false + default: true WebKit: - default: false + default: true WebCore: - default: false + default: true OfflineWebApplicationCacheEnabled: type: bool ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290113] branches/safari-613.1.17.1-branch/Source
Title: [290113] branches/safari-613.1.17.1-branch/Source Revision 290113 Author kocsen_ch...@apple.com Date 2022-02-17 21:34:22 -0800 (Thu, 17 Feb 2022) Log Message Versioning. WebKit-7613.1.17.1.6 Modified Paths branches/safari-613.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.1.17.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (290112 => 290113) --- branches/safari-613.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-02-18 05:21:37 UTC (rev 290112) +++ branches/safari-613.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-02-18 05:34:22 UTC (rev 290113) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 1; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (290112 => 290113) --- branches/safari-613.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-02-18 05:21:37 UTC (rev 290112) +++ branches/safari-613.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-02-18 05:34:22 UTC (rev 290113) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 1; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (290112 => 290113) --- branches/safari-613.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-02-18 05:21:37 UTC (rev 290112) +++ branches/safari-613.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-02-18 05:34:22 UTC (rev 290113) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 1; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig (290112 => 290113) --- branches/safari-613.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-02-18 05:21:37 UTC (rev 290112) +++ branches/safari-613.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-02-18 05:34:22 UTC (rev 290113) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 1; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (290112 => 290113) --- branches/safari-613.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-02-18 05:21:37 UTC (rev 290112) +++ branches/safari-613.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-02-18 05:34:22 UTC (rev 290113) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 1; -NANO_VERSION = 5; +NANO_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.17.1-branch/Source/WebGPU/Configurations/Version.xcconfig (290112 => 290113) --- branches/safari-613.1.17.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-02-18 05:21:37 UTC (rev 290112) +++ branches/safari-613.1.17.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-02-18 05:34:22 UTC (rev 290113) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 17; MICRO_VERSION = 1; -NANO_VERSION = 5;
[webkit-changes] [290112] trunk/Source/WebCore
Title: [290112] trunk/Source/WebCore Revision 290112 Author pan...@apple.com Date 2022-02-17 21:21:37 -0800 (Thu, 17 Feb 2022) Log Message Web Inspector: [Flexbox] Add indicators for layout context in element tooltips https://bugs.webkit.org/show_bug.cgi?id=236738 Reviewed by Devin Rousso. * en.lproj/Localizable.strings: * inspector/InspectorOverlay.cpp: (WebCore::rendererIsFlexboxItem): (WebCore::rendererIsGridItem): (WebCore::InspectorOverlay::drawElementTitle): - Add new `Flex Item`, `Flex`, `Grid Item`, and `Grid` bubblea to element tooltips to allow provide more context about layout while selecting nodes on a page. - Move the role into its own bubble with special color (based on the previous coloring of the `Role` text). * inspector/InspectorOverlayLabel.cpp: (WebCore::InspectorOverlayLabel::draw): * inspector/InspectorOverlayLabel.h: (WebCore::InspectorOverlayLabel::Content::encode const): (WebCore::InspectorOverlayLabel::Content::decode): (WebCore::InspectorOverlayLabel::Content::Decoration::encode const): (WebCore::InspectorOverlayLabel::Content::Decoration::decode): - Add the concept of text decoration (currently just bordered text). - Create an intermediate `ComputedContentRun` to hold the intermediate representation of content with the computed attributes of each piece of text. This allows us to better scale with the addition of the new text decorations and other configuration properties instead of having to create even more Vectors of things that need to be kept in sync with each other. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/en.lproj/Localizable.strings trunk/Source/WebCore/inspector/InspectorOverlay.cpp trunk/Source/WebCore/inspector/InspectorOverlayLabel.cpp trunk/Source/WebCore/inspector/InspectorOverlayLabel.h Diff Modified: trunk/Source/WebCore/ChangeLog (290111 => 290112) --- trunk/Source/WebCore/ChangeLog 2022-02-18 04:52:02 UTC (rev 290111) +++ trunk/Source/WebCore/ChangeLog 2022-02-18 05:21:37 UTC (rev 290112) @@ -1,3 +1,32 @@ +2022-02-17 Patrick Angle + +Web Inspector: [Flexbox] Add indicators for layout context in element tooltips +https://bugs.webkit.org/show_bug.cgi?id=236738 + +Reviewed by Devin Rousso. + +* en.lproj/Localizable.strings: +* inspector/InspectorOverlay.cpp: +(WebCore::rendererIsFlexboxItem): +(WebCore::rendererIsGridItem): +(WebCore::InspectorOverlay::drawElementTitle): +- Add new `Flex Item`, `Flex`, `Grid Item`, and `Grid` bubblea to element tooltips to allow provide more +context about layout while selecting nodes on a page. +- Move the role into its own bubble with special color (based on the previous coloring of the `Role` text). + +* inspector/InspectorOverlayLabel.cpp: +(WebCore::InspectorOverlayLabel::draw): +* inspector/InspectorOverlayLabel.h: +(WebCore::InspectorOverlayLabel::Content::encode const): +(WebCore::InspectorOverlayLabel::Content::decode): +(WebCore::InspectorOverlayLabel::Content::Decoration::encode const): +(WebCore::InspectorOverlayLabel::Content::Decoration::decode): +- Add the concept of text decoration (currently just bordered text). +- Create an intermediate `ComputedContentRun` to hold the intermediate representation of content with the +computed attributes of each piece of text. This allows us to better scale with the addition of the new text +decorations and other configuration properties instead of having to create even more Vectors of things that need +to be kept in sync with each other. + 2022-02-17 Simon Fraser Crash under ScrollingCoordinatorMac::hasNodeWithAnimatedScrollChanged() Modified: trunk/Source/WebCore/en.lproj/Localizable.strings (290111 => 290112) --- trunk/Source/WebCore/en.lproj/Localizable.strings 2022-02-18 04:52:02 UTC (rev 290111) +++ trunk/Source/WebCore/en.lproj/Localizable.strings 2022-02-18 05:21:37 UTC (rev 290112) @@ -478,6 +478,12 @@ /* Default application name for Open With context menu */ "Finder" = "Finder"; +/* Inspector element selection tooltip text for Flexbox containers. */ +"Flex (Inspector Element Selection)" = "Flex"; + +/* Inspector element selection tooltip text for items inside a Flexbox Container. */ +"Flex Item (Inspector Element Selection)" = "Flex Item"; + /* Font context sub-menu item */ "Font" = "Font"; @@ -502,6 +508,12 @@ /* Google Safe Browsing */ "Google Safe Browsing" = "Google Safe Browsing"; +/* Inspector element selection tooltip text for Grid containers. */ +"Grid (Inspector Element Selection)" = "Grid"; + +/* Inspector element selection tooltip text for items inside a Grid Container. */ +"Grid Item (Inspector Element Selection)" = "Grid Item"; + /* accessibility role description for web area */ "HTML content" = "HTML content"; Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (290111 => 290112)
[webkit-changes] [290111] trunk/Source/WTF
Title: [290111] trunk/Source/WTF Revision 290111 Author commit-qu...@webkit.org Date 2022-02-17 20:52:02 -0800 (Thu, 17 Feb 2022) Log Message Enable subgrid by default. https://bugs.webkit.org/show_bug.cgi?id=236821 Patch by Matt Woodrow on 2022-02-17 Reviewed by Alan Bujtas. * Scripts/Preferences/WebPreferencesExperimental.yaml: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Diff Modified: trunk/Source/WTF/ChangeLog (290110 => 290111) --- trunk/Source/WTF/ChangeLog 2022-02-18 04:16:55 UTC (rev 290110) +++ trunk/Source/WTF/ChangeLog 2022-02-18 04:52:02 UTC (rev 290111) @@ -1,3 +1,12 @@ +2022-02-17 Matt Woodrow + +Enable subgrid by default. +https://bugs.webkit.org/show_bug.cgi?id=236821 + +Reviewed by Alan Bujtas. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: + 2022-02-17 Fujii Hironori GeneratePreferences.rb: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (290110 => 290111) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-02-18 04:16:55 UTC (rev 290110) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-02-18 04:52:02 UTC (rev 290111) @@ -1355,11 +1355,11 @@ humanReadableDescription: "Enable CSS subgrid support" defaultValue: WebKitLegacy: - default: false + default: true WebKit: - default: false + default: true WebCore: - default: false + default: true SyntheticEditingCommandsEnabled: type: bool ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290110] trunk/Source/bmalloc
Title: [290110] trunk/Source/bmalloc
Revision 290110
Author ysuz...@apple.com
Date 2022-02-17 20:16:55 -0800 (Thu, 17 Feb 2022)
Log Message
[libpas] scavenger should not call pthread_mach_thread_np after suspension
https://bugs.webkit.org/show_bug.cgi?id=236798
rdar://89020902
Reviewed by Mark Lam and Keith Miller.
pthread_mach_thread_np can take a lock internally. So we should not call it after suspending a thread.
This patch refactors libpas scavenger so that we call pthread_mach_thread_np before suspending a thread.
We also avoid calling pthread_self() after suspension to make suspending safer (while it does not take
a lock, it also depends on an internal implementation).
* libpas/src/libpas/pas_thread_local_cache.c:
(scavenger_thread_suspend_data_create):
(suspend):
(resume):
(stop_allocator):
(pas_thread_local_cache_for_all):
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c
Diff
Modified: trunk/Source/bmalloc/ChangeLog (290109 => 290110)
--- trunk/Source/bmalloc/ChangeLog 2022-02-18 03:55:27 UTC (rev 290109)
+++ trunk/Source/bmalloc/ChangeLog 2022-02-18 04:16:55 UTC (rev 290110)
@@ -1,5 +1,25 @@
2022-02-17 Yusuke Suzuki
+[libpas] scavenger should not call pthread_mach_thread_np after suspension
+https://bugs.webkit.org/show_bug.cgi?id=236798
+rdar://89020902
+
+Reviewed by Mark Lam and Keith Miller.
+
+pthread_mach_thread_np can take a lock internally. So we should not call it after suspending a thread.
+This patch refactors libpas scavenger so that we call pthread_mach_thread_np before suspending a thread.
+We also avoid calling pthread_self() after suspension to make suspending safer (while it does not take
+a lock, it also depends on an internal implementation).
+
+* libpas/src/libpas/pas_thread_local_cache.c:
+(scavenger_thread_suspend_data_create):
+(suspend):
+(resume):
+(stop_allocator):
+(pas_thread_local_cache_for_all):
+
+2022-02-17 Yusuke Suzuki
+
Unreviewed, fix heap enumeration
https://bugs.webkit.org/show_bug.cgi?id=236662
Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c (290109 => 290110)
--- trunk/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c 2022-02-18 03:55:27 UTC (rev 290109)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c 2022-02-18 04:16:55 UTC (rev 290110)
@@ -774,20 +774,35 @@
thread_local_cache, heap_lock_hold_mode, pas_segregated_deallocation_direct_mode);
}
+typedef struct scavenger_thread_suspend_data {
+bool did_suspend;
+bool is_scavenger_itself;
#if PAS_OS(DARWIN)
+mach_port_t mach_thread;
+#endif
+} scavenger_thread_suspend_data;
-static void suspend(pas_thread_local_cache* cache, bool* did_suspend)
+static scavenger_thread_suspend_data scavenger_thread_suspend_data_create()
{
+scavenger_thread_suspend_data thread_suspend_data;
+thread_suspend_data.did_suspend = false;
+thread_suspend_data.is_scavenger_itself = false;
+return thread_suspend_data;
+}
+
+#if PAS_OS(DARWIN)
+
+static void suspend(pas_thread_local_cache* cache, scavenger_thread_suspend_data* thread_suspend_data)
+{
static const bool verbose = false;
pthread_t thread;
-mach_port_t mach_thread;
kern_return_t result;
-if (*did_suspend)
+if (thread_suspend_data->did_suspend)
return;
-*did_suspend = true;
+thread_suspend_data->did_suspend = true;
if (verbose)
printf("Suspending TLC %p with thread %p.\n", cache, cache->thread);
@@ -795,11 +810,12 @@
thread = cache->thread;
PAS_ASSERT(thread);
-if (thread == pthread_self())
+thread_suspend_data->is_scavenger_itself = thread == pthread_self();
+if (thread_suspend_data->is_scavenger_itself)
return;
-mach_thread = pthread_mach_thread_np(thread);
-result = thread_suspend(mach_thread);
+thread_suspend_data->mach_thread = pthread_mach_thread_np(thread);
+result = thread_suspend(thread_suspend_data->mach_thread);
/* Fun fact: it's impossible for us to try to suspend a thread that has exited, since
thread exit for any thread with a TLC needs to grab the heap lock and we hold the
@@ -807,13 +823,13 @@
if (result != KERN_SUCCESS) {
pas_log("[%d] Failed to suspend pthread %p (mach thread %d) associated with TLC %p: %d\n",
-getpid(), thread, mach_thread, cache, result);
+getpid(), thread, thread_suspend_data->mach_thread, cache, result);
dump_thread_diagnostics(thread);
PAS_ASSERT(result == KERN_SUCCESS);
}
}
-static void resume(pas_thread_local_cache* cache)
+static void resume(pas_thread_local_cache* cache, scavenger_thread_suspend_data* thread_suspend_data)
{
static const bool verbose = false;
@@ -822,10 +838,10 @@
if
[webkit-changes] [290109] trunk/Source/WebCore
Title: [290109] trunk/Source/WebCore
Revision 290109
Author simon.fra...@apple.com
Date 2022-02-17 19:55:27 -0800 (Thu, 17 Feb 2022)
Log Message
Crash under ScrollingCoordinatorMac::hasNodeWithAnimatedScrollChanged()
https://bugs.webkit.org/show_bug.cgi?id=236810
Reviewed by Dean Jackson.
Crash data suggests that r288933 didn't fix the crash entirely.
Although the code paths I can find appear to hold the lock, there may be an
opportunity for m_scrollingCoordinator to get nulled out after we null-check it
but before the copy for the main thread dispatch.
So make a RefPtr on the stack, null-check it, and then move it into the callback.
* page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::reportSynchronousScrollingReasonsChanged):
(WebCore::ThreadedScrollingTree::reportExposedUnfilledArea):
(WebCore::ThreadedScrollingTree::currentSnapPointIndicesDidChange):
(WebCore::ThreadedScrollingTree::handleWheelEventPhase):
(WebCore::ThreadedScrollingTree::setActiveScrollSnapIndices):
(WebCore::ThreadedScrollingTree::hasNodeWithAnimatedScrollChanged):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (290108 => 290109)
--- trunk/Source/WebCore/ChangeLog 2022-02-18 03:46:49 UTC (rev 290108)
+++ trunk/Source/WebCore/ChangeLog 2022-02-18 03:55:27 UTC (rev 290109)
@@ -1,3 +1,27 @@
+2022-02-17 Simon Fraser
+
+Crash under ScrollingCoordinatorMac::hasNodeWithAnimatedScrollChanged()
+https://bugs.webkit.org/show_bug.cgi?id=236810
+
+
+Reviewed by Dean Jackson.
+
+Crash data suggests that r288933 didn't fix the crash entirely.
+
+Although the code paths I can find appear to hold the lock, there may be an
+opportunity for m_scrollingCoordinator to get nulled out after we null-check it
+but before the copy for the main thread dispatch.
+
+So make a RefPtr on the stack, null-check it, and then move it into the callback.
+
+* page/scrolling/ThreadedScrollingTree.cpp:
+(WebCore::ThreadedScrollingTree::reportSynchronousScrollingReasonsChanged):
+(WebCore::ThreadedScrollingTree::reportExposedUnfilledArea):
+(WebCore::ThreadedScrollingTree::currentSnapPointIndicesDidChange):
+(WebCore::ThreadedScrollingTree::handleWheelEventPhase):
+(WebCore::ThreadedScrollingTree::setActiveScrollSnapIndices):
+(WebCore::ThreadedScrollingTree::hasNodeWithAnimatedScrollChanged):
+
2022-02-17 Chris Dumez
Clean up / optimize call sites constructing vectors
Modified: trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp (290108 => 290109)
--- trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp 2022-02-18 03:46:49 UTC (rev 290108)
+++ trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp 2022-02-18 03:55:27 UTC (rev 290109)
@@ -283,7 +283,11 @@
void ThreadedScrollingTree::reportSynchronousScrollingReasonsChanged(MonotonicTime timestamp, OptionSet reasons)
{
-RunLoop::main().dispatch([scrollingCoordinator = m_scrollingCoordinator, timestamp, reasons] {
+auto scrollingCoordinator = m_scrollingCoordinator;
+if (!scrollingCoordinator)
+return;
+
+RunLoop::main().dispatch([scrollingCoordinator = WTFMove(scrollingCoordinator), timestamp, reasons] {
scrollingCoordinator->reportSynchronousScrollingReasonsChanged(timestamp, reasons);
});
}
@@ -290,7 +294,10 @@
void ThreadedScrollingTree::reportExposedUnfilledArea(MonotonicTime timestamp, unsigned unfilledArea)
{
-RunLoop::main().dispatch([scrollingCoordinator = m_scrollingCoordinator, timestamp, unfilledArea] {
+auto scrollingCoordinator = m_scrollingCoordinator;
+if (!scrollingCoordinator)
+return;
+RunLoop::main().dispatch([scrollingCoordinator = WTFMove(scrollingCoordinator), timestamp, unfilledArea] {
scrollingCoordinator->reportExposedUnfilledArea(timestamp, unfilledArea);
});
}
@@ -298,10 +305,11 @@
#if PLATFORM(COCOA)
void ThreadedScrollingTree::currentSnapPointIndicesDidChange(ScrollingNodeID nodeID, std::optional horizontal, std::optional vertical)
{
-if (!m_scrollingCoordinator)
+auto scrollingCoordinator = m_scrollingCoordinator;
+if (!scrollingCoordinator)
return;
-RunLoop::main().dispatch([scrollingCoordinator = m_scrollingCoordinator, nodeID, horizontal, vertical] {
+RunLoop::main().dispatch([scrollingCoordinator = WTFMove(scrollingCoordinator), nodeID, horizontal, vertical] {
scrollingCoordinator->setActiveScrollSnapIndices(nodeID, horizontal, vertical);
});
}
@@ -310,10 +318,11 @@
#if PLATFORM(MAC)
void ThreadedScrollingTree::handleWheelEventPhase(ScrollingNodeID nodeID, PlatformWheelEventPhase phase)
{
-if (!m_scrollingCoordinator)
+auto scrollingCoordinator = m_scrollingCoordinator;
+if (!scrollingCoordinator)
return;
-
[webkit-changes] [290108] trunk/Source
Title: [290108] trunk/Source
Revision 290108
Author cdu...@apple.com
Date 2022-02-17 19:46:49 -0800 (Thu, 17 Feb 2022)
Log Message
Clean up / optimize call sites constructing vectors
https://bugs.webkit.org/show_bug.cgi?id=236748
Reviewed by Darin Adler.
Follow-up to r290026 to address feedback from Darin.
Source/_javascript_Core:
* b3/air/AirCode.cpp:
(JSC::B3::Air::Code::setNumEntrypoints):
Source/WebCore:
* Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::updateKeyStatuses):
* Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::currentData):
* accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::setMathscripts):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readString):
* css/StyleProperties.cpp:
(WebCore::DeferredStyleProperties::DeferredStyleProperties):
* css/StyleRule.cpp:
(WebCore::DeferredStyleGroupRuleList::DeferredStyleGroupRuleList):
* dom/ElementData.cpp:
(WebCore::UniqueElementData::UniqueElementData):
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createFromSelection):
* page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::responseHeaders const):
* platform/encryptedmedia/CDMProxy.cpp:
(WebCore::KeyStore::convertToJSKeyStatusVector const):
* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
* platform/text/LocaleICU.cpp:
(WebCore::createFallbackMonthLabels):
* platform/text/LocaleNone.cpp:
(WebCore::LocaleNone::shortMonthLabels):
* platform/text/cocoa/LocaleCocoa.mm:
(WebCore::LocaleCocoa::monthLabels):
(WebCore::LocaleCocoa::shortMonthLabels):
(WebCore::LocaleCocoa::standAloneMonthLabels):
(WebCore::LocaleCocoa::shortStandAloneMonthLabels):
* testing/MockCDMFactory.cpp:
(WebCore::MockCDMInstanceSession::updateLicense):
(WebCore::MockCDMInstanceSession::removeSessionData):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/air/AirCode.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp
trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
trunk/Source/WebCore/css/StyleProperties.cpp
trunk/Source/WebCore/css/StyleRule.cpp
trunk/Source/WebCore/css/calc/CSSCalcValue.cpp
trunk/Source/WebCore/dom/ElementData.cpp
trunk/Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp
trunk/Source/WebCore/page/csp/ContentSecurityPolicy.cpp
trunk/Source/WebCore/platform/encryptedmedia/CDMProxy.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm
trunk/Source/WebCore/platform/text/LocaleICU.cpp
trunk/Source/WebCore/platform/text/LocaleNone.cpp
trunk/Source/WebCore/platform/text/cocoa/LocaleCocoa.mm
trunk/Source/WebCore/testing/MockCDMFactory.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (290107 => 290108)
--- trunk/Source/_javascript_Core/ChangeLog 2022-02-18 03:37:28 UTC (rev 290107)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-02-18 03:46:49 UTC (rev 290108)
@@ -1,3 +1,16 @@
+2022-02-17 Chris Dumez
+
+Clean up / optimize call sites constructing vectors
+https://bugs.webkit.org/show_bug.cgi?id=236748
+
+
+Reviewed by Darin Adler.
+
+Follow-up to r290026 to address feedback from Darin.
+
+* b3/air/AirCode.cpp:
+(JSC::B3::Air::Code::setNumEntrypoints):
+
2022-02-17 Mikhail R. Gadelha
[32bit] Increase fixedExecutableMemoryPoolSize on ARM to 32MB
Modified: trunk/Source/_javascript_Core/b3/air/AirCode.cpp (290107 => 290108)
--- trunk/Source/_javascript_Core/b3/air/AirCode.cpp 2022-02-18 03:37:28 UTC (rev 290107)
+++ trunk/Source/_javascript_Core/b3/air/AirCode.cpp 2022-02-18 03:46:49 UTC (rev 290108)
@@ -333,7 +333,7 @@
void Code::setNumEntrypoints(unsigned numEntryPoints)
{
-m_prologueGenerators = Vector { numEntryPoints, m_defaultPrologueGenerator.copyRef() };
+m_prologueGenerators = { numEntryPoints, m_defaultPrologueGenerator.copyRef() };
}
} } } // namespace JSC::B3::Air
Modified: trunk/Source/WebCore/ChangeLog (290107 => 290108)
--- trunk/Source/WebCore/ChangeLog 2022-02-18 03:37:28 UTC (rev 290107)
+++ trunk/Source/WebCore/ChangeLog 2022-02-18 03:46:49 UTC (rev 290108)
@@ -1,3 +1,48 @@
+2022-02-17 Chris Dumez
+
+Clean up / optimize call sites constructing vectors
+https://bugs.webkit.org/show_bug.cgi?id=236748
+
+
+Reviewed by Darin Adler.
+
+Follow-up to r290026 to address feedback from Darin.
+
+* Modules/encryptedmedia/MediaKeySession.cpp:
+(WebCore::MediaKeySession::updateKeyStatuses):
+* Modules/indexeddb/server/SQLiteIDBCursor.cpp:
+(WebCore::IDBServer::SQLiteIDBCursor::currentData):
+*
[webkit-changes] [290107] trunk/Source/WebCore
Title: [290107] trunk/Source/WebCore Revision 290107 Author dp...@igalia.com Date 2022-02-17 19:37:28 -0800 (Thu, 17 Feb 2022) Log Message [WPE] Unreviewed, fix non-unified build after r290089 * html/PDFDocument.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/PDFDocument.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (290106 => 290107) --- trunk/Source/WebCore/ChangeLog 2022-02-18 03:31:39 UTC (rev 290106) +++ trunk/Source/WebCore/ChangeLog 2022-02-18 03:37:28 UTC (rev 290107) @@ -1,3 +1,9 @@ +2022-02-17 Diego Pino Garcia + +[WPE] Unreviewed, fix non-unified build after r290089 + +* html/PDFDocument.cpp: + 2022-02-17 Alan Bujtas [LFC][IFC] 'vertical-align: bottom' makes inline level boxes stick out of their parent block box Modified: trunk/Source/WebCore/html/PDFDocument.cpp (290106 => 290107) --- trunk/Source/WebCore/html/PDFDocument.cpp 2022-02-18 03:31:39 UTC (rev 290106) +++ trunk/Source/WebCore/html/PDFDocument.cpp 2022-02-18 03:37:28 UTC (rev 290107) @@ -38,6 +38,7 @@ #include "HTMLNames.h" #include "HTMLScriptElement.h" #include "RawDataDocumentParser.h" +#include "ScriptController.h" #include "Settings.h" #include #include ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290106] trunk/Source/WebKit
Title: [290106] trunk/Source/WebKit
Revision 290106
Author dp...@igalia.com
Date 2022-02-17 19:31:39 -0800 (Thu, 17 Feb 2022)
Log Message
[GTK] Debian Stable build is broken after r290026
https://bugs.webkit.org/show_bug.cgi?id=236819
Unreviewed build fix.
* UIProcess/API/APIWebsitePolicies.cpp:
(API::WebsitePolicies::copy const):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (290105 => 290106)
--- trunk/Source/WebKit/ChangeLog 2022-02-18 02:51:32 UTC (rev 290105)
+++ trunk/Source/WebKit/ChangeLog 2022-02-18 03:31:39 UTC (rev 290106)
@@ -1,3 +1,13 @@
+2022-02-17 Diego Pino Garcia
+
+[GTK] Debian Stable build is broken after r290026
+https://bugs.webkit.org/show_bug.cgi?id=236819
+
+Unreviewed build fix.
+
+* UIProcess/API/APIWebsitePolicies.cpp:
+(API::WebsitePolicies::copy const):
+
2022-02-17 Kate Cheney
Refactor share menu item presentation
Modified: trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp (290105 => 290106)
--- trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp 2022-02-18 02:51:32 UTC (rev 290105)
+++ trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp 2022-02-18 03:31:39 UTC (rev 290106)
@@ -59,8 +59,8 @@
policies->setWebsiteDataStore(m_websiteDataStore.get());
policies->setUserContentController(m_userContentController.get());
policies->setIdempotentModeAutosizingOnlyHonorsPercentages(m_idempotentModeAutosizingOnlyHonorsPercentages);
-policies->setLegacyCustomHeaderFields(Vector { m_legacyCustomHeaderFields });
-policies->setCustomHeaderFields(Vector { m_customHeaderFields });
+policies->setLegacyCustomHeaderFields(Vector { m_legacyCustomHeaderFields });
+policies->setCustomHeaderFields(Vector { m_customHeaderFields });
policies->setAllowSiteSpecificQuirksToOverrideContentMode(m_allowSiteSpecificQuirksToOverrideContentMode);
policies->setApplicationNameForDesktopUserAgent(m_applicationNameForDesktopUserAgent);
policies->setAllowsContentJavaScript(m_allowsContentJavaScript);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290105] trunk
Title: [290105] trunk
Revision 290105
Author za...@apple.com
Date 2022-02-17 18:51:32 -0800 (Thu, 17 Feb 2022)
Log Message
[LFC][IFC] 'vertical-align: bottom' makes inline level boxes stick out of their parent block box
https://bugs.webkit.org/show_bug.cgi?id=236677
Reviewed by Antti Koivisto.
Source/WebCore:
'vertical-align: bottom' pushes the root inline box's baseline down as it stretches the line box downwards.
In most cases this makes the root inline box sit at the bottom of the line box e.g.
some text
forms a 100px tall block box where the "some text" sits at the bottom of the line and the tall image fills the rest of the line box all the way to the top.
Now if we add another inline level box with e.g. middle alignment.
some text
We still form a 100px tall block box where the "some text" content sits at the bottom and the middle aligned box stick out of the block box by about 40px (middle alignment -> 80px/2) as it is aligned based
on the root inline box's position (which is at the very bottom of the block container).
Instead the root inline box's baseline should be pull up to make room for the middle aligned image box.
This patch fixes this incorrect behavior by removing the line box relative alignment types from the regular alignment logic and offsetting the root inline box's baseline position at a later step.
What we do here is we simply compute the root inline box's baseline position as if there were no line box relative aligned boxes present and offset the final result if such box happens to stretch the line box.
(going back to the example: without the tall, bottom aligned image box, we compute the root inline box's baseline position to be around 40px to
ensure that the 80px image box fits and later we push it down to 60px (as the 100px image box stretches the line box by 20px).)
Test: fast/inline/vertical-align-bottom.html
* layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:
(WebCore::Layout::LineBoxVerticalAligner::computeLogicalHeightAndAlign const):
(WebCore::Layout::LineBoxVerticalAligner::computeLineBoxLogicalHeight const):
(WebCore::Layout::LineBoxVerticalAligner::computeRootInlineBoxVerticalPosition const):
* layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h:
(WebCore::Layout::LineBoxVerticalAligner::LineBoxHeight::value const):
LayoutTests:
* fast/inline/vertical-align-bottom-expected.html: Added.
* fast/inline/vertical-align-bottom.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h
Added Paths
trunk/LayoutTests/fast/inline/vertical-align-bottom-expected.html
trunk/LayoutTests/fast/inline/vertical-align-bottom.html
Diff
Modified: trunk/LayoutTests/ChangeLog (290104 => 290105)
--- trunk/LayoutTests/ChangeLog 2022-02-18 02:46:22 UTC (rev 290104)
+++ trunk/LayoutTests/ChangeLog 2022-02-18 02:51:32 UTC (rev 290105)
@@ -1,3 +1,13 @@
+2022-02-17 Alan Bujtas
+
+[LFC][IFC] 'vertical-align: bottom' makes inline level boxes stick out of their parent block box
+https://bugs.webkit.org/show_bug.cgi?id=236677
+
+Reviewed by Antti Koivisto.
+
+* fast/inline/vertical-align-bottom-expected.html: Added.
+* fast/inline/vertical-align-bottom.html: Added.
+
2022-02-17 Jon Lee
Unreviewed gardening for iOS GPU Process bots.
Added: trunk/LayoutTests/fast/inline/vertical-align-bottom-expected.html (0 => 290105)
--- trunk/LayoutTests/fast/inline/vertical-align-bottom-expected.html (rev 0)
+++ trunk/LayoutTests/fast/inline/vertical-align-bottom-expected.html 2022-02-18 02:51:32 UTC (rev 290105)
@@ -0,0 +1,15 @@
+
+
+div {
+ background-color: green;
+ width: 120px;
+ margin-bottom: 20px;
+}
+
+
+
+
+
+
+
+
\ No newline at end of file
Added: trunk/LayoutTests/fast/inline/vertical-align-bottom.html (0 => 290105)
--- trunk/LayoutTests/fast/inline/vertical-align-bottom.html (rev 0)
+++ trunk/LayoutTests/fast/inline/vertical-align-bottom.html 2022-02-18 02:51:32 UTC (rev 290105)
@@ -0,0 +1,42 @@
+
+
+.block {
+ background-color: green;
+ width: 120px;
+ margin-bottom: 20px;
+ color: transparent;
+ font-family: Ahem;
+ font-size: 20px;
+}
+
+.aligned-box {
+ display: inline-block;
+ background-color: green;
+ width: 50px;
+ height: 50px;
+}
+
+.non-lineBox-relative {
+ vertical-align: baseline;
+ width: 50px;
+ height: 20px;
+}
+
+.bottom {
+ vertical-align: bottom;
+
+ width: 50px;
+ height: 50px;
+}
+
+.top {
+ vertical-align: top;
+}
+
+
+XX
+XX
+XX
+XX
+XX
+XX
Modified: trunk/Source/WebCore/ChangeLog (290104 => 290105)
--- trunk/Source/WebCore/ChangeLog 2022-02-18 02:46:22 UTC (rev 290104)
+++ trunk/Source/WebCore/ChangeLog 2022-02-18 02:51:32 UTC (rev 290105)
@@
[webkit-changes] [290104] trunk/Source/WTF
Title: [290104] trunk/Source/WTF Revision 290104 Author hironori.fu...@sony.com Date 2022-02-17 18:46:22 -0800 (Thu, 17 Feb 2022) Log Message GeneratePreferences.rb: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated https://bugs.webkit.org/show_bug.cgi?id=236684 Reviewed by Yusuke Suzuki. With Ruby 3.1.0, GeneratePreferences.rb reported the following warnings. > GeneratePreferences.rb:235: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments. > GeneratePreferences.rb:235: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead. * Scripts/GeneratePreferences.rb: Changed to use the keyword argument for ERB.new. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/GeneratePreferences.rb Diff Modified: trunk/Source/WTF/ChangeLog (290103 => 290104) --- trunk/Source/WTF/ChangeLog 2022-02-18 02:31:16 UTC (rev 290103) +++ trunk/Source/WTF/ChangeLog 2022-02-18 02:46:22 UTC (rev 290104) @@ -1,3 +1,16 @@ +2022-02-17 Fujii Hironori + +GeneratePreferences.rb: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated +https://bugs.webkit.org/show_bug.cgi?id=236684 + +Reviewed by Yusuke Suzuki. + +With Ruby 3.1.0, GeneratePreferences.rb reported the following warnings. +> GeneratePreferences.rb:235: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments. +> GeneratePreferences.rb:235: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead. + +* Scripts/GeneratePreferences.rb: Changed to use the keyword argument for ERB.new. + 2022-02-17 Commit Queue Unreviewed, reverting r289974. Modified: trunk/Source/WTF/Scripts/GeneratePreferences.rb (290103 => 290104) --- trunk/Source/WTF/Scripts/GeneratePreferences.rb 2022-02-18 02:31:16 UTC (rev 290103) +++ trunk/Source/WTF/Scripts/GeneratePreferences.rb 2022-02-18 02:46:22 UTC (rev 290104) @@ -232,7 +232,7 @@ resultFile = File.join(outputDirectory, File.basename(templateFile, ".erb")) tempResultFile = resultFile + ".tmp" -output = ERB.new(File.read(templateFile), 0, "-").result(binding) +output = ERB.new(File.read(templateFile), trim_mode:"-").result(binding) File.open(tempResultFile, "w+") do |f| f.write(output) end ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290103] trunk/Source
Title: [290103] trunk/Source Revision 290103 Author katherine_che...@apple.com Date 2022-02-17 18:31:16 -0800 (Thu, 17 Feb 2022) Log Message Refactor share menu item presentation https://bugs.webkit.org/show_bug.cgi?id=236806 Reviewed by Aditya Keerthi. Source/WebCore: * page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate): Source/WebCore/PAL: * pal/spi/mac/NSSharingServicePickerSPI.h: Source/WebKit: * UIProcess/mac/WebContextMenuProxyMac.mm: (WebKit::WebContextMenuProxyMac::setupServicesMenu): (WebKit::WebContextMenuProxyMac::getShareMenuItem): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/mac/NSSharingServicePickerSPI.h trunk/Source/WebCore/page/ContextMenuController.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (290102 => 290103) --- trunk/Source/WebCore/ChangeLog 2022-02-18 01:56:28 UTC (rev 290102) +++ trunk/Source/WebCore/ChangeLog 2022-02-18 02:31:16 UTC (rev 290103) @@ -1,3 +1,14 @@ +2022-02-17 Kate Cheney + +Refactor share menu item presentation +https://bugs.webkit.org/show_bug.cgi?id=236806 + + +Reviewed by Aditya Keerthi. + +* page/ContextMenuController.cpp: +(WebCore::ContextMenuController::populate): + 2022-02-17 Aditya Keerthi '-webkit-user-select: all' is not respected in editable views Modified: trunk/Source/WebCore/PAL/ChangeLog (290102 => 290103) --- trunk/Source/WebCore/PAL/ChangeLog 2022-02-18 01:56:28 UTC (rev 290102) +++ trunk/Source/WebCore/PAL/ChangeLog 2022-02-18 02:31:16 UTC (rev 290103) @@ -1,3 +1,13 @@ +2022-02-17 Kate Cheney + +Refactor share menu item presentation +https://bugs.webkit.org/show_bug.cgi?id=236806 + + +Reviewed by Aditya Keerthi. + +* pal/spi/mac/NSSharingServicePickerSPI.h: + 2022-02-17 Jer Noble [Cocoa] Make AVFoundationSPI.h robust against changes in system headers Modified: trunk/Source/WebCore/PAL/pal/spi/mac/NSSharingServicePickerSPI.h (290102 => 290103) --- trunk/Source/WebCore/PAL/pal/spi/mac/NSSharingServicePickerSPI.h 2022-02-18 01:56:28 UTC (rev 290102) +++ trunk/Source/WebCore/PAL/pal/spi/mac/NSSharingServicePickerSPI.h 2022-02-18 02:31:16 UTC (rev 290103) @@ -27,6 +27,10 @@ #import +@interface NSSharingServicePicker (Staging_r88855017) +- (NSMenuItem *)standardShareMenuItem; +@end + #else #import @@ -40,6 +44,7 @@ @interface NSSharingServicePicker (Private) @property NSSharingServicePickerStyle style; +- (NSMenuItem *)standardShareMenuItem; - (NSMenu *)menu; - (void)getMenuWithCompletion:(void(^)(NSMenu *))completion; - (void)hide; Modified: trunk/Source/WebCore/page/ContextMenuController.cpp (290102 => 290103) --- trunk/Source/WebCore/page/ContextMenuController.cpp 2022-02-18 01:56:28 UTC (rev 290102) +++ trunk/Source/WebCore/page/ContextMenuController.cpp 2022-02-18 02:31:16 UTC (rev 290103) @@ -840,7 +840,7 @@ #if PLATFORM(GTK) || PLATFORM(WIN) ContextMenuItem ShareMenuItem; #else -ContextMenuItem ShareMenuItem(SubmenuType, ContextMenuItemTagShareMenu, emptyString()); +ContextMenuItem ShareMenuItem(ActionType, ContextMenuItemTagShareMenu, emptyString()); #endif #if ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS) Modified: trunk/Source/WebKit/ChangeLog (290102 => 290103) --- trunk/Source/WebKit/ChangeLog 2022-02-18 01:56:28 UTC (rev 290102) +++ trunk/Source/WebKit/ChangeLog 2022-02-18 02:31:16 UTC (rev 290103) @@ -1,3 +1,15 @@ +2022-02-17 Kate Cheney + +Refactor share menu item presentation +https://bugs.webkit.org/show_bug.cgi?id=236806 + + +Reviewed by Aditya Keerthi. + +* UIProcess/mac/WebContextMenuProxyMac.mm: +(WebKit::WebContextMenuProxyMac::setupServicesMenu): +(WebKit::WebContextMenuProxyMac::getShareMenuItem): + 2022-02-17 Aditya Keerthi '-webkit-user-select: all' is not respected in editable views Modified: trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm (290102 => 290103) --- trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm 2022-02-18 01:56:28 UTC (rev 290102) +++ trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm 2022-02-18 02:31:16 UTC (rev 290103) @@ -258,7 +258,10 @@ [[WKSharingServicePickerDelegate sharedSharingServicePickerDelegate] setSourceFrame:imageRect]; [[WKSharingServicePickerDelegate sharedSharingServicePickerDelegate] setAttachmentID:m_context.controlledImageAttachmentID()]; -m_menu = adoptNS([[picker menu] copy]); +if ([picker respondsToSelector:@selector(standardShareMenuItem)]) +m_menu = adoptNS([[[picker standardShareMenuItem] menu] copy]); +else +m_menu = adoptNS([[picker menu] copy]); if (!hasControlledImage) [m_menu setShowsStateColumn:YES]; @@ -405,6 +408,14 @@ return; }
[webkit-changes] [290102] trunk/LayoutTests
Title: [290102] trunk/LayoutTests Revision 290102 Author jon...@apple.com Date 2022-02-17 17:56:28 -0800 (Thu, 17 Feb 2022) Log Message LayoutTests/imported/w3c: Unreviewed gardening. Update fuzzy data. * web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-003.html: LayoutTests: Unreviewed gardening for iOS GPU Process bots. * TestExpectations: * gpu-process/TestExpectations: Triage remaining failures. * css3/masking/clip-path-border-radius-border-box-000.html: Add fuzzy data. * imported/blink/svg/paintorder/paintorder.svg: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/css3/masking/clip-path-border-radius-border-box-000.html trunk/LayoutTests/gpu-process/TestExpectations trunk/LayoutTests/imported/blink/svg/paintorder/paintorder.svg trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-003.html Diff Modified: trunk/LayoutTests/ChangeLog (290101 => 290102) --- trunk/LayoutTests/ChangeLog 2022-02-18 01:18:05 UTC (rev 290101) +++ trunk/LayoutTests/ChangeLog 2022-02-18 01:56:28 UTC (rev 290102) @@ -1,3 +1,13 @@ +2022-02-17 Jon Lee + +Unreviewed gardening for iOS GPU Process bots. + +* TestExpectations: +* gpu-process/TestExpectations: Triage remaining failures. + +* css3/masking/clip-path-border-radius-border-box-000.html: Add fuzzy data. +* imported/blink/svg/paintorder/paintorder.svg: + 2022-02-17 Aditya Keerthi '-webkit-user-select: all' is not respected in editable views Modified: trunk/LayoutTests/TestExpectations (290101 => 290102) --- trunk/LayoutTests/TestExpectations 2022-02-18 01:18:05 UTC (rev 290101) +++ trunk/LayoutTests/TestExpectations 2022-02-18 01:56:28 UTC (rev 290102) @@ -2106,8 +2106,7 @@ imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html [ Slow ] imported/w3c/web-platform-tests/webrtc/protocol/split.https.html [ Pass Failure ] -imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-relay-canvas.https.html [ Pass Failure ] -imported/w3c/web-platform-tests/webrtc/protocol/rtp-clockrate.html [ Pass Failure ] +imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-relay-canvas.https.html [ Failure ] # Skip timing out test imported/w3c/web-platform-tests/webrtc/RTCTrackEvent-fire.html [ Skip ] Modified: trunk/LayoutTests/css3/masking/clip-path-border-radius-border-box-000.html (290101 => 290102) --- trunk/LayoutTests/css3/masking/clip-path-border-radius-border-box-000.html 2022-02-18 01:18:05 UTC (rev 290101) +++ trunk/LayoutTests/css3/masking/clip-path-border-radius-border-box-000.html 2022-02-18 01:56:28 UTC (rev 290102) @@ -1,4 +1,5 @@ +
[webkit-changes] [290101] tags/Safari-614.1.3.4/
Title: [290101] tags/Safari-614.1.3.4/ Revision 290101 Author kocsen_ch...@apple.com Date 2022-02-17 17:18:05 -0800 (Thu, 17 Feb 2022) Log Message Tag Safari-614.1.3.4. Added Paths tags/Safari-614.1.3.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290100] tags/Safari-614.1.3.4/
Title: [290100] tags/Safari-614.1.3.4/ Revision 290100 Author kocsen_ch...@apple.com Date 2022-02-17 17:17:36 -0800 (Thu, 17 Feb 2022) Log Message Delete tag. Removed Paths tags/Safari-614.1.3.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290099] tags/Safari-614.1.3.4/
Title: [290099] tags/Safari-614.1.3.4/ Revision 290099 Author kocsen_ch...@apple.com Date 2022-02-17 17:10:56 -0800 (Thu, 17 Feb 2022) Log Message Tag Safari-614.1.3.4. Added Paths tags/Safari-614.1.3.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290098] trunk
Title: [290098] trunk Revision 290098 Author akeer...@apple.com Date 2022-02-17 17:03:50 -0800 (Thu, 17 Feb 2022) Log Message '-webkit-user-select: all' is not respected in editable views https://bugs.webkit.org/show_bug.cgi?id=190977 rdar://34945944 Reviewed by Wenson Hsieh. Source/WebCore: Original patch by Tim Horton. Currently, if the web view's editable bit is set to true, all nodes are made editable via a short circuit. However, the content of nodes with '-webkit-user-select: all' should not be editable. To fix, remove the short circuit and allow '-webkit-user-select' to take precedence. '-webkit-user-modify: read-only' and 'contenteditable=false' elements remain editable in editable web views. Tests: editing/editability/contenteditable-false-in-editable-view.html editing/editability/user-modify-read-only-in-editable-view.html editing/editability/user-select-all-in-editable-view.html * dom/Node.cpp: (WebCore::computeEditabilityFromComputedStyle): (WebCore::Node::computeEditability const): * html/HTMLElement.cpp: (WebCore::HTMLElement::editabilityFromContentEditableAttr): (WebCore::HTMLElement::matchesReadWritePseudoClass const): * html/HTMLElement.h: * page/Page.h: Source/WebKit: Add methods for testing the GTK port. * UIProcess/API/C/gtk/WKView.cpp: (WKViewSetEditable): * UIProcess/API/C/gtk/WKViewPrivate.h: * UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseSetEditable): * UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Tools: Add a UIScriptController method to make web views editable. Remove TestRunner::setWebViewEditable as it is unused. * DumpRenderTree/TestRunner.cpp: (TestRunner::staticFunctions): (setWebViewEditableCallback): Deleted. * DumpRenderTree/TestRunner.h: * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWebViewEditable): Deleted. * DumpRenderTree/mac/UIScriptControllerMac.h: * DumpRenderTree/mac/UIScriptControllerMac.mm: (WTR::UIScriptControllerMac::setWebViewEditable): * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::~TestRunner): (TestRunner::setWebViewEditable): Deleted. * DumpRenderTree/win/UIScriptControllerWin.cpp: (WTR::UIScriptControllerWin::setWebViewEditable): * DumpRenderTree/win/UIScriptControllerWin.h: * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.h: (WTR::UIScriptController::setWebViewEditable): * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::cocoaResetStateToConsistentValues): * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: (WTR::UIScriptControllerCocoa::setWebViewEditable): * WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::platformResetStateToConsistentValues): * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: (WTR::UIScriptControllerGtk::setWebViewEditable): * WebKitTestRunner/gtk/UIScriptControllerGtk.h: LayoutTests: Add tests to verify the behavior of `-[WKWebView _setEditable:]` with '-webkit-user-select: all', '-webkit-user-modify: none', and 'contenteditable=false'. Elements with '-webkit-user-select: all' should not be editable. * editing/editability/contenteditable-false-in-editable-view-expected.txt: Added. * editing/editability/contenteditable-false-in-editable-view.html: Added. * editing/editability/user-modify-read-only-in-editable-view-expected.txt: Added. * editing/editability/user-modify-read-only-in-editable-view.html: Added. * editing/editability/user-select-all-in-editable-view-expected.txt: Added. * editing/editability/user-select-all-in-editable-view.html: Added. * editing/input/ios/rtl-keyboard-input-on-focus-in-editable-page.html: Replace the test option with the new UIHelper method. * resources/ui-helper.js: (window.UIHelper.setWebViewEditable): Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/editing/input/ios/rtl-keyboard-input-on-focus-in-editable-page.html trunk/LayoutTests/resources/ui-helper.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/html/HTMLElement.cpp trunk/Source/WebCore/html/HTMLElement.h trunk/Source/WebCore/page/Page.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/C/gtk/WKView.cpp trunk/Source/WebKit/UIProcess/API/C/gtk/WKViewPrivate.h trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/TestRunner.cpp trunk/Tools/DumpRenderTree/TestRunner.h trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm trunk/Tools/DumpRenderTree/mac/UIScriptControllerMac.h trunk/Tools/DumpRenderTree/mac/UIScriptControllerMac.mm trunk/Tools/DumpRenderTree/win/TestRunnerWin.cpp trunk/Tools/DumpRenderTree/win/UIScriptControllerWin.cpp trunk/Tools/DumpRenderTree/win/UIScriptControllerWin.h trunk/Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
[webkit-changes] [290097] branches/safari-614.1.3-branch/Source
Title: [290097] branches/safari-614.1.3-branch/Source Revision 290097 Author kocsen_ch...@apple.com Date 2022-02-17 17:00:48 -0800 (Thu, 17 Feb 2022) Log Message Versioning. WebKit-7614.1.3.4 Modified Paths branches/safari-614.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-614.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-614.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-614.1.3-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-614.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-614.1.3-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-614.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-614.1.3-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-614.1.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-614.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (290096 => 290097) --- branches/safari-614.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-02-18 00:54:41 UTC (rev 290096) +++ branches/safari-614.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-02-18 01:00:48 UTC (rev 290097) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 3; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (290096 => 290097) --- branches/safari-614.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-02-18 00:54:41 UTC (rev 290096) +++ branches/safari-614.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-02-18 01:00:48 UTC (rev 290097) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 3; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (290096 => 290097) --- branches/safari-614.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-02-18 00:54:41 UTC (rev 290096) +++ branches/safari-614.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-02-18 01:00:48 UTC (rev 290097) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 3; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.3-branch/Source/WebCore/Configurations/Version.xcconfig (290096 => 290097) --- branches/safari-614.1.3-branch/Source/WebCore/Configurations/Version.xcconfig 2022-02-18 00:54:41 UTC (rev 290096) +++ branches/safari-614.1.3-branch/Source/WebCore/Configurations/Version.xcconfig 2022-02-18 01:00:48 UTC (rev 290097) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 3; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (290096 => 290097) --- branches/safari-614.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-02-18 00:54:41 UTC (rev 290096) +++ branches/safari-614.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-02-18 01:00:48 UTC (rev 290097) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 3; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.3-branch/Source/WebGPU/Configurations/Version.xcconfig (290096 => 290097) --- branches/safari-614.1.3-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-02-18 00:54:41 UTC (rev 290096) +++ branches/safari-614.1.3-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-02-18 01:00:48 UTC (rev 290097) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 3; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (290096 => 290097) --- branches/safari-614.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-02-18 00:54:41 UTC (rev 290096) +++ branches/safari-614.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-02-18 01:00:48 UTC (rev 290097) @@ -1,7 +1,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 3; -MICRO_VERSION = 3; +MICRO_VERSION = 4;
[webkit-changes] [290096] trunk
Title: [290096] trunk Revision 290096 Author commit-qu...@webkit.org Date 2022-02-17 16:54:41 -0800 (Thu, 17 Feb 2022) Log Message Account for subgrid MBP when sizing https://bugs.webkit.org/show_bug.cgi?id=236338 Patch by Matt Woodrow on 2022-02-17 Reviewed by Dean Jackson. LayoutTests/imported/w3c: * web-platform-tests/css/css-grid/subgrid/abs-pos-002-expected.html: * web-platform-tests/css/css-grid/subgrid/abs-pos-003-expected.html: * web-platform-tests/css/css-grid/subgrid/line-names-008.html: * web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-001.html: * web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-002.html: Source/WebCore: Adds extra margin to subgrid items participating in the sizing of an outer grid's tracks to account for the margin/border/padding of the intermediate subgrid item itself. Also contributes the subgrid's m/b/p to the edge tracks it cover, even if no inner items occupy that track. * rendering/GridLayoutFunctions.cpp: (WebCore::GridLayoutFunctions::directionFromSide): (WebCore::GridLayoutFunctions::hasRelativeOrIntrinsicSizeForChild): (WebCore::GridLayoutFunctions::extraMarginForSubgridChild): (WebCore::GridLayoutFunctions::gapDifferenceForSubgridChild): (WebCore::GridLayoutFunctions::marginLogicalSizeForChild): * rendering/GridTrackSizingAlgorithm.cpp: (WebCore::setOverridingContainingBlockContentSizeForChild): (WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const): (WebCore::GridTrackSizingAlgorithmStrategy::updateOverridingContainingBlockContentSizeForChild const): (WebCore::DefiniteSizeStrategy::minLogicalSizeForChild const): (WebCore::DefiniteSizeStrategy::minContentForChild const): (WebCore::addSubgridMarginBorderPadding): (WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrack): * rendering/RenderGrid.cpp: (WebCore::RenderGrid::isSubgrid const): (WebCore::RenderGrid::mayBeSubgridExcludingAbsPos const): (WebCore::RenderGrid::gridSpanCoversRealTracks const): (WebCore::RenderGrid::gridAreaBreadthForOutOfFlowChild): (WebCore::RenderGrid::computeContentPositionAndDistributionOffset): (WebCore::RenderGrid::gridSpanForChild const): * rendering/RenderGrid.h: * rendering/style/GridPositionsResolver.cpp: (WebCore::adjustGridPositionsFromStyle): LayoutTests: Account for subgrid MBP when sizing * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/abs-pos-002-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/abs-pos-003-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/line-names-008.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-002.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/GridLayoutFunctions.cpp trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp trunk/Source/WebCore/rendering/RenderGrid.cpp trunk/Source/WebCore/rendering/RenderGrid.h trunk/Source/WebCore/rendering/style/GridPositionsResolver.cpp Diff Modified: trunk/LayoutTests/ChangeLog (290095 => 290096) --- trunk/LayoutTests/ChangeLog 2022-02-18 00:53:20 UTC (rev 290095) +++ trunk/LayoutTests/ChangeLog 2022-02-18 00:54:41 UTC (rev 290096) @@ -1,5 +1,16 @@ 2022-02-17 Matt Woodrow +Account for subgrid MBP when sizing +https://bugs.webkit.org/show_bug.cgi?id=236338 + +Reviewed by Dean Jackson. + +Account for subgrid MBP when sizing + +* TestExpectations: + +2022-02-17 Matt Woodrow + Include sub grid items in the track sizing algorithm of the outer grid https://bugs.webkit.org/show_bug.cgi?id=236337 Modified: trunk/LayoutTests/TestExpectations (290095 => 290096) --- trunk/LayoutTests/TestExpectations 2022-02-18 00:53:20 UTC (rev 290095) +++ trunk/LayoutTests/TestExpectations 2022-02-18 00:54:41 UTC (rev 290096) @@ -1395,29 +1395,14 @@ imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-subgrid-002.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-grid/subgrid/auto-track-sizing-001.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-grid/subgrid/abs-pos-002.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-grid/subgrid/abs-pos-003.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-grid/subgrid/abs-pos-004.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-grid/subgrid/baseline-001.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-grid/subgrid/grid-gap-001.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-grid/subgrid/grid-gap-002.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-grid/subgrid/grid-gap-003.html [
[webkit-changes] [290095] tags/Safari-613.1.17.3.2/
Title: [290095] tags/Safari-613.1.17.3.2/ Revision 290095 Author kocsen_ch...@apple.com Date 2022-02-17 16:53:20 -0800 (Thu, 17 Feb 2022) Log Message Tag Safari-613.1.17.3.2. Added Paths tags/Safari-613.1.17.3.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290094] tags/Safari-613.1.17.2.2/
Title: [290094] tags/Safari-613.1.17.2.2/ Revision 290094 Author kocsen_ch...@apple.com Date 2022-02-17 16:53:14 -0800 (Thu, 17 Feb 2022) Log Message Tag Safari-613.1.17.2.2. Added Paths tags/Safari-613.1.17.2.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290093] tags/Safari-613.1.17.0.5/
Title: [290093] tags/Safari-613.1.17.0.5/ Revision 290093 Author kocsen_ch...@apple.com Date 2022-02-17 16:52:24 -0800 (Thu, 17 Feb 2022) Log Message Tag Safari-613.1.17.0.5. Added Paths tags/Safari-613.1.17.0.5/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290092] tags/Safari-613.1.17.1.5/
Title: [290092] tags/Safari-613.1.17.1.5/ Revision 290092 Author kocsen_ch...@apple.com Date 2022-02-17 16:45:03 -0800 (Thu, 17 Feb 2022) Log Message Tag Safari-613.1.17.1.5. Added Paths tags/Safari-613.1.17.1.5/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290091] trunk/Source/WebKit
Title: [290091] trunk/Source/WebKit
Revision 290091
Author drou...@apple.com
Date 2022-02-17 16:42:15 -0800 (Thu, 17 Feb 2022)
Log Message
[MacCatalyst] improve support for resizing
https://bugs.webkit.org/show_bug.cgi?id=236745
Reviewed by Tim Horton.
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView setFrame:]):
(-[WKWebView setBounds:]):
(-[WKWebView _acquireResizeAssertionForReason:]): Added.
Acquire a UIKit assertion whenever the `frame`/`bounds` of the `WKWebView` is changed that
is `invalidate` once the visible contect rect has been updated. UIKit can use this to know
both when WebKit is processing `WKWebView` resize changes and get notified once it's done.
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _doAfterNextVisibleContentRectUpdate:]): Added.
* UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
* UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView _doAfterNextVisibleContentRectUpdate:]): Deleted.
Allow this to be used outside of testing code (just like `-[WKWebView _doAfterNextPresentationUpdate:]`).
* Platform/spi/ios/UIKitSPI.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm
trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (290090 => 290091)
--- trunk/Source/WebKit/ChangeLog 2022-02-18 00:39:48 UTC (rev 290090)
+++ trunk/Source/WebKit/ChangeLog 2022-02-18 00:42:15 UTC (rev 290091)
@@ -1,3 +1,30 @@
+2022-02-17 Devin Rousso
+
+[MacCatalyst] improve support for resizing
+https://bugs.webkit.org/show_bug.cgi?id=236745
+
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/Cocoa/WKWebViewInternal.h:
+* UIProcess/API/ios/WKWebViewIOS.mm:
+(-[WKWebView setFrame:]):
+(-[WKWebView setBounds:]):
+(-[WKWebView _acquireResizeAssertionForReason:]): Added.
+Acquire a UIKit assertion whenever the `frame`/`bounds` of the `WKWebView` is changed that
+is `invalidate` once the visible contect rect has been updated. UIKit can use this to know
+both when WebKit is processing `WKWebView` resize changes and get notified once it's done.
+
+* UIProcess/API/Cocoa/WKWebViewPrivate.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _doAfterNextVisibleContentRectUpdate:]): Added.
+* UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
+* UIProcess/API/Cocoa/WKWebViewTesting.mm:
+(-[WKWebView _doAfterNextVisibleContentRectUpdate:]): Deleted.
+Allow this to be used outside of testing code (just like `-[WKWebView _doAfterNextPresentationUpdate:]`).
+
+* Platform/spi/ios/UIKitSPI.h:
+
2022-02-17 Simon Fraser
Move setting RemoteLayerBackingStore surfaces volatile into the GPU Process
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (290090 => 290091)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2022-02-18 00:39:48 UTC (rev 290090)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2022-02-18 00:42:15 UTC (rev 290091)
@@ -1537,6 +1537,22 @@
#endif
+#if HAVE(MAC_CATALYST_LIVE_RESIZE)
+
+#if __has_include()
+#include
+#else
+@protocol _UIInvalidatable
+- (void)_invalidate;
+@end
+#endif
+
+@interface UIWindowScene (Staging_86494115)
+- (id<_UIInvalidatable>)_holdLiveResizeSnapshotForReason:(NSString *)reason;
+@end
+
+#endif // HAVE(MAC_CATALYST_LIVE_RESIZE)
+
WTF_EXTERN_C_BEGIN
BOOL UIKeyboardEnabledInputModesAllowOneToManyShortcuts(void);
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (290090 => 290091)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2022-02-18 00:39:48 UTC (rev 290090)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2022-02-18 00:42:15 UTC (rev 290091)
@@ -3706,6 +3706,18 @@
[self _internalDoAfterNextPresentationUpdate:updateBlock withoutWaitingForPainting:YES withoutWaitingForAnimatedResize:NO];
}
+- (void)_doAfterNextVisibleContentRectUpdate:(void (^)(void))updateBlock
+{
+#if PLATFORM(IOS_FAMILY)
+_visibleContentRectUpdateCallbacks.append(makeBlockPtr(updateBlock));
+[self _scheduleVisibleContentRectUpdate];
+#else
+RunLoop::main().dispatch([updateBlock = makeBlockPtr(updateBlock)] {
+updateBlock();
+});
+#endif
+}
+
- (WKDisplayCaptureSurfaces) _displayCaptureSurfaces
{
auto pageState = _page->reportedMediaState();
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h (290090 => 290091)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h 2022-02-18 00:39:48 UTC (rev 290090)
+++
[webkit-changes] [290090] tags/Safari-614.1.3.3/
Title: [290090] tags/Safari-614.1.3.3/ Revision 290090 Author kocsen_ch...@apple.com Date 2022-02-17 16:39:48 -0800 (Thu, 17 Feb 2022) Log Message Tag Safari-614.1.3.3. Added Paths tags/Safari-614.1.3.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290089] trunk/Source/WebCore
Title: [290089] trunk/Source/WebCore
Revision 290089
Author j_pas...@apple.com
Date 2022-02-17 16:27:59 -0800 (Thu, 17 Feb 2022)
Log Message
PDF.js viewer should work for all kinds of URLs
https://bugs.webkit.org/show_bug.cgi?id=236525
rdar://problem/88832961
Reviewed by Tim Nguyen.
This patch starts loading the pdf as an array buffer after it's recieved
by calling the PDFJS viewer's open function through the content script's
wrapper. More work is needed to potentially present the data as a
PDFDataRangeTransport.
* Modules/pdfjs-extras/content-script.js:
(const.PDFJSContentScript.init):
(const.PDFJSContentScript.open):
* html/PDFDocument.cpp:
(WebCore::PDFDocumentEventListener::handleEvent):
(WebCore::PDFDocument::createDocumentStructure):
(WebCore::PDFDocument::updateDuringParsing):
(WebCore::PDFDocument::finishedParsing):
(WebCore::PDFDocument::sendPDFArrayBuffer):
(WebCore::PDFDocument::injectContentScript):
* html/PDFDocument.h:
(WebCore::PDFDocumentEventListener::handleEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/pdfjs-extras/content-script.js
trunk/Source/WebCore/html/PDFDocument.cpp
trunk/Source/WebCore/html/PDFDocument.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (290088 => 290089)
--- trunk/Source/WebCore/ChangeLog 2022-02-18 00:14:59 UTC (rev 290088)
+++ trunk/Source/WebCore/ChangeLog 2022-02-18 00:27:59 UTC (rev 290089)
@@ -1,3 +1,29 @@
+2022-02-17 J Pascoe
+
+PDF.js viewer should work for all kinds of URLs
+https://bugs.webkit.org/show_bug.cgi?id=236525
+rdar://problem/88832961
+
+Reviewed by Tim Nguyen.
+
+This patch starts loading the pdf as an array buffer after it's recieved
+by calling the PDFJS viewer's open function through the content script's
+wrapper. More work is needed to potentially present the data as a
+PDFDataRangeTransport.
+
+* Modules/pdfjs-extras/content-script.js:
+(const.PDFJSContentScript.init):
+(const.PDFJSContentScript.open):
+* html/PDFDocument.cpp:
+(WebCore::PDFDocumentEventListener::handleEvent):
+(WebCore::PDFDocument::createDocumentStructure):
+(WebCore::PDFDocument::updateDuringParsing):
+(WebCore::PDFDocument::finishedParsing):
+(WebCore::PDFDocument::sendPDFArrayBuffer):
+(WebCore::PDFDocument::injectContentScript):
+* html/PDFDocument.h:
+(WebCore::PDFDocumentEventListener::handleEvent):
+
2022-02-17 Chris Dumez
Pass registrable domain to CoreLocation API
Modified: trunk/Source/WebCore/Modules/pdfjs-extras/content-script.js (290088 => 290089)
--- trunk/Source/WebCore/Modules/pdfjs-extras/content-script.js 2022-02-18 00:14:59 UTC (rev 290088)
+++ trunk/Source/WebCore/Modules/pdfjs-extras/content-script.js 2022-02-18 00:27:59 UTC (rev 290089)
@@ -31,6 +31,9 @@
},
init() {
this.injectStyle();
+},
+open(data) {
+PDFViewerApplication.open(data);
}
};
Modified: trunk/Source/WebCore/html/PDFDocument.cpp (290088 => 290089)
--- trunk/Source/WebCore/html/PDFDocument.cpp 2022-02-18 00:14:59 UTC (rev 290088)
+++ trunk/Source/WebCore/html/PDFDocument.cpp 2022-02-18 00:27:59 UTC (rev 290089)
@@ -107,12 +107,14 @@
void PDFDocumentEventListener::handleEvent(ScriptExecutionContext&, Event& event)
{
-auto* iframe = dynamicDowncast(event.target());
-ASSERT(iframe, "Should have event target");
-
-if (event.type() == eventNames().loadEvent) {
-m_document->injectContentScript(*iframe->contentDocument());
-}
+if (is(event.target()) && event.type() == eventNames().loadEvent) {
+m_document->injectContentScript();
+} else if (is(event.target()) && event.type() == eventNames().loadEvent) {
+m_document->setContentScriptLoaded(true);
+if (m_document->isFinishedParsing())
+m_document->sendPDFArrayBuffer();
+} else
+ASSERT_NOT_REACHED();
}
bool PDFDocumentEventListener::operator==(const EventListener& other) const
@@ -135,6 +137,7 @@
void PDFDocument::createDocumentStructure()
{
+// The empty file parameter prevents default pdf from loading.
auto viewerURL = "webkit-pdfjs-viewer://pdfjs/web/viewer.html?file=";
auto rootElement = HTMLHtmlElement::create(*this);
appendChild(rootElement);
@@ -146,35 +149,68 @@
body->setAttribute(styleAttr, AtomString("margin: 0px;height: 100vh;", AtomString::ConstructFromLiteral));
rootElement->appendChild(body);
-auto iframe = HTMLIFrameElement::create(HTMLNames::iframeTag, *this);
-iframe->setAttribute(srcAttr, makeString(viewerURL, encodeWithURLEscapeSequences(url().string(;
-iframe->setAttribute(styleAttr, AtomString("width: 100%; height: 100%; border: 0; display: block;", AtomString::ConstructFromLiteral));
-body->appendChild(iframe);
+m_iframe = HTMLIFrameElement::create(HTMLNames::iframeTag, *this);
+
[webkit-changes] [290088] trunk/Source/WebCore
Title: [290088] trunk/Source/WebCore Revision 290088 Author cdu...@apple.com Date 2022-02-17 16:14:59 -0800 (Thu, 17 Feb 2022) Log Message Pass registrable domain to CoreLocation API https://bugs.webkit.org/show_bug.cgi?id=236803 Reviewed by Darin Adler. Pass registrable domain to CoreLocation API when the Geolocation API is used. Note that the code is guarded on a CL_HAS_RADAR_88834301 define from CoreLocation since the initWithWebsiteIdentifier is currently present in the SDK but not functional. * platform/cocoa/CoreLocationGeolocationProvider.mm: (-[WebCLLocationManager initWithWebsiteIdentifier:client:]): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/cocoa/CoreLocationGeolocationProvider.mm Diff Modified: trunk/Source/WebCore/ChangeLog (290087 => 290088) --- trunk/Source/WebCore/ChangeLog 2022-02-18 00:09:11 UTC (rev 290087) +++ trunk/Source/WebCore/ChangeLog 2022-02-18 00:14:59 UTC (rev 290088) @@ -1,3 +1,19 @@ +2022-02-17 Chris Dumez + +Pass registrable domain to CoreLocation API +https://bugs.webkit.org/show_bug.cgi?id=236803 + + +Reviewed by Darin Adler. + +Pass registrable domain to CoreLocation API when the Geolocation API is used. +Note that the code is guarded on a CL_HAS_RADAR_88834301 define from CoreLocation +since the initWithWebsiteIdentifier is currently present in the SDK but not +functional. + +* platform/cocoa/CoreLocationGeolocationProvider.mm: +(-[WebCLLocationManager initWithWebsiteIdentifier:client:]): + 2022-02-17 Cameron McCormack Always use ChildChange::Source::Parser when creating input element UA shadow tree contents Modified: trunk/Source/WebCore/platform/cocoa/CoreLocationGeolocationProvider.mm (290087 => 290088) --- trunk/Source/WebCore/platform/cocoa/CoreLocationGeolocationProvider.mm 2022-02-18 00:09:11 UTC (rev 290087) +++ trunk/Source/WebCore/platform/cocoa/CoreLocationGeolocationProvider.mm 2022-02-18 00:14:59 UTC (rev 290088) @@ -74,9 +74,14 @@ if (!self) return nil; -// FIXME: Call initWithWebsiteIdentifier and pass the websiteIdentifier when HAVE(CORE_LOCATION_WEBSITE_IDENTIFIERS) and !websiteIdentifier.isEmpty() once is fixed. +#if USE(APPLE_INTERNAL_SDK) && HAVE(CORE_LOCATION_WEBSITE_IDENTIFIERS) && defined(CL_HAS_RADAR_88834301) +if (!websiteIdentifier.isEmpty()) +_locationManager = adoptNS([allocCLLocationManagerInstance() initWithWebsiteIdentifier:websiteIdentifier]); +#else UNUSED_PARAM(websiteIdentifier); -_locationManager = adoptNS([allocCLLocationManagerInstance() init]); +#endif +if (!_locationManager) +_locationManager = adoptNS([allocCLLocationManagerInstance() init]); _client = _websiteIdentifier = websiteIdentifier; [_locationManager setDelegate:self]; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290087] trunk
Title: [290087] trunk Revision 290087 Author d...@apple.com Date 2022-02-17 16:09:11 -0800 (Thu, 17 Feb 2022) Log Message Source/ThirdParty/ANGLE: Metal ANGLE: vertex array does not correctly observe contents of data buffers https://bugs.webkit.org/show_bug.cgi?id=236733 Patch by Kyle Piddington on 2022-02-17 Reviewed by Dean Jackson. Similar to previous bug (236427), we were not correctly observing changes to the vertex buffer data. This caused us to miss rebinding vertex buffers when data was updated without causing conversion * src/libANGLE/renderer/metal/VertexArrayMtl.h: * src/libANGLE/renderer/metal/VertexArrayMtl.mm: (rx::VertexArrayMtl::syncState): (rx::VertexArrayMtl::setupDraw): (rx::VertexArrayMtl::syncDirtyAttrib): Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.h trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.mm Added Paths trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer-expected.txt trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer.html Diff Modified: trunk/LayoutTests/ChangeLog (290086 => 290087) --- trunk/LayoutTests/ChangeLog 2022-02-18 00:01:20 UTC (rev 290086) +++ trunk/LayoutTests/ChangeLog 2022-02-18 00:09:11 UTC (rev 290087) @@ -25,6 +25,22 @@ * platform/ios/TestExpectations: Mark tests as failing. +2022-02-17 Kyle Piddington + +Metal ANGLE: vertex array does not correctly observe contents of data buffers +https://bugs.webkit.org/show_bug.cgi?id=236733 + + + +Reviewed by Dean Jackson. + +Similar to previous bug (236427), we were not correctly observing changes to the +vertex buffer data. This caused us to miss rebinding vertex buffers +when data was updated without causing conversion + +* fast/canvas/webgl/buffer-data-subdata-dynamic-buffer.html: Added. +* fast/canvas/webgl/buffer-data-subdata-dynamic-buffer-expected.txt: Added. + 2022-02-17 Matteo Flores [css-grid] Incorrectly stretched SVGs without an aspect-ratio. Added: trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer-expected.txt (0 => 290087) --- trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer-expected.txt (rev 0) +++ trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer-expected.txt 2022-02-18 00:09:11 UTC (rev 290087) @@ -0,0 +1,14 @@ + Checks that update-draws of bufferSubData are respected + +PASS gl.getError() is gl.NO_ERROR +PASS gl.getError() is gl.NO_ERROR +PASS gl.getError() is gl.NO_ERROR +PASS gl.getError() is gl.NO_ERROR +PASS top-left of canvas should be green. +PASS bottom-left of canvas should be green. +PASS Top-right of canvas should be green. +PASS bottom-right of canvas should be green. +PASS successfullyParsed is true + +TEST COMPLETE + Property changes on: trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer-expected.txt ___ Added: svn:eol-style +native \ No newline at end of property Added: svn:keywords +Date Revision \ No newline at end of property Added: svn:mime-type +text/plain \ No newline at end of property Added: trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer.html (0 => 290087) --- trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer.html (rev 0) +++ trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer.html 2022-02-18 00:09:11 UTC (rev 290087) @@ -0,0 +1,96 @@ + + + + + + + + + +