[webkit-changes] [291603] trunk
Title: [291603] trunk
Revision 291603
Author ysuz...@apple.com
Date 2022-03-21 21:26:31 -0700 (Mon, 21 Mar 2022)
Log Message
[JSC] Change Date.parse to stop returning numbers with fractional part
https://bugs.webkit.org/show_bug.cgi?id=238050
Reviewed by Saam Barati.
JSTests:
* stress/date-parse-timeclip.js: Added.
(shouldBe):
Source/_javascript_Core:
Date.parse should return NaN or integer numbers[1,2]. This patch applies timeClip
to the result of Date.parse to ensure that the returned value is time value.
[1]: https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-date.parse
[2]: https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-time-values-and-time-range
* runtime/DateConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/DateConstructor.cpp
Added Paths
trunk/JSTests/stress/date-parse-timeclip.js
Diff
Modified: trunk/JSTests/ChangeLog (291602 => 291603)
--- trunk/JSTests/ChangeLog 2022-03-22 03:54:43 UTC (rev 291602)
+++ trunk/JSTests/ChangeLog 2022-03-22 04:26:31 UTC (rev 291603)
@@ -1,5 +1,15 @@
2022-03-21 Yusuke Suzuki
+[JSC] Change Date.parse to stop returning numbers with fractional part
+https://bugs.webkit.org/show_bug.cgi?id=238050
+
+Reviewed by Saam Barati.
+
+* stress/date-parse-timeclip.js: Added.
+(shouldBe):
+
+2022-03-21 Yusuke Suzuki
+
[JSC] ReferenceError when using extra parens in class fields
https://bugs.webkit.org/show_bug.cgi?id=236843
Added: trunk/JSTests/stress/date-parse-timeclip.js (0 => 291603)
--- trunk/JSTests/stress/date-parse-timeclip.js (rev 0)
+++ trunk/JSTests/stress/date-parse-timeclip.js 2022-03-22 04:26:31 UTC (rev 291603)
@@ -0,0 +1,22 @@
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error('bad value: ' + actual);
+}
+
+[
+"1970-01-01T00:00:00.00051Z",
+"1969-12-31T23:59:59.999515625Z",
+"1969-12-31T23:59:59.999015625Z",
+].forEach(str => {
+const tv = Date.parse(str);
+shouldBe(Object.is(tv, 0), true);
+shouldBe((new Date(str)).toISOString(), `1970-01-01T00:00:00.000Z`);
+});
+
+[
+0.51,
+-0.484375,
+-0.984375,
+].forEach(value => {
+shouldBe(new Date(value).valueOf(), 0);
+});
Modified: trunk/Source/_javascript_Core/ChangeLog (291602 => 291603)
--- trunk/Source/_javascript_Core/ChangeLog 2022-03-22 03:54:43 UTC (rev 291602)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-03-22 04:26:31 UTC (rev 291603)
@@ -1,3 +1,19 @@
+2022-03-21 Yusuke Suzuki
+
+[JSC] Change Date.parse to stop returning numbers with fractional part
+https://bugs.webkit.org/show_bug.cgi?id=238050
+
+Reviewed by Saam Barati.
+
+Date.parse should return NaN or integer numbers[1,2]. This patch applies timeClip
+to the result of Date.parse to ensure that the returned value is time value.
+
+[1]: https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-date.parse
+[2]: https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-time-values-and-time-range
+
+* runtime/DateConstructor.cpp:
+(JSC::JSC_DEFINE_HOST_FUNCTION):
+
2022-03-21 Saam Barati
Fix bug in Relationship::mergeImpl
Modified: trunk/Source/_javascript_Core/runtime/DateConstructor.cpp (291602 => 291603)
--- trunk/Source/_javascript_Core/runtime/DateConstructor.cpp 2022-03-22 03:54:43 UTC (rev 291602)
+++ trunk/Source/_javascript_Core/runtime/DateConstructor.cpp 2022-03-22 04:26:31 UTC (rev 291603)
@@ -159,7 +159,7 @@
auto scope = DECLARE_THROW_SCOPE(vm);
String dateStr = callFrame->argument(0).toWTFString(globalObject);
RETURN_IF_EXCEPTION(scope, encodedJSValue());
-RELEASE_AND_RETURN(scope, JSValue::encode(jsNumber(vm.dateCache.parseDate(globalObject, vm, dateStr;
+RELEASE_AND_RETURN(scope, JSValue::encode(jsNumber(timeClip(vm.dateCache.parseDate(globalObject, vm, dateStr);
}
JSValue dateNowImpl()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291602] trunk/Source/JavaScriptCore
Title: [291602] trunk/Source/_javascript_Core Revision 291602 Author sbar...@apple.com Date 2022-03-21 20:54:43 -0700 (Mon, 21 Mar 2022) Log Message Fix bug in Relationship::mergeImpl https://bugs.webkit.org/show_bug.cgi?id=238183 Reviewed by Yusuke Suzuki. * dfg/DFGIntegerRangeOptimizationPhase.cpp: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (291601 => 291602) --- trunk/Source/_javascript_Core/ChangeLog 2022-03-22 03:52:50 UTC (rev 291601) +++ trunk/Source/_javascript_Core/ChangeLog 2022-03-22 03:54:43 UTC (rev 291602) @@ -1,5 +1,15 @@ 2022-03-21 Saam Barati +Fix bug in Relationship::mergeImpl +https://bugs.webkit.org/show_bug.cgi?id=238183 + + +Reviewed by Yusuke Suzuki. + +* dfg/DFGIntegerRangeOptimizationPhase.cpp: + +2022-03-21 Saam Barati + AirFixObviousSpills needs to consider a PreIndex and PostIndex as clobbering the Reg used for indexing https://bugs.webkit.org/show_bug.cgi?id=238178 Modified: trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp (291601 => 291602) --- trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp 2022-03-22 03:52:50 UTC (rev 291601) +++ trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp 2022-03-22 03:54:43 UTC (rev 291602) @@ -749,6 +749,9 @@ // // @a < @b + max(C, D + 1) +if (sumOverflows(other.m_offset, 1)) +return Relationship(); + int bestOffset = std::max(m_offset, other.m_offset + 1); // We have something like @a < @b + 2. We can't do it. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291601] trunk/Source/JavaScriptCore
Title: [291601] trunk/Source/_javascript_Core
Revision 291601
Author sbar...@apple.com
Date 2022-03-21 20:52:50 -0700 (Mon, 21 Mar 2022)
Log Message
AirFixObviousSpills needs to consider a PreIndex and PostIndex as clobbering the Reg used for indexing
https://bugs.webkit.org/show_bug.cgi?id=238178
Reviewed by Mark Lam.
Inside AirFixObviousSpills, we run a basic alias analysis for StackSlots and
registers. For example, when we overwrite a register, we clear anything
it's aliased with. However, the way we were doing this was by looking at
each Arg that was Defd. However, this iteration was missing that
PostIndex/PreIndex mutate the register that feeds into the address Arg.
This patch fixes the issue by walking the instruction in such a way that
we visit all the Defs we care about, both Regs and StackSlots.
* b3/air/AirFixObviousSpills.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/air/AirFixObviousSpills.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (291600 => 291601)
--- trunk/Source/_javascript_Core/ChangeLog 2022-03-22 03:49:48 UTC (rev 291600)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-03-22 03:52:50 UTC (rev 291601)
@@ -1,3 +1,21 @@
+2022-03-21 Saam Barati
+
+AirFixObviousSpills needs to consider a PreIndex and PostIndex as clobbering the Reg used for indexing
+https://bugs.webkit.org/show_bug.cgi?id=238178
+
+
+Reviewed by Mark Lam.
+
+Inside AirFixObviousSpills, we run a basic alias analysis for StackSlots and
+registers. For example, when we overwrite a register, we clear anything
+it's aliased with. However, the way we were doing this was by looking at
+each Arg that was Defd. However, this iteration was missing that
+PostIndex/PreIndex mutate the register that feeds into the address Arg.
+This patch fixes the issue by walking the instruction in such a way that
+we visit all the Defs we care about, both Regs and StackSlots.
+
+* b3/air/AirFixObviousSpills.cpp:
+
2022-03-21 Yusuke Suzuki
[JSC] ReferenceError when using extra parens in class fields
Modified: trunk/Source/_javascript_Core/b3/air/AirFixObviousSpills.cpp (291600 => 291601)
--- trunk/Source/_javascript_Core/b3/air/AirFixObviousSpills.cpp 2022-03-22 03:49:48 UTC (rev 291600)
+++ trunk/Source/_javascript_Core/b3/air/AirFixObviousSpills.cpp 2022-03-22 03:52:50 UTC (rev 291601)
@@ -188,14 +188,20 @@
if (AirFixObviousSpillsInternal::verbose)
dataLog("Executing ", inst, ": ", m_state, "\n");
-Inst::forEachDefWithExtraClobberedRegs(
-, ,
-[&] (const Arg& arg, Arg::Role, Bank, Width) {
+Inst::forEachDefWithExtraClobberedRegs(, ,
+[&] (const Reg& reg, Arg::Role, Bank, Width) {
if (AirFixObviousSpillsInternal::verbose)
-dataLog("Clobbering ", arg, "\n");
-m_state.clobber(arg);
+dataLog("Clobbering ", reg, "\n");
+m_state.clobber(reg);
});
-
+
+Inst::forEachDef(, ,
+[&] (StackSlot* slot, Arg::Role, Bank, Width) {
+if (AirFixObviousSpillsInternal::verbose)
+dataLog("Clobbering ", *slot, "\n");
+m_state.clobber(slot);
+});
+
forAllAliases(
[&] (const auto& alias) {
m_state.addAlias(alias);
@@ -558,31 +564,30 @@
return std::nullopt;
}
-void clobber(const Arg& arg)
+void clobber(const Reg& reg)
{
-if (arg.isReg()) {
-regConst.removeAllMatching(
-[&] (const RegConst& alias) -> bool {
-return alias.reg == arg.reg();
-});
-regSlot.removeAllMatching(
-[&] (const RegSlot& alias) -> bool {
-return alias.reg == arg.reg();
-});
-return;
-}
-if (arg.isStack()) {
-slotConst.removeAllMatching(
-[&] (const SlotConst& alias) -> bool {
-return alias.slot == arg.stackSlot();
-});
-regSlot.removeAllMatching(
-[&] (const RegSlot& alias) -> bool {
-return alias.slot == arg.stackSlot();
-});
-}
+regConst.removeAllMatching(
+[&] (const RegConst& alias) -> bool {
+return alias.reg == reg;
+});
+regSlot.removeAllMatching(
+[&] (const RegSlot& alias) -> bool {
+return alias.reg == reg;
+});
}
+void clobber(StackSlot* slot)
+{
+slotConst.removeAllMatching(
[webkit-changes] [291600] trunk
Title: [291600] trunk Revision 291600 Author tyle...@apple.com Date 2022-03-21 20:49:48 -0700 (Mon, 21 Mar 2022) Log Message AX: AccessibilityObject::visibleCharacterRange is extremely slow when called on objects with lots of text https://bugs.webkit.org/show_bug.cgi?id=237678 Reviewed by Andres Gonzalez. Source/WebCore: AccessibilityObject::visibleCharacterRange is extremely slow when called on objects with lots of text. For example, trying to enter a large contenteditable element with VoiceOver causes "Safari not responding" because WebKit is so slow to return this data. This patch fixes this in two ways. First, we optimize computation of the end boundary point by grabbing previous line start positions in batches and binary searching within each batch to find the correct value. I tried to apply this algorithm to the computation of the start boundary, but that regressed performance for small and medium text objects, and didn't yield any noticeable improvement for large text objects. Keeping start boundary computation as-is while changing the end boundary computation provided the best performance at all text sizes. Second, this patch caches visibleCharacterRange results, as the same inputs to this function will always yield the same output. It's common for this data to be requested multiple times without any change in page state (e.g. scrolling), so caching further improves performance by a lot. Additional testcases added to accessibility/visible-character-range.html to ensure behavior is correct. * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::previousLineStartBoundaryPoints const): Added. (WebCore::AccessibilityObject::lastBoundaryPointContainedInRect const): Added. (WebCore::AccessibilityObject::boundaryPointsContainedInRect const): Added. (WebCore::AccessibilityObject::visibleCharacterRange const): Wraps visibleCharacterRangeInternal to handle caching. (WebCore::AccessibilityObject::visibleCharacterRangeInternal const): (WebCore::AccessibilityObject::previousLineStartPositionInternal const): Added. (WebCore::AccessibilityObject::previousLineStartPosition const): Wraps previousLineStartPositionInternal to return default VisualPosition if it returns std::nullopt (existing callers expect this behavior) * accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::lastBoundaryPointContainedInRect const): Added. * dom/BoundaryPoint.cpp: (WebCore::operator<<): * dom/BoundaryPoint.h: Added implementation of operator<< to make debugging boundary points easier. LayoutTests: Add many new visible character range testcases split across four new tests. * accessibility/visible-character-range-basic.html: Added. * accessibility/visible-character-range-height-changes.html: Added. * accessibility/visible-character-range-scrolling.html: Added. * accessibility/visible-character-range-width-changes.html: Added. * platform/glib/TestExpectations: Skip new tests. * platform/ios-simulator-wk2/TestExpectations: Mark new tests as crashing since the old test was crashing in `main`. * platform/ios/TestExpectations: Enable new tests. * platform/ios/accessibility/visible-character-range-basic-expected.txt: Added. * platform/ios/accessibility/visible-character-range-expected.txt: Removed. * platform/ios/accessibility/visible-character-range-height-changes-expected.txt: Added. * platform/ios/accessibility/visible-character-range-scrolling-expected.txt: Added. * platform/ios/accessibility/visible-character-range-width-changes-expected.txt: Added. * platform/mac-wk1/TestExpectations: Skip new tests. * platform/mac/accessibility/visible-character-range-basic-expected.txt: Added. * platform/mac/accessibility/visible-character-range-expected.txt: Removed. * platform/mac/accessibility/visible-character-range-height-changes-expected.txt: Added. * platform/mac/accessibility/visible-character-range-scrolling-expected.txt: Added. * platform/mac/accessibility/visible-character-range-width-changes-expected.txt: Added. * platform/win/TestExpectations: Skip new tests. * resources/accessibility-helper.js: (visibleRange): Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/LayoutTests/platform/win/TestExpectations trunk/LayoutTests/resources/accessibility-helper.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityObject.cpp trunk/Source/WebCore/accessibility/AccessibilityObject.h trunk/Source/WebCore/dom/BoundaryPoint.cpp trunk/Source/WebCore/dom/BoundaryPoint.h Added Paths trunk/LayoutTests/accessibility/visible-character-range-basic.html trunk/LayoutTests/accessibility/visible-character-range-height-changes.html trunk/LayoutTests/accessibility/visible-character-range-scrolling.html
[webkit-changes] [291599] trunk/Source/WebKit
Title: [291599] trunk/Source/WebKit Revision 291599 Author simon.fra...@apple.com Date 2022-03-21 20:33:18 -0700 (Mon, 21 Mar 2022) Log Message Do all RemoteLayerBackingStore buffer swapping in one batch https://bugs.webkit.org/show_bug.cgi?id=238161 Reviewed by Tim Horton. Previously, RemoteLayerBackingStore buffer swapping happened per-layer in PlatformCALayerRemote::recursiveBuildTransaction(). To prepare for a single IPC for all buffer swapping, batch all the swapping under prepareBackingStoresForDisplay() which is called from RemoteLayerTreeContext::buildTransaction(). RemoteLayerBackingStoreCollection tracks m_backingStoresNeedingDisplay, and RemoteLayerBackingStore implements needsDisplay() so we only add backing stores to this hash set that need any buffer swapping. * Shared/RemoteLayerTree/RemoteLayerBackingStore.h: * Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: (WebKit::RemoteLayerBackingStore::layerWillBeDisplayed): (WebKit::RemoteLayerBackingStore::needsDisplay const): (WebKit::RemoteLayerBackingStore::prepareToDisplay): (WebKit::RemoteLayerBackingStore::paintContents): (WebKit::RemoteLayerBackingStore::takePendingFlushers): * Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h: * Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm: (WebKit::RemoteLayerBackingStoreCollection::backingStoreNeedsDisplay): (WebKit::RemoteLayerBackingStoreCollection::prepareBackingStoresForDisplay): (WebKit::RemoteLayerBackingStoreCollection::paintReachableBackingStoreContents): (WebKit::RemoteLayerBackingStoreCollection::willFlushLayers): (WebKit::RemoteLayerBackingStoreCollection::backingStoreWillBeDisplayed): * Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.h: * Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm: (WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::backingStoreNeedsDisplay): (WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::prepareBackingStoreBuffers): * WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp: (WebKit::PlatformCALayerRemote::recursiveBuildTransaction): * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm: (WebKit::RemoteLayerTreeContext::buildTransaction): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.h trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm Diff Modified: trunk/Source/WebKit/ChangeLog (291598 => 291599) --- trunk/Source/WebKit/ChangeLog 2022-03-22 03:28:05 UTC (rev 291598) +++ trunk/Source/WebKit/ChangeLog 2022-03-22 03:33:18 UTC (rev 291599) @@ -1,3 +1,44 @@ +2022-03-21 Simon Fraser + +Do all RemoteLayerBackingStore buffer swapping in one batch +https://bugs.webkit.org/show_bug.cgi?id=238161 + +Reviewed by Tim Horton. + +Previously, RemoteLayerBackingStore buffer swapping happened per-layer in +PlatformCALayerRemote::recursiveBuildTransaction(). + +To prepare for a single IPC for all buffer swapping, batch all the swapping under +prepareBackingStoresForDisplay() which is called from +RemoteLayerTreeContext::buildTransaction(). + +RemoteLayerBackingStoreCollection tracks m_backingStoresNeedingDisplay, and +RemoteLayerBackingStore implements needsDisplay() so we only add backing stores to this hash +set that need any buffer swapping. + +* Shared/RemoteLayerTree/RemoteLayerBackingStore.h: +* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: +(WebKit::RemoteLayerBackingStore::layerWillBeDisplayed): +(WebKit::RemoteLayerBackingStore::needsDisplay const): +(WebKit::RemoteLayerBackingStore::prepareToDisplay): +(WebKit::RemoteLayerBackingStore::paintContents): +(WebKit::RemoteLayerBackingStore::takePendingFlushers): +* Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h: +* Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm: +(WebKit::RemoteLayerBackingStoreCollection::backingStoreNeedsDisplay): +(WebKit::RemoteLayerBackingStoreCollection::prepareBackingStoresForDisplay): +(WebKit::RemoteLayerBackingStoreCollection::paintReachableBackingStoreContents): +(WebKit::RemoteLayerBackingStoreCollection::willFlushLayers): +(WebKit::RemoteLayerBackingStoreCollection::backingStoreWillBeDisplayed): +*
[webkit-changes] [291598] trunk/Source/WebKit
Title: [291598] trunk/Source/WebKit
Revision 291598
Author achristen...@apple.com
Date 2022-03-21 20:28:05 -0700 (Mon, 21 Mar 2022)
Log Message
Adjust when _setPrivacyProxyFailClosedForUnreachableNonMainHosts is called
https://bugs.webkit.org/show_bug.cgi?id=237735
Reviewed by Geoff Garen.
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(WebKit::NetworkSessionCocoa::createWebSocketTask):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (291597 => 291598)
--- trunk/Source/WebKit/ChangeLog 2022-03-22 03:22:44 UTC (rev 291597)
+++ trunk/Source/WebKit/ChangeLog 2022-03-22 03:28:05 UTC (rev 291598)
@@ -1,3 +1,16 @@
+2022-03-21 Alex Christensen
+
+Adjust when _setPrivacyProxyFailClosedForUnreachableNonMainHosts is called
+https://bugs.webkit.org/show_bug.cgi?id=237735
+
+Reviewed by Geoff Garen.
+
+* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
+(WebKit::NetworkSessionCocoa::createWebSocketTask):
+
2022-03-21 Aditya Keerthi
Unreviewed, address post-landing feedback on r291445
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (291597 => 291598)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-03-22 03:22:44 UTC (rev 291597)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-03-22 03:28:05 UTC (rev 291598)
@@ -340,6 +340,14 @@
RetainPtr nsRequest = request.nsURLRequest(WebCore::HTTPBodyUpdatePolicy::UpdateHTTPBody);
RetainPtr mutableRequest = adoptNS([nsRequest.get() mutableCopy]);
+if (parameters.isMainFrameNavigation
+|| parameters.hadMainFrameMainResourcePrivateRelayed // This means it did not fail. FIXME: adjust names to reflect this.
+|| !parameters.topOrigin
+|| request.url().host() == parameters.topOrigin->host()) {
+if ([mutableRequest respondsToSelector:@selector(_setPrivacyProxyFailClosedForUnreachableNonMainHosts:)])
+[mutableRequest _setPrivacyProxyFailClosedForUnreachableNonMainHosts:YES];
+}
+
#if ENABLE(APP_PRIVACY_REPORT)
mutableRequest.get().attribution = request.isAppInitiated() ? NSURLRequestAttributionDeveloper : NSURLRequestAttributionUser;
#endif
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (291597 => 291598)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-03-22 03:22:44 UTC (rev 291597)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-03-22 03:28:05 UTC (rev 291598)
@@ -931,7 +931,7 @@
NSURLSessionTaskTransactionMetrics *metrics = taskMetrics.transactionMetrics.lastObject;
#if HAVE(NETWORK_CONNECTION_PRIVACY_STANCE)
-auto privateRelayed = metrics._privacyStance == nw_connection_privacy_stance_direct ? PrivateRelayed::No : PrivateRelayed::Yes;
+auto privateRelayed = metrics._privacyStance == nw_connection_privacy_stance_failed ? PrivateRelayed::No : PrivateRelayed::Yes;
#else
auto privateRelayed = PrivateRelayed::No;
#endif
@@ -1717,6 +1717,17 @@
appPrivacyReportTestingData().didLoadAppInitiatedRequest(nsRequest.get().attribution == NSURLRequestAttributionDeveloper);
#endif
+// FIXME: This function can make up to 3 copies of a request.
+// Reduce that to one if the protocol is null, the request isn't app initiated,
+// or the main frame main resource was private relayed, then set all properties
+// on the one copy.
+if (hadMainFrameMainResourcePrivateRelayed || request.url().host() == clientOrigin.topOrigin.host) {
+RetainPtr mutableRequest = adoptNS([nsRequest.get() mutableCopy]);
+if ([mutableRequest respondsToSelector:@selector(_setPrivacyProxyFailClosedForUnreachableNonMainHosts:)])
+[mutableRequest _setPrivacyProxyFailClosedForUnreachableNonMainHosts:YES];
+nsRequest = WTFMove(mutableRequest);
+}
+
auto& sessionSet = sessionSetForPage(webPageProxyID);
RetainPtr task = [sessionSet.sessionWithCredentialStorage.session webSocketTaskWithRequest:nsRequest.get()];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291597] trunk
Title: [291597] trunk Revision 291597 Author commit-qu...@webkit.org Date 2022-03-21 20:22:44 -0700 (Mon, 21 Mar 2022) Log Message Implement CSSNumericValue.mul, div, add, sub, max, and min https://bugs.webkit.org/show_bug.cgi?id=238153 Patch by Alex Christensen on 2022-03-21 Reviewed by Simon Fraser. LayoutTests/imported/w3c: * web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/arithmetic.tentative-expected.txt: Source/WebCore: This implements all except the derived units of multiplication and the unit checking of the others. They are an off-by-default experimental feature right now, part of css-typed-om which is being implemented. They are covered by wpt tests. * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSCSSStyleValueCustom.cpp: (WebCore::toJSNewlyCreated): * css/typedom/CSSKeywordValue.h: (WebCore::CSSKeywordValue::value const): Deleted. (WebCore::CSSKeywordValue::CSSKeywordValue): Deleted. * css/typedom/CSSNumericValue.cpp: (WebCore::negate): (WebCore::invert): (WebCore::operationOnValuesOfSameUnit): (WebCore::CSSNumericValue::prependItemsOfTypeOrThis): (WebCore::CSSNumericValue::addInternal): (WebCore::CSSNumericValue::add): (WebCore::CSSNumericValue::sub): (WebCore::CSSNumericValue::multiplyInternal): (WebCore::CSSNumericValue::mul): (WebCore::CSSNumericValue::div): (WebCore::CSSNumericValue::min): (WebCore::CSSNumericValue::max): (WebCore::CSSNumericValue::rectifyNumberish): (WebCore::CSSNumericValue::toSum): * css/typedom/CSSNumericValue.h: (isType): * css/typedom/CSSStyleValue.h: (WebCore::isCSSNumericValue): (WebCore::isCSSMathValue): * css/typedom/CSSUnitValue.h: (isType): * css/typedom/numeric/CSSMathInvert.cpp: (WebCore::CSSMathInvert::CSSMathInvert): * css/typedom/numeric/CSSMathInvert.h: (isType): (WebCore::CSSMathInvert::value const): Deleted. * css/typedom/numeric/CSSMathMax.cpp: (WebCore::CSSMathMax::CSSMathMax): (WebCore::CSSMathMax::create): Deleted. * css/typedom/numeric/CSSMathMax.h: (isType): * css/typedom/numeric/CSSMathMin.cpp: (WebCore::CSSMathMin::CSSMathMin): (WebCore::CSSMathMin::create): Deleted. * css/typedom/numeric/CSSMathMin.h: (isType): * css/typedom/numeric/CSSMathNegate.cpp: (WebCore::CSSMathNegate::CSSMathNegate): (WebCore::CSSMathNegate::create): Deleted. * css/typedom/numeric/CSSMathNegate.h: (isType): (WebCore::CSSMathNegate::value const): Deleted. * css/typedom/numeric/CSSMathProduct.cpp: (WebCore::CSSMathProduct::CSSMathProduct): (WebCore::CSSMathProduct::create): Deleted. * css/typedom/numeric/CSSMathProduct.h: (isType): * css/typedom/numeric/CSSMathSum.cpp: (WebCore::CSSMathSum::CSSMathSum): (WebCore::CSSMathSum::create): Deleted. (WebCore::CSSMathSum::values const): Deleted. * css/typedom/numeric/CSSMathSum.h: (isType): * css/typedom/numeric/CSSMathValue.cpp: Removed. * css/typedom/numeric/CSSMathValue.h: (WebCore::CSSMathValue::getOperator const): Deleted. (): Deleted. (isType): Deleted. * css/typedom/numeric/CSSNumericArray.cpp: (WebCore::CSSNumericArray::create): (WebCore::CSSNumericArray::CSSNumericArray): * css/typedom/numeric/CSSNumericArray.h: (WebCore::CSSNumericArray::array const): * css/typedom/numeric/CSSNumericType.h: * css/typedom/transform/CSSTransformValue.h: (WebCore::CSSTransformValue::length const): Deleted. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/arithmetic.tentative-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/JSCSSStyleValueCustom.cpp trunk/Source/WebCore/css/typedom/CSSKeywordValue.h trunk/Source/WebCore/css/typedom/CSSNumericValue.cpp trunk/Source/WebCore/css/typedom/CSSNumericValue.h trunk/Source/WebCore/css/typedom/CSSStyleValue.h trunk/Source/WebCore/css/typedom/CSSUnitValue.h trunk/Source/WebCore/css/typedom/numeric/CSSMathInvert.cpp trunk/Source/WebCore/css/typedom/numeric/CSSMathInvert.h trunk/Source/WebCore/css/typedom/numeric/CSSMathMax.cpp trunk/Source/WebCore/css/typedom/numeric/CSSMathMax.h trunk/Source/WebCore/css/typedom/numeric/CSSMathMin.cpp trunk/Source/WebCore/css/typedom/numeric/CSSMathMin.h trunk/Source/WebCore/css/typedom/numeric/CSSMathNegate.cpp trunk/Source/WebCore/css/typedom/numeric/CSSMathNegate.h trunk/Source/WebCore/css/typedom/numeric/CSSMathProduct.cpp trunk/Source/WebCore/css/typedom/numeric/CSSMathProduct.h trunk/Source/WebCore/css/typedom/numeric/CSSMathSum.cpp trunk/Source/WebCore/css/typedom/numeric/CSSMathSum.h trunk/Source/WebCore/css/typedom/numeric/CSSMathValue.h trunk/Source/WebCore/css/typedom/numeric/CSSNumericArray.cpp trunk/Source/WebCore/css/typedom/numeric/CSSNumericArray.h trunk/Source/WebCore/css/typedom/numeric/CSSNumericType.h trunk/Source/WebCore/css/typedom/transform/CSSTransformValue.h Removed Paths trunk/Source/WebCore/css/typedom/numeric/CSSMathValue.cpp Diff Modified:
[webkit-changes] [291596] branches/safari-614.1.6-branch/Source/WebKit/UIProcess/API/Cocoa/ _WKWebAuthenticationPanel.h
Title: [291596] branches/safari-614.1.6-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h Revision 291596 Author repst...@apple.com Date 2022-03-21 19:09:04 -0700 (Mon, 21 Mar 2022) Log Message Unreviewed logging change. rdar://90517607 Modified Paths branches/safari-614.1.6-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h Diff Modified: branches/safari-614.1.6-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h (291595 => 291596) --- branches/safari-614.1.6-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h 2022-03-22 01:38:32 UTC (rev 291595) +++ branches/safari-614.1.6-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h 2022-03-22 02:09:04 UTC (rev 291596) @@ -23,6 +23,10 @@ * THE POSSIBILITY OF SUCH DAMAGE. */ +#if __building_module(MobileSafari) +#error "how did this get here?" +#endif + #import #import #import ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291595] trunk/LayoutTests
Title: [291595] trunk/LayoutTests Revision 291595 Author matteo_flo...@apple.com Date 2022-03-21 18:38:32 -0700 (Mon, 21 Mar 2022) Log Message [ iOS iPhone 12 ] fast/hidpi & fast/layers/hidpi tests are flaky text/image failing https://bugs.webkit.org/show_bug.cgi?id=232384 Unreviewed test gardening. * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (291594 => 291595) --- trunk/LayoutTests/ChangeLog 2022-03-22 01:35:47 UTC (rev 291594) +++ trunk/LayoutTests/ChangeLog 2022-03-22 01:38:32 UTC (rev 291595) @@ -1,3 +1,12 @@ +2022-03-21 Matteo Flores + +[ iOS iPhone 12 ] fast/hidpi & fast/layers/hidpi tests are flaky text/image failing +https://bugs.webkit.org/show_bug.cgi?id=232384 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: + 2022-03-21 Robert Jenner REGRESSION: [ Monterey ] imported/w3c/web-platform-tests/html/canvas/element/line-styles/2d.line.width.scaledefault.html is a constant text failure Modified: trunk/LayoutTests/platform/ios/TestExpectations (291594 => 291595) --- trunk/LayoutTests/platform/ios/TestExpectations 2022-03-22 01:35:47 UTC (rev 291594) +++ trunk/LayoutTests/platform/ios/TestExpectations 2022-03-22 01:38:32 UTC (rev 291595) @@ -1773,6 +1773,13 @@ webkit.org/b/178739 css3/viewport-percentage-lengths/viewport-percentage-lengths-relative-font-size.html [ Skip ] webkit.org/b/178739 css3/viewport-percentage-lengths/viewport-percentage-lengths-resize.html [ Skip ] +# Webkit.org/b/232384 these tests are flaky failures on iOS +fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden.html [ Pass Failure ] +fast/layers/hidpi-box-positioned-off-by-one-when-transform-is-present.html [ Pass Failure ] +fast/layers/hidpi-floor-negative-coordinate-values-to-maintain-rounding-direction.html [ Pass Failure ] +fast/layers/hidpi-nested-layers-with-subpixel-accumulation.html [ Pass Failure ] +fast/layers/hidpi-transform-on-child-content-is-mispositioned.html [ Pass Failure ] + # LayoutTests/fast tests that timeout: fast/events/reveal-link-when-focused.html fast/forms/validation-message-appearance.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291594] trunk
Title: [291594] trunk
Revision 291594
Author obru...@igalia.com
Date 2022-03-21 18:35:47 -0700 (Mon, 21 Mar 2022)
Log Message
[css-cascade] Let revert-layer roll back to preshints
https://bugs.webkit.org/show_bug.cgi?id=237532
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Add test.
* web-platform-tests/css/css-cascade/presentational-hints-rollback-expected.txt: Added.
* web-platform-tests/css/css-cascade/presentational-hints-rollback.html: Added.
Source/WebCore:
The patch makes presentational hints use a cascade layer priority of 0.
The priority of the lowest layer is then increased to 1.
This allows 'revert-layer' in author origin revert to the presentational
hints origin, which is between user origin and author origin.
Test: imported/w3c/web-platform-tests/css/css-cascade/presentational-hints-rollback.html
* style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::addElementStyleProperties):
(WebCore::Style::ElementRuleCollector::matchAllRules):
(WebCore::Style::ElementRuleCollector::addElementInlineStyleProperties):
* style/ElementRuleCollector.h:
* style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::updateCascadeLayerPriorities):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/ElementRuleCollector.cpp
trunk/Source/WebCore/style/ElementRuleCollector.h
trunk/Source/WebCore/style/RuleSet.h
trunk/Source/WebCore/style/RuleSetBuilder.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/presentational-hints-rollback-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/presentational-hints-rollback.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291593 => 291594)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-22 01:19:00 UTC (rev 291593)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-22 01:35:47 UTC (rev 291594)
@@ -1,3 +1,15 @@
+2022-03-21 Oriol Brufau
+
+[css-cascade] Let revert-layer roll back to preshints
+https://bugs.webkit.org/show_bug.cgi?id=237532
+
+Reviewed by Darin Adler.
+
+Add test.
+
+* web-platform-tests/css/css-cascade/presentational-hints-rollback-expected.txt: Added.
+* web-platform-tests/css/css-cascade/presentational-hints-rollback.html: Added.
+
2022-03-21 Chris Dumez
BroadcastChannel instances in distinct opaque origins can communicate
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/presentational-hints-rollback-expected.txt (0 => 291594)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/presentational-hints-rollback-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/presentational-hints-rollback-expected.txt 2022-03-22 01:35:47 UTC (rev 291594)
@@ -0,0 +1,18 @@
+
+PASS #tests > * 1
+PASS #tests > * 2
+PASS #tests > * 3
+PASS #tests > * 4
+PASS #tests > * 5
+PASS #tests > * 6
+PASS #tests > * 7
+PASS #tests > * 8
+PASS #tests > * 9
+PASS #tests > * 10
+PASS #tests > * 11
+PASS #tests > * 12
+PASS #tests > * 13
+PASS #tests > * 14
+PASS #tests > * 15
+PASS #tests > * 16
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/presentational-hints-rollback.html (0 => 291594)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/presentational-hints-rollback.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/presentational-hints-rollback.html 2022-03-22 01:35:47 UTC (rev 291594)
@@ -0,0 +1,125 @@
+
+
+CSS Cascade: rolling back the cascade with presentation hints
+
+
+
+@layer {
+ .revert-1 {
+width: revert;
+height: revert;
+ }
+ .revert-layer-1 {
+width: revert-layer;
+height: revert-layer;
+ }
+}
+
+.revert-2 {
+ width: revert;
+ height: revert;
+}
+.revert-layer-2 {
+ width: revert-layer;
+ height: revert-layer;
+}
+
+.revert-3 {
+ animation: revert-3 paused 2s -1s;
+}
+.revert-layer-3 {
+ animation: revert-layer-3 paused 2s -1s;
+}
+@keyframes revert-3 {
+ from, to {
+width: revert;
+height: revert;
+ }
+}
+@keyframes revert-layer-3 {
+ from, to {
+width: revert-layer;
+height: revert-layer;
+ }
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+addEventListener("load", function() {
+ checkLayout("#tests > *", false);
+ done();
+}, {once: true});
+
Modified: trunk/Source/WebCore/ChangeLog (291593 => 291594)
--- trunk/Source/WebCore/ChangeLog 2022-03-22 01:19:00 UTC (rev 291593)
+++ trunk/Source/WebCore/ChangeLog 2022-03-22 01:35:47 UTC (rev 291594)
@@ -1,3 +1,25 @@
+2022-03-21 Oriol Brufau
+
+[css-cascade] Let revert-layer roll back to preshints
+https://bugs.webkit.org/show_bug.cgi?id=237532
+
+Reviewed by Darin Adler.
+
+The patch makes presentational hints use a cascade layer
[webkit-changes] [291593] trunk/Source/WebGPU
Title: [291593] trunk/Source/WebGPU
Revision 291593
Author mmaxfi...@apple.com
Date 2022-03-21 18:19:00 -0700 (Mon, 21 Mar 2022)
Log Message
[WebGPU] maxAnisotropy > 16 is clamped, rather than illegal
https://bugs.webkit.org/show_bug.cgi?id=238063
Reviewed by Kimmo Kinnunen.
See https://github.com/gpuweb/gpuweb/issues/696#issuecomment-644343897
> Let's add a maxAnisotropy value to samplers, and a maxAnisotropy limit(? query?) (likely only
> ever 16 or 1), but not to validate that the former is less than the latter.
Test: api/operation/sampling/anisotropy.spec.ts
* WebGPU/Sampler.mm:
(WebGPU::validateCreateSampler):
(WebGPU::Device::createSampler):
Modified Paths
trunk/Source/WebGPU/ChangeLog
trunk/Source/WebGPU/WebGPU/Sampler.mm
Diff
Modified: trunk/Source/WebGPU/ChangeLog (291592 => 291593)
--- trunk/Source/WebGPU/ChangeLog 2022-03-22 00:43:52 UTC (rev 291592)
+++ trunk/Source/WebGPU/ChangeLog 2022-03-22 01:19:00 UTC (rev 291593)
@@ -1,5 +1,23 @@
2022-03-21 Myles C. Maxfield
+[WebGPU] maxAnisotropy > 16 is clamped, rather than illegal
+https://bugs.webkit.org/show_bug.cgi?id=238063
+
+Reviewed by Kimmo Kinnunen.
+
+See https://github.com/gpuweb/gpuweb/issues/696#issuecomment-644343897
+
+> Let's add a maxAnisotropy value to samplers, and a maxAnisotropy limit(? query?) (likely only
+> ever 16 or 1), but not to validate that the former is less than the latter.
+
+Test: api/operation/sampling/anisotropy.spec.ts
+
+* WebGPU/Sampler.mm:
+(WebGPU::validateCreateSampler):
+(WebGPU::Device::createSampler):
+
+2022-03-21 Myles C. Maxfield
+
[WebGPU] Implement error reporting facilities
https://bugs.webkit.org/show_bug.cgi?id=238131
Modified: trunk/Source/WebGPU/WebGPU/Sampler.mm (291592 => 291593)
--- trunk/Source/WebGPU/WebGPU/Sampler.mm 2022-03-22 00:43:52 UTC (rev 291592)
+++ trunk/Source/WebGPU/WebGPU/Sampler.mm 2022-03-22 01:19:00 UTC (rev 291593)
@@ -50,10 +50,6 @@
if (descriptor.maxAnisotropy < 1)
return false;
-// "descriptor.maxAnisotropy is less than or equal to 16."
-if (descriptor.maxAnisotropy > 16)
-return false;
-
// "When descriptor.maxAnisotropy is greater than 1"
if (descriptor.maxAnisotropy > 1) {
// "descriptor.magFilter, descriptor.minFilter, and descriptor.mipmapFilter must be equal to "linear"."
@@ -194,7 +190,10 @@
return nullptr;
}
-samplerDescriptor.maxAnisotropy = descriptor.maxAnisotropy;
+// "The used value of maxAnisotropy will be clamped to the maximum value that the platform supports."
+// https://developer.apple.com/documentation/metal/mtlsamplerdescriptor/1516164-maxanisotropy?language=objc
+// "Values must be between 1 and 16, inclusive."
+samplerDescriptor.maxAnisotropy = std::min(descriptor.maxAnisotropy, 16);
samplerDescriptor.label = descriptor.label ? [NSString stringWithCString:descriptor.label encoding:NSUTF8StringEncoding] : nil;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291592] trunk/LayoutTests
Title: [291592] trunk/LayoutTests Revision 291592 Author jen...@apple.com Date 2022-03-21 17:43:52 -0700 (Mon, 21 Mar 2022) Log Message REGRESSION: [ Monterey ] imported/w3c/web-platform-tests/html/canvas/element/line-styles/2d.line.width.scaledefault.html is a constant text failure Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (291591 => 291592) --- trunk/LayoutTests/ChangeLog 2022-03-22 00:22:07 UTC (rev 291591) +++ trunk/LayoutTests/ChangeLog 2022-03-22 00:43:52 UTC (rev 291592) @@ -1,3 +1,12 @@ +2022-03-21 Robert Jenner + +REGRESSION: [ Monterey ] imported/w3c/web-platform-tests/html/canvas/element/line-styles/2d.line.width.scaledefault.html is a constant text failure + 2022-03-21 Kate Cheney nj.gov: Background color incorrect for 'State Vehicles' section Modified: trunk/LayoutTests/platform/mac/TestExpectations (291591 => 291592) --- trunk/LayoutTests/platform/mac/TestExpectations 2022-03-22 00:22:07 UTC (rev 291591) +++ trunk/LayoutTests/platform/mac/TestExpectations 2022-03-22 00:43:52 UTC (rev 291592) @@ -2193,9 +2193,6 @@ webkit.org/b/226299 [ BigSur ] http/tests/performance/performance-resource-timing-resourcetimingbufferfull-crash.html [ Pass Failure ] -# rdar://77527575 (REGRESSION: [ Monterey ] imported/w3c/web-platform-tests/html/canvas/element/line-styles/2d.line.width.scaledefault.html is a constant text failure 77527575) -[ Monterey ] imported/w3c/web-platform-tests/html/canvas/element/line-styles/2d.line.width.scaledefault.html [ Pass Failure ] - # rdar://78477744 (REGRESSION: [ Monterey ] 3 imported/w3c/web-platform-tests/css/css-text-decor (layout-tests) are constant ImageOnlyFailures) [ Monterey ] imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-from-font-variable.html [ Pass ImageOnlyFailure ] [ Monterey ] imported/w3c/web-platform-tests/css/css-text-decor/text-underline-offset-variable.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291591] trunk/Source/WebKit
Title: [291591] trunk/Source/WebKit Revision 291591 Author akeer...@apple.com Date 2022-03-21 17:22:07 -0700 (Mon, 21 Mar 2022) Log Message Unreviewed, address post-landing feedback on r291445 * UIProcess/ios/WKPDFView.mm: (-[WKPDFView compareFoundRange:toRange:inDocument:]): Subtraction to determine ordering is an anti-pattern, due to the possibility of overflow. Use comparison operators. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm Diff Modified: trunk/Source/WebKit/ChangeLog (291590 => 291591) --- trunk/Source/WebKit/ChangeLog 2022-03-22 00:17:14 UTC (rev 291590) +++ trunk/Source/WebKit/ChangeLog 2022-03-22 00:22:07 UTC (rev 291591) @@ -1,3 +1,13 @@ +2022-03-21 Aditya Keerthi + +Unreviewed, address post-landing feedback on r291445 + +* UIProcess/ios/WKPDFView.mm: +(-[WKPDFView compareFoundRange:toRange:inDocument:]): + +Subtraction to determine ordering is an anti-pattern, due to the +possibility of overflow. Use comparison operators. + 2022-03-21 Chris Dumez BroadcastChannel instances in distinct opaque origins can communicate Modified: trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm (291590 => 291591) --- trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm 2022-03-22 00:17:14 UTC (rev 291590) +++ trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm 2022-03-22 00:22:07 UTC (rev 291591) @@ -707,12 +707,10 @@ if (!to) return NSOrderedSame; -NSInteger offset = from.index - to.index; - -if (offset < 0) +if (from.index < to.index) return NSOrderedAscending; -if (offset > 0) +if (from.index > to.index) return NSOrderedDescending; return NSOrderedSame; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291590] branches/safari-613-branch/Source
Title: [291590] branches/safari-613-branch/Source Revision 291590 Author repst...@apple.com Date 2022-03-21 17:17:14 -0700 (Mon, 21 Mar 2022) Log Message Versioning. WebKit-7613.2.4 Modified Paths branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig (291589 => 291590) --- branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-03-21 23:46:48 UTC (rev 291589) +++ branches/safari-613-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-03-22 00:17:14 UTC (rev 291590) @@ -23,7 +23,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; -TINY_VERSION = 3; +TINY_VERSION = 4; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (291589 => 291590) --- branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-03-21 23:46:48 UTC (rev 291589) +++ branches/safari-613-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-03-22 00:17:14 UTC (rev 291590) @@ -23,7 +23,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; -TINY_VERSION = 3; +TINY_VERSION = 4; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (291589 => 291590) --- branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-03-21 23:46:48 UTC (rev 291589) +++ branches/safari-613-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-03-22 00:17:14 UTC (rev 291590) @@ -23,7 +23,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; -TINY_VERSION = 3; +TINY_VERSION = 4; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig (291589 => 291590) --- branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig 2022-03-21 23:46:48 UTC (rev 291589) +++ branches/safari-613-branch/Source/WebCore/Configurations/Version.xcconfig 2022-03-22 00:17:14 UTC (rev 291590) @@ -23,7 +23,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; -TINY_VERSION = 3; +TINY_VERSION = 4; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (291589 => 291590) --- branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-03-21 23:46:48 UTC (rev 291589) +++ branches/safari-613-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-03-22 00:17:14 UTC (rev 291590) @@ -23,7 +23,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; -TINY_VERSION = 3; +TINY_VERSION = 4; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig (291589 => 291590) --- branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-03-21 23:46:48 UTC (rev 291589) +++ branches/safari-613-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-03-22 00:17:14 UTC (rev 291590) @@ -23,7 +23,7 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; -TINY_VERSION = 3; +TINY_VERSION = 4; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-613-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (291589 => 291590) --- branches/safari-613-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-03-21 23:46:48 UTC (rev 291589) +++ branches/safari-613-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-03-22 00:17:14 UTC (rev 291590) @@ -1,6 +1,6 @@ MAJOR_VERSION = 613; MINOR_VERSION = 2; -TINY_VERSION = 3; +TINY_VERSION = 4; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-613-branch/Source/WebKit/Configurations/Version.xcconfig (291589 => 291590) ---
[webkit-changes] [291589] trunk
Title: [291589] trunk Revision 291589 Author cdu...@apple.com Date 2022-03-21 16:46:48 -0700 (Mon, 21 Mar 2022) Log Message LayoutTests/imported/w3c: BroadcastChannel instances in distinct opaque origins can communicate https://bugs.webkit.org/show_bug.cgi?id=238090 Reviewed by Alex Christensen. Import web-platform-tests test coverage. * web-platform-tests/webmessaging/broadcastchannel/opaque-origin-expected.txt: Added. * web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html: Added. * web-platform-tests/webmessaging/broadcastchannel/w3c-import.log: Source/WebCore: BroadcastChannel instances in distinct opaque origins can communicate https://bugs.webkit.org/show_bug.cgi?id=238090 Reviewed by Alex Christensen. The issue is that we would use a ClientOrigin to distinguish origins for BroadcastChannel, which relies on SecurityOriginData internally. A unique/opaque SecurityOrigin becomes an empty SecurityOriginData upon conversion. As a result, when comparing ClientOrigin objects from unique SecurityOrigins, they would compare as equal. To address the issue, I introduced a new PartitionedSecurityOrigin type which is similar to ClientOrigin but stores SecurityOrigin objects internally, instead of SecurityOriginData objects. PartitionedSecurityOrigin's operator==() is such that different SecurityOrigins would not be equal but the same unique SecurityOrigin would be. I then used this new PartitionedSecurityOrigin type as key in our HashMap on the WebProcess side instead of ClientOrigin. This allows communication between several BroadcastChannels from the same unique origin, while preventing communication between distinct opaque origins. When the PartitionedSecurityOrigin contains an opaque security origin, we don't involve the Network Process at all since the destination can only be in the same WebProcess. Test: imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html * Headers.cmake: * WebCore.xcodeproj/project.pbxproj: * dom/BroadcastChannel.cpp: (WebCore::shouldPartitionOrigin): (WebCore::BroadcastChannel::MainThreadBridge::registerChannel): (WebCore::BroadcastChannel::MainThreadBridge::unregisterChannel): (WebCore::BroadcastChannel::MainThreadBridge::postMessage): * dom/BroadcastChannelRegistry.h: * loader/EmptyClients.cpp: * page/PartitionedSecurityOrigin.h: Added. (WebCore::PartitionedSecurityOrigin::PartitionedSecurityOrigin): (WebCore::PartitionedSecurityOrigin::isHashTableDeletedValue const): (WebCore::PartitionedSecurityOrigin::isHashTableEmptyValue const): (WebCore::operator==): (WTF::add): (WTF::PartitionedSecurityOriginHash::hash): (WTF::PartitionedSecurityOriginHash::equal): (WTF::HashTraits::emptyValue): (WTF::HashTraits::constructEmptyValue): (WTF::HashTraits::isEmptyValue): (WTF::HashTraits::peek): (WTF::HashTraits::take): Source/WebKit: BroadcastChannel instances in distinct opaque origins can communicate https://bugs.webkit.org/show_bug.cgi?id=238090 Reviewed by Alex Christensen. The issue is that we would use a ClientOrigin to distinguish origins for BroadcastChannel, which relies on SecurityOriginData internally. A unique/opaque SecurityOrigin becomes an empty SecurityOriginData upon conversion. As a result, when comparing ClientOrigin objects from unique SecurityOrigins, they would compare as equal. To address the issue, I introduced a new PartitionedSecurityOrigin type which is similar to ClientOrigin but stores SecurityOrigin objects internally, instead of SecurityOriginData objects. PartitionedSecurityOrigin's operator==() is such that different SecurityOrigins would not be equal but the same unique SecurityOrigin would be. I then used this new PartitionedSecurityOrigin type as key in our HashMap on the WebProcess side instead of ClientOrigin. This allows communication between several BroadcastChannels from the same unique origin, while preventing communication between distinct opaque origins. When the PartitionedSecurityOrigin contains an opaque security origin, we don't involve the Network Process at all since the destination can only be in the same WebProcess. * WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.cpp: (WebKit::toClientOrigin): (WebKit::WebBroadcastChannelRegistry::registerChannel): (WebKit::WebBroadcastChannelRegistry::unregisterChannel): (WebKit::WebBroadcastChannelRegistry::postMessage): (WebKit::WebBroadcastChannelRegistry::postMessageLocally): (WebKit::WebBroadcastChannelRegistry::postMessageToRemote): (WebKit::WebBroadcastChannelRegistry::networkProcessCrashed): * WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.h: Source/WebKitLegacy: Dust off Mac CMake build https://bugs.webkit.org/show_bug.cgi?id=238121 Reviewed by Yusuke Suzuki. * PlatformMac.cmake: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/w3c-import.log trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Headers.cmake
[webkit-changes] [291588] trunk
Title: [291588] trunk Revision 291588 Author katherine_che...@apple.com Date 2022-03-21 16:39:22 -0700 (Mon, 21 Mar 2022) Log Message nj.gov: Background color incorrect for 'State Vehicles' section https://bugs.webkit.org/show_bug.cgi?id=238035 Reviewed by Aditya Keerthi. Source/WebCore: Test: fast/css/non-form-control-element-drop-appearance.html Update RenderTheme::adjustStyle to drop appearance for non-form control elements when they are styled by the author. * rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustAppearanceForElement const): (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::isControlStyled const): * rendering/RenderTheme.h: * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::borderAndBackgroundEqual const): * rendering/style/RenderStyle.h: LayoutTests: * fast/css/non-form-control-element-drop-appearance-expected.html: Added. * fast/css/non-form-control-element-drop-appearance.html: Added. * editing/deleting/insert-in-orphaned-selection-crash.html: Added. Now that we drop native style for non-form control elements, we need to add height to the style to make sure this table element is selectable and successfully tests what it needs to test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderTheme.cpp trunk/Source/WebCore/rendering/RenderTheme.h trunk/Source/WebCore/rendering/style/RenderStyle.cpp trunk/Source/WebCore/rendering/style/RenderStyle.h Added Paths trunk/LayoutTests/fast/css/non-form-control-element-drop-appearance-expected.html trunk/LayoutTests/fast/css/non-form-control-element-drop-appearance.html Diff Modified: trunk/LayoutTests/ChangeLog (291587 => 291588) --- trunk/LayoutTests/ChangeLog 2022-03-21 23:36:16 UTC (rev 291587) +++ trunk/LayoutTests/ChangeLog 2022-03-21 23:39:22 UTC (rev 291588) @@ -1,3 +1,18 @@ +2022-03-21 Kate Cheney + +nj.gov: Background color incorrect for 'State Vehicles' section +https://bugs.webkit.org/show_bug.cgi?id=238035 + + +Reviewed by Aditya Keerthi. + +* fast/css/non-form-control-element-drop-appearance-expected.html: Added. +* fast/css/non-form-control-element-drop-appearance.html: Added. +* editing/deleting/insert-in-orphaned-selection-crash.html: Added. +Now that we drop native style for non-form control elements, we need to +add height to the style to make sure this table element is selectable and +successfully tests what it needs to test. + 2022-03-21 Commit Queue Unreviewed, reverting r291055. Modified: trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash.html (291587 => 291588) --- trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash.html 2022-03-21 23:36:16 UTC (rev 291587) +++ trunk/LayoutTests/editing/deleting/insert-in-orphaned-selection-crash.html 2022-03-21 23:39:22 UTC (rev 291588) @@ -1,5 +1,6 @@* { -webkit-appearance:default-button; } + tr { height: 10px; }
[webkit-changes] [291587] trunk
Title: [291587] trunk
Revision 291587
Author commit-qu...@webkit.org
Date 2022-03-21 16:36:16 -0700 (Mon, 21 Mar 2022)
Log Message
Unreviewed, reverting r291055.
https://bugs.webkit.org/show_bug.cgi?id=238145
Invalid test expectations
Reverted changeset:
"[iOS] Hard link AVPictureInPictureController"
https://bugs.webkit.org/show_bug.cgi?id=237227
https://commits.webkit.org/r291055
Modified Paths
trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ipad/TestExpectations
trunk/metadata/contributors.json
Diff
Modified: trunk/ChangeLog (291586 => 291587)
--- trunk/ChangeLog 2022-03-21 22:44:51 UTC (rev 291586)
+++ trunk/ChangeLog 2022-03-21 23:36:16 UTC (rev 291587)
@@ -1,3 +1,16 @@
+2022-03-21 Commit Queue
+
+Unreviewed, reverting r291055.
+https://bugs.webkit.org/show_bug.cgi?id=238145
+
+Invalid test expectations
+
+Reverted changeset:
+
+"[iOS] Hard link AVPictureInPictureController"
+https://bugs.webkit.org/show_bug.cgi?id=237227
+https://commits.webkit.org/r291055
+
2022-03-18 Philippe Normand
[GStreamer] Migrate gst-full support to 1.20
Modified: trunk/LayoutTests/ChangeLog (291586 => 291587)
--- trunk/LayoutTests/ChangeLog 2022-03-21 22:44:51 UTC (rev 291586)
+++ trunk/LayoutTests/ChangeLog 2022-03-21 23:36:16 UTC (rev 291587)
@@ -1,3 +1,16 @@
+2022-03-21 Commit Queue
+
+Unreviewed, reverting r291055.
+https://bugs.webkit.org/show_bug.cgi?id=238145
+
+Invalid test expectations
+
+Reverted changeset:
+
+"[iOS] Hard link AVPictureInPictureController"
+https://bugs.webkit.org/show_bug.cgi?id=237227
+https://commits.webkit.org/r291055
+
2022-03-21 Matteo Flores
REGRESSION(r290797-r290793): [ iOS Debug ] 4 editing/selection/* tests are constant timeouts
Modified: trunk/LayoutTests/platform/ipad/TestExpectations (291586 => 291587)
--- trunk/LayoutTests/platform/ipad/TestExpectations 2022-03-21 22:44:51 UTC (rev 291586)
+++ trunk/LayoutTests/platform/ipad/TestExpectations 2022-03-21 23:36:16 UTC (rev 291587)
@@ -96,18 +96,6 @@
webkit.org/b/231635 [ Release ] editing/selection/ios/scroll-to-reveal-selection-when-showing-software-keyboard.html [ Timeout ]
-#webkit.org/b/237227 These 10 picture in picture tests are failing on iPad
-media/picture-in-picture/picture-in-picture-api-css-selector.html [ Timeout ]
-media/picture-in-picture/picture-in-picture-api-enter-pip-1.html [ Failure ]
-media/picture-in-picture/picture-in-picture-api-enter-pip-2.html [ Failure ]
-media/picture-in-picture/picture-in-picture-api-enter-pip-3.html [ Failure ]
-media/picture-in-picture/picture-in-picture-api-enter-pip-4.html [ Failure ]
-media/picture-in-picture/picture-in-picture-api-events.html [ Timeout ]
-media/picture-in-picture/picture-in-picture-api-exit-pip-1.html [ Timeout ]
-media/picture-in-picture/picture-in-picture-api-pip-window.html [ Failure ]
-media/picture-in-picture/picture-in-picture-window-aspect-ratio.html [ Failure ]
-platform/ipad/media/modern-media-controls/pip-support/pip-support-enabled.html [ Failure ]
-
media/picture-in-picture [ Pass ]
media/remove-video-element-in-pip-from-document.html [ Pass ]
Modified: trunk/metadata/contributors.json (291586 => 291587)
--- trunk/metadata/contributors.json 2022-03-21 22:44:51 UTC (rev 291586)
+++ trunk/metadata/contributors.json 2022-03-21 23:36:16 UTC (rev 291587)
@@ -4737,17 +4737,6 @@
},
{
"emails" : [
- "matteo_flo...@apple.com"
- ],
- "github" : "Smackteo",
- "name" : "Matteo Flores",
- "nicks" : [
- "MatteoF"
- ],
- "status" : "committer"
- },
- {
- "emails" : [
"mvujo...@adobe.com",
"maxvujo...@gmail.com"
],
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291586] branches/safari-614.1.7-branch/Source/WebKit
Title: [291586] branches/safari-614.1.7-branch/Source/WebKit Revision 291586 Author repst...@apple.com Date 2022-03-21 15:44:51 -0700 (Mon, 21 Mar 2022) Log Message Cherry-pick r291563. rdar://problem/90448244 Sandbox: Remove telemetry in Network Process sandbox macOS https://bugs.webkit.org/show_bug.cgi?id=238041 Patch by Adam Mazander on 2022-03-21 Reviewed by Brent Fulgham. * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291563 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-614.1.7-branch/Source/WebKit/ChangeLog branches/safari-614.1.7-branch/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in Diff Modified: branches/safari-614.1.7-branch/Source/WebKit/ChangeLog (291585 => 291586) --- branches/safari-614.1.7-branch/Source/WebKit/ChangeLog 2022-03-21 22:14:46 UTC (rev 291585) +++ branches/safari-614.1.7-branch/Source/WebKit/ChangeLog 2022-03-21 22:44:51 UTC (rev 291586) @@ -1,5 +1,28 @@ 2022-03-21 Russell Epstein +Cherry-pick r291563. rdar://problem/90448244 + +Sandbox: Remove telemetry in Network Process sandbox macOS +https://bugs.webkit.org/show_bug.cgi?id=238041 + +Patch by Adam Mazander on 2022-03-21 +Reviewed by Brent Fulgham. + +* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291563 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2022-03-21 Adam Mazander + +Sandbox: Remove telemetry in Network Process sandbox macOS +https://bugs.webkit.org/show_bug.cgi?id=238041 + +Reviewed by Brent Fulgham. + +* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: + +2022-03-21 Russell Epstein + Cherry-pick r291564. rdar://problem/90463946 Add an addition point for system background color Modified: branches/safari-614.1.7-branch/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (291585 => 291586) --- branches/safari-614.1.7-branch/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2022-03-21 22:14:46 UTC (rev 291585) +++ branches/safari-614.1.7-branch/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2022-03-21 22:44:51 UTC (rev 291586) @@ -49,7 +49,7 @@ (literal (string-append (param "HOME_DIR") home-relative-literal))) #if PLATFORM(MAC) -(deny mach-register (with telemetry) (local-name-prefix "")) +(deny mach-register (local-name-prefix "")) (allow system-automount (process-attribute is-platform-binary)) @@ -71,7 +71,7 @@ (literal "/var") (literal "/private/etc/localtime")) -(allow file-read-metadata (with telemetry) (path-ancestors "/System/Volumes/Data/private")) +(allow file-read-metadata (path-ancestors "/System/Volumes/Data/private")) (allow file-read* (literal "/")) @@ -130,7 +130,7 @@ (allow file-read* (literal "/Library/Preferences/com.apple.networkd.plist") (literal "/private/var/db/nsurlstoraged/dafsaData.bin")) -(deny mach-lookup (with telemetry) +(deny mach-lookup (global-name "com.apple.SystemConfiguration.PPPController") (global-name "com.apple.SystemConfiguration.SCNetworkReachability") (global-name "com.apple.networkd") @@ -143,7 +143,7 @@ (global-name "com.apple.usymptomsd")) (allow network-outbound (control-name "com.apple.netsrc")) -(deny system-socket (with telemetry) +(deny system-socket (socket-domain AF_ROUTE)) (allow system-socket (require-all (socket-domain AF_SYSTEM) @@ -150,7 +150,7 @@ (socket-protocol 2))) ; SYSPROTO_CONTROL (allow mach-lookup (global-name "com.apple.AppSSO.service-xpc")) -(deny ipc-posix-shm-read-data (with telemetry) +(deny ipc-posix-shm-read-data (ipc-posix-name "/com.apple.AppSSO.version"))) #else (import "system.sb") @@ -162,7 +162,7 @@ (allow process-info-pidinfo) (allow process-info-setcontrol (target self)) -(deny sysctl* (with telemetry)) +(deny sysctl*) (allow sysctl-read (sysctl-name "hw.cputype" @@ -274,7 +274,7 @@ (iokit-user-client-class "RootDomainUserClient") ; Used by PowerObserver ) -(deny mach-lookup (with telemetry) +(deny mach-lookup (global-name "com.apple.PowerManagement.control")) ;; Various services required by CFNetwork and other frameworks @@ -300,19 +300,19 @@ (global-name "com.apple.analyticsd") (global-name "com.apple.diagnosticd"))) -(allow mach-lookup (with telemetry) (global-name "com.apple.webkit.adattributiond.service")) -(allow mach-lookup (with telemetry) (global-name "org.webkit.pcmtestdaemon.service")) +(allow mach-lookup (global-name "com.apple.webkit.adattributiond.service")) +(allow mach-lookup (global-name "org.webkit.pcmtestdaemon.service"))
[webkit-changes] [291585] trunk/LayoutTests/ChangeLog
Title: [291585] trunk/LayoutTests/ChangeLog Revision 291585 Author matteo_flo...@apple.com Date 2022-03-21 15:14:46 -0700 (Mon, 21 Mar 2022) Log Message REGRESSION(r290797-r290793): [ iOS Debug ] 4 editing/selection/* tests are constant timeouts https://bugs.webkit.org/show_bug.cgi?id=238155 Unreviewed test gardening. * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog Diff Modified: trunk/LayoutTests/ChangeLog (291584 => 291585) --- trunk/LayoutTests/ChangeLog 2022-03-21 22:14:43 UTC (rev 291584) +++ trunk/LayoutTests/ChangeLog 2022-03-21 22:14:46 UTC (rev 291585) @@ -1,3 +1,12 @@ +2022-03-21 Matteo Flores + +REGRESSION(r290797-r290793): [ iOS Debug ] 4 editing/selection/* tests are constant timeouts +https://bugs.webkit.org/show_bug.cgi?id=238155 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: + 2022-03-21 Myles C. Maxfield [WebGPU] Set the WebGPU WKPreference to true in layout tests ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291584] trunk/LayoutTests/platform/ios/TestExpectations
Title: [291584] trunk/LayoutTests/platform/ios/TestExpectations Revision 291584 Author matteo_flo...@apple.com Date 2022-03-21 15:14:43 -0700 (Mon, 21 Mar 2022) Log Message Need a short description (OOPS!). Need the bug URL (OOPS!). Reviewed by NOBODY (OOPS!). * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/platform/ios/TestExpectations (291583 => 291584) --- trunk/LayoutTests/platform/ios/TestExpectations 2022-03-21 21:44:17 UTC (rev 291583) +++ trunk/LayoutTests/platform/ios/TestExpectations 2022-03-21 22:14:43 UTC (rev 291584) @@ -2665,6 +2665,13 @@ webkit.org/b/210173 webrtc/h265.html [ Skip ] +# webkit.org/b/238155 [ Debug ] These 5 tests are timing out on iOS Debug Specifically. +[ Debug ] editing/selection/move-by-word-visually-single-space-one-element.html [ Slow ] +[ Debug ] editing/selection/move-by-word-visually-single-space-inline-element.html [ Slow ] +[ Debug ] editing/selection/move-by-word-visually-multi-line.html [ Slow ] +[ Debug ] editing/selection/move-by-word-visually-mac.html [ Slow ] +[ Debug ] editing/selection/move-by-word-visually-inline-block-positioned-element.html [ Slow ] + webkit.org/b/209878 [ Debug ] webrtc/datachannel/multiple-connections.html [ Slow ] webkit.org/b/177323 imported/w3c/web-platform-tests/fetch/security/embedded-credentials.tentative.sub.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291583] tags/Safari-614.1.5.9.2/
Title: [291583] tags/Safari-614.1.5.9.2/ Revision 291583 Author repst...@apple.com Date 2022-03-21 14:44:17 -0700 (Mon, 21 Mar 2022) Log Message Tag Safari-614.1.5.9.2. Added Paths tags/Safari-614.1.5.9.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291582] branches/safari-614.1.7-branch/Source
Title: [291582] branches/safari-614.1.7-branch/Source Revision 291582 Author repst...@apple.com Date 2022-03-21 14:42:07 -0700 (Mon, 21 Mar 2022) Log Message Cherry-pick r291564. rdar://problem/90463946 Add an addition point for system background color https://bugs.webkit.org/show_bug.cgi?id=238108 Reviewed by Aditya Keerthi. Source/WebCore: * SourcesCocoa.txt: * WebCore.xcodeproj/project.pbxproj: * platform/ios/WebCoreUIColorExtras.h: Added. * platform/ios/WebCoreUIColorExtras.mm: Added. (WebCore::systemBackgroundColor): Add an addition point. * rendering/RenderThemeIOS.mm: (WebCore::CSSValueSystemColorInformation::function): (WebCore::cssValueSystemColorInformationList): (WebCore::systemColorFromCSSValueSystemColorInformation): Adopt it for CSS use of system background color. Source/WebKit: * UIProcess/API/ios/WKWebViewIOS.mm: (scrollViewBackgroundColor): Adopt systemBackgroundColor(). * UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::contentViewBackgroundColor): * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::platformUnderPageBackgroundColor const): Move the fallback to systemBackgroundColor into PageClientImpl so that it can realize the web view's trait collection. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291564 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-614.1.7-branch/Source/WebCore/ChangeLog branches/safari-614.1.7-branch/Source/WebCore/SourcesCocoa.txt branches/safari-614.1.7-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj branches/safari-614.1.7-branch/Source/WebCore/rendering/RenderThemeIOS.mm branches/safari-614.1.7-branch/Source/WebKit/ChangeLog branches/safari-614.1.7-branch/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm branches/safari-614.1.7-branch/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm branches/safari-614.1.7-branch/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm Added Paths branches/safari-614.1.7-branch/Source/WebCore/platform/ios/WebCoreUIColorExtras.h branches/safari-614.1.7-branch/Source/WebCore/platform/ios/WebCoreUIColorExtras.mm Diff Modified: branches/safari-614.1.7-branch/Source/WebCore/ChangeLog (291581 => 291582) --- branches/safari-614.1.7-branch/Source/WebCore/ChangeLog 2022-03-21 21:35:03 UTC (rev 291581) +++ branches/safari-614.1.7-branch/Source/WebCore/ChangeLog 2022-03-21 21:42:07 UTC (rev 291582) @@ -1,5 +1,67 @@ 2022-03-21 Russell Epstein +Cherry-pick r291564. rdar://problem/90463946 + +Add an addition point for system background color +https://bugs.webkit.org/show_bug.cgi?id=238108 + + +Reviewed by Aditya Keerthi. + +Source/WebCore: + +* SourcesCocoa.txt: +* WebCore.xcodeproj/project.pbxproj: +* platform/ios/WebCoreUIColorExtras.h: Added. +* platform/ios/WebCoreUIColorExtras.mm: Added. +(WebCore::systemBackgroundColor): +Add an addition point. + +* rendering/RenderThemeIOS.mm: +(WebCore::CSSValueSystemColorInformation::function): +(WebCore::cssValueSystemColorInformationList): +(WebCore::systemColorFromCSSValueSystemColorInformation): +Adopt it for CSS use of system background color. + +Source/WebKit: + +* UIProcess/API/ios/WKWebViewIOS.mm: +(scrollViewBackgroundColor): +Adopt systemBackgroundColor(). + +* UIProcess/ios/PageClientImplIOS.mm: +(WebKit::PageClientImpl::contentViewBackgroundColor): +* UIProcess/ios/WebPageProxyIOS.mm: +(WebKit::WebPageProxy::platformUnderPageBackgroundColor const): +Move the fallback to systemBackgroundColor into PageClientImpl +so that it can realize the web view's trait collection. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291564 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2022-03-21 Tim Horton + +Add an addition point for system background color +https://bugs.webkit.org/show_bug.cgi?id=238108 + + +Reviewed by Aditya Keerthi. + +* SourcesCocoa.txt: +* WebCore.xcodeproj/project.pbxproj: +* platform/ios/WebCoreUIColorExtras.h: Added. +* platform/ios/WebCoreUIColorExtras.mm: Added. +(WebCore::systemBackgroundColor): +Add an addition point. + +* rendering/RenderThemeIOS.mm: +(WebCore::CSSValueSystemColorInformation::function): +(WebCore::cssValueSystemColorInformationList): +(WebCore::systemColorFromCSSValueSystemColorInformation): +Adopt it for CSS use of system background color. + +2022-03-21 Russell Epstein + Cherry-pick r291514. rdar://problem/90500863 [iOS] Fix more build breakage from r291361 Modified: branches/safari-614.1.7-branch/Source/WebCore/SourcesCocoa.txt (291581 => 291582) ---
[webkit-changes] [291581] branches/safari-614.1.5.9-branch/Source
Title: [291581] branches/safari-614.1.5.9-branch/Source Revision 291581 Author repst...@apple.com Date 2022-03-21 14:35:03 -0700 (Mon, 21 Mar 2022) Log Message Cherry-pick r291564. rdar://problem/90463946 Add an addition point for system background color https://bugs.webkit.org/show_bug.cgi?id=238108 Reviewed by Aditya Keerthi. Source/WebCore: * SourcesCocoa.txt: * WebCore.xcodeproj/project.pbxproj: * platform/ios/WebCoreUIColorExtras.h: Added. * platform/ios/WebCoreUIColorExtras.mm: Added. (WebCore::systemBackgroundColor): Add an addition point. * rendering/RenderThemeIOS.mm: (WebCore::CSSValueSystemColorInformation::function): (WebCore::cssValueSystemColorInformationList): (WebCore::systemColorFromCSSValueSystemColorInformation): Adopt it for CSS use of system background color. Source/WebKit: * UIProcess/API/ios/WKWebViewIOS.mm: (scrollViewBackgroundColor): Adopt systemBackgroundColor(). * UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::contentViewBackgroundColor): * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::platformUnderPageBackgroundColor const): Move the fallback to systemBackgroundColor into PageClientImpl so that it can realize the web view's trait collection. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291564 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-614.1.5.9-branch/Source/WebCore/ChangeLog branches/safari-614.1.5.9-branch/Source/WebCore/SourcesCocoa.txt branches/safari-614.1.5.9-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj branches/safari-614.1.5.9-branch/Source/WebCore/rendering/RenderThemeIOS.mm branches/safari-614.1.5.9-branch/Source/WebKit/ChangeLog branches/safari-614.1.5.9-branch/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm branches/safari-614.1.5.9-branch/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm branches/safari-614.1.5.9-branch/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm Added Paths branches/safari-614.1.5.9-branch/Source/WebCore/platform/ios/WebCoreUIColorExtras.h branches/safari-614.1.5.9-branch/Source/WebCore/platform/ios/WebCoreUIColorExtras.mm Diff Modified: branches/safari-614.1.5.9-branch/Source/WebCore/ChangeLog (291580 => 291581) --- branches/safari-614.1.5.9-branch/Source/WebCore/ChangeLog 2022-03-21 21:32:31 UTC (rev 291580) +++ branches/safari-614.1.5.9-branch/Source/WebCore/ChangeLog 2022-03-21 21:35:03 UTC (rev 291581) @@ -1,3 +1,65 @@ +2022-03-21 Russell Epstein + +Cherry-pick r291564. rdar://problem/90463946 + +Add an addition point for system background color +https://bugs.webkit.org/show_bug.cgi?id=238108 + + +Reviewed by Aditya Keerthi. + +Source/WebCore: + +* SourcesCocoa.txt: +* WebCore.xcodeproj/project.pbxproj: +* platform/ios/WebCoreUIColorExtras.h: Added. +* platform/ios/WebCoreUIColorExtras.mm: Added. +(WebCore::systemBackgroundColor): +Add an addition point. + +* rendering/RenderThemeIOS.mm: +(WebCore::CSSValueSystemColorInformation::function): +(WebCore::cssValueSystemColorInformationList): +(WebCore::systemColorFromCSSValueSystemColorInformation): +Adopt it for CSS use of system background color. + +Source/WebKit: + +* UIProcess/API/ios/WKWebViewIOS.mm: +(scrollViewBackgroundColor): +Adopt systemBackgroundColor(). + +* UIProcess/ios/PageClientImplIOS.mm: +(WebKit::PageClientImpl::contentViewBackgroundColor): +* UIProcess/ios/WebPageProxyIOS.mm: +(WebKit::WebPageProxy::platformUnderPageBackgroundColor const): +Move the fallback to systemBackgroundColor into PageClientImpl +so that it can realize the web view's trait collection. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291564 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2022-03-21 Tim Horton + +Add an addition point for system background color +https://bugs.webkit.org/show_bug.cgi?id=238108 + + +Reviewed by Aditya Keerthi. + +* SourcesCocoa.txt: +* WebCore.xcodeproj/project.pbxproj: +* platform/ios/WebCoreUIColorExtras.h: Added. +* platform/ios/WebCoreUIColorExtras.mm: Added. +(WebCore::systemBackgroundColor): +Add an addition point. + +* rendering/RenderThemeIOS.mm: +(WebCore::CSSValueSystemColorInformation::function): +(WebCore::cssValueSystemColorInformationList): +(WebCore::systemColorFromCSSValueSystemColorInformation): +Adopt it for CSS use of system background color. + 2022-03-03 Russell Epstein Cherry-pick r290805. rdar://problem/89053248 Modified: branches/safari-614.1.5.9-branch/Source/WebCore/SourcesCocoa.txt (291580 => 291581) --- branches/safari-614.1.5.9-branch/Source/WebCore/SourcesCocoa.txt
[webkit-changes] [291580] branches/safari-614.1.5.9-branch/Source
Title: [291580] branches/safari-614.1.5.9-branch/Source Revision 291580 Author repst...@apple.com Date 2022-03-21 14:32:31 -0700 (Mon, 21 Mar 2022) Log Message Versioning. WebKit-7614.1.5.9.2 Modified Paths branches/safari-614.1.5.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-614.1.5.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-614.1.5.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-614.1.5.9-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-614.1.5.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-614.1.5.9-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-614.1.5.9-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-614.1.5.9-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-614.1.5.9-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-614.1.5.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig (291579 => 291580) --- branches/safari-614.1.5.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-03-21 21:23:58 UTC (rev 291579) +++ branches/safari-614.1.5.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-03-21 21:32:31 UTC (rev 291580) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 5; MICRO_VERSION = 9; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-614.1.5.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (291579 => 291580) --- branches/safari-614.1.5.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-03-21 21:23:58 UTC (rev 291579) +++ branches/safari-614.1.5.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-03-21 21:32:31 UTC (rev 291580) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 5; MICRO_VERSION = 9; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-614.1.5.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (291579 => 291580) --- branches/safari-614.1.5.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-03-21 21:23:58 UTC (rev 291579) +++ branches/safari-614.1.5.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-03-21 21:32:31 UTC (rev 291580) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 5; MICRO_VERSION = 9; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-614.1.5.9-branch/Source/WebCore/Configurations/Version.xcconfig (291579 => 291580) --- branches/safari-614.1.5.9-branch/Source/WebCore/Configurations/Version.xcconfig 2022-03-21 21:23:58 UTC (rev 291579) +++ branches/safari-614.1.5.9-branch/Source/WebCore/Configurations/Version.xcconfig 2022-03-21 21:32:31 UTC (rev 291580) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 5; MICRO_VERSION = 9; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-614.1.5.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (291579 => 291580) --- branches/safari-614.1.5.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-03-21 21:23:58 UTC (rev 291579) +++ branches/safari-614.1.5.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-03-21 21:32:31 UTC (rev 291580) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 5; MICRO_VERSION = 9; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-614.1.5.9-branch/Source/WebGPU/Configurations/Version.xcconfig (291579 => 291580) --- branches/safari-614.1.5.9-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-03-21 21:23:58 UTC (rev 291579) +++ branches/safari-614.1.5.9-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-03-21 21:32:31 UTC (rev 291580) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 5; MICRO_VERSION = 9; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION =
[webkit-changes] [291579] trunk
Title: [291579] trunk
Revision 291579
Author bfulg...@apple.com
Date 2022-03-21 14:23:58 -0700 (Mon, 21 Mar 2022)
Log Message
Disable the element in Captive Portal mode.
https://bugs.webkit.org/show_bug.cgi?id=238148
Reviewed by Chris Dumez.
Source/WebKit:
When displaying content in a captive portal, we should make sure the experimental
element is unavailable.
Tests: TestWebKitAPI
* WebProcess/WebPage/WebPage.cpp:
(WebKit::adjustSettingsForCaptivePortal): Added. Also turn off support.
(WebKit::WebPage::updatePreferences): Call new helper function.
Tools:
Update tests to check element.
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (291578 => 291579)
--- trunk/Source/WebKit/ChangeLog 2022-03-21 20:44:52 UTC (rev 291578)
+++ trunk/Source/WebKit/ChangeLog 2022-03-21 21:23:58 UTC (rev 291579)
@@ -1,3 +1,20 @@
+2022-03-21 Brent Fulgham
+
+Disable the element in Captive Portal mode.
+https://bugs.webkit.org/show_bug.cgi?id=238148
+
+
+Reviewed by Chris Dumez.
+
+When displaying content in a captive portal, we should make sure the experimental
+ element is unavailable.
+
+Tests: TestWebKitAPI
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::adjustSettingsForCaptivePortal): Added. Also turn off support.
+(WebKit::WebPage::updatePreferences): Call new helper function.
+
2022-03-21 Per Arne Vollan
[watchOS] Add required syscall
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (291578 => 291579)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2022-03-21 20:44:52 UTC (rev 291578)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2022-03-21 21:23:58 UTC (rev 291579)
@@ -3956,6 +3956,61 @@
return false;
}
+static void adjustSettingsForCaptivePortal(Settings& settings, const WebPreferencesStore& store)
+{
+settings.setWebGLEnabled(false);
+#if ENABLE(WEBGL2)
+settings.setWebGL2Enabled(false);
+#endif
+#if ENABLE(GAMEPAD)
+settings.setGamepadsEnabled(false);
+#endif
+#if ENABLE(WIRELESS_PLAYBACK_TARGET)
+settings.setRemotePlaybackEnabled(false);
+#endif
+settings.setFileSystemAccessEnabled(false);
+settings.setAllowsPictureInPictureMediaPlayback(false);
+#if ENABLE(PICTURE_IN_PICTURE_API)
+settings.setPictureInPictureAPIEnabled(false);
+#endif
+settings.setSpeechRecognitionEnabled(false);
+#if ENABLE(NOTIFICATIONS)
+settings.setNotificationsEnabled(false);
+#endif
+#if ENABLE(SERVICE_WORKER)
+settings.setPushAPIEnabled(false);
+#endif
+#if ENABLE(WEBXR)
+settings.setWebXREnabled(false);
+settings.setWebXRAugmentedRealityModuleEnabled(false);
+#endif
+#if ENABLE(MODEL_ELEMENT)
+settings.setModelElementEnabled(false);
+#endif
+#if ENABLE(MEDIA_STREAM)
+settings.setMediaDevicesEnabled(false);
+#endif
+#if ENABLE(WEB_AUDIO)
+settings.setWebAudioEnabled(false);
+#endif
+settings.setDownloadableBinaryFontsEnabled(false);
+#if ENABLE(WEB_RTC)
+settings.setPeerConnectionEnabled(false);
+#endif
+#if ENABLE(MATHML)
+settings.setMathMLEnabled(false);
+#endif
+#if ENABLE(PDFJS)
+settings.setPdfJSViewerEnabled(true);
+#endif
+
+settings.setAllowedMediaContainerTypes(store.getStringValueForKey(WebPreferencesKey::mediaContainerTypesAllowedInCaptivePortalModeKey()));
+settings.setAllowedMediaCodecTypes(store.getStringValueForKey(WebPreferencesKey::mediaCodecTypesAllowedInCaptivePortalModeKey()));
+settings.setAllowedMediaVideoCodecIDs(store.getStringValueForKey(WebPreferencesKey::mediaVideoCodecIDsAllowedInCaptivePortalModeKey()));
+settings.setAllowedMediaAudioCodecIDs(store.getStringValueForKey(WebPreferencesKey::mediaAudioCodecIDsAllowedInCaptivePortalModeKey()));
+settings.setAllowedMediaCaptionFormatTypes(store.getStringValueForKey(WebPreferencesKey::mediaCaptionFormatTypesAllowedInCaptivePortalModeKey()));
+}
+
void WebPage::updatePreferences(const WebPreferencesStore& store)
{
updatePreferencesGenerated(store);
@@ -4076,57 +4131,9 @@
// FIXME: This should be automated by adding a new field in WebPreferences*.yaml
// that indicates override state for captive portal mode. https://webkit.org/b/233100.
-if (WebProcess::singleton().isCaptivePortalModeEnabled()) {
-settings.setWebGLEnabled(false);
-#if ENABLE(WEBGL2)
-settings.setWebGL2Enabled(false);
-#endif
-#if ENABLE(GAMEPAD)
-settings.setGamepadsEnabled(false);
-#endif
-#if ENABLE(WIRELESS_PLAYBACK_TARGET)
-settings.setRemotePlaybackEnabled(false);
-#endif
-settings.setFileSystemAccessEnabled(false);
-settings.setAllowsPictureInPictureMediaPlayback(false);
-#if ENABLE(PICTURE_IN_PICTURE_API)
-
[webkit-changes] [291578] trunk
Title: [291578] trunk Revision 291578 Author mmaxfi...@apple.com Date 2022-03-21 13:44:52 -0700 (Mon, 21 Mar 2022) Log Message [WebGPU] Set the WebGPU WKPreference to true in layout tests https://bugs.webkit.org/show_bug.cgi?id=238130 Reviewed by Sam Weinig. Tools: WebGPU isn't ready yet to show up in any Safari menus, so rather than just marking it as an experimental feature, this patch just enables the preference in DumpRenderTree and WebKitTestRunner. This doesn't require a linker change, because all of the WebGPU calls are already behind HAS(WEBGPU_IMPLEMENTATION). Therefore, the immediate behavior change of this patch is that the IDL types are exposed in layout tests, but calling WebGPU functions in layout tests will return undefined. When we finally link WebCore with WebGPU, then these functions will automatically start working in layout tests. Outside of layout tests, the IDL types are still not present, and so therefore the WebGPU functions cannot be called because they are not visible from script. * DumpRenderTree/TestOptions.cpp: (WTR::TestOptions::defaults): * WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): LayoutTests: * platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt: * platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt trunk/LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/TestOptions.cpp trunk/Tools/WebKitTestRunner/TestOptions.cpp Diff Modified: trunk/LayoutTests/ChangeLog (291577 => 291578) --- trunk/LayoutTests/ChangeLog 2022-03-21 19:57:19 UTC (rev 291577) +++ trunk/LayoutTests/ChangeLog 2022-03-21 20:44:52 UTC (rev 291578) @@ -1,3 +1,13 @@ +2022-03-21 Myles C. Maxfield + +[WebGPU] Set the WebGPU WKPreference to true in layout tests +https://bugs.webkit.org/show_bug.cgi?id=238130 + +Reviewed by Sam Weinig. + +* platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt: +* platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt: + 2022-03-21 Tyler Wilcock AX: Include display: contents elements in the AX tree Modified: trunk/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt (291577 => 291578) --- trunk/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt 2022-03-21 19:57:19 UTC (rev 291577) +++ trunk/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt 2022-03-21 20:44:52 UTC (rev 291578) @@ -5,6 +5,7 @@ navigator.appVersion is OK navigator.cookieEnabled is OK navigator.getStorageUpdates() is OK +navigator.gpu is OK navigator.hardwareConcurrency is OK navigator.javaEnabled() is OK navigator.language is OK @@ -32,6 +33,7 @@ navigator.appVersion is OK navigator.cookieEnabled is OK navigator.getStorageUpdates() is OK +navigator.gpu is OK navigator.hardwareConcurrency is OK navigator.javaEnabled() is OK navigator.language is OK Modified: trunk/LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt (291577 => 291578) --- trunk/LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt 2022-03-21 19:57:19 UTC (rev 291577) +++ trunk/LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt 2022-03-21 20:44:52 UTC (rev 291578) @@ -9,6 +9,7 @@ navigator.cookieEnabled is OK navigator.credentials is OK navigator.getStorageUpdates() is OK +navigator.gpu is OK navigator.hardwareConcurrency is OK navigator.isLoggedIn() is OK navigator.javaEnabled() is OK @@ -46,6 +47,7 @@ navigator.cookieEnabled is OK navigator.credentials is OK navigator.getStorageUpdates() is OK +navigator.gpu is OK navigator.hardwareConcurrency is OK navigator.isLoggedIn() is OK navigator.javaEnabled() is OK Modified: trunk/Tools/ChangeLog (291577 => 291578) --- trunk/Tools/ChangeLog 2022-03-21 19:57:19 UTC (rev 291577) +++ trunk/Tools/ChangeLog 2022-03-21 20:44:52 UTC (rev 291578) @@ -1,5 +1,26 @@ 2022-03-21 Myles C. Maxfield +[WebGPU] Set the WebGPU WKPreference to true in layout tests +https://bugs.webkit.org/show_bug.cgi?id=238130 + +Reviewed by Sam Weinig. + +WebGPU isn't ready yet to show up in any Safari menus, so rather than just marking it as an experimental feature, +this patch just enables the preference in DumpRenderTree and WebKitTestRunner. + +This doesn't require a linker change, because all of the WebGPU calls are already behind HAS(WEBGPU_IMPLEMENTATION). +Therefore, the immediate behavior change of this patch is that the IDL types are exposed in layout tests, but calling +WebGPU functions in layout tests will return undefined. When we finally link WebCore with WebGPU, then these +functions will automatically
[webkit-changes] [291577] trunk
Title: [291577] trunk
Revision 291577
Author ysuz...@apple.com
Date 2022-03-21 12:57:19 -0700 (Mon, 21 Mar 2022)
Log Message
[JSC] ReferenceError when using extra parens in class fields
https://bugs.webkit.org/show_bug.cgi?id=236843
Reviewed by Saam Barati.
JSTests:
* stress/class-field-initializer-should-have-variable-scope.js: Added.
(shouldBe):
(test1.const.a.x.B):
(test1):
(test2.const.a.x.B):
(test2):
(test3.B.prototype.b):
(test3.B):
(test3):
Source/_javascript_Core:
class field initializer should create its own used-variables set
to capture used variables separately from the other variables since
it becomes independent CodeBlock internally later. The current code
was wrong since,
1. Incorrectly using the current set of class-scope.
2. Incorrectly marking only the last set while parseAssignmentExpression can create a new set inside it.
* parser/Parser.cpp:
(JSC::Parser::parseClass):
* parser/Parser.h:
(JSC::Scope::markLastUsedVariablesSetAsCaptured):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Parser.cpp
trunk/Source/_javascript_Core/parser/Parser.h
Added Paths
trunk/JSTests/stress/class-field-initializer-should-have-variable-scope.js
Diff
Modified: trunk/JSTests/ChangeLog (291576 => 291577)
--- trunk/JSTests/ChangeLog 2022-03-21 19:42:26 UTC (rev 291576)
+++ trunk/JSTests/ChangeLog 2022-03-21 19:57:19 UTC (rev 291577)
@@ -1,3 +1,20 @@
+2022-03-21 Yusuke Suzuki
+
+[JSC] ReferenceError when using extra parens in class fields
+https://bugs.webkit.org/show_bug.cgi?id=236843
+
+Reviewed by Saam Barati.
+
+* stress/class-field-initializer-should-have-variable-scope.js: Added.
+(shouldBe):
+(test1.const.a.x.B):
+(test1):
+(test2.const.a.x.B):
+(test2):
+(test3.B.prototype.b):
+(test3.B):
+(test3):
+
2022-03-08 Mark Lam
Remove invalid ASSERT in LocaleIDBuilder::overrideLanguageScriptRegion().
Added: trunk/JSTests/stress/class-field-initializer-should-have-variable-scope.js (0 => 291577)
--- trunk/JSTests/stress/class-field-initializer-should-have-variable-scope.js (rev 0)
+++ trunk/JSTests/stress/class-field-initializer-should-have-variable-scope.js 2022-03-21 19:57:19 UTC (rev 291577)
@@ -0,0 +1,37 @@
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error('bad value: ' + actual);
+}
+
+(function test1() {
+const a = (x) => x
+
+class B {
+c = a('OK');
+}
+
+shouldBe(new B().c, "OK");
+})();
+
+(function test2() {
+const a = (x) => x
+
+class B {
+c = a(('OK'));
+}
+
+shouldBe(new B().c, "OK");
+})();
+
+(function test3() {
+const a = (x) => x;
+const b = 'ok';
+
+class B {
+[b]() { return 42; }
+c = a('OK');
+}
+
+shouldBe(new B().c, "OK");
+shouldBe(new B().ok(), 42);
+})();
Modified: trunk/Source/_javascript_Core/ChangeLog (291576 => 291577)
--- trunk/Source/_javascript_Core/ChangeLog 2022-03-21 19:42:26 UTC (rev 291576)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-03-21 19:57:19 UTC (rev 291577)
@@ -1,3 +1,23 @@
+2022-03-21 Yusuke Suzuki
+
+[JSC] ReferenceError when using extra parens in class fields
+https://bugs.webkit.org/show_bug.cgi?id=236843
+
+Reviewed by Saam Barati.
+
+class field initializer should create its own used-variables set
+to capture used variables separately from the other variables since
+it becomes independent CodeBlock internally later. The current code
+was wrong since,
+
+1. Incorrectly using the current set of class-scope.
+2. Incorrectly marking only the last set while parseAssignmentExpression can create a new set inside it.
+
+* parser/Parser.cpp:
+(JSC::Parser::parseClass):
+* parser/Parser.h:
+(JSC::Scope::markLastUsedVariablesSetAsCaptured):
+
2022-03-21 Jonathan Bedard
Unreviewed, reverting r291558.
Modified: trunk/Source/_javascript_Core/parser/Parser.cpp (291576 => 291577)
--- trunk/Source/_javascript_Core/parser/Parser.cpp 2022-03-21 19:42:26 UTC (rev 291576)
+++ trunk/Source/_javascript_Core/parser/Parser.cpp 2022-03-21 19:57:19 UTC (rev 291577)
@@ -3110,12 +3110,14 @@
TreeExpression initializer = 0;
if (consume(EQUAL)) {
+size_t usedVariablesSize = currentScope()->currentUsedVariablesSize();
+currentScope()->pushUsedVariableSet();
SetForScope overrideParsingClassFieldInitializer(m_parserState.isParsingClassFieldInitializer, true);
classScope->setExpectedSuperBinding(SuperBinding::Needed);
initializer = parseAssignmentExpression(context);
classScope->setExpectedSuperBinding(SuperBinding::NotNeeded);
[webkit-changes] [291576] trunk/LayoutTests
Title: [291576] trunk/LayoutTests
Revision 291576
Author ryanhad...@apple.com
Date 2022-03-21 12:42:26 -0700 (Mon, 21 Mar 2022)
Log Message
Unreviewed test gardening after 246673@main.
* fast/viewport/watchos/viewport-adaptations-after-navigation-expected.txt:
* fast/viewport/watchos/viewport-with-system-minimum-layout-margins.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/viewport/watchos/viewport-adaptations-after-navigation-expected.txt
trunk/LayoutTests/fast/viewport/watchos/viewport-with-system-minimum-layout-margins.html
Diff
Modified: trunk/LayoutTests/ChangeLog (291575 => 291576)
--- trunk/LayoutTests/ChangeLog 2022-03-21 19:21:59 UTC (rev 291575)
+++ trunk/LayoutTests/ChangeLog 2022-03-21 19:42:26 UTC (rev 291576)
@@ -118,6 +118,13 @@
* inspector/runtime/evaluate-emulateUserGesture-hasTransientActivation.html: Added.
* inspector/runtime/evaluate-emulateUserGesture-hasTransientActivation-expected.txt: Added.
+2022-03-21 Ryan Haddad
+
+Unreviewed test gardening.
+
+* fast/viewport/watchos/viewport-adaptations-after-navigation-expected.txt:
+* fast/viewport/watchos/viewport-with-system-minimum-layout-margins.html:
+
2022-03-18 Ryan Haddad
[macOS arm64] webrtc/vp9-profile2.html is consistently timing out
Modified: trunk/LayoutTests/fast/viewport/watchos/viewport-adaptations-after-navigation-expected.txt (291575 => 291576)
--- trunk/LayoutTests/fast/viewport/watchos/viewport-adaptations-after-navigation-expected.txt 2022-03-21 19:21:59 UTC (rev 291575)
+++ trunk/LayoutTests/fast/viewport/watchos/viewport-adaptations-after-navigation-expected.txt 2022-03-21 19:42:26 UTC (rev 291576)
@@ -1 +1 @@
-previous size: (156, 175); current size: (320, 359)
+previous size: (184, 204); current size: (320, 355)
Modified: trunk/LayoutTests/fast/viewport/watchos/viewport-with-system-minimum-layout-margins.html (291575 => 291576)
--- trunk/LayoutTests/fast/viewport/watchos/viewport-with-system-minimum-layout-margins.html 2022-03-21 19:21:59 UTC (rev 291575)
+++ trunk/LayoutTests/fast/viewport/watchos/viewport-with-system-minimum-layout-margins.html 2022-03-21 19:42:26 UTC (rev 291576)
@@ -22,7 +22,7 @@
return;
await UIHelper.ensureVisibleContentRectUpdate();
-shouldBe("innerWidth", "132");
+shouldBe("innerWidth", "160");
finishJSTest();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291575] trunk/Tools
Title: [291575] trunk/Tools
Revision 291575
Author mmaxfi...@apple.com
Date 2022-03-21 12:21:59 -0700 (Mon, 21 Mar 2022)
Log Message
[WebGPU] Add a build-webgpu script
https://bugs.webkit.org/show_bug.cgi?id=238040
Reviewed by Saam Barati.
This patch adds a build-webgpu script by sharing code with the build-jsc script.
It moves almost all of the contents of the build-jsc script to a shared Perl module,
webkitperl/BuildSubproject.pm, and then has build-jsc and build-webgpu both call
into it to build the relevant projects.
* Scripts/build-jsc:
(buildMyProject): Deleted.
(writeCongrats): Deleted.
* Scripts/build-webgpu: Added.
* Scripts/webkitperl/BuildSubproject.pm: Copied from Tools/Scripts/build-jsc.
(buildMyProject):
(writeCongrats):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-jsc
Added Paths
trunk/Tools/Scripts/build-webgpu
trunk/Tools/Scripts/webkitperl/BuildSubproject.pm
Diff
Modified: trunk/Tools/ChangeLog (291574 => 291575)
--- trunk/Tools/ChangeLog 2022-03-21 19:16:37 UTC (rev 291574)
+++ trunk/Tools/ChangeLog 2022-03-21 19:21:59 UTC (rev 291575)
@@ -1,3 +1,23 @@
+2022-03-21 Myles C. Maxfield
+
+[WebGPU] Add a build-webgpu script
+https://bugs.webkit.org/show_bug.cgi?id=238040
+
+Reviewed by Saam Barati.
+
+This patch adds a build-webgpu script by sharing code with the build-jsc script.
+It moves almost all of the contents of the build-jsc script to a shared Perl module,
+webkitperl/BuildSubproject.pm, and then has build-jsc and build-webgpu both call
+into it to build the relevant projects.
+
+* Scripts/build-jsc:
+(buildMyProject): Deleted.
+(writeCongrats): Deleted.
+* Scripts/build-webgpu: Added.
+* Scripts/webkitperl/BuildSubproject.pm: Copied from Tools/Scripts/build-jsc.
+(buildMyProject):
+(writeCongrats):
+
2022-03-18 Jonathan Bedard
[Merge-Queue] Support multiple reviewers names
Modified: trunk/Tools/Scripts/build-jsc (291574 => 291575)
--- trunk/Tools/Scripts/build-jsc 2022-03-21 19:16:37 UTC (rev 291574)
+++ trunk/Tools/Scripts/build-jsc 2022-03-21 19:21:59 UTC (rev 291575)
@@ -1,6 +1,6 @@
#!/usr/bin/env perl
-# Copyright (C) 2005, 2013 Apple Inc. All rights reserved.
+# Copyright (C) 2005-2022 Apple Inc. All rights reserved.
# Copyright (C) 2007 Eric Seidel
#
# Redistribution and use in source and binary forms, with or without
@@ -27,246 +27,14 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-use strict;
-use warnings;
use FindBin;
-use Getopt::Long qw(:config pass_through);
use lib $FindBin::Bin;
-use webkitdirs;
use webkitperl::FeatureList qw(getFeatureOptionList);
-use POSIX;
-use Text::ParseWords;
+use webkitperl::BuildSubproject;
-sub writeCongrats();
-
-prohibitUnknownPort();
-
-if (shouldUseFlatpak()) {
-print "Building flatpak based environment\n";
-my @command = (File::Spec->catfile(sourceDir(), "Tools", "Scripts", "build-jsc"));
-runInFlatpak(@command);
-}
-
-
-my $shouldRunStaticAnalyzer = 0;
-my $minimal = 0;
-my $coverageSupport = 0;
-my $showHelp = 0;
-my $ftlJIT = int(isAppleCocoaWebKit() && !willUseIOSSimulatorSDK() || ((isARM64() || isX86_64()) && (isGtk() || isJSCOnly(;
-my $forceCLoop = 0;
-my $makeArgs = "";
-my @cmakeArgs;
-my $buildDir = "";
-my $startTime = time();
-my $useCCache = -1;
-my $exportCompileCommands = 0;
-
-my @features = getFeatureOptionList();
-
-# Initialize values from defaults
-foreach (@ARGV) {
-if ($_ eq '--minimal') {
-$minimal = 1;
-}
-}
-
-# Initialize values from defaults
-foreach (@features) {
-${$_->{value}} = ($minimal ? 0 : $_->{default});
-}
-
-# Additional environment parameters
-push @ARGV, parse_line('\s+', 0, $ENV{'BUILD_JSC_ARGS'}) if ($ENV{'BUILD_JSC_ARGS'});
-
-my $programName = basename($0);
-my $usage = \$shouldRunStaticAnalyzer,
-'coverage!' => \$coverageSupport,
-'help' => \$showHelp,
-'ftl-jit!' => \$ftlJIT,
-'cloop!' => \$forceCLoop,
-'makeargs=s' => \$makeArgs,
-'cmakeargs=s' => \@cmakeArgs,
-'build-dir=s' => \$buildDir,
-'use-ccache!' => \$useCCache,
-'export-compile-commands' => \$exportCompileCommands
-);
-
-foreach (@features) {
-if ($_->{_javascript_}) {
-my $opt = sprintf("%-35s", " --[no-]$_->{option}");
-$usage .= "$opt $_->{desc} (default: $_->{default})\n";
-$options{"$_->{option}!"} = $_->{value};
-}
-}
-
[webkit-changes] [291574] trunk/Source/WebCore
Title: [291574] trunk/Source/WebCore
Revision 291574
Author grao...@webkit.org
Date 2022-03-21 12:16:37 -0700 (Mon, 21 Mar 2022)
Log Message
[media-controls] scrubbing on iOS when inline does not work
https://bugs.webkit.org/show_bug.cgi?id=238138
rdar://90046770
Reviewed by Dean Jackson.
This bug is simular to bug 238136. We cannot register pointer events on window on iOS.
* Modules/modern-media-controls/controls/slider.js:
(Slider.prototype._interactionEndTarget):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/modern-media-controls/controls/slider.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (291573 => 291574)
--- trunk/Source/WebCore/ChangeLog 2022-03-21 19:11:22 UTC (rev 291573)
+++ trunk/Source/WebCore/ChangeLog 2022-03-21 19:16:37 UTC (rev 291574)
@@ -1,5 +1,18 @@
2022-03-21 Antoine Quint
+[media-controls] scrubbing on iOS when inline does not work
+https://bugs.webkit.org/show_bug.cgi?id=238138
+rdar://90046770
+
+Reviewed by Dean Jackson.
+
+This bug is simular to bug 238136. We cannot register pointer events on window on iOS.
+
+* Modules/modern-media-controls/controls/slider.js:
+(Slider.prototype._interactionEndTarget):
+
+2022-03-21 Antoine Quint
+
[media-controls] tap gesture recognizer sometimes fails to recognize on iOS
https://bugs.webkit.org/show_bug.cgi?id=238136
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/slider.js (291573 => 291574)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/slider.js 2022-03-21 19:11:22 UTC (rev 291573)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/slider.js 2022-03-21 19:16:37 UTC (rev 291574)
@@ -190,6 +190,8 @@
_interactionEndTarget()
{
const mediaControls = this.parentOfType(MediaControls);
+if (GestureRecognizer.SupportsTouches)
+return mediaControls.element;
return (!mediaControls || !mediaControls.layoutTraits.isFullscreen) ? window : mediaControls.element;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291573] trunk/Source/WebKit
Title: [291573] trunk/Source/WebKit Revision 291573 Author pvol...@apple.com Date 2022-03-21 12:11:22 -0700 (Mon, 21 Mar 2022) Log Message [watchOS] Add required syscall https://bugs.webkit.org/show_bug.cgi?id=238117 Reviewed by Brent Fulgham. Add rarely used syscall on watchOS. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (291572 => 291573) --- trunk/Source/WebKit/ChangeLog 2022-03-21 19:00:18 UTC (rev 291572) +++ trunk/Source/WebKit/ChangeLog 2022-03-21 19:11:22 UTC (rev 291573) @@ -1,3 +1,15 @@ +2022-03-21 Per Arne Vollan + +[watchOS] Add required syscall +https://bugs.webkit.org/show_bug.cgi?id=238117 + + +Reviewed by Brent Fulgham. + +Add rarely used syscall on watchOS. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: + 2022-03-21 Youenn Fablet Remove unneeded quotes in capture attribution string Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (291572 => 291573) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-03-21 19:00:18 UTC (rev 291572) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-03-21 19:11:22 UTC (rev 291573) @@ -1278,6 +1278,9 @@ SYS_setrlimit SYS_sigaltstack SYS_sigprocmask +#if PLATFORM(WATCHOS) +SYS_sigreturn +#endif SYS_socket SYS_thread_selfusage SYS_unlink ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291572] trunk/Source/WebCore
Title: [291572] trunk/Source/WebCore
Revision 291572
Author grao...@webkit.org
Date 2022-03-21 12:00:18 -0700 (Mon, 21 Mar 2022)
Log Message
[media-controls] tap gesture recognizer sometimes fails to recognize on iOS
https://bugs.webkit.org/show_bug.cgi?id=238136
Reviewed by Dean Jackson.
While on macOS it's fine to register pointer events handlers on the `window` object,
on iOS it may not be depending on the fullscreen state. However, it's always fine to
use the gesture recognizer's target on iOS, so let's default to that when touches
are supported.
* Modules/modern-media-controls/gesture-recognizers/gesture-recognizer.js:
(GestureRecognizer.prototype.touchesBegan):
(GestureRecognizer.prototype.get _captureTarget):
(GestureRecognizer.prototype._removeTrackingListeners):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/modern-media-controls/gesture-recognizers/gesture-recognizer.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (291571 => 291572)
--- trunk/Source/WebCore/ChangeLog 2022-03-21 18:58:31 UTC (rev 291571)
+++ trunk/Source/WebCore/ChangeLog 2022-03-21 19:00:18 UTC (rev 291572)
@@ -1,3 +1,20 @@
+2022-03-21 Antoine Quint
+
+[media-controls] tap gesture recognizer sometimes fails to recognize on iOS
+https://bugs.webkit.org/show_bug.cgi?id=238136
+
+Reviewed by Dean Jackson.
+
+While on macOS it's fine to register pointer events handlers on the `window` object,
+on iOS it may not be depending on the fullscreen state. However, it's always fine to
+use the gesture recognizer's target on iOS, so let's default to that when touches
+are supported.
+
+* Modules/modern-media-controls/gesture-recognizers/gesture-recognizer.js:
+(GestureRecognizer.prototype.touchesBegan):
+(GestureRecognizer.prototype.get _captureTarget):
+(GestureRecognizer.prototype._removeTrackingListeners):
+
2022-03-21 Tyler Wilcock
AX: Include display: contents elements in the AX tree
Modified: trunk/Source/WebCore/Modules/modern-media-controls/gesture-recognizers/gesture-recognizer.js (291571 => 291572)
--- trunk/Source/WebCore/Modules/modern-media-controls/gesture-recognizers/gesture-recognizer.js 2022-03-21 18:58:31 UTC (rev 291571)
+++ trunk/Source/WebCore/Modules/modern-media-controls/gesture-recognizers/gesture-recognizer.js 2022-03-21 19:00:18 UTC (rev 291572)
@@ -125,9 +125,9 @@
if (event.currentTarget !== this._target)
return;
-window.addEventListener(GestureRecognizer.Events.PointerMove, this, true);
-window.addEventListener(GestureRecognizer.Events.PointerUp, this, true);
-window.addEventListener(GestureRecognizer.Events.PointerCancel, this, true);
+this._captureTarget.addEventListener(GestureRecognizer.Events.PointerMove, this, true);
+this._captureTarget.addEventListener(GestureRecognizer.Events.PointerUp, this, true);
+this._captureTarget.addEventListener(GestureRecognizer.Events.PointerCancel, this, true);
this.enterPossibleState();
}
@@ -269,11 +269,18 @@
}
}
+get _captureTarget()
+{
+if (GestureRecognizer.SupportsTouches)
+return this._target;
+return window;
+}
+
_removeTrackingListeners()
{
-window.removeEventListener(GestureRecognizer.Events.PointerMove, this, true);
-window.removeEventListener(GestureRecognizer.Events.PointerUp, this, true);
-window.removeEventListener(GestureRecognizer.Events.PointerCancel, this, true);
+this._captureTarget.removeEventListener(GestureRecognizer.Events.PointerMove, this, true);
+this._captureTarget.removeEventListener(GestureRecognizer.Events.PointerUp, this, true);
+this._captureTarget.removeEventListener(GestureRecognizer.Events.PointerCancel, this, true);
this._target.removeEventListener(GestureRecognizer.Events.GestureChange, this, true);
this._target.removeEventListener(GestureRecognizer.Events.GestureEnd, this, true);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291571] trunk/Source/WebGPU
Title: [291571] trunk/Source/WebGPU
Revision 291571
Author mmaxfi...@apple.com
Date 2022-03-21 11:58:31 -0700 (Mon, 21 Mar 2022)
Log Message
[WebGPU] Implement error reporting facilities
https://bugs.webkit.org/show_bug.cgi?id=238131
Reviewed by Kimmo Kinnunen.
This patch implements the GPUDevice.pushErrorScope() and GPUDevice.popErrorScope() functions,
according to the spec.
Now that we can report errors, we should be just about able to pass our first CTS test.
* CommandLinePlayground/main.swift:
* WebGPU/Buffer.mm:
(WebGPU::Buffer::mapAsync):
(WebGPU::Buffer::unmap):
* WebGPU/CommandEncoder.h:
(WebGPU::CommandEncoder::create):
* WebGPU/CommandEncoder.mm:
(WebGPU::Device::createCommandEncoder):
(WebGPU::CommandEncoder::CommandEncoder):
(WebGPU::CommandEncoder::copyBufferToBuffer):
(WebGPU::CommandEncoder::clearBuffer):
(WebGPU::CommandEncoder::finish):
* WebGPU/Device.h:
* WebGPU/Device.mm:
(WebGPU::Device::currentErrorScope):
(WebGPU::Device::generateAValidationError):
(WebGPU::Device::validatePopErrorScope const):
(WebGPU::Device::popErrorScope):
(WebGPU::Device::pushErrorScope):
(WebGPU::Device::setUncapturedErrorCallback):
* WebGPU/Queue.h:
* WebGPU/Queue.mm:
(WebGPU::Queue::submit):
* WebGPU/Sampler.h:
(WebGPU::Sampler::create):
* WebGPU/Sampler.mm:
(WebGPU::Device::createSampler):
(WebGPU::Sampler::Sampler):
Modified Paths
trunk/Source/WebGPU/ChangeLog
trunk/Source/WebGPU/CommandLinePlayground/main.swift
trunk/Source/WebGPU/WebGPU/Buffer.mm
trunk/Source/WebGPU/WebGPU/CommandEncoder.h
trunk/Source/WebGPU/WebGPU/CommandEncoder.mm
trunk/Source/WebGPU/WebGPU/Device.h
trunk/Source/WebGPU/WebGPU/Device.mm
trunk/Source/WebGPU/WebGPU/Queue.h
trunk/Source/WebGPU/WebGPU/Queue.mm
trunk/Source/WebGPU/WebGPU/Sampler.h
trunk/Source/WebGPU/WebGPU/Sampler.mm
Diff
Modified: trunk/Source/WebGPU/ChangeLog (291570 => 291571)
--- trunk/Source/WebGPU/ChangeLog 2022-03-21 18:48:25 UTC (rev 291570)
+++ trunk/Source/WebGPU/ChangeLog 2022-03-21 18:58:31 UTC (rev 291571)
@@ -1,3 +1,44 @@
+2022-03-21 Myles C. Maxfield
+
+[WebGPU] Implement error reporting facilities
+https://bugs.webkit.org/show_bug.cgi?id=238131
+
+Reviewed by Kimmo Kinnunen.
+
+This patch implements the GPUDevice.pushErrorScope() and GPUDevice.popErrorScope() functions,
+according to the spec.
+
+Now that we can report errors, we should be just about able to pass our first CTS test.
+
+* CommandLinePlayground/main.swift:
+* WebGPU/Buffer.mm:
+(WebGPU::Buffer::mapAsync):
+(WebGPU::Buffer::unmap):
+* WebGPU/CommandEncoder.h:
+(WebGPU::CommandEncoder::create):
+* WebGPU/CommandEncoder.mm:
+(WebGPU::Device::createCommandEncoder):
+(WebGPU::CommandEncoder::CommandEncoder):
+(WebGPU::CommandEncoder::copyBufferToBuffer):
+(WebGPU::CommandEncoder::clearBuffer):
+(WebGPU::CommandEncoder::finish):
+* WebGPU/Device.h:
+* WebGPU/Device.mm:
+(WebGPU::Device::currentErrorScope):
+(WebGPU::Device::generateAValidationError):
+(WebGPU::Device::validatePopErrorScope const):
+(WebGPU::Device::popErrorScope):
+(WebGPU::Device::pushErrorScope):
+(WebGPU::Device::setUncapturedErrorCallback):
+* WebGPU/Queue.h:
+* WebGPU/Queue.mm:
+(WebGPU::Queue::submit):
+* WebGPU/Sampler.h:
+(WebGPU::Sampler::create):
+* WebGPU/Sampler.mm:
+(WebGPU::Device::createSampler):
+(WebGPU::Sampler::Sampler):
+
2022-03-18 Myles C. Maxfield
[WebGPU] Add #pragma marks to strategic places
Modified: trunk/Source/WebGPU/CommandLinePlayground/main.swift (291570 => 291571)
--- trunk/Source/WebGPU/CommandLinePlayground/main.swift 2022-03-21 18:48:25 UTC (rev 291570)
+++ trunk/Source/WebGPU/CommandLinePlayground/main.swift 2022-03-21 18:58:31 UTC (rev 291571)
@@ -58,6 +58,8 @@
}
print("Device: \(String(describing: device))")
+wgpuDevicePushErrorScope(device, WGPUErrorFilter_Validation)
+
var uploadBufferDescriptor = WGPUBufferDescriptor(nextInChain: nil, label: nil, usage: WGPUBufferUsage_MapWrite.rawValue | WGPUBufferUsage_CopySrc.rawValue, size: UInt64(MemoryLayout.size), mappedAtCreation: false)
let uploadBuffer = wgpuDeviceCreateBuffer(device, )
assert(uploadBuffer != nil)
@@ -100,7 +102,18 @@
let readPointer = wgpuBufferGetMappedRange(downloadBuffer, 0, MemoryLayout.size).bindMemory(to: Int32.self, capacity: 1)
print("Result: \(readPointer[0])")
wgpuBufferUnmap(downloadBuffer)
-CFRunLoopStop(CFRunLoopGetMain())
+wgpuDevicePopErrorScopeWithBlock(device) { (type: WGPUErrorType, message: Optional>) in
+if type != WGPUErrorType_NoError {
+if message != nil {
+print("Message: \(String(cString: message!))")
+} else {
+print("Empty
[webkit-changes] [291570] trunk
Title: [291570] trunk Revision 291570 Author tyle...@apple.com Date 2022-03-21 11:48:25 -0700 (Mon, 21 Mar 2022) Log Message AX: Include display: contents elements in the AX tree https://bugs.webkit.org/show_bug.cgi?id=237834 Reviewed by Chris Fleizach. Source/WebCore: Because display: contents intentionally prevents a render object from being generated for the element it's applied to, we don't add it to the AX tree as part of our normal render tree walk, making these elements inaccessible. This patch includes these elements as part of the DOM walk that addHiddenChildren (now renamed to addNodeOnlyChildren) already does. Also, because display: contents moves the affected element's children up a level in the render tree, this patch also special cases: 1. AccessibilityRenderObject::parentObject and similar methods to return their display: contents parent instead of their render tree parent 2. AccessibilityObject::insertChild to only insert display: contents children to their display: contents parent, rather than their render tree parent Test: accessibility/display-contents-element-roles.html, accessibility/aria-hidden-display-contents-element.html * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate): Allow creation of AX objects from display: contents `Node`s. Also, don't create an object for a renderer that is in the process of being destroyed (prevents display-contents-element-roles.html from crashing in ITM) * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::displayContentsParent const): (WebCore::AccessibilityObject::insertChild): If an object has a display: contents parent, and that parent isn't `this`, return early. * accessibility/AccessibilityObject.h: * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::parentObjectIfExists const): (WebCore::AccessibilityRenderObject::parentObject const): (WebCore::AccessibilityRenderObject::parentObjectUnignored const): If an object has a display: contents parent, return that instead of its render tree parent. (WebCore::AccessibilityRenderObject::addNodeOnlyChildren): Renamed from addHiddenChildren. (WebCore::AccessibilityRenderObject::addChildren): Don't clear m_subtreeDirty until after all children have been added. Necessary to make aria-hidden-display-contents-element.html pass, as we were clearing this too early, causing display: contents subtrees to not be updated after aria-hidden changes. (WebCore::AccessibilityRenderObject::addHiddenChildren): Renamed to addNodeOnlyChildren. * accessibility/AccessibilityRenderObject.h: LayoutTests: * accessibility/aria-hidden-display-contents-element-expected.txt: Added. * accessibility/aria-hidden-display-contents-element.html: Added. * accessibility/display-contents-element-roles-expected.txt: Added. * accessibility/display-contents-element-roles.html: Added. * platform/glib/accessibility/aria-hidden-display-contents-element-expected.txt: Added. * platform/glib/accessibility/display-contents-element-roles-expected.txt: Added. * platform/ios/TestExpectations: Enable new tests. * platform/ios/accessibility/aria-hidden-display-contents-element-expected.txt: Added. * platform/ios/accessibility/display-contents-element-roles-expected.txt: Added. * platform/win/TestExpectations: Skip display-contents-element-roles.html. * platform/win/accessibility/aria-hidden-display-contents-element-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/win/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AXObjectCache.cpp trunk/Source/WebCore/accessibility/AccessibilityObject.cpp trunk/Source/WebCore/accessibility/AccessibilityObject.h trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h Added Paths trunk/LayoutTests/accessibility/aria-hidden-display-contents-element-expected.txt trunk/LayoutTests/accessibility/aria-hidden-display-contents-element.html trunk/LayoutTests/accessibility/display-contents-element-roles-expected.txt trunk/LayoutTests/accessibility/display-contents-element-roles.html trunk/LayoutTests/platform/glib/accessibility/aria-hidden-display-contents-element-expected.txt trunk/LayoutTests/platform/glib/accessibility/display-contents-element-roles-expected.txt trunk/LayoutTests/platform/ios/accessibility/aria-hidden-display-contents-element-expected.txt trunk/LayoutTests/platform/ios/accessibility/display-contents-element-roles-expected.txt trunk/LayoutTests/platform/win/accessibility/aria-hidden-display-contents-element-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (291569 => 291570) --- trunk/LayoutTests/ChangeLog 2022-03-21 18:01:29 UTC (rev 291569) +++ trunk/LayoutTests/ChangeLog 2022-03-21 18:48:25 UTC (rev 291570) @@ -1,3 +1,22 @@ +2022-03-21 Tyler Wilcock + +AX: Include display: contents
[webkit-changes] [291569] branches/safari-614.1.7-branch/Source/WebCore
Title: [291569] branches/safari-614.1.7-branch/Source/WebCore Revision 291569 Author repst...@apple.com Date 2022-03-21 11:01:29 -0700 (Mon, 21 Mar 2022) Log Message Cherry-pick r291514. rdar://problem/90500863 [iOS] Fix more build breakage from r291361 https://bugs.webkit.org/show_bug.cgi?id=238097 Unreviewed build fix. * platform/ios/WebAVPlayerController.mm: Declare AVAssetTrack. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291514 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-614.1.7-branch/Source/WebCore/ChangeLog branches/safari-614.1.7-branch/Source/WebCore/platform/ios/WebAVPlayerController.mm Diff Modified: branches/safari-614.1.7-branch/Source/WebCore/ChangeLog (291568 => 291569) --- branches/safari-614.1.7-branch/Source/WebCore/ChangeLog 2022-03-21 18:00:07 UTC (rev 291568) +++ branches/safari-614.1.7-branch/Source/WebCore/ChangeLog 2022-03-21 18:01:29 UTC (rev 291569) @@ -1,3 +1,29 @@ +2022-03-21 Russell Epstein + +Cherry-pick r291514. rdar://problem/90500863 + +[iOS] Fix more build breakage from r291361 +https://bugs.webkit.org/show_bug.cgi?id=238097 + + +Unreviewed build fix. + + +* platform/ios/WebAVPlayerController.mm: Declare AVAssetTrack. + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291514 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2022-03-18 Eric Carlson + +[iOS] Fix more build breakage from r291361 +https://bugs.webkit.org/show_bug.cgi?id=238097 + + +Unreviewed build fix. + +* platform/ios/WebAVPlayerController.mm: Declare AVAssetTrack. + 2022-03-18 Jonathan Bedard [iOS 15.4] Fix unused variables Modified: branches/safari-614.1.7-branch/Source/WebCore/platform/ios/WebAVPlayerController.mm (291568 => 291569) --- branches/safari-614.1.7-branch/Source/WebCore/platform/ios/WebAVPlayerController.mm 2022-03-21 18:00:07 UTC (rev 291568) +++ branches/safari-614.1.7-branch/Source/WebCore/platform/ios/WebAVPlayerController.mm 2022-03-21 18:01:29 UTC (rev 291569) @@ -44,6 +44,7 @@ SOFT_LINK_CLASS_OPTIONAL(AVKit, AVPlayerController) SOFT_LINK_CLASS_OPTIONAL(AVKit, AVValueTiming) +OBJC_CLASS AVAssetTrack; OBJC_CLASS AVMetadataItem; using namespace WebCore; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291568] trunk/Source/WebCore
Title: [291568] trunk/Source/WebCore Revision 291568 Author obru...@igalia.com Date 2022-03-21 11:00:07 -0700 (Mon, 21 Mar 2022) Log Message [css-cascade] Don't defer applying text decoration properties https://bugs.webkit.org/show_bug.cgi?id=238126 Reviewed by Darin Adler. shouldApplyPropertyInParseOrder() was returning true for these: - webkit-text-decoration - text-decoration-line - text-decoration-style - text-decoration-color - text-decoration-skip - text-decoration-skip-ink - text-underline-position - text-underline-offset - text-decoration-thickness - text-decoration This was previously needed for text-decoration-line and text-decoration, since they were implemented as longhands that shared a computed value. But that's no longer the case, text-decoration became a shorthand in bug 237175. AFAIK -webkit-text-decoration has always been a shorthand since it was implemented in bug 92000, so having it in the list it's pointless, only longhands matter. And text-decoration-skip became a shorthand in bug 230244, so it's also pointless. The other longhands seem unnecessary too, since they don't share a computed style with other properties. No test since there should be no observable change in behavior. * style/PropertyCascade.cpp: (WebCore::Style::shouldApplyPropertyInParseOrder): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/style/PropertyCascade.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (291567 => 291568) --- trunk/Source/WebCore/ChangeLog 2022-03-21 17:58:21 UTC (rev 291567) +++ trunk/Source/WebCore/ChangeLog 2022-03-21 18:00:07 UTC (rev 291568) @@ -1,3 +1,40 @@ +2022-03-21 Oriol Brufau + +[css-cascade] Don't defer applying text decoration properties +https://bugs.webkit.org/show_bug.cgi?id=238126 + +Reviewed by Darin Adler. + +shouldApplyPropertyInParseOrder() was returning true for these: + - webkit-text-decoration + - text-decoration-line + - text-decoration-style + - text-decoration-color + - text-decoration-skip + - text-decoration-skip-ink + - text-underline-position + - text-underline-offset + - text-decoration-thickness + - text-decoration + +This was previously needed for text-decoration-line and text-decoration, +since they were implemented as longhands that shared a computed value. +But that's no longer the case, text-decoration became a shorthand in bug +237175. + +AFAIK -webkit-text-decoration has always been a shorthand since it was +implemented in bug 92000, so having it in the list it's pointless, +only longhands matter. And text-decoration-skip became a shorthand in +bug 230244, so it's also pointless. + +The other longhands seem unnecessary too, since they don't share a +computed style with other properties. + +No test since there should be no observable change in behavior. + +* style/PropertyCascade.cpp: +(WebCore::Style::shouldApplyPropertyInParseOrder): + 2022-03-21 Youenn Fablet Remove unneeded quotes in capture attribution string Modified: trunk/Source/WebCore/style/PropertyCascade.cpp (291567 => 291568) --- trunk/Source/WebCore/style/PropertyCascade.cpp 2022-03-21 17:58:21 UTC (rev 291567) +++ trunk/Source/WebCore/style/PropertyCascade.cpp 2022-03-21 18:00:07 UTC (rev 291568) @@ -56,16 +56,6 @@ case CSSPropertyBorderImageWidth: case CSSPropertyWebkitBoxShadow: case CSSPropertyBoxShadow: -case CSSPropertyWebkitTextDecoration: -case CSSPropertyTextDecorationLine: -case CSSPropertyTextDecorationStyle: -case CSSPropertyTextDecorationColor: -case CSSPropertyTextDecorationSkip: -case CSSPropertyTextDecorationSkipInk: -case CSSPropertyTextUnderlinePosition: -case CSSPropertyTextUnderlineOffset: -case CSSPropertyTextDecorationThickness: -case CSSPropertyTextDecoration: return true; default: return CSSProperty::isInLogicalPropertyGroup(propertyID); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291567] trunk/Source
Title: [291567] trunk/Source Revision 291567 Author you...@apple.com Date 2022-03-21 10:58:21 -0700 (Mon, 21 Mar 2022) Log Message Remove unneeded quotes in capture attribution string https://bugs.webkit.org/show_bug.cgi?id=238132 Reviewed by Eric Carlson. Source/WebCore: * en.lproj/Localizable.strings: Source/WebKit: Quotes are unneeded and made it less clear to read. * GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm: (WebKit::GPUConnectionToWebProcess::setCaptureAttributionString): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/en.lproj/Localizable.strings trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm Diff Modified: trunk/Source/WebCore/ChangeLog (291566 => 291567) --- trunk/Source/WebCore/ChangeLog 2022-03-21 17:53:58 UTC (rev 291566) +++ trunk/Source/WebCore/ChangeLog 2022-03-21 17:58:21 UTC (rev 291567) @@ -1,3 +1,13 @@ +2022-03-21 Youenn Fablet + +Remove unneeded quotes in capture attribution string +https://bugs.webkit.org/show_bug.cgi?id=238132 + + +Reviewed by Eric Carlson. + +* en.lproj/Localizable.strings: + 2022-03-21 Kimmo Kinnunen Accessing WebGL content crashes in macOS Recovery OS Modified: trunk/Source/WebCore/en.lproj/Localizable.strings (291566 => 291567) --- trunk/Source/WebCore/en.lproj/Localizable.strings 2022-03-21 17:53:58 UTC (rev 291566) +++ trunk/Source/WebCore/en.lproj/Localizable.strings 2022-03-21 17:58:21 UTC (rev 291567) @@ -1676,7 +1676,7 @@ "“%@” Would Like to Access Motion and Orientation" = "“%@” Would Like to Access Motion and Orientation"; /* The domain and application using the camera and/or microphone. The first argument is domain, the second is the application name (iOS only). */ -"“%@” in “%%@”" = "“%@” in “%%@”"; +"%@ in %%@" = "%@ in %%@"; /* Allow the specified bundle to sign in to the specified website */ "“%@” would like to sign in to “%@”." = "“%@” would like to sign in to “%@”."; Modified: trunk/Source/WebKit/ChangeLog (291566 => 291567) --- trunk/Source/WebKit/ChangeLog 2022-03-21 17:53:58 UTC (rev 291566) +++ trunk/Source/WebKit/ChangeLog 2022-03-21 17:58:21 UTC (rev 291567) @@ -1,3 +1,16 @@ +2022-03-21 Youenn Fablet + +Remove unneeded quotes in capture attribution string +https://bugs.webkit.org/show_bug.cgi?id=238132 + + +Reviewed by Eric Carlson. + +Quotes are unneeded and made it less clear to read. + +* GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm: +(WebKit::GPUConnectionToWebProcess::setCaptureAttributionString): + 2022-03-21 Tim Horton Add an addition point for system background color Modified: trunk/Source/WebKit/GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm (291566 => 291567) --- trunk/Source/WebKit/GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm 2022-03-21 17:53:58 UTC (rev 291566) +++ trunk/Source/WebKit/GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm 2022-03-21 17:58:21 UTC (rev 291567) @@ -60,7 +60,7 @@ if (!visibleName) visibleName = gpuProcess().applicationVisibleName(); -RetainPtr formatString = [NSString stringWithFormat:WEB_UI_NSSTRING(@"“%@” in “%%@”", "The domain and application using the camera and/or microphone. The first argument is domain, the second is the application name (iOS only)."), visibleName]; +RetainPtr formatString = [NSString stringWithFormat:WEB_UI_NSSTRING(@"%@ in %%@", "The domain and application using the camera and/or microphone. The first argument is domain, the second is the application name (iOS only)."), visibleName]; [PAL::getSTDynamicActivityAttributionPublisherClass() setCurrentAttributionStringWithFormat:formatString.get() auditToken:auditToken.value()]; #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291566] trunk/Source/WebCore
Title: [291566] trunk/Source/WebCore
Revision 291566
Author commit-qu...@webkit.org
Date 2022-03-21 10:53:58 -0700 (Mon, 21 Mar 2022)
Log Message
Accessing WebGL content crashes in macOS Recovery OS
https://bugs.webkit.org/show_bug.cgi?id=238139
Patch by Kimmo Kinnunen on 2022-03-21
Reviewed by Antti Koivisto.
Add a quick fix trying to circumvent a Recovery OS crash.
Parts of this will be reverted once the true source is found.
* platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::platformSupportsMetal):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (291565 => 291566)
--- trunk/Source/WebCore/ChangeLog 2022-03-21 17:47:37 UTC (rev 291565)
+++ trunk/Source/WebCore/ChangeLog 2022-03-21 17:53:58 UTC (rev 291566)
@@ -1,3 +1,16 @@
+2022-03-21 Kimmo Kinnunen
+
+Accessing WebGL content crashes in macOS Recovery OS
+https://bugs.webkit.org/show_bug.cgi?id=238139
+
+Reviewed by Antti Koivisto.
+
+Add a quick fix trying to circumvent a Recovery OS crash.
+Parts of this will be reverted once the true source is found.
+
+* platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
+(WebCore::platformSupportsMetal):
+
2022-03-21 Tim Horton
Add an addition point for system background color
Modified: trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm (291565 => 291566)
--- trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm 2022-03-21 17:47:37 UTC (rev 291565)
+++ trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm 2022-03-21 17:53:58 UTC (rev 291566)
@@ -41,6 +41,7 @@
#import
#import
#import
+#import
#import
#if PLATFORM(IOS_FAMILY)
@@ -57,6 +58,9 @@
#import "ImageRotationSessionVT.h"
#endif
+// Metal may not be available, for example in recovery OS.
+WTF_WEAK_LINK_FORCE_IMPORT(MTLCreateSystemDefaultDevice);
+
namespace WebCore {
// In isCurrentContextPredictable() == true case this variable is accessed in single-threaded manner.
@@ -96,6 +100,22 @@
static bool platformSupportsMetal(bool isWebGL2)
{
+// FIXME: Figure out why WebKit runs in recovery system using -framework Metal, but seemingly cannot call into Metal.
+// The hunk about runnningInRecoverySystem should be removed once it is clear how WebKit can link strongly to Metal
+// but run without Metal.
+static bool runningInRecoverySystem = [] {
+if (getenv("__OSINSTALL_ENVIRONMENT")) {
+WTFLogAlways("WebGL: Running in recovery. Has access to Metal: %s", !MTLCreateSystemDefaultDevice ? "no" : "yes");
+return true;
+}
+return false;
+}();
+if (runningInRecoverySystem)
+return false;
+
+if (!MTLCreateSystemDefaultDevice)
+return false;
+
auto device = adoptNS(MTLCreateSystemDefaultDevice());
if (device) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291565] branches/safari-614.1.7-branch/
Title: [291565] branches/safari-614.1.7-branch/ Revision 291565 Author repst...@apple.com Date 2022-03-21 10:47:37 -0700 (Mon, 21 Mar 2022) Log Message New branch. Added Paths branches/safari-614.1.7-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291564] trunk/Source
Title: [291564] trunk/Source
Revision 291564
Author timothy_hor...@apple.com
Date 2022-03-21 10:44:45 -0700 (Mon, 21 Mar 2022)
Log Message
Add an addition point for system background color
https://bugs.webkit.org/show_bug.cgi?id=238108
Reviewed by Aditya Keerthi.
Source/WebCore:
* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/ios/WebCoreUIColorExtras.h: Added.
* platform/ios/WebCoreUIColorExtras.mm: Added.
(WebCore::systemBackgroundColor):
Add an addition point.
* rendering/RenderThemeIOS.mm:
(WebCore::CSSValueSystemColorInformation::function):
(WebCore::cssValueSystemColorInformationList):
(WebCore::systemColorFromCSSValueSystemColorInformation):
Adopt it for CSS use of system background color.
Source/WebKit:
* UIProcess/API/ios/WKWebViewIOS.mm:
(scrollViewBackgroundColor):
Adopt systemBackgroundColor().
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::contentViewBackgroundColor):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::platformUnderPageBackgroundColor const):
Move the fallback to systemBackgroundColor into PageClientImpl
so that it can realize the web view's trait collection.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/rendering/RenderThemeIOS.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
Added Paths
trunk/Source/WebCore/platform/ios/WebCoreUIColorExtras.h
trunk/Source/WebCore/platform/ios/WebCoreUIColorExtras.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (291563 => 291564)
--- trunk/Source/WebCore/ChangeLog 2022-03-21 17:37:08 UTC (rev 291563)
+++ trunk/Source/WebCore/ChangeLog 2022-03-21 17:44:45 UTC (rev 291564)
@@ -1,3 +1,24 @@
+2022-03-21 Tim Horton
+
+Add an addition point for system background color
+https://bugs.webkit.org/show_bug.cgi?id=238108
+
+
+Reviewed by Aditya Keerthi.
+
+* SourcesCocoa.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* platform/ios/WebCoreUIColorExtras.h: Added.
+* platform/ios/WebCoreUIColorExtras.mm: Added.
+(WebCore::systemBackgroundColor):
+Add an addition point.
+
+* rendering/RenderThemeIOS.mm:
+(WebCore::CSSValueSystemColorInformation::function):
+(WebCore::cssValueSystemColorInformationList):
+(WebCore::systemColorFromCSSValueSystemColorInformation):
+Adopt it for CSS use of system background color.
+
2022-03-21 Alex Christensen
Dust off Mac CMake build
Modified: trunk/Source/WebCore/SourcesCocoa.txt (291563 => 291564)
--- trunk/Source/WebCore/SourcesCocoa.txt 2022-03-21 17:37:08 UTC (rev 291563)
+++ trunk/Source/WebCore/SourcesCocoa.txt 2022-03-21 17:44:45 UTC (rev 291564)
@@ -480,6 +480,7 @@
platform/ios/WebBackgroundTaskController.mm
platform/ios/WebCoreMotionManager.mm
platform/ios/WebEvent.mm @no-unify
+platform/ios/WebCoreUIColorExtras.mm
platform/ios/WebItemProviderPasteboard.mm @no-unify
platform/ios/WebSQLiteDatabaseTrackerClient.mm
platform/ios/WebVideoFullscreenControllerAVKit.mm @no-unify
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (291563 => 291564)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2022-03-21 17:37:08 UTC (rev 291563)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2022-03-21 17:44:45 UTC (rev 291564)
@@ -862,6 +862,7 @@
2D8B92FD203D13E1009C868F /* UnifiedSource528.cpp in Sources */ = {isa = PBXBuildFile; fileRef = DE5F85D21FA23856006DB63B /* UnifiedSource528.cpp */; };
2D8B92FE203D13E1009C868F /* UnifiedSource529.cpp in Sources */ = {isa = PBXBuildFile; fileRef = DE5F85CF1FA23850006DB63B /* UnifiedSource529.cpp */; };
2D8B92FF203D13E1009C868F /* UnifiedSource530.cpp in Sources */ = {isa = PBXBuildFile; fileRef = DE5F85D31FA23859006DB63B /* UnifiedSource530.cpp */; };
+ 2D8BA18127E5A487008F7E52 /* WebCoreUIColorExtras.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D8BA18027E5A47B008F7E52 /* WebCoreUIColorExtras.h */; settings = {ATTRIBUTES = (Private, ); }; };
2D8FEBDD143E3EF70072502B /* CSSCrossfadeValue.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D8FEBDB143E3EF70072502B /* CSSCrossfadeValue.h */; };
2D9066070BE141D400956998 /* RenderLayoutState.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D9066050BE141D400956998 /* RenderLayoutState.h */; settings = {ATTRIBUTES = (Private, ); }; };
2D93AEE319DF5641002A86C3 /* ServicesOverlayController.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D93AEE119DF5641002A86C3 /* ServicesOverlayController.h */; };
@@ -8107,6 +8108,8 @@
2D7ED0A91BAE99170043B3E5 /* TimerEventBasedMock.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TimerEventBasedMock.h; sourceTree = ""; };
[webkit-changes] [291559] trunk/Source
Title: [291559] trunk/Source
Revision 291559
Author jbed...@apple.com
Date 2022-03-21 09:29:00 -0700 (Mon, 21 Mar 2022)
Log Message
Unreviewed, reverting r291558.
Exceeded GitHub file size limit
Reverted changeset:
"Enable PGO when building for release and production"
https://bugs.webkit.org/show_bug.cgi?id=238119
https://commits.webkit.org/r291558
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/Base.xcconfig
trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/Base.xcconfig
trunk/Source/WebCore/Configurations/WebCore.xcconfig
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/Base.xcconfig
trunk/Source/WebKit/Configurations/WebKit.xcconfig
Removed Paths
trunk/Source/_javascript_Core/Profiling/
trunk/Source/WebCore/Profiling/
trunk/Source/WebKit/Profiling/
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (291558 => 291559)
--- trunk/Source/_javascript_Core/ChangeLog 2022-03-21 15:25:59 UTC (rev 291558)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-03-21 16:29:00 UTC (rev 291559)
@@ -1,3 +1,15 @@
+2022-03-21 Jonathan Bedard
+
+Unreviewed, reverting r291558.
+
+Exceeded GitHub file size limit
+
+Reverted changeset:
+
+"Enable PGO when building for release and production"
+https://bugs.webkit.org/show_bug.cgi?id=238119
+https://commits.webkit.org/r291558
+
2022-03-21 Wenson Hsieh
Enable PGO when building for release and production
Modified: trunk/Source/_javascript_Core/Configurations/Base.xcconfig (291558 => 291559)
--- trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2022-03-21 15:25:59 UTC (rev 291558)
+++ trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2022-03-21 16:29:00 UTC (rev 291559)
@@ -106,7 +106,7 @@
GCC_WARN_UNUSED_VARIABLE = YES;
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
PREBINDING = NO;
-WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wvla -Wliteral-conversion -Wthread-safety -Wno-profile-instr-out-of-date -Wno-profile-instr-unprofiled;
+WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wvla -Wliteral-conversion -Wthread-safety;
HEADER_SEARCH_PATHS = . "${BUILT_PRODUCTS_DIR}/usr/local/include" $(HEADER_SEARCH_PATHS);
Modified: trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig (291558 => 291559)
--- trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig 2022-03-21 15:25:59 UTC (rev 291558)
+++ trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig 2022-03-21 16:29:00 UTC (rev 291559)
@@ -40,15 +40,10 @@
SECTORDER_FLAGS_Production[sdk=iphoneos*] = -Wl,-order_file,$(SDKROOT)/AppleInternal/OrderFiles/_javascript_Core.order;
SECTORDER_FLAGS_Production[sdk=macosx*] = -Wl,-order_file,_javascript_Core.order;
-PROFILE_DATA_FLAGS = $(PROFILE_DATA_FLAGS_$(CONFIGURATION));
-PROFILE_DATA_FLAGS_Production = $(PROFILE_DATA_FLAGS_YES);
-PROFILE_DATA_FLAGS_Release = $(PROFILE_DATA_FLAGS_YES);
-PROFILE_DATA_FLAGS_YES = -fprofile-instr-use=$(SRCROOT)/Profiling/_javascript_Core.profdata;
-
GCC_PREFIX_HEADER = _javascript_CorePrefix.h;
GCC_SYMBOLS_PRIVATE_EXTERN = YES;
OTHER_CFLAGS = $(inherited) -fno-slp-vectorize --system-header-prefix=unicode/ -D__STDC_WANT_LIB_EXT1__=1;
-OTHER_CPLUSPLUSFLAGS = $(inherited) -fno-slp-vectorize --system-header-prefix=unicode/ $(PROFILE_DATA_FLAGS);
+OTHER_CPLUSPLUSFLAGS = $(inherited) -fno-slp-vectorize --system-header-prefix=unicode/;
HEADER_SEARCH_PATHS = "${BUILT_PRODUCTS_DIR}/DerivedSources/_javascript_Core" $(HEADER_SEARCH_PATHS);
INFOPLIST_FILE = Info.plist;
INSTALL_PATH = $(INSTALL_PATH_PREFIX)$(_javascript_CORE_FRAMEWORKS_DIR);
Modified: trunk/Source/WebCore/ChangeLog (291558 => 291559)
--- trunk/Source/WebCore/ChangeLog 2022-03-21 15:25:59 UTC (rev 291558)
+++ trunk/Source/WebCore/ChangeLog 2022-03-21 16:29:00 UTC (rev 291559)
@@ -1,3 +1,15 @@
+2022-03-21 Jonathan Bedard
+
+Unreviewed, reverting r291558.
+
+Exceeded GitHub file size limit
+
+Reverted changeset:
+
+"Enable PGO when building for release and production"
+https://bugs.webkit.org/show_bug.cgi?id=238119
+https://commits.webkit.org/r291558
+
2022-03-21 Wenson Hsieh
Enable PGO when building for release and production
Modified:
[webkit-changes] [291563] trunk/Source/WebKit
Title: [291563] trunk/Source/WebKit Revision 291563 Author commit-qu...@webkit.org Date 2022-03-21 10:37:08 -0700 (Mon, 21 Mar 2022) Log Message Sandbox: Remove telemetry in Network Process sandbox macOS https://bugs.webkit.org/show_bug.cgi?id=238041 Patch by Adam Mazander on 2022-03-21 Reviewed by Brent Fulgham. * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (291562 => 291563) --- trunk/Source/WebKit/ChangeLog 2022-03-21 17:20:35 UTC (rev 291562) +++ trunk/Source/WebKit/ChangeLog 2022-03-21 17:37:08 UTC (rev 291563) @@ -1,3 +1,12 @@ +2022-03-21 Adam Mazander + +Sandbox: Remove telemetry in Network Process sandbox macOS +https://bugs.webkit.org/show_bug.cgi?id=238041 + +Reviewed by Brent Fulgham. + +* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: + 2022-03-21 Alex Christensen Dust off Mac CMake build Modified: trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (291562 => 291563) --- trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2022-03-21 17:20:35 UTC (rev 291562) +++ trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2022-03-21 17:37:08 UTC (rev 291563) @@ -49,7 +49,7 @@ (literal (string-append (param "HOME_DIR") home-relative-literal))) #if PLATFORM(MAC) -(deny mach-register (with telemetry) (local-name-prefix "")) +(deny mach-register (local-name-prefix "")) (allow system-automount (process-attribute is-platform-binary)) @@ -71,7 +71,7 @@ (literal "/var") (literal "/private/etc/localtime")) -(allow file-read-metadata (with telemetry) (path-ancestors "/System/Volumes/Data/private")) +(allow file-read-metadata (path-ancestors "/System/Volumes/Data/private")) (allow file-read* (literal "/")) @@ -130,7 +130,7 @@ (allow file-read* (literal "/Library/Preferences/com.apple.networkd.plist") (literal "/private/var/db/nsurlstoraged/dafsaData.bin")) -(deny mach-lookup (with telemetry) +(deny mach-lookup (global-name "com.apple.SystemConfiguration.PPPController") (global-name "com.apple.SystemConfiguration.SCNetworkReachability") (global-name "com.apple.networkd") @@ -143,7 +143,7 @@ (global-name "com.apple.usymptomsd")) (allow network-outbound (control-name "com.apple.netsrc")) -(deny system-socket (with telemetry) +(deny system-socket (socket-domain AF_ROUTE)) (allow system-socket (require-all (socket-domain AF_SYSTEM) @@ -150,7 +150,7 @@ (socket-protocol 2))) ; SYSPROTO_CONTROL (allow mach-lookup (global-name "com.apple.AppSSO.service-xpc")) -(deny ipc-posix-shm-read-data (with telemetry) +(deny ipc-posix-shm-read-data (ipc-posix-name "/com.apple.AppSSO.version"))) #else (import "system.sb") @@ -162,7 +162,7 @@ (allow process-info-pidinfo) (allow process-info-setcontrol (target self)) -(deny sysctl* (with telemetry)) +(deny sysctl*) (allow sysctl-read (sysctl-name "hw.cputype" @@ -274,7 +274,7 @@ (iokit-user-client-class "RootDomainUserClient") ; Used by PowerObserver ) -(deny mach-lookup (with telemetry) +(deny mach-lookup (global-name "com.apple.PowerManagement.control")) ;; Various services required by CFNetwork and other frameworks @@ -300,19 +300,19 @@ (global-name "com.apple.analyticsd") (global-name "com.apple.diagnosticd"))) -(allow mach-lookup (with telemetry) (global-name "com.apple.webkit.adattributiond.service")) -(allow mach-lookup (with telemetry) (global-name "org.webkit.pcmtestdaemon.service")) +(allow mach-lookup (global-name "com.apple.webkit.adattributiond.service")) +(allow mach-lookup (global-name "org.webkit.pcmtestdaemon.service")) -(allow mach-lookup (with telemetry) (global-name "com.apple.webkit.webpushd.service")) -(allow mach-lookup (with telemetry) (global-name "org.webkit.webpushtestdaemon.service")) +(allow mach-lookup (global-name "com.apple.webkit.webpushd.service")) +(allow mach-lookup (global-name "org.webkit.webpushtestdaemon.service")) (with-filter (uid 0) -(allow mach-lookup (with telemetry) +(allow mach-lookup (global-name "com.apple.DiskArbitration.diskarbitrationd") ) ) -(deny mach-lookup (with telemetry) +(deny mach-lookup (global-name "com.apple.ctkd.token-client") (global-name "com.apple.securityd.xpc") (global-name "com.apple.CoreAuthentication.agent") @@ -335,7 +335,7 @@ (allow file-read* (subpath "/private/var/db/mds/system")) ;; FIXME: This should be removed when is fixed. (with-filter (uid 0) -(allow file-write* (with telemetry) +(allow file-write* (subpath
[webkit-changes] [291560] trunk/Tools
Title: [291560] trunk/Tools
Revision 291560
Author jbed...@apple.com
Date 2022-03-21 09:57:10 -0700 (Mon, 21 Mar 2022)
Log Message
[Merge-Queue] Support multiple reviewers names
https://bugs.webkit.org/show_bug.cgi?id=238095
Reviewed by Aakash Jain.
* Tools/CISupport/ews-build/steps.py:
(ApplyPatch.start): Only apply the first reviewer name.
(ValidateCommiterAndReviewer.start): Support a list of reviewers.
Canonical link: https://commits.webkit.org/248662@main
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (291559 => 291560)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-03-21 16:29:00 UTC (rev 291559)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-03-21 16:57:10 UTC (rev 291560)
@@ -722,9 +722,9 @@
shell.ShellCommand.start(self)
return None
-reviewer_name = self.getProperty('reviewer_full_name', '')
-if reviewer_name:
-self.command.extend(['--reviewer', reviewer_name])
+reviewers_names = self.getProperty('reviewers_full_names', [])
+if reviewers_names:
+self.command.extend(['--reviewer', reviewers_names[0]])
d = self.downloadFileContentToWorker('.buildbot-diff', patch)
d.addCallback(lambda res: shell.ShellCommand.start(self))
@@ -1516,7 +1516,7 @@
self.finished(SUCCESS)
return None
-self.setProperty('reviewer_full_name', self.full_name_from_email(reviewer))
+self.setProperty('reviewers_full_names', [self.full_name_from_email(reviewer)])
if not self.is_reviewer(reviewer):
self.fail_build(reviewer, 'reviewer')
return None
Modified: trunk/Tools/ChangeLog (291559 => 291560)
--- trunk/Tools/ChangeLog 2022-03-21 16:29:00 UTC (rev 291559)
+++ trunk/Tools/ChangeLog 2022-03-21 16:57:10 UTC (rev 291560)
@@ -1,3 +1,15 @@
+2022-03-18 Jonathan Bedard
+
+[Merge-Queue] Support multiple reviewers names
+https://bugs.webkit.org/show_bug.cgi?id=238095
+
+
+Reviewed by Aakash Jain.
+
+* CISupport/ews-build/steps.py:
+(ApplyPatch.start): Only apply the first reviewer name.
+(ValidateCommiterAndReviewer.start): Support a list of reviewers.
+
2022-03-21 Diego Pino Garcia
Unreviewed, fix Debian Stable build after r291543
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291562] trunk/Source
Title: [291562] trunk/Source Revision 291562 Author commit-qu...@webkit.org Date 2022-03-21 10:20:35 -0700 (Mon, 21 Mar 2022) Log Message Dust off Mac CMake build https://bugs.webkit.org/show_bug.cgi?id=238121 Patch by Alex Christensen on 2022-03-21 Reviewed by Yusuke Suzuki. Source/bmalloc: * PlatformMac.cmake: Source/ThirdParty/ANGLE: * GLESv2.cmake: * Metal.cmake: Source/ThirdParty/libwebrtc: * CMakeLists.txt: * Source/third_party/libwebm/common/vp9_level_stats.h: Source/WebCore: * CMakeLists.txt: * PlatformMac.cmake: * SourcesCocoa.txt: Source/WebCore/PAL: * pal/PlatformMac.cmake: Source/WebKit: * PlatformMac.cmake: Source/WebKitLegacy: * PlatformMac.cmake: Modified Paths trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/ThirdParty/ANGLE/GLESv2.cmake trunk/Source/ThirdParty/ANGLE/Metal.cmake trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt trunk/Source/ThirdParty/libwebrtc/ChangeLog trunk/Source/ThirdParty/libwebrtc/Source/third_party/libwebm/common/vp9_level_stats.h trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/PlatformMac.cmake trunk/Source/WebCore/PlatformMac.cmake trunk/Source/WebCore/SourcesCocoa.txt trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/PlatformMac.cmake trunk/Source/WebKitLegacy/ChangeLog trunk/Source/WebKitLegacy/PlatformMac.cmake trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/PlatformMac.cmake Diff Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (291561 => 291562) --- trunk/Source/ThirdParty/ANGLE/ChangeLog 2022-03-21 17:15:30 UTC (rev 291561) +++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2022-03-21 17:20:35 UTC (rev 291562) @@ -1,3 +1,13 @@ +2022-03-21 Alex Christensen + +Dust off Mac CMake build +https://bugs.webkit.org/show_bug.cgi?id=238121 + +Reviewed by Yusuke Suzuki. + +* GLESv2.cmake: +* Metal.cmake: + 2022-03-17 Michael Saboff libANGLE-shared.dylib, libwebrtc.dylib & WebGPU install names are prefixed with the system content path Modified: trunk/Source/ThirdParty/ANGLE/GLESv2.cmake (291561 => 291562) --- trunk/Source/ThirdParty/ANGLE/GLESv2.cmake 2022-03-21 17:15:30 UTC (rev 291561) +++ trunk/Source/ThirdParty/ANGLE/GLESv2.cmake 2022-03-21 17:20:35 UTC (rev 291562) @@ -102,7 +102,7 @@ endif() -if(is_apple) +if (APPLE) list(APPEND libangle_common_sources "src/common/apple/SoftLinking.h" "src/common/apple/apple_platform.h" @@ -449,6 +449,7 @@ "src/libANGLE/renderer/ProgramPipelineImpl.cpp" "src/libANGLE/renderer/QueryImpl.cpp" "src/libANGLE/renderer/ShaderImpl.cpp" +"src/libANGLE/renderer/ShaderInterfaceVariableInfoMap.cpp" "src/libANGLE/renderer/SurfaceImpl.cpp" "src/libANGLE/renderer/TextureImpl.cpp" "src/libANGLE/renderer/driver_utils.cpp" Modified: trunk/Source/ThirdParty/ANGLE/Metal.cmake (291561 => 291562) --- trunk/Source/ThirdParty/ANGLE/Metal.cmake 2022-03-21 17:15:30 UTC (rev 291561) +++ trunk/Source/ThirdParty/ANGLE/Metal.cmake 2022-03-21 17:20:35 UTC (rev 291562) @@ -70,8 +70,6 @@ "src/libANGLE/renderer/metal/mtl_format_utils.mm" "src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.h" "src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm" -"src/libANGLE/renderer/metal/mtl_glslang_utils.h" -"src/libANGLE/renderer/metal/mtl_glslang_utils.mm" "src/libANGLE/renderer/metal/mtl_occlusion_query_pool.h" "src/libANGLE/renderer/metal/mtl_occlusion_query_pool.mm" "src/libANGLE/renderer/metal/mtl_render_utils.h" Modified: trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt (291561 => 291562) --- trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt 2022-03-21 17:15:30 UTC (rev 291561) +++ trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt 2022-03-21 17:20:35 UTC (rev 291562) @@ -26,14 +26,123 @@ endif () set(webrtc_SOURCES -Source/third_party/abseil-cpp/absl/base/internal/raw_logging.cc -Source/third_party/abseil-cpp/absl/base/internal/throw_delegate.cc -Source/third_party/abseil-cpp/absl/strings/ascii.cc +Source/third_party/abseil-cpp/absl/strings/match.cc +Source/third_party/abseil-cpp/absl/strings/internal/charconv_bigint.cc +Source/third_party/abseil-cpp/absl/strings/internal/cordz_info.cc +Source/third_party/abseil-cpp/absl/strings/internal/cord_internal.cc +Source/third_party/abseil-cpp/absl/strings/internal/cordz_sample_token.cc +Source/third_party/abseil-cpp/absl/strings/internal/charconv_parse.cc +Source/third_party/abseil-cpp/absl/strings/internal/str_format/arg.cc +Source/third_party/abseil-cpp/absl/strings/internal/str_format/float_conversion.cc +Source/third_party/abseil-cpp/absl/strings/internal/str_format/output.cc +Source/third_party/abseil-cpp/absl/strings/internal/str_format/bind.cc +Source/third_party/abseil-cpp/absl/strings/internal/str_format/parser.cc +
[webkit-changes] [291561] trunk/Source/WebCore
Title: [291561] trunk/Source/WebCore Revision 291561 Author commit-qu...@webkit.org Date 2022-03-21 10:15:30 -0700 (Mon, 21 Mar 2022) Log Message Null check style in Editor::applyParagraphStyle https://bugs.webkit.org/show_bug.cgi?id=238137 Patch by Rob Buis on 2022-03-21 Reviewed by Wenson Hsieh. Null check style in Editor::applyParagraphStyle. * editing/Editor.cpp: (WebCore::Editor::applyParagraphStyle): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/Editor.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (291560 => 291561) --- trunk/Source/WebCore/ChangeLog 2022-03-21 16:57:10 UTC (rev 291560) +++ trunk/Source/WebCore/ChangeLog 2022-03-21 17:15:30 UTC (rev 291561) @@ -1,3 +1,15 @@ +2022-03-21 Rob Buis + +Null check style in Editor::applyParagraphStyle +https://bugs.webkit.org/show_bug.cgi?id=238137 + +Reviewed by Wenson Hsieh. + +Null check style in Editor::applyParagraphStyle. + +* editing/Editor.cpp: +(WebCore::Editor::applyParagraphStyle): + 2022-03-21 Jonathan Bedard Unreviewed, reverting r291558. Modified: trunk/Source/WebCore/editing/Editor.cpp (291560 => 291561) --- trunk/Source/WebCore/editing/Editor.cpp 2022-03-21 16:57:10 UTC (rev 291560) +++ trunk/Source/WebCore/editing/Editor.cpp 2022-03-21 17:15:30 UTC (rev 291561) @@ -1009,7 +1009,8 @@ ApplyStyleCommand::create(document(), EditingStyle::create(style).ptr(), editingAction, ApplyStyleCommand::ForceBlockProperties)->apply(); -client()->didApplyStyle(); +if (client()) +client()->didApplyStyle(); if (element) dispatchInputEvent(*element, inputTypeName, inputEventData); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291557] releases/WebKitGTK/webkit-2.36.0/
Title: [291557] releases/WebKitGTK/webkit-2.36.0/ Revision 291557 Author carlo...@webkit.org Date 2022-03-21 06:17:11 -0700 (Mon, 21 Mar 2022) Log Message WebKitGTK 2.36.0 Added Paths releases/WebKitGTK/webkit-2.36.0/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291556] releases/WebKitGTK/webkit-2.36
Title: [291556] releases/WebKitGTK/webkit-2.36 Revision 291556 Author carlo...@webkit.org Date 2022-03-21 06:16:46 -0700 (Mon, 21 Mar 2022) Log Message Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.0 release .: * Source/cmake/OptionsGTK.cmake: Bump version numbers. Source/WebKit: * gtk/NEWS: Add release notes for 2.36.0. Modified Paths releases/WebKitGTK/webkit-2.36/ChangeLog releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake Diff Modified: releases/WebKitGTK/webkit-2.36/ChangeLog (291555 => 291556) --- releases/WebKitGTK/webkit-2.36/ChangeLog 2022-03-21 09:27:07 UTC (rev 291555) +++ releases/WebKitGTK/webkit-2.36/ChangeLog 2022-03-21 13:16:46 UTC (rev 291556) @@ -1,3 +1,9 @@ +2022-03-21 Carlos Garcia Campos + +Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.0 release + +* Source/cmake/OptionsGTK.cmake: Bump version numbers. + 2022-02-28 Michael Catanzaro -Wodr warning spam caused by ENABLE(BINDING_INTEGRITY) Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (291555 => 291556) --- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog 2022-03-21 09:27:07 UTC (rev 291555) +++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog 2022-03-21 13:16:46 UTC (rev 291556) @@ -1,3 +1,9 @@ +2022-03-21 Carlos Garcia Campos + +Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.0 release + +* gtk/NEWS: Add release notes for 2.36.0. + 2022-03-18 Carlos Garcia Campos [WPE][GTK] Fix a crash after r290360 Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS (291555 => 291556) --- releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS 2022-03-21 09:27:07 UTC (rev 291555) +++ releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS 2022-03-21 13:16:46 UTC (rev 291556) @@ -1,3 +1,16 @@ + +WebKitGTK 2.36.0 + + +What's new in WebKitGTK 2.36.0? + + - Fix selection foreground color on text with decorations. + - Fix seeking on YouTube videos. + - Fix list item marker not exposed to a11y when not a direct child of a list item. + - Fix a crash while closing a page. + - Fix the build to make it reproducible again. + - Fix several crashes and rendering issues. + = WebKitGTK 2.35.90 = Modified: releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake (291555 => 291556) --- releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake 2022-03-21 09:27:07 UTC (rev 291555) +++ releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake 2022-03-21 13:16:46 UTC (rev 291556) @@ -3,7 +3,7 @@ WEBKIT_OPTION_BEGIN() -SET_PROJECT_VERSION(2 35 90) +SET_PROJECT_VERSION(2 36 0) set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string") @@ -227,11 +227,11 @@ endif () if (WEBKITGTK_API_VERSION VERSION_EQUAL "4.0") -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 3 56) -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 3 20) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 4 56) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 4 20) elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "4.1") -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 3 1) -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 3 1) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 4 1) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 4 1) elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "5.0") CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 0 0) CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 0 0 0) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291555] trunk
Title: [291555] trunk
Revision 291555
Author z...@igalia.com
Date 2022-03-21 02:27:07 -0700 (Mon, 21 Mar 2022)
Log Message
[selection] HTMLTextFormControlElement::subtreeHasChanged() shouldn't be called in setRangeText
https://bugs.webkit.org/show_bug.cgi?id=237720
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Update test expectations as more sub-tests are now passing.
* web-platform-tests/html/semantics/forms/textfieldselection/selection-value-interactions-expected.txt:
* web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setRangeText-expected.txt:
Source/WebCore:
We shouldn't call HTMLTextFormControlElement::subtreeHasChanged() in HTMLTextFormControlElement::setRangeText.
It has been removed in patch for bug 237641. This patch is to further remove unnecessary code.
This change refers and imports some of the changes in chromium CL at
https://codereview.chromium.org/1577243002
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setRangeText):
LayoutTests:
Update test expectation as the test is now passing.
* fast/forms/setrangetext-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/setrangetext-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-value-interactions-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setRangeText-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (291554 => 291555)
--- trunk/LayoutTests/ChangeLog 2022-03-21 08:45:10 UTC (rev 291554)
+++ trunk/LayoutTests/ChangeLog 2022-03-21 09:27:07 UTC (rev 291555)
@@ -1,3 +1,13 @@
+2022-03-21 Ziran Sun
+
+[selection] HTMLTextFormControlElement::subtreeHasChanged() shouldn't be called in setRangeText
+https://bugs.webkit.org/show_bug.cgi?id=237720
+
+Reviewed by Chris Dumez.
+
+Update test expectation as the test is now passing.
+* fast/forms/setrangetext-expected.txt:
+
2022-03-21 Carlos Garcia Campos
REGRESSION(r286955): Rendering Links during search: highlighting fails
Modified: trunk/LayoutTests/fast/forms/setrangetext-expected.txt (291554 => 291555)
--- trunk/LayoutTests/fast/forms/setrangetext-expected.txt 2022-03-21 08:45:10 UTC (rev 291554)
+++ trunk/LayoutTests/fast/forms/setrangetext-expected.txt 2022-03-21 09:27:07 UTC (rev 291555)
@@ -597,7 +597,7 @@
Check that setRangeText() on disconnected elements doesn't crash and has proper values.
element.value = '0123456789'
element.setRangeText('ABC', 0, 0, 'select')
-FAIL element.value should be ABC0123456789. Was 0123456789.
+PASS element.value is "ABC0123456789"
Running tests on input with attributes: {"type":"button"}
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291554 => 291555)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-21 08:45:10 UTC (rev 291554)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-21 09:27:07 UTC (rev 291555)
@@ -1,3 +1,14 @@
+2022-03-21 Ziran Sun
+
+[selection] HTMLTextFormControlElement::subtreeHasChanged() shouldn't be called in setRangeText
+https://bugs.webkit.org/show_bug.cgi?id=237720
+
+Reviewed by Chris Dumez.
+
+Update test expectations as more sub-tests are now passing.
+* web-platform-tests/html/semantics/forms/textfieldselection/selection-value-interactions-expected.txt:
+* web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setRangeText-expected.txt:
+
2022-03-20 Oriol Brufau
Fix CSS cascade regarding logical properties
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-value-interactions-expected.txt (291554 => 291555)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-value-interactions-expected.txt 2022-03-21 08:45:10 UTC (rev 291554)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-value-interactions-expected.txt 2022-03-21 09:27:07 UTC (rev 291555)
@@ -1,6 +1,6 @@
-FAIL value dirty flag behavior after setRangeText on textarea not in body assert_equals: Calling setRangeText should set the value dirty flag expected "somexyzing" but got "set range text"
-FAIL value dirty flag behavior after setRangeText on input not in body assert_equals: Calling setRangeText should set the value dirty flag expected "somexyzing" but got "set range text"
+PASS value dirty flag behavior after setRangeText on textarea not in body
+PASS value dirty flag behavior after setRangeText on input not in body
PASS value dirty flag behavior after setRangeText on textarea in body
PASS value dirty flag behavior after setRangeText on input in body
[webkit-changes] [291554] releases/WebKitGTK/webkit-2.36
Title: [291554] releases/WebKitGTK/webkit-2.36
Revision 291554
Author carlo...@webkit.org
Date 2022-03-21 01:45:10 -0700 (Mon, 21 Mar 2022)
Log Message
Merge r291552 - REGRESSION(r286955): Rendering Links during search: highlighting fails
https://bugs.webkit.org/show_bug.cgi?id=237816
Reviewed by Simon Fraser.
Source/WebCore:
Since r286955 the same coalesced marked text loop is used for painting the foreground text in case of text with
decorations. StyledMarkedText::coalesceAdjacentWithEqualDecorations() doesn't take into account the text style,
so when selected foreground color is different we end up painting the whole decorated text with the same
foreground color for the selected and non-selected parts.
Test: fast/text/selection-with-text-decorations.html
* rendering/StyledMarkedText.cpp:
(WebCore::StyledMarkedText::coalesceAdjacentWithEqualDecorations): Take into account the text styles too.
* rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::paintForegroundAndDecorations): Do not call
StyledMarkedText::coalesceAdjacentWithEqualForeground() in case of text with decorations, since it's unused.
LayoutTests:
* fast/text/selection-with-text-decorations-expected.html: Added.
* fast/text/selection-with-text-decorations.html: Added.
* platform/ios/TestExpectations:
Modified Paths
releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/ios/TestExpectations
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/rendering/StyledMarkedText.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/rendering/TextBoxPainter.cpp
Added Paths
releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations-expected.html
releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations.html
Diff
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (291553 => 291554)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog 2022-03-21 08:45:03 UTC (rev 291553)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog 2022-03-21 08:45:10 UTC (rev 291554)
@@ -1,3 +1,14 @@
+2022-03-21 Carlos Garcia Campos
+
+REGRESSION(r286955): Rendering Links during search: highlighting fails
+https://bugs.webkit.org/show_bug.cgi?id=237816
+
+Reviewed by Simon Fraser.
+
+* fast/text/selection-with-text-decorations-expected.html: Added.
+* fast/text/selection-with-text-decorations.html: Added.
+* platform/ios/TestExpectations:
+
2022-03-01 Cameron McCormack
Make input element UA shadow tree creation lazy
Added: releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations-expected.html (0 => 291554)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations-expected.html (rev 0)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations-expected.html 2022-03-21 08:45:10 UTC (rev 291554)
@@ -0,0 +1,18 @@
+
+
+div {
+display: inline-block;
+clip-path: inset(0px 1px 0px 0px); /* workaround for mac. See webkit.org/b/237816. */
+font-family: monospace;
+font-size: 18px;
+text-decoration: underline;
+text-decoration-color: lightgreen;
+text-decoration-thickness: 1ex;
+text-underline-offset: -1.25ex;
+text-decoration-skip-ink: none;
+text-decoration-skip: none;
+}
+
+
+Hello I have a cool underline
+
Added: releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations.html (0 => 291554)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations.html (rev 0)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations.html 2022-03-21 08:45:10 UTC (rev 291554)
@@ -0,0 +1,25 @@
+
+
+div {
+display: inline-block;
+clip-path: inset(0px 1px 0px 0px); /* workaround for mac. See webkit.org/b/237816. */
+font-family: monospace;
+font-size: 18px;
+text-decoration: underline;
+text-decoration-color: lightgreen;
+text-decoration-thickness: 1ex;
+text-underline-offset: -1.25ex;
+text-decoration-skip-ink: none;
+text-decoration-skip: none;
+}
+div::selection {
+color: red;
+background: transparent;
+}
+
+
+Hello I have a cool underline
+
+var target = document.getElementById("target").firstChild;
+getSelection().setBaseAndExtent(target, 0, target, 5);
+
Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/platform/ios/TestExpectations (291553 => 291554)
--- releases/WebKitGTK/webkit-2.36/LayoutTests/platform/ios/TestExpectations 2022-03-21 08:45:03 UTC (rev 291553)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/platform/ios/TestExpectations 2022-03-21 08:45:10 UTC (rev 291554)
@@ -134,6 +134,7 @@
fast/selectors/text-field-selection-text-shadow.html [ WontFix ]
[webkit-changes] [291553] releases/WebKitGTK/webkit-2.36/Source/WebCore
Title: [291553] releases/WebKitGTK/webkit-2.36/Source/WebCore
Revision 291553
Author carlo...@webkit.org
Date 2022-03-21 01:45:03 -0700 (Mon, 21 Mar 2022)
Log Message
Merge r291544 - REGRESSION(r289154) [GSTREAMER] webrtc/vp8-then-h264.html is crashing after SDK update to fdo 21.08 and Gstreamer 1.20
https://bugs.webkit.org/show_bug.cgi?id=237872
Patch by Philippe Normand on 2022-03-20
Reviewed by Adrian Perez de Castro.
* platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp:
(WebCore::VP8Decoder::Create): Fix typo in decoder factory test.
Modified Paths
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (291552 => 291553)
--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog 2022-03-21 08:35:28 UTC (rev 291552)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog 2022-03-21 08:45:03 UTC (rev 291553)
@@ -1,3 +1,13 @@
+2022-03-20 Philippe Normand
+
+REGRESSION(r289154) [GSTREAMER] webrtc/vp8-then-h264.html is crashing after SDK update to fdo 21.08 and Gstreamer 1.20
+https://bugs.webkit.org/show_bug.cgi?id=237872
+
+Reviewed by Adrian Perez de Castro.
+
+* platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp:
+(WebCore::VP8Decoder::Create): Fix typo in decoder factory test.
+
2022-03-01 Cameron McCormack
Make input element UA shadow tree creation lazy
Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp (291552 => 291553)
--- releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp 2022-03-21 08:35:28 UTC (rev 291552)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp 2022-03-21 08:45:03 UTC (rev 291553)
@@ -367,7 +367,7 @@
static std::unique_ptr Create()
{
auto factory = GstDecoderFactory("video/x-vp8");
-if (!factory) {
+if (factory) {
const auto* factoryName = GST_OBJECT_NAME(GST_OBJECT(factory.get()));
if (!g_strcmp0(factoryName, "vp8dec") || !g_strcmp0(factoryName, "vp8alphadecodebin")) {
GST_INFO("Our best GStreamer VP8 decoder is vp8dec, better use the one from LibWebRTC");
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291552] trunk
Title: [291552] trunk
Revision 291552
Author carlo...@webkit.org
Date 2022-03-21 01:35:28 -0700 (Mon, 21 Mar 2022)
Log Message
REGRESSION(r286955): Rendering Links during search: highlighting fails
https://bugs.webkit.org/show_bug.cgi?id=237816
Reviewed by Simon Fraser.
Source/WebCore:
Since r286955 the same coalesced marked text loop is used for painting the foreground text in case of text with
decorations. StyledMarkedText::coalesceAdjacentWithEqualDecorations() doesn't take into account the text style,
so when selected foreground color is different we end up painting the whole decorated text with the same
foreground color for the selected and non-selected parts.
Test: fast/text/selection-with-text-decorations.html
* rendering/StyledMarkedText.cpp:
(WebCore::StyledMarkedText::coalesceAdjacentWithEqualDecorations): Take into account the text styles too.
* rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::paintForegroundAndDecorations): Do not call
StyledMarkedText::coalesceAdjacentWithEqualForeground() in case of text with decorations, since it's unused.
LayoutTests:
* fast/text/selection-with-text-decorations-expected.html: Added.
* fast/text/selection-with-text-decorations.html: Added.
* platform/ios/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/StyledMarkedText.cpp
trunk/Source/WebCore/rendering/TextBoxPainter.cpp
Added Paths
trunk/LayoutTests/fast/text/selection-with-text-decorations-expected.html
trunk/LayoutTests/fast/text/selection-with-text-decorations.html
Diff
Modified: trunk/LayoutTests/ChangeLog (291551 => 291552)
--- trunk/LayoutTests/ChangeLog 2022-03-21 07:41:52 UTC (rev 291551)
+++ trunk/LayoutTests/ChangeLog 2022-03-21 08:35:28 UTC (rev 291552)
@@ -1,3 +1,14 @@
+2022-03-21 Carlos Garcia Campos
+
+REGRESSION(r286955): Rendering Links during search: highlighting fails
+https://bugs.webkit.org/show_bug.cgi?id=237816
+
+Reviewed by Simon Fraser.
+
+* fast/text/selection-with-text-decorations-expected.html: Added.
+* fast/text/selection-with-text-decorations.html: Added.
+* platform/ios/TestExpectations:
+
2022-03-19 Tyler Wilcock
Rebaseline accessibility/roles-exposed.html for Mac WK1 after https://commits.webkit.org/r291401
Added: trunk/LayoutTests/fast/text/selection-with-text-decorations-expected.html (0 => 291552)
--- trunk/LayoutTests/fast/text/selection-with-text-decorations-expected.html (rev 0)
+++ trunk/LayoutTests/fast/text/selection-with-text-decorations-expected.html 2022-03-21 08:35:28 UTC (rev 291552)
@@ -0,0 +1,18 @@
+
+
+div {
+display: inline-block;
+clip-path: inset(0px 1px 0px 0px); /* workaround for mac. See webkit.org/b/237816. */
+font-family: monospace;
+font-size: 18px;
+text-decoration: underline;
+text-decoration-color: lightgreen;
+text-decoration-thickness: 1ex;
+text-underline-offset: -1.25ex;
+text-decoration-skip-ink: none;
+text-decoration-skip: none;
+}
+
+
+Hello I have a cool underline
+
Added: trunk/LayoutTests/fast/text/selection-with-text-decorations.html (0 => 291552)
--- trunk/LayoutTests/fast/text/selection-with-text-decorations.html (rev 0)
+++ trunk/LayoutTests/fast/text/selection-with-text-decorations.html 2022-03-21 08:35:28 UTC (rev 291552)
@@ -0,0 +1,25 @@
+
+
+div {
+display: inline-block;
+clip-path: inset(0px 1px 0px 0px); /* workaround for mac. See webkit.org/b/237816. */
+font-family: monospace;
+font-size: 18px;
+text-decoration: underline;
+text-decoration-color: lightgreen;
+text-decoration-thickness: 1ex;
+text-underline-offset: -1.25ex;
+text-decoration-skip-ink: none;
+text-decoration-skip: none;
+}
+div::selection {
+color: red;
+background: transparent;
+}
+
+
+Hello I have a cool underline
+
+var target = document.getElementById("target").firstChild;
+getSelection().setBaseAndExtent(target, 0, target, 5);
+
Modified: trunk/LayoutTests/platform/ios/TestExpectations (291551 => 291552)
--- trunk/LayoutTests/platform/ios/TestExpectations 2022-03-21 07:41:52 UTC (rev 291551)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2022-03-21 08:35:28 UTC (rev 291552)
@@ -136,6 +136,7 @@
fast/selectors/text-field-selection-text-shadow.html [ WontFix ]
fast/selectors/text-field-selection-window-inactive-stroke-color.html [ WontFix ]
fast/selectors/text-field-selection-window-inactive-text-shadow.html [ WontFix ]
+fast/text/selection-with-text-decorations.html [ WontFix ]
# Plugins are not supported on iOS
plugins
Modified: trunk/Source/WebCore/ChangeLog (291551 => 291552)
--- trunk/Source/WebCore/ChangeLog 2022-03-21 07:41:52 UTC (rev 291551)
+++ trunk/Source/WebCore/ChangeLog 2022-03-21 08:35:28 UTC (rev 291552)
@@ -1,3 +1,23 @@
+2022-03-21 Carlos Garcia Campos
+
[webkit-changes] [291551] trunk/Tools
Title: [291551] trunk/Tools Revision 291551 Author dp...@igalia.com Date 2022-03-21 00:41:52 -0700 (Mon, 21 Mar 2022) Log Message Unreviewed, fix Debian Stable build after r291543 * TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp: (elementSize): Replace RELEASE_ASSERT_NOT_REACHED() for RELEASE_ASSERT_NOT_REACHED_UNDER_CONSTEXPR_CONTEXT(). Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp Diff Modified: trunk/Tools/ChangeLog (291550 => 291551) --- trunk/Tools/ChangeLog 2022-03-21 07:14:14 UTC (rev 291550) +++ trunk/Tools/ChangeLog 2022-03-21 07:41:52 UTC (rev 291551) @@ -1,3 +1,10 @@ +2022-03-21 Diego Pino Garcia + +Unreviewed, fix Debian Stable build after r291543 + +* TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp: +(elementSize): Replace RELEASE_ASSERT_NOT_REACHED() for RELEASE_ASSERT_NOT_REACHED_UNDER_CONSTEXPR_CONTEXT(). + 2022-03-20 Adrian Perez de Castro Fix clang warning after r291229 Modified: trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp (291550 => 291551) --- trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp 2022-03-21 07:14:14 UTC (rev 291550) +++ trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp 2022-03-21 07:41:52 UTC (rev 291551) @@ -2987,7 +2987,7 @@ case JSC_TYPED_ARRAY_FLOAT64: return sizeof(double); case JSC_TYPED_ARRAY_NONE: break; } -RELEASE_ASSERT_NOT_REACHED(); +RELEASE_ASSERT_NOT_REACHED_UNDER_CONSTEXPR_CONTEXT(); } void testJSCTypedArray() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [291550] trunk/Source
Title: [291550] trunk/Source
Revision 291550
Author you...@apple.com
Date 2022-03-21 00:14:14 -0700 (Mon, 21 Mar 2022)
Log Message
Remove use of MediaSampleAVFObjC from WebRTC pipelines
https://bugs.webkit.org/show_bug.cgi?id=237706
Reviewed by Eric Carlson.
Source/WebCore:
Replace MediaSampleAVFObjC by VideoFrameCV when handling CVPixelBuffers.
Covered by existing tests.
* platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
* platform/graphics/cv/ImageRotationSessionVT.mm:
* platform/graphics/cv/ImageTransferSessionVT.h:
* platform/graphics/cv/ImageTransferSessionVT.mm:
* platform/graphics/cv/VideoFrameCV.h:
* platform/graphics/cv/VideoFrameCV.mm:
* platform/mediastream/RealtimeVideoSource.cpp:
* platform/mediastream/RealtimeVideoSource.h:
* platform/mediastream/mac/AVVideoCaptureSource.mm:
* platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:
* platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.h:
* platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
Source/WebKit:
* GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
* GPUProcess/webrtc/RemoteMediaRecorder.cpp:
* GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
* UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm
trunk/Source/WebCore/platform/graphics/cv/ImageRotationSessionVT.mm
trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.h
trunk/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm
trunk/Source/WebCore/platform/graphics/cv/VideoFrameCV.h
trunk/Source/WebCore/platform/graphics/cv/VideoFrameCV.mm
trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp
trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.h
trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
trunk/Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm
trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.h
trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm
trunk/Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp
trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp
trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (291549 => 291550)
--- trunk/Source/WebCore/ChangeLog 2022-03-21 02:11:50 UTC (rev 291549)
+++ trunk/Source/WebCore/ChangeLog 2022-03-21 07:14:14 UTC (rev 291550)
@@ -1,3 +1,29 @@
+2022-03-21 Youenn Fablet
+
+Remove use of MediaSampleAVFObjC from WebRTC pipelines
+https://bugs.webkit.org/show_bug.cgi?id=237706
+
+
+Reviewed by Eric Carlson.
+
+Replace MediaSampleAVFObjC by VideoFrameCV when handling CVPixelBuffers.
+
+Covered by existing tests.
+
+* platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:
+* platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
+* platform/graphics/cv/ImageRotationSessionVT.mm:
+* platform/graphics/cv/ImageTransferSessionVT.h:
+* platform/graphics/cv/ImageTransferSessionVT.mm:
+* platform/graphics/cv/VideoFrameCV.h:
+* platform/graphics/cv/VideoFrameCV.mm:
+* platform/mediastream/RealtimeVideoSource.cpp:
+* platform/mediastream/RealtimeVideoSource.h:
+* platform/mediastream/mac/AVVideoCaptureSource.mm:
+* platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:
+* platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.h:
+* platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
+
2022-03-20 Diego Pino Garcia
[WPE] Unreviewed, fix non-unified build after r291474 and r291508
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h (291549 => 291550)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h 2022-03-21 02:11:50 UTC (rev 291549)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h 2022-03-21 07:14:14 UTC (rev 291550)
@@ -44,12 +44,7 @@
static Ref create(CMSampleBufferRef sample, uint64_t trackID) { return adoptRef(*new MediaSampleAVFObjC(sample, trackID)); }
static Ref create(CMSampleBufferRef sample, AtomString trackID) { return adoptRef(*new MediaSampleAVFObjC(sample, trackID)); }
static Ref create(CMSampleBufferRef sample, VideoRotation rotation = VideoRotation::None, bool mirrored = false) { return adoptRef(*new MediaSampleAVFObjC(sample, rotation, mirrored)); }
-static RefPtr createFromPixelBuffer(PixelBuffer&&);
-WEBCORE_EXPORT static RefPtr createFromPixelBuffer(RetainPtr&&, VideoRotation, bool mirrored, MediaTime
