[webkit-changes] [295259] trunk/Source/WebKit/Configurations/BaseTarget.xcconfig
Title: [295259] trunk/Source/WebKit/Configurations/BaseTarget.xcconfig Revision 295259 Author e...@apple.com Date 2022-06-03 19:17:32 -0700 (Fri, 03 Jun 2022) Log Message Fix WebKit's PROFILE_DATA_PATH in internal release builds https://bugs.webkit.org/show_bug.cgi?id=241297 Reviewed by Wenson Hsieh. WebKit's PROFILE_DATA_PATH_INTERNAL_YES was missing `WebKitAdditions/` in its path name. Just a typo here, WebCore and _javascript_Core have correct paths. * Source/WebKit/Configurations/BaseTarget.xcconfig: Canonical link: https://commits.webkit.org/251305@main Modified Paths trunk/Source/WebKit/Configurations/BaseTarget.xcconfig Diff Modified: trunk/Source/WebKit/Configurations/BaseTarget.xcconfig (295258 => 295259) --- trunk/Source/WebKit/Configurations/BaseTarget.xcconfig 2022-06-04 02:09:18 UTC (rev 295258) +++ trunk/Source/WebKit/Configurations/BaseTarget.xcconfig 2022-06-04 02:17:32 UTC (rev 295259) @@ -53,7 +53,7 @@ PROFILE_DATA_PATH = $(PROFILE_DATA_PATH_INTERNAL_$(USE_INTERNAL_SDK)); PROFILE_DATA_PATH_INTERNAL_ = $(SRCROOT)/../../Tools/Profiling/Empty.profdata; -PROFILE_DATA_PATH_INTERNAL_YES = $(BUILT_PRODUCTS_DIR)$(WK_LIBRARY_HEADERS_FOLDER_PATH)/Profiling/WebKit.profdata.compressed; +PROFILE_DATA_PATH_INTERNAL_YES = $(BUILT_PRODUCTS_DIR)$(WK_LIBRARY_HEADERS_FOLDER_PATH)/WebKitAdditions/Profiling/WebKit.profdata.compressed; PROFILE_DATA_PATH_INTERNAL_YES[config=Production] = $(SDK_DIR)$(WK_ALTERNATE_WEBKIT_SDK_PATH)$(WK_LIBRARY_HEADERS_FOLDER_PATH)/WebKitAdditions/Profiling/WebKit.profdata.compressed; PROFILE_DATA_FLAGS_ENABLED = -fprofile-instr-use=$(BUILT_PRODUCTS_DIR)/DerivedSources/WebKit/WebKit.profdata; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295258] trunk
Title: [295258] trunk
Revision 295258
Author ysuz...@apple.com
Date 2022-06-03 19:09:18 -0700 (Fri, 03 Jun 2022)
Log Message
[WTF] Handle "at" in Date parse heuristics to make Date picker work in CNBC.com
https://bugs.webkit.org/show_bug.cgi?id=241258
rdar://93920424
Reviewed by Darin Adler.
AppleICU changes Intl.DateTimeFormat's formatting result to align it to Apple HI. But we
observed regression in CNBC.com since it reparses Intl.DateTimeFormat's string with Date
constructor.
Strictly speaking, there is no guarantee that code works. Date constructor's parsing
is implementation-dependent, and the spec does not require that Intl.DateTimeFormat's output
should be accepted by Date constructor. And this works only for English case anyway even before
this AppleICU change: if date is formatted via `ja-JP`, then Date constructor does not accept it.
But previously, this English case was working by chance, but now, new ICU format inserts "at"
in the string, and it makes that string unaccepted in Date constructor.
To workaround this web-compatibility issue, we extend our Date parsing heuristics to
accept "at". This is OK since the goal of this heuristics is accepting wider range of date
strings. Also it is OK that accepting English word "at" since this heuristics already handle
weekday and month names in English.
* JSTests/complex.yaml:
* JSTests/complex/intl-date-time-format-date-parse.js: Added.
(shouldBe):
* Source/WTF/wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
Canonical link: https://commits.webkit.org/251304@main
Modified Paths
trunk/JSTests/complex.yaml
trunk/Source/WTF/wtf/DateMath.cpp
Added Paths
trunk/JSTests/complex/intl-date-time-format-date-parse.js
Diff
Added: trunk/JSTests/complex/intl-date-time-format-date-parse.js (0 => 295258)
--- trunk/JSTests/complex/intl-date-time-format-date-parse.js (rev 0)
+++ trunk/JSTests/complex/intl-date-time-format-date-parse.js 2022-06-04 02:09:18 UTC (rev 295258)
@@ -0,0 +1,21 @@
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error(`bad value: ${actual}, expected ${expected}`);
+}
+
+let date = new Date(165419124);
+let t = Intl.DateTimeFormat("en-US", {
+timeZone: "America/New_York",
+weekday: "short",
+year: "numeric",
+month: "short",
+day: "numeric",
+hour: "numeric",
+minute: "numeric"
+}).format(date);
+let reparsed = new Date(t)
+shouldBe(reparsed.getTime(), date.getTime());
+
+// "at" case
+shouldBe(new Date(`Thu, May 26, 2022, 6:27 PM`).getTime(), 165360402);
+shouldBe(new Date(`Thu, May 26, 2022 at 6:27 PM`).getTime(), 165360402);
Modified: trunk/JSTests/complex.yaml (295257 => 295258)
--- trunk/JSTests/complex.yaml 2022-06-04 01:10:29 UTC (rev 295257)
+++ trunk/JSTests/complex.yaml 2022-06-04 02:09:18 UTC (rev 295258)
@@ -61,3 +61,6 @@
- path: complex/for-in-clobberize.js
cmd: runComplexTest [], [], "", "--destroy-vm"
+
+- path: complex/intl-date-time-format-date-parse.js
+ cmd: runComplexTest [], [], "TZ=America/New_York"
Modified: trunk/Source/WTF/wtf/DateMath.cpp (295257 => 295258)
--- trunk/Source/WTF/wtf/DateMath.cpp 2022-06-04 01:10:29 UTC (rev 295257)
+++ trunk/Source/WTF/wtf/DateMath.cpp 2022-06-04 02:09:18 UTC (rev 295258)
@@ -836,7 +836,12 @@
year = std::nullopt;
} else {
// in the normal case (we parsed the year), advance to the next number
-dateString = ++newPosStr;
+// ' at 23:12:40 GMT'
+if (isASCIISpace(newPosStr[0]) && isASCIIAlphaCaselessEqual(newPosStr[1], 'a') && isASCIIAlphaCaselessEqual(newPosStr[2], 't'))
+newPosStr += 3;
+else
+++newPosStr; // space or comma
+dateString = newPosStr;
skipSpacesAndComments(dateString);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295257] tags/WebKit-7614.1.14.10.11/
Title: [295257] tags/WebKit-7614.1.14.10.11/ Revision 295257 Author alanc...@apple.com Date 2022-06-03 18:10:29 -0700 (Fri, 03 Jun 2022) Log Message Tag WebKit-7614.1.14.10.11. Added Paths tags/WebKit-7614.1.14.10.11/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295256] branches/safari-7614.1.14.10-branch/Source
Title: [295256] branches/safari-7614.1.14.10-branch/Source Revision 295256 Author alanc...@apple.com Date 2022-06-03 18:06:30 -0700 (Fri, 03 Jun 2022) Log Message Versioning. WebKit-7614.1.14.10.11 Modified Paths branches/safari-7614.1.14.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7614.1.14.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig (295255 => 295256) --- branches/safari-7614.1.14.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-06-04 00:30:28 UTC (rev 295255) +++ branches/safari-7614.1.14.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-06-04 01:06:30 UTC (rev 295256) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 10; -NANO_VERSION = 10; +NANO_VERSION = 11; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (295255 => 295256) --- branches/safari-7614.1.14.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-06-04 00:30:28 UTC (rev 295255) +++ branches/safari-7614.1.14.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-06-04 01:06:30 UTC (rev 295256) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 10; -NANO_VERSION = 10; +NANO_VERSION = 11; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (295255 => 295256) --- branches/safari-7614.1.14.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-06-04 00:30:28 UTC (rev 295255) +++ branches/safari-7614.1.14.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-06-04 01:06:30 UTC (rev 295256) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 10; -NANO_VERSION = 10; +NANO_VERSION = 11; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.10-branch/Source/WebCore/Configurations/Version.xcconfig (295255 => 295256) --- branches/safari-7614.1.14.10-branch/Source/WebCore/Configurations/Version.xcconfig 2022-06-04 00:30:28 UTC (rev 295255) +++ branches/safari-7614.1.14.10-branch/Source/WebCore/Configurations/Version.xcconfig 2022-06-04 01:06:30 UTC (rev 295256) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 10; -NANO_VERSION = 10; +NANO_VERSION = 11; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (295255 => 295256) --- branches/safari-7614.1.14.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-06-04 00:30:28 UTC (rev 295255) +++ branches/safari-7614.1.14.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-06-04 01:06:30 UTC (rev 295256) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 10; -NANO_VERSION = 10; +NANO_VERSION = 11; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.10-branch/Source/WebGPU/Configurations/Version.xcconfig (295255 => 295256) --- branches/safari-7614.1.14.10-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-06-04 00:30:28 UTC (rev 295255) +++ branches/safari-7614.1.14.10-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-06-04 01:06:30 UTC (rev 295256) @@ -25,7 +25,7 @@ MINOR_VERSION = 1;
[webkit-changes] [295255] trunk/Source
Title: [295255] trunk/Source Revision 295255 Author drou...@apple.com Date 2022-06-03 17:30:28 -0700 (Fri, 03 Jun 2022) Log Message Web Inspector: remove unused `InspectorFrontendHost` attributes and methods https://bugs.webkit.org/show_bug.cgi?id=241291 Reviewed by Patrick Angle. * Source/WebCore/inspector/InspectorFrontendHost.idl: * Source/WebCore/inspector/InspectorFrontendHost.h: * Source/WebCore/inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::port const): Deleted. (WebCore::InspectorFrontendHost::append): Deleted. (WebCore::InspectorFrontendHost::close): Deleted. * Source/WebCore/inspector/InspectorFrontendClient.h: * Source/WebCore/inspector/InspectorFrontendClientLocal.h: (WebCore::InspectorFrontendClientLocal::append): Deleted. * Source/WebKit/WebProcess/Inspector/WebInspectorUI.messages.in: * Source/WebKit/WebProcess/Inspector/WebInspectorUI.h: * Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp: (WebKit::WebInspectorUI::didSave): Deleted. (WebKit::WebInspectorUI::append): Deleted. (WebKit::WebInspectorUI::didAppend): Deleted. * Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.messages.in: * Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h: * Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp: (WebKit::WebInspectorUIProxy::append): Deleted. (WebKit::WebInspectorUIProxy::platformAppend): Deleted. * Source/WebKit/UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp: (WebKit::fileReplaceContentsCallback): (WebKit::WebInspectorUIProxy::platformAppend): Deleted. * Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm: (WebKit::WebInspectorUIProxy::platformSave): (WebKit::WebInspectorUIProxy::platformAppend): Deleted. * Source/WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp: (WebKit::WebInspectorUIProxy::platformAppend): Deleted. * Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.messages.in: * Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h: * Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp: (WebKit::RemoteWebInspectorUI::didSave): Deleted. (WebKit::RemoteWebInspectorUI::didAppend): Deleted. (WebKit::RemoteWebInspectorUI::append): Deleted. * Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.messages.in: * Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.h: * Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.cpp: (WebKit::RemoteWebInspectorUIProxy::append): Deleted. (WebKit::RemoteWebInspectorUIProxy::platformAppend): Deleted. * Source/WebKit/UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp: (WebKit::remoteFileReplaceContentsCallback): (WebKit::RemoteWebInspectorUIProxy::platformAppend): Deleted. * Source/WebKit/UIProcess/Inspector/mac/RemoteWebInspectorUIProxyMac.mm: (WebKit::RemoteWebInspectorUIProxy::platformSave): (WebKit::RemoteWebInspectorUIProxy::platformAppend): Deleted. * Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp: (WebKit::RemoteWebInspectorUIProxy::platformAppend): Deleted. * Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h: * Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::save): (WebInspectorFrontendClient::append): Deleted. * Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm: (WebInspectorFrontendClient::append): Deleted. * Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js: (InspectorFrontendAPI.savedURL): Deleted. (InspectorFrontendAPI.appendedToURL): Deleted. Canonical link: https://commits.webkit.org/251303@main Modified Paths trunk/Source/WebCore/inspector/InspectorFrontendClient.h trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp trunk/Source/WebCore/inspector/InspectorFrontendHost.h trunk/Source/WebCore/inspector/InspectorFrontendHost.idl trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js trunk/Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.cpp trunk/Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.h trunk/Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.messages.in trunk/Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp trunk/Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h trunk/Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.messages.in trunk/Source/WebKit/UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp trunk/Source/WebKit/UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp trunk/Source/WebKit/UIProcess/Inspector/mac/RemoteWebInspectorUIProxyMac.mm trunk/Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm trunk/Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp trunk/Source/WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp trunk/Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp trunk/Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h trunk/Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.messages.in
[webkit-changes] [295254] trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm
Title: [295254] trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm
Revision 295254
Author sihui_...@apple.com
Date 2022-06-03 16:59:06 -0700 (Fri, 03 Jun 2022)
Log Message
Regression (r294405): missing tiles during scrolling after foregrounding app
https://bugs.webkit.org/show_bug.cgi?id=241280
Reviewed by Chris Dumez.
Partially revert r294405 to disable ProcessStateMonitor that can make UI process fail to take foreground assertion after
app is foregrounded.
* Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:
(-[WKProcessAssertionBackgroundTaskManager init]):
(-[WKProcessAssertionBackgroundTaskManager _releaseBackgroundTask]):
Canonical link: https://commits.webkit.org/251302@main
Modified Paths
trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm
Diff
Modified: trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm (295253 => 295254)
--- trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm 2022-06-03 23:55:02 UTC (rev 295253)
+++ trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm 2022-06-03 23:59:06 UTC (rev 295254)
@@ -29,7 +29,6 @@
#if PLATFORM(IOS_FAMILY)
#import "Logging.h"
-#import "ProcessStateMonitor.h"
#import "RunningBoardServicesSPI.h"
#import "WebProcessPool.h"
#import
@@ -74,7 +73,6 @@
std::atomic _backgroundTaskWasInvalidated;
WeakHashSet _assertionsNeedingBackgroundTask;
dispatch_block_t _pendingTaskReleaseTask;
-std::unique_ptr m_processStateMonitor;
}
+ (WKProcessAssertionBackgroundTaskManager *)shared
@@ -94,20 +92,11 @@
[[NSNotificationCenter defaultCenter] addObserverForName:UIApplicationWillEnterForegroundNotification object:[UIApplication sharedApplication] queue:nil usingBlock:^(NSNotification *) {
[self _cancelPendingReleaseTask];
[self _updateBackgroundTask];
-
-m_processStateMonitor = nullptr;
}];
[[NSNotificationCenter defaultCenter] addObserverForName:UIApplicationDidEnterBackgroundNotification object:[UIApplication sharedApplication] queue:nil usingBlock:^(NSNotification *) {
if (![self _hasBackgroundTask])
WebKit::WebProcessPool::notifyProcessPoolsApplicationIsAboutToSuspend();
-
-if (!m_processStateMonitor) {
-m_processStateMonitor = makeUnique([](bool suspended) {
-for (auto& processPool : WebKit::WebProcessPool::allProcessPools())
-processPool->setProcessesShouldSuspend(suspended);
-});
-}
}];
return self;
@@ -253,11 +242,8 @@
return;
RELEASE_LOG(ProcessSuspension, "%p - WKProcessAssertionBackgroundTaskManager: endBackgroundTask", self);
-if (processHasActiveRunTimeLimitation()) {
+if (processHasActiveRunTimeLimitation())
WebKit::WebProcessPool::notifyProcessPoolsApplicationIsAboutToSuspend();
-if (m_processStateMonitor)
-m_processStateMonitor->processWillBeSuspendedImmediately();
-}
[_backgroundTask removeObserver:self];
[_backgroundTask invalidate];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295252] trunk/LayoutTests/platform/mac-wk2/TestExpectations
Title: [295252] trunk/LayoutTests/platform/mac-wk2/TestExpectations Revision 295252 Author rack...@apple.com Date 2022-06-03 16:54:30 -0700 (Fri, 03 Jun 2022) Log Message [Gardening]: [ Monterey wk2 release ] imported/w3c/web-platform-tests/content-security-policy/inheritance/blob-url-inherits-from-initiator.sub.html is a flaky crash https://bugs.webkit.org/show_bug.cgi?id=239307 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/251300@main Modified Paths trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (295251 => 295252) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-06-03 23:49:42 UTC (rev 295251) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-06-03 23:54:30 UTC (rev 295252) @@ -1634,8 +1634,6 @@ webkit.org/b/239304 http/tests/cache-storage/cache-origins.https.html [ Pass Failure ] -webkit.org/b/239307 [ Monterey+ Release ] imported/w3c/web-platform-tests/content-security-policy/inheritance/blob-url-inherits-from-initiator.sub.html [ Pass Crash ] - # [ Monterey wk2 debug ] WebGL conformance tests are a flaky time out webkit.org/b/239386 [ Debug ] webgl/1.0.3/conformance/context/context-eviction-with-garbage-collection.html [ Pass Timeout ] webkit.org/b/239386 [ Debug ] webgl/1.0.3/conformance/context/context-release-with-workers.html [ Pass Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295251] trunk/LayoutTests/http/tests/media/modern-media-controls/ macos-fullscreen-media-controls/ macos-fullscreen-media-controls-live-broadcast.html
Title: [295251] trunk/LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html
Revision 295251
Author drou...@apple.com
Date 2022-06-03 16:49:42 -0700 (Fri, 03 Jun 2022)
Log Message
[ Mac ] http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html is a flaky text failure
https://bugs.webkit.org/show_bug.cgi?id=239091
Unreviewed test fix.
* LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html:
Only listen for `"webkitfullscreenchange"` once in case the `` exiting fullscreen somehow
happens before the test fully finishes.
Canonical link: https://commits.webkit.org/251299@main
Modified Paths
trunk/LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html
Diff
Modified: trunk/LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html (295250 => 295251)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html 2022-06-03 23:45:34 UTC (rev 295250)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html 2022-06-03 23:49:42 UTC (rev 295251)
@@ -27,7 +27,7 @@
shadowRoot.host.remove();
finishJSTest();
});
-});
+}, { once: true });
media.addEventListener("play", () => {
media.pause();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295250] trunk
Title: [295250] trunk
Revision 295250
Author mmaxfi...@apple.com
Date 2022-06-03 16:45:34 -0700 (Fri, 03 Jun 2022)
Log Message
[Cocoa] Mail compose doesn't use Bulgarian letter forms when the system language is set to Bulgarian
https://bugs.webkit.org/show_bug.cgi?id=241253
Reviewed by Cameron McCormack.
Mail compose doesn't set `lang`, which causes us to have a null locale string.
String::createCFString() transforms a null string to CFSTR(""), which indicates to Core Text
that it shouldn't use the shaping from the system language. Instead, if the locale string
is null, we should give Core Text a null locale string, so they use the correct shaping.
* LayoutTests/TestExpectations:
* LayoutTests/fast/text/bulgarian-system-language-shaping-expected-mismatch.html: Added.
* LayoutTests/fast/text/bulgarian-system-language-shaping.html: Added.
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/platform/graphics/coretext/FontCoreText.cpp:
(WebCore::Font::applyTransforms const):
Canonical link: https://commits.webkit.org/251298@main
Modified Paths
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/platform/graphics/coretext/FontCoreText.cpp
Added Paths
trunk/LayoutTests/fast/text/bulgarian-system-language-shaping-expected-mismatch.html
trunk/LayoutTests/fast/text/bulgarian-system-language-shaping.html
Diff
Modified: trunk/LayoutTests/TestExpectations (295249 => 295250)
--- trunk/LayoutTests/TestExpectations 2022-06-03 23:39:34 UTC (rev 295249)
+++ trunk/LayoutTests/TestExpectations 2022-06-03 23:45:34 UTC (rev 295250)
@@ -5291,3 +5291,6 @@
# Image controls menu is mac only.
fast/attachment/attachment-image-controls-basic.html [ Skip ]
+
+# This test requires a system font that has Bulgarian-specific shaping.
+fast/text/bulgarian-system-language-shaping.html [ ImageOnlyFailure ]
Added: trunk/LayoutTests/fast/text/bulgarian-system-language-shaping-expected-mismatch.html (0 => 295250)
--- trunk/LayoutTests/fast/text/bulgarian-system-language-shaping-expected-mismatch.html (rev 0)
+++ trunk/LayoutTests/fast/text/bulgarian-system-language-shaping-expected-mismatch.html 2022-06-03 23:45:34 UTC (rev 295250)
@@ -0,0 +1,8 @@
+
+
+
+
+
+
+
+
Added: trunk/LayoutTests/fast/text/bulgarian-system-language-shaping.html (0 => 295250)
--- trunk/LayoutTests/fast/text/bulgarian-system-language-shaping.html (rev 0)
+++ trunk/LayoutTests/fast/text/bulgarian-system-language-shaping.html 2022-06-03 23:45:34 UTC (rev 295250)
@@ -0,0 +1,8 @@
+
+
+
+
+
+
+
+
Modified: trunk/LayoutTests/platform/ios/TestExpectations (295249 => 295250)
--- trunk/LayoutTests/platform/ios/TestExpectations 2022-06-03 23:39:34 UTC (rev 295249)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2022-06-03 23:45:34 UTC (rev 295250)
@@ -3648,4 +3648,6 @@
webkit.org/b/241048 imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-ImageBitmap-video.html [ Failure ]
webkit.org/b/241048 imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html [ Failure ]
-webkit.org/b/241205 fast/forms/textfield-outline.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/241205 fast/forms/textfield-outline.html [ Pass Failure ]
+
+fast/text/bulgarian-system-language-shaping.html [ Pass ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (295249 => 295250)
--- trunk/LayoutTests/platform/mac/TestExpectations 2022-06-03 23:39:34 UTC (rev 295249)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2022-06-03 23:45:34 UTC (rev 295250)
@@ -2302,3 +2302,5 @@
webkit.org/b/227845 [ Debug ] webaudio/audioworket-out-of-memory.html [ Pass Timeout DumpJSConsoleLogInStdErr ]
webkit.org/b/240989 http/tests/media/hls/hls-webvtt-flashing.html [ Pass Failure ]
+
+[ Monterey+ ] fast/text/bulgarian-system-language-shaping.html [ Pass ]
Modified: trunk/Source/WebCore/platform/graphics/coretext/FontCoreText.cpp (295249 => 295250)
--- trunk/Source/WebCore/platform/graphics/coretext/FontCoreText.cpp 2022-06-03 23:39:34 UTC (rev 295249)
+++ trunk/Source/WebCore/platform/graphics/coretext/FontCoreText.cpp 2022-06-03 23:45:34 UTC (rev 295250)
@@ -619,7 +619,7 @@
auto substring = text.substring(beginningStringIndex);
auto upconvertedCharacters = substring.upconvertedCharacters();
-auto localeString = LocaleCocoa::canonicalLanguageIdentifierFromString(locale).string().createCFString();
+auto localeString = locale.isNull() ? nullptr : LocaleCocoa::canonicalLanguageIdentifierFromString(locale).string().createCFString();
auto numberOfInputGlyphs = glyphBuffer.size() - beginningGlyphIndex;
// FIXME: Enable kerning for single glyphs when rdar://82195405 is fixed
CTFontShapeOptions options =
[webkit-changes] [295249] tags/WebKit-7613.3.3/
Title: [295249] tags/WebKit-7613.3.3/ Revision 295249 Author alanc...@apple.com Date 2022-06-03 16:39:34 -0700 (Fri, 03 Jun 2022) Log Message Tag WebKit-7613.3.3. Added Paths tags/WebKit-7613.3.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295248] trunk/LayoutTests/platform/mac-wk2/TestExpectations
Title: [295248] trunk/LayoutTests/platform/mac-wk2/TestExpectations Revision 295248 Author rack...@apple.com Date 2022-06-03 16:38:41 -0700 (Fri, 03 Jun 2022) Log Message [Gardening]: [ macOS Debug wk2 EWS ] fast/animation/request-animation-frame-throttling-lowPowerMode.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=241289 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/251297@main Modified Paths trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (295247 => 295248) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-06-03 23:24:54 UTC (rev 295247) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-06-03 23:38:41 UTC (rev 295248) @@ -1430,7 +1430,7 @@ [ Monterey arm64 ] platform/mac/fast/overflow/overflow-scrollbar-hit-test.html [ Failure Crash ] # rdar://80333935 (REGRESSION: [ Monterey wk2 arm64 ] fast/animation/request-animation-frame-throttling-detached-iframe.html and request-animation-frame-throttling-lowPowerMode.html failing) -[ Monterey arm64 ] fast/animation/request-animation-frame-throttling-lowPowerMode.html [ Failure ] +[ arm64 ] fast/animation/request-animation-frame-throttling-lowPowerMode.html [ Failure ] [ Monterey arm64 ] fast/animation/css-animation-throttling-lowPowerMode.html [ Failure ] # Behavior of navigator-language-ru changed in Monterey ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295247] trunk/Source/WebCore/html/parser
Title: [295247] trunk/Source/WebCore/html/parser
Revision 295247
Author cdu...@apple.com
Date 2022-06-03 16:24:54 -0700 (Fri, 03 Jun 2022)
Log Message
Optimize HTMLToken::appendToAttributeValue()
https://bugs.webkit.org/show_bug.cgi?id=241274
Reviewed by Darin Adler.
Optimize HTMLToken::appendToAttributeValue() by appending all characters at
once instead of one by one.
* Source/WebCore/html/parser/HTMLToken.h:
(WebCore::HTMLToken::appendToAttributeValue):
* Source/WebCore/html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::processToken):
Canonical link: https://commits.webkit.org/251296@main
Modified Paths
trunk/Source/WebCore/html/parser/HTMLToken.h
trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp
Diff
Modified: trunk/Source/WebCore/html/parser/HTMLToken.h (295246 => 295247)
--- trunk/Source/WebCore/html/parser/HTMLToken.h 2022-06-03 23:22:06 UTC (rev 295246)
+++ trunk/Source/WebCore/html/parser/HTMLToken.h 2022-06-03 23:24:54 UTC (rev 295247)
@@ -106,6 +106,7 @@
void appendToAttributeName(UChar);
void appendToAttributeValue(UChar);
void appendToAttributeValue(unsigned index, StringView value);
+template void appendToAttributeValue(Span);
void endAttribute();
void setSelfClosing();
@@ -331,6 +332,14 @@
m_currentAttribute->value.append(character);
}
+template
+inline void HTMLToken::appendToAttributeValue(Span characters)
+{
+ASSERT(m_type == StartTag || m_type == EndTag);
+ASSERT(m_currentAttribute);
+m_currentAttribute->value.append(characters);
+}
+
inline void HTMLToken::appendToAttributeValue(unsigned i, StringView value)
{
ASSERT(!value.isEmpty());
Modified: trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp (295246 => 295247)
--- trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp 2022-06-03 23:22:06 UTC (rev 295246)
+++ trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp 2022-06-03 23:24:54 UTC (rev 295247)
@@ -854,8 +854,10 @@
ASSERT(decodedEntity.isEmpty());
m_token.appendToAttributeValue('&');
} else {
-for (unsigned i = 0; i < decodedEntity.length(); ++i)
-m_token.appendToAttributeValue(decodedEntity[i]);
+if (decodedEntity.is8Bit())
+m_token.appendToAttributeValue(decodedEntity.span());
+else
+m_token.appendToAttributeValue(decodedEntity.span());
}
// We're supposed to switch back to the attribute value state that
// we were in when we were switched into this state. Rather than
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295245] branches/safari-613-branch/Source/WebKit
Title: [295245] branches/safari-613-branch/Source/WebKit Revision 295245 Author repst...@apple.com Date 2022-06-03 16:21:59 -0700 (Fri, 03 Jun 2022) Log Message Revert 637d98e55c078fde1b8a5f7cff22da2cfda99187. rdar://problem/88904160 This reverts commit 637d98e55c078fde1b8a5f7cff22da2cfda99187. Modified Paths branches/safari-613-branch/Source/WebKit/ChangeLog branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm Diff Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (295244 => 295245) --- branches/safari-613-branch/Source/WebKit/ChangeLog 2022-06-03 23:21:56 UTC (rev 295244) +++ branches/safari-613-branch/Source/WebKit/ChangeLog 2022-06-03 23:21:59 UTC (rev 295245) @@ -44,59 +44,6 @@ 2022-04-22 Kimmo Kinnunen -Multiple concurrency violations in LibWebRTCCodecsProxy -https://bugs.webkit.org/show_bug.cgi?id=236767 - - -Reviewed by Antti Koivisto. - -- ThreadMessageReceivers should not add IPC listeners in constructors, -as the delivery starts right away and uses the unconstructed virtual pointer. -- The work queue functions should not use GPUConnectionToWebProcess, as that is -main thread object. -- Locked m_encoders, m_decoders are sometimes accessed without lock. - -Instead: -- Add the IPC listeners in initialize function. -- Remove the IPC listeners when GPUConnectionToWebProcess disconnects. -- Store the thread-safe conection, video frame object heap, process identity -objects as member variables. -- Do not lock m_encoders, m_decoders. If they are work queue instances, -just access them in the work queue functions. Add thread requirements -to the variables so that the compiler checks the access. -- Use IPC testing assertions when skipping incorrect messages. -- Use separate atomic counter (bool) to check if allowsExitUnderMemoryPressure. - -No new tests, tested with existing tests and ASAN. - -* GPUProcess/GPUConnectionToWebProcess.cpp: -(WebKit::GPUConnectionToWebProcess::~GPUConnectionToWebProcess): -(WebKit::GPUConnectionToWebProcess::didClose): -* GPUProcess/GPUConnectionToWebProcess.h: -* GPUProcess/webrtc/LibWebRTCCodecsProxy.h: -* GPUProcess/webrtc/LibWebRTCCodecsProxy.mm: -(WebKit::LibWebRTCCodecsProxy::create): -(WebKit::LibWebRTCCodecsProxy::LibWebRTCCodecsProxy): -(WebKit::LibWebRTCCodecsProxy::stopListeningForIPC): -(WebKit::LibWebRTCCodecsProxy::initialize): -(WebKit::LibWebRTCCodecsProxy::dispatchToThread): -(WebKit::LibWebRTCCodecsProxy::createDecoderCallback): -(WebKit::LibWebRTCCodecsProxy::createH264Decoder): -(WebKit::LibWebRTCCodecsProxy::createH265Decoder): -(WebKit::LibWebRTCCodecsProxy::createVP9Decoder): -(WebKit::LibWebRTCCodecsProxy::releaseDecoder): -(WebKit::LibWebRTCCodecsProxy::createEncoder): -(WebKit::LibWebRTCCodecsProxy::releaseEncoder): -(WebKit::LibWebRTCCodecsProxy::initializeEncoder): -(WebKit::LibWebRTCCodecsProxy::findEncoder): -(WebKit::LibWebRTCCodecsProxy::encodeFrame): -(WebKit::LibWebRTCCodecsProxy::setEncodeRates): -(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameSemaphore): -(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameMemory): -(WebKit::LibWebRTCCodecsProxy::allowsExitUnderMemoryPressure const): - -2022-04-22 Kimmo Kinnunen - Thread safety analysis to assert "code is run sequentially" is not useful when code is mainly run with WorkQueues https://bugs.webkit.org/show_bug.cgi?id=236832 Modified: branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp (295244 => 295245) --- branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp 2022-06-03 23:21:56 UTC (rev 295244) +++ branches/safari-613-branch/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp 2022-06-03 23:21:59 UTC (rev 295245) @@ -274,6 +274,9 @@ #if PLATFORM(COCOA) && ENABLE(MEDIA_STREAM) m_sampleBufferDisplayLayerManager->close(); #endif +#if PLATFORM(COCOA) && USE(LIBWEBRTC) +m_libWebRTCCodecsProxy->close(); +#endif --gObjectCountForTesting; } @@ -306,9 +309,7 @@ WCContentBufferManager::singleton().removeAllContentBuffersForProcess(webProcessIdentifier); }); #endif -#if PLATFORM(COCOA) && USE(LIBWEBRTC) -m_libWebRTCCodecsProxy = nullptr; -#endif + gpuProcess().connectionToWebProcessClosed(connection); gpuProcess().removeGPUConnectionToWebProcess(*this); // May destroy |this|. } Modified:
[webkit-changes] [295244] branches/safari-613-branch
Title: [295244] branches/safari-613-branch Revision 295244 Author repst...@apple.com Date 2022-06-03 16:21:56 -0700 (Fri, 03 Jun 2022) Log Message Revert afffb32a8971addf23e6b2cea93a52cbb6199e54. rdar://problem/92015599 This reverts commit afffb32a8971addf23e6b2cea93a52cbb6199e54. Modified Paths branches/safari-613-branch/Source/WTF/ChangeLog branches/safari-613-branch/Source/WebKit/ChangeLog branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h branches/safari-613-branch/Tools/ChangeLog Diff Modified: branches/safari-613-branch/Source/WTF/ChangeLog (295243 => 295244) --- branches/safari-613-branch/Source/WTF/ChangeLog 2022-06-03 23:21:52 UTC (rev 295243) +++ branches/safari-613-branch/Source/WTF/ChangeLog 2022-06-03 23:21:56 UTC (rev 295244) @@ -26,29 +26,6 @@ (WTF::WorkQueue::assertIsCurrent): (WTF::currentSequenceID): -2022-04-22 Kimmo Kinnunen - -Thread safety analysis to assert "code is run sequentially" is not useful when code is mainly run with WorkQueues -https://bugs.webkit.org/show_bug.cgi?id=236832 - -Thread safety analysis is not useful when code is mainly run with WorkQueues. -WorkQueue runnables might run in arbitrary thread, but still serially in a specific -"work queue". Thus current ThreadAssertion produces false assertions. - -Make Thread and WorkQueue hold "is current" capability. This means the -`assertIsCurrent(thread/workQueue)` can establish that the caller holds the capabity, -e.g. that the caller is running in the particular thread or work queue. - -Tested by new API tests. - -* wtf/Threading.h: -(WTF::WTF_ASSERTS_ACQUIRED_CAPABILITY): -* wtf/WorkQueue.h: -(WTF::WTF_ASSERTS_ACQUIRED_CAPABILITY): -* wtf/cocoa/WorkQueueCocoa.cpp: -(WTF::WorkQueueBase::platformInitialize): -(WTF::WorkQueue::assertIsCurrent const): -(WTF::currentSequenceID): 2022-05-13 Ben Nham Enforce foreground WebContent memory limit on macOS Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (295243 => 295244) --- branches/safari-613-branch/Source/WebKit/ChangeLog 2022-06-03 23:21:52 UTC (rev 295243) +++ branches/safari-613-branch/Source/WebKit/ChangeLog 2022-06-03 23:21:56 UTC (rev 295244) @@ -44,302 +44,6 @@ 2022-04-22 Kimmo Kinnunen -Thread safety analysis to assert "code is run sequentially" is not useful when code is mainly run with WorkQueues -https://bugs.webkit.org/show_bug.cgi?id=236832 - -Assert directly that the work queues are current instead of using ThreadAssertion. - -* GPUProcess/graphics/RemoteGraphicsContextGL.cpp: -(WebKit::RemoteGraphicsContextGL::~RemoteGraphicsContextGL): -(WebKit::RemoteGraphicsContextGL::displayWasReconfigured): -(WebKit::RemoteGraphicsContextGL::workQueueInitialize): -(WebKit::RemoteGraphicsContextGL::workQueueUninitialize): -(WebKit::RemoteGraphicsContextGL::didComposite): -(WebKit::RemoteGraphicsContextGL::forceContextLost): -(WebKit::RemoteGraphicsContextGL::dispatchContextChangedNotification): -(WebKit::RemoteGraphicsContextGL::reshape): -(WebKit::RemoteGraphicsContextGL::prepareForDisplay): -(WebKit::RemoteGraphicsContextGL::synthesizeGLError): -(WebKit::RemoteGraphicsContextGL::getError): -(WebKit::RemoteGraphicsContextGL::ensureExtensionEnabled): -(WebKit::RemoteGraphicsContextGL::markContextChanged): -(WebKit::RemoteGraphicsContextGL::paintRenderingResultsToCanvasWithQualifiedIdentifier): -(WebKit::RemoteGraphicsContextGL::paintCompositedResultsToCanvasWithQualifiedIdentifier): -(WebKit::RemoteGraphicsContextGL::paintCompositedResultsToMediaSample): -(WebKit::RemoteGraphicsContextGL::paintPixelBufferToImageBuffer): -(WebKit::RemoteGraphicsContextGL::simulateEventForTesting): -* GPUProcess/graphics/RemoteGraphicsContextGL.h: -(WebKit::RemoteGraphicsContextGL::workQueue const): -* GPUProcess/graphics/RemoteGraphicsContextGL.messages.in: -* GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp: -(WebKit::RemoteGraphicsContextGL::copyTextureFromVideoFrame): -(WebKit::RemoteGraphicsContextGLCocoa::platformWorkQueueInitialize): -(WebKit::RemoteGraphicsContextGLCocoa::prepareForDisplay): -* GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h: -(moveErrorsToSyntheticErrorList): -(activeTexture): -(attachShader): -(bindAttribLocation): -(bindBuffer): -(bindFramebuffer): -(bindRenderbuffer): -(bindTexture): -(blendColor): -(blendEquation): -(blendEquationSeparate): -(blendFunc): -(blendFuncSeparate): -(checkFramebufferStatus): -(clear): -(clearColor): -
[webkit-changes] [295243] branches/safari-613-branch
Title: [295243] branches/safari-613-branch
Revision 295243
Author repst...@apple.com
Date 2022-06-03 16:21:52 -0700 (Fri, 03 Jun 2022)
Log Message
Revert 704644f751c332c5b1001936cf2cd0446f4bea18. rdar://problem/92380002
This reverts commit 704644f751c332c5b1001936cf2cd0446f4bea18.
Modified Paths
branches/safari-613-branch/Source/WTF/wtf/ThreadAssertions.h
branches/safari-613-branch/Source/WTF/wtf/ThreadSafetyAnalysis.h
branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h
branches/safari-613-branch/Tools/Scripts/webkitpy/style/checkers/cpp.py
branches/safari-613-branch/Tools/TestWebKitAPI/Tests/WTF/ThreadAssertionsTest.cpp
Diff
Modified: branches/safari-613-branch/Source/WTF/wtf/ThreadAssertions.h (295242 => 295243)
--- branches/safari-613-branch/Source/WTF/wtf/ThreadAssertions.h 2022-06-03 23:21:49 UTC (rev 295242)
+++ branches/safari-613-branch/Source/WTF/wtf/ThreadAssertions.h 2022-06-03 23:21:52 UTC (rev 295243)
@@ -41,11 +41,11 @@
// void doTask() { assertIsCurrent(m_ownerThread); doTaskImpl(); }
// template void doTaskCompileFailure() { doTaskImpl(); }
// private:
-// void doTaskImpl() WTF_REQUIRES_CAPABILITY(m_ownerThread);
-// int m_value WTF_GUARDED_BY_CAPABILITY(m_ownerThread) { 0 };
+// void doTaskImpl() WTF_REQUIRES_LOCK(m_ownerThread);
+// int m_value WTF_GUARDED_BY_LOCK(m_ownerThread) { 0 };
// NO_UNIQUE_ADDRESS ThreadAssertion m_ownerThread;
// };
-class WTF_CAPABILITY("is current") ThreadAssertion {
+class WTF_CAPABILITY_LOCK ThreadAssertion {
public:
ThreadAssertion() = default;
enum UninitializedTag { Uninitialized };
@@ -64,7 +64,7 @@
friend void assertIsCurrent(const ThreadAssertion&);
};
-inline void assertIsCurrent(const ThreadAssertion& threadAssertion) WTF_ASSERTS_ACQUIRED_CAPABILITY(threadAssertion)
+inline void assertIsCurrent(const ThreadAssertion& threadAssertion) WTF_ASSERTS_ACQUIRED_LOCK(threadAssertion)
{
ASSERT_UNUSED(threadAssertion, Thread::current().uid() == threadAssertion.m_uid);
}
@@ -74,8 +74,8 @@
// a known named thread.
// Example:
// extern NamedAssertion& mainThread;
-// inline void assertIsMainThread() WTF_ASSERTS_ACQUIRED_CAPABILITY(mainThread);
-// void myTask() WTF_REQUIRES_CAPABILITY(mainThread) { printf("my task is running"); }
+// inline void assertIsMainThread() WTF_ASSERTS_ACQUIRED_LOCK(mainThread);
+// void myTask() WTF_REQUIRES_LOCK(mainThread) { printf("my task is running"); }
// void runner() {
// assertIsMainThread();
// myTask();
@@ -83,15 +83,15 @@
// template runnerCompileFailure() {
// myTask();
// }
-class WTF_CAPABILITY("is current") NamedAssertion { };
+class WTF_CAPABILITY_LOCK NamedAssertion { };
-// To be used with WTF_REQUIRES_CAPABILITY(mainThread). Symbol is undefined.
+// To be used with WTF_REQUIRES_LOCK(mainThread). Symbol is undefined.
extern NamedAssertion& mainThread;
-inline void assertIsMainThread() WTF_ASSERTS_ACQUIRED_CAPABILITY(mainThread) { ASSERT(isMainThread()); }
+inline void assertIsMainThread() WTF_ASSERTS_ACQUIRED_LOCK(mainThread) { ASSERT(isMainThread()); }
-// To be used with WTF_REQUIRES_CAPABILITY(mainRunLoop). Symbol is undefined.
+// To be used with WTF_REQUIRES_LOCK(mainRunLoop). Symbol is undefined.
extern NamedAssertion& mainRunLoop;
-inline void assertIsMainRunLoop() WTF_ASSERTS_ACQUIRED_CAPABILITY(mainRunLoop) { ASSERT(isMainRunLoop()); }
+inline void assertIsMainRunLoop() WTF_ASSERTS_ACQUIRED_LOCK(mainRunLoop) { ASSERT(isMainRunLoop()); }
}
Modified: branches/safari-613-branch/Source/WTF/wtf/ThreadSafetyAnalysis.h (295242 => 295243)
--- branches/safari-613-branch/Source/WTF/wtf/ThreadSafetyAnalysis.h 2022-06-03 23:21:49 UTC (rev 295242)
+++ branches/safari-613-branch/Source/WTF/wtf/ThreadSafetyAnalysis.h 2022-06-03 23:21:52 UTC (rev 295243)
@@ -35,39 +35,21 @@
#define WTF_THREAD_ANNOTATION_ATTRIBUTE(x)
#endif
-#define WTF_ACQUIRES_CAPABILITY_IF(...) WTF_THREAD_ANNOTATION_ATTRIBUTE(try_acquire_capability(__VA_ARGS__))
-#define WTF_ACQUIRES_CAPABILITY(...) WTF_THREAD_ANNOTATION_ATTRIBUTE(acquire_capability(__VA_ARGS__))
-#define WTF_ACQUIRES_SHARED_CAPABILITY_IF(...) WTF_THREAD_ANNOTATION_ATTRIBUTE(try_acquire_shared_capability(__VA_ARGS__))
-#define WTF_ACQUIRES_SHARED_CAPABILITY(...) WTF_THREAD_ANNOTATION_ATTRIBUTE(acquire_shared_capability(__VA_ARGS__))
-#define WTF_ASSERTS_ACQUIRED_CAPABILITY(x) WTF_THREAD_ANNOTATION_ATTRIBUTE(assert_capability(x))
-#define WTF_ASSERTS_ACQUIRED_SHARED_CAPABILITY(x) WTF_THREAD_ANNOTATION_ATTRIBUTE(assert_shared_capability(x))
-#define WTF_CAPABILITY(name) WTF_THREAD_ANNOTATION_ATTRIBUTE(capability(name))
+#define WTF_ACQUIRES_LOCK_IF(...) WTF_THREAD_ANNOTATION_ATTRIBUTE(try_acquire_capability(__VA_ARGS__))
+#define WTF_ACQUIRES_LOCK(...) WTF_THREAD_ANNOTATION_ATTRIBUTE(acquire_capability(__VA_ARGS__))
+#define WTF_ACQUIRES_SHARED_LOCK_IF(...) WTF_THREAD_ANNOTATION_ATTRIBUTE(try_acquire_shared_capability(__VA_ARGS__))
+#define
[webkit-changes] [295242] branches/safari-613-branch/Source/WebKit
Title: [295242] branches/safari-613-branch/Source/WebKit
Revision 295242
Author repst...@apple.com
Date 2022-06-03 16:21:49 -0700 (Fri, 03 Jun 2022)
Log Message
Revert a56ea95c510fc523f36e6f179f2e6a9763418f4e. rdar://problem/88904160
This reverts commit a56ea95c510fc523f36e6f179f2e6a9763418f4e.
Modified Paths
branches/safari-613-branch/Source/WebKit/ChangeLog
branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h
branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm
Diff
Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (295241 => 295242)
--- branches/safari-613-branch/Source/WebKit/ChangeLog 2022-06-03 23:21:46 UTC (rev 295241)
+++ branches/safari-613-branch/Source/WebKit/ChangeLog 2022-06-03 23:21:49 UTC (rev 295242)
@@ -44,59 +44,6 @@
2022-04-22 Kimmo Kinnunen
-Multiple concurrency violations in LibWebRTCCodecsProxy
-https://bugs.webkit.org/show_bug.cgi?id=236767
-
-
-Reviewed by Antti Koivisto.
-
-- ThreadMessageReceivers should not add IPC listeners in constructors,
-as the delivery starts right away and uses the unconstructed virtual pointer.
-- The work queue functions should not use GPUConnectionToWebProcess, as that is
-main thread object.
-- Locked m_encoders, m_decoders are sometimes accessed without lock.
-
-Instead:
-- Add the IPC listeners in initialize function.
-- Remove the IPC listeners when GPUConnectionToWebProcess disconnects.
-- Store the thread-safe conection, video frame object heap, process identity
-objects as member variables.
-- Do not lock m_encoders, m_decoders. If they are work queue instances,
-just access them in the work queue functions. Add thread requirements
-to the variables so that the compiler checks the access.
-- Use IPC testing assertions when skipping incorrect messages.
-- Use separate atomic counter (bool) to check if allowsExitUnderMemoryPressure.
-
-No new tests, tested with existing tests and ASAN.
-
-* GPUProcess/GPUConnectionToWebProcess.cpp:
-(WebKit::GPUConnectionToWebProcess::~GPUConnectionToWebProcess):
-(WebKit::GPUConnectionToWebProcess::didClose):
-* GPUProcess/GPUConnectionToWebProcess.h:
-* GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
-* GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
-(WebKit::LibWebRTCCodecsProxy::create):
-(WebKit::LibWebRTCCodecsProxy::LibWebRTCCodecsProxy):
-(WebKit::LibWebRTCCodecsProxy::stopListeningForIPC):
-(WebKit::LibWebRTCCodecsProxy::initialize):
-(WebKit::LibWebRTCCodecsProxy::dispatchToThread):
-(WebKit::LibWebRTCCodecsProxy::createDecoderCallback):
-(WebKit::LibWebRTCCodecsProxy::createH264Decoder):
-(WebKit::LibWebRTCCodecsProxy::createH265Decoder):
-(WebKit::LibWebRTCCodecsProxy::createVP9Decoder):
-(WebKit::LibWebRTCCodecsProxy::releaseDecoder):
-(WebKit::LibWebRTCCodecsProxy::createEncoder):
-(WebKit::LibWebRTCCodecsProxy::releaseEncoder):
-(WebKit::LibWebRTCCodecsProxy::initializeEncoder):
-(WebKit::LibWebRTCCodecsProxy::findEncoder):
-(WebKit::LibWebRTCCodecsProxy::encodeFrame):
-(WebKit::LibWebRTCCodecsProxy::setEncodeRates):
-(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameSemaphore):
-(WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameMemory):
-(WebKit::LibWebRTCCodecsProxy::allowsExitUnderMemoryPressure const):
-
-2022-04-22 Kimmo Kinnunen
-
Thread safety analysis to assert "code is run sequentially" is not useful when code is mainly run with WorkQueues
https://bugs.webkit.org/show_bug.cgi?id=236832
Modified: branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp (295241 => 295242)
--- branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp 2022-06-03 23:21:46 UTC (rev 295241)
+++ branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp 2022-06-03 23:21:49 UTC (rev 295242)
@@ -252,7 +252,7 @@
void RemoteGraphicsContextGL::copyTextureFromMedia(WebCore::MediaPlayerIdentifier mediaPlayerIdentifier, uint32_t texture, uint32_t target, int32_t level, uint32_t internalFormat, uint32_t format, uint32_t type, bool premultiplyAlpha, bool flipY, CompletionHandler&& completionHandler)
{
-assertIsCurrent(workQueue());
+assertIsCurrent(m_workQueue());
#if USE(AVFOUNDATION)
UNUSED_VARIABLE(premultiplyAlpha);
ASSERT_UNUSED(target, target == GraphicsContextGL::TEXTURE_2D);
Modified: branches/safari-613-branch/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h (295241 => 295242)
---
[webkit-changes] [295241] branches/safari-613-branch/Source/WebCore/editing/ BreakBlockquoteCommand.cpp
Title: [295241] branches/safari-613-branch/Source/WebCore/editing/BreakBlockquoteCommand.cpp
Revision 295241
Author repst...@apple.com
Date 2022-06-03 16:21:46 -0700 (Fri, 03 Jun 2022)
Log Message
Unreviewed build fix. rdar://14839536
./editing/BreakBlockquoteCommand.cpp:29:10: fatal error: 'CommonAtomStrings.h' file not found
Modified Paths
branches/safari-613-branch/Source/WebCore/editing/BreakBlockquoteCommand.cpp
Diff
Modified: branches/safari-613-branch/Source/WebCore/editing/BreakBlockquoteCommand.cpp (295240 => 295241)
--- branches/safari-613-branch/Source/WebCore/editing/BreakBlockquoteCommand.cpp 2022-06-03 23:09:33 UTC (rev 295240)
+++ branches/safari-613-branch/Source/WebCore/editing/BreakBlockquoteCommand.cpp 2022-06-03 23:21:46 UTC (rev 295241)
@@ -26,7 +26,6 @@
#include "config.h"
#include "BreakBlockquoteCommand.h"
-#include "CommonAtomStrings.h"
#include "Editing.h"
#include "ElementInlines.h"
#include "HTMLBRElement.h"
@@ -88,7 +87,7 @@
return lineBreak;
auto container = HTMLDivElement::create(document());
-container->setDir(autoAtom());
+container->setDir("auto"_s);
container->appendChild(lineBreak);
return container;
}();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295239] trunk
Title: [295239] trunk
Revision 295239
Author commit-qu...@webkit.org
Date 2022-06-03 15:29:47 -0700 (Fri, 03 Jun 2022)
Log Message
Properly implement text-align-last in legacy layout engine and IFC
https://bugs.webkit.org/show_bug.cgi?id=241050
Patch by Kiet Ho on 2022-06-03
Reviewed by Alan Bujtas.
The alignment of the last line in a block always follows the alignment specified
by text-align-last. However, the legacy layout engine currently follows the old
spec, where text-align-last only takes effect when text-align was 'justify' (see [1]
where this was changed), and IFC does not honor text-align-last at all. Fix both the
legacy layout engine and IFC to align the last line according to text-align-last.
Manually tested by running run-webkit-tests with IFC enabled and disabled.
[1]: https://github.com/w3c/csswg-drafts/commit/c1f7023611f2c44d24d5a0647965817902651f58
* LayoutTests/TestExpectations:
* LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify-expected.html: Removed.
* LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html:
Remove obsolete test that tests the old behavior of text-align-line.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::LineBoxBuilder::build):
* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::textAlignmentForLine const):
Canonical link: https://commits.webkit.org/251294@main
Modified Paths
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
trunk/Source/WebCore/rendering/LegacyLineLayout.cpp
Removed Paths
trunk/LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify-expected.html
trunk/LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html
Diff
Modified: trunk/LayoutTests/TestExpectations (295238 => 295239)
--- trunk/LayoutTests/TestExpectations 2022-06-03 22:21:23 UTC (rev 295238)
+++ trunk/LayoutTests/TestExpectations 2022-06-03 22:29:47 UTC (rev 295239)
@@ -2642,9 +2642,6 @@
webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-004.html [ ImageOnlyFailure ]
webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-005.html [ ImageOnlyFailure ]
webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-006.html [ ImageOnlyFailure ]
-webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-010.html [ ImageOnlyFailure ]
-webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-011.html [ ImageOnlyFailure ]
-webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-wins-001.html [ ImageOnlyFailure ]
webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/text-encoding/shaping-join-003.html [ ImageOnlyFailure ]
webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/text-encoding/shaping-tatweel-002.html [ ImageOnlyFailure ]
webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/text-encoding/shaping-tatweel-003.html [ ImageOnlyFailure ]
Deleted: trunk/LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify-expected.html (295238 => 295239)
--- trunk/LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify-expected.html 2022-06-03 22:21:23 UTC (rev 295238)
+++ trunk/LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify-expected.html 2022-06-03 22:29:47 UTC (rev 295239)
@@ -1,37 +0,0 @@
-
-
-
-
-#tests div {
-width: 100px;
-margin-bottom: 20px;
-border: 1px solid #00;
-font: 20px/1 Ahem, sans-serif;
-}
-
-
-
-
-
-text-align : start; text-align-last : end
-X X X XXX
-
-text-align : end; text-align-last : start
-X X X XXX
-
-text-align : left; text-align-last : right
-X X X XXX
-
-text-align : right; text-align-last : left
-X X X XXX
-
-text-align : center; text-align-last : left
-X X X XXX
-
-
-Since text-align is not justify, text-align-last property shouldn't be respected,
-thus the alignment should be as defined by text-align.
-
-
-
-
Deleted: trunk/LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html (295238 => 295239)
--- trunk/LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html 2022-06-03 22:21:23 UTC (rev 295238)
+++ trunk/LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html 2022-06-03 22:29:47 UTC (rev 295239)
@@ -1,38 +0,0 @@
-
-
-
-
-#tests div {
-width: 100px;
-margin-bottom: 20px;
-border: 1px solid #00;
-font: 20px/1 Ahem,
[webkit-changes] [295238] trunk/Tools
Title: [295238] trunk/Tools
Revision 295238
Author hironori.fu...@sony.com
Date 2022-06-03 15:21:23 -0700 (Fri, 03 Jun 2022)
Log Message
webkit-patch: `git am` strips []-enclosed prefixes (e.g. [CMake][WPE]) in a subject
https://bugs.webkit.org/show_bug.cgi?id=241114
Reviewed by Jonathan Bedard.
git-am removes all []-enclosed prefixes from a subject by default.
git-am has --keep-non-patch option that removes only "[PATCH]" prefix.
* Tools/CISupport/ews-build/steps.py:
(run):
* Tools/Scripts/webkitpy/common/checkout/checkout.py:
(apply_patch):
Use `--keep-non-patch` option for `git am`.
Canonical link: https://commits.webkit.org/251293@main
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (295237 => 295238)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-06-03 22:08:21 UTC (rev 295237)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-06-03 22:21:23 UTC (rev 295238)
@@ -887,7 +887,7 @@
if not patch:
commands += [['curl', '-L', 'https://bugs.webkit.org/attachment.cgi?id={}'.format(self.getProperty('patch_id', '')), '-o', '.buildbot-diff']]
commands += [
-['git', 'am', '.buildbot-diff'],
+['git', 'am', '--keep-non-patch', '.buildbot-diff'],
['git', 'filter-branch', '-f', '--msg-filter', 'python3 -c "{}"'.format(self.FILTER_BRANCH_PROGRAM), 'HEAD...HEAD~1'],
]
for command in commands:
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py (295237 => 295238)
--- trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py 2022-06-03 22:08:21 UTC (rev 295237)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py 2022-06-03 22:21:23 UTC (rev 295238)
@@ -173,7 +173,7 @@
num_commits = len(self.COMMIT_SUBJECT_RE.findall(encoded_patch))
if isinstance(self._scm, Git) and num_commits:
self._executive.run_command(
-['git', 'am'],
+['git', 'am', '--keep-non-patch'],
input=self.filter_patch_content(encoded_patch, reviewer=patch.reviewer().full_name if patch.reviewer() else None),
cwd=self._scm.checkout_root,
)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295237] trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm
Title: [295237] trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm
Revision 295237
Author katherine_che...@apple.com
Date 2022-06-03 15:08:21 -0700 (Fri, 03 Jun 2022)
Log Message
REGRESSION: [ iOS ] Six TestWebKitAPI.AppPrivacyRep ort API tests are a consistent timeout (241233)
https://bugs.webkit.org/show_bug.cgi?id=241233
rdar://94298162
Reviewed by Ryan Haddad.
Avoid connecting to the internet in API tests.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:
(TEST):
Canonical link: https://commits.webkit.org/251292@main
Modified Paths
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm
Diff
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm (295236 => 295237)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm 2022-06-03 22:02:34 UTC (rev 295236)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm 2022-06-03 22:08:21 UTC (rev 295237)
@@ -44,10 +44,12 @@
#if ENABLE(APP_PRIVACY_REPORT)
TEST(AppPrivacyReport, DefaultRequestIsAppInitiated)
{
+TestWebKitAPI::HTTPServer server(TestWebKitAPI::HTTPServer::respondWithChallengeThenOK);
+
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectZero configuration:configuration.get()]);
-NSString *url = ""
+NSString *url = "" stringWithFormat:@"http://127.0.0.1:%d/", server.port()];
__block bool isDone = false;
// Don't set the attribution API on NSURLRequest to make sure the default is app initiated.
@@ -73,10 +75,11 @@
TEST(AppPrivacyReport, AppInitiatedRequest)
{
+TestWebKitAPI::HTTPServer server(TestWebKitAPI::HTTPServer::respondWithChallengeThenOK);
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectZero configuration:configuration.get()]);
-NSString *url = ""
+NSString *url = "" stringWithFormat:@"http://127.0.0.1:%d/", server.port()];
__block bool isDone = false;
NSMutableURLRequest *appInitiatedRequest = [NSMutableURLRequest requestWithURL:[NSURL URLWithString:url]];
@@ -104,10 +107,12 @@
TEST(AppPrivacyReport, NonAppInitiatedRequest)
{
+TestWebKitAPI::HTTPServer server(TestWebKitAPI::HTTPServer::respondWithChallengeThenOK);
+
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectZero configuration:configuration.get()]);
-NSString *url = ""
+NSString *url = "" stringWithFormat:@"http://127.0.0.1:%d/", server.port()];
__block bool isDone = false;
NSMutableURLRequest *nonAppInitiatedRequest = [NSMutableURLRequest requestWithURL:[NSURL URLWithString:url]];
@@ -135,11 +140,13 @@
TEST(AppPrivacyReport, AppInitiatedRequestWithNavigation)
{
+TestWebKitAPI::HTTPServer server(TestWebKitAPI::HTTPServer::respondWithChallengeThenOK);
+
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectZero configuration:configuration.get()]);
-NSString *appInitiatedURL = @"https://www.webkit.org";
-NSString *nonAppInitiatedURL = @"https://www.apple.com";
+NSString *appInitiatedURL = [NSString stringWithFormat:@"http://127.0.0.1:%d/", server.port()];
+NSString *nonAppInitiatedURL = [NSString stringWithFormat:@"http://localhost:%d/", server.port()];
NSMutableURLRequest *appInitiatedRequest = [NSMutableURLRequest requestWithURL:[NSURL URLWithString:appInitiatedURL]];
appInitiatedRequest.attribution = NSURLRequestAttributionDeveloper;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295236] trunk/LayoutTests/platform/win/TestExpectations
Title: [295236] trunk/LayoutTests/platform/win/TestExpectations Revision 295236 Author rack...@apple.com Date 2022-06-03 15:02:34 -0700 (Fri, 03 Jun 2022) Log Message [Gardening]: [Win] Update expectations for layout tests. https://bugs.webkit.org/show_bug.cgi?id=172437 Unreviewed test gardening. * LayoutTests/platform/win/TestExpectations: Canonical link: https://commits.webkit.org/251291@main Modified Paths trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/platform/win/TestExpectations (295235 => 295236) --- trunk/LayoutTests/platform/win/TestExpectations 2022-06-03 21:44:57 UTC (rev 295235) +++ trunk/LayoutTests/platform/win/TestExpectations 2022-06-03 22:02:34 UTC (rev 295236) @@ -3693,7 +3693,7 @@ editing/caret/emoji.html [ Failure ] editing/deleting/skip-virama-001.html [ Failure ] fast/animation/request-animation-frame-throttling-detached-iframe.html [ Failure ] -fast/animation/request-animation-frame-throttling-lowPowerMode.html [ Failure ] +fast/animation/request-animation-frame-throttling-lowPowerMode.html [ Failure Timeout ] fast/block/positioning/016.html [ Failure ] fast/block/positioning/025.html [ Failure ] fast/block/positioning/fixed-position-stacking-context.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295235] trunk/Source/WebKit/Resources/SandboxProfiles/ios/ com.apple.WebKit.GPU.sb.in
Title: [295235] trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in Revision 295235 Author pvol...@apple.com Date 2022-06-03 14:44:57 -0700 (Fri, 03 Jun 2022) Log Message [iOS][GPUP] Add read access to Mobile asset font directory https://bugs.webkit.org/show_bug.cgi?id=241276 Reviewed by Geoffrey Garen. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Canonical link: https://commits.webkit.org/251290@main Modified Paths trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in Diff Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in (295234 => 295235) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in 2022-06-03 21:21:14 UTC (rev 295234) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in 2022-06-03 21:44:57 UTC (rev 295235) @@ -490,6 +490,9 @@ ;; Permit reading assets via MobileAsset framework. (asset-access 'with-media-playback) +(allow file-read* +(subpath "/private/var/MobileAsset/AssetsV2/com_apple_MobileAsset_Font7")) + ;; allow 3rd party applications to access nsurlstoraged's top level domain data cache (allow-well-known-system-group-container-literal-read "/systemgroup.com.apple.nsurlstoragedresources/Library/dafsaData.bin") ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295234] trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
Title: [295234] trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
Revision 295234
Author pvol...@apple.com
Date 2022-06-03 14:21:14 -0700 (Fri, 03 Jun 2022)
Log Message
Enable HEIC decoding for all non-browser apps on macOS
https://bugs.webkit.org/show_bug.cgi?id=241271
Reviewed by Geoffrey Garen.
Enable HEIC decoding for all non-browser apps on macOS, since this capability is also needed for other apps besides Mail.
We do not want to enable it for Web browsers yet, since this currently requries an unconditional sandbox extension for
trustd.
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
Canonical link: https://commits.webkit.org/251289@main
Modified Paths
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
Diff
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (295233 => 295234)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2022-06-03 21:12:12 UTC (rev 295233)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2022-06-03 21:21:14 UTC (rev 295234)
@@ -393,7 +393,7 @@
#if HAVE(VIDEO_RESTRICTED_DECODING)
#if PLATFORM(MAC)
-if (MacApplication::isAppleMail() || CocoaApplication::isWebkitTestRunner()) {
+if (!isFullWebBrowser()) {
if (auto trustdExtensionHandle = SandboxExtension::createHandleForMachLookup("com.apple.trustd.agent"_s, std::nullopt))
parameters.trustdExtensionHandle = WTFMove(*trustdExtensionHandle);
parameters.enableDecodingHEIC = true;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295233] trunk/Source/WebCore/platform/graphics/texmap
Title: [295233] trunk/Source/WebCore/platform/graphics/texmap
Revision 295233
Author hironori.fu...@sony.com
Date 2022-06-03 14:12:12 -0700 (Fri, 03 Jun 2022)
Log Message
Remove TextureMapperLayer::setChildren(const Vector&) to make TextureMapperLayer independent to GraphicsLayer and GraphicsLayerTextureMapper
https://bugs.webkit.org/show_bug.cgi?id=241248
Reviewed by Don Olmstead.
setChildren(const Vector&) was taking GraphicsLayer
objects as an argument, and assuming the GraphicsLayer objects were
GraphicsLayerTextureMapper objects. This was a layer violation.
TextureMapperLayer doen't need to know about GraphicsLayer and
GraphicsLayerTextureMapper.
* Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
* Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:
* Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h:
Canonical link: https://commits.webkit.org/251288@main
Modified Paths
trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h
Diff
Modified: trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp (295232 => 295233)
--- trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp 2022-06-03 21:08:41 UTC (rev 295232)
+++ trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp 2022-06-03 21:12:12 UTC (rev 295233)
@@ -417,10 +417,10 @@
return;
if (m_changeMask & ChildrenChange) {
-Vector rawChildren;
+Vector rawChildren;
rawChildren.reserveInitialCapacity(children().size());
-for (auto& layer : children())
-rawChildren.uncheckedAppend(layer.ptr());
+for (auto& child : children())
+rawChildren.uncheckedAppend((child.get()).layer());
m_layer.setChildren(rawChildren);
}
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp (295232 => 295233)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2022-06-03 21:08:41 UTC (rev 295232)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2022-06-03 21:12:12 UTC (rev 295233)
@@ -21,7 +21,6 @@
#include "TextureMapperLayer.h"
#include "FloatQuad.h"
-#include "GraphicsLayerTextureMapper.h"
#include "Region.h"
#include
#include
@@ -506,15 +505,6 @@
paintUsingOverlapRegions(options);
}
-#if !USE(COORDINATED_GRAPHICS)
-void TextureMapperLayer::setChildren(const Vector& newChildren)
-{
-removeAllChildren();
-for (auto* child : newChildren)
-addChild((child)->layer());
-}
-#endif
-
void TextureMapperLayer::setChildren(const Vector& newChildren)
{
removeAllChildren();
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h (295232 => 295233)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h 2022-06-03 21:08:41 UTC (rev 295232)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h 2022-06-03 21:12:12 UTC (rev 295233)
@@ -32,7 +32,6 @@
namespace WebCore {
-class GraphicsLayer;
class Region;
class TextureMapperPaintOptions;
class TextureMapperPlatformLayer;
@@ -49,9 +48,6 @@
const Vector& children() const { return m_children; }
-#if !USE(COORDINATED_GRAPHICS)
-void setChildren(const Vector&);
-#endif
void setChildren(const Vector&);
void setMaskLayer(TextureMapperLayer*);
void setReplicaLayer(TextureMapperLayer*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295232] trunk
Title: [295232] trunk Revision 295232 Author drou...@apple.com Date 2022-06-03 14:08:41 -0700 (Fri, 03 Jun 2022) Log Message Web Inspector: drop InspectorAdditionsEnabled in favor of new methods on InspectorFrontendhost https://bugs.webkit.org/show_bug.cgi?id=241192 Reviewed by Patrick Angle. This removes custom things from standardized IDLs and allows custom functionality necessary for Web Inspector to be kept inside inspector objects (as well as the fact that `InspectorFrontendHost` is guaranteed to exist, so there's no concern about this functionality not being available). * Source/WTF/Scripts/Preferences/WebPreferences.yaml: * Source/WebCore/page/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setInspectorAdditionsEnabled): Deleted. (WebCore::RuntimeEnabledFeatures::inspectorAdditionsEnabled const): Deleted. * Source/WebKit/UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetInspectorAdditionsEnabled): Deleted. (WKPreferencesGetInspectorAdditionsEnabled): Deleted. * Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h: * Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp: (WebKit::WebInspectorUI::enableFrontendFeatures): * Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferences.mm: (-[WebPreferences inspectorAdditionsEnabled]): Deleted. (-[WebPreferences setInspectorAdditionsEnabled:]): Deleted. * Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h: * Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl: * Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h: * Source/WebKitLegacy/win/WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::inspectorAdditionsEnabled): Deleted. (WebPreferences::setInspectorAdditionsEnabled): Deleted. * Source/WebKitLegacy/win/WebPreferences.h: * Source/WebKitLegacy/win/WebView.cpp: (WebView::notifyPreferencesChanged): * Tools/DumpRenderTree/TestOptions.cpp: (WTR::TestOptions::defaults): Remove all things related to `InspectorAdditionsEnabled`. * Source/WebCore/html/canvas/CanvasPath.idl: * Source/WebCore/html/canvas/CanvasRenderingContext2D.idl: * Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.idl: Remove nonstandard functionality gated by `InspectorAdditionsEnabled` in standardized IDLs. * Source/WebCore/inspector/InspectorFrontendHost.h: * Source/WebCore/inspector/InspectorFrontendHost.idl: * Source/WebCore/inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::getPath const): Added. (WebCore::InspectorFrontendHost::getCurrentX const): Added. (WebCore::InspectorFrontendHost::getCurrentY const): Added. (WebCore::InspectorFrontendHost::setPath const): Added. * Source/WebInspectorUI/UserInterface/Base/IDLExtensions.js: Added. (File.prototype.getPath): Added. (CanvasRenderingContext2D.prototype.currentX): Added. (CanvasRenderingContext2D.prototype.currentY): Added. (CanvasRenderingContext2D.prototype.getPath): Added. (CanvasRenderingContext2D.prototype.setPath): Added. Centralize all custom IDL extensions in a new file with the same name so it's very easy to find. * Source/WebInspectorUI/UserInterface/Base/ImageUtilities.js: (WI.ImageUtilities.supportsCanvasPathDebugging): Deleted. * Source/WebInspectorUI/UserInterface/Models/RecordingAction.js: (WI.RecordingAction.prototype.process): * Source/WebInspectorUI/UserInterface/Models/RecordingState.js: (WI.RecordingState.prototype.fromContext): * Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js: (WI.RecordingContentView): (WI.RecordingContentView.prototype.get navigationItems): (WI.RecordingContentView.prototype.attached): (WI.RecordingContentView.prototype._generateContentCanvas2D): * Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js: (WI.ResourceContentView.prototype.async _handleMapLocalResourceOverrideToFile): Remove checks based on `InspectorAdditionsEnabled` (technically they check for the existence of the custom functionality on the builtin prototype, but that's added based on `InspectorAdditionsEnabled`). * Source/WebInspectorUI/UserInterface/Main.html: * Source/WebInspectorUI/UserInterface/Test.html: * LayoutTests/fast/canvas/2d.currentPoint.html: Removed. * LayoutTests/fast/canvas/2d.currentPoint-expected.txt: Removed. * LayoutTests/fast/canvas/2d.getPath.modification.html: Removed. * LayoutTests/fast/canvas/2d.getPath.modification-expected.txt: Removed. * LayoutTests/fast/canvas/2d.getPath.newobject.html: Removed. * LayoutTests/fast/canvas/2d.getPath.newobject-expected.txt: Removed. * LayoutTests/fast/canvas/2d.setPath.html: Removed. * LayoutTests/fast/canvas/2d.setPath-expected.txt: Removed. * LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/getPath.html: Added. * LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/getPath-expected.txt: Added. * LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/get_currentX.html: Added. *
[webkit-changes] [295229] trunk/Tools/CISupport/build-webkit-org
Title: [295229] trunk/Tools/CISupport/build-webkit-org
Revision 295229
Author ryanhad...@apple.com
Date 2022-06-03 14:03:40 -0700 (Fri, 03 Jun 2022)
Log Message
Repurpose arm64 iOS simulator GPUP bot as a general arm64 iOS simulator tester
https://bugs.webkit.org/show_bug.cgi?id=241278
Reviewed by Aakash Jain.
* Tools/CISupport/build-webkit-org/config.json:
* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
Canonical link: https://commits.webkit.org/251284@main
Modified Paths
trunk/Tools/CISupport/build-webkit-org/config.json
trunk/Tools/CISupport/build-webkit-org/factories_unittest.py
trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/config.json (295228 => 295229)
--- trunk/Tools/CISupport/build-webkit-org/config.json 2022-06-03 21:00:51 UTC (rev 295228)
+++ trunk/Tools/CISupport/build-webkit-org/config.json 2022-06-03 21:03:40 UTC (rev 295229)
@@ -311,7 +311,7 @@
{
"name": "Apple-iOS-15-Simulator-Release-Build", "factory": "BuildFactory",
"platform": "ios-simulator-15", "configuration": "release", "architectures": ["x86_64", "arm64"],
- "triggers": ["ios-simulator-15-release-gpuprocess-arm64-tests-wk2", "ios-simulator-15-release-gpuprocess-tests-wk2", "ios-simulator-15-release-tests-wk2", "ipados-simulator-15-release-tests-wk2"],
+ "triggers": ["ios-simulator-15-release-arm64-tests-wk2", "ios-simulator-15-release-gpuprocess-tests-wk2", "ios-simulator-15-release-tests-wk2", "ipados-simulator-15-release-tests-wk2"],
"workernames": ["bot614", "bot641", "bot682", "bot685", "bot303", "bot305", "bot306"]
},
{
@@ -321,9 +321,9 @@
"workernames": ["bot694", "bot695", "bot307", "bot308"]
},
{
- "name": "Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests", "factory": "TestAllButJSCFactory",
+ "name": "Apple-iOS-15-Simulator-Release-arm64-WK2-Tests", "factory": "TestAllButJSCFactory",
"platform": "ios-simulator-15", "configuration": "release", "architectures": ["x86_64", "arm64"], "device_model": "iphone",
- "additionalArguments": ["--no-retry-failures", "--use-gpu-process", "--accelerated-drawing"],
+ "additionalArguments": ["--no-retry-failures"],
"workernames": ["bot210"]
},
{
@@ -733,8 +733,8 @@
{ "type": "PlatformSpecificScheduler", "platform": "win", "branch": "main", "treeStableTimer": 45.0,
"builderNames": ["Apple-Win-10-Release-Build", "Apple-Win-10-Debug-Build"]
},
-{ "type": "Triggerable", "name": "ios-simulator-15-release-gpuprocess-arm64-tests-wk2",
- "builderNames": ["Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests"]
+{ "type": "Triggerable", "name": "ios-simulator-15-release-arm64-tests-wk2",
+ "builderNames": ["Apple-iOS-15-Simulator-Release-arm64-WK2-Tests"]
},
{ "type": "Triggerable", "name": "ios-simulator-15-release-gpuprocess-tests-wk2",
"builderNames": ["Apple-iOS-15-Simulator-Release-GPUProcess-WK2-Tests"]
Modified: trunk/Tools/CISupport/build-webkit-org/factories_unittest.py (295228 => 295229)
--- trunk/Tools/CISupport/build-webkit-org/factories_unittest.py 2022-06-03 21:00:51 UTC (rev 295228)
+++ trunk/Tools/CISupport/build-webkit-org/factories_unittest.py 2022-06-03 21:03:40 UTC (rev 295229)
@@ -736,7 +736,7 @@
'transfer-to-s3',
'trigger'
],
-'Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests': [
+'Apple-iOS-15-Simulator-Release-arm64-WK2-Tests': [
'configure-build',
'configuration',
'clean-and-update-working-directory',
Modified: trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js (295228 => 295229)
--- trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js 2022-06-03 21:00:51 UTC (rev 295228)
+++ trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js 2022-06-03 21:03:40 UTC (rev 295229)
@@ -61,6 +61,7 @@
}},
"Apple-iOS-15-Release-Build": {platform: Dashboard.Platform.iOS15Device, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
"Apple-iOS-15-Simulator-Release-Build": {platform: Dashboard.Platform.iOS15Simulator, debug: false, builder: true, architecture:
[webkit-changes] [295230] trunk
Title: [295230] trunk
Revision 295230
Author achristen...@apple.com
Date 2022-06-03 14:03:49 -0700 (Fri, 03 Jun 2022)
Log Message
HSTS synthesized redirect responses should not be blocked by CORS
https://bugs.webkit.org/show_bug.cgi?id=241003
Reviewed by Youenn Fablet.
If a cross-origin request is made to an http URL that would be upgraded to an https URL
because of HSTS, we synthesize a "response" to call willPerformHTTPRedirection with.
Unfortunately, this response can fail CORS checks causing the request to be unnecessarily blocked.
To prevent this, just add CORS headers to the synthesized responses for HSTS.
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/251284@main
Modified Paths
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm
Diff
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (295229 => 295230)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-06-03 21:03:40 UTC (rev 295229)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-06-03 21:03:49 UTC (rev 295230)
@@ -636,7 +636,10 @@
ASSERT_NOT_REACHED();
#endif
-networkDataTask->willPerformHTTPRedirection(WebCore::synthesizeRedirectResponseIfNecessary([task currentRequest], request, nil), request, [completionHandler = makeBlockPtr(completionHandler), taskIdentifier, shouldIgnoreHSTS](auto&& request) {
+WebCore::ResourceResponse synthesizedResponse = WebCore::synthesizeRedirectResponseIfNecessary([task currentRequest], request, nil);
+NSString *origin = [request valueForHTTPHeaderField:@"Origin"] ?: @"*";
+synthesizedResponse.setHTTPHeaderField(WebCore::HTTPHeaderName::AccessControlAllowOrigin, origin);
+networkDataTask->willPerformHTTPRedirection(WTFMove(synthesizedResponse), request, [completionHandler = makeBlockPtr(completionHandler), taskIdentifier, shouldIgnoreHSTS](auto&& request) {
#if !LOG_DISABLED
LOG(NetworkSession, "%llu _schemeUpgraded completionHandler (%s)", taskIdentifier, request.url().string().utf8().data());
#else
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm (295229 => 295230)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm 2022-06-03 21:03:40 UTC (rev 295229)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm 2022-06-03 21:03:49 UTC (rev 295230)
@@ -114,10 +114,8 @@
EXPECT_WK_STREQ(webView.get().URL.absoluteString, "https://example.com/");
[webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:@"http://example.org/"]]];
-// FIXME: This should be "http://example.com/ hi" but the response generated in _schemeUpgraded is failing a CORS check.
-// This should be fixed to disable CORS checks for HSTS "redirects"
-EXPECT_WK_STREQ([webView _test_waitForAlert], " ");
-EXPECT_EQ(httpServer.totalRequests(), 1u);
+EXPECT_WK_STREQ([webView _test_waitForAlert], "http://example.com/ hi");
+EXPECT_EQ(httpServer.totalRequests(), 2u);
}
TEST(HSTS, CrossOriginRedirect)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295228] trunk/LayoutTests/platform/mac-wk2/TestExpectations
Title: [295228] trunk/LayoutTests/platform/mac-wk2/TestExpectations Revision 295228 Author rack...@apple.com Date 2022-06-03 14:00:51 -0700 (Fri, 03 Jun 2022) Log Message [Gardening]: [ macOS Debug wk2 EWS ] fast/animation/request-animation-frame-throttling-detached-iframe.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=241283 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/251283@main Modified Paths trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (295227 => 295228) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-06-03 20:52:52 UTC (rev 295227) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-06-03 21:00:51 UTC (rev 295228) @@ -1430,7 +1430,6 @@ [ Monterey arm64 ] platform/mac/fast/overflow/overflow-scrollbar-hit-test.html [ Failure Crash ] # rdar://80333935 (REGRESSION: [ Monterey wk2 arm64 ] fast/animation/request-animation-frame-throttling-detached-iframe.html and request-animation-frame-throttling-lowPowerMode.html failing) -[ Monterey arm64 ] fast/animation/request-animation-frame-throttling-detached-iframe.html [ Failure ] [ Monterey arm64 ] fast/animation/request-animation-frame-throttling-lowPowerMode.html [ Failure ] [ Monterey arm64 ] fast/animation/css-animation-throttling-lowPowerMode.html [ Failure ] @@ -1719,4 +1718,6 @@ webkit.org/b/241191 [ Monterey Debug ] webgl/1.0.3/conformance/attribs/gl-vertexattribpointer-offsets.html [ Pass Timeout ] -webkit.org/b/241265 [ Debug ] imported/w3c/web-platform-tests/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-object-percentage.html [ Pass Crash ] \ No newline at end of file +webkit.org/b/241265 [ Debug ] imported/w3c/web-platform-tests/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-object-percentage.html [ Pass Crash ] + +webkit.org/b/241283 fast/animation/request-animation-frame-throttling-detached-iframe.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295227] trunk
Title: [295227] trunk Revision 295227 Author s...@apple.com Date 2022-06-03 13:52:52 -0700 (Fri, 03 Jun 2022) Log Message [GPU Process] [Filters] Make PixelBuffer an abstract class https://bugs.webkit.org/show_bug.cgi?id=240809 Reviewed by Simon Fraser. Hide the current underlying memory of PixelBuffer which is 'Uint8ClampedArray' and move it to a new subclass named ByteArrayPixelBuffer. All clients should use the virtual methods 'bytes()' and 'sizeInBytes()' to have access to the pixel bytes. All calls to 'PixelBuffer::tryCreate()' should be replaced with 'ByteArrayPixelBuffer::tryCreate()'. In future patches and when GPUProcess applies software filters, we are going to create new subclass of PixelBuffer for the result FilterImages. This new sub- class will use SharedMemory as its underlying pixel data and it will attribute this SharedMemory to WebProcess. * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpImageBitmap): (WebCore::CloneDeserializer::readImageBitmap): * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getImageData): * Source/WebCore/html/ImageData.cpp: (WebCore::ImageData::create): (WebCore::ImageData::pixelBuffer const): * Source/WebCore/html/ImageData.h: * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::getImageData const): * Source/WebCore/page/PageColorSampler.cpp: (WebCore::sampleColor): * Source/WebCore/platform/graphics/GraphicsContextGL.cpp: (WebCore::GraphicsContextGL::extractPixelBuffer): * Source/WebCore/platform/graphics/ImageBufferAllocator.cpp: (WebCore::ImageBufferAllocator::createPixelBuffer const): * Source/WebCore/platform/graphics/ImageBufferBackend.cpp: (WebCore::ImageBufferBackend::convertToLuminanceMask): (WebCore::ImageBufferBackend::getPixelBuffer const): (WebCore::ImageBufferBackend::putPixelBuffer): * Source/WebCore/platform/graphics/PixelBuffer.cpp: (WebCore::PixelBuffer::supportedPixelFormat): (WebCore::PixelBuffer::PixelBuffer): (WebCore::PixelBuffer::tryCreateForDecoding): Deleted. (WebCore::PixelBuffer::tryCreate): Deleted. (WebCore::PixelBuffer::create): Deleted. (WebCore::PixelBuffer::bytes const): Deleted. (WebCore::PixelBuffer::sizeInBytes const): Deleted. (WebCore::PixelBuffer::createScratchPixelBuffer const): Deleted. (WebCore::operator<<): Deleted. * Source/WebCore/platform/graphics/PixelBuffer.h: (WebCore::PixelBuffer::size const): (WebCore::PixelBuffer::isByteArrayPixelBuffer const): (WebCore::PixelBuffer::data const): Deleted. (WebCore::PixelBuffer::takeData): Deleted. (WebCore::PixelBuffer::encode const): Deleted. (WebCore::PixelBuffer::decode): Deleted. * Source/WebCore/platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::blurShadowBuffer): * Source/WebCore/platform/graphics/ByteArrayPixelBuffer.cpp: Added. (WebCore::ByteArrayPixelBuffer::create): (WebCore::ByteArrayPixelBuffer::tryCreate): (WebCore::ByteArrayPixelBuffer::tryCreateForDecoding): (WebCore::ByteArrayPixelBuffer::ByteArrayPixelBuffer): (WebCore::ByteArrayPixelBuffer::bytes const): (WebCore::ByteArrayPixelBuffer::sizeInBytes const): (WebCore::ByteArrayPixelBuffer::createScratchPixelBuffer const): * Source/WebCore/platform/graphics/ByteArrayPixelBuffer.h: Added. (WebCore::ByteArrayPixelBuffer::data const): (WebCore::ByteArrayPixelBuffer::takeData): (WebCore::ByteArrayPixelBuffer::encode const): (WebCore::ByteArrayPixelBuffer::decode): (isType): * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLANGLE::readPixelsForPaintResults): (WebCore::GraphicsContextGLANGLE::paintRenderingResultsToPixelBuffer): * Source/WebCore/platform/graphics/cg/GraphicsContextGLCG.cpp: (WebCore::GraphicsContextGL::paintToCanvas): * Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.cpp: (WebCore::ImageBufferCGBackend::copyCGImageForEncoding const): * Source/WebCore/platform/graphics/cg/ImageBufferUtilitiesCG.cpp: (WebCore::encode): * Source/WebCore/platform/graphics/cv/VideoFrameCV.mm: (WebCore::VideoFrameCV::createFromPixelBuffer): * Source/WebCore/platform/graphics/filters/FilterImage.cpp: (WebCore::copyImageBytes): * Source/WebCore/rendering/shapes/Shape.cpp: (WebCore::Shape::createRasterShape): * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp: (WebKit::RemoteGraphicsContextGL::paintPixelBufferToImageBuffer): * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::getPixelBufferForImageBuffer): * Source/WebKit/Platform/IPC/PixelBufferReference.h: (IPC::PixelBufferReference::encode const): (IPC::PixelBufferReference::decode): * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h: * Tools/TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp: (TestWebKitAPI::imageBufferPixelIs): Canonical link: https://commits.webkit.org/251282@main Modified Paths
[webkit-changes] [295226] trunk/LayoutTests/platform/win/TestExpectations
Title: [295226] trunk/LayoutTests/platform/win/TestExpectations Revision 295226 Author rack...@apple.com Date 2022-06-03 13:39:35 -0700 (Fri, 03 Jun 2022) Log Message [Gardening]: [ Windows EWS ] webanimations/accelerated-animations-and-motion-path.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=241282 Unreviewed test gardening. * LayoutTests/platform/win/TestExpectations: Canonical link: https://commits.webkit.org/251281@main Modified Paths trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/platform/win/TestExpectations (295225 => 295226) --- trunk/LayoutTests/platform/win/TestExpectations 2022-06-03 20:31:58 UTC (rev 295225) +++ trunk/LayoutTests/platform/win/TestExpectations 2022-06-03 20:39:35 UTC (rev 295226) @@ -5067,3 +5067,5 @@ webkit.org/b/241281 imported/blink/fast/multicol/vertical-lr/float-content-break.html [ ImageOnlyFailure ] webkit.org/b/241281 fast/layers/parent-clipping-overflow-is-overwritten-by-child-clipping.html [ ImageOnlyFailure ] +webkit.org/b/241282 webanimations/accelerated-animations-and-motion-path.html [ Pass Failure ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295225] trunk/LayoutTests/http/tests/inspector/network/copy-as-fetch.html
Title: [295225] trunk/LayoutTests/http/tests/inspector/network/copy-as-fetch.html
Revision 295225
Author drou...@apple.com
Date 2022-06-03 13:31:58 -0700 (Fri, 03 Jun 2022)
Log Message
New test: http/tests/inspector/network/copy-as-fetch.html is a frequent / flaky failure
https://bugs.webkit.org/show_bug.cgi?id=241279
Unreviewed text fix.
* LayoutTests/http/tests/inspector/network/copy-as-fetch.html:
Canonical link: https://commits.webkit.org/251280@main
Modified Paths
trunk/LayoutTests/http/tests/inspector/network/copy-as-fetch.html
Diff
Modified: trunk/LayoutTests/http/tests/inspector/network/copy-as-fetch.html (295224 => 295225)
--- trunk/LayoutTests/http/tests/inspector/network/copy-as-fetch.html 2022-06-03 20:29:45 UTC (rev 295224)
+++ trunk/LayoutTests/http/tests/inspector/network/copy-as-fetch.html 2022-06-03 20:31:58 UTC (rev 295225)
@@ -81,8 +81,13 @@
]);
let resource = resourceWasAddedEvent.data.resource;
+
let fetchCode = resource.generateFetchCode();
+
+// Strip inconsistent headers.
+fetchCode = fetchCode.replace(/\s+"Accept-Language": ".+?",\n/, "\n");
fetchCode = fetchCode.replace(/("User-Agent": )(".+?")(,?\n)/, "$1$3");
+
InspectorTest.log(fetchCode);
},
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295224] trunk/Source/WebInspectorUI/UserInterface
Title: [295224] trunk/Source/WebInspectorUI/UserInterface
Revision 295224
Author drou...@apple.com
Date 2022-06-03 13:29:45 -0700 (Fri, 03 Jun 2022)
Log Message
Web Inspector: Sources: creating a local override when viewing a resource should automatically place the cursor where it was before
https://bugs.webkit.org/show_bug.cgi?id=218301
Reviewed by Patrick Angle.
* Source/WebInspectorUI/UserInterface/Base/Main.js:
(WI.showLocalResourceOverride):
If the overridden `WI.Resource` is also provided, grab the selected text and scroll position from
the `WI.ContentView` created for it (if it exists) and pass it along when showing the `WI.ContentView`
for the given `WI.LocalResourceOverride`.
* Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:
(WI.appendContextMenuItemsForSourceCode):
* Source/WebInspectorUI/UserInterface/Views/FontResourceContentView.js:
(WI.FontResourceContentView.prototype.dropZoneHandleDrop):
* Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js:
(WI.ImageResourceContentView.prototype.dropZoneHandleDrop):
* Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js:
(WI.LocalResourceOverrideTreeElement.prototype.willDismissPopover):
* Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideWarningView.js:
(WI.LocalResourceOverrideWarningView.prototype.initialLayout):
* Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:
(WI.ResourceContentView.prototype.async _createAndShowLocalResourceOverride):
(WI.ResourceContentView.prototype._handleImportLocalResourceOverride):
Pass along the overridden `WI.Resource`.
* Source/WebInspectorUI/UserInterface/Views/TextEditor.js:
(WI.TextEditor.prototype.get scrollOffset): Added.
(WI.TextEditor.prototype.set scrollOffset): Added.
(WI.TextEditor.prototype.revealPosition):
(WI.TextEditor.prototype.revealPosition.revealAndHighlightLine):
(WI.TextEditor.prototype._updateAfterFormatting):
(WI.TextEditor.prototype._revealPendingPositionIfPossible):
Add a way for callers to get/set the scroll position.
Allow callers of `revealPosition` to also `focus` for instant editability.
Drive-by: Rework the structure of the parameters to make it easier to add new one.
* Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:
(WI.ResourceClusterContentView.prototype.restoreFromCookie):
(WI.ResourceClusterContentView.prototype.showResponse):
(WI.ResourceClusterContentView.prototype._resourceLoadingDidFinish):
Teach `restoreFromCookie` how to pull out more things (e.g. `WI.TextRange`, `WI.Point`, etc.).
Drive-by: Remove parameters from `showResponse` as they're not used anywhere.
* Source/WebInspectorUI/UserInterface/Views/ScriptContentView.js:
(WI.ScriptContentView.prototype.revealPosition):
(WI.ScriptContentView.prototype.restoreFromCookie):
* Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js:
(WI.ShaderProgramContentView.prototype.revealPosition):
* Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:
(WI.SourceCodeTextEditor.prototype.dialogWasDismissedWithRepresentedObject):
* Source/WebInspectorUI/UserInterface/Views/TextContentView.js:
(WI.TextContentView.prototype.revealPosition):
* Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js:
(WI.TextResourceContentView.prototype.revealPosition):
Adjust `revealPosition` to simply pass along parameters instead of trying to do things with them.
Canonical link: https://commits.webkit.org/251279@main
Modified Paths
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js
trunk/Source/WebInspectorUI/UserInterface/Views/FontResourceContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideWarningView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ScriptContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
trunk/Source/WebInspectorUI/UserInterface/Views/TextContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js
trunk/Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js
Diff
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (295223 => 295224)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2022-06-03 20:24:46 UTC (rev 295223)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2022-06-03 20:29:45 UTC (rev 295224)
@@ -1458,7 +1458,37 @@
WI.showLocalResourceOverride = function(localResourceOverride, options = {})
{
console.assert(localResourceOverride instanceof WI.LocalResourceOverride);
[webkit-changes] [295223] trunk/Source/WebKit/UIProcess
Title: [295223] trunk/Source/WebKit/UIProcess
Revision 295223
Author wenson_hs...@apple.com
Date 2022-06-03 13:24:46 -0700 (Fri, 03 Jun 2022)
Log Message
Allow the element fullscreen security heuristic to ignore certain touches
https://bugs.webkit.org/show_bug.cgi?id=241068
Reviewed by Eric Carlson.
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _shouldAvoidSecurityHeuristicScoreUpdates]):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _shouldAvoidSecurityHeuristicScoreUpdates]):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController _touchDetected:]):
Canonical link: https://commits.webkit.org/251278@main
Modified Paths
trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h
trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
Diff
Modified: trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h (295222 => 295223)
--- trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h 2022-06-03 20:24:04 UTC (rev 295222)
+++ trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h 2022-06-03 20:24:46 UTC (rev 295223)
@@ -162,6 +162,8 @@
@property (nonatomic, readonly) WKWebViewContentProviderRegistry *_contentProviderRegistry;
@property (nonatomic, readonly) WKSelectionGranularity _selectionGranularity;
+@property (nonatomic, readonly) BOOL _shouldAvoidSecurityHeuristicScoreUpdates;
+
@property (nonatomic, readonly) BOOL _isBackground;
@property (nonatomic, readonly) BOOL _allowsDoubleTapGestures;
@property (nonatomic, readonly) BOOL _haveSetObscuredInsets;
Modified: trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm (295222 => 295223)
--- trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm 2022-06-03 20:24:04 UTC (rev 295222)
+++ trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm 2022-06-03 20:24:46 UTC (rev 295223)
@@ -40,7 +40,7 @@
#import "VideoFullscreenManagerProxy.h"
#import "ViewGestureController.h"
#import "WKBackForwardListItemInternal.h"
-#import "WKContentView.h"
+#import "WKContentViewInteraction.h"
#import "WKPasswordView.h"
#import "WKSafeBrowsingWarning.h"
#import "WKScrollView.h"
@@ -2742,6 +2742,11 @@
[super buildMenuWithBuilder:builder];
}
+- (BOOL)_shouldAvoidSecurityHeuristicScoreUpdates
+{
+return [_contentView _shouldAvoidSecurityHeuristicScoreUpdates];
+}
+
#if HAVE(UIFINDINTERACTION)
- (id)_searchableObject
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h (295222 => 295223)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2022-06-03 20:24:04 UTC (rev 295222)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2022-06-03 20:24:46 UTC (rev 295223)
@@ -753,6 +753,7 @@
@property (nonatomic, readonly) BOOL _shouldAvoidResizingWhenInputViewBoundsChange;
@property (nonatomic, readonly) BOOL _shouldAvoidScrollingWhenFocusedContentIsVisible;
@property (nonatomic, readonly) BOOL _shouldUseLegacySelectPopoverDismissalBehavior;
+@property (nonatomic, readonly) BOOL _shouldAvoidSecurityHeuristicScoreUpdates;
- (void)_didChangeLinkPreviewAvailability;
- (void)setContinuousSpellCheckingEnabled:(BOOL)enabled;
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (295222 => 295223)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2022-06-03 20:24:04 UTC (rev 295222)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2022-06-03 20:24:46 UTC (rev 295223)
@@ -11068,6 +11068,11 @@
{
}
+- (BOOL)_shouldAvoidSecurityHeuristicScoreUpdates
+{
+return NO;
+}
+
#endif
@end
Modified: trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm (295222 => 295223)
--- trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2022-06-03 20:24:04 UTC (rev 295222)
+++ trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2022-06-03 20:24:46 UTC (rev 295223)
@@ -33,7 +33,7 @@
#import "UIKitSPI.h"
#import "VideoFullscreenManagerProxy.h"
#import "WKFullscreenStackView.h"
-#import "WKWebViewInternal.h"
+#import "WKWebViewIOS.h"
#import "WebFullScreenManagerProxy.h"
#import "WebPageProxy.h"
#import
@@ -491,7 +491,7 @@
- (void)_touchDetected:(id)sender
{
ASSERT(_valid);
-if ([_touchGestureRecognizer state] == UIGestureRecognizerStateEnded) {
+if ([_touchGestureRecognizer state] == UIGestureRecognizerStateEnded && !self._webView._shouldAvoidSecurityHeuristicScoreUpdates) {
double score = _secheuristic.scoreOfNextTouch([_touchGestureRecognizer locationInView:self.view]);
if (score > _secheuristic.requiredScore())
[self _showPhishingAlert];
[webkit-changes] [295222] branches/safari-613-branch/Source/WebCore/Modules/cache/ WorkerCacheStorageConnection.cpp
Title: [295222] branches/safari-613-branch/Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp
Revision 295222
Author alanc...@apple.com
Date 2022-06-03 13:24:04 -0700 (Fri, 03 Jun 2022)
Log Message
Unreviewed build fix. rdar://problem/92853663
FAILURE ./Modules/cache/WorkerCacheStorageConnection.cpp:125:107: error: non-virtual member function marked 'final' hides virtual member function
FAILURE ./Modules/cache/WorkerCacheStorageConnection.cpp:119:72: error: allocating an object of abstract class type 'WebCore::StoppedCacheStorageConnection'
Modified Paths
branches/safari-613-branch/Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp
Diff
Modified: branches/safari-613-branch/Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp (295221 => 295222)
--- branches/safari-613-branch/Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp 2022-06-03 20:24:02 UTC (rev 295221)
+++ branches/safari-613-branch/Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp 2022-06-03 20:24:04 UTC (rev 295222)
@@ -122,7 +122,7 @@
void open(const ClientOrigin&, const String&, DOMCacheEngine::CacheIdentifierCallback&& callback) final { callback(makeUnexpected(DOMCacheEngine::Error::Stopped)); }
void remove(uint64_t, DOMCacheEngine::CacheIdentifierCallback&& callback) final { callback(makeUnexpected(DOMCacheEngine::Error::Stopped)); }
void retrieveCaches(const ClientOrigin&, uint64_t, DOMCacheEngine::CacheInfosCallback&& callback) final { callback(makeUnexpected(DOMCacheEngine::Error::Stopped)); }
-void retrieveRecords(uint64_t, RetrieveRecordsOptions&&, DOMCacheEngine::RecordsCallback&& callback) final { callback(makeUnexpected(DOMCacheEngine::Error::Stopped)); }
+void retrieveRecords(uint64_t, const RetrieveRecordsOptions&, DOMCacheEngine::RecordsCallback&& callback) final { callback(makeUnexpected(DOMCacheEngine::Error::Stopped)); }
void batchDeleteOperation(uint64_t, const ResourceRequest&, CacheQueryOptions&&, DOMCacheEngine::RecordIdentifiersCallback&& callback) final { callback(makeUnexpected(DOMCacheEngine::Error::Stopped)); }
void batchPutOperation(uint64_t, Vector&&, DOMCacheEngine::RecordIdentifiersCallback&& callback) final { callback(makeUnexpected(DOMCacheEngine::Error::Stopped)); }
void reference(uint64_t) final { }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295221] branches/safari-613-branch/Source/WebCore/animation/ KeyframeEffect.cpp
Title: [295221] branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp
Revision 295221
Author alanc...@apple.com
Date 2022-06-03 13:24:02 -0700 (Fri, 03 Jun 2022)
Log Message
Revert 41769648c46b. rdar://problem/93513759
This reverts commit dc0c4463e249c835881c42cc7446662a85914ae1.
Modified Paths
branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp
Diff
Modified: branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp (295220 => 295221)
--- branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp 2022-06-03 20:19:15 UTC (rev 295220)
+++ branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp 2022-06-03 20:24:02 UTC (rev 295221)
@@ -814,8 +814,6 @@
ExceptionOr KeyframeEffect::processKeyframes(JSGlobalObject& lexicalGlobalObject, Strong&& keyframesInput)
{
-Ref protectedDocument { document };
-
// 1. If object is null, return an empty sequence of keyframes.
if (!keyframesInput.get())
return { };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295220] trunk/LayoutTests/platform/win/TestExpectations
Title: [295220] trunk/LayoutTests/platform/win/TestExpectations Revision 295220 Author rack...@apple.com Date 2022-06-03 13:19:15 -0700 (Fri, 03 Jun 2022) Log Message [Gardening]: [ Windows ] two tests imported/blink and fast/layers are a consistent failure https://bugs.webkit.org/show_bug.cgi?id=241281 Unreviewed test gardening. * LayoutTests/platform/win/TestExpectations: Canonical link: https://commits.webkit.org/251277@main Modified Paths trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/platform/win/TestExpectations (295219 => 295220) --- trunk/LayoutTests/platform/win/TestExpectations 2022-06-03 19:59:27 UTC (rev 295219) +++ trunk/LayoutTests/platform/win/TestExpectations 2022-06-03 20:19:15 UTC (rev 295220) @@ -5063,3 +5063,7 @@ fast/css3-text/css3-text-decoration/text-decoration-thickness-repaint.html [ ImageOnlyFailure ] webkit.org/b/241268 webanimations/accelerated-transform-animation-from-scale-zero-and-implicit-to-kefyrame.html [ Pass ImageOnlyFailure ] + +webkit.org/b/241281 imported/blink/fast/multicol/vertical-lr/float-content-break.html [ ImageOnlyFailure ] +webkit.org/b/241281 fast/layers/parent-clipping-overflow-is-overwritten-by-child-clipping.html [ ImageOnlyFailure ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295219] trunk
Title: [295219] trunk Revision 295219 Author achristen...@apple.com Date 2022-06-03 12:59:27 -0700 (Fri, 03 Jun 2022) Log Message Implement CSSNumericValue.to https://bugs.webkit.org/show_bug.cgi?id=241167 Reviewed by Chris Dumez. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssRotate.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssMathValue.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/to.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/toSum.tentative-expected.txt: * Source/WebCore/css/CSSUnits.cpp: (WebCore::canonicalUnitType): Deleted. * Source/WebCore/css/CSSUnits.h: * Source/WebCore/css/typedom/CSSNumericValue.cpp: (WebCore::operationOnValuesOfSameUnit): (WebCore::CSSNumericValue::multiplyInternal): (WebCore::CSSNumericValue::min): (WebCore::CSSNumericValue::max): (WebCore::CSSNumericValue::to): * Source/WebCore/css/typedom/CSSNumericValue.h: * Source/WebCore/css/typedom/CSSUnitValue.cpp: (WebCore::CSSUnitValue::parseUnit): (WebCore::CSSUnitValue::create): (WebCore::CSSUnitValue::CSSUnitValue): (WebCore::conversionToCanonicalUnitsScaleFactor): (WebCore::CSSUnitValue::convertTo const): (WebCore::CSSUnitValue::toSumValue const): (WebCore::numericType): Deleted. (WebCore::parseUnit): Deleted. * Source/WebCore/css/typedom/CSSUnitValue.h: * Source/WebCore/css/typedom/numeric/CSSMathInvert.cpp: (WebCore::CSSMathInvert::toSumValue const): * Source/WebCore/css/typedom/numeric/CSSMathInvert.h: * Source/WebCore/css/typedom/numeric/CSSMathMax.cpp: (WebCore::CSSMathMax::create): (WebCore::CSSMathMax::CSSMathMax): (WebCore::CSSMathMax::toSumValue const): * Source/WebCore/css/typedom/numeric/CSSMathMax.h: * Source/WebCore/css/typedom/numeric/CSSMathMin.cpp: (WebCore::CSSMathMin::create): (WebCore::CSSMathMin::CSSMathMin): (WebCore::CSSMathMin::toSumValue const): * Source/WebCore/css/typedom/numeric/CSSMathMin.h: * Source/WebCore/css/typedom/numeric/CSSMathNegate.cpp: (WebCore::CSSMathNegate::toSumValue const): * Source/WebCore/css/typedom/numeric/CSSMathNegate.h: * Source/WebCore/css/typedom/numeric/CSSMathProduct.cpp: (WebCore::CSSMathProduct::toSumValue const): * Source/WebCore/css/typedom/numeric/CSSMathProduct.h: * Source/WebCore/css/typedom/numeric/CSSMathSum.cpp: (WebCore::CSSMathSum::toSumValue const): * Source/WebCore/css/typedom/numeric/CSSMathSum.h: * Source/WebCore/css/typedom/numeric/CSSNumericArray.cpp: (WebCore::CSSNumericArray::forEach): * Source/WebCore/css/typedom/numeric/CSSNumericType.cpp: (WebCore::CSSNumericType::create): (WebCore::typeFromVector): * Source/WebCore/css/typedom/numeric/CSSNumericType.h: (WebCore::CSSNumericType::operator!= const): * Source/WebCore/css/typedom/transform/CSSTransformValue.cpp: (WebCore::CSSTransformValue::serialize const): Canonical link: https://commits.webkit.org/251276@main Modified Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssRotate.tentative-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssMathValue.tentative-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/to.tentative-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/toSum.tentative-expected.txt trunk/Source/WebCore/css/CSSUnits.cpp trunk/Source/WebCore/css/CSSUnits.h trunk/Source/WebCore/css/typedom/CSSNumericValue.cpp trunk/Source/WebCore/css/typedom/CSSNumericValue.h trunk/Source/WebCore/css/typedom/CSSUnitValue.cpp trunk/Source/WebCore/css/typedom/CSSUnitValue.h trunk/Source/WebCore/css/typedom/numeric/CSSMathInvert.cpp trunk/Source/WebCore/css/typedom/numeric/CSSMathInvert.h trunk/Source/WebCore/css/typedom/numeric/CSSMathMax.cpp trunk/Source/WebCore/css/typedom/numeric/CSSMathMax.h trunk/Source/WebCore/css/typedom/numeric/CSSMathMin.cpp trunk/Source/WebCore/css/typedom/numeric/CSSMathMin.h trunk/Source/WebCore/css/typedom/numeric/CSSMathNegate.cpp trunk/Source/WebCore/css/typedom/numeric/CSSMathNegate.h trunk/Source/WebCore/css/typedom/numeric/CSSMathProduct.cpp trunk/Source/WebCore/css/typedom/numeric/CSSMathProduct.h trunk/Source/WebCore/css/typedom/numeric/CSSMathSum.cpp trunk/Source/WebCore/css/typedom/numeric/CSSMathSum.h trunk/Source/WebCore/css/typedom/numeric/CSSNumericArray.cpp trunk/Source/WebCore/css/typedom/numeric/CSSNumericType.cpp trunk/Source/WebCore/css/typedom/numeric/CSSNumericType.h trunk/Source/WebCore/css/typedom/transform/CSSTransformValue.cpp Diff Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssRotate.tentative-expected.txt (295218 => 295219) ---
[webkit-changes] [295218] trunk/Source/WebCore/html/canvas
Title: [295218] trunk/Source/WebCore/html/canvas
Revision 295218
Author commit-qu...@webkit.org
Date 2022-06-03 12:57:21 -0700 (Fri, 03 Jun 2022)
Log Message
WebGL extensions enable code cleanup
https://bugs.webkit.org/show_bug.cgi?id=241264
Patch by Alexey Knyazev <3479527+lexaknya...@users.noreply.github.com> on 2022-06-03
Reviewed by Kenneth Russell.
* Use extension ctors to enable them in ANGLE. It is safe to
call ensureExtensionEnabled even when ANGLE is not used
* Do not request ARB-prefixed extensions from ANGLE
* Fixed duplicated extension enable requests for
* ANGLE_instanced_arrays
* OES_fbo_render_mipmap
* WEBGL_draw_buffers
* Directly check for enabled extensions in
WebGL2RenderingContext::renderbufferStorageImpl and
WebGLRenderingContextBase::addExtensionSupportedFormatsAndTypes
instead of scanning through the list of strings
* Source/WebCore/html/canvas/ANGLEInstancedArrays.cpp:
(WebCore::ANGLEInstancedArrays::ANGLEInstancedArrays):
* Source/WebCore/html/canvas/EXTBlendMinMax.cpp:
(WebCore::EXTBlendMinMax::EXTBlendMinMax):
* Source/WebCore/html/canvas/EXTFragDepth.cpp:
(WebCore::EXTFragDepth::EXTFragDepth):
* Source/WebCore/html/canvas/EXTShaderTextureLOD.cpp:
(WebCore::EXTShaderTextureLOD::EXTShaderTextureLOD):
* Source/WebCore/html/canvas/EXTTextureCompressionBPTC.cpp:
(WebCore::EXTTextureCompressionBPTC::EXTTextureCompressionBPTC):
* Source/WebCore/html/canvas/EXTTextureCompressionRGTC.cpp:
(WebCore::EXTTextureCompressionRGTC::EXTTextureCompressionRGTC):
* Source/WebCore/html/canvas/EXTTextureFilterAnisotropic.cpp:
(WebCore::EXTTextureFilterAnisotropic::EXTTextureFilterAnisotropic):
* Source/WebCore/html/canvas/EXTTextureNorm16.cpp:
(WebCore::EXTTextureNorm16::EXTTextureNorm16):
* Source/WebCore/html/canvas/EXTsRGB.cpp:
(WebCore::EXTsRGB::EXTsRGB):
* Source/WebCore/html/canvas/OESElementIndexUint.cpp:
(WebCore::OESElementIndexUint::OESElementIndexUint):
* Source/WebCore/html/canvas/OESStandardDerivatives.cpp:
(WebCore::OESStandardDerivatives::OESStandardDerivatives):
* Source/WebCore/html/canvas/OESTextureFloatLinear.cpp:
(WebCore::OESTextureFloatLinear::OESTextureFloatLinear):
* Source/WebCore/html/canvas/OESTextureHalfFloatLinear.cpp:
(WebCore::OESTextureHalfFloatLinear::OESTextureHalfFloatLinear):
* Source/WebCore/html/canvas/OESVertexArrayObject.cpp:
(WebCore::OESVertexArrayObject::OESVertexArrayObject):
* Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::renderbufferStorageImpl):
* Source/WebCore/html/canvas/WebGLDepthTexture.cpp:
(WebCore::WebGLDepthTexture::WebGLDepthTexture):
* Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::addExtensionSupportedFormatsAndTypes):
Canonical link: https://commits.webkit.org/251275@main
Modified Paths
trunk/Source/WebCore/html/canvas/ANGLEInstancedArrays.cpp
trunk/Source/WebCore/html/canvas/EXTBlendMinMax.cpp
trunk/Source/WebCore/html/canvas/EXTFragDepth.cpp
trunk/Source/WebCore/html/canvas/EXTShaderTextureLOD.cpp
trunk/Source/WebCore/html/canvas/EXTTextureCompressionBPTC.cpp
trunk/Source/WebCore/html/canvas/EXTTextureCompressionRGTC.cpp
trunk/Source/WebCore/html/canvas/EXTTextureFilterAnisotropic.cpp
trunk/Source/WebCore/html/canvas/EXTTextureNorm16.cpp
trunk/Source/WebCore/html/canvas/EXTsRGB.cpp
trunk/Source/WebCore/html/canvas/OESElementIndexUint.cpp
trunk/Source/WebCore/html/canvas/OESStandardDerivatives.cpp
trunk/Source/WebCore/html/canvas/OESTextureFloatLinear.cpp
trunk/Source/WebCore/html/canvas/OESTextureHalfFloatLinear.cpp
trunk/Source/WebCore/html/canvas/OESVertexArrayObject.cpp
trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
trunk/Source/WebCore/html/canvas/WebGLDepthTexture.cpp
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
Diff
Modified: trunk/Source/WebCore/html/canvas/ANGLEInstancedArrays.cpp (295217 => 295218)
--- trunk/Source/WebCore/html/canvas/ANGLEInstancedArrays.cpp 2022-06-03 19:30:11 UTC (rev 295217)
+++ trunk/Source/WebCore/html/canvas/ANGLEInstancedArrays.cpp 2022-06-03 19:57:21 UTC (rev 295218)
@@ -37,9 +37,7 @@
ANGLEInstancedArrays::ANGLEInstancedArrays(WebGLRenderingContextBase& context)
: WebGLExtension(context)
{
-#if USE(ANGLE)
context.graphicsContextGL()->ensureExtensionEnabled("GL_ANGLE_instanced_arrays"_s);
-#endif
}
ANGLEInstancedArrays::~ANGLEInstancedArrays() = default;
Modified: trunk/Source/WebCore/html/canvas/EXTBlendMinMax.cpp (295217 => 295218)
--- trunk/Source/WebCore/html/canvas/EXTBlendMinMax.cpp 2022-06-03 19:30:11 UTC (rev 295217)
+++ trunk/Source/WebCore/html/canvas/EXTBlendMinMax.cpp 2022-06-03 19:57:21 UTC (rev 295218)
@@ -37,6 +37,7 @@
EXTBlendMinMax::EXTBlendMinMax(WebGLRenderingContextBase& context)
: WebGLExtension(context)
[webkit-changes] [295217] trunk/LayoutTests
Title: [295217] trunk/LayoutTests Revision 295217 Author wenson_hs...@apple.com Date 2022-06-03 12:30:11 -0700 (Fri, 03 Jun 2022) Log Message [iOS] editing/selection/ios/do-not-hide-selection-in-visible-container.html fails on iPhone 12 simulator https://bugs.webkit.org/show_bug.cgi?id=241270 rdar://86025461 Reviewed by Tim Horton. This test currently fails when run on iPhone 12 simulator. Due to the slightly wider screen size, the row of buttons at the top of the page no longer wraps to the next line, which in turn causes the output text to have one less space character when compared to the output on iPhone SE. To fix this, make the test robust against this difference by removing each button before the end of the test. This also causes the text ouput on iPad to now match the expected output on iPhone, so we no longer require test expectations that are specific to iPad vs. iPhone. * LayoutTests/editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt: * LayoutTests/editing/selection/ios/do-not-hide-selection-in-visible-container.html: * LayoutTests/platform/ipad/editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt: Removed. Canonical link: https://commits.webkit.org/251274@main Modified Paths trunk/LayoutTests/editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt trunk/LayoutTests/editing/selection/ios/do-not-hide-selection-in-visible-container.html Removed Paths trunk/LayoutTests/platform/ipad/editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt Diff Modified: trunk/LayoutTests/editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt (295216 => 295217) --- trunk/LayoutTests/editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt 2022-06-03 17:11:25 UTC (rev 295216) +++ trunk/LayoutTests/editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt 2022-06-03 19:30:11 UTC (rev 295217) @@ -1,5 +1,5 @@ -First field Second field Third field Fourth field + Verifies that native selection UI is not suppressed when focusing an input that is inside an empty container with `overflow: hidden`, but is positioned absolutely such that it is still visible. To manually verify, click on each of the four buttons to move focus into editable areas. After tapping the first and third buttons, you should not see a caret view; after tapping the second and fourth buttons, you should see a caret view. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". Modified: trunk/LayoutTests/editing/selection/ios/do-not-hide-selection-in-visible-container.html (295216 => 295217) --- trunk/LayoutTests/editing/selection/ios/do-not-hide-selection-in-visible-container.html 2022-06-03 17:11:25 UTC (rev 295216) +++ trunk/LayoutTests/editing/selection/ios/do-not-hide-selection-in-visible-container.html 2022-06-03 19:30:11 UTC (rev 295217) @@ -60,6 +60,7 @@ await UIHelper.activateElementAndWaitForInputSession(buttonToTap); await ensureCaretIsVisible(expectedVisibility); document.activeElement.blur(); +buttonToTap.remove(); } await UIHelper.waitForKeyboardToHide(); Deleted: trunk/LayoutTests/platform/ipad/editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt (295216 => 295217) --- trunk/LayoutTests/platform/ipad/editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt 2022-06-03 17:11:25 UTC (rev 295216) +++ trunk/LayoutTests/platform/ipad/editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt 2022-06-03 19:30:11 UTC (rev 295217) @@ -1,18 +0,0 @@ -First field Second field Third field Fourth field - -Verifies that native selection UI is not suppressed when focusing an input that is inside an empty container with `overflow: hidden`, but is positioned absolutely such that it is still visible. To manually verify, click on each of the four buttons to move focus into editable areas. After tapping the first and third buttons, you should not see a caret view; after tapping the second and fourth buttons, you should see a caret view. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - -Waiting for caret to hide. -PASS Caret was hidden. -Waiting for caret to show. -PASS Caret was shown. -Waiting for caret to hide. -PASS Caret was hidden. -Waiting for caret to show. -PASS Caret was shown. -PASS successfullyParsed is true - -TEST COMPLETE - ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295216] trunk/Source/WebCore
Title: [295216] trunk/Source/WebCore
Revision 295216
Author commit-qu...@webkit.org
Date 2022-06-03 10:11:25 -0700 (Fri, 03 Jun 2022)
Log Message
[GTK] Fix a couple clang warnings related with DESTINATION_COLOR_SPACE_LINEAR_SRGB and atspi
https://bugs.webkit.org/show_bug.cgi?id=241269
Patch by Philippe Normand on 2022-06-03
Reviewed by Michael Catanzaro.
* Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:
(WebCore::AXObjectCache::postPlatformNotification): Add switch case for AXHasPopupChanged, stubbed for now.
* Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp:
(WebCore::ImageBufferCairoBackend::transformToColorSpace): makr newColorSpace as unused when
DESTINATION_COLOR_SPACE_LINEAR_SRGB is disabled.
* Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource): Move svgStyle declaration to
DESTINATION_COLOR_SPACE_LINEAR_SRGB code path.
Canonical link: https://commits.webkit.org/251273@main
Modified Paths
trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp
trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp
Diff
Modified: trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp (295215 => 295216)
--- trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp 2022-06-03 16:30:27 UTC (rev 295215)
+++ trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp 2022-06-03 17:11:25 UTC (rev 295216)
@@ -201,6 +201,8 @@
break;
case AXDescribedByChanged:
break;
+case AXHasPopupChanged:
+break;
}
}
Modified: trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp (295215 => 295216)
--- trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp 2022-06-03 16:30:27 UTC (rev 295215)
+++ trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp 2022-06-03 17:11:25 UTC (rev 295216)
@@ -96,6 +96,7 @@
#else
ASSERT(newColorSpace == DestinationColorSpace::SRGB());
ASSERT(m_parameters.colorSpace == DestinationColorSpace::SRGB());
+UNUSED_PARAM(newColorSpace);
#endif
}
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp (295215 => 295216)
--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp 2022-06-03 16:30:27 UTC (rev 295215)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp 2022-06-03 17:11:25 UTC (rev 295216)
@@ -76,12 +76,11 @@
ImageBuffer::sizeNeedsClamping(repaintRect.size(), scale);
if (!maskerData->maskImage && !repaintRect.isEmpty()) {
-const SVGRenderStyle& svgStyle = style().svgStyle();
-
auto maskColorSpace = DestinationColorSpace::SRGB();
auto drawColorSpace = DestinationColorSpace::SRGB();
#if ENABLE(DESTINATION_COLOR_SPACE_LINEAR_SRGB)
+const SVGRenderStyle& svgStyle = style().svgStyle();
if (svgStyle.colorInterpolation() == ColorInterpolation::LinearRGB) {
#if USE(CG)
maskColorSpace = DestinationColorSpace::LinearSRGB();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295215] trunk/Source/WebCore
Title: [295215] trunk/Source/WebCore Revision 295215 Author commit-qu...@webkit.org Date 2022-06-03 09:30:27 -0700 (Fri, 03 Jun 2022) Log Message Remove last remnants of old Media Controls related sliders https://bugs.webkit.org/show_bug.cgi?id=241226 Patch by Philippe Normand on 2022-06-03 Reviewed by Tim Nguyen. The `media-*-slider-*part` theme parts are no longer used, so should be removed. * Source/WebCore/WebCore.order: * Source/WebCore/accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation const): * Source/WebCore/css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/css/mediaControls.css: (:is(audio, video)::-webkit-media-controls-timeline): * Source/WebCore/css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): * Source/WebCore/html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): * Source/WebCore/html/shadow/ShadowPseudoIds.cpp: (WebCore::ShadowPseudoIds::webkitMediaSliderThumb): Deleted. (WebCore::ShadowPseudoIds::webkitMediaSliderContainer): Deleted. * Source/WebCore/html/shadow/ShadowPseudoIds.h: * Source/WebCore/html/shadow/SliderThumbElement.cpp: (WebCore::hasVerticalAppearance): (WebCore::SliderThumbElement::create): (WebCore::SliderThumbElement::resolveCustomStyle): (WebCore::SliderContainerElement::create): (WebCore::SliderThumbElement::shadowPseudoId const): Deleted. (WebCore::SliderContainerElement::resolveCustomStyle): Deleted. (WebCore::SliderContainerElement::shadowPseudoId const): Deleted. * Source/WebCore/html/shadow/SliderThumbElement.h: (WebCore::SliderThumbElement::create): Deleted. * Source/WebCore/platform/ThemeTypes.cpp: (WebCore::operator<<): * Source/WebCore/platform/ThemeTypes.h: * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::autoAppearanceForElement const): (WebCore::RenderTheme::paint): * Source/WebCore/rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaSliderTrack): Deleted. (WebCore::RenderTheme::paintMediaSliderThumb): Deleted. (WebCore::RenderTheme::paintMediaVolumeSliderTrack): Deleted. (WebCore::RenderTheme::paintMediaVolumeSliderThumb): Deleted. (WebCore::RenderTheme::paintMediaFullScreenVolumeSliderTrack): Deleted. (WebCore::RenderTheme::paintMediaFullScreenVolumeSliderThumb): Deleted. * Source/WebCore/rendering/RenderThemeAdwaita.cpp: (WebCore::parentMediaElement): Deleted. (WebCore::RenderThemeAdwaita::paintMediaSliderTrack): Deleted. (WebCore::RenderThemeAdwaita::paintMediaVolumeSliderTrack): Deleted. * Source/WebCore/rendering/RenderThemeAdwaita.h: * Source/WebCore/rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderTrack): Canonical link: https://commits.webkit.org/251272@main Modified Paths trunk/Source/WebCore/WebCore.order trunk/Source/WebCore/accessibility/AccessibilitySlider.cpp trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h trunk/Source/WebCore/css/CSSValueKeywords.in trunk/Source/WebCore/css/mediaControls.css trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp trunk/Source/WebCore/html/RangeInputType.cpp trunk/Source/WebCore/html/shadow/ShadowPseudoIds.cpp trunk/Source/WebCore/html/shadow/ShadowPseudoIds.h trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp trunk/Source/WebCore/html/shadow/SliderThumbElement.h trunk/Source/WebCore/platform/ThemeTypes.cpp trunk/Source/WebCore/platform/ThemeTypes.h trunk/Source/WebCore/rendering/RenderTheme.cpp trunk/Source/WebCore/rendering/RenderTheme.h trunk/Source/WebCore/rendering/RenderThemeAdwaita.cpp trunk/Source/WebCore/rendering/RenderThemeAdwaita.h trunk/Source/WebCore/rendering/RenderThemeMac.mm Diff Modified: trunk/Source/WebCore/WebCore.order (295214 => 295215) --- trunk/Source/WebCore/WebCore.order 2022-06-03 16:13:00 UTC (rev 295214) +++ trunk/Source/WebCore/WebCore.order 2022-06-03 16:30:27 UTC (rev 295215) @@ -19175,11 +19175,7 @@ __ZNK7WebCore39MediaControlTimeRemainingDisplayElement14shadowPseudoIdEv __ZN7WebCore35RenderMediaControlTimelineContainer6layoutEv __ZN7WebCore36MediaControlTimelineContainerElement21setTimeDisplaysHiddenEb -__ZN7WebCore14RenderThemeMac21paintMediaSliderTrackEPNS_12RenderObjectERKNS_9PaintInfoERKNS_7IntRectE __ZN7WebCoreL38getUnzoomedRectAndAdjustCurrentContextEPNS_12RenderObjectERKNS_9PaintInfoERKNS_7IntRectE -__ZN7WebCore14RenderThemeMac21paintMediaSliderThumbEPNS_12RenderObjectERKNS_9PaintInfoERKNS_7IntRectE -__ZN7WebCore14RenderThemeMac26paintMediaFullscreenButtonEPNS_12RenderObjectERKNS_9PaintInfoERKNS_7IntRectE -__ZN7WebCore14RenderThemeMac20paintMediaMuteButtonEPNS_12RenderObjectERKNS_9PaintInfoERKNS_7IntRectE __ZN7WebCore13MediaControls37refreshClosedCaptionsButtonVisibilityEv __ZN7WebCore13MediaControls19bufferingProgressedEv __ZThn144_NK7WebCore16HTMLMediaElement6pausedEv Modified: trunk/Source/WebCore/accessibility/AccessibilitySlider.cpp (295214 => 295215) ---
[webkit-changes] [295214] trunk/Source
Title: [295214] trunk/Source
Revision 295214
Author cdu...@apple.com
Date 2022-06-03 09:13:00 -0700 (Fri, 03 Jun 2022)
Log Message
Drop unnecessary operator==() overloads for String
https://bugs.webkit.org/show_bug.cgi?id=241235
Reviewed by Alex Christensen.
* Source/WTF/wtf/text/WTFString.h:
(WTF::operator==):
(WTF::operator!=):
Canonical link: https://commits.webkit.org/251271@main
Modified Paths
trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/runtime/IntlCollator.cpp
trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp
trunk/Source/_javascript_Core/runtime/IntlLocale.cpp
trunk/Source/_javascript_Core/runtime/IntlObject.cpp
trunk/Source/_javascript_Core/runtime/IntlObject.h
trunk/Source/_javascript_Core/runtime/TemporalObject.cpp
trunk/Source/WTF/wtf/text/WTFString.h
Diff
Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp (295213 => 295214)
--- trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp 2022-06-03 15:55:01 UTC (rev 295213)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp 2022-06-03 16:13:00 UTC (rev 295214)
@@ -939,15 +939,15 @@
RefPtr allExceptionsBreakpoint;
RefPtr uncaughtExceptionsBreakpoint;
-if (stateString == "all") {
+if (stateString == "all"_s) {
allExceptionsBreakpoint = debuggerBreakpointFromPayload(errorString, WTFMove(options));
if (!allExceptionsBreakpoint)
return makeUnexpected(errorString);
-} else if (stateString == "uncaught") {
+} else if (stateString == "uncaught"_s) {
uncaughtExceptionsBreakpoint = debuggerBreakpointFromPayload(errorString, WTFMove(options));
if (!uncaughtExceptionsBreakpoint)
return makeUnexpected(errorString);
-} else if (stateString != "none")
+} else if (stateString != "none"_s)
return makeUnexpected(makeString("Unknown state: "_s, stateString));
m_debugger.setPauseOnAllExceptionsBreakpoint(WTFMove(allExceptionsBreakpoint));
Modified: trunk/Source/_javascript_Core/jsc.cpp (295213 => 295214)
--- trunk/Source/_javascript_Core/jsc.cpp 2022-06-03 15:55:01 UTC (rev 295213)
+++ trunk/Source/_javascript_Core/jsc.cpp 2022-06-03 16:13:00 UTC (rev 295214)
@@ -1668,7 +1668,7 @@
if (callFrame->argumentCount() > 1) {
String type = callFrame->argument(1).toWTFString(globalObject);
RETURN_IF_EXCEPTION(scope, encodedJSValue());
-if (type != "binary")
+if (type != "binary"_s)
return throwVMError(globalObject, scope, "Expected 'binary' as second argument."_s);
isBinary = true;
}
Modified: trunk/Source/_javascript_Core/runtime/IntlCollator.cpp (295213 => 295214)
--- trunk/Source/_javascript_Core/runtime/IntlCollator.cpp 2022-06-03 15:55:01 UTC (rev 295213)
+++ trunk/Source/_javascript_Core/runtime/IntlCollator.cpp 2022-06-03 16:13:00 UTC (rev 295214)
@@ -188,7 +188,7 @@
if (numeric != TriState::Indeterminate)
localeOptions[static_cast(RelevantExtensionKey::Kn)] = String(numeric == TriState::True ? "true"_s : "false"_s);
-String caseFirstOption = intlStringOption(globalObject, options, vm.propertyNames->caseFirst, { "upper", "lower", "false" }, "caseFirst must be either \"upper\", \"lower\", or \"false\""_s, { });
+String caseFirstOption = intlStringOption(globalObject, options, vm.propertyNames->caseFirst, { "upper"_s, "lower"_s, "false"_s }, "caseFirst must be either \"upper\", \"lower\", or \"false\""_s, { });
RETURN_IF_EXCEPTION(scope, void());
if (!caseFirstOption.isNull())
localeOptions[static_cast(RelevantExtensionKey::Kf)] = caseFirstOption;
Modified: trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp (295213 => 295214)
--- trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp 2022-06-03 15:55:01 UTC (rev 295213)
+++ trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp 2022-06-03 16:13:00 UTC (rev 295214)
@@ -881,7 +881,7 @@
break;
}
-intlStringOption(globalObject, options, vm.propertyNames->formatMatcher, { "basic", "best fit" }, "formatMatcher must be either \"basic\" or \"best fit\""_s, "best fit"_s);
+intlStringOption(globalObject, options, vm.propertyNames->formatMatcher, { "basic"_s, "best fit"_s }, "formatMatcher must be either \"basic\" or \"best fit\""_s, "best fit"_s);
RETURN_IF_EXCEPTION(scope, void());
m_dateStyle = intlOption(globalObject, options, vm.propertyNames->dateStyle, { { "full"_s, DateTimeStyle::Full }, { "long"_s, DateTimeStyle::Long }, { "medium"_s, DateTimeStyle::Medium }, { "short"_s, DateTimeStyle::Short } }, "dateStyle must be \"full\", \"long\", \"medium\", or \"short\""_s, DateTimeStyle::None);
Modified: trunk/Source/_javascript_Core/runtime/IntlLocale.cpp (295213 => 295214)
--- trunk/Source/_javascript_Core/runtime/IntlLocale.cpp 2022-06-03
[webkit-changes] [295213] trunk/Source
Title: [295213] trunk/Source
Revision 295213
Author pvol...@apple.com
Date 2022-06-03 08:55:01 -0700 (Fri, 03 Jun 2022)
Log Message
Call function to restrict image decoders for all clients
https://bugs.webkit.org/show_bug.cgi?id=240958
Reviewed by Geoffrey Garen.
Call function to enable HEIC decoding for all clients on iOS. The main motivation behind this patch
is to avoid using IOKit when decoding HEIC or JPEGs with aux HEIC. Calling enableDecodingHEIC() will
make sure IOKit is not being used, as well as enabling HEIC decoding. We previously only did this for
Mail, but decoding of HEIC images should be possible for all clients. We are not enabling this for
all clients on macOS, since macOS is not blocking IOKit in the WebContent process. This patch also
renames the function, since the former name was not accurate.
* Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:
(WebCore::createImageSourceOptions):
(WebCore::ImageDecoderCG::enableDecodeHEIC):
(WebCore::ImageDecoderCG::decodeHEICEnabled):
(WebCore::ImageDecoderCG::enableRestrictedDecoding): Deleted.
(WebCore::ImageDecoderCG::restrictedDecodingEnabled): Deleted.
* Source/WebCore/platform/graphics/cg/ImageDecoderCG.h:
* Source/WebKit/Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Source/WebKit/Shared/WebProcessCreationParameters.h:
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Canonical link: https://commits.webkit.org/251270@main
Modified Paths
trunk/Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp
trunk/Source/WebCore/platform/graphics/cg/ImageDecoderCG.h
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
Diff
Modified: trunk/Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp (295212 => 295213)
--- trunk/Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp 2022-06-03 15:47:55 UTC (rev 295212)
+++ trunk/Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp 2022-06-03 15:55:01 UTC (rev 295213)
@@ -76,7 +76,7 @@
CFDictionarySetValue(options.get(), kCGImageSourceUseHardwareAcceleration, kCFBooleanFalse);
#if HAVE(IMAGE_RESTRICTED_DECODING) && USE(APPLE_INTERNAL_SDK)
-if (ImageDecoderCG::restrictedDecodingEnabled())
+if (ImageDecoderCG::decodingHEICEnabled())
CFDictionarySetValue(options.get(), kCGImageSourceEnableRestrictedDecoding, kCFBooleanTrue);
#endif
@@ -268,7 +268,7 @@
}
#endif
-bool ImageDecoderCG::s_enableRestrictedDecoding = false;
+bool ImageDecoderCG::s_enableDecodingHEIC = false;
bool ImageDecoderCG::s_hardwareAcceleratedDecodingDisabled = false;
ImageDecoderCG::ImageDecoderCG(FragmentedSharedBuffer& data, AlphaOption, GammaAndColorProfileOption)
@@ -611,14 +611,14 @@
return MIMETypeRegistry::isSupportedImageMIMEType(mimeType);
}
-void ImageDecoderCG::enableRestrictedDecoding()
+void ImageDecoderCG::enableDecodingHEIC()
{
-s_enableRestrictedDecoding = true;
+s_enableDecodingHEIC = true;
}
-bool ImageDecoderCG::restrictedDecodingEnabled()
+bool ImageDecoderCG::decodingHEICEnabled()
{
-return s_enableRestrictedDecoding;
+return s_enableDecodingHEIC;
}
void ImageDecoderCG::disableHardwareAcceleratedDecoding()
Modified: trunk/Source/WebCore/platform/graphics/cg/ImageDecoderCG.h (295212 => 295213)
--- trunk/Source/WebCore/platform/graphics/cg/ImageDecoderCG.h 2022-06-03 15:47:55 UTC (rev 295212)
+++ trunk/Source/WebCore/platform/graphics/cg/ImageDecoderCG.h 2022-06-03 15:55:01 UTC (rev 295213)
@@ -70,8 +70,8 @@
bool isAllDataReceived() const final { return m_isAllDataReceived; }
void clearFrameBufferCache(size_t) final { }
-WEBCORE_EXPORT static void enableRestrictedDecoding();
-static bool restrictedDecodingEnabled();
+WEBCORE_EXPORT static void enableDecodingHEIC();
+static bool decodingHEICEnabled();
WEBCORE_EXPORT static void disableHardwareAcceleratedDecoding();
static bool hardwareAcceleratedDecodingDisabled();
@@ -80,7 +80,7 @@
bool m_isAllDataReceived { false };
mutable EncodedDataStatus m_encodedDataStatus { EncodedDataStatus::Unknown };
RetainPtr m_nativeDecoder;
-static bool s_enableRestrictedDecoding;
+static bool s_enableDecodingHEIC;
static bool s_hardwareAcceleratedDecodingDisabled;
};
Modified: trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp (295212 => 295213)
--- trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp 2022-06-03 15:47:55 UTC (rev 295212)
+++ trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp 2022-06-03 15:55:01 UTC (rev 295213)
@@ -163,7 +163,7 @@
#if
[webkit-changes] [295211] trunk
Title: [295211] trunk
Revision 295211
Author an...@apple.com
Date 2022-06-03 08:29:29 -0700 (Fri, 03 Jun 2022)
Log Message
Disallow styles using container units from matched declarations cache
https://bugs.webkit.org/show_bug.cgi?id=241261
Reviewed by Alan Bujtas.
We may fail to invalidate styles using container units correctly on container size change
because they are getting cached.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-invalidation-expected.txt:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble):
Mark styles that use container units.
* Source/WebCore/css/CSSToLengthConversionData.cpp:
(WebCore::CSSToLengthConversionData::defaultViewportFactor const):
(WebCore::CSSToLengthConversionData::smallViewportFactor const):
(WebCore::CSSToLengthConversionData::largeViewportFactor const):
(WebCore::CSSToLengthConversionData::dynamicViewportFactor const):
(WebCore::CSSToLengthConversionData::setUsesContainerUnits const):
* Source/WebCore/css/CSSToLengthConversionData.h:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::updateViewportUnitsOnResize):
* Source/WebCore/rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::isFullScreenIFrame const):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setUsesViewportUnits):
(WebCore::RenderStyle::usesViewportUnits const):
Also rename hasViewportUnits -> usesViewportUnits for clarity.
(WebCore::RenderStyle::setUsesContainerUnits):
(WebCore::RenderStyle::usesContainerUnits const):
(WebCore::RenderStyle::NonInheritedFlags::operator== const):
(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):
(WebCore::RenderStyle::setHasViewportUnits): Deleted.
(WebCore::RenderStyle::hasViewportUnits const): Deleted.
* Source/WebCore/style/MatchedDeclarationsCache.cpp:
(WebCore::Style::MatchedDeclarationsCache::isCacheable):
Disallow caching.
(WebCore::Style::MatchedDeclarationsCache::clearEntriesAffectedByViewportUnits):
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::styleForElement):
(WebCore::Style::Resolver::pseudoStyleForElement):
Canonical link: https://commits.webkit.org/251268@main
Modified Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-invalidation-expected.txt
trunk/Source/WebCore/css/CSSPrimitiveValue.cpp
trunk/Source/WebCore/css/CSSToLengthConversionData.cpp
trunk/Source/WebCore/css/CSSToLengthConversionData.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/rendering/RenderIFrame.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/style/MatchedDeclarationsCache.cpp
trunk/Source/WebCore/style/StyleResolver.cpp
Diff
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-invalidation-expected.txt (295210 => 295211)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-invalidation-expected.txt 2022-06-03 15:24:42 UTC (rev 295210)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-invalidation-expected.txt 2022-06-03 15:29:29 UTC (rev 295211)
@@ -1,8 +1,8 @@
Test
-FAIL cqi respond when selected container changes type (inline-size -> none) assert_equals: expected "50px" but got "30px"
-FAIL cqb respond when selected container changes type (size -> none) assert_equals: expected "60px" but got "40px"
-FAIL cqb respond when intermediate container changes type (inline-size -> size) assert_equals: expected "20px" but got "40px"
-FAIL cqi respond when selected container changes inline-size assert_equals: expected "5px" but got "30px"
-FAIL cqb respond when selected container changes block-size assert_equals: expected "5px" but got "40px"
+PASS cqi respond when selected container changes type (inline-size -> none)
+PASS cqb respond when selected container changes type (size -> none)
+PASS cqb respond when intermediate container changes type (inline-size -> size)
+PASS cqi respond when selected container changes inline-size
+PASS cqb respond when selected container changes block-size
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.cpp (295210 => 295211)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2022-06-03 15:24:42 UTC (rev 295210)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2022-06-03 15:29:29 UTC (rev 295211)
@@ -824,6 +824,7 @@
double CSSPrimitiveValue::computeNonCalcLengthDouble(const CSSToLengthConversionData& conversionData, CSSUnitType primitiveType, double value)
{
auto selectContainerRenderer = [&](CQ::Axis axis) -> const RenderBox* {
+conversionData.setUsesContainerUnits();
if (!conversionData.element())
return nullptr;
// FIXME: Use
[webkit-changes] [295210] trunk/Source/WebCore/html/HTMLMapElement.cpp
Title: [295210] trunk/Source/WebCore/html/HTMLMapElement.cpp Revision 295210 Author commit-qu...@webkit.org Date 2022-06-03 08:24:42 -0700 (Fri, 03 Jun 2022) Log Message Allow image map adding/removing when in tree scope https://bugs.webkit.org/show_bug.cgi?id=241263 Patch by Rob Buis on 2022-06-03 Reviewed by Ryosuke Niwa. Allow image map adding/removing when in tree scope, even when disconnected, to avoid insert/remove mismatches. * Source/WebCore/html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseAttribute): Canonical link: https://commits.webkit.org/251267@main Modified Paths trunk/Source/WebCore/html/HTMLMapElement.cpp Diff Modified: trunk/Source/WebCore/html/HTMLMapElement.cpp (295209 => 295210) --- trunk/Source/WebCore/html/HTMLMapElement.cpp 2022-06-03 15:13:50 UTC (rev 295209) +++ trunk/Source/WebCore/html/HTMLMapElement.cpp 2022-06-03 15:24:42 UTC (rev 295210) @@ -95,13 +95,13 @@ if (document().isHTMLDocument()) return; } -if (isConnected()) +if (isInTreeScope()) treeScope().removeImageMap(*this); AtomString mapName = value; if (mapName[0] == '#') mapName = StringView(mapName).substring(1).toAtomString(); m_name = WTFMove(mapName); -if (isConnected()) +if (isInTreeScope()) treeScope().addImageMap(*this); return; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295209] trunk/LayoutTests/platform/mac-wk1/TestExpectations
Title: [295209] trunk/LayoutTests/platform/mac-wk1/TestExpectations Revision 295209 Author rack...@apple.com Date 2022-06-03 08:13:50 -0700 (Fri, 03 Jun 2022) Log Message [Gardening]: [ macOS wk1 ] compositing/video/video-border-radius.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=241266 Unreviewed test gardening. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/251266@main Modified Paths trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (295208 => 295209) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-06-03 15:03:54 UTC (rev 295208) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-06-03 15:13:50 UTC (rev 295209) @@ -1849,3 +1849,5 @@ webkit.org/b/241048 imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-ImageBitmap-video.html [ Failure Timeout ] webkit.org/b/241048 imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html [ Failure Timeout ] + +webkit.org/b/241266 compositing/video/video-border-radius.html [ Pass Timeout ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295208] trunk/Source/WebCore/layout
Title: [295208] trunk/Source/WebCore/layout
Revision 295208
Author za...@apple.com
Date 2022-06-03 08:03:54 -0700 (Fri, 03 Jun 2022)
Log Message
FlexLayout should not use non-logical intrinsic widths
https://bugs.webkit.org/show_bug.cgi?id=241256
Reviewed by Antti Koivisto.
This is in preparation for using logical-intrinsic widths in flex layout.
* Source/WebCore/layout/FormattingState.h:
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::FlexLayout):
(WebCore::Layout::FlexLayout::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:
(WebCore::Layout::FlexLayout::LogicalFlexItem::minimumContentWidth const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::LogicalFlexItem):
(WebCore::Layout::FlexLayout::formattingState const): Deleted.
Canonical link: https://commits.webkit.org/251265@main
Modified Paths
trunk/Source/WebCore/layout/FormattingState.h
trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp
trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.h
Diff
Modified: trunk/Source/WebCore/layout/FormattingState.h (295207 => 295208)
--- trunk/Source/WebCore/layout/FormattingState.h 2022-06-03 14:41:53 UTC (rev 295207)
+++ trunk/Source/WebCore/layout/FormattingState.h 2022-06-03 15:03:54 UTC (rev 295208)
@@ -47,7 +47,7 @@
void markNeedsLayout(const Box&, StyleDiff);
bool needsLayout(const Box&);
-void setIntrinsicWidthConstraintsForBox(const Box&, IntrinsicWidthConstraints);
+void setIntrinsicWidthConstraintsForBox(const Box&, IntrinsicWidthConstraints);
std::optional intrinsicWidthConstraintsForBox(const Box&) const;
void clearIntrinsicWidthConstraints(const Box&);
Modified: trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp (295207 => 295208)
--- trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp 2022-06-03 14:41:53 UTC (rev 295207)
+++ trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp 2022-06-03 15:03:54 UTC (rev 295208)
@@ -225,7 +225,12 @@
auto& style = layoutBox.style();
auto logicalWidthType = flexDirectionIsInlineAxis ? style.width().type() : style.height().type();
auto logicalHeightType = flexDirectionIsInlineAxis ? style.height().type() : style.width().type();
-logicalFlexItemList[index] = { flexItemList[index].marginRect, logicalWidthType, logicalHeightType, layoutBox };
+logicalFlexItemList[index] = { flexItemList[index].marginRect
+, logicalWidthType
+, logicalHeightType
+// FIXME: Convert to logical intrinsic width
+, *formattingState.intrinsicWidthConstraintsForBox(layoutBox)
+, layoutBox };
}
return logicalFlexItemList;
}
@@ -285,7 +290,7 @@
{
auto flexConstraints = downcast(constraints);
auto logicalFlexItems = convertFlexItemsToLogicalSpace(flexConstraints);
-auto flexLayout = FlexLayout { formattingState(), root().style() };
+auto flexLayout = FlexLayout { root().style() };
flexLayout.layout(flexConstraints, logicalFlexItems);
setFlexItemsGeometry(logicalFlexItems, flexConstraints);
}
Modified: trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp (295207 => 295208)
--- trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp 2022-06-03 14:41:53 UTC (rev 295207)
+++ trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp 2022-06-03 15:03:54 UTC (rev 295208)
@@ -34,9 +34,8 @@
namespace WebCore {
namespace Layout {
-FlexLayout::FlexLayout(const FlexFormattingState& formattingState, const RenderStyle& flexBoxStyle)
-: m_formattingState(formattingState)
-, m_flexBoxStyle(flexBoxStyle)
+FlexLayout::FlexLayout(const RenderStyle& flexBoxStyle)
+: m_flexBoxStyle(flexBoxStyle)
{
}
@@ -80,8 +79,6 @@
void FlexLayout::computeLogicalWidthForShrinkingFlexItems(LogicalFlexItems& flexItems, LayoutUnit availableSpace)
{
-auto& formattingState = this->formattingState();
-
auto totalShrink = 0.f;
auto totalFlexibleSpace = LayoutUnit { };
auto flexShrinkBase = 0.f;
@@ -103,7 +100,7 @@
auto baseSize = style.flexBasis().isFixed() ? LayoutUnit { style.flexBasis().value() } : flexItem.width();
if (auto shrinkValue = style.flexShrink()) {
auto flexShrink = shrinkValue * baseSize;
-shrinkingItems.append({ flexShrink, formattingState.intrinsicWidthConstraintsForBox(flexItem.layoutBox())->minimum, baseSize,
[webkit-changes] [295207] trunk/Source/WebCore/html/parser
Title: [295207] trunk/Source/WebCore/html/parser
Revision 295207
Author cdu...@apple.com
Date 2022-06-03 07:41:53 -0700 (Fri, 03 Jun 2022)
Log Message
Optimize HTMLToken::appendToComment()
https://bugs.webkit.org/show_bug.cgi?id=241250
Reviewed by Yusuke Suzuki.
Append several characters at once whenever possible instead of going one
character at a time. Also avoid updating the m_data8BitCheck data member
when the input characters are not UChars.
* Source/WebCore/html/parser/HTMLToken.h:
(WebCore::HTMLToken::appendToComment):
* Source/WebCore/html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::processToken):
Canonical link: https://commits.webkit.org/251264@main
Modified Paths
trunk/Source/WebCore/html/parser/HTMLToken.h
trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp
Diff
Modified: trunk/Source/WebCore/html/parser/HTMLToken.h (295206 => 295207)
--- trunk/Source/WebCore/html/parser/HTMLToken.h 2022-06-03 14:16:38 UTC (rev 295206)
+++ trunk/Source/WebCore/html/parser/HTMLToken.h 2022-06-03 14:41:53 UTC (rev 295207)
@@ -130,6 +130,8 @@
bool commentIsAll8BitData() const;
void beginComment();
+void appendToComment(char);
+void appendToComment(ASCIILiteral);
void appendToComment(UChar);
private:
@@ -407,6 +409,19 @@
m_type = Comment;
}
+inline void HTMLToken::appendToComment(char character)
+{
+ASSERT(character);
+ASSERT(m_type == Comment);
+m_data.append(character);
+}
+
+inline void HTMLToken::appendToComment(ASCIILiteral literal)
+{
+ASSERT(m_type == Comment);
+m_data.append(literal.characters8(), literal.length());
+}
+
inline void HTMLToken::appendToComment(UChar character)
{
ASSERT(character);
Modified: trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp (295206 => 295207)
--- trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp 2022-06-03 14:16:38 UTC (rev 295206)
+++ trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp 2022-06-03 14:41:53 UTC (rev 295207)
@@ -1010,8 +1010,7 @@
return emitAndReconsumeInDataState();
}
parseError();
-m_token.appendToComment('-');
-m_token.appendToComment('-');
+m_token.appendToComment("--"_s);
m_token.appendToComment(character);
ADVANCE_TO(CommentState);
END_STATE()
@@ -1018,9 +1017,7 @@
BEGIN_STATE(CommentEndBangState)
if (character == '-') {
-m_token.appendToComment('-');
-m_token.appendToComment('-');
-m_token.appendToComment('!');
+m_token.appendToComment("--!"_s);
ADVANCE_PAST_NON_NEWLINE_TO(CommentEndDashState);
}
if (character == '>')
@@ -1029,9 +1026,7 @@
parseError();
return emitAndReconsumeInDataState();
}
-m_token.appendToComment('-');
-m_token.appendToComment('-');
-m_token.appendToComment('!');
+m_token.appendToComment("--!"_s);
m_token.appendToComment(character);
ADVANCE_TO(CommentState);
END_STATE()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295206] trunk/LayoutTests/platform/mac-wk2/TestExpectations
Title: [295206] trunk/LayoutTests/platform/mac-wk2/TestExpectations Revision 295206 Author rack...@apple.com Date 2022-06-03 07:16:38 -0700 (Fri, 03 Jun 2022) Log Message [Gardening]: [ macOS Debug wk2 EWS ] WebCore::RenderView::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) https://bugs.webkit.org/show_bug.cgi?id=241265 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/251263@main Modified Paths trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (295205 => 295206) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-06-03 14:00:14 UTC (rev 295205) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-06-03 14:16:38 UTC (rev 295206) @@ -1719,3 +1719,4 @@ webkit.org/b/241191 [ Monterey Debug ] webgl/1.0.3/conformance/attribs/gl-vertexattribpointer-offsets.html [ Pass Timeout ] +webkit.org/b/241265 [ Debug ] imported/w3c/web-platform-tests/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-object-percentage.html [ Pass Crash ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295204] trunk/Source/WebCore/rendering/RenderTable.cpp
Title: [295204] trunk/Source/WebCore/rendering/RenderTable.cpp
Revision 295204
Author commit-qu...@webkit.org
Date 2022-06-03 06:59:08 -0700 (Fri, 03 Jun 2022)
Log Message
Layout table captions in simplified layout
https://bugs.webkit.org/show_bug.cgi?id=241262
Patch by Rob Buis on 2022-06-03
Reviewed by Alan Bujtas.
Layout table captions in simplified layout.
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::simplifiedNormalFlowLayout):
Canonical link: https://commits.webkit.org/251261@main
Modified Paths
trunk/Source/WebCore/rendering/RenderTable.cpp
Diff
Modified: trunk/Source/WebCore/rendering/RenderTable.cpp (295203 => 295204)
--- trunk/Source/WebCore/rendering/RenderTable.cpp 2022-06-03 13:31:49 UTC (rev 295203)
+++ trunk/Source/WebCore/rendering/RenderTable.cpp 2022-06-03 13:59:08 UTC (rev 295204)
@@ -413,6 +413,8 @@
void RenderTable::simplifiedNormalFlowLayout()
{
+for (auto& caption : m_captions)
+caption->layoutIfNeeded();
for (RenderTableSection* section = topSection(); section; section = sectionBelow(section)) {
section->layoutIfNeeded();
section->computeOverflowFromCells();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295200] trunk
Title: [295200] trunk Revision 295200 Author an...@apple.com Date 2022-06-03 02:54:36 -0700 (Fri, 03 Jun 2022) Log Message Re-evaluate queries after subframe size changes https://bugs.webkit.org/show_bug.cgi?id=241225 Reviewed by Alan Bujtas. Container queries in frames don't react to frame size changes. * LayoutTests/TestExpectations: Mark imported/w3c/web-platform-tests/css/css-contain/container-queries/inline-size-bfc-floats.html as failure, it has ever been passing by fluke (there are some containment issues with floats). * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-in-container-invalidation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-invalidation-expected.txt: * Source/WebCore/css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): Ensure we update layout when there are container queries in a subframe, similar to media queries. * Source/WebCore/dom/Document.cpp: (WebCore::Document::resolveStyle): (WebCore::Document::updateLayout): * Source/WebCore/page/FrameView.cpp: (WebCore::FrameView::updateContentsSize): (WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive): * Source/WebCore/page/FrameViewLayoutContext.cpp: (WebCore::FrameViewLayoutContext::layout): Move the container query invalidation loop to the main layout function so all paths are covered. (WebCore::FrameViewLayoutContext::performLayout): * Source/WebCore/page/FrameViewLayoutContext.h: * Source/WebCore/style/StyleScopeRuleSets.cpp: (WebCore::Style::ScopeRuleSets::hasContainerQueries const): * Source/WebCore/style/StyleScopeRuleSets.h: Canonical link: https://commits.webkit.org/251257@main Modified Paths trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-in-container-invalidation-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-invalidation-expected.txt trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/page/FrameViewLayoutContext.cpp trunk/Source/WebCore/page/FrameViewLayoutContext.h trunk/Source/WebCore/style/StyleScopeRuleSets.cpp trunk/Source/WebCore/style/StyleScopeRuleSets.h Diff Modified: trunk/LayoutTests/TestExpectations (295199 => 295200) --- trunk/LayoutTests/TestExpectations 2022-06-03 08:29:27 UTC (rev 295199) +++ trunk/LayoutTests/TestExpectations 2022-06-03 09:54:36 UTC (rev 295200) @@ -4778,6 +4778,7 @@ # Container queries webkit.org/b/229659 imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-layout-container-001.https.html [ ImageOnlyFailure ] +webkit.org/b/229659 imported/w3c/web-platform-tests/css/css-contain/container-queries/inline-size-bfc-floats.html [ ImageOnlyFailure ] webkit.org/b/229659 imported/w3c/web-platform-tests/css/css-contain/container-queries/svg-foreignobject-no-size-container.html [ Skip ] webkit.org/b/229659 imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-gradient-invalidation.html [ ImageOnlyFailure ] webkit.org/b/229659 imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-gradient.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-in-container-invalidation-expected.txt (295199 => 295200) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-in-container-invalidation-expected.txt 2022-06-03 08:29:27 UTC (rev 295199) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-in-container-invalidation-expected.txt 2022-06-03 09:54:36 UTC (rev 295200) @@ -1,4 +1,4 @@ -FAIL @container-dependent elements respond to size changes of an @container-dependent iframe assert_equals: expected "rgb(0, 128, 0)" but got "rgb(255, 0, 0)" +PASS @container-dependent elements respond to size changes of an @container-dependent iframe Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-invalidation-expected.txt (295199 => 295200) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-invalidation-expected.txt 2022-06-03 08:29:27 UTC (rev 295199) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-invalidation-expected.txt 2022-06-03 09:54:36 UTC (rev 295200) @@ -1,4 +1,4 @@ -FAIL @container-dependent elements respond to iframe size changes assert_equals: expected "rgb(0, 128, 0)" but got "rgb(255, 0, 0)" +PASS @container-dependent elements respond to iframe size changes Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (295199 => 295200) --- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2022-06-03 08:29:27 UTC (rev
[webkit-changes] [295199] trunk/Tools/jhbuild/jhbuild-minimal.modules
Title: [295199] trunk/Tools/jhbuild/jhbuild-minimal.modules Revision 295199 Author dp...@igalia.com Date 2022-06-03 01:29:27 -0700 (Fri, 03 Jun 2022) Log Message [JHBuild] Disable gnutls backend in glib-networking and enable openssl backend https://bugs.webkit.org/show_bug.cgi?id=239324 Reviewed by Carlos Alberto Lopez Perez. glib-networking uses gnutls backend by default. Ubuntu 18.04's gnutls doesn't meet the minimal version required by glib-networking. Use openssl instead. * jhbuild/jhbuild-minimal.modules: Use openssl backend in glib-networking. Canonical link: https://commits.webkit.org/251256@main Modified Paths trunk/Tools/jhbuild/jhbuild-minimal.modules Diff Modified: trunk/Tools/jhbuild/jhbuild-minimal.modules (295198 => 295199) --- trunk/Tools/jhbuild/jhbuild-minimal.modules 2022-06-03 06:46:11 UTC (rev 295198) +++ trunk/Tools/jhbuild/jhbuild-minimal.modules 2022-06-03 08:29:27 UTC (rev 295199) @@ -175,7 +175,8 @@ - + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295198] branches/safari-613-branch/Source/WebKit
Title: [295198] branches/safari-613-branch/Source/WebKit Revision 295198 Author alanc...@apple.com Date 2022-06-02 23:46:11 -0700 (Thu, 02 Jun 2022) Log Message Cherry-pick 969b67ab0154. rdar://problem/80059355 Unreviewed, fix the Catalyst build after r292888 `MCProfileConnection` is not available on Mac Catalyst. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _dataOwnerForPasteboard:]): Canonical link: https://commits.webkit.org/249666@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292896 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-613-branch/Source/WebKit/ChangeLog branches/safari-613-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (295197 => 295198) --- branches/safari-613-branch/Source/WebKit/ChangeLog 2022-06-03 06:46:08 UTC (rev 295197) +++ branches/safari-613-branch/Source/WebKit/ChangeLog 2022-06-03 06:46:11 UTC (rev 295198) @@ -1,3 +1,12 @@ +2022-04-14 Wenson Hsieh + +Unreviewed, fix the Catalyst build after r292888 + +`MCProfileConnection` is not available on Mac Catalyst. + +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView _dataOwnerForPasteboard:]): + 2022-05-16 Youenn Fablet Add logging when taking a process assertion synchronously Modified: branches/safari-613-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (295197 => 295198) --- branches/safari-613-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2022-06-03 06:46:08 UTC (rev 295197) +++ branches/safari-613-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2022-06-03 06:46:11 UTC (rev 295198) @@ -7889,6 +7889,11 @@ if (intent == WebKit::PasteboardAccessIntent::Write) return coreDataOwnerType(self._dataOwnerForCopy); +#if !PLATFORM(MACCATALYST) +if ([[PAL::getMCProfileConnectionClass() sharedConnection] isURLManaged:[_webView URL]]) +return WebCore::DataOwnerType::Enterprise; +#endif + ASSERT_NOT_REACHED(); return WebCore::DataOwnerType::Undefined; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295197] branches/safari-613-branch
Title: [295197] branches/safari-613-branch
Revision 295197
Author alanc...@apple.com
Date 2022-06-02 23:46:08 -0700 (Thu, 02 Jun 2022)
Log Message
Cherry-pick d323be61003f. rdar://problem/14839536
Breaking out of a quoted reply block by inserting a new paragraph should reset writing direction
https://bugs.webkit.org/show_bug.cgi?id=240778
rdar://14839536
Reviewed by Devin Rousso.
The process of breaking out of a `blockquote` via the "InsertNewlineInQuotedContent" editor command currently works by
splitting the `blockquote` into two sibling elements underneath the same parent container, and then inserting a `br`
element in between these sibling `blockquote` elements. The selection is then moved to the end of the newly created
`br`, which inherits the writing direction (`dir`) of the element containing the `blockquote`. In the case of Mail, if
the system language is right-to-left but the quoted content is left-to-right, this can lead to some unintuitive behavior
when breaking out of quoted LTR content, since the newly created line break will inherit the right-to-left direction of
its ancestor.
To fix this, in the case where we're breaking out of a `blockquote` and the start of the selection is left-to-right but
the element that contains the `blockquote` is right-to-left, we can wrap the `br` in another block-level container
element with `dir=auto` to avoid inheriting the writing direction from the `blockquote`'s ancestor. This means that the
writing direction of the newly inserted paragraph will automatically be determined by what the user types.
Test: editing/execCommand/reset-direction-after-breaking-blockquote.html
* LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote-expected.txt: Added.
* LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote.html: Added.
* Source/WebCore/editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
Canonical link: https://commits.webkit.org/250901@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613-branch/Source/WebCore/editing/BreakBlockquoteCommand.cpp
Added Paths
branches/safari-613-branch/LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote-expected.txt
branches/safari-613-branch/LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote.html
Diff
Added: branches/safari-613-branch/LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote-expected.txt (0 => 295197)
--- branches/safari-613-branch/LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote-expected.txt (rev 0)
+++ branches/safari-613-branch/LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote-expected.txt 2022-06-03 06:46:08 UTC (rev 295197)
@@ -0,0 +1,23 @@
+| "\n"
+|
+| "Start of right to left content"
+| "\n"
+|
+| type="cite"
+| "\n"
+|
+| dir="ltr"
+| id="target"
+| "Some quoted content"
+|
+| dir="auto"
+| <#selection-caret>
+|
+|
+| type="cite"
+| "\n"
+|
+| dir="ltr"
+| "End of quoted content"
+| "\n"
+| "\n"
Added: branches/safari-613-branch/LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote.html (0 => 295197)
--- branches/safari-613-branch/LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote.html (rev 0)
+++ branches/safari-613-branch/LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote.html 2022-06-03 06:46:08 UTC (rev 295197)
@@ -0,0 +1,31 @@
+
+
+
+
+blockquote {
+border-left: 2px solid lightblue;
+padding-left: 1em;
+}
+
+
+
+
+This tests that the writing direction is reset to its natural value after breaking out of a blockquote in the case
+where the writing direction at the previous selection differs from the writing direction of the newly inserted
+paragraph.
+
+
+Start of right to left content
+
+Some quoted content
+End of quoted content
+
+
+