[webkit-changes] [WebKit/WebKit] e214b2: Use quaternary-fill UIColor in iOS attachment
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e214b2a322c49e1ff3aa7991b6f9478d8cbd80e5 https://github.com/WebKit/WebKit/commit/e214b2a322c49e1ff3aa7991b6f9478d8cbd80e5 Author: Gerald Squelart Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt M Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h M Source/WebCore/css/CSSValueKeywords.in M Source/WebCore/css/parser/CSSParserIdioms.cpp M Source/WebCore/html/shadow/attachmentElementShadow.css M Source/WebCore/rendering/RenderThemeIOS.mm Log Message: --- Use quaternary-fill UIColor in iOS attachment https://bugs.webkit.org/show_bug.cgi?id=255055 rdar://problem/107679227 Reviewed by Aditya Keerthi. * Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h: * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/html/shadow/attachmentElementShadow.css: (div#attachment-container): * Source/WebCore/rendering/RenderThemeIOS.mm: (WebCore::cssValueSystemColorInformationList): Canonical link: https://commits.webkit.org/262657@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ff96b4: AX: AccessibilityRenderObject::addRemoteSVGChildre...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ff96b4d0c1203fc293c8eba30d2022cf2e949a3e https://github.com/WebKit/WebKit/commit/ff96b4d0c1203fc293c8eba30d2022cf2e949a3e Author: Tyler Wilcock Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebCore/accessibility/AccessibilityRenderObject.cpp Log Message: --- AX: AccessibilityRenderObject::addRemoteSVGChildren() should protect the created SVG object with a RefPtr https://bugs.webkit.org/show_bug.cgi?id=255047 rdar://problem/107674710 Reviewed by Chris Fleizach. Per https://github.com/WebKit/WebKit/wiki/Smart-Pointer-Usage-Guidelines: > Every object passed to a non-trivial function as an argument (including > "this" pointer) should be stored as a Ref, RefPtr, CheckedRef, or CheckedPtr > in the caller’s local scope Let's bring this function inline with this guidance since AccessibilityObject::addChild is not trivial. This RefPtr will be free in the common case that there is no remote SVG root object to add. * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::addRemoteSVGChildren): Canonical link: https://commits.webkit.org/262656@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e69ef3: Small interaction regions need to be guarded with ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e69ef3dfd95259622b14db520960c37959feeafd https://github.com/WebKit/WebKit/commit/e69ef3dfd95259622b14db520960c37959feeafd Author: Megan Gardner Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M LayoutTests/interaction-region/input-type-file-region-expected.txt M LayoutTests/interaction-region/input-type-range-region-expected.txt A LayoutTests/interaction-region/tiny-regions-expected.txt A LayoutTests/interaction-region/tiny-regions.html M Source/WebCore/page/DebugPageOverlays.cpp M Source/WebCore/rendering/EventRegion.cpp M Source/WebCore/rendering/RenderLayerBacking.cpp Log Message: --- Small interaction regions need to be guarded with occlusion regions. https://bugs.webkit.org/show_bug.cgi?id=254785 rdar://105092716 Reviewed by Tim Horton. Also add some additional debug information to draw occlusion regions in red. * LayoutTests/interaction-region/input-type-file-region-expected.txt: * LayoutTests/interaction-region/input-type-range-region-expected.txt: * Source/WebCore/page/DebugPageOverlays.cpp: (WebCore::InteractionRegionOverlay::drawRect): * Source/WebCore/rendering/EventRegion.cpp: (WebCore::EventRegionContext::guardSmallIntetactionRegions): (WebCore::EventRegionContext::copyInteractionRegionsToEventRegion): * Source/WebCore/rendering/EventRegion.h: * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintDebugOverlays): Canonical link: https://commits.webkit.org/262655@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 62b9ab: No videos play if opened in full screen on first play
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 62b9ab75af70fc1cb9ada689c9f3f482a0274e30 https://github.com/WebKit/WebKit/commit/62b9ab75af70fc1cb9ada689c9f3f482a0274e30 Author: Per Arne Vollan Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm Log Message: --- No videos play if opened in full screen on first play https://bugs.webkit.org/show_bug.cgi?id=255048 rdar://107540521 Reviewed by Eric Carlson and Jean-Yves Avenard. When CA layers are not remotely hosted in both the GPU process and the WebContent process, it is not guaranteed that the remote context ID will be set in the HTML media element when entering fullscreen. This patch works around that by delaying setting up the fullscreen until the video dimensions are set. At this point, the remote context ID should be available. * Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h: * Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement): (WebKit::VideoFullscreenManager::videoDimensionsChanged): Canonical link: https://commits.webkit.org/262654@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 95cb10: [Lockdown Mode] Disable Web Codecs API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 95cb10c87569d6491b027a7f0123548dbf891555 https://github.com/WebKit/WebKit/commit/95cb10c87569d6491b027a7f0123548dbf891555 Author: Brent Fulgham Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- [Lockdown Mode] Disable Web Codecs API https://bugs.webkit.org/show_bug.cgi?id=255054 Reviewed by Youenn Fablet. Disable access to WebCodec APIs when in lockdown mode. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::adjustSettingsForLockdownMode): Turn off WebCodecs. * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Add tests. Canonical link: https://commits.webkit.org/262653@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1200e5: REGRESSION (Safari 16.4): "box-decoration-break: c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1200e59015c2f14ef93c2e80aa952349506c2012 https://github.com/WebKit/WebKit/commit/1200e59015c2f14ef93c2e80aa952349506c2012 Author: Alan Baradlay Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M LayoutTests/fast/inline/box-decoration-clone-with-padding-end-expected.html A LayoutTests/fast/inline/box-decoration-clone-with-padding-end-line-wrap-expected.html A LayoutTests/fast/inline/box-decoration-clone-with-padding-end-line-wrap.html M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp Log Message: --- REGRESSION (Safari 16.4): "box-decoration-break: clone" with "padding-right" wraps inline content unexpectedly https://bugs.webkit.org/show_bug.cgi?id=255065 Reviewed by Antti Koivisto. Remove incorrect check against whether the candidate content has inline level box. I am sure this was supposed to check against _inline_box_ (and not inline level box) so that we don't even try to find the matching inline box end with cloned decoration unless the candidate content has an inline box (end) (perf optimization). However we hardly have cloned inline boxes and even when we do, they are not super nested and/or sprinkled all over the inline content. * LayoutTests/fast/inline/box-decoration-clone-with-padding-end-line-wrap-expected.html: Added. * LayoutTests/fast/inline/box-decoration-clone-with-padding-end-line-wrap.html: Added. * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineCandidate::InlineContent::isEmpty const): (WebCore::Layout::LineCandidate::InlineContent::appendInlineItem): (WebCore::Layout::LineCandidate::InlineContent::reset): (WebCore::Layout::availableWidth): (WebCore::Layout::LineCandidate::InlineContent::hasInlineLevelBox const): Deleted. Canonical link: https://commits.webkit.org/262652@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7d6a1d: [JSC] strcat-bigint-oom.js should only run on WASM...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d6a1d456583be02e81476582bb9eaf5ee944f2d https://github.com/WebKit/WebKit/commit/7d6a1d456583be02e81476582bb9eaf5ee944f2d Author: Ross Kirsling Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M JSTests/stress/strcat-bigint-oom.js Log Message: --- [JSC] strcat-bigint-oom.js should only run on WASM platforms https://bugs.webkit.org/show_bug.cgi?id=255074 Reviewed by Yusuke Suzuki. * JSTests/stress/strcat-bigint-oom.js: Guard test file with $isWasmPlatform. Canonical link: https://commits.webkit.org/262651@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9e8029: Adjust fullscreen transition logic
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9e8029942f4c9b520c68cc2b45571e958e0d2417 https://github.com/WebKit/WebKit/commit/9e8029942f4c9b520c68cc2b45571e958e0d2417 Author: Aditya Keerthi Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm Log Message: --- Adjust fullscreen transition logic https://bugs.webkit.org/show_bug.cgi?id=255046 rdar://105242390 Reviewed by Tim Horton. * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): (-[WKFullScreenWindowController _exitFullscreenImmediately]): (-[WKFullScreenWindowController _dismissFullscreenViewController]): Canonical link: https://commits.webkit.org/262650@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b51b20: [UI-side compositing] Flash of flipped content whe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b51b2033860f0b19c303ae83cb2c0551d066baf5 https://github.com/WebKit/WebKit/commit/b51b2033860f0b19c303ae83cb2c0551d066baf5 Author: Wenson Hsieh Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm M Tools/TestWebKitAPI/SourcesCocoa.txt M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm A Tools/TestWebKitAPI/cocoa/CGImagePixelReader.cpp A Tools/TestWebKitAPI/cocoa/CGImagePixelReader.h A Tools/TestWebKitAPI/cocoa/EnableUISideCompositingScope.h A Tools/TestWebKitAPI/cocoa/EnableUISideCompositingScope.mm Log Message: --- [UI-side compositing] Flash of flipped content when pinching into tab overview in Safari https://bugs.webkit.org/show_bug.cgi?id=255042 rdar://107499419 Reviewed by Simon Fraser. Currently, when pinching out to tab overview when UI-side compositing is enabled, there's a brief flash of partially-flipped page tiles in the `_WKThumbnailView`, as Safari swaps out the contents of the tab with the web view thumbnail. When this happens, the thumbnail view asynchronously requests a snapshot from the web page; before the snapshot arrives, however, we reparent the web view's root layer inside the layer hierarchy of the thumbnail view, to continue displaying live web content. When UI-side compositing is enabled, however, this reparenting causes page tiles to become flipped underneath the `_WKThumbnailView`; this is because while `WKWebView` on macOS returns `YES` for `-isFlipped`, `_WKThumbnailView` does not (all other aspects being equal). Note that when UI-side compositing is disabled, the hosting layer has `geometryFlipped=true`, which allows us to get the flipping behavior right. To fix this, we simply implement `-[_WKThumbnailView isFlipped]` and return `YES`, to align with `WKWebView`. Note that this is safe to do even when UI-side compositing is disabled, since it's the only layer underneath `_WKThumbnailView`'s layer anyways, and covers the entire layer (which is how it works in `WKWebView` as well). Test: WebKit.WKThumbnailViewLayerReparentingWithUISideCompositing * Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm: (-[_WKThumbnailView isFlipped]): Return `YES` here to align with `WKWebView` on macOS. See above for more details. * Tools/TestWebKitAPI/SourcesCocoa.txt: * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm: (-[NSView _test_cgImage]): Add a testing helper method to grab a layer snapshot of an `NSView`, and return it as a `CGImage`. (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm: (-[NSUserDefaults swizzled_objectForKey:]): Deleted. (TestWebKitAPI::EnableUISideCompositingScope::EnableUISideCompositingScope): Deleted. (TestWebKitAPI::EnableUISideCompositingScope::~EnableUISideCompositingScope): Deleted. Move the `CGImagePixelReader` helper class out into a separate file. * Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm: (TestWebKitAPI::CGImagePixelReader::CGImagePixelReader): Deleted. (TestWebKitAPI::CGImagePixelReader::isTransparentBlack const): Deleted. (TestWebKitAPI::CGImagePixelReader::at const): Deleted. (TestWebKitAPI::CGImagePixelReader::width const): Deleted. (TestWebKitAPI::CGImagePixelReader::height const): Deleted. * Tools/TestWebKitAPI/cocoa/CGImagePixelReader.cpp: Added. (TestWebKitAPI::CGImagePixelReader::CGImagePixelReader): (TestWebKitAPI::CGImagePixelReader::isTransparentBlack const): (TestWebKitAPI::CGImagePixelReader::at const): * Tools/TestWebKitAPI/cocoa/CGImagePixelReader.h: Added. (TestWebKitAPI::CGImagePixelReader::width const): (TestWebKitAPI::CGImagePixelReader::height const): * Tools/TestWebKitAPI/cocoa/EnableUISideCompositingScope.h: Added. * Tools/TestWebKitAPI/cocoa/EnableUISideCompositingScope.mm: Added. Move the `EnableUISideCompositingScope` helper class out into a separate file. (-[NSUserDefaults swizzled_objectForKey:]): (TestWebKitAPI::EnableUISideCompositingScope::EnableUISideCompositingScope): (TestWebKitAPI::EnableUISideCompositingScope::~EnableUISideCompositingScope): Canonical link: https://commits.webkit.org/262649@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bde34b: [Gardening]: [ BigSur Debug ] http/tests/security/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bde34b59b56c25dfea09afd82970102ccf9f54c5 https://github.com/WebKit/WebKit/commit/bde34b59b56c25dfea09afd82970102ccf9f54c5 Author: Karl Rackler Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: [ BigSur Debug ] http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin.html is a flakey timeout https://bugs.webkit.org/show_bug.cgi?id=224842 rdar://76926339 Unreviewed test gardening. Removing stale test expectation. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/262648@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2ef8f7: [Cocoa] Transition Legacy Fairplay CDM off AVStrea...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2ef8f77a149ffbe6dcb5026c3988d76c1f1e66d3 https://github.com/WebKit/WebKit/commit/2ef8f77a149ffbe6dcb5026c3988d76c1f1e66d3 Author: Jer Noble Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: A LayoutTests/http/tests/media/fairplay/legacy-eme.js A LayoutTests/http/tests/media/fairplay/legacy-fairplay-error-expected.txt A LayoutTests/http/tests/media/fairplay/legacy-fairplay-error.html A LayoutTests/http/tests/media/fairplay/legacy-fairplay-hls-expected.txt A LayoutTests/http/tests/media/fairplay/legacy-fairplay-hls.html A LayoutTests/http/tests/media/fairplay/legacy-fairplay-mse-v2-expected.txt A LayoutTests/http/tests/media/fairplay/legacy-fairplay-mse-v2.html A LayoutTests/http/tests/media/fairplay/legacy-fairplay-mse-v3-expected.txt A LayoutTests/http/tests/media/fairplay/legacy-fairplay-mse-v3.html M LayoutTests/http/tests/media/fairplay/support.js M Source/WTF/wtf/PlatformHave.h M Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.cpp M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/graphics/LegacyCDMSession.h M Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm R Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h R Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm M Source/WebCore/platform/graphics/mac/controls/ImageControlsButtonMac.mm M Source/WebCore/platform/graphics/mac/controls/MenuListButtonMac.mm M Tools/TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm Log Message: --- [Cocoa] Transition Legacy Fairplay CDM off AVStreamSession https://bugs.webkit.org/show_bug.cgi?id=254992 rdar://107202864 Reviewed by Eric Carlson. Clients of the prefixed WebKit EME APIs using the Fairplay "V2" protocol will use a CDM implementation that relies upon AVStreamSession. This implementation will break when "sampleBufferContentKeySessionSupport" is enabled, as it relies upon platform changes only available through AVContentKeySession. Remove the AVStreamSession-based CDM implementation and funnel all support through the existing AVContentKeySession-based legacy CDM. At the same time, modify that AVContentKeySession-based CDM to query the "sampleBufferContentKeySessionSupport" setting and opt into the non-legacy AVContentKeySession path when it is enabled. Drive-by fix: When opting into the non-legacy codepath, the -contentKeySession:didProvideContentKeyRequest: delegate callbock becomes asynchronous. To retain the existing synchronous behavior of the CDM, set an explicit work queue for the delegate callbacks, and make the setting and getting of m_keyRequest thread-safe. Add a semaphore to be used to detect when the m_keyRequest value changes. Drive-by fix #2: Fix some unified-build included errors exposed by removing CDMSessionAVStreamSession.h Add LayoutTests for basic legacy EME API playback. * LayoutTests/http/tests/media/fairplay/legacy-eme.js: Added. (selectKeySystem): (async startLegacyEME): (extractContentId): (concatInitDataIdAndCertificate): * LayoutTests/http/tests/media/fairplay/legacy-fairplay-error-expected.txt: Added. * LayoutTests/http/tests/media/fairplay/legacy-fairplay-error.html: Added. * LayoutTests/http/tests/media/fairplay/legacy-fairplay-hls-expected.txt: Added. * LayoutTests/http/tests/media/fairplay/legacy-fairplay-hls.html: Added. * LayoutTests/http/tests/media/fairplay/legacy-fairplay-mse-v2-expected.txt: Added. * LayoutTests/http/tests/media/fairplay/legacy-fairplay-mse-v2.html: Added. * LayoutTests/http/tests/media/fairplay/legacy-fairplay-mse-v3-expected.txt: Added. * LayoutTests/http/tests/media/fairplay/legacy-fairplay-mse-v3.html: Added. * LayoutTests/http/tests/media/fairplay/support.js: (uInt16ArrayToString): (stringToUint16Array): * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.cpp: (WebCore::platformRegisterFactories): * Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h: *
[webkit-changes] [WebKit/WebKit] d4960a: [Gardening]: [ BigSur Debug ] http/tests/security/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d4960a982a41cae27923f39b9220f33a2ad46917 https://github.com/WebKit/WebKit/commit/d4960a982a41cae27923f39b9220f33a2ad46917 Author: Karl Rackler Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: [ BigSur Debug ] http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect.html is a flakey timeout https://bugs.webkit.org/show_bug.cgi?id=223759 rdar://75863566 Unreviewed test gardening. Removing stale test expectation. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/262646@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d263eb: [Cocoa] Refactor caps lock indicator display logic
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d263ebe5a2f6a852e8dc303dcc2fb5f4591e2282 https://github.com/WebKit/WebKit/commit/d263ebe5a2f6a852e8dc303dcc2fb5f4591e2282 Author: Aditya Keerthi Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebCore/rendering/RenderThemeCocoa.mm Log Message: --- [Cocoa] Refactor caps lock indicator display logic https://bugs.webkit.org/show_bug.cgi?id=255056 rdar://107582325 Reviewed by Wenson Hsieh. * Source/WebCore/rendering/RenderThemeCocoa.mm: (WebCore::canShowCapsLockIndicator): (WebCore::RenderThemeCocoa::shouldHaveCapsLockIndicator const): Canonical link: https://commits.webkit.org/262645@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8ed055: REGRESSION (Safari 16.4): "box-decoration-break: c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8ed055f73871f20e519ed8920f711196d204df5e https://github.com/WebKit/WebKit/commit/8ed055f73871f20e519ed8920f711196d204df5e Author: Alan Baradlay Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: A LayoutTests/fast/inline/box-decoration-clone-with-padding-end-expected.html A LayoutTests/fast/inline/box-decoration-clone-with-padding-end.html M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp Log Message: --- REGRESSION (Safari 16.4): "box-decoration-break: clone" with "padding-right" is missing padding space https://bugs.webkit.org/show_bug.cgi?id=255036 Reviewed by Antti Koivisto. Account for cloned decoration end when computing the content width for merged text runs. * LayoutTests/fast/inline/box-decoration-clone-with-padding-end-expected.html: Added. * LayoutTests/fast/inline/box-decoration-clone-with-padding-end.html: Added. * Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp: (WebCore::Layout::Line::appendTextContent): * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForLineLayout): Canonical link: https://commits.webkit.org/262644@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e43ffd: [Gardening]: [ Debug ] http/tests/security/webaudi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e43ffdb71cf137384ab2a1f37e68c60a568c3ad0 https://github.com/WebKit/WebKit/commit/e43ffdb71cf137384ab2a1f37e68c60a568c3ad0 Author: Karl Rackler Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M LayoutTests/platform/ios-simulator/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: [ Debug ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html and one other test are flakey timeouts https://bugs.webkit.org/show_bug.cgi?id=223724 rdar://75817036 Unreviewed test gardening. Removing stale test expectations * LayoutTests/platform/ios-simulator/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/262643@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8be98d: Unreviewed, reverting r262623@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8be98ddfbc4192409ff21d6fb299cdb305e725e3 https://github.com/WebKit/WebKit/commit/8be98ddfbc4192409ff21d6fb299cdb305e725e3 Author: Commit Queue Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Unreviewed, reverting r262623@main. https://bugs.webkit.org/show_bug.cgi?id=255062 Reverted changeset: "Enable fetch priority hints by default" https://bugs.webkit.org/show_bug.cgi?id=255008 https://commits.webkit.org/262623@main Canonical link: https://commits.webkit.org/262642@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f59f78: Remove the mechanism for blocking paint on non-fin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f59f78a8be0bda72e2019411f3111088dd6c9fba https://github.com/WebKit/WebKit/commit/f59f78a8be0bda72e2019411f3111088dd6c9fba Author: Antti Koivisto Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/html/HTMLFrameSetElement.cpp M Source/WebCore/rendering/RenderBlock.cpp M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/StyleMiscNonInheritedData.cpp M Source/WebCore/rendering/style/StyleMiscNonInheritedData.h M Source/WebCore/rendering/svg/RenderSVGRoot.cpp M Source/WebCore/style/StyleScope.cpp M Source/WebCore/style/StyleTreeResolver.cpp Log Message: --- Remove the mechanism for blocking paint on non-final style https://bugs.webkit.org/show_bug.cgi?id=255045 rdar://106805458 Reviewed by Alan Baradlay. Normally we don't compute element style until all relevant stylesheets have been loaded. However a script may force us to compute the style earlier. In this case we were marking the style as "non-final" and avoided painting such elements (because their style may change later, resulting in a flash of miss-styled content). In practice hitting this case is rather difficult since we block script execution on stylesheet loads. You need to insert a stylesheet from a script and then force a style recalc. Our current main anti-FOUC mechanism is to delay layer tree unfreezing. The non-final style mechanism is likely not useful anymore. * Source/WebCore/dom/Document.cpp: (WebCore::Document::resolveStyle): * Source/WebCore/dom/Document.h: (WebCore::Document::hasNodesWithNonFinalStyle const): Deleted. (WebCore::Document::setHasNodesWithNonFinalStyle): Deleted. * Source/WebCore/html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::rendererIsNeeded): * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents): * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::shouldSuppressPaintingLayer): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::miscDataChangeRequiresRepaint): * Source/WebCore/rendering/style/RenderStyle.h: (WebCore::RenderStyle::isNotFinal const): Deleted. (WebCore::RenderStyle::setIsNotFinal): Deleted. * Source/WebCore/rendering/style/StyleMiscNonInheritedData.cpp: (WebCore::StyleMiscNonInheritedData::StyleMiscNonInheritedData): (WebCore::StyleMiscNonInheritedData::operator== const): * Source/WebCore/rendering/style/StyleMiscNonInheritedData.h: * Source/WebCore/rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paintContents): * Source/WebCore/style/StyleScope.cpp: (WebCore::Style::Scope::invalidateStyleAfterStyleSheetChange): * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement): (WebCore::Style::TreeResolver::resolveComposedTree): (WebCore::Style::TreeResolver::resolve): Canonical link: https://commits.webkit.org/262641@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 42bebe: Revert another piece of 262558@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 42bebe2b0a1a9c5defbc359aeb93a60b8ba342c2 https://github.com/WebKit/WebKit/commit/42bebe2b0a1a9c5defbc359aeb93a60b8ba342c2 Author: Alex Christensen Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm Log Message: --- Revert another piece of 262558@main https://bugs.webkit.org/show_bug.cgi?id=255057 rdar://107676726 Reviewed by Chris Dumez. Reverting these pieces fixes another known regression. * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::encodeSecureCodingInternal): (IPC::shouldEnableStrictMode): Canonical link: https://commits.webkit.org/262640@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40e8ec: [git-webkit] Handle edge-case of commit not on branch
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40e8ecb625c1980908ec70c8a60dda47cc899e99 https://github.com/WebKit/WebKit/commit/40e8ecb625c1980908ec70c8a60dda47cc899e99 Author: Jonathan Bedard Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Tools/Scripts/libraries/webkitscmpy/setup.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py Log Message: --- [git-webkit] Handle edge-case of commit not on branch https://bugs.webkit.org/show_bug.cgi?id=255050 rdar://107676470 Reviewed by Stephanie Lewis and Dewei Zhu. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py: (Git.branches_for): Handle case where a commit is on no branches. (Git.commit): Handle undefined branch. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py: (ScmBase.prioritize_branches): If no branches are provided, return None. Canonical link: https://commits.webkit.org/262639@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 59318c: [PlayStation] Fix build after 262631@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 59318ce6feee9ffa135d2c2979b291f526bf9c09 https://github.com/WebKit/WebKit/commit/59318ce6feee9ffa135d2c2979b291f526bf9c09 Author: Basuke Suzuki Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/NetworkProcess/NetworkProcess.cpp Log Message: --- [PlayStation] Fix build after 262631@main https://bugs.webkit.org/show_bug.cgi?id=255053 Unreviewed build fix. Service worker code was used without enable guard. * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::storeServiceWorkerRegistrations): Canonical link: https://commits.webkit.org/262638@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f31b51: Disable strict secure coding for PKPaymentSetupCon...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f31b514521f8772780bc413f8ab6faf6bdd6b210 https://github.com/WebKit/WebKit/commit/f31b514521f8772780bc413f8ab6faf6bdd6b210 Author: Alex Christensen Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm Log Message: --- Disable strict secure coding for PKPaymentSetupConfiguration https://bugs.webkit.org/show_bug.cgi?id=255052 rdar://107626990 Reviewed by Tim Horton. This undoes part of 262558@main until further investigation can happen. * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::encodeSecureCodingInternal): Canonical link: https://commits.webkit.org/262637@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4b5b02: More build fixes for ANGLE on embedded platforms
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4b5b02b509683ac9d75644be5a3909ee20a670e4 https://github.com/WebKit/WebKit/commit/4b5b02b509683ac9d75644be5a3909ee20a670e4 Author: Dean Jackson Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/ThirdParty/ANGLE/src/common/apple/apple_platform.h M Source/ThirdParty/ANGLE/src/common/apple_platform_utils.mm M Source/ThirdParty/ANGLE/src/common/platform.h M Source/ThirdParty/ANGLE/src/common/system_utils.cpp M Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp M Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_internal.h M Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_ios.cpp M Source/ThirdParty/ANGLE/src/libANGLE/Caps.cpp M Source/ThirdParty/ANGLE/src/libANGLE/Display.cpp M Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp M Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.cpp M Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.h M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/apple/DisplayApple_api.cpp M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ShaderMtl.mm M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm Log Message: --- More build fixes for ANGLE on embedded platforms https://bugs.webkit.org/show_bug.cgi?id=254933 rdar://107570491 Reviewed by Ken Russell. The change https://commits.webkit.org/262190@main fixed one build issue on watchOS, but uncovered more on other Apple embedded platforms. Sometimes there were branches of code not being compiled on anything but iOS and macOS. A lot of this comes from the slighting confusing way Apple defines targets in TargetConditionals.h. This patch is an attempt to make better sense of it, and apply it to ANGLE. The idea is that this will land first in WebKit, and if it doesn't break anything it will be posted to upstream ANGLE. Note that macOS Catalyst builds might require a followup. * Source/ThirdParty/ANGLE/src/common/apple/apple_platform.h: The meat of the patch is here. Add a new APPLE_EMBEDDED definition for iOS/watchOS/tvOS. Split the simulator out into its own definition. Everything below this is moving things to use the embedded path where needed. * Source/ThirdParty/ANGLE/src/common/apple_platform_utils.mm: (angle::IsMetalRendererAvailable): * Source/ThirdParty/ANGLE/src/common/platform.h: * Source/ThirdParty/ANGLE/src/common/system_utils.cpp: (angle::OpenSystemLibraryAndGetError): * Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp: (angle::OpenSystemLibraryWithExtensionAndGetError): * Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_internal.h: * Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_ios.cpp: * Source/ThirdParty/ANGLE/src/libANGLE/Caps.cpp: (gl::DetermineDepthTextureANGLESupport): (gl::DetermineDepthTextureOESSupport): * Source/ThirdParty/ANGLE/src/libANGLE/Display.cpp: (egl::GenerateClientExtensions): * Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp: (gl::BuildInternalFormatInfoMap): * Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.cpp: * Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.h: (rx::IsAppleEmbedded): (rx::IsIOS): Deleted. * Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/apple/DisplayApple_api.cpp: (rx::CreateDisplayCGLOrEAGL): * Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp: (rx::nativegl_gl::InitializeFeatures): * Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm: (rx::DisplayMtl::initializeExtensions const): * Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ShaderMtl.mm: (rx::ShaderMtl::compile): * Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm: (rx::mtl::GetSamplerAddressMode): Canonical link: https://commits.webkit.org/262636@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 34c241: [git pre-push] Prevent pushing commits for redacte...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 34c241927fad61ad952eea1bbddd205459f1a7a8 https://github.com/WebKit/WebKit/commit/34c241927fad61ad952eea1bbddd205459f1a7a8 Author: Jonathan Bedard Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Tools/Scripts/hooks/pre-push Log Message: --- [git pre-push] Prevent pushing commits for redacted issues https://bugs.webkit.org/show_bug.cgi?id=255043 rdar://107673301 Reviewed by Elliott Williams and Geoffrey Garen. Prevent pushing commits which reference redacted issues to public remotes unless: 1. Those commits are already on a public remote 2. Those commits cherry-pick a commit already on a public remote 3. Those commits reference an issue exempt from redaction Notably, this change removes the prompt allowing a user to override the guard against publishing a commit for a redacted issue. * Tools/Scripts/hooks/pre-push: Canonical link: https://commits.webkit.org/262635@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 88e75e: Tracker traffic is blocked even if user grants tra...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 88e75e6719920eb7ab21c91ec410047cdae48862 https://github.com/WebKit/WebKit/commit/88e75e6719920eb7ab21c91ec410047cdae48862 Author: Ben Nham Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/Scripts/process-entitlements.sh Log Message: --- Tracker traffic is blocked even if user grants tracking permission https://bugs.webkit.org/show_bug.cgi?id=254996 rdar://107359915 Reviewed by Wenson Hsieh. In trunk builds, tracker traffic is blocked even if the user grants tracking permissions via the ATT prompt. To fix this, we need to allow TCC to check for the kTCCServiceUserTracking permission via audit tokens. * Source/WebKit/Scripts/process-entitlements.sh: Canonical link: https://commits.webkit.org/262634@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 65b2e0: Media: Videos opening fullscreen via JS API have d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 65b2e06df85324883b2f5b62e035a4f474db3fa6 https://github.com/WebKit/WebKit/commit/65b2e06df85324883b2f5b62e035a4f474db3fa6 Author: Dean Jackson Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h M Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp M Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp M Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h Log Message: --- Media: Videos opening fullscreen via JS API have duplicated fullscreen controls https://bugs.webkit.org/show_bug.cgi?id=255012 rdar://103032343 Reviewed by Aditya Keerthi. We overlay native "exit fullscreen" and "PiP" buttons when we think they are necessary. However, our detection of necessity was slightly incorrect. When a element goes fullscreen, we always inject our default controls. They provide their own "exit fullscreen" button, so the native one is not necessary. We were assuming you needed to have the `controls` attribute on the video. While here, rename the member variable to be more clear that we're hiding two particular buttons, not the media controls as a whole. * Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::isVideoElement const): (WebKit::WebFullScreenManagerProxy::enterFullScreen): (WebKit::WebFullScreenManagerProxy::isVideoElementWithControls const): Deleted. * Source/WebKit/UIProcess/WebFullScreenManagerProxy.h: * Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in: * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h: * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController initWithWebView:]): (-[WKFullScreenViewController videoControlsManagerDidChange]): (-[WKFullScreenViewController hideCancelAndPIPButtons:]): (-[WKFullScreenViewController hideMediaControls:]): Deleted. * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController enterFullScreen:]): * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::enterFullScreenForElement): * Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp: (WebKit::InjectedBundlePageFullScreenClient::enterFullScreenForElement): * Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h: Canonical link: https://commits.webkit.org/262632@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e35ce: Migrate ServiceWorkerRegistration data to origin d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e35cedbb5b8c4d52b35faccb1b0b2ac7b619878 https://github.com/WebKit/WebKit/commit/1e35cedbb5b8c4d52b35faccb1b0b2ac7b619878 Author: Sihui Liu Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/WebCorePersistentCoders.cpp M Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h M Source/WebCore/workers/service/ServiceWorkerTypes.h M Source/WebCore/workers/service/server/RegistrationDatabase.cpp M Source/WebCore/workers/service/server/RegistrationDatabase.h M Source/WebCore/workers/service/server/RegistrationStore.cpp M Source/WebCore/workers/service/server/RegistrationStore.h A Source/WebCore/workers/service/server/SWRegistrationDatabase.cpp A Source/WebCore/workers/service/server/SWRegistrationDatabase.h A Source/WebCore/workers/service/server/SWRegistrationStore.h M Source/WebCore/workers/service/server/SWServer.cpp M Source/WebCore/workers/service/server/SWServer.h M Source/WebCore/workers/service/server/SWServerDelegate.h M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/NetworkProcess/NetworkProcess.h M Source/WebKit/NetworkProcess/NetworkProcess.messages.in M Source/WebKit/NetworkProcess/NetworkSession.cpp M Source/WebKit/NetworkProcess/NetworkSession.h A Source/WebKit/NetworkProcess/ServiceWorker/WebSWRegistrationStore.cpp A Source/WebKit/NetworkProcess/ServiceWorker/WebSWRegistrationStore.h M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h M Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp M Source/WebKit/NetworkProcess/storage/OriginStorageManager.h A Source/WebKit/NetworkProcess/storage/ServiceWorkerStorageManager.cpp A Source/WebKit/NetworkProcess/storage/ServiceWorkerStorageManager.h M Source/WebKit/Sources.txt M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKitCocoa/Badging.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm Log Message: --- Migrate ServiceWorkerRegistration data to origin directory https://bugs.webkit.org/show_bug.cgi?id=254771 rdar://106385894 Reviewed by Youenn Fablet. ServiceWorkerRegistration data is currently placed in Caches directory by default (see WebsiteDataStore::defaultServiceWorkerRegistrationDirectory), which means ServiceWorker registrations could be deleted by system. To avoid that, we should move it to a non-Caches directory. To make ServiceWorkerRegistration aligned with other storage types like CacheStorage and IndexedDB, this patch adds functions to migrate ServiceWorkerRegistration data to origin directory. Origin directory is managed by OriginStorageManager, so for accessing ServiceWorkerRegistration data, SWServer will need to talk to OriginStorageManager, or NetworkStorageManager (the owner of OriginStorageManager). This is implemented by replacing RegistrationStore with SWRegistrationStore, and having SWRegistrationStore (implemented in WebSWRegistrationStore) pointing to NetworkStorageManager. A new class ServiceWorkerStorageManager is added to manage ServiceWorkerRegistration data of one "partition". Before migration, ServiceWorkerRegistration has one database for all origins (i.e. there is only one "partition" for all origins), so NetworkStorageManager owns a ServiceWorkerStorageManager. After migration, each origin has a database (i.e. there is one "partition" per origin), so each OriginStorageManager owns a ServiceWorkerStorageManager and thus a SWRegistrationDatabase. SWRegistrationDatabase is the single-thread version of the existing RegistrationDatabase, because ServiceWorkerStorageManager only runs on WorkQueue of NetworkStorageManager. New test: WKWebsiteDataStore.MigrateServiceWorkerRegistrationToGeneralStorageDirectory * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/WebCorePersistentCoders.cpp: * Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h: * Source/WebCore/workers/service/ServiceWorkerTypes.h: (WebCore::ServiceWorkerScripts::isolatedCopy const): * Source/WebCore/workers/service/server/RegistrationDatabase.cpp: (WebCore::recordsTableSchema): Deleted.
[webkit-changes] [WebKit/WebKit] ff31bb: Configuring Xcode 14.3 for Embedded Development Fails
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ff31bbc0bcd40b66a0397e13428e553d282a4359 https://github.com/WebKit/WebKit/commit/ff31bbc0bcd40b66a0397e13428e553d282a4359 Author: Chris Gibb Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Tools/Scripts/configure-xcode-for-embedded-development Log Message: --- Configuring Xcode 14.3 for Embedded Development Fails https://bugs.webkit.org/show_bug.cgi?id=255038 rdar://107664570 Reviewed by Jonathan Bedard. Configuring Xcode for embedded development fails in Xcode 14.3 due to changes to XCBSpecifications. * Tools/Scripts/configure-xcode-for-embedded-development: Canonical link: https://commits.webkit.org/262630@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 56f0f4: Enable GPU Process and UI side compositing on macOS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 56f0f4203278a87bd40c7509d28c5c1ed61d0568 https://github.com/WebKit/WebKit/commit/56f0f4203278a87bd40c7509d28c5c1ed61d0568 Author: Ryosuke Niwa Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WTF/wtf/PlatformEnable.h M Source/WebKit/UIProcess/mac/WebViewImpl.mm M Tools/MiniBrowser/mac/SettingsController.m M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py M Tools/Scripts/webkitpy/port/driver.py M Tools/WebKitTestRunner/Options.cpp M Tools/WebKitTestRunner/TestOptions.cpp M Tools/WebKitTestRunner/TestOptions.h M Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm M Tools/WebKitTestRunner/mac/main.mm Log Message: --- Enable GPU Process and UI side compositing on macOS https://bugs.webkit.org/show_bug.cgi?id=254725 Reviewed by Simon Fraser. Enable GPU process for DOM rendering and UI side compositing by default on macOS. Also add options to disable these two features to run-webkit-tests. * Source/WTF/wtf/PlatformEnable.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::WebViewImpl): * Tools/MiniBrowser/mac/SettingsController.m: (-[SettingsController useUISideCompositing]): * Tools/Scripts/webkitpy/api_tests/runner.py: (Runner.command_for_port): * Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): * Tools/Scripts/webkitpy/port/driver.py: (Driver.cmd_line): * Tools/WebKitTestRunner/Options.cpp: (WTR::handleOptionNoRemoteLayerTree): (WTR::OptionsHandler::OptionsHandler): * Tools/WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): * Tools/WebKitTestRunner/TestOptions.h: (WTR::TestOptions::noUseRemoteLayerTree const): * Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): * Tools/WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting): Canonical link: https://commits.webkit.org/262629@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f81910: Add RELEASE_LOG_FAULT when message checks fail in ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f819105a66b163d6d9ef03c93dd38596a9c14174 https://github.com/WebKit/WebKit/commit/f819105a66b163d6d9ef03c93dd38596a9c14174 Author: Alex Christensen Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.cpp Log Message: --- Add RELEASE_LOG_FAULT when message checks fail in service worker and shared worker connections https://bugs.webkit.org/show_bug.cgi?id=255037 rdar://107665814 Reviewed by Youenn Fablet. This will help us notice and fix problems based on telemetry and logs. * Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp: * Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.cpp: Canonical link: https://commits.webkit.org/262628@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b15ce8: Make sure isLatin1() is a no-op for LChar characters
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b15ce8abf9daed95e5b7a4b8f172ae024c942428 https://github.com/WebKit/WebKit/commit/b15ce8abf9daed95e5b7a4b8f172ae024c942428 Author: Chris Dumez Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WTF/wtf/text/StringCommon.h Log Message: --- Make sure isLatin1() is a no-op for LChar characters https://bugs.webkit.org/show_bug.cgi?id=255040 rdar://107666559 Reviewed by Mark Lam. * Source/WTF/wtf/text/StringCommon.h: (WTF::isLatin1): Canonical link: https://commits.webkit.org/262627@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 44a09b: Revert 262184@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 44a09b4e75e2b71681fec3205c182d28edae67b2 https://github.com/WebKit/WebKit/commit/44a09b4e75e2b71681fec3205c182d28edae67b2 Author: Tim Horton Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm Log Message: --- Revert 262184@main https://bugs.webkit.org/show_bug.cgi?id=255041 rdar://107624168 Unreviewed revert. * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: (WebKit::RemoteLayerBackingStoreProperties::applyBackingStoreToLayer): Canonical link: https://commits.webkit.org/262626@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40ad31: Deduplicate headers in generated GeneratedSerializ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40ad311960214102f5e5b80de441cfa280598b76 https://github.com/WebKit/WebKit/commit/40ad311960214102f5e5b80de441cfa280598b76 Author: Sihui Liu Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h M Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp M Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in Log Message: --- Deduplicate headers in generated GeneratedSerializers file https://bugs.webkit.org/show_bug.cgi?id=254547 rdar://107283996 Reviewed by Alex Christensen. Use dictionary and set to avoid including a header multiple times in generated file. * Source/WebKit/Scripts/generate-serializers.py: (ConditionalHeader.__eq__): (ConditionalHeader): (ConditionalHeader.__hash__): (main): * Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp: (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): * Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h: * Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp: (WebKit::allSerializedTypes): * Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in: Canonical link: https://commits.webkit.org/262625@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f70e21: [GTK] gardening: fast/repaint/vertical-text-repain...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f70e214ed34187d63777ec8542ab3282ec0e5f67 https://github.com/WebKit/WebKit/commit/f70e214ed34187d63777ec8542ab3282ec0e5f67 Author: Amanda Falke Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: R LayoutTests/platform/gtk/fast/repaint/vertical-text-repaint-expected.txt Log Message: --- [GTK] gardening: fast/repaint/vertical-text-repaint.html Unreviewed test gardening When we updated LayoutTest baseline for this test in commit 260008@main to address some regressions, we forgot to also update GTK port expectation. We *could* fix it by duplicating LayoutTest file into GTK platform, but that would be duplicated code, so instead, just deleting the file to simplify. Test now passes. * LayoutTests/platform/gtk/fast/repaint/vertical-text-repaint-expected.txt: Removed. Canonical link: https://commits.webkit.org/262624@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 48bfdb: Enable fetch priority hints by default
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 48bfdb0c90531bb6754a703f5a29bb90f63055b3 https://github.com/WebKit/WebKit/commit/48bfdb0c90531bb6754a703f5a29bb90f63055b3 Author: Youenn Fablet Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Enable fetch priority hints by default https://bugs.webkit.org/show_bug.cgi?id=255008 rdar://problem/107630350 Reviewed by Alex Christensen. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/262623@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8be9b9: AcceleratedSurfaceDMABuf: clean up configuration a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8be9b9b191ebd20578da7f8b77c615ab0d1554f6 https://github.com/WebKit/WebKit/commit/8be9b9b191ebd20578da7f8b77c615ab0d1554f6 Author: Žan Doberšek Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.messages.in M Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp Log Message: --- AcceleratedSurfaceDMABuf: clean up configuration arguments https://bugs.webkit.org/show_bug.cgi?id=254994 Reviewed by Adrian Perez de Castro. Adjust the arguments of the AcceleratedBackingStoreDMABuf::Configure message. The size value, kept as an IntSize, is put earlier in the order, fourcc is renamed to format, and format, stride and offset values are changed to the uint32_t type. This subsequently propagates further across the class. * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp: (WebKit::AcceleratedBackingStoreDMABuf::Texture::Texture): (WebKit::AcceleratedBackingStoreDMABuf::Surface::Surface): (WebKit::AcceleratedBackingStoreDMABuf::configure): (WebKit::AcceleratedBackingStoreDMABuf::createSource): * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h: * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.messages.in: * Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp: (WebKit::AcceleratedSurfaceDMABuf::clientResize): Canonical link: https://commits.webkit.org/262622@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 284a4d: Unreviewed, remove some dead code from the HTML fa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 284a4d7819bbda8e90bcbdbcf9d1e3c9f9202905 https://github.com/WebKit/WebKit/commit/284a4d7819bbda8e90bcbdbcf9d1e3c9f9202905 Author: Chris Dumez Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp Log Message: --- Unreviewed, remove some dead code from the HTML fast parser https://bugs.webkit.org/show_bug.cgi?id=255032 rdar://107659867 * Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp: Canonical link: https://commits.webkit.org/262621@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d5d5bd: Remote Web Inspector: Send the `presentingApplicat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d5d5bd30a02deea1a39d7235f31a0bf3fee5cdd4 https://github.com/WebKit/WebKit/commit/d5d5bd30a02deea1a39d7235f31a0bf3fee5cdd4 Author: Patrick Angle Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.cpp M Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.h M Source/JavaScriptCore/inspector/remote/RemoteInspector.h M Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Remote Web Inspector: Send the `presentingApplicationPID` to the relay process for WKWebViews https://bugs.webkit.org/show_bug.cgi?id=254537 rdar://105636143 Reviewed by BJ Burg. In some cases, a process may create WKWebViews on behalf of another process to be served remotely. WKWebViews inspectability is managed in the UI process, and those does not currently use the `presentingApplicationPID` to associate a target with a specific parent process (a process may represent multiple parent processes at a time). We thus need to provide target-specific PIDs for the presenting application so that WKWebViews are correctly related back to the application that is showing the web content via the intermediate remote service that actually created the WKWebView. * Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.cpp: (Inspector::RemoteInspectionTarget::setPresentingApplicationPID): * Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.h: - Allow setting a per-target `presentingApplicationPID` as an alternative to having a single PID the entire process proxies its inspectable content to. * Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm: (Inspector::identifierForPID): (Inspector::RemoteInspector::listingForInspectionTarget const): - Provide a per-target presenting application PID so that individual web views can be associated the appropriate process. Relays should use this value in place of the application-wide parent process PID when it is present. For WKWebView, those values will be equal by default unless explicitly set. (Inspector::RemoteInspector::receivedProxyApplicationSetupMessage): - Proxy apps don't need to respond to the proxy setup message, since all the necessary information will be provided with the application's listing of targets. * Source/WebKit/UIProcess/WebPageProxy.cpp: - Use the `presentingApplicationPID` of the web content process pool to inform associate the inspectable page with the correct parent application, since that is the pool that the content to be inspected will actually exist in. Unless it has been overriden, this will be the PID of the UI process. Canonical link: https://commits.webkit.org/262620@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] de96a0: Use generated code in ReferrerPolicy.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: de96a0b36261b247a4c939e0aee98323e50114c8 https://github.com/WebKit/WebKit/commit/de96a0b36261b247a4c939e0aee98323e50114c8 Author: Rob Buis Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebCore/platform/ReferrerPolicy.cpp Log Message: --- Use generated code in ReferrerPolicy.cpp https://bugs.webkit.org/show_bug.cgi?id=252962 Reviewed by Youenn Fablet. Code used for serializing ReferrerPolicy is generated in JSReferrerPolicy, use that instead of the current custom code in ReferrerPolicy.cpp. * Source/WebCore/platform/ReferrerPolicy.cpp: (WebCore::referrerPolicyToString): Canonical link: https://commits.webkit.org/262619@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 700cb2: [git-webkit] Clarify fork relationship in creation...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 700cb2cd643542227eb68ab6ed79491efeb87289 https://github.com/WebKit/WebKit/commit/700cb2cd643542227eb68ab6ed79491efeb87289 Author: Jonathan Bedard Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Tools/Scripts/libraries/webkitscmpy/setup.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py Log Message: --- [git-webkit] Clarify fork relationship in creation prompt https://bugs.webkit.org/show_bug.cgi?id=254531 rdar://107271252 Reviewed by Aakash Jain. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py: (Setup.github): Include both owner and repository name when describing the repository git-webkit is creating a fork of. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py: (TestSetup.test_github): Canonical link: https://commits.webkit.org/262618@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e7a136: [git-webkit] Provide mechanism to exempt bugs from...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e7a1365dc511795c1924d5248d10397aacf02604 https://github.com/WebKit/WebKit/commit/e7a1365dc511795c1924d5248d10397aacf02604 Author: Jonathan Bedard Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Tools/Scripts/hooks/pre-push M Tools/Scripts/libraries/webkitbugspy/setup.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tracker.py M Tools/Scripts/libraries/webkitscmpy/setup.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py M metadata/trackers.json Log Message: --- [git-webkit] Provide mechanism to exempt bugs from redaction https://bugs.webkit.org/show_bug.cgi?id=254993 rdar://107615755 Reviewed by Geoffrey Garen. It is often the case that we with to (eventually) publish changes which are redacted when they are written. git-webkit should support a mechanism to mark bugs (and by extension, the commits associated with those bug) as exempt from redaction. * Tools/Scripts/hooks/pre-push: Do not flag class 3 commits if an issue is exempt from redaction. * Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py: (Tracker.__init__): Pass redact_exemption. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py: (Tracker.__init__): Pass redact_exemption. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py: (Issue.redacted): Check if an issue is exempt from redaction. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py: (Tracker.__init__): Pass redact_exemption. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py: * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py: * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py: * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tracker.py: (Tracker.Redaction): Support defining a redaction exemption. (Tracker.from_json): Pass redact_exemption. (Tracker.__init__): Ditto. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py: (PullRequest.create_pull_request): * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py: * metadata/trackers.json: Exempt radars with the 'WebKit Cleared for Publication' keyword. Canonical link: https://commits.webkit.org/262617@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a11cf: Cherry-pick 262573@main (c48d7192b129). https://bu...
Branch: refs/heads/webkitglib/2.40 Home: https://github.com/WebKit/WebKit Commit: 3a11cf01b0e2dcc7db44fc5d1dcb9e6b643f2ba7 https://github.com/WebKit/WebKit/commit/3a11cf01b0e2dcc7db44fc5d1dcb9e6b643f2ba7 Author: Ryosuke Niwa Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: A LayoutTests/fast/shadow-dom/selection-collapse-expected.txt A LayoutTests/fast/shadow-dom/selection-collapse.html M Source/WebCore/page/DOMSelection.cpp Log Message: --- Cherry-pick 262573@main (c48d7192b129). https://bugs.webkit.org/show_bug.cgi?id=254957 REGRESSION(259904@main): Comment editor on huffpost.com doesn't update the caret position after inserting new line https://bugs.webkit.org/show_bug.cgi?id=254957 Reviewed by Wenson Hsieh. The bug was caused by DOMSelection::collapse exiting early due to the node being inside a shadow tree. When live range selection is enabled, we exit early if frame->document()->contains(*node) isn’t true. Fixed the bug by relaxing this restriction to allow a connected node of the same document. This patch also relaxes the same restriction on DOMSelection::extend. * LayoutTests/fast/shadow-dom/selection-collapse-expected.txt: Added. * LayoutTests/fast/shadow-dom/selection-collapse.html: Added. * Source/WebCore/page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): Fixed the bug by relaxing the condition for an early exit when selectionAPIForShadowDOMEnabled returns true. Also made the check slightly more efficient by avoiding the tree walk to find the root node in most cases. (WebCore::DOMSelection::extend): Ditto. Canonical link: https://commits.webkit.org/262573@main Commit: 768963a39cda2396c5d8190db8db5a3996435c7d https://github.com/WebKit/WebKit/commit/768963a39cda2396c5d8190db8db5a3996435c7d Author: Ryosuke Niwa Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/editing/other/editable-state-and-focus-in-shadow-dom-in-designMode.tentative-expected.txt M Source/WebCore/html/HTMLElement.cpp Log Message: --- Cherry-pick 262563@main (155c4f42d9ef). https://bugs.webkit.org/show_bug.cgi?id=254966 designMode should not affect shadow tree https://bugs.webkit.org/show_bug.cgi?id=254966 Reviewed by Wenson Hsieh. Even when the document is in design mode, its shadow trees shouldn't be considered as editable. * LayoutTests/imported/w3c/web-platform-tests/editing/other/editable-state-and-focus-in-shadow-dom-in-designMode.tentative-expected.txt: * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::editabilityFromContentEditableAttr): Canonical link: https://commits.webkit.org/262563@main Compare: https://github.com/WebKit/WebKit/compare/988cb56ec61c...768963a39cda ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fead01: Support Apple Pay in cross-origin iframes with all...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fead01e13ad2f5837324865b19f30607383d410c https://github.com/WebKit/WebKit/commit/fead01e13ad2f5837324865b19f30607383d410c Author: Javier López Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M LayoutTests/http/tests/paymentrequest/payment-allow-attribute.https-expected.txt M Source/WebCore/Modules/applepay/PaymentSession.cpp Log Message: --- Support Apple Pay in cross-origin iframes with allow=payment attribute https://bugs.webkit.org/show_bug.cgi?id=226345 Reviewed by Dean Jackson. This bug happens because there is a check for the parentDocument to have the same security origin than the child document, contrary to what the [Payment Request API spec from W3 states](https://www.w3.org/TR/payment-request/#using-with-cross-origin-iframes). The solution is to remove the check for the same parentDocument origin. * LayoutTests/http/tests/paymentrequest/payment-allow-attribute.https-expected.txt: - Update tests according to new behavior * Source/WebCore/Modules/applepay/PaymentSession.cpp: (PaymentSession::canCreateSession): - Remove check for same parent origin since we have allow payment check before Canonical link: https://commits.webkit.org/262616@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 988cb5: Unreviewed non-unified build fixes.
Branch: refs/heads/webkitglib/2.40 Home: https://github.com/WebKit/WebKit Commit: 988cb56ec61c140431d9b93c7d9699eb5fa7925b https://github.com/WebKit/WebKit/commit/988cb56ec61c140431d9b93c7d9699eb5fa7925b Author: Adrian Perez de Castro Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/JavaScriptCore/b3/B3Const128Value.cpp M Source/WebCore/Modules/push-api/PushMessageData.cpp M Source/WebCore/Modules/webaudio/AudioBuffer.h M Source/WebCore/animation/KeyframeEffect.cpp M Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/page/PerformanceMark.cpp Log Message: --- Unreviewed non-unified build fixes. * Source/JavaScriptCore/b3/B3Const128Value.cpp: Add missing B3ValueInlines.h header inclusion, and replace B3Procedure.h with B3ProcedureInlines.h, which includes the former transitively as well. * Source/WebCore/Modules/push-api/PushMessageData.cpp: Add missing JavaScriptCore/JSCJSValueInlines.h header inclusion. * Source/WebCore/Modules/webaudio/AudioBuffer.h: Replace inclusion of JavaScriptCore/TypedArrayAdaptersForwardDeclarations.h with the GenericTypedArrayView.h header. * Source/WebCore/animation/KeyframeEffect.cpp: Add missing DocumentInlines.h header inclusion. * Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp: Add missing JavaScriptCore/AbstractSlotVisitorInlines.h and JavaScriptCore/JSCJSValueInlines.h header inclusions. * Source/WebCore/css/parser/CSSPropertyParser.cpp: Add missing CSSQuadValue.h inclusion. * Source/WebCore/page/PerformanceMark.cpp: Add missing JavaScriptCore/JSCJSValueInlines.h header inclusion. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 688752: Enable new WebGL conformance tests, conformance/{p...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 688752e2f646a39b38b78bd1f73f4b96e65ba2ef
https://github.com/WebKit/WebKit/commit/688752e2f646a39b38b78bd1f73f4b96e65ba2ef
Author: Kimmo Kinnunen
Date: 2023-04-05 (Wed, 05 Apr 2023)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/gtk-wayland/TestExpectations
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/ios-simulator/TestExpectations
M LayoutTests/platform/ios-wk2/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
M LayoutTests/platform/mac/TestExpectations
M LayoutTests/platform/wincairo/TestExpectations
M LayoutTests/platform/wpe/TestExpectations
Log Message:
---
Enable new WebGL conformance tests,
conformance/{programs,reading,renderbuffers,rendering}
https://bugs.webkit.org/show_bug.cgi?id=254804
rdar://107462499
Reviewed by Tim Horton.
Enable subset of webgl/1.0.x, webgl/2.0.y and disable old tests.
* LayoutTests/TestExpectations:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/gtk-wayland/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/ios-wk2/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/platform/wincairo/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
Canonical link: https://commits.webkit.org/262615@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2cd8ae: AX: Make AccessibilityNodeObject::m_node hold a We...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2cd8ae7e10eaf832abdf698c3701dde4990fe045 https://github.com/WebKit/WebKit/commit/2cd8ae7e10eaf832abdf698c3701dde4990fe045 Author: Tyler Wilcock Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebCore/accessibility/AccessibilityNodeObject.cpp M Source/WebCore/accessibility/AccessibilityNodeObject.h Log Message: --- AX: Make AccessibilityNodeObject::m_node hold a WeakPtr https://bugs.webkit.org/show_bug.cgi?id=255005 rdar://107589983 Reviewed by Chris Fleizach. Let's bring AccessibilityNodeObject in line with https://github.com/WebKit/WebKit/wiki/Smart-Pointer-Usage-Guidelines to improve memory safety. * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::addChildren): (WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored const): (WebCore::AccessibilityNodeObject::correspondingLabelForControlElement const): (WebCore::AccessibilityNodeObject::labelElementContainer const): (WebCore::AccessibilityNodeObject::exposesTitleUIElement const): (WebCore::AccessibilityNodeObject::description const): (WebCore::AccessibilityNodeObject::isFocused const): (WebCore::AccessibilityNodeObject::setFocused): * Source/WebCore/accessibility/AccessibilityNodeObject.h: Canonical link: https://commits.webkit.org/262614@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f37c05: Refactor PlatformCALayer to support finishing the ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f37c05e1232e7be8dca7ddebe2003a9b1d75948c https://github.com/WebKit/WebKit/commit/f37c05e1232e7be8dca7ddebe2003a9b1d75948c Author: Kimmo Kinnunen Date: 2023-04-04 (Tue, 04 Apr 2023) Changed paths: M Source/WebCore/PlatformMac.cmake M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj R Source/WebCore/html/canvas/GPUCanvasContextCocoa.cpp M Source/WebCore/html/canvas/GPUCanvasContextCocoa.h A Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm R Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp M Source/WebCore/platform/graphics/ca/PlatformCALayer.h A Source/WebCore/platform/graphics/ca/PlatformCALayer.mm A Source/WebCore/platform/graphics/ca/PlatformCALayerDelegatedContents.h M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm M Source/WebCore/platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm M Source/WebKit/SourcesCocoa.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm R Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h A Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.mm M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm Log Message: --- Refactor PlatformCALayer to support finishing the delegated layer contents before compositing https://bugs.webkit.org/show_bug.cgi?id=254988 rdar://107605713 Reviewed by Simon Fraser. The WebKit compositor should wait for WebGL / WebGPU content to be finished before proceeding to send that to the system compositor. Otherwise slow WebGL content slows down the system user interface. Refactor "delegated contents" feature of PlatformCALayer to be able to pass objects that allow to do the above. The structure will be: - Each layer, i.e. WebGL or WebGPU context, has a Metal shared event that can be waited on. - Each submitted frame, i.e. IOSurface, will be ready to be composited only after the shared event has received a signal with the "finished identifier". Refactor the PlatformCALayer to support the above, but do not introduce any new functionality in this patch. Since Metal shared event is id, Obj-C protocol, the code that uses definitions of new structs in PlatformCALayerDelegatedContents.h needs to also be real Obj-C code. - Renames previously C++ caller GPUCanvasContextCocoa.cpp to GPUCanvasContextCocoa.mm - Renames previously C++ callee PlatformCALayer.cpp to PlatformCALayer.mm * Source/WebCore/PlatformMac.cmake: * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/html/canvas/GPUCanvasContextCocoa.h: * Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm: Renamed from Source/WebCore/html/canvas/GPUCanvasContextCocoa.cpp. (WebCore::GPUCanvasContext::create): (WebCore::GPUCanvasContextCocoa::create): (WebCore::presentationContextDescriptor): (WebCore::getCanvasWidth): (WebCore::getCanvasHeight): (WebCore::GPUCanvasContextCocoa::GPUCanvasContextCocoa): (WebCore::GPUCanvasContextCocoa::reshape): (WebCore::GPUCanvasContextCocoa::canvas): (WebCore::GPUCanvasContextCocoa::configure): (WebCore::GPUCanvasContextCocoa::unconfigure): (WebCore::GPUCanvasContextCocoa::getCurrentTexture): (WebCore::GPUCanvasContextCocoa::pixelFormat const): (WebCore::GPUCanvasContextCocoa::colorSpace const): (WebCore::GPUCanvasContextCocoa::layerContentsDisplayDelegate): (WebCore::GPUCanvasContextCocoa::prepareForDisplay): (WebCore::GPUCanvasContextCocoa::markContextChangedAndNotifyCanvasObservers): * Source/WebCore/platform/graphics/ca/PlatformCALayer.h: * Source/WebCore/platform/graphics/ca/PlatformCALayer.mm: Renamed from Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp. (WebCore::PlatformCALayer::PlatformCALayer): (WebCore::PlatformCALayer::~PlatformCALayer): (WebCore::PlatformCALayer::currentTimeToMediaTime): (WebCore::PlatformCALayer::canHaveBackingStore const): (WebCore::PlatformCALayer::drawRepaintIndicator): (WebCore::PlatformCALayer::flipContext): (WebCore::PlatformCALayer::drawTextAtPoint const): (WebCore::PlatformCALayer::createCompatibleLayerOrTakeFromPool): (WebCore::PlatformCALayer::moveToLayerPool): (WebCore::PlatformCALayer::layerPool): (WebCore::PlatformCALayer::clearContents): (WebCore::PlatformCALayer::setDelegatedContentsFinishedEvent): (WebCore::PlatformCALayer::setDelegatedContents): (WebCore::PlatformCALayer::clearAcceleratedEffectsAndBaseValues): (WebCore::PlatformCALayer::setAcceleratedEffectsAndBaseValues):
[webkit-changes] [WebKit/WebKit] 424d19: Use fixed-size deadCells vector in MarkedBlock::sweep
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 424d1996eedf829b94d9593ed1a4288994bf43f1 https://github.com/WebKit/WebKit/commit/424d1996eedf829b94d9593ed1a4288994bf43f1 Author: David Degazio Date: 2023-04-04 (Tue, 04 Apr 2023) Changed paths: M Source/JavaScriptCore/heap/MarkedBlock.h M Source/JavaScriptCore/heap/MarkedBlockInlines.h Log Message: --- Use fixed-size deadCells vector in MarkedBlock::sweep https://bugs.webkit.org/show_bug.cgi?id=254960 rdar://107585451 Reviewed by Justin Michaud and Yusuke Suzuki. Allocates the deadCells vector in MarkedBlock::specializedSweep entirely on the stack, and stores atom numbers using uint16_t instead of uint64_t. Should reduce allocations and potentially improve locality. * Source/JavaScriptCore/heap/MarkedBlockInlines.h: (JSC::MarkedBlock::Handle::specializedSweep): Canonical link: https://commits.webkit.org/262612@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 45b46f: Unreviewed gardening for ChakraCore tests on Win JSC
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 45b46fd412b4ed1555bb417fdc1f556bb2b16df8 https://github.com/WebKit/WebKit/commit/45b46fd412b4ed1555bb417fdc1f556bb2b16df8 Author: Ross Kirsling Date: 2023-04-04 (Tue, 04 Apr 2023) Changed paths: M JSTests/ChakraCore.yaml A JSTests/ChakraCore/test/es5/hasItem.baseline-jsc-windows Log Message: --- Unreviewed gardening for ChakraCore tests on Win JSC https://bugs.webkit.org/show_bug.cgi?id=255019 Renable various tests and add a Win-specific expectation. (The latter wouldn't be necessary if we could easily `diff -a` against the existing JSC baseline, but adding a platform-specific expectation seems less complicated. It's weird that the test is using binary output anyway.) * JSTests/ChakraCore.yaml: * JSTests/ChakraCore/test/es5/hasItem.baseline-jsc-windows: Added. Canonical link: https://commits.webkit.org/262611@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
