[webkit-changes] [WebKit/WebKit] e75e72: Add runInCrossOriginIFrame TestOption for WebKitTe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e75e728228a424bc650bc91d343e584c387edaf3 https://github.com/WebKit/WebKit/commit/e75e728228a424bc650bc91d343e584c387edaf3 Author: Pascoe Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Tools/WebKitTestRunner/TestInvocation.cpp M Tools/WebKitTestRunner/TestOptions.cpp M Tools/WebKitTestRunner/TestOptions.h Log Message: --- Add runInCrossOriginIFrame TestOption for WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=265984 rdar://problem/11922 Reviewed by Jonathan Bedard. This adds a WebKitTestRunner option to run a test in a cross-origin i-frame. This enables the output of a given test to be compared with the output of the test in a site isolated cross-origin i-frame by using run-webkit-tests --self-compare-with-header='SiteIsolationEnabled=true runInCrossOriginIFrame=true' ... * Tools/WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): * Tools/WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): (WTR::TestOptions::keyTypeMapping): * Tools/WebKitTestRunner/TestOptions.h: (WTR::TestOptions::runInCrossOriginIFrame const): Canonical link: https://commits.webkit.org/271718@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 62a9e5: [WebXR] Transient input source for immersive AR se...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 62a9e5aae1b4a74508539a653611e1be59c526f3 https://github.com/WebKit/WebKit/commit/62a9e5aae1b4a74508539a653611e1be59c526f3 Author: Dan Glastonbury Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj A Source/WebCore/PAL/pal/spi/cocoa/ARKitSPI.h M Source/WebKit/Shared/Cocoa/ARKitSoftLink.h M Source/WebKit/Shared/Cocoa/ARKitSoftLink.mm M Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.mm M Source/WebKit/UIProcess/XR/ios/WKARPresentationSession.h M Source/WebKit/UIProcess/XR/ios/WKARPresentationSession.mm Log Message: --- [WebXR] Transient input source for immersive AR sessions https://bugs.webkit.org/show_bug.cgi?id=266045 rdar://119348536 Reviewed by Dean Jackson. Now that we support rendering of immersive AR sessions, we need a way to interact with them. This implementation of `transient-pointer`, based upon immersive VR, translates basic touch interactions into target rays derived from shooting a ray from the ARCamera position through the touch position in world space. Introduce a _WKTransientGestureRecognizer that can generate `transient-pointer` events from UITouch, and attach an instance of that gesture recognizer to the main view for the immersive AR session. Access to events is provided via -[WKARPresentationSession collectInputSources], which provides transient actions suitable for passing to PlatformXR::Device::FrameData::inputSources * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/PAL/pal/spi/cocoa/ARKitSPI.h: Copied from Source/WebKit/Shared/Cocoa/ARKitSoftLink.h. * Source/WebKit/Shared/Cocoa/ARKitSoftLink.h: * Source/WebKit/Shared/Cocoa/ARKitSoftLink.mm: * Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.mm: (WebKit::ARKitCoordinator::renderLoop): * Source/WebKit/UIProcess/XR/ios/WKARPresentationSession.h: * Source/WebKit/UIProcess/XR/ios/WKARPresentationSession.mm: (-[UITouch normalizedLocationInView:]): (-[_WKARPresentationSession raycastQueryTransformFromPoint:]): (-[_WKARPresentationSession collectInputSources]): (-[_WKARPresentationSession gestureRecognizer:shouldReceiveTouch:]): (-[_WKARPresentationSession loadView]): (-[_WKTransientAction initWithTargetRay:pose:]): (-[_WKTransientGestureRecognizer initWithSession:]): (-[_WKTransientGestureRecognizer touchesBegan:withEvent:]): (-[_WKTransientGestureRecognizer touchesMoved:withEvent:]): (-[_WKTransientGestureRecognizer touchesEnded:withEvent:]): (-[_WKTransientGestureRecognizer touchesCancelled:withEvent:]): (-[_WKTransientGestureRecognizer _doneWithTouch:]): (-[_WKTransientGestureRecognizer _platformXRInputSourceFromTransientAction:actionIdentifier:]): (-[_WKTransientGestureRecognizer collectInputSources]): Canonical link: https://commits.webkit.org/271717@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b8b425: [Gardening] Update 'disabled-event-dispatch.tentat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b8b425ed2bb398b0ba3713015e461548a5439431 https://github.com/WebKit/WebKit/commit/b8b425ed2bb398b0ba3713015e461548a5439431 Author: Ahmad Saleem Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M LayoutTests/platform/ios-simulator-16-wk2/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt Log Message: --- [Gardening] Update 'disabled-event-dispatch.tentative.html' test expectation on 'ios-simulator-16-wk2' https://bugs.webkit.org/show_bug.cgi?id=266008 Reviewed by Tim Nguyen. This PR is to fix platform specific test expectation, which was not shown during initial commit. * LayoutTests/platform/ios-simulator-16-wk2/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/271716@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ec8318: Fix clean build after 271710@main and 271709@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec8318b87d24964bac6308eaf14a70e1bb9db678 https://github.com/WebKit/WebKit/commit/ec8318b87d24964bac6308eaf14a70e1bb9db678 Author: Alex Christensen Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist Log Message: --- Fix clean build after 271710@main and 271709@main https://bugs.webkit.org/show_bug.cgi?id=266059 rdar://119357604 Unreviewed. They added new derived sources input but didn't add it to Xcode's list. * Source/WebKit/DerivedSources-input.xcfilelist: Canonical link: https://commits.webkit.org/271715@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4e1abb: Make rebind::other explicit in FastAllocator
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4e1abb6514cdc2bf301e5ea4f299c139faa0b2ff https://github.com/WebKit/WebKit/commit/4e1abb6514cdc2bf301e5ea4f299c139faa0b2ff Author: Ross Kirsling Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WTF/wtf/FastMalloc.h Log Message: --- Make rebind::other explicit in FastAllocator https://bugs.webkit.org/show_bug.cgi?id=265933 Reviewed by Yusuke Suzuki. PlayStation build fix following 271419@main. Evidently using StdUnorderedMap::extract(K) causes our platform to complain about rebind::other being undefined. It's trivial to define so let's just do so. * Source/WTF/wtf/FastMalloc.h: Canonical link: https://commits.webkit.org/271714@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ce1ad: [iOS] Prewarmed web process is not launched as an ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ce1ad341229284e66e8f630fcadabdeed45b77e https://github.com/WebKit/WebKit/commit/7ce1ad341229284e66e8f630fcadabdeed45b77e Author: Andy Estes Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/UIProcess/WebProcessPool.cpp Log Message: --- [iOS] Prewarmed web process is not launched as an extension https://bugs.webkit.org/show_bug.cgi?id=266027 rdar://119341312 Reviewed by Per Arne Vollan. If a prewarmed WebContent process is created before the first WebPage is created, the process would not be launched using ExtensionKit even if ManageWebKitProcessesAsExtensions is enabled. Fixed this by moving the call to AuxiliaryProcessProxy::setManageProcessesAsExtensions from WebProcessPool::createWebPage to WebProcessPool::createNewWebProcess so that the global flag is set before the prewarmed WebContent process is created. Since pagePreferences are not available at this point, also reverted to a user default for using ExtensionKit rather than a web preference. * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::createNewWebProcess): (WebKit::WebProcessPool::createWebPage): Canonical link: https://commits.webkit.org/271713@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6f19e5: Track when link decoration filtering was applied t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f19e5c890be7129b3da6fc6bb147ae207d5d5fe https://github.com/WebKit/WebKit/commit/6f19e5c890be7129b3da6fc6bb147ae207d5d5fe Author: Matthew Finkel Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/page/ChromeClient.h M Source/WebCore/platform/network/ResourceRequestBase.cpp M Source/WebCore/platform/network/ResourceRequestBase.h M Source/WebCore/platform/network/cf/ResourceRequest.h M Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm M Source/WebKit/WebProcess/WebPage/WebPage.h Log Message: --- Track when link decoration filtering was applied to a request's url https://bugs.webkit.org/show_bug.cgi?id=265531 rdar://118940125 Reviewed by Wenson Hsieh. Link decoration filtering (LDF) isn't always applied to requests. This patch provides a way for later stages of the resource loading process to know if LDF was previously applied, but this patch does not make any changes to the current behavior. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::updateRequestAndAddExtraFields): * Source/WebCore/page/ChromeClient.h: (WebCore::ChromeClient::applyLinkDecorationFilteringWithResult const): (WebCore::ChromeClient::applyLinkDecorationFiltering const): * Source/WebCore/platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setAsIsolatedCopy): (WebCore::ResourceRequestBase::setURL): (WebCore::ResourceRequestBase::setDidFilterLinkDecoration): * Source/WebCore/platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::RequestData::RequestData): (WebCore::ResourceRequestBase::didFilterLinkDecoration const): * Source/WebCore/platform/network/cf/ResourceRequest.h: * Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::getResourceRequestPlatformData const): * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::applyLinkDecorationFilteringWithResult const): (WebKit::WebChromeClient::applyLinkDecorationFiltering const): Deleted. * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: * Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::applyLinkDecorationFilteringWithResult): (WebKit::WebPage::applyLinkDecorationFiltering): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.h: (WebKit::WebPage::applyLinkDecorationFiltering): (WebKit::WebPage::applyLinkDecorationFilteringWithResult): Canonical link: https://commits.webkit.org/271712@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 55786d: Generate serialization of WebImage
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 55786dc300a3ef373750a36e6e34f50444ee0513 https://github.com/WebKit/WebKit/commit/55786dc300a3ef373750a36e6e34f50444ee0513 Author: Alex Christensen Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/API/c/cairo/WKImageCairo.cpp M Source/WebKit/Shared/API/c/cg/WKImageCG.cpp M Source/WebKit/Shared/UserData.cpp M Source/WebKit/Shared/WebImage.cpp M Source/WebKit/Shared/WebImage.h A Source/WebKit/Shared/WebImage.serialization.in M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp M Source/WebKit/WebProcess/WebPage/FindController.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: --- Generate serialization of WebImage https://bugs.webkit.org/show_bug.cgi?id=266031 rdar://119343434 Reviewed by Chris Dumez. It currently has a handwritten asymmetrical decoder that can decode nullptr when a non-null WebImage was encoded. To correct this, I make WebImage able to contain a null image buffer. I updated all the checks to reflect this. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/API/c/cg/WKImageCG.cpp: (WKImageCreateFromCGImage): * Source/WebKit/Shared/UserData.cpp: (WebKit::UserData::encode): (WebKit::UserData::decode): * Source/WebKit/Shared/WebImage.cpp: (WebKit::WebImage::createEmpty): (WebKit::WebImage::create): (WebKit::WebImage::WebImage): (WebKit::WebImage::size const): (WebKit::WebImage::parameters const): (WebKit::WebImage::parametersAndHandle const): (WebKit::WebImage::context const): (WebKit::WebImage::copyNativeImage const): (WebKit::WebImage::bitmap const): (WebKit::WebImage::createCairoSurface): (WebKit::WebImage::createHandle const): * Source/WebKit/Shared/WebImage.h: (WebKit::WebImage::isEmpty const): * Source/WebKit/Shared/WebImage.serialization.in: Added. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didGetImageForFindMatch): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: (WebKit::imageForRect): * Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp: (WebKit::InjectedBundleRangeHandle::renderedImage): * Source/WebKit/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp: (WebKit::InjectedBundleHitTestResult::image const): * Source/WebKit/WebProcess/WebPage/FindController.cpp: (WebKit::FindController::getImageForFindMatch): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::snapshotAtSize): (WebKit::WebPage::snapshotNode): (WebKit::WebPage::drawRectToImage): Canonical link: https://commits.webkit.org/271711@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ccdef: Move WebFindOptions to the new serialization format
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ccdef5950c2cb3ff46b6664ced7976fcc218660 https://github.com/WebKit/WebKit/commit/7ccdef5950c2cb3ff46b6664ced7976fcc218660 Author: Claudio Saavedra Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/WebFindOptions.h A Source/WebKit/Shared/WebFindOptions.serialization.in Log Message: --- Move WebFindOptions to the new serialization format https://bugs.webkit.org/show_bug.cgi?id=265877 Reviewed by Alex Christensen. Add a serialization file for the WebFindOptions.h enums and remove the EnumTraits for these. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/WebFindOptions.h: * Source/WebKit/Shared/WebFindOptions.serialization.in: Added. Canonical link: https://commits.webkit.org/271710@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7bb974: [JSC] Port enum classes to new serialization format
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7bb974912a5e68c176c876e3ce7ba59149e056b5 https://github.com/WebKit/WebKit/commit/7bb974912a5e68c176c876e3ce7ba59149e056b5 Author: Claudio Saavedra Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/JavaScriptCore/runtime/ConsoleTypes.h M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources.make A Source/WebKit/Shared/JavaScriptCore.serialization.in Log Message: --- [JSC] Port enum classes to new serialization format https://bugs.webkit.org/show_bug.cgi?id=265679 Reviewed by Alex Christensen. Move JSC's console types to the new serialization format and remove the EnumTraits for it. Use a new JavaScriptCore serialization file to keep things tidy. * Source/JavaScriptCore/runtime/ConsoleTypes.h: * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/JavaScriptCore.serialization.in: Added. Canonical link: https://commits.webkit.org/271709@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 913717: Prepare UserData for generated serialization
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 913717a568c32610003cb528ef4cdfeb8dcfaa58 https://github.com/WebKit/WebKit/commit/913717a568c32610003cb528ef4cdfeb8dcfaa58 Author: Alex Christensen Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/API/APIArray.cpp M Source/WebKit/Shared/API/APIArray.h A Source/WebKit/Shared/API/APIArray.serialization.in M Source/WebKit/Shared/API/APIDictionary.cpp M Source/WebKit/Shared/API/APIDictionary.h A Source/WebKit/Shared/API/APIDictionary.serialization.in M Source/WebKit/Shared/API/APIObject.cpp M Source/WebKit/Shared/API/APIObject.h M Source/WebKit/Shared/API/APISerializedScriptValue.h A Source/WebKit/Shared/API/APISerializedScriptValue.serialization.in A Source/WebKit/Shared/API/APIString.serialization.in A Source/WebKit/Shared/API/APIUserContentURLPattern.serialization.in M Source/WebKit/Shared/UserData.cpp M Source/WebKit/Shared/UserData.h M Source/WebKit/Shared/mac/ObjCObjectGraph.h M Source/WebKit/Shared/mac/ObjCObjectGraph.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Prepare UserData for generated serialization https://bugs.webkit.org/show_bug.cgi?id=266014 rdar://119335942 Reviewed by Brady Eidson. Generate or move serialization of all possible types to make it so we can generate API::Object serialization. I did all but WebKit::WebImage, which I'll do separately. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/API/APIArray.cpp: (API::Array::~Array): Deleted. * Source/WebKit/Shared/API/APIArray.h: * Source/WebKit/Shared/API/APIArray.serialization.in: Added. * Source/WebKit/Shared/API/APIDictionary.cpp: (API::Dictionary::create): (API::Dictionary::Dictionary): (API::Dictionary::~Dictionary): Deleted. * Source/WebKit/Shared/API/APIDictionary.h: * Source/WebKit/Shared/API/APIDictionary.serialization.in: Added. * Source/WebKit/Shared/API/APIObject.cpp: (IPC::ArgumentCoder>::encode): (IPC::ArgumentCoder>::decode): * Source/WebKit/Shared/API/APIObject.h: * Source/WebKit/Shared/API/APISerializedScriptValue.h: (API::SerializedScriptValue::createFromWireBytes): * Source/WebKit/Shared/API/APISerializedScriptValue.serialization.in: Added. * Source/WebKit/Shared/API/APIString.serialization.in: Added. * Source/WebKit/Shared/API/APIUserContentURLPattern.serialization.in: Added. * Source/WebKit/Shared/UserData.cpp: (WebKit::UserData::encode): (WebKit::UserData::decode): (WebKit::UserData::~UserData): Deleted. * Source/WebKit/Shared/UserData.h: * Source/WebKit/Shared/mac/ObjCObjectGraph.h: * Source/WebKit/Shared/mac/ObjCObjectGraph.mm: (IPC::ArgumentCoder::decode): (IPC::ArgumentCoder::encode): (WebKit::ObjCObjectGraph::encode const): Deleted. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/271708@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1db53f: [UnifiedPDF] `UnifiedPDFPlugin::scaleFactor()` alw...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1db53fe7ec8e9962e9debd599fff40323cabd150 https://github.com/WebKit/WebKit/commit/1db53fe7ec8e9962e9debd599fff40323cabd150 Author: Abrar Rahman Protyasha Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] `UnifiedPDFPlugin::scaleFactor()` always reports a scale factor of 1 https://bugs.webkit.org/show_bug.cgi?id=266035 rdar://119344324 Reviewed by Tim Horton and Simon Fraser. Let's make it report `m_scaleFactor` instead, since it isn't guaranteed that the scale factor will be 1. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::scaleFactor): Canonical link: https://commits.webkit.org/271707@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 14bd8a: Implement declarativeNetRequest dynamic and sessio...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 14bd8a42717a351ebe92101b83d757311d20a07e https://github.com/WebKit/WebKit/commit/14bd8a42717a351ebe92101b83d757311d20a07e Author: Brian Weinstein Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebCore/en.lproj/Localizable.strings M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js M Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.h M Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestSQLiteStore.h M Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestSQLiteStore.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDeclarativeNetRequestCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm Log Message: --- Implement declarativeNetRequest dynamic and session rules APIs https://bugs.webkit.org/show_bug.cgi?id=266016 rdar://118476702&118476774 Reviewed by Timothy Hatcher. This patch implements: - declarativeNetRequest.getSessionRules() - declarativeNetRequest.updateSessionRules() - declarativeNetRequest.getDynamicRules() - declarativeNetRequest.updateDynamicRules() The big difference between these two APIs is that dynamic rules are persisted to disk and will be loaded across quitting and relaunching the browser. Session rules will go away. Also, while we are here, fix a typo in an error message and update the localizable strings. * Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.h: * Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm: (-[_WKWebExtensionSQLiteStore _savepointNameFromUUID:]): Generate a savepoint name based on the UUID. (-[_WKWebExtensionSQLiteStore createSavepointWithCompletionHandler:]): Create a savepoint in the database. (-[_WKWebExtensionSQLiteStore commitSavepoint:completionHandler:]): Commit the savepoint to the database. (-[_WKWebExtensionSQLiteStore rollbackToSavepoint:completionHandler:]): Rollback the database to a given savepoint. * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm: (WebKit::WebExtensionContext::declarativeNetRequestDynamicRulesStore): Create and return a _WKWebExtensionDeclarativeNetRequestSQLiteStore for the dynamic rules. This will only use the in memory database if storage isn't persistent for the extension context. (WebKit::WebExtensionContext::declarativeNetRequestSessionRulesStore): Create and return a _WKWebExtensionDeclarativeNetRequestSQLiteStore for the session rules. This will always use the in memory database. (WebKit::WebExtensionContext::updateDeclarativeNetRequestRulesInStorage): Attempt to perform the given updates to the rules in the database. The flow is: - Create a savepoint - Update the rules by removing and adding rules. - If this fails, perform a rollback - If this succeeds, attempt to load the new rules - If this fails, perform a rollback, and attempt to load the old rules - If this succeeds, commit the savepoint (WebKit::WebExtensionContext::declarativeNetRequestGetDynamicRules): Get the rules from the dynamic rules store. (WebKit::WebExtensionContext::declarativeNetRequestUpdateDynamicRules): Call into updateDeclarativeNetRequestRulesInStorage. (WebKit::WebExtensionContext::declarativeNetRequestGetSessionRules): Get the rules from the session rules store. (WebKit::WebExtensionContext::declarativeNetRequestUpdateSessionRules): Call into updateDeclarativeNetRequestRulesInStorage. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::loadDeclarativeNetRequestRules): Chain together loading rules from the various sources, the order is: - Session rules - Dynamic rules - Static rules * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: * Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in: * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDeclarativeNetRequestCocoa.mm: (WebKit::WebExtensionAPIDeclarativeNetRequest::updateDynamicRules): Call into the UI process after performing argument validation. (WebKit::WebExtensionAPIDeclarativeNetRequest::getDynamicRules): Call into the UI process. (WebKit::WebExtensionAPIDeclarativeNetRequest::updateSessionRules): Call into the UI process after performing argument validation. (WebKit::WebExtensionAPIDeclarativeNetRequest::getSessionRules): Call into the UI process. *
[webkit-changes] [WebKit/WebKit] 2d1ab2: Unreviewed, reverting 271682@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2d1ab242d1624ce6b34e95a100cc3e4ee0042c40 https://github.com/WebKit/WebKit/commit/2d1ab242d1624ce6b34e95a100cc3e4ee0042c40 Author: Commit Queue Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebCore/PAL/pal/ios/UIKitSoftLink.h M Source/WebCore/PAL/pal/ios/UIKitSoftLink.mm M Source/WebCore/css/htmlSwitchControl.css M Source/WebCore/html/CheckboxInputType.cpp M Source/WebCore/html/CheckboxInputType.h M Source/WebCore/html/HTMLInputElement.cpp M Source/WebCore/html/HTMLInputElement.h M Source/WebCore/html/InputType.h M Source/WebCore/platform/Theme.h M Source/WebCore/platform/ios/ThemeIOS.h M Source/WebCore/platform/ios/ThemeIOS.mm M Source/WebCore/rendering/RenderTheme.cpp M Source/WebCore/rendering/RenderTheme.h M Source/WebCore/rendering/RenderThemeIOS.h M Source/WebCore/rendering/RenderThemeIOS.mm Log Message: --- Unreviewed, reverting 271682@main. https://bugs.webkit.org/show_bug.cgi?id=266050 5% SP2 regression Reverted changeset: "Add iOS infrastructure" https://bugs.webkit.org/show_bug.cgi?id=265947 https://commits.webkit.org/271682@main Canonical link: https://commits.webkit.org/271705@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 052b3e: REGRESSION(271529@main): Volatility timer stops be...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 052b3e14ae006698e648810fe1182afb2f76bef3 https://github.com/WebKit/WebKit/commit/052b3e14ae006698e648810fe1182afb2f76bef3 Author: Matt Woodrow Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm Log Message: --- REGRESSION(271529@main): Volatility timer stops before all surfaces are made volatile and never completes. https://bugs.webkit.org/show_bug.cgi?id=266034 Reviewed by Dan Glastonbury. If `identifiers` is empty it means we didn't collect any right now, not that there weren't any to be collected. We should only stop the timer if `collectedAllRemoteRenderingBuffers` is true (as well as `successfullyMadeBackingStoreVolatile`). * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm: (WebKit::RemoteLayerBackingStoreCollection::markAllBackingStoreVolatileFromTimer): Canonical link: https://commits.webkit.org/271704@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 399efe: Adjust enablement criteria for the "Async UIKit In...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 399efe5784e4a2b3e7fc2819bb1204a8b75ffe9c https://github.com/WebKit/WebKit/commit/399efe5784e4a2b3e7fc2819bb1204a8b75ffe9c Author: Wenson Hsieh Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm Log Message: --- Adjust enablement criteria for the "Async UIKit Interactions" feature flag https://bugs.webkit.org/show_bug.cgi?id=266022 Reviewed by Aditya Keerthi. Adjust this feature flag, such that it's enabled by default only when both the following criteria are met: 1. `PAL::deviceClassIsSmallScreen()` is true. 2. `UIKit/async_text_input` is enabled. * Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm: (WebKit::defaultUseAsyncUIKitInteractions): Canonical link: https://commits.webkit.org/271703@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a54075: [ iOS EWS ] 2X TestWebKitAPI.ServiceWorker.WindowC...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a54075c47ad26b8a9b9aa7d303c1262ffc7c4533 https://github.com/WebKit/WebKit/commit/a54075c47ad26b8a9b9aa7d303c1262ffc7c4533 Author: Robert Jenner Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm Log Message: --- [ iOS EWS ] 2X TestWebKitAPI.ServiceWorker.WindowClientNavigate (API-Tests) are flaky timeout rdar://117758550 https://bugs.webkit.org/show_bug.cgi?id=263991 Unreviewed test gardneing. Removing the disabled flag for these API-tests to verify a proposed fix. * Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: Canonical link: https://commits.webkit.org/271702@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ea98b: Optimize the creation of WeakPtrs for many object ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ea98bdecabcba02abd3154aef5a17d11f35d9ca https://github.com/WebKit/WebKit/commit/0ea98bdecabcba02abd3154aef5a17d11f35d9ca Author: Chris Dumez Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WTF/wtf/WeakHashMap.h M Source/WTF/wtf/WeakHashSet.h M Source/WTF/wtf/WeakListHashSet.h M Source/WTF/wtf/WeakPtr.h M Source/WTF/wtf/WeakRef.h M Source/WebCore/dom/EventTarget.cpp M Source/WebCore/dom/EventTarget.h Log Message: --- Optimize the creation of WeakPtrs for many object types https://bugs.webkit.org/show_bug.cgi?id=265981 Reviewed by Darin Adler. The performance of WeakPtrs is increasingly important as we adopt it more and more in our code base. As I am working to use WeakPtr more in rendering code, I noticed that the construction of WeakPtr was impact by the fact that WeakPtrFactory was using a data member of type `CompactRefPtrTuple` to store a packed WeakPtrImpl pointer in order to free up space for a bitfield. This means that every time we want to construct a WeakPtr from an object, the WeakPtrFactory has to extract the WeakPtrImpl pointer from the CompactRefPtrTuple, which can be costly, especially in Intel hardware. The only type actually leveraging the WeakPtrFactory's bit field is EventTarget. All the other classes (like RenderObject) are just paying this cost without actually getting any benefit from the pointer packing. To address the issue, I renamed WeakPtrFactory to WeakPtrFactoryWithBitField and had EventTarget use this one instead. I introduced a simpler WeakPtrFactory which is using a straight `RefPtr` instead, which every other type is now using. Based on my A/B testing, this should allow us to replace CheckedPtr / CheckedRef with WeakPtr / WeakRef in rendering code without regressing our benchmarks. * Source/WTF/wtf/WeakHashMap.h: * Source/WTF/wtf/WeakHashSet.h: * Source/WTF/wtf/WeakListHashSet.h: * Source/WTF/wtf/WeakPtr.h: (WTF::WeakPtr::implForObject): (WTF::WeakPtrFactory::~WeakPtrFactory): (WTF::WeakPtrFactory::impl const): (WTF::WeakPtrFactory::initializeIfNeeded const): (WTF::WeakPtrFactory::createWeakPtr const): (WTF::WeakPtrFactory::revokeAll): (WTF::WeakPtrFactory::weakPtrCount const): (WTF::WeakPtrFactory::isInitialized const): (WTF::WeakPtrFactoryWithBitField::WeakPtrFactoryWithBitField): (WTF::WeakPtrFactoryWithBitField::~WeakPtrFactoryWithBitField): (WTF::WeakPtrFactoryWithBitField::impl const): (WTF::CanMakeWeakPtrBase::weakPtrFactory const): (WTF::CanMakeWeakPtrBase::weakPtrFactory): (WTF::CanMakeWeakPtrBase::CanMakeWeakPtrBase): (WTF::CanMakeWeakPtrBase::operator=): (WTF::CanMakeWeakPtrBase::initializeWeakPtrFactory): (WTF::WeakPtrFactory::impl): Deleted. (WTF::WeakPtrFactory::bitfield const): Deleted. (WTF::WeakPtrFactory::setBitfield const): Deleted. (WTF::CanMakeWeakPtr::weakPtrFactory const): Deleted. (WTF::CanMakeWeakPtr::weakPtrFactory): Deleted. (WTF::CanMakeWeakPtr::CanMakeWeakPtr): Deleted. (WTF::CanMakeWeakPtr::operator=): Deleted. (WTF::CanMakeWeakPtr::initializeWeakPtrFactory): Deleted. * Source/WTF/wtf/WeakRef.h: (WTF::WeakRef::implForObject): * Source/WebCore/dom/EventTarget.h: Canonical link: https://commits.webkit.org/271701@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bd3a49: Port PixelBuffer to the new IPC serialization format
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bd3a49638f1d87209d588d4d80e3814141caf381 https://github.com/WebKit/WebKit/commit/bd3a49638f1d87209d588d4d80e3814141caf381 Author: Chris Dumez Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Port PixelBuffer to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=266011 Reviewed by Alex Christensen. * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/271700@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 14c99c: [webkitcorepy] Fix incorrect pip requires list
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 14c99c25cf268715f5d14b19dda3b7038af1e7cd https://github.com/WebKit/WebKit/commit/14c99c25cf268715f5d14b19dda3b7038af1e7cd Author: Jonathan Bedard Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/setup.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py Log Message: --- [webkitcorepy] Fix incorrect pip requires list https://bugs.webkit.org/show_bug.cgi?id=266023 rdar://119340267 Unreviewed infrastructure fix. * Tools/Scripts/libraries/webkitcorepy/setup.py: Fix install_requires list. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version. Canonical link: https://commits.webkit.org/271699@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5aab6f: Teach package-root to include auxiliary process ex...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5aab6fe8ccf6483ea9f8dbc03768089380f1522b https://github.com/WebKit/WebKit/commit/5aab6fe8ccf6483ea9f8dbc03768089380f1522b Author: Andy Estes Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Tools/Scripts/package-root Log Message: --- Teach package-root to include auxiliary process extension bundles https://bugs.webkit.org/show_bug.cgi?id=266019 rdar://119339487 Reviewed by Per Arne Vollan. The GPU, Networking, and WebContent app extensions expect to be installed in /System/Library/ExtensionKit/Extensions. Teach package-root to package them in this location. * Tools/Scripts/package-root: Canonical link: https://commits.webkit.org/271698@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] baab62: Add visibility propagation for WebKit extension pr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: baab62554de5053810fa34fc9dbe06a50c9df8a5 https://github.com/WebKit/WebKit/commit/baab62554de5053810fa34fc9dbe06a50c9df8a5 Author: Per Arne Vollan Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/Platform/spi/Cocoa/ExtensionKitSPI.h M Source/WebKit/UIProcess/ios/WKContentView.mm Log Message: --- Add visibility propagation for WebKit extension processes https://bugs.webkit.org/show_bug.cgi?id=265995 rdar://119313066 Reviewed by Brent Fulgham. Add visibility propagation for WebKit extension processes. This only applies to the WebContent and GPU process. * Source/WebKit/Platform/spi/Cocoa/ExtensionKitSPI.h: * Source/WebKit/UIProcess/ios/WKContentView.mm: (-[WKContentView _setupVisibilityPropagationViewForWebProcess]): (-[WKContentView _setupVisibilityPropagationViewForGPUProcess]): (-[WKContentView _removeVisibilityPropagationViewForWebProcess]): (-[WKContentView _removeVisibilityPropagationViewForGPUProcess]): Canonical link: https://commits.webkit.org/271697@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e10485: Race condition between JSObject::getDirectConcurre...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e1048521aef5bf2f660d0d1826450f0588d2eec2 https://github.com/WebKit/WebKit/commit/e1048521aef5bf2f660d0d1826450f0588d2eec2 Author: Yusuke Suzuki Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/JavaScriptCore/runtime/Structure.cpp Log Message: --- Race condition between JSObject::getDirectConcurrently users and Structure::flattenDictionaryStructure https://bugs.webkit.org/show_bug.cgi?id=265067 rdar://118548733 Reviewed by Justin Michaud and Mark Lam. Like Array shift/unshift, flattenDictionaryStructure is the other code which can shrink butterfly for named properties (no other code does it). Compiler threads rely on the fact that normally named property storage never shrunk. And we should catch this exceptional case by taking a cellLock in the compiler thread. But flattenDictionaryStructure is not taking cellLock correctly. This patch computes afterOutOfLineCapacity first to detect that whether this flattening will shrink the butterfly. And if it is, then we take a cellLock. We do not need to take it if we do not shrink the butterfly. * Source/JavaScriptCore/runtime/Structure.cpp: (JSC::Structure::flattenDictionaryStructure): Originally-landed-as: 267815.577@safari-7617-branch (b0a755e34426). rdar://119326607 Canonical link: https://commits.webkit.org/271696@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b2788c: [macOS] Occasional crash when invoking the complet...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b2788c65e9c925f0484298df163aa2b7fee81ede https://github.com/WebKit/WebKit/commit/b2788c65e9c925f0484298df163aa2b7fee81ede Author: Wenson Hsieh Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm Log Message: --- [macOS] Occasional crash when invoking the completion handler in WebKit::requestPayloadForQRCode https://bugs.webkit.org/show_bug.cgi?id=266000 rdar://117083360 Reviewed by Aditya Keerthi. This is a speculative fix for rdar://117083360, where (on certain version of macOS), Safari crashes underneath this QR code detection codepath, due to the completion handler being invoked more than once. While I wasn't able to reproduce the crash locally, forcing the completion handler to be called twice was sufficient to replicate a crash under the same stack. It's possible that Vision has a bug wherein `-[VNImageRequestHandler performRequests:error:]` yields a non-null `NSError` for the error outparam, yet the `VNDetectBarcodesRequest`'s completion handler is still invoked (presumably, also with an `NSError`). rdar://119319173 tracks further investigation here. * Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm: (WebKit::requestPayloadForQRCode): Canonical link: https://commits.webkit.org/271695@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4314b6: Extr can overflow when imm=64, allowing a random r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4314b6ee6195aeb294402cce98bdb05dbdf83ad4 https://github.com/WebKit/WebKit/commit/4314b6ee6195aeb294402cce98bdb05dbdf83ad4 Author: Justin Michaud Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/JavaScriptCore/b3/B3LowerToAir.cpp M Source/JavaScriptCore/b3/air/AirValidate.cpp Log Message: --- Extr can overflow when imm=64, allowing a random register to be read rdar://118515062 Reviewed by Yusuke Suzuki. Extr can overflow when imm=64, allowing a random register to be read. * Source/JavaScriptCore/b3/B3LowerToAir.cpp: * Source/JavaScriptCore/b3/air/AirValidate.cpp: Originally-landed-as: 267815.574@safari-7617-branch (49ba637c4abb). rdar://119327080 Canonical link: https://commits.webkit.org/271694@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9e36fb: Failing to deserialize data from _WKWebExtensionSQ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9e36fb6ce4d50edc025be982de388581958edf03 https://github.com/WebKit/WebKit/commit/9e36fb6ce4d50edc025be982de388581958edf03 Author: Kiara Rose Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteRow.mm M Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm Log Message: --- Failing to deserialize data from _WKWebExtensionSQLiteRow https://bugs.webkit.org/show_bug.cgi?id=266012 Reviewed by Brian Weinstein and Timothy Hatcher. We should be passing data.bytes as is. `- (NSData *)uncopiedDataAtIndex:(NSUInteger)index` needs a cast. * Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteRow.mm: (-[_WKWebExtensionSQLiteRow dataAtIndex:]): (-[_WKWebExtensionSQLiteRow uncopiedDataAtIndex:]): * Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm: Initialize with space for two items, not three. Canonical link: https://commits.webkit.org/271693@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c4c680: [threaded-animation-resolution] store accelerated ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c4c680697bdba4208581dc7fd40ffdd202482c08 https://github.com/WebKit/WebKit/commit/c4c680697bdba4208581dc7fd40ffdd202482c08 Author: Antoine Quint Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebCore/platform/animation/AcceleratedEffectStack.h M Source/WebCore/platform/animation/AcceleratedEffectStack.mm M Source/WebCore/platform/graphics/GraphicsLayer.cpp M Source/WebCore/platform/graphics/GraphicsLayer.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm M Source/WebKit/SourcesCocoa.txt A Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.h A Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.mm M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.h M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.h M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.h M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- [threaded-animation-resolution] store accelerated effects and base values in the remote layer tree https://bugs.webkit.org/show_bug.cgi?id=265880 Reviewed by Simon Fraser. While we correctly encode the `AcceleratedEffectStack` from WebCore to be sent over IPC to the UI process whenever there is a meaningful change, we don't do anything with these effects yet. This patch creates a `RemoteAcceleratedEffectStack` and store effects and base values on it and lays the groundwork for the next patch for the threaded animation resolution feature where we will schedule and resolve animations in the remote layer tree. On iOS, the `RemoteAcceleratedEffectStack` is owned by a `RemoteLayerTreeNode` which will access on the main thread for animation resolution. On macOS, the `RemoteAcceleratedEffectStack` is owned by the `RemoteLayerTreeEventDispatcher` which will allow access in a thread-safe manner for animation resolution. * Source/WebCore/platform/animation/AcceleratedEffectStack.h: (WebCore::AcceleratedEffectStack::primaryLayerEffects const): Deleted. (WebCore::AcceleratedEffectStack::backdropLayerEffects const): Deleted. (WebCore::AcceleratedEffectStack::baseValues): Deleted. * Source/WebCore/platform/animation/AcceleratedEffectStack.mm: (WebCore::AcceleratedEffectStack::create): (WebCore::AcceleratedEffectStack::AcceleratedEffectStack): (WebCore::AcceleratedEffectStack::setEffects): (WebCore::AcceleratedEffectStack::~AcceleratedEffectStack): Deleted. * Source/WebCore/platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setAcceleratedEffectsAndBaseValues): * Source/WebCore/platform/graphics/GraphicsLayer.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm: (WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer): * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.h: Added. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.mm: Added. (WebKit::RemoteAcceleratedEffectStack::create): (WebKit::RemoteAcceleratedEffectStack::RemoteAcceleratedEffectStack): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm: (WebKit::RemoteLayerTreeDrawingAreaProxy::animationsWereAddedToNode): (WebKit::RemoteLayerTreeDrawingAreaProxy::animationsWereRemovedFromNode): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm: (WebKit::RemoteLayerTreeHost::threadedAnimationResolutionEnabled const): (WebKit::RemoteLayerTreeHost::animationsWereAddedToNode): (WebKit::RemoteLayerTreeHost::animationsWereRemovedFromNode): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h: (WebKit::RemoteLayerTreeNode::takeEffectStack): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm: (WebKit::RemoteLayerTreeNode::setAcceleratedEffectsAndBaseValues): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
[webkit-changes] [WebKit/WebKit] 63cec5: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 63cec56fb31d218d7dd9b27fd38c96f5ac8deac9 https://github.com/WebKit/WebKit/commit/63cec56fb31d218d7dd9b27fd38c96f5ac8deac9 Author: Fujii Hironori Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/fast/dom/xml-parser-error-message-crash-expected.txt Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/fast/dom/xml-parser-error-message-crash-expected.txt: Canonical link: https://commits.webkit.org/271691@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ff2215: Port Font::Attributes to the new IPC serialization...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ff2215743d202983f1eb966c1a60158480fd464c https://github.com/WebKit/WebKit/commit/ff2215743d202983f1eb966c1a60158480fd464c Author: Chris Dumez Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebCore/platform/graphics/Font.cpp M Source/WebCore/platform/graphics/Font.h M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Port Font::Attributes to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=266002 Reviewed by Brady Eidson. * Source/WebCore/platform/graphics/Font.cpp: (WebCore::FontInternalAttributes::ensureRenderingResourceIdentifier const): (WebCore::Font::Attributes::ensureRenderingResourceIdentifier const): Deleted. * Source/WebCore/platform/graphics/Font.h: * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/271690@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5cf20e: AX: Remove WTR::AccessibilityUIElement::isIsolated...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5cf20e0973b787ad6b5968b69ce313db34cc2639 https://github.com/WebKit/WebKit/commit/5cf20e0973b787ad6b5968b69ce313db34cc2639 Author: Andres Gonzalez Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm Log Message: --- AX: Remove WTR::AccessibilityUIElement::isIsolatedObject since it should not be used in any test. https://bugs.webkit.org/show_bug.cgi?id=265876 Reviewed by Tyler Wilcock. Whether or not the underlying AX object is isolated should be irrelevant to the client, so no test should need to call this. This was added in an early stage of the ITM project for debugging purposes and is not exposed or used by any active test. * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]): * Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::isIsolatedObject const): Deleted. * Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::isIsolatedObject const): Deleted. Canonical link: https://commits.webkit.org/271689@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6eed9f: [webkitscmpy] Collect diff from Bitbucket remote r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6eed9f3aec5d730a27c93b311506d725b597cb31 https://github.com/WebKit/WebKit/commit/6eed9f3aec5d730a27c93b311506d725b597cb31 Author: Jonathan Bedard Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/scm.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py Log Message: --- [webkitscmpy] Collect diff from Bitbucket remote repository https://bugs.webkit.org/show_bug.cgi?id=265705 rdar://119055886 Reviewed by Dewei Zhu. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py: (BitBucket.commit): 'HEAD' in Bitbucket means "latest commit on the default branch". (BitBucket.request): Return a response with a mock diff. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py: (BitBucket.json_to_diff): Convert Bitbucket json diff to text diff. (BitBucket.commits): Return a list of commits to caller. (BitBucket.diff): Given a commit or commit range, return a line-by-line diff of the provided range. If the caller requests it, include the commit messages for the specified commits in the same patch format used by 'git format-patch'. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py: (GitHub): Move EMAIL_RE to base class. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/scm.py: (Scm): Move EMAIL_RE from GitHub. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py: Canonical link: https://commits.webkit.org/271688@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 912bf7: [webkitscmpy] Collect diff from GitHub remote repo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 912bf757dabd4abf64bdacea33775bee027032ed https://github.com/WebKit/WebKit/commit/912bf757dabd4abf64bdacea33775bee027032ed Author: Jonathan Bedard Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py Log Message: --- [webkitscmpy] Collect diff from GitHub remote repository https://bugs.webkit.org/show_bug.cgi?id=265590 rdar://118993239 Reviewed by Dewei Zhu. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py: (GitHub.commit): 'HEAD' in GitHub means "latest commit on the default branch". (GitHub._diff_response): Return a response with a mock text diff. (GitHub.request): Respect the 'application/vnd.github.diff' header. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py: (GitHub): (GitHub.diff): Given a commit or commit range, return a line-by-line diff of the provided range. If the caller requests it, include the commit messages for the specified commits in the same patch format used by 'git format-patch'. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py: Canonical link: https://commits.webkit.org/271687@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bb91f7: Add macOS haptic feed...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bb91f7ea979b47b2d2097d6a423b461c4d37d8ec https://github.com/WebKit/WebKit/commit/bb91f7ea979b47b2d2097d6a423b461c4d37d8ec Author: Anne van Kesteren Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebCore/html/CheckboxInputType.cpp M Source/WebCore/page/ChromeClient.h M Source/WebCore/rendering/RenderThemeMac.h M Source/WebKit/UIProcess/PageClient.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/UIProcess/mac/PageClientImplMac.h M Source/WebKit/UIProcess/mac/PageClientImplMac.mm M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h Log Message: --- Add macOS haptic feedback https://bugs.webkit.org/show_bug.cgi?id=265991 Reviewed by Aditya Keerthi. During pointer tracking when the visually on state changes the switch control is to provide haptic feedback. * Source/WebCore/html/CheckboxInputType.cpp: (WebCore::CheckboxInputType::updateIsSwitchVisuallyOnFromAbsoluteLocation): * Source/WebCore/page/ChromeClient.h: (WebCore::ChromeClient::inputElementDidResignStrongPasswordAppearance): Remove a trailing semicolon here for consistency. (WebCore::ChromeClient::performSwitchHapticFeedback): * Source/WebCore/rendering/RenderThemeMac.h: Drive-by fix to mark this method private. * Source/WebKit/UIProcess/PageClient.h: (WebKit::PageClient::performSwitchHapticFeedback): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::performSwitchHapticFeedback): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/UIProcess/mac/PageClientImplMac.h: * Source/WebKit/UIProcess/mac/PageClientImplMac.mm: (WebKit::PageClientImpl::performSwitchHapticFeedback): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::performSwitchHapticFeedback): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: Canonical link: https://commits.webkit.org/271686@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9c3976: [Gardening]: REGRESSION (270602@main): [ Monterey ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9c39767436608bf13c007d9d52f0e249cbc7edbd https://github.com/WebKit/WebKit/commit/9c39767436608bf13c007d9d52f0e249cbc7edbd Author: Marta Darbinyan Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: A LayoutTests/platform/mac-ventura/imported/w3c/web-platform-tests/accname/name/comp_host_language_label-expected.txt Log Message: --- [Gardening]: REGRESSION (270602@main): [ Monterey / Ventura wk2 ] imported/w3c/web-platform-tests/accname/name/comp_host_language_label.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=265414 rdar://118857276 Unreviewed test gardening. Rebaseline test * LayoutTests/platform/mac-ventura/imported/w3c/web-platform-tests/accname/name/comp_host_language_label-expected.txt: Added. Canonical link: https://commits.webkit.org/271685@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bdc9c3: Enable `::grammar-error` and `::spelling-error` by...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bdc9c3cf0a54ccd3e90bfae34b7e5ffbb22874cd https://github.com/WebKit/WebKit/commit/bdc9c3cf0a54ccd3e90bfae34b7e5ffbb22874cd Author: Aditya Keerthi Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Enable `::grammar-error` and `::spelling-error` by default https://bugs.webkit.org/show_bug.cgi?id=265997 rdar://119314048 Reviewed by Wenson Hsieh. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/271684@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ddfc22: Port DOMCacheEngine::Record to the new IPC seriali...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ddfc224d7b54e837f2ffacfec1260a15c45f7c82 https://github.com/WebKit/WebKit/commit/ddfc224d7b54e837f2ffacfec1260a15c45f7c82 Author: Chris Dumez Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Port DOMCacheEngine::Record to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=265999 Reviewed by Youenn Fablet. * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/271683@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 26a483: Add iOS infrastructure
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 26a483b2248d43fe8f7b77ce47c847f698d97da7 https://github.com/WebKit/WebKit/commit/26a483b2248d43fe8f7b77ce47c847f698d97da7 Author: Anne van Kesteren Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebCore/PAL/pal/ios/UIKitSoftLink.h M Source/WebCore/PAL/pal/ios/UIKitSoftLink.mm M Source/WebCore/css/htmlSwitchControl.css M Source/WebCore/html/CheckboxInputType.cpp M Source/WebCore/html/CheckboxInputType.h M Source/WebCore/html/HTMLInputElement.cpp M Source/WebCore/html/HTMLInputElement.h M Source/WebCore/html/InputType.h M Source/WebCore/platform/Theme.h M Source/WebCore/platform/ios/ThemeIOS.h M Source/WebCore/platform/ios/ThemeIOS.mm M Source/WebCore/rendering/RenderTheme.cpp M Source/WebCore/rendering/RenderTheme.h M Source/WebCore/rendering/RenderThemeIOS.h M Source/WebCore/rendering/RenderThemeIOS.mm Log Message: --- Add iOS infrastructure https://bugs.webkit.org/show_bug.cgi?id=265947 Reviewed by Aditya Keerthi. This makes the following changes: - Resets default styling of on iOS. - Adds support for reading the on/off labels preference. - Adds support for touch-based pointer tracking to CheckboxInputType as well as a Pressed animation that can run simultaneously with the VisuallyOn animation. - Make the non-IOS_TOUCH_EVENTS code in HTMLInputElement compatible with IOS_TOUCH_EVENTS so events get delivered to CheckboxInputType. - Adds the relevant hooks to RenderTheme to enable painting on iOS. * Source/WebCore/PAL/pal/ios/UIKitSoftLink.h: * Source/WebCore/PAL/pal/ios/UIKitSoftLink.mm: * Source/WebCore/css/htmlSwitchControl.css: (#if defined(WTF_PLATFORM_IOS_FAMILY) && WTF_PLATFORM_IOS_FAMILY): (input[type="checkbox"][switch]:checked): (input[type="checkbox"][switch]:disabled): (input[type="checkbox"][switch]:checked:disabled): * Source/WebCore/html/CheckboxInputType.cpp: (WebCore::CheckboxInputType::handleMouseDownEvent): (WebCore::findTouchWithIdentifier): (WebCore::CheckboxInputType::handleTouchEvent): (WebCore::CheckboxInputType::startSwitchPointerTracking): (WebCore::CheckboxInputType::stopSwitchPointerTracking): (WebCore::CheckboxInputType::disabledStateChanged): (WebCore::CheckboxInputType::willUpdateCheckedness): (WebCore::switchAnimationDuration): (WebCore::CheckboxInputType::switchAnimationStartTime const): (WebCore::CheckboxInputType::setSwitchAnimationStartTime): (WebCore::CheckboxInputType::switchAnimationPressedProgress const): (WebCore::CheckboxInputType::switchAnimationTimerFired): * Source/WebCore/html/CheckboxInputType.h: * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::runPostTypeUpdateTasks): (WebCore::HTMLInputElement::didMoveToNewDocument): (WebCore::HTMLInputElement::switchAnimationPressedProgress const): * Source/WebCore/html/HTMLInputElement.h: * Source/WebCore/html/InputType.h: * Source/WebCore/platform/Theme.h: (WebCore::Theme::userPrefersOnOffLabels const): * Source/WebCore/platform/ios/ThemeIOS.h: * Source/WebCore/platform/ios/ThemeIOS.mm: (WebCore::ThemeIOS::userPrefersOnOffLabels const): * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): * Source/WebCore/rendering/RenderTheme.h: (WebCore::RenderTheme::switchAnimationPressedDuration const): (WebCore::RenderTheme::adjustSwitchStyle const): (WebCore::RenderTheme::paintSwitchThumb): (WebCore::RenderTheme::paintSwitchTrack): * Source/WebCore/rendering/RenderThemeIOS.h: * Source/WebCore/rendering/RenderThemeIOS.mm: (WebCore::renderThemePaintSwitchThumb): (WebCore::renderThemePaintSwitchTrack): (WebCore::RenderThemeIOS::adjustSwitchStyle const): (WebCore::RenderThemeIOS::paintSwitchThumb): (WebCore::RenderThemeIOS::paintSwitchTrack): Canonical link: https://commits.webkit.org/271682@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cf6a98: [web-animations] the AnimationEffect::ticksContino...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf6a98dec70cfea88402bc45d23a13e873d43743 https://github.com/WebKit/WebKit/commit/cf6a98dec70cfea88402bc45d23a13e873d43743 Author: Antoine Quint Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebCore/animation/AnimationEffect.cpp M Source/WebCore/animation/AnimationEffect.h M Source/WebCore/animation/CustomEffect.h M Source/WebCore/animation/KeyframeEffect.cpp M Source/WebCore/animation/KeyframeEffect.h Log Message: --- [web-animations] the AnimationEffect::ticksContinouslyWhileActive() method has a typo in its name https://bugs.webkit.org/show_bug.cgi?id=265955 rdar://119265944 Reviewed by Aditya Keerthi. The correct spelling is ticksContinuouslyWhileActive. * Source/WebCore/animation/AnimationEffect.cpp: (WebCore::AnimationEffect::timeToNextTick const): * Source/WebCore/animation/AnimationEffect.h: (WebCore::AnimationEffect::ticksContinuouslyWhileActive const): (WebCore::AnimationEffect::ticksContinouslyWhileActive const): Deleted. * Source/WebCore/animation/CustomEffect.h: * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::ticksContinuouslyWhileActive const): (WebCore::KeyframeEffect::timeToNextTick const): (WebCore::KeyframeEffect::ticksContinouslyWhileActive const): Deleted. * Source/WebCore/animation/KeyframeEffect.h: Canonical link: https://commits.webkit.org/271681@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d57e74: [Gardening]: REGRESSION (271535@main): [ macOS Rel...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d57e747ddc8968bbf62aeec94d4496c4a5dbc21e https://github.com/WebKit/WebKit/commit/d57e747ddc8968bbf62aeec94d4496c4a5dbc21e Author: Marta Darbinyan Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION (271535@main): [ macOS Release wk2 ] fullscreen/full-screen-layer-dump.html is a frequent failure https://bugs.webkit.org/show_bug.cgi?id=265957 rdar://119268470 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: This commit include: Canonical link: https://commits.webkit.org/271680@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dfc40f: [IFC][Ruby] Reserve horizontal space for inter-cha...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dfc40f631aac708c66fff9274f288d31256f0931 https://github.com/WebKit/WebKit/commit/dfc40f631aac708c66fff9274f288d31256f0931 Author: Alan Baradlay Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h Log Message: --- [IFC][Ruby] Reserve horizontal space for inter-character annotation content https://bugs.webkit.org/show_bug.cgi?id=265961 Reviewed by Antti Koivisto. 1. Move special, ruby base inline-box end handling to RubyFormattingContext. 2. Make space for inter-character annotation (right to the base content). * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::candidateContentForLine): * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp: (WebCore::Layout::baseLogicalWidthFromRubyBaseEnd): (WebCore::Layout::RubyFormattingContext::annotationBoxLogicalWidth): (WebCore::Layout::RubyFormattingContext::baseEndAdditionalLogicalWidth): (WebCore::Layout::RubyFormattingContext::placeAnnotationBox): (WebCore::Layout::RubyFormattingContext::baseLogicalWidthFromRubyBaseEnd): Deleted. * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h: Canonical link: https://commits.webkit.org/271679@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 97f84b: Do not synchronously measure SVG text every time i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 97f84b2e6bd16d246a6006c38f434cbdf441b0d7 https://github.com/WebKit/WebKit/commit/97f84b2e6bd16d246a6006c38f434cbdf441b0d7 Author: Vitor Roriz Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebCore/rendering/svg/RenderSVGText.cpp Log Message: --- Do not synchronously measure SVG text every time it changes https://bugs.webkit.org/show_bug.cgi?id=264669 rdar://problem/118451741 Reviewed by Simon Fraser. This is a optimization done in the Blink fork https://chromium.googlesource.com/chromium/src.git/+/34c351416a102e4ee510badb86fbc4f57604ccd0 and found by Ahmad Saleem. If SVG text is set multiple times in a row, we would measure text synchronously for every set, even though just the last measurement would count. This patch marks it as "need layout", so we measure text in the next layout. * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::subtreeTextDidChange): Canonical link: https://commits.webkit.org/271678@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0c0643: [GPUP] WebContent process consumes a sandbox exten...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0c06435111bb6f56f6cee07d733519e69ff84b6b https://github.com/WebKit/WebKit/commit/0c06435111bb6f56f6cee07d733519e69ff84b6b Author: Per Arne Vollan Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/Shared/WebProcessDataStoreParameters.h M Source/WebKit/Shared/WebProcessDataStoreParameters.serialization.in M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- [GPUP] WebContent process consumes a sandbox extension to the media cache directory unnecessarily https://bugs.webkit.org/show_bug.cgi?id=265406 rdar://110540943 Reviewed by Brent Fulgham. Disable this code when the GPU process is enabled. As a follow-up, I plan to disable the runtime setting for Media in the GPU process for Cocoa platforms, since that should never be turned off. * Source/WebKit/Shared/WebProcessDataStoreParameters.h: * Source/WebKit/Shared/WebProcessDataStoreParameters.serialization.in: * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::webProcessDataStoreParameters): * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformSetWebsiteDataStoreParameters): Canonical link: https://commits.webkit.org/271677@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a9177: Unreviewed, fix downlevel builds after 271650@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a91772c75345ca2ce4e27ac7cb16004c2dec568 https://github.com/WebKit/WebKit/commit/3a91772c75345ca2ce4e27ac7cb16004c2dec568 Author: Abrar Rahman Protyasha Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h Log Message: --- Unreviewed, fix downlevel builds after 271650@main rdar://119317531 Unreviewed build fix for downlevel builds after 271650@main. CGPDFLayout.h is only available on MacOS Sonoma and iOS 17, but we were including it unconditionally. We should guard its inclusion around UNIFIED_PDF so that it only gets pulled when available. * Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h: Canonical link: https://commits.webkit.org/271676@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dedf70: [CSS] Mark selector as implicit to ignore them in ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dedf708653ff64d0743e6be773311fec317cd601 https://github.com/WebKit/WebKit/commit/dedf708653ff64d0743e6be773311fec317cd601 Author: Matthieu Dubet Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-specificity-expected.txt M Source/WebCore/css/CSSSelector.cpp M Source/WebCore/css/CSSSelector.h M Source/WebCore/css/parser/CSSParserImpl.cpp Log Message: --- [CSS] Mark selector as implicit to ignore them in specificity calculation https://bugs.webkit.org/show_bug.cgi?id=265992 rdar://119307433 Reviewed by Antti Koivisto. We sometimes insert non author written selectors in the selector list (for cases like `:has(> foo)` or scoped or nested selectors). We should not count those implicit selectors in the specificity calculation. * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-specificity-expected.txt: * Source/WebCore/css/CSSSelector.cpp: (WebCore::SelectorSpecificity::specificityTuple const): (WebCore::SelectorSpecificity::debugDescription const): (WebCore::operator<<): (WebCore::selectorSpecificity): (WebCore::maxSpecificity): (WebCore::simpleSelectorSpecificity): (WebCore::CSSSelector::computeSpecificityTuple const): (WebCore::CSSSelector::CSSSelector): * Source/WebCore/css/CSSSelector.h: (WebCore::CSSSelector::setImplicit): (WebCore::CSSSelector::isImplicit const): * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::consumeStyleRule): Canonical link: https://commits.webkit.org/271675@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 42558b: Generate serialization of API::Number
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 42558b897a355c69da5a3d95cac60b6588e5d881 https://github.com/WebKit/WebKit/commit/42558b897a355c69da5a3d95cac60b6588e5d881 Author: Alex Christensen Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/API/APINumber.h A Source/WebKit/Shared/API/APINumber.serialization.in M Source/WebKit/Shared/API/c/WKSharedAPICast.h M Source/WebKit/Shared/Cocoa/WKNSNumber.h M Source/WebKit/Shared/Cocoa/WKNSNumber.mm M Source/WebKit/Shared/UserData.cpp M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Generate serialization of API::Number https://bugs.webkit.org/show_bug.cgi?id=265983 Reviewed by Chris Dumez. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/API/APINumber.h: (API::Number::Number): (API::Boolean::create): (API::Boolean::Boolean): (API::Double::create): (API::Double::Double): (API::UInt64::create): (API::UInt64::UInt64): (API::Int64::create): (API::Int64::Int64): (API::Number::create): Deleted. (API::Number::encode const): Deleted. (API::Number::decode): Deleted. * Source/WebKit/Shared/API/APINumber.serialization.in: Added. * Source/WebKit/Shared/API/c/WKSharedAPICast.h: * Source/WebKit/Shared/Cocoa/WKNSNumber.h: (): Deleted. * Source/WebKit/Shared/Cocoa/WKNSNumber.mm: (-[WKNSNumber dealloc]): * Source/WebKit/Shared/UserData.cpp: (WebKit::UserData::encode): (WebKit::UserData::decode): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/271674@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ebf0de: Unreviewed, reverting 271668@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ebf0de3e4b75b8bb7784c0bdc292dea394e09e70 https://github.com/WebKit/WebKit/commit/ebf0de3e4b75b8bb7784c0bdc292dea394e09e70 Author: Jonathan Bedard Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/ThirdParty/libwebrtc/Configurations/Base-libvpx.xcconfig M Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/BUILD.gn M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/OWNERS M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/README.chromium M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/generate_gni.sh M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/libvpx_srcs.gni M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/lint_config.sh M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/run_perl.py M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_config.c M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_config.c M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_config.c M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_config.c M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vpx_config.h M
[webkit-changes] [WebKit/WebKit] 949236: Port ConsumerSharedCARingBuffer::Handle to the new...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 949236d50e8989b1aacebd090a180471ca9218e3 https://github.com/WebKit/WebKit/commit/949236d50e8989b1aacebd090a180471ca9218e3 Author: Chris Dumez Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/Cocoa/SharedCARingBuffer.h A Source/WebKit/Shared/Cocoa/SharedCARingBuffer.serialization.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Port ConsumerSharedCARingBuffer::Handle to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=265951 Reviewed by Alex Christensen. * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/Cocoa/SharedCARingBuffer.h: (WebKit::ConsumerSharedCARingBufferHandle::takeOwnershipOfMemory): (WebKit::ConsumerSharedCARingBuffer::Handle::encode): Deleted. (WebKit::ConsumerSharedCARingBuffer::Handle::decode): Deleted. * Source/WebKit/Shared/Cocoa/SharedCARingBuffer.serialization.in: Added. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/271672@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 197177: Port SerializedScriptValue to the new IPC serializ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 197177abbd7c527be4856a691f8f42c6c1768f8d https://github.com/WebKit/WebKit/commit/197177abbd7c527be4856a691f8f42c6c1768f8d Author: Chris Dumez Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/JavaScriptCore/runtime/ArrayBuffer.cpp M Source/JavaScriptCore/runtime/ArrayBuffer.h M Source/WebCore/Headers.cmake M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/js/SerializedScriptValue.cpp M Source/WebCore/bindings/js/SerializedScriptValue.h M Source/WebCore/html/OffscreenCanvas.h M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Port SerializedScriptValue to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=265904 Reviewed by Alex Christensen. * Source/JavaScriptCore/runtime/ArrayBuffer.cpp: (JSC::ArrayBufferContents::fromDataSpan): * Source/JavaScriptCore/runtime/ArrayBuffer.h: * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::SerializedScriptValue): * Source/WebCore/bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValue::arrayBufferContentsArray const): (WebCore::SerializedScriptValue::detachedRTCDataChannels const): (WebCore::SerializedScriptValue::serializedVideoChunks const): (WebCore::SerializedScriptValue::serializedAudioChunks const): (WebCore::SerializedScriptValue::encode const): Deleted. (WebCore::SerializedScriptValue::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder>::encode): Deleted. (IPC::ArgumentCoder>::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/271671@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b7c1e9: [CSS] Activate the CSS @scope feature in stable
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b7c1e9880ff4745bcf53a671739d0e875937e380 https://github.com/WebKit/WebKit/commit/b7c1e9880ff4745bcf53a671739d0e875937e380 Author: Matthieu Dubet Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- [CSS] Activate the CSS @scope feature in stable rdar://119261250 Reviewed by Tim Nguyen. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/271670@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d09702: [IFC][Ruby] Fix layout-bounds based line box stret...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d09702666d458c363d5a96a7ee258b6d8fc9661c https://github.com/WebKit/WebKit/commit/d09702666d458c363d5a96a7ee258b6d8fc9661c Author: Alan Baradlay Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp Log Message: --- [IFC][Ruby] Fix layout-bounds based line box stretching in vertical writing mode (mostly inter-character annotation) https://bugs.webkit.org/show_bug.cgi?id=265968 Reviewed by Antti Koivisto. 1. Move annotation box stretching after ideographic layout bounds adjustment 2. Use the correct baseline type when checking if (vertical) annotation box fits * Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp: (WebCore::Layout::LineBoxBuilder::build): (WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes): * Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h: * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp: (WebCore::Layout::RubyFormattingContext::adjustLayoutBoundsAndStretchAncestorRubyBase): Canonical link: https://commits.webkit.org/271669@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0e8326: Update libvpx up to M120
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0e8326a7acf5ab253777b72e72457ef02e84d757 https://github.com/WebKit/WebKit/commit/0e8326a7acf5ab253777b72e72457ef02e84d757 Author: Youenn Fablet Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/ThirdParty/libwebrtc/Configurations/Base-libvpx.xcconfig M Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/BUILD.gn M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/OWNERS M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/README.chromium M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/generate_gni.sh M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/libvpx_srcs.gni M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/lint_config.sh M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/run_perl.py M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_config.c M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_config.c M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_config.c M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_config.c M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vpx_config.h M
[webkit-changes] [WebKit/WebKit] 1009bf: Cherry-pick 266809@main (deb6f171e956). https://bu...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: 1009bfa42659283ea69e9dbb378715b46d6b91c8 https://github.com/WebKit/WebKit/commit/1009bfa42659283ea69e9dbb378715b46d6b91c8 Author: Mike Wyrzykowski Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebCore/rendering/RenderVideo.cpp M Source/WebCore/rendering/RenderVideo.h Log Message: --- Cherry-pick 266809@main (deb6f171e956). https://bugs.webkit.org/show_bug.cgi?id=259171 Revert Resizing video on YouTube can result in aliasing https://bugs.webkit.org/show_bug.cgi?id=259171 Unreviewed revert 266284@main as it causes a regression opening to fullscreen. * Source/WebCore/rendering/RenderVideo.cpp: (WebCore::areAspectRatiosEssentiallyEqual): (WebCore::RenderVideo::videoBox const): (WebCore::RenderVideo::updatePlayer): (WebCore::contentSizeAlmostEqualsFrameSize): Deleted. (WebCore::RenderVideo::inElementOrVideoFullscreen const): Deleted. * Source/WebCore/rendering/RenderVideo.h: Canonical link: https://commits.webkit.org/266809@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fdf03b: REGRESSION (271011@main): [ Ventura+ x86_64 wk2 ] ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fdf03b86449c12a28214ee47eee06577e538f4e3 https://github.com/WebKit/WebKit/commit/fdf03b86449c12a28214ee47eee06577e538f4e3 Author: Youenn Fablet Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M LayoutTests/webrtc/multi-video.html Log Message: --- REGRESSION (271011@main): [ Ventura+ x86_64 wk2 ] webrtc/multi-video.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=265700 rdar://119051908 Reviewed by Jean-Yves Avenard. Mock camera sources are now using a buffer pool just like regular cameras. This allows to check potential leaks cases. In this case, LayoutTests/webrtc/multi-video.html is encoding six times the same stream. This makes slow bots potentially having 10 video frames in the pipeline, thus blocking the mock camera. To prevent this, we are reducing the frame rate by 6, which should get us back to a regular case where things should work out well. * LayoutTests/webrtc/multi-video.html: Canonical link: https://commits.webkit.org/271667@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ea8989: [WPE][GTK][Debug] Some `imported/w3c/web-platform-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ea8989bde13eb88fcaa2eeb5bf5761b2c03b25b2 https://github.com/WebKit/WebKit/commit/ea8989bde13eb88fcaa2eeb5bf5761b2c03b25b2 Author: Vitaly Dyachkov Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [WPE][GTK][Debug] Some `imported/w3c/web-platform-tests/editing/run` are flaky timeouts https://bugs.webkit.org/show_bug.cgi?id=265942 Unreviewed test gardening. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/271666@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 195082: [CSS] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 195082ca4f51252e608bbdd9753db2ed5aeb6d96 https://github.com/WebKit/WebKit/commit/195082ca4f51252e608bbdd9753db2ed5aeb6d96 Author: Matthieu Dubet Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M LayoutTests/TestExpectations Log Message: --- [CSS] Unreviewed test gardening (css-nesting and css-scoping) * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/271665@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
