[webkit-changes] [295005] tags/WebKit-7614.1.14.1.15/

[bshafiei]

Title: [295005] tags/WebKit-7614.1.14.1.15/








Revision 295005
Author bshaf...@apple.com
Date 2022-05-28 16:33:17 -0700 (Sat, 28 May 2022)


Log Message
Tag WebKit-7614.1.14.1.15.

Added Paths

tags/WebKit-7614.1.14.1.15/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [295004] branches/safari-7614.1.14.1-branch/Source

[bshafiei]

Title: [295004] branches/safari-7614.1.14.1-branch/Source








Revision 295004
Author bshaf...@apple.com
Date 2022-05-28 15:58:01 -0700 (Sat, 28 May 2022)


Log Message
Versioning.

WebKit-7614.1.14.1.15

Modified Paths

branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (295003 => 295004)

--- branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-28 18:00:06 UTC (rev 295003)
+++ branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-28 22:58:01 UTC (rev 295004)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 14;
+NANO_VERSION = 15;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (295003 => 295004)

--- branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-28 18:00:06 UTC (rev 295003)
+++ branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-28 22:58:01 UTC (rev 295004)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 14;
+NANO_VERSION = 15;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (295003 => 295004)

--- branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-28 18:00:06 UTC (rev 295003)
+++ branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-28 22:58:01 UTC (rev 295004)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 14;
+NANO_VERSION = 15;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig (295003 => 295004)

--- branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-28 18:00:06 UTC (rev 295003)
+++ branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-28 22:58:01 UTC (rev 295004)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 14;
+NANO_VERSION = 15;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (295003 => 295004)

--- branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-28 18:00:06 UTC (rev 295003)
+++ branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-28 22:58:01 UTC (rev 295004)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 14;
+NANO_VERSION = 15;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig (295003 => 295004)

--- branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-28 18:00:06 UTC (rev 295003)
+++ branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-28 22:58:01 UTC (rev 295004)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION 

[webkit-changes] [294867] tags/WebKit-7614.1.14.1.12/

[bshafiei]

Title: [294867] tags/WebKit-7614.1.14.1.12/








Revision 294867
Author bshaf...@apple.com
Date 2022-05-25 20:49:06 -0700 (Wed, 25 May 2022)


Log Message
Tag WebKit-7614.1.14.1.12.

Added Paths

tags/WebKit-7614.1.14.1.12/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [294865] branches/safari-7614.1.14.1-branch/Source

[bshafiei]

Title: [294865] branches/safari-7614.1.14.1-branch/Source








Revision 294865
Author bshaf...@apple.com
Date 2022-05-25 20:39:27 -0700 (Wed, 25 May 2022)


Log Message
Versioning.

WebKit-7614.1.14.1.12

Modified Paths

branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-7614.1.14.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294864 => 294865)

--- branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-26 03:15:16 UTC (rev 294864)
+++ branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-05-26 03:39:27 UTC (rev 294865)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 11;
+NANO_VERSION = 12;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294864 => 294865)

--- branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-26 03:15:16 UTC (rev 294864)
+++ branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-05-26 03:39:27 UTC (rev 294865)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 11;
+NANO_VERSION = 12;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294864 => 294865)

--- branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-26 03:15:16 UTC (rev 294864)
+++ branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-05-26 03:39:27 UTC (rev 294865)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 11;
+NANO_VERSION = 12;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig (294864 => 294865)

--- branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-26 03:15:16 UTC (rev 294864)
+++ branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig	2022-05-26 03:39:27 UTC (rev 294865)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 11;
+NANO_VERSION = 12;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294864 => 294865)

--- branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-26 03:15:16 UTC (rev 294864)
+++ branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-05-26 03:39:27 UTC (rev 294865)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION = 1;
-NANO_VERSION = 11;
+NANO_VERSION = 12;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig (294864 => 294865)

--- branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-26 03:15:16 UTC (rev 294864)
+++ branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig	2022-05-26 03:39:27 UTC (rev 294865)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
 MICRO_VERSION 

[webkit-changes] [288084] tags/Safari-612.4.9.0.3/

[bshafiei]

Title: [288084] tags/Safari-612.4.9.0.3/








Revision 288084
Author bshaf...@apple.com
Date 2022-01-16 19:56:40 -0800 (Sun, 16 Jan 2022)


Log Message
Tag Safari-612.4.9.0.3.

Added Paths

tags/Safari-612.4.9.0.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [288083] tags/Safari-612.4.9.1.5/

[bshafiei]

Title: [288083] tags/Safari-612.4.9.1.5/








Revision 288083
Author bshaf...@apple.com
Date 2022-01-16 19:54:47 -0800 (Sun, 16 Jan 2022)


Log Message
Tag Safari-612.4.9.1.5.

Added Paths

tags/Safari-612.4.9.1.5/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [288082] branches/safari-612.4.9.0-branch

[bshafiei]

Title: [288082] branches/safari-612.4.9.0-branch








Revision 288082
Author bshaf...@apple.com
Date 2022-01-16 19:49:56 -0800 (Sun, 16 Jan 2022)


Log Message
Cherry-pick r288078. rdar://problem/85801310

database names leak cross-origin within the same browser session
https://bugs.webkit.org/show_bug.cgi?id=233548

Reviewed by Geoff Garen.

Source/WebCore:

Test: http/tests/security/getdatabases-crossorigin.html

* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::getAllDatabaseNamesAndVersions): When iterating the set of all open
  UniqueIDBDatabases, only add them to the results list if their origins match.

* page/ClientOrigin.h:
(WebCore::ClientOrigin::operator!= const):

LayoutTests:

* http/tests/security/getdatabases-crossorigin-expected.txt: Added.
* http/tests/security/getdatabases-crossorigin.html: Added.
* http/tests/security/resources/getdatabases-otherframe.html: Added.
* http/tests/security/resources/getdatabases-otherwindow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.4.9.0-branch/LayoutTests/ChangeLog
branches/safari-612.4.9.0-branch/Source/WebCore/ChangeLog
branches/safari-612.4.9.0-branch/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp
branches/safari-612.4.9.0-branch/Source/WebCore/page/ClientOrigin.h


Added Paths

branches/safari-612.4.9.0-branch/LayoutTests/http/tests/security/getdatabases-crossorigin-expected.txt
branches/safari-612.4.9.0-branch/LayoutTests/http/tests/security/getdatabases-crossorigin.html
branches/safari-612.4.9.0-branch/LayoutTests/http/tests/security/resources/getdatabases-otherframe.html
branches/safari-612.4.9.0-branch/LayoutTests/http/tests/security/resources/getdatabases-otherwindow.html




Diff

Modified: branches/safari-612.4.9.0-branch/LayoutTests/ChangeLog (288081 => 288082)

--- branches/safari-612.4.9.0-branch/LayoutTests/ChangeLog	2022-01-17 03:46:57 UTC (rev 288081)
+++ branches/safari-612.4.9.0-branch/LayoutTests/ChangeLog	2022-01-17 03:49:56 UTC (rev 288082)
@@ -1,3 +1,45 @@
+2022-01-16  Russell Epstein  
+
+Cherry-pick r288078. rdar://problem/85801310
+
+database names leak cross-origin within the same browser session
+https://bugs.webkit.org/show_bug.cgi?id=233548
+
+Reviewed by Geoff Garen.
+
+Source/WebCore:
+
+Test: http/tests/security/getdatabases-crossorigin.html
+
+* Modules/indexeddb/server/IDBServer.cpp:
+(WebCore::IDBServer::IDBServer::getAllDatabaseNamesAndVersions): When iterating the set of all open
+  UniqueIDBDatabases, only add them to the results list if their origins match.
+
+* page/ClientOrigin.h:
+(WebCore::ClientOrigin::operator!= const):
+
+LayoutTests:
+
+* http/tests/security/getdatabases-crossorigin-expected.txt: Added.
+* http/tests/security/getdatabases-crossorigin.html: Added.
+* http/tests/security/resources/getdatabases-otherframe.html: Added.
+* http/tests/security/resources/getdatabases-otherwindow.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-01-16  Brady Eidson  
+
+database names leak cross-origin within the same browser session
+https://bugs.webkit.org/show_bug.cgi?id=233548
+
+Reviewed by Geoff Garen.
+
+* http/tests/security/getdatabases-crossorigin-expected.txt: Added.
+* http/tests/security/getdatabases-crossorigin.html: Added.
+* http/tests/security/resources/getdatabases-otherframe.html: Added.
+* http/tests/security/resources/getdatabases-otherwindow.html: Added.
+
 2022-01-07  Russell Epstein  
 
 Cherry-pick r286094. rdar://problem/87125111


Added: branches/safari-612.4.9.0-branch/LayoutTests/http/tests/security/getdatabases-crossorigin-expected.txt (0 => 288082)

--- branches/safari-612.4.9.0-branch/LayoutTests/http/tests/security/getdatabases-crossorigin-expected.txt	(rev 0)
+++ branches/safari-612.4.9.0-branch/LayoutTests/http/tests/security/getdatabases-crossorigin-expected.txt	2022-01-17 03:49:56 UTC (rev 288082)
@@ -0,0 +1,4 @@
+CONSOLE MESSAGE: Message received from other context
+CONSOLE MESSAGE: Message received from other context
+CONSOLE MESSAGE: PASS
+


Added: branches/safari-612.4.9.0-branch/LayoutTests/http/tests/security/getdatabases-crossorigin.html (0 => 288082)

--- branches/safari-612.4.9.0-branch/LayoutTests/http/tests/security/getdatabases-crossorigin.html	(rev 0)
+++ branches/safari-612.4.9.0-branch/LayoutTests/http/tests/security/getdatabases-crossorigin.html	2022-01-17 03:49:56 UTC (rev 288082)
@@ -0,0 +1,43 @@
+
+
+
+
+
+if (window.location.hostname == "localhost")
+console.log("FAIL: Must be run as 127.0.0.1, not localhost");
+
+if 

[webkit-changes] [288081] branches/safari-612.4.9.1-branch

[bshafiei]

Title: [288081] branches/safari-612.4.9.1-branch








Revision 288081
Author bshaf...@apple.com
Date 2022-01-16 19:46:57 -0800 (Sun, 16 Jan 2022)


Log Message
Cherry-pick r288078. rdar://problem/85801310

database names leak cross-origin within the same browser session
https://bugs.webkit.org/show_bug.cgi?id=233548

Reviewed by Geoff Garen.

Source/WebCore:

Test: http/tests/security/getdatabases-crossorigin.html

* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::getAllDatabaseNamesAndVersions): When iterating the set of all open
  UniqueIDBDatabases, only add them to the results list if their origins match.

* page/ClientOrigin.h:
(WebCore::ClientOrigin::operator!= const):

LayoutTests:

* http/tests/security/getdatabases-crossorigin-expected.txt: Added.
* http/tests/security/getdatabases-crossorigin.html: Added.
* http/tests/security/resources/getdatabases-otherframe.html: Added.
* http/tests/security/resources/getdatabases-otherwindow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.4.9.1-branch/LayoutTests/ChangeLog
branches/safari-612.4.9.1-branch/Source/WebCore/ChangeLog
branches/safari-612.4.9.1-branch/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp
branches/safari-612.4.9.1-branch/Source/WebCore/page/ClientOrigin.h


Added Paths

branches/safari-612.4.9.1-branch/LayoutTests/http/tests/security/getdatabases-crossorigin-expected.txt
branches/safari-612.4.9.1-branch/LayoutTests/http/tests/security/getdatabases-crossorigin.html
branches/safari-612.4.9.1-branch/LayoutTests/http/tests/security/resources/getdatabases-otherframe.html
branches/safari-612.4.9.1-branch/LayoutTests/http/tests/security/resources/getdatabases-otherwindow.html




Diff

Modified: branches/safari-612.4.9.1-branch/LayoutTests/ChangeLog (288080 => 288081)

--- branches/safari-612.4.9.1-branch/LayoutTests/ChangeLog	2022-01-17 03:41:20 UTC (rev 288080)
+++ branches/safari-612.4.9.1-branch/LayoutTests/ChangeLog	2022-01-17 03:46:57 UTC (rev 288081)
@@ -1,3 +1,45 @@
+2022-01-16  Russell Epstein  
+
+Cherry-pick r288078. rdar://problem/85801310
+
+database names leak cross-origin within the same browser session
+https://bugs.webkit.org/show_bug.cgi?id=233548
+
+Reviewed by Geoff Garen.
+
+Source/WebCore:
+
+Test: http/tests/security/getdatabases-crossorigin.html
+
+* Modules/indexeddb/server/IDBServer.cpp:
+(WebCore::IDBServer::IDBServer::getAllDatabaseNamesAndVersions): When iterating the set of all open
+  UniqueIDBDatabases, only add them to the results list if their origins match.
+
+* page/ClientOrigin.h:
+(WebCore::ClientOrigin::operator!= const):
+
+LayoutTests:
+
+* http/tests/security/getdatabases-crossorigin-expected.txt: Added.
+* http/tests/security/getdatabases-crossorigin.html: Added.
+* http/tests/security/resources/getdatabases-otherframe.html: Added.
+* http/tests/security/resources/getdatabases-otherwindow.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-01-16  Brady Eidson  
+
+database names leak cross-origin within the same browser session
+https://bugs.webkit.org/show_bug.cgi?id=233548
+
+Reviewed by Geoff Garen.
+
+* http/tests/security/getdatabases-crossorigin-expected.txt: Added.
+* http/tests/security/getdatabases-crossorigin.html: Added.
+* http/tests/security/resources/getdatabases-otherframe.html: Added.
+* http/tests/security/resources/getdatabases-otherwindow.html: Added.
+
 2022-01-07  Russell Epstein  
 
 Cherry-pick r286094. rdar://problem/87125111


Added: branches/safari-612.4.9.1-branch/LayoutTests/http/tests/security/getdatabases-crossorigin-expected.txt (0 => 288081)

--- branches/safari-612.4.9.1-branch/LayoutTests/http/tests/security/getdatabases-crossorigin-expected.txt	(rev 0)
+++ branches/safari-612.4.9.1-branch/LayoutTests/http/tests/security/getdatabases-crossorigin-expected.txt	2022-01-17 03:46:57 UTC (rev 288081)
@@ -0,0 +1,4 @@
+CONSOLE MESSAGE: Message received from other context
+CONSOLE MESSAGE: Message received from other context
+CONSOLE MESSAGE: PASS
+


Added: branches/safari-612.4.9.1-branch/LayoutTests/http/tests/security/getdatabases-crossorigin.html (0 => 288081)

--- branches/safari-612.4.9.1-branch/LayoutTests/http/tests/security/getdatabases-crossorigin.html	(rev 0)
+++ branches/safari-612.4.9.1-branch/LayoutTests/http/tests/security/getdatabases-crossorigin.html	2022-01-17 03:46:57 UTC (rev 288081)
@@ -0,0 +1,43 @@
+
+
+
+
+
+if (window.location.hostname == "localhost")
+console.log("FAIL: Must be run as 127.0.0.1, not localhost");
+
+if 

[webkit-changes] [288080] branches/safari-612.4.9.1-branch/Source

[bshafiei]

Title: [288080] branches/safari-612.4.9.1-branch/Source








Revision 288080
Author bshaf...@apple.com
Date 2022-01-16 19:41:20 -0800 (Sun, 16 Jan 2022)


Log Message
Versioning.

WebKit-7612.4.9.1.5

Modified Paths

branches/safari-612.4.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.4.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.4.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.4.9.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.4.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.4.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.4.9.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.4.9.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.4.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (288079 => 288080)

--- branches/safari-612.4.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-01-17 03:36:58 UTC (rev 288079)
+++ branches/safari-612.4.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-01-17 03:41:20 UTC (rev 288080)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 9;
 MICRO_VERSION = 1;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.4.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (288079 => 288080)

--- branches/safari-612.4.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-01-17 03:36:58 UTC (rev 288079)
+++ branches/safari-612.4.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-01-17 03:41:20 UTC (rev 288080)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 9;
 MICRO_VERSION = 1;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.4.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (288079 => 288080)

--- branches/safari-612.4.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-01-17 03:36:58 UTC (rev 288079)
+++ branches/safari-612.4.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-01-17 03:41:20 UTC (rev 288080)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 9;
 MICRO_VERSION = 1;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.4.9.1-branch/Source/WebCore/Configurations/Version.xcconfig (288079 => 288080)

--- branches/safari-612.4.9.1-branch/Source/WebCore/Configurations/Version.xcconfig	2022-01-17 03:36:58 UTC (rev 288079)
+++ branches/safari-612.4.9.1-branch/Source/WebCore/Configurations/Version.xcconfig	2022-01-17 03:41:20 UTC (rev 288080)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 9;
 MICRO_VERSION = 1;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.4.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (288079 => 288080)

--- branches/safari-612.4.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-01-17 03:36:58 UTC (rev 288079)
+++ branches/safari-612.4.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-01-17 03:41:20 UTC (rev 288080)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 9;
 MICRO_VERSION = 1;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.4.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (288079 => 288080)

--- branches/safari-612.4.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-01-17 03:36:58 UTC (rev 288079)
+++ branches/safari-612.4.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-01-17 03:41:20 UTC (rev 288080)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 9;
 MICRO_VERSION = 1;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = 

[webkit-changes] [288079] branches/safari-612.4.9.0-branch/Source

[bshafiei]

Title: [288079] branches/safari-612.4.9.0-branch/Source








Revision 288079
Author bshaf...@apple.com
Date 2022-01-16 19:36:58 -0800 (Sun, 16 Jan 2022)


Log Message
Versioning.

WebKit-7612.4.9.0.3

Modified Paths

branches/safari-612.4.9.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.4.9.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.4.9.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.4.9.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.4.9.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.4.9.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.4.9.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.4.9.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.4.9.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (288078 => 288079)

--- branches/safari-612.4.9.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-01-17 03:35:16 UTC (rev 288078)
+++ branches/safari-612.4.9.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2022-01-17 03:36:58 UTC (rev 288079)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 9;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.4.9.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (288078 => 288079)

--- branches/safari-612.4.9.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-01-17 03:35:16 UTC (rev 288078)
+++ branches/safari-612.4.9.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2022-01-17 03:36:58 UTC (rev 288079)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 9;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.4.9.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (288078 => 288079)

--- branches/safari-612.4.9.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-01-17 03:35:16 UTC (rev 288078)
+++ branches/safari-612.4.9.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2022-01-17 03:36:58 UTC (rev 288079)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 9;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.4.9.0-branch/Source/WebCore/Configurations/Version.xcconfig (288078 => 288079)

--- branches/safari-612.4.9.0-branch/Source/WebCore/Configurations/Version.xcconfig	2022-01-17 03:35:16 UTC (rev 288078)
+++ branches/safari-612.4.9.0-branch/Source/WebCore/Configurations/Version.xcconfig	2022-01-17 03:36:58 UTC (rev 288079)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 9;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.4.9.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (288078 => 288079)

--- branches/safari-612.4.9.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-01-17 03:35:16 UTC (rev 288078)
+++ branches/safari-612.4.9.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2022-01-17 03:36:58 UTC (rev 288079)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 9;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.4.9.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (288078 => 288079)

--- branches/safari-612.4.9.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-01-17 03:35:16 UTC (rev 288078)
+++ branches/safari-612.4.9.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2022-01-17 03:36:58 UTC (rev 288079)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 9;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = 

[webkit-changes] [286043] tags/Safari-612.3.6.1.5/

[bshafiei]

Title: [286043] tags/Safari-612.3.6.1.5/








Revision 286043
Author bshaf...@apple.com
Date 2021-11-18 19:12:56 -0800 (Thu, 18 Nov 2021)


Log Message
Tag Safari-612.3.6.1.5.

Added Paths

tags/Safari-612.3.6.1.5/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285757] tags/Safari-613.1.7.4/

[bshafiei]

Title: [285757] tags/Safari-613.1.7.4/








Revision 285757
Author bshaf...@apple.com
Date 2021-11-12 15:56:07 -0800 (Fri, 12 Nov 2021)


Log Message
Tag Safari-613.1.7.4.

Added Paths

tags/Safari-613.1.7.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285750] branches/safari-613.1.7-branch/Source/WebCore/PAL

[bshafiei]

Title: [285750] branches/safari-613.1.7-branch/Source/WebCore/PAL








Revision 285750
Author bshaf...@apple.com
Date 2021-11-12 15:48:51 -0800 (Fri, 12 Nov 2021)


Log Message
Cherry-pick r285744. rdar://problem/85341122

Stop statically declaring various UIFoundation constants in NSAttributedStringSPI.h
https://bugs.webkit.org/show_bug.cgi?id=233064
rdar://85341122

Reviewed by Tim Horton.

Replace these static NSString definitions with soft-linked constants instead.

* pal/spi/cocoa/NSAttributedStringSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.7-branch/Source/WebCore/PAL/ChangeLog
branches/safari-613.1.7-branch/Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h




Diff

Modified: branches/safari-613.1.7-branch/Source/WebCore/PAL/ChangeLog (285749 => 285750)

--- branches/safari-613.1.7-branch/Source/WebCore/PAL/ChangeLog	2021-11-12 23:47:33 UTC (rev 285749)
+++ branches/safari-613.1.7-branch/Source/WebCore/PAL/ChangeLog	2021-11-12 23:48:51 UTC (rev 285750)
@@ -1,3 +1,32 @@
+2021-11-12  Babak Shafiei  
+
+Cherry-pick r285744. rdar://problem/85341122
+
+Stop statically declaring various UIFoundation constants in NSAttributedStringSPI.h
+https://bugs.webkit.org/show_bug.cgi?id=233064
+rdar://85341122
+
+Reviewed by Tim Horton.
+
+Replace these static NSString definitions with soft-linked constants instead.
+
+* pal/spi/cocoa/NSAttributedStringSPI.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-11-12  Wenson Hsieh  
+
+Stop statically declaring various UIFoundation constants in NSAttributedStringSPI.h
+https://bugs.webkit.org/show_bug.cgi?id=233064
+rdar://85341122
+
+Reviewed by Tim Horton.
+
+Replace these static NSString definitions with soft-linked constants instead.
+
+* pal/spi/cocoa/NSAttributedStringSPI.h:
+
 2021-10-29  Alex Christensen  
 
 Unreviewed, reverting r284917.


Modified: branches/safari-613.1.7-branch/Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h (285749 => 285750)

--- branches/safari-613.1.7-branch/Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h	2021-11-12 23:47:33 UTC (rev 285749)
+++ branches/safari-613.1.7-branch/Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h	2021-11-12 23:48:51 UTC (rev 285750)
@@ -95,6 +95,32 @@
 #define NSMarkedClauseSegmentAttributeName getNSMarkedClauseSegmentAttributeName()
 SOFT_LINK_CONSTANT(UIFoundation, NSTextAlternativesAttributeName, NSString *)
 #define NSTextAlternativesAttributeName getNSTextAlternativesAttributeName()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerCircle, NSString *)
+#define NSTextListMarkerCircle getNSTextListMarkerCircle()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerDisc, NSString *)
+#define NSTextListMarkerDisc getNSTextListMarkerDisc()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerSquare, NSString *)
+#define NSTextListMarkerSquare getNSTextListMarkerSquare()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerLowercaseHexadecimal, NSString *)
+#define NSTextListMarkerLowercaseHexadecimal getNSTextListMarkerLowercaseHexadecimal()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerUppercaseHexadecimal, NSString *)
+#define NSTextListMarkerUppercaseHexadecimal getNSTextListMarkerUppercaseHexadecimal()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerOctal, NSString *)
+#define NSTextListMarkerOctal getNSTextListMarkerOctal()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerLowercaseAlpha, NSString *)
+#define NSTextListMarkerLowercaseAlpha getNSTextListMarkerLowercaseAlpha()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerUppercaseAlpha, NSString *)
+#define NSTextListMarkerUppercaseAlpha getNSTextListMarkerUppercaseAlpha()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerLowercaseLatin, NSString *)
+#define NSTextListMarkerLowercaseLatin getNSTextListMarkerLowercaseLatin()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerUppercaseLatin, NSString *)
+#define NSTextListMarkerUppercaseLatin getNSTextListMarkerUppercaseLatin()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerLowercaseRoman, NSString *)
+#define NSTextListMarkerLowercaseRoman getNSTextListMarkerLowercaseRoman()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerUppercaseRoman, NSString *)
+#define NSTextListMarkerUppercaseRoman getNSTextListMarkerUppercaseRoman()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerDecimal, NSString *)
+#define NSTextListMarkerDecimal getNSTextListMarkerDecimal()
 
 // We don't softlink NSSuperscriptAttributeName because UIFoundation stopped exporting it.
 // This attribute is being deprecated at the API level, but internally UIFoundation
@@ -111,18 +137,4 @@
 - (BOOL)containsAttachments;
 @end
 
-static NSString *const 

[webkit-changes] [285749] branches/safari-613.1.7-branch/Source

[bshafiei]

Title: [285749] branches/safari-613.1.7-branch/Source








Revision 285749
Author bshaf...@apple.com
Date 2021-11-12 15:47:33 -0800 (Fri, 12 Nov 2021)


Log Message
Versioning.

WebKit-7613.1.7.4

Modified Paths

branches/safari-613.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613.1.7-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613.1.7-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613.1.7-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig (285748 => 285749)

--- branches/safari-613.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-11-12 23:45:58 UTC (rev 285748)
+++ branches/safari-613.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-11-12 23:47:33 UTC (rev 285749)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (285748 => 285749)

--- branches/safari-613.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-11-12 23:45:58 UTC (rev 285748)
+++ branches/safari-613.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-11-12 23:47:33 UTC (rev 285749)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (285748 => 285749)

--- branches/safari-613.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-11-12 23:45:58 UTC (rev 285748)
+++ branches/safari-613.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-11-12 23:47:33 UTC (rev 285749)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.7-branch/Source/WebCore/Configurations/Version.xcconfig (285748 => 285749)

--- branches/safari-613.1.7-branch/Source/WebCore/Configurations/Version.xcconfig	2021-11-12 23:45:58 UTC (rev 285748)
+++ branches/safari-613.1.7-branch/Source/WebCore/Configurations/Version.xcconfig	2021-11-12 23:47:33 UTC (rev 285749)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (285748 => 285749)

--- branches/safari-613.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-11-12 23:45:58 UTC (rev 285748)
+++ branches/safari-613.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-11-12 23:47:33 UTC (rev 285749)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (285748 => 285749)

--- branches/safari-613.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-11-12 23:45:58 UTC (rev 285748)
+++ branches/safari-613.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-11-12 23:47:33 UTC (rev 285749)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.7-branch/Source/WebKit/Configurations/Version.xcconfig (285748 => 285749)

--- branches/safari-613.1.7-branch/Source/WebKit/Configurations/Version.xcconfig	2021-11-12 23:45:58 UTC (rev 285748)
+++ branches/safari-613.1.7-branch/Source/WebKit/Configurations/Version.xcconfig	2021-11-12 23:47:33 UTC (rev 285749)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = 

[webkit-changes] [281437] tags/Safari-612.1.27.3.7/

[bshafiei]

Title: [281437] tags/Safari-612.1.27.3.7/








Revision 281437
Author bshaf...@apple.com
Date 2021-08-22 23:22:37 -0700 (Sun, 22 Aug 2021)


Log Message
Tag Safari-612.1.27.3.7.

Added Paths

tags/Safari-612.1.27.3.7/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281436] branches/safari-612.1.27.3-branch/Source/JavaScriptCore

[bshafiei]

Title: [281436] branches/safari-612.1.27.3-branch/Source/_javascript_Core








Revision 281436
Author bshaf...@apple.com
Date 2021-08-22 23:17:56 -0700 (Sun, 22 Aug 2021)


Log Message
Apply patch. rdar://problem/82196634

Modified Paths

branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.27.3-branch/Source/_javascript_Core/b3/testb3_3.cpp




Diff

Modified: branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog (281435 => 281436)

--- branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog	2021-08-23 05:46:11 UTC (rev 281435)
+++ branches/safari-612.1.27.3-branch/Source/_javascript_Core/ChangeLog	2021-08-23 06:17:56 UTC (rev 281436)
@@ -1,3 +1,16 @@
+2021-08-22  Russell Epstein  
+
+Apply patch. rdar://problem/82196634
+
+2021-08-22  Mark Lam  
+
+Build fix for bad cherry-pick of r281178.
+rdar://problem/82083485
+
+Not reviewed.
+
+* b3/testb3_3.cpp:
+
 2021-08-20  Russell Epstein  
 
 Cherry-pick r281178. rdar://problem/82083485


Modified: branches/safari-612.1.27.3-branch/Source/_javascript_Core/b3/testb3_3.cpp (281435 => 281436)

--- branches/safari-612.1.27.3-branch/Source/_javascript_Core/b3/testb3_3.cpp	2021-08-23 05:46:11 UTC (rev 281435)
+++ branches/safari-612.1.27.3-branch/Source/_javascript_Core/b3/testb3_3.cpp	2021-08-23 06:17:56 UTC (rev 281436)
@@ -3993,10 +3993,10 @@
 RUN(testZShrArgImm32(0x, 63));
 
 if (Options::useB3CanonicalizePrePostIncrements()) {
-RUN(testStorePreIndex32());
-RUN(testStorePreIndex64());
-RUN(testStorePostIndex32());
-RUN(testStorePostIndex64());
+RUN(testLoadPreIndex32());
+RUN(testLoadPreIndex64());
+RUN(testLoadPostIndex32());
+RUN(testLoadPostIndex64());
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281435] branches/safari-612.1.27.3-branch/Source

[bshafiei]

Title: [281435] branches/safari-612.1.27.3-branch/Source








Revision 281435
Author bshaf...@apple.com
Date 2021-08-22 22:46:11 -0700 (Sun, 22 Aug 2021)


Log Message
Versioning.

WebKit-7612.1.27.3.7

Modified Paths

branches/safari-612.1.27.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.27.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.27.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.27.3-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.27.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.27.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.27.3-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.27.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.27.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (281434 => 281435)

--- branches/safari-612.1.27.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-23 05:12:33 UTC (rev 281434)
+++ branches/safari-612.1.27.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-23 05:46:11 UTC (rev 281435)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 3;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (281434 => 281435)

--- branches/safari-612.1.27.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-23 05:12:33 UTC (rev 281434)
+++ branches/safari-612.1.27.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-23 05:46:11 UTC (rev 281435)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 3;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (281434 => 281435)

--- branches/safari-612.1.27.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-23 05:12:33 UTC (rev 281434)
+++ branches/safari-612.1.27.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-23 05:46:11 UTC (rev 281435)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 3;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.3-branch/Source/WebCore/Configurations/Version.xcconfig (281434 => 281435)

--- branches/safari-612.1.27.3-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-23 05:12:33 UTC (rev 281434)
+++ branches/safari-612.1.27.3-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-23 05:46:11 UTC (rev 281435)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 3;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (281434 => 281435)

--- branches/safari-612.1.27.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-23 05:12:33 UTC (rev 281434)
+++ branches/safari-612.1.27.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-23 05:46:11 UTC (rev 281435)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 3;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.27.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (281434 => 281435)

--- branches/safari-612.1.27.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-23 05:12:33 UTC (rev 281434)
+++ branches/safari-612.1.27.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-23 05:46:11 UTC (rev 281435)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 27;
 MICRO_VERSION = 3;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = 

[webkit-changes] [280126] tags/Safari-612.1.24.0.3/

[bshafiei]

Title: [280126] tags/Safari-612.1.24.0.3/








Revision 280126
Author bshaf...@apple.com
Date 2021-07-20 22:55:05 -0700 (Tue, 20 Jul 2021)


Log Message
Tag Safari-612.1.24.0.3.

Added Paths

tags/Safari-612.1.24.0.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [280125] branches/safari-612.1.24.0-branch/Source

[bshafiei]

Title: [280125] branches/safari-612.1.24.0-branch/Source








Revision 280125
Author bshaf...@apple.com
Date 2021-07-20 22:37:19 -0700 (Tue, 20 Jul 2021)


Log Message
Versioning.

WebKit-7612.1.24.0.3

Modified Paths

branches/safari-612.1.24.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.24.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.24.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.24.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.24.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.24.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.24.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.24.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.24.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (280124 => 280125)

--- branches/safari-612.1.24.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-21 04:23:21 UTC (rev 280124)
+++ branches/safari-612.1.24.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-07-21 05:37:19 UTC (rev 280125)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.24.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (280124 => 280125)

--- branches/safari-612.1.24.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-21 04:23:21 UTC (rev 280124)
+++ branches/safari-612.1.24.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-07-21 05:37:19 UTC (rev 280125)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.24.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (280124 => 280125)

--- branches/safari-612.1.24.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-21 04:23:21 UTC (rev 280124)
+++ branches/safari-612.1.24.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-07-21 05:37:19 UTC (rev 280125)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.24.0-branch/Source/WebCore/Configurations/Version.xcconfig (280124 => 280125)

--- branches/safari-612.1.24.0-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-21 04:23:21 UTC (rev 280124)
+++ branches/safari-612.1.24.0-branch/Source/WebCore/Configurations/Version.xcconfig	2021-07-21 05:37:19 UTC (rev 280125)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.24.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (280124 => 280125)

--- branches/safari-612.1.24.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-21 04:23:21 UTC (rev 280124)
+++ branches/safari-612.1.24.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-07-21 05:37:19 UTC (rev 280125)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-612.1.24.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (280124 => 280125)

--- branches/safari-612.1.24.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-21 04:23:21 UTC (rev 280124)
+++ branches/safari-612.1.24.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-07-21 05:37:19 UTC (rev 280125)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 24;
 MICRO_VERSION = 0;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = 

[webkit-changes] [273810] tags/Safari-612.1.5.2.1/

[bshafiei]

Title: [273810] tags/Safari-612.1.5.2.1/








Revision 273810
Author bshaf...@apple.com
Date 2021-03-02 20:56:51 -0800 (Tue, 02 Mar 2021)


Log Message
Tag Safari-612.1.5.2.1.

Added Paths

tags/Safari-612.1.5.2.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [273808] branches/safari-612.1.5.2-branch/Source

[bshafiei]

Title: [273808] branches/safari-612.1.5.2-branch/Source








Revision 273808
Author bshaf...@apple.com
Date 2021-03-02 20:49:07 -0800 (Tue, 02 Mar 2021)


Log Message
Versioning.

WebKit-7612.1.5.2.1

Modified Paths

branches/safari-612.1.5.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.5.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.5.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.5.2-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.5.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.5.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.5.2-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.5.2-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.5.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (273807 => 273808)

--- branches/safari-612.1.5.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-03-03 04:38:47 UTC (rev 273807)
+++ branches/safari-612.1.5.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-03-03 04:49:07 UTC (rev 273808)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
 MICRO_VERSION = 2;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.5.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (273807 => 273808)

--- branches/safari-612.1.5.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-03-03 04:38:47 UTC (rev 273807)
+++ branches/safari-612.1.5.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-03-03 04:49:07 UTC (rev 273808)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
 MICRO_VERSION = 2;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.5.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (273807 => 273808)

--- branches/safari-612.1.5.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-03-03 04:38:47 UTC (rev 273807)
+++ branches/safari-612.1.5.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-03-03 04:49:07 UTC (rev 273808)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
 MICRO_VERSION = 2;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.5.2-branch/Source/WebCore/Configurations/Version.xcconfig (273807 => 273808)

--- branches/safari-612.1.5.2-branch/Source/WebCore/Configurations/Version.xcconfig	2021-03-03 04:38:47 UTC (rev 273807)
+++ branches/safari-612.1.5.2-branch/Source/WebCore/Configurations/Version.xcconfig	2021-03-03 04:49:07 UTC (rev 273808)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
 MICRO_VERSION = 2;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-612.1.5.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (273807 => 273808)

--- branches/safari-612.1.5.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-03-03 04:38:47 UTC (rev 273807)
+++ branches/safari-612.1.5.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-03-03 04:49:07 UTC (rev 273808)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 5;
 MICRO_VERSION = 2;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string 

[webkit-changes] [273807] branches/safari-612.1.5.2-branch/

[bshafiei]

Title: [273807] branches/safari-612.1.5.2-branch/








Revision 273807
Author bshaf...@apple.com
Date 2021-03-02 20:38:47 -0800 (Tue, 02 Mar 2021)


Log Message
New branch.

Added Paths

branches/safari-612.1.5.2-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [272003] tags/Safari-611.1.10.3.2/

[bshafiei]

Title: [272003] tags/Safari-611.1.10.3.2/








Revision 272003
Author bshaf...@apple.com
Date 2021-01-27 21:35:49 -0800 (Wed, 27 Jan 2021)


Log Message
Tag Safari-611.1.10.3.2.

Added Paths

tags/Safari-611.1.10.3.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [272002] branches/safari-611.1.10.3-branch/Source

[bshafiei]

Title: [272002] branches/safari-611.1.10.3-branch/Source








Revision 272002
Author bshaf...@apple.com
Date 2021-01-27 21:28:35 -0800 (Wed, 27 Jan 2021)


Log Message
Versioning.

WebKit-7611.1.10.3.2

Modified Paths

branches/safari-611.1.10.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-611.1.10.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-611.1.10.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-611.1.10.3-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-611.1.10.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-611.1.10.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-611.1.10.3-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-611.1.10.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-611.1.10.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (272001 => 272002)

--- branches/safari-611.1.10.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-01-28 05:22:30 UTC (rev 272001)
+++ branches/safari-611.1.10.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-01-28 05:28:35 UTC (rev 272002)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 3;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (272001 => 272002)

--- branches/safari-611.1.10.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-01-28 05:22:30 UTC (rev 272001)
+++ branches/safari-611.1.10.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-01-28 05:28:35 UTC (rev 272002)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 3;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (272001 => 272002)

--- branches/safari-611.1.10.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-01-28 05:22:30 UTC (rev 272001)
+++ branches/safari-611.1.10.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-01-28 05:28:35 UTC (rev 272002)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 3;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.3-branch/Source/WebCore/Configurations/Version.xcconfig (272001 => 272002)

--- branches/safari-611.1.10.3-branch/Source/WebCore/Configurations/Version.xcconfig	2021-01-28 05:22:30 UTC (rev 272001)
+++ branches/safari-611.1.10.3-branch/Source/WebCore/Configurations/Version.xcconfig	2021-01-28 05:28:35 UTC (rev 272002)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 3;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (272001 => 272002)

--- branches/safari-611.1.10.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-01-28 05:22:30 UTC (rev 272001)
+++ branches/safari-611.1.10.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-01-28 05:28:35 UTC (rev 272002)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 3;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (272001 => 272002)

--- branches/safari-611.1.10.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-01-28 05:22:30 UTC (rev 272001)
+++ branches/safari-611.1.10.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-01-28 05:28:35 UTC (rev 272002)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 3;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = 

[webkit-changes] [272001] tags/Safari-611.1.10.2.2/

[bshafiei]

Title: [272001] tags/Safari-611.1.10.2.2/








Revision 272001
Author bshaf...@apple.com
Date 2021-01-27 21:22:30 -0800 (Wed, 27 Jan 2021)


Log Message
Tag Safari-611.1.10.2.2.

Added Paths

tags/Safari-611.1.10.2.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [271999] branches/safari-611.1.10.2-branch/Source

[bshafiei]

Title: [271999] branches/safari-611.1.10.2-branch/Source








Revision 271999
Author bshaf...@apple.com
Date 2021-01-27 21:17:43 -0800 (Wed, 27 Jan 2021)


Log Message
Versioning.

WebKit-7611.1.10.2.2

Modified Paths

branches/safari-611.1.10.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-611.1.10.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-611.1.10.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-611.1.10.2-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-611.1.10.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-611.1.10.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-611.1.10.2-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-611.1.10.2-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-611.1.10.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (271998 => 271999)

--- branches/safari-611.1.10.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-01-28 04:59:34 UTC (rev 271998)
+++ branches/safari-611.1.10.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-01-28 05:17:43 UTC (rev 271999)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (271998 => 271999)

--- branches/safari-611.1.10.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-01-28 04:59:34 UTC (rev 271998)
+++ branches/safari-611.1.10.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-01-28 05:17:43 UTC (rev 271999)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (271998 => 271999)

--- branches/safari-611.1.10.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-01-28 04:59:34 UTC (rev 271998)
+++ branches/safari-611.1.10.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-01-28 05:17:43 UTC (rev 271999)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.2-branch/Source/WebCore/Configurations/Version.xcconfig (271998 => 271999)

--- branches/safari-611.1.10.2-branch/Source/WebCore/Configurations/Version.xcconfig	2021-01-28 04:59:34 UTC (rev 271998)
+++ branches/safari-611.1.10.2-branch/Source/WebCore/Configurations/Version.xcconfig	2021-01-28 05:17:43 UTC (rev 271999)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (271998 => 271999)

--- branches/safari-611.1.10.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-01-28 04:59:34 UTC (rev 271998)
+++ branches/safari-611.1.10.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-01-28 05:17:43 UTC (rev 271999)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (271998 => 271999)

--- branches/safari-611.1.10.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-01-28 04:59:34 UTC (rev 271998)
+++ branches/safari-611.1.10.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-01-28 05:17:43 UTC (rev 271999)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = 

[webkit-changes] [271998] tags/Safari-611.1.10.0.6/

[bshafiei]

Title: [271998] tags/Safari-611.1.10.0.6/








Revision 271998
Author bshaf...@apple.com
Date 2021-01-27 20:59:34 -0800 (Wed, 27 Jan 2021)


Log Message
Tag Safari-611.1.10.0.6.

Added Paths

tags/Safari-611.1.10.0.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [271997] branches/safari-611.1.10.0-branch/Source

[bshafiei]

Title: [271997] branches/safari-611.1.10.0-branch/Source








Revision 271997
Author bshaf...@apple.com
Date 2021-01-27 20:53:44 -0800 (Wed, 27 Jan 2021)


Log Message
Versioning.

WebKit-7611.1.10.0.6

Modified Paths

branches/safari-611.1.10.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-611.1.10.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-611.1.10.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-611.1.10.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-611.1.10.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-611.1.10.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-611.1.10.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-611.1.10.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-611.1.10.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (271996 => 271997)

--- branches/safari-611.1.10.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-01-28 04:31:18 UTC (rev 271996)
+++ branches/safari-611.1.10.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-01-28 04:53:44 UTC (rev 271997)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (271996 => 271997)

--- branches/safari-611.1.10.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-01-28 04:31:18 UTC (rev 271996)
+++ branches/safari-611.1.10.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-01-28 04:53:44 UTC (rev 271997)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (271996 => 271997)

--- branches/safari-611.1.10.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-01-28 04:31:18 UTC (rev 271996)
+++ branches/safari-611.1.10.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-01-28 04:53:44 UTC (rev 271997)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.0-branch/Source/WebCore/Configurations/Version.xcconfig (271996 => 271997)

--- branches/safari-611.1.10.0-branch/Source/WebCore/Configurations/Version.xcconfig	2021-01-28 04:31:18 UTC (rev 271996)
+++ branches/safari-611.1.10.0-branch/Source/WebCore/Configurations/Version.xcconfig	2021-01-28 04:53:44 UTC (rev 271997)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (271996 => 271997)

--- branches/safari-611.1.10.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-01-28 04:31:18 UTC (rev 271996)
+++ branches/safari-611.1.10.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-01-28 04:53:44 UTC (rev 271997)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (271996 => 271997)

--- branches/safari-611.1.10.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-01-28 04:31:18 UTC (rev 271996)
+++ branches/safari-611.1.10.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-01-28 04:53:44 UTC (rev 271997)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = 

[webkit-changes] [271996] tags/Safari-611.1.10.1.5/

[bshafiei]

Title: [271996] tags/Safari-611.1.10.1.5/








Revision 271996
Author bshaf...@apple.com
Date 2021-01-27 20:31:18 -0800 (Wed, 27 Jan 2021)


Log Message
Tag Safari-611.1.10.1.5.

Added Paths

tags/Safari-611.1.10.1.5/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [271995] branches/safari-611.1.10.1-branch/Source

[bshafiei]

Title: [271995] branches/safari-611.1.10.1-branch/Source








Revision 271995
Author bshaf...@apple.com
Date 2021-01-27 20:29:40 -0800 (Wed, 27 Jan 2021)


Log Message
Versioning.

WebKit-7611.1.10.1.5

Modified Paths

branches/safari-611.1.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-611.1.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-611.1.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-611.1.10.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-611.1.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-611.1.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-611.1.10.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-611.1.10.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-611.1.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (271994 => 271995)

--- branches/safari-611.1.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-01-28 01:34:36 UTC (rev 271994)
+++ branches/safari-611.1.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-01-28 04:29:40 UTC (rev 271995)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 1;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (271994 => 271995)

--- branches/safari-611.1.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-01-28 01:34:36 UTC (rev 271994)
+++ branches/safari-611.1.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-01-28 04:29:40 UTC (rev 271995)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 1;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (271994 => 271995)

--- branches/safari-611.1.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-01-28 01:34:36 UTC (rev 271994)
+++ branches/safari-611.1.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-01-28 04:29:40 UTC (rev 271995)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 1;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.1-branch/Source/WebCore/Configurations/Version.xcconfig (271994 => 271995)

--- branches/safari-611.1.10.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-01-28 01:34:36 UTC (rev 271994)
+++ branches/safari-611.1.10.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-01-28 04:29:40 UTC (rev 271995)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 1;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (271994 => 271995)

--- branches/safari-611.1.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-01-28 01:34:36 UTC (rev 271994)
+++ branches/safari-611.1.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-01-28 04:29:40 UTC (rev 271995)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 1;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-611.1.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (271994 => 271995)

--- branches/safari-611.1.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-01-28 01:34:36 UTC (rev 271994)
+++ branches/safari-611.1.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-01-28 04:29:40 UTC (rev 271995)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 1;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = 

[webkit-changes] [271558] tags/Safari-611.1.10.0.1/Source

[bshafiei]

Title: [271558] tags/Safari-611.1.10.0.1/Source








Revision 271558
Author bshaf...@apple.com
Date 2021-01-16 12:20:58 -0800 (Sat, 16 Jan 2021)


Log Message
Versioning.

WebKit-7611.1.10.0.1

Modified Paths

tags/Safari-611.1.10.0.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-611.1.10.0.1/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
tags/Safari-611.1.10.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-611.1.10.0.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-611.1.10.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-611.1.10.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-611.1.10.0.1/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-611.1.10.0.1/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-611.1.10.0.1/Source/_javascript_Core/Configurations/Version.xcconfig (271557 => 271558)

--- tags/Safari-611.1.10.0.1/Source/_javascript_Core/Configurations/Version.xcconfig	2021-01-16 20:09:32 UTC (rev 271557)
+++ tags/Safari-611.1.10.0.1/Source/_javascript_Core/Configurations/Version.xcconfig	2021-01-16 20:20:58 UTC (rev 271558)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-611.1.10.0.1/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (271557 => 271558)

--- tags/Safari-611.1.10.0.1/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-01-16 20:09:32 UTC (rev 271557)
+++ tags/Safari-611.1.10.0.1/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-01-16 20:20:58 UTC (rev 271558)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-611.1.10.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (271557 => 271558)

--- tags/Safari-611.1.10.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-01-16 20:09:32 UTC (rev 271557)
+++ tags/Safari-611.1.10.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-01-16 20:20:58 UTC (rev 271558)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-611.1.10.0.1/Source/WebCore/Configurations/Version.xcconfig (271557 => 271558)

--- tags/Safari-611.1.10.0.1/Source/WebCore/Configurations/Version.xcconfig	2021-01-16 20:09:32 UTC (rev 271557)
+++ tags/Safari-611.1.10.0.1/Source/WebCore/Configurations/Version.xcconfig	2021-01-16 20:20:58 UTC (rev 271558)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-611.1.10.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig (271557 => 271558)

--- tags/Safari-611.1.10.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-01-16 20:09:32 UTC (rev 271557)
+++ tags/Safari-611.1.10.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-01-16 20:20:58 UTC (rev 271558)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-611.1.10.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig (271557 => 271558)

--- 

[webkit-changes] [271557] tags/Safari-611.1.10.0.1/

[bshafiei]

Title: [271557] tags/Safari-611.1.10.0.1/








Revision 271557
Author bshaf...@apple.com
Date 2021-01-16 12:09:32 -0800 (Sat, 16 Jan 2021)


Log Message
New tag.

Added Paths

tags/Safari-611.1.10.0.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [271556] branches/safari-611-branch/Source

[bshafiei]

Title: [271556] branches/safari-611-branch/Source








Revision 271556
Author bshaf...@apple.com
Date 2021-01-16 12:05:40 -0800 (Sat, 16 Jan 2021)


Log Message
Versioning.

WebKit-7611.1.14

Modified Paths

branches/safari-611-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-611-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-611-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-611-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-611-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-611-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-611-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-611-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-611-branch/Source/_javascript_Core/Configurations/Version.xcconfig (271555 => 271556)

--- branches/safari-611-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-01-16 14:28:39 UTC (rev 271555)
+++ branches/safari-611-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-01-16 20:05:40 UTC (rev 271556)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
-TINY_VERSION = 13;
+TINY_VERSION = 14;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-611-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (271555 => 271556)

--- branches/safari-611-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-01-16 14:28:39 UTC (rev 271555)
+++ branches/safari-611-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-01-16 20:05:40 UTC (rev 271556)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
-TINY_VERSION = 13;
+TINY_VERSION = 14;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-611-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (271555 => 271556)

--- branches/safari-611-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-01-16 14:28:39 UTC (rev 271555)
+++ branches/safari-611-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-01-16 20:05:40 UTC (rev 271556)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
-TINY_VERSION = 13;
+TINY_VERSION = 14;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-611-branch/Source/WebCore/Configurations/Version.xcconfig (271555 => 271556)

--- branches/safari-611-branch/Source/WebCore/Configurations/Version.xcconfig	2021-01-16 14:28:39 UTC (rev 271555)
+++ branches/safari-611-branch/Source/WebCore/Configurations/Version.xcconfig	2021-01-16 20:05:40 UTC (rev 271556)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
-TINY_VERSION = 13;
+TINY_VERSION = 14;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-611-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (271555 => 271556)

--- branches/safari-611-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-01-16 14:28:39 UTC (rev 271555)
+++ branches/safari-611-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-01-16 20:05:40 UTC (rev 271556)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
-TINY_VERSION = 13;
+TINY_VERSION = 14;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-611-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (271555 => 271556)

--- branches/safari-611-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-01-16 14:28:39 UTC (rev 271555)
+++ branches/safari-611-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-01-16 20:05:40 UTC (rev 271556)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
-TINY_VERSION = 13;
+TINY_VERSION = 14;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-611-branch/Source/WebKit/Configurations/Version.xcconfig (271555 => 271556)

--- branches/safari-611-branch/Source/WebKit/Configurations/Version.xcconfig	2021-01-16 14:28:39 UTC (rev 271555)
+++ branches/safari-611-branch/Source/WebKit/Configurations/Version.xcconfig	2021-01-16 20:05:40 UTC (rev 271556)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
-TINY_VERSION = 13;
+TINY_VERSION = 14;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-611-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (271555 => 271556)

--- branches/safari-611-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	

[webkit-changes] [271009] tags/Safari-611.1.9.3/

[bshafiei]

Title: [271009] tags/Safari-611.1.9.3/








Revision 271009
Author bshaf...@apple.com
Date 2020-12-19 16:11:11 -0800 (Sat, 19 Dec 2020)


Log Message
Tag Safari-611.1.9.3.

Added Paths

tags/Safari-611.1.9.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [271008] tags/Safari-611.1.9.2/

[bshafiei]

Title: [271008] tags/Safari-611.1.9.2/








Revision 271008
Author bshaf...@apple.com
Date 2020-12-19 16:10:21 -0800 (Sat, 19 Dec 2020)


Log Message
Tag Safari-611.1.9.2.

Added Paths

tags/Safari-611.1.9.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [271007] branches/safari-611.1.9-branch/Source

[bshafiei]

Title: [271007] branches/safari-611.1.9-branch/Source








Revision 271007
Author bshaf...@apple.com
Date 2020-12-19 16:06:00 -0800 (Sat, 19 Dec 2020)


Log Message
Versioning.

WebKit-7611.1.9.3

Modified Paths

branches/safari-611.1.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-611.1.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-611.1.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-611.1.9-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-611.1.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-611.1.9-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-611.1.9-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-611.1.9-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-611.1.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig (271006 => 271007)

--- branches/safari-611.1.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-12-20 00:05:00 UTC (rev 271006)
+++ branches/safari-611.1.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-12-20 00:06:00 UTC (rev 271007)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-611.1.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (271006 => 271007)

--- branches/safari-611.1.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-12-20 00:05:00 UTC (rev 271006)
+++ branches/safari-611.1.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-12-20 00:06:00 UTC (rev 271007)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-611.1.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (271006 => 271007)

--- branches/safari-611.1.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-12-20 00:05:00 UTC (rev 271006)
+++ branches/safari-611.1.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-12-20 00:06:00 UTC (rev 271007)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-611.1.9-branch/Source/WebCore/Configurations/Version.xcconfig (271006 => 271007)

--- branches/safari-611.1.9-branch/Source/WebCore/Configurations/Version.xcconfig	2020-12-20 00:05:00 UTC (rev 271006)
+++ branches/safari-611.1.9-branch/Source/WebCore/Configurations/Version.xcconfig	2020-12-20 00:06:00 UTC (rev 271007)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-611.1.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (271006 => 271007)

--- branches/safari-611.1.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-12-20 00:05:00 UTC (rev 271006)
+++ branches/safari-611.1.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-12-20 00:06:00 UTC (rev 271007)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-611.1.9-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (271006 => 271007)

--- branches/safari-611.1.9-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-12-20 00:05:00 UTC (rev 271006)
+++ branches/safari-611.1.9-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-12-20 00:06:00 UTC (rev 271007)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-611.1.9-branch/Source/WebKit/Configurations/Version.xcconfig (271006 => 271007)

--- branches/safari-611.1.9-branch/Source/WebKit/Configurations/Version.xcconfig	2020-12-20 00:05:00 UTC (rev 271006)
+++ branches/safari-611.1.9-branch/Source/WebKit/Configurations/Version.xcconfig	2020-12-20 00:06:00 UTC (rev 271007)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = 

[webkit-changes] [271006] branches/safari-611.1.9-branch/Source

[bshafiei]

Title: [271006] branches/safari-611.1.9-branch/Source








Revision 271006
Author bshaf...@apple.com
Date 2020-12-19 16:05:00 -0800 (Sat, 19 Dec 2020)


Log Message
Versioning.

WebKit-7611.1.9.2

Modified Paths

branches/safari-611.1.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-611.1.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-611.1.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-611.1.9-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-611.1.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-611.1.9-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-611.1.9-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-611.1.9-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-611.1.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig (271005 => 271006)

--- branches/safari-611.1.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-12-20 00:03:03 UTC (rev 271005)
+++ branches/safari-611.1.9-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-12-20 00:05:00 UTC (rev 271006)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 1;
-NANO_VERSION = 1;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
+MICRO_VERSION = 2;
+NANO_VERSION = 0;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-611.1.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (271005 => 271006)

--- branches/safari-611.1.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-12-20 00:03:03 UTC (rev 271005)
+++ branches/safari-611.1.9-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-12-20 00:05:00 UTC (rev 271006)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 1;
-NANO_VERSION = 1;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
+MICRO_VERSION = 2;
+NANO_VERSION = 0;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-611.1.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (271005 => 271006)

--- branches/safari-611.1.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-12-20 00:03:03 UTC (rev 271005)
+++ branches/safari-611.1.9-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-12-20 00:05:00 UTC (rev 271006)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 1;
-NANO_VERSION = 1;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
+MICRO_VERSION = 2;
+NANO_VERSION = 0;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-611.1.9-branch/Source/WebCore/Configurations/Version.xcconfig (271005 => 271006)

--- branches/safari-611.1.9-branch/Source/WebCore/Configurations/Version.xcconfig	2020-12-20 00:03:03 UTC (rev 271005)
+++ branches/safari-611.1.9-branch/Source/WebCore/Configurations/Version.xcconfig	2020-12-20 00:05:00 UTC (rev 271006)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 1;
-NANO_VERSION = 1;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
+MICRO_VERSION = 2;
+NANO_VERSION = 0;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-611.1.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (271005 => 271006)

--- branches/safari-611.1.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-12-20 00:03:03 UTC (rev 271005)
+++ branches/safari-611.1.9-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-12-20 00:05:00 UTC (rev 271006)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 611;
 MINOR_VERSION = 1;
 TINY_VERSION = 9;
-MICRO_VERSION = 1;
-NANO_VERSION = 1;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);

[webkit-changes] [271005] branches/safari-611.1.9-branch/Source/WebKit

[bshafiei]

Title: [271005] branches/safari-611.1.9-branch/Source/WebKit








Revision 271005
Author bshaf...@apple.com
Date 2020-12-19 16:03:03 -0800 (Sat, 19 Dec 2020)


Log Message
Cherry-pick r271004. rdar://problem/72508138

REGRESSION(r270575): [iOS] Correct GPU Process sandbox syntax error
https://bugs.webkit.org/show_bug.cgi?id=220041


Unreviewed build fix after r270575.

A closing parentheses was omitted when the 'play-audio' rule was changed to
remove its last rule.

* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-611.1.9-branch/Source/WebKit/ChangeLog
branches/safari-611.1.9-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb




Diff

Modified: branches/safari-611.1.9-branch/Source/WebKit/ChangeLog (271004 => 271005)

--- branches/safari-611.1.9-branch/Source/WebKit/ChangeLog	2020-12-19 23:55:32 UTC (rev 271004)
+++ branches/safari-611.1.9-branch/Source/WebKit/ChangeLog	2020-12-20 00:03:03 UTC (rev 271005)
@@ -1,3 +1,35 @@
+2020-12-19  Babak Shafiei  
+
+Cherry-pick r271004. rdar://problem/72508138
+
+REGRESSION(r270575): [iOS] Correct GPU Process sandbox syntax error
+https://bugs.webkit.org/show_bug.cgi?id=220041
+
+
+Unreviewed build fix after r270575.
+
+A closing parentheses was omitted when the 'play-audio' rule was changed to
+remove its last rule.
+
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-12-19  Brent Fulgham  
+
+REGRESSION(r270575): [iOS] Correct GPU Process sandbox syntax error
+https://bugs.webkit.org/show_bug.cgi?id=220041
+
+
+Unreviewed build fix after r270575.
+
+A closing parentheses was omitted when the 'play-audio' rule was changed to
+remove its last rule.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+
 2020-12-18  Alan Coon  
 
 Cherry-pick r270962. rdar://problem/72472070


Modified: branches/safari-611.1.9-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (271004 => 271005)

--- branches/safari-611.1.9-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2020-12-19 23:55:32 UTC (rev 271004)
+++ branches/safari-611.1.9-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2020-12-20 00:03:03 UTC (rev 271005)
@@ -106,7 +106,7 @@
 
 (define-once (play-audio)
 (allow mach-lookup
-   (global-name "com.apple.audio.AURemoteIOServer"))
+   (global-name "com.apple.audio.AURemoteIOServer")))
 
 (define-once (play-media . filters)
 (if (not (null? filters))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [268347] tags/Safari-610.2.11.51.1/

[bshafiei]

Title: [268347] tags/Safari-610.2.11.51.1/








Revision 268347
Author bshaf...@apple.com
Date 2020-10-12 01:10:04 -0700 (Mon, 12 Oct 2020)


Log Message
Tag Safari-610.2.11.51.1.

Added Paths

tags/Safari-610.2.11.51.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [268345] branches/safari-610.2.11.51-branch/Source

[bshafiei]

Title: [268345] branches/safari-610.2.11.51-branch/Source








Revision 268345
Author bshaf...@apple.com
Date 2020-10-12 01:08:24 -0700 (Mon, 12 Oct 2020)


Log Message
Cherry-pick r268327. rdar://problem/70189401

Ignore deployment suffix and identifier when computing major OS version for macOS
Big Sur and newer
https://bugs.webkit.org/show_bug.cgi?id=217584
rdar://70168426

Patch by Luming Yin  on 2020-10-11
Reviewed by Darin Adler.

Stop using MACOSX_DEPLOYMENT_TARGET:suffix:identifier to compute major OS versions.
Only use the deployment target base for macOS Big Sur and newer. Keep the manual
definitions for legacy versions of macOS.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.2.11.51-branch/Source/_javascript_Core/ChangeLog
branches/safari-610.2.11.51-branch/Source/_javascript_Core/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/ThirdParty/ANGLE/ChangeLog
branches/safari-610.2.11.51-branch/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-610.2.11.51-branch/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/WTF/ChangeLog
branches/safari-610.2.11.51-branch/Source/WTF/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/WebCore/ChangeLog
branches/safari-610.2.11.51-branch/Source/WebCore/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/WebCore/PAL/ChangeLog
branches/safari-610.2.11.51-branch/Source/WebCore/PAL/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/WebInspectorUI/ChangeLog
branches/safari-610.2.11.51-branch/Source/WebInspectorUI/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/WebKit/ChangeLog
branches/safari-610.2.11.51-branch/Source/WebKit/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/WebKitLegacy/mac/ChangeLog
branches/safari-610.2.11.51-branch/Source/WebKitLegacy/mac/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/bmalloc/ChangeLog
branches/safari-610.2.11.51-branch/Source/bmalloc/Configurations/Base.xcconfig




Diff

Modified: branches/safari-610.2.11.51-branch/Source/_javascript_Core/ChangeLog (268344 => 268345)

--- branches/safari-610.2.11.51-branch/Source/_javascript_Core/ChangeLog	2020-10-12 08:04:04 UTC (rev 268344)
+++ branches/safari-610.2.11.51-branch/Source/_javascript_Core/ChangeLog	2020-10-12 08:08:24 UTC (rev 268345)
@@ -1,3 +1,38 @@
+2020-10-12  Babak Shafiei  
+
+Cherry-pick r268327. rdar://problem/70189401
+
+Ignore deployment suffix and identifier when computing major OS version for macOS
+Big Sur and newer
+https://bugs.webkit.org/show_bug.cgi?id=217584
+rdar://70168426
+
+Patch by Luming Yin  on 2020-10-11
+Reviewed by Darin Adler.
+
+Stop using MACOSX_DEPLOYMENT_TARGET:suffix:identifier to compute major OS versions.
+Only use the deployment target base for macOS Big Sur and newer. Keep the manual
+definitions for legacy versions of macOS.
+
+* Configurations/Base.xcconfig:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-10-11  Luming Yin  
+
+Ignore deployment suffix and identifier when computing major OS version for macOS
+Big Sur and newer
+https://bugs.webkit.org/show_bug.cgi?id=217584
+rdar://70168426
+
+Reviewed by Darin Adler.
+
+Stop using MACOSX_DEPLOYMENT_TARGET:suffix:identifier to compute major OS versions.
+Only use the deployment target base for macOS Big Sur and newer. Keep the manual
+definitions for legacy versions of macOS.
+
+* Configurations/Base.xcconfig:
+
 2020-09-27  Alan Coon  
 
 Cherry-pick r267304. rdar://problem/69594380


Modified: branches/safari-610.2.11.51-branch/Source/_javascript_Core/Configurations/Base.xcconfig (268344 => 268345)

--- branches/safari-610.2.11.51-branch/Source/_javascript_Core/Configurations/Base.xcconfig	2020-10-12 08:04:04 UTC (rev 268344)
+++ branches/safari-610.2.11.51-branch/Source/_javascript_Core/Configurations/Base.xcconfig	2020-10-12 08:08:24 UTC (rev 268345)
@@ -102,13 +102,15 @@
 
 HEADER_SEARCH_PATHS = . "${BUILT_PRODUCTS_DIR}/usr/local/include" $(HEADER_SEARCH_PATHS);
 
-TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR_$(MACOSX_DEPLOYMENT_TARGET:base)$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier));
-TARGET_MAC_OS_X_VERSION_MAJOR_10_13 = 101300;
-TARGET_MAC_OS_X_VERSION_MAJOR_10_14 = 101400;
-TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500;
-TARGET_MAC_OS_X_VERSION_MAJOR_11_0 = 11;
-TARGET_MAC_OS_X_VERSION_MAJOR_12_0 = 12;
+TARGET_MACOS_LEGACY_VERSION_IDENTIFIER = 

[webkit-changes] [268346] branches/safari-610.2.11.51-branch/Source

[bshafiei]

Title: [268346] branches/safari-610.2.11.51-branch/Source








Revision 268346
Author bshaf...@apple.com
Date 2020-10-12 01:08:32 -0700 (Mon, 12 Oct 2020)


Log Message
Cherry-pick r268330. rdar://problem/70189394

Strip patch version from TARGET_MAC_OS_X_VERSION_MAJOR when building for macOS Big Sur
or later
https://bugs.webkit.org/show_bug.cgi?id=217594
rdar://70188497

Patch by Luming Yin  on 2020-10-11
Reviewed by Darin Adler.

To ensure successful Mac Catalyst WebKit builds, strip the patch version from
TARGET_MAC_OS_X_VERSION_MAJOR by using two `base:`s on MACOSX_DEPLOYMENT_TARGET.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.2.11.51-branch/Source/_javascript_Core/ChangeLog
branches/safari-610.2.11.51-branch/Source/_javascript_Core/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/ThirdParty/ANGLE/ChangeLog
branches/safari-610.2.11.51-branch/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-610.2.11.51-branch/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/WTF/ChangeLog
branches/safari-610.2.11.51-branch/Source/WTF/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/WebCore/ChangeLog
branches/safari-610.2.11.51-branch/Source/WebCore/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/WebCore/PAL/ChangeLog
branches/safari-610.2.11.51-branch/Source/WebCore/PAL/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/WebInspectorUI/ChangeLog
branches/safari-610.2.11.51-branch/Source/WebInspectorUI/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/WebKit/ChangeLog
branches/safari-610.2.11.51-branch/Source/WebKit/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/WebKitLegacy/mac/ChangeLog
branches/safari-610.2.11.51-branch/Source/WebKitLegacy/mac/Configurations/Base.xcconfig
branches/safari-610.2.11.51-branch/Source/bmalloc/ChangeLog
branches/safari-610.2.11.51-branch/Source/bmalloc/Configurations/Base.xcconfig




Diff

Modified: branches/safari-610.2.11.51-branch/Source/_javascript_Core/ChangeLog (268345 => 268346)

--- branches/safari-610.2.11.51-branch/Source/_javascript_Core/ChangeLog	2020-10-12 08:08:24 UTC (rev 268345)
+++ branches/safari-610.2.11.51-branch/Source/_javascript_Core/ChangeLog	2020-10-12 08:08:32 UTC (rev 268346)
@@ -1,5 +1,38 @@
 2020-10-12  Babak Shafiei  
 
+Cherry-pick r268330. rdar://problem/70189394
+
+Strip patch version from TARGET_MAC_OS_X_VERSION_MAJOR when building for macOS Big Sur
+or later
+https://bugs.webkit.org/show_bug.cgi?id=217594
+rdar://70188497
+
+Patch by Luming Yin  on 2020-10-11
+Reviewed by Darin Adler.
+
+To ensure successful Mac Catalyst WebKit builds, strip the patch version from
+TARGET_MAC_OS_X_VERSION_MAJOR by using two `base:`s on MACOSX_DEPLOYMENT_TARGET.
+
+* Configurations/Base.xcconfig:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-10-11  Luming Yin  
+
+Strip patch version from TARGET_MAC_OS_X_VERSION_MAJOR when building for macOS Big Sur
+or later
+https://bugs.webkit.org/show_bug.cgi?id=217594
+rdar://70188497
+
+Reviewed by Darin Adler.
+
+To ensure successful Mac Catalyst WebKit builds, strip the patch version from
+TARGET_MAC_OS_X_VERSION_MAJOR by using two `base:`s on MACOSX_DEPLOYMENT_TARGET.
+
+* Configurations/Base.xcconfig:
+
+2020-10-12  Babak Shafiei  
+
 Cherry-pick r268327. rdar://problem/70189401
 
 Ignore deployment suffix and identifier when computing major OS version for macOS


Modified: branches/safari-610.2.11.51-branch/Source/_javascript_Core/Configurations/Base.xcconfig (268345 => 268346)

--- branches/safari-610.2.11.51-branch/Source/_javascript_Core/Configurations/Base.xcconfig	2020-10-12 08:08:24 UTC (rev 268345)
+++ branches/safari-610.2.11.51-branch/Source/_javascript_Core/Configurations/Base.xcconfig	2020-10-12 08:08:32 UTC (rev 268346)
@@ -106,7 +106,7 @@
 TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = 10$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier)
 
 TARGET_MAC_OS_X_VERSION_MAJOR = $(TARGET_MAC_OS_X_VERSION_MAJOR_$(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER))
-TARGET_MAC_OS_X_VERSION_MAJOR_ = $(MACOSX_DEPLOYMENT_TARGET:base)
+TARGET_MAC_OS_X_VERSION_MAJOR_ = $(MACOSX_DEPLOYMENT_TARGET:base:base)
 TARGET_MAC_OS_X_VERSION_MAJOR_10_13 = 101300
 TARGET_MAC_OS_X_VERSION_MAJOR_10_14 = 101400
 TARGET_MAC_OS_X_VERSION_MAJOR_10_15 = 101500


Modified: branches/safari-610.2.11.51-branch/Source/ThirdParty/ANGLE/ChangeLog (268345 => 268346)

--- 

[webkit-changes] [268344] branches/safari-610.2.11.51-branch/Source

[bshafiei]

Title: [268344] branches/safari-610.2.11.51-branch/Source








Revision 268344
Author bshaf...@apple.com
Date 2020-10-12 01:04:04 -0700 (Mon, 12 Oct 2020)


Log Message
Versioning.

WebKit-7610.2.11.51.1

Modified Paths

branches/safari-610.2.11.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-610.2.11.51-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-610.2.11.51-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-610.2.11.51-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-610.2.11.51-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-610.2.11.51-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-610.2.11.51-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-610.2.11.51-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-610.2.11.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig (268343 => 268344)

--- branches/safari-610.2.11.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-10-12 07:45:24 UTC (rev 268343)
+++ branches/safari-610.2.11.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-10-12 08:04:04 UTC (rev 268344)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 2;
 TINY_VERSION = 11;
-MICRO_VERSION = 1;
+MICRO_VERSION = 51;
 NANO_VERSION = 1;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 


Modified: branches/safari-610.2.11.51-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (268343 => 268344)

--- branches/safari-610.2.11.51-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-10-12 07:45:24 UTC (rev 268343)
+++ branches/safari-610.2.11.51-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-10-12 08:04:04 UTC (rev 268344)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 2;
 TINY_VERSION = 11;
-MICRO_VERSION = 1;
+MICRO_VERSION = 51;
 NANO_VERSION = 1;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 


Modified: branches/safari-610.2.11.51-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (268343 => 268344)

--- branches/safari-610.2.11.51-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-10-12 07:45:24 UTC (rev 268343)
+++ branches/safari-610.2.11.51-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-10-12 08:04:04 UTC (rev 268344)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 2;
 TINY_VERSION = 11;
-MICRO_VERSION = 1;
+MICRO_VERSION = 51;
 NANO_VERSION = 1;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 


Modified: branches/safari-610.2.11.51-branch/Source/WebCore/Configurations/Version.xcconfig (268343 => 268344)

--- branches/safari-610.2.11.51-branch/Source/WebCore/Configurations/Version.xcconfig	2020-10-12 07:45:24 UTC (rev 268343)
+++ branches/safari-610.2.11.51-branch/Source/WebCore/Configurations/Version.xcconfig	2020-10-12 08:04:04 UTC (rev 268344)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 2;
 TINY_VERSION = 11;
-MICRO_VERSION = 1;
+MICRO_VERSION = 51;
 NANO_VERSION = 1;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 


Modified: branches/safari-610.2.11.51-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (268343 => 268344)

--- branches/safari-610.2.11.51-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-10-12 07:45:24 UTC (rev 268343)
+++ branches/safari-610.2.11.51-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-10-12 08:04:04 UTC (rev 268344)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 2;
 TINY_VERSION = 11;
-MICRO_VERSION = 1;
+MICRO_VERSION = 51;
 NANO_VERSION = 1;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 


Modified: branches/safari-610.2.11.51-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (268343 => 268344)

--- branches/safari-610.2.11.51-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-10-12 07:45:24 UTC (rev 268343)
+++ branches/safari-610.2.11.51-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-10-12 08:04:04 UTC (rev 268344)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 2;
 TINY_VERSION = 11;
-MICRO_VERSION = 1;
+MICRO_VERSION = 51;
 NANO_VERSION = 1;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 


Modified: branches/safari-610.2.11.51-branch/Source/WebKit/Configurations/Version.xcconfig (268343 => 268344)

--- branches/safari-610.2.11.51-branch/Source/WebKit/Configurations/Version.xcconfig	2020-10-12 07:45:24 UTC (rev 268343)
+++ branches/safari-610.2.11.51-branch/Source/WebKit/Configurations/Version.xcconfig	

[webkit-changes] [268343] branches/safari-610.2.11.51-branch/

[bshafiei]

Title: [268343] branches/safari-610.2.11.51-branch/








Revision 268343
Author bshaf...@apple.com
Date 2020-10-12 00:45:24 -0700 (Mon, 12 Oct 2020)


Log Message
New branch.

Added Paths

branches/safari-610.2.11.51-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [268341] tags/Safari-611.1.3.1/

[bshafiei]

Title: [268341] tags/Safari-611.1.3.1/








Revision 268341
Author bshaf...@apple.com
Date 2020-10-11 21:58:39 -0700 (Sun, 11 Oct 2020)


Log Message
Tag Safari-611.1.3.1.

Added Paths

tags/Safari-611.1.3.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [268340] tags/Safari-610.3.2/

[bshafiei]

Title: [268340] tags/Safari-610.3.2/








Revision 268340
Author bshaf...@apple.com
Date 2020-10-11 21:35:59 -0700 (Sun, 11 Oct 2020)


Log Message
Tag Safari-610.3.2.

Added Paths

tags/Safari-610.3.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257198] tags/Safari-609.1.20.111.3/

[bshafiei]

Title: [257198] tags/Safari-609.1.20.111.3/








Revision 257198
Author bshaf...@apple.com
Date 2020-02-23 14:12:57 -0800 (Sun, 23 Feb 2020)


Log Message
Tag Safari-609.1.20.111.3.

Added Paths

tags/Safari-609.1.20.111.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [257197] branches/safari-609.1.20.111-branch/Source

[bshafiei]

Title: [257197] branches/safari-609.1.20.111-branch/Source








Revision 257197
Author bshaf...@apple.com
Date 2020-02-23 14:00:39 -0800 (Sun, 23 Feb 2020)


Log Message
Versioning.

Modified Paths

branches/safari-609.1.20.111-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-609.1.20.111-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-609.1.20.111-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-609.1.20.111-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-609.1.20.111-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-609.1.20.111-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-609.1.20.111-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-609.1.20.111-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-609.1.20.111-branch/Source/_javascript_Core/Configurations/Version.xcconfig (257196 => 257197)

--- branches/safari-609.1.20.111-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-23 21:41:42 UTC (rev 257196)
+++ branches/safari-609.1.20.111-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-23 22:00:39 UTC (rev 257197)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 111;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.111-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (257196 => 257197)

--- branches/safari-609.1.20.111-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-23 21:41:42 UTC (rev 257196)
+++ branches/safari-609.1.20.111-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-23 22:00:39 UTC (rev 257197)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 111;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.111-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (257196 => 257197)

--- branches/safari-609.1.20.111-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-23 21:41:42 UTC (rev 257196)
+++ branches/safari-609.1.20.111-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-23 22:00:39 UTC (rev 257197)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 111;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.111-branch/Source/WebCore/Configurations/Version.xcconfig (257196 => 257197)

--- branches/safari-609.1.20.111-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-23 21:41:42 UTC (rev 257196)
+++ branches/safari-609.1.20.111-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-23 22:00:39 UTC (rev 257197)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 111;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.111-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (257196 => 257197)

--- branches/safari-609.1.20.111-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-23 21:41:42 UTC (rev 257196)
+++ branches/safari-609.1.20.111-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-23 22:00:39 UTC (rev 257197)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 111;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-609.1.20.111-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (257196 => 257197)

--- branches/safari-609.1.20.111-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-02-23 21:41:42 UTC (rev 257196)
+++ branches/safari-609.1.20.111-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-02-23 22:00:39 UTC (rev 257197)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
 MICRO_VERSION = 111;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 

[webkit-changes] [251356] branches/safari-608-branch/Source/WebCore

[bshafiei]

Title: [251356] branches/safari-608-branch/Source/WebCore








Revision 251356
Author bshaf...@apple.com
Date 2019-10-20 17:44:32 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r251188. rdar://problem/56340816

WebAudioSourceProviderAVFObjC::provideInput should set its WebAudioBufferList parameters correctly
https://bugs.webkit.org/show_bug.cgi?id=202930


Reviewed by Eric Carlson.

Source/WebCore:

There is a time where the bus channel number and audio source channel numbers may be different.
In case the bus channel number is less than the audio source channel number, initialization of
the WebAudioBufferList might not be fully done.
In that case, output silence and return early.
Reduce the number of frames to process based on the number of frames the output audio bus plans to process.

Partially covered by new API test (this a race so we cannot reproduce the crash easily).

* Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::process):
Make sure to process the number of frames the output bus expect.
* platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
(WebCore::WebAudioSourceProviderAVFObjC::provideInput):

Tools:

Add a test that has an audio track that goes from 1 to 2 channels while being piped to a WebAudio pipeline.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
(-[GUMMessageHandler userContentController:didReceiveScriptMessage:]):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit/getUserMedia-webaudio.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp
branches/safari-608-branch/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm




Diff

Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (251355 => 251356)

--- branches/safari-608-branch/Source/WebCore/ChangeLog	2019-10-21 00:44:30 UTC (rev 251355)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2019-10-21 00:44:32 UTC (rev 251356)
@@ -1,5 +1,65 @@
 2019-10-20  Babak Shafiei  
 
+Cherry-pick r251188. rdar://problem/56340816
+
+WebAudioSourceProviderAVFObjC::provideInput should set its WebAudioBufferList parameters correctly
+https://bugs.webkit.org/show_bug.cgi?id=202930
+
+
+Reviewed by Eric Carlson.
+
+Source/WebCore:
+
+There is a time where the bus channel number and audio source channel numbers may be different.
+In case the bus channel number is less than the audio source channel number, initialization of
+the WebAudioBufferList might not be fully done.
+In that case, output silence and return early.
+Reduce the number of frames to process based on the number of frames the output audio bus plans to process.
+
+Partially covered by new API test (this a race so we cannot reproduce the crash easily).
+
+* Modules/webaudio/MediaStreamAudioSourceNode.cpp:
+(WebCore::MediaStreamAudioSourceNode::process):
+Make sure to process the number of frames the output bus expect.
+* platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
+(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
+
+Tools:
+
+Add a test that has an audio track that goes from 1 to 2 channels while being piped to a WebAudio pipeline.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
+(-[GUMMessageHandler userContentController:didReceiveScriptMessage:]):
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/WebKit/getUserMedia-webaudio.html: Added.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-16  Youenn Fablet  
+
+WebAudioSourceProviderAVFObjC::provideInput should set its WebAudioBufferList parameters correctly
+https://bugs.webkit.org/show_bug.cgi?id=202930
+
+
+Reviewed by Eric Carlson.
+
+There is a time where the bus channel number and audio source channel numbers may be different.
+In case the bus channel number is less than the audio source channel number, initialization of
+the WebAudioBufferList might not be fully done.
+In that case, output silence and return early.
+Reduce the number of frames to process based on the number of frames the output audio bus plans to process.
+
+Partially covered by new API test (this a race so we cannot reproduce the crash easily).
+
+* Modules/webaudio/MediaStreamAudioSourceNode.cpp:
+(WebCore::MediaStreamAudioSourceNode::process):
+Make sure to process the 

[webkit-changes] [251354] branches/safari-608-branch

[bshafiei]

Title: [251354] branches/safari-608-branch








Revision 251354
Author bshaf...@apple.com
Date 2019-10-20 17:44:26 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r249538. rdar://problem/56426429

LazyClassStructure::setConstructor should not store the constructor to the global object
https://bugs.webkit.org/show_bug.cgi?id=201484


Reviewed by Yusuke Suzuki.

JSTests:

* stress/web-assembly-constructors-should-not-override-global-object-property.js: Added.

Source/_javascript_Core:

LazyClassStructure::setConstructor sets the constructor as a property of the global object.
This became a problem when it started being used for WebAssembly constructors, such as Module
and Instance, since they are properties of the WebAssembly object, not the global object. That
resulted in properties of the global object replaced whenever a lazy WebAssembly constructor
was first accessed. e.g.

globalThis.Module = x;
WebAssembly.Module;
globalThis.Module === WebAssembly.Module;

* runtime/LazyClassStructure.cpp:
(JSC::LazyClassStructure::Initializer::setConstructor):
* runtime/LazyClassStructure.h:
* runtime/Lookup.h:
(JSC::reifyStaticProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/JSTests/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/runtime/LazyClassStructure.cpp
branches/safari-608-branch/Source/_javascript_Core/runtime/LazyClassStructure.h
branches/safari-608-branch/Source/_javascript_Core/runtime/Lookup.h


Added Paths

branches/safari-608-branch/JSTests/stress/web-assembly-constructors-should-not-override-global-object-property.js




Diff

Modified: branches/safari-608-branch/JSTests/ChangeLog (251353 => 251354)

--- branches/safari-608-branch/JSTests/ChangeLog	2019-10-20 23:40:21 UTC (rev 251353)
+++ branches/safari-608-branch/JSTests/ChangeLog	2019-10-21 00:44:26 UTC (rev 251354)
@@ -1,3 +1,47 @@
+2019-10-20  Babak Shafiei  
+
+Cherry-pick r249538. rdar://problem/56426429
+
+LazyClassStructure::setConstructor should not store the constructor to the global object
+https://bugs.webkit.org/show_bug.cgi?id=201484
+
+
+Reviewed by Yusuke Suzuki.
+
+JSTests:
+
+* stress/web-assembly-constructors-should-not-override-global-object-property.js: Added.
+
+Source/_javascript_Core:
+
+LazyClassStructure::setConstructor sets the constructor as a property of the global object.
+This became a problem when it started being used for WebAssembly constructors, such as Module
+and Instance, since they are properties of the WebAssembly object, not the global object. That
+resulted in properties of the global object replaced whenever a lazy WebAssembly constructor
+was first accessed. e.g.
+
+globalThis.Module = x;
+WebAssembly.Module;
+globalThis.Module === WebAssembly.Module;
+
+* runtime/LazyClassStructure.cpp:
+(JSC::LazyClassStructure::Initializer::setConstructor):
+* runtime/LazyClassStructure.h:
+* runtime/Lookup.h:
+(JSC::reifyStaticProperty):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-09-05  Tadeu Zagallo  
+
+LazyClassStructure::setConstructor should not store the constructor to the global object
+https://bugs.webkit.org/show_bug.cgi?id=201484
+
+
+Reviewed by Yusuke Suzuki.
+
+* stress/web-assembly-constructors-should-not-override-global-object-property.js: Added.
+
 2019-10-15  Kocsen Chung  
 
 Cherry-pick r250585. rdar://problem/56280995


Added: branches/safari-608-branch/JSTests/stress/web-assembly-constructors-should-not-override-global-object-property.js (0 => 251354)

--- branches/safari-608-branch/JSTests/stress/web-assembly-constructors-should-not-override-global-object-property.js	(rev 0)
+++ branches/safari-608-branch/JSTests/stress/web-assembly-constructors-should-not-override-global-object-property.js	2019-10-21 00:44:26 UTC (rev 251354)
@@ -0,0 +1,4 @@
+var originalModule = this.Module = {};
+WebAssembly.Module;
+if (Module !== originalModule)
+throw new Error('Global property `Module` was overwritten!');


Modified: branches/safari-608-branch/Source/_javascript_Core/ChangeLog (251353 => 251354)

--- branches/safari-608-branch/Source/_javascript_Core/ChangeLog	2019-10-20 23:40:21 UTC (rev 251353)
+++ branches/safari-608-branch/Source/_javascript_Core/ChangeLog	2019-10-21 00:44:26 UTC (rev 251354)
@@ -1,3 +1,61 @@
+2019-10-20  Babak Shafiei  
+
+Cherry-pick r249538. rdar://problem/56426429
+
+LazyClassStructure::setConstructor should not store the constructor to the global object
+https://bugs.webkit.org/show_bug.cgi?id=201484
+
+  

[webkit-changes] [251355] branches/safari-608-branch/Source/WebKit

[bshafiei]

Title: [251355] branches/safari-608-branch/Source/WebKit








Revision 251355
Author bshaf...@apple.com
Date 2019-10-20 17:44:30 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250773. rdar://problem/56271900

WebPageProxy::updatePlayingMediaDidChange should protect from a null m_userMediaPermissionRequestManager
https://bugs.webkit.org/show_bug.cgi?id=202628


Reviewed by Eric Carlson.

On process swap on navigation or process crash, m_userMediaPermissionRequestManager is made null.
At the same time, the media state is set back to not playing.
Future calls of updatePlayingMediaDidChange should not have any capture state change until getUserMedia/getDisplayMedia
is called, which would create m_userMediaPermissionRequestManager.
But this assumption is not always true given that the media state is computed as process-wide in MediaStreamTrack::captureState on iOS.
The above behavior is fixed as part of https://bugs.webkit.org/show_bug.cgi?id=202627.
Since the call to updatePlayingMediaDidChange is triggered straight from IPC, it should not be trusted and a null check should be added.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updatePlayingMediaDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/UIProcess/WebPageProxy.cpp




Diff

Modified: branches/safari-608-branch/Source/WebKit/ChangeLog (251354 => 251355)

--- branches/safari-608-branch/Source/WebKit/ChangeLog	2019-10-21 00:44:26 UTC (rev 251354)
+++ branches/safari-608-branch/Source/WebKit/ChangeLog	2019-10-21 00:44:30 UTC (rev 251355)
@@ -1,5 +1,48 @@
 2019-10-20  Babak Shafiei  
 
+Cherry-pick r250773. rdar://problem/56271900
+
+WebPageProxy::updatePlayingMediaDidChange should protect from a null m_userMediaPermissionRequestManager
+https://bugs.webkit.org/show_bug.cgi?id=202628
+
+
+Reviewed by Eric Carlson.
+
+On process swap on navigation or process crash, m_userMediaPermissionRequestManager is made null.
+At the same time, the media state is set back to not playing.
+Future calls of updatePlayingMediaDidChange should not have any capture state change until getUserMedia/getDisplayMedia
+is called, which would create m_userMediaPermissionRequestManager.
+But this assumption is not always true given that the media state is computed as process-wide in MediaStreamTrack::captureState on iOS.
+The above behavior is fixed as part of https://bugs.webkit.org/show_bug.cgi?id=202627.
+Since the call to updatePlayingMediaDidChange is triggered straight from IPC, it should not be trusted and a null check should be added.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::updatePlayingMediaDidChange):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-07  youenn fablet  
+
+WebPageProxy::updatePlayingMediaDidChange should protect from a null m_userMediaPermissionRequestManager
+https://bugs.webkit.org/show_bug.cgi?id=202628
+
+
+Reviewed by Eric Carlson.
+
+On process swap on navigation or process crash, m_userMediaPermissionRequestManager is made null.
+At the same time, the media state is set back to not playing.
+Future calls of updatePlayingMediaDidChange should not have any capture state change until getUserMedia/getDisplayMedia
+is called, which would create m_userMediaPermissionRequestManager.
+But this assumption is not always true given that the media state is computed as process-wide in MediaStreamTrack::captureState on iOS.
+The above behavior is fixed as part of https://bugs.webkit.org/show_bug.cgi?id=202627.
+Since the call to updatePlayingMediaDidChange is triggered straight from IPC, it should not be trusted and a null check should be added.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::updatePlayingMediaDidChange):
+
+2019-10-20  Babak Shafiei  
+
 Apply patch. rdar://problem/56427498
 
 2019-10-20  John Wilander  


Modified: branches/safari-608-branch/Source/WebKit/UIProcess/WebPageProxy.cpp (251354 => 251355)

--- branches/safari-608-branch/Source/WebKit/UIProcess/WebPageProxy.cpp	2019-10-21 00:44:26 UTC (rev 251354)
+++ branches/safari-608-branch/Source/WebKit/UIProcess/WebPageProxy.cpp	2019-10-21 00:44:30 UTC (rev 251355)
@@ -8275,7 +8275,9 @@
 #if ENABLE(MEDIA_STREAM)
 if (oldMediaCaptureState != newMediaCaptureState) {
 m_uiClient->mediaCaptureStateDidChange(m_mediaState);
-m_userMediaPermissionRequestManager->captureStateChanged(oldMediaCaptureState, newMediaCaptureState);
+ASSERT(m_userMediaPermissionRequestManager);
+if 

[webkit-changes] [251353] branches/safari-608-branch

[bshafiei]

Title: [251353] branches/safari-608-branch








Revision 251353
Author bshaf...@apple.com
Date 2019-10-20 16:40:21 -0700 (Sun, 20 Oct 2019)


Log Message
Apply patch. rdar://problem/56427498

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/page/Settings.yaml
branches/safari-608-branch/Source/WebCore/platform/network/NetworkStorageSession.cpp
branches/safari-608-branch/Source/WebCore/platform/network/NetworkStorageSession.h
branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
branches/safari-608-branch/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp
branches/safari-608-branch/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp
branches/safari-608-branch/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h
branches/safari-608-branch/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp
branches/safari-608-branch/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h
branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp
branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkProcess.h
branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkProcess.messages.in
branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkSession.h
branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.cpp
branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h
branches/safari-608-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
branches/safari-608-branch/Source/WebKit/Shared/WebPreferences.yaml
branches/safari-608-branch/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
branches/safari-608-branch/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h
branches/safari-608-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
branches/safari-608-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
branches/safari-608-branch/Source/WebKit/UIProcess/WebProcessPool.cpp
branches/safari-608-branch/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
branches/safari-608-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
branches/safari-608-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
branches/safari-608-branch/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
branches/safari-608-branch/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
branches/safari-608-branch/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
branches/safari-608-branch/Tools/WebKitTestRunner/TestController.cpp
branches/safari-608-branch/Tools/WebKitTestRunner/TestController.h
branches/safari-608-branch/Tools/WebKitTestRunner/TestInvocation.cpp
branches/safari-608-branch/Tools/WebKitTestRunner/TestInvocation.h


Added Paths

branches/safari-608-branch/LayoutTests/http/tests/resourceLoadStatistics/third-party-cookie-blocking-on-sites-without-user-interaction-expected.txt
branches/safari-608-branch/LayoutTests/http/tests/resourceLoadStatistics/third-party-cookie-blocking-on-sites-without-user-interaction.html




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (251352 => 251353)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-20 23:24:48 UTC (rev 251352)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-20 23:40:21 UTC (rev 251353)
@@ -1,3 +1,20 @@
+2019-10-20  Babak Shafiei  
+
+Apply patch. rdar://problem/56427498
+
+2019-10-20  John Wilander  
+
+Cherry-pick r251213. rdar://problem/56262708
+
+Resource Load Statistics: Block all third-party cookies on websites without prior user interaction
+https://bugs.webkit.org/show_bug.cgi?id=203017
+
+
+Reviewed by Alex Christensen.
+
+* http/tests/resourceLoadStatistics/third-party-cookie-blocking-on-sites-without-user-interaction-expected.txt: Added.
+* http/tests/resourceLoadStatistics/third-party-cookie-blocking-on-sites-without-user-interaction.html: Added.
+
 2019-10-17  Alan Coon  
 
 Cherry-pick r250589. rdar://problem/55927251


Added: branches/safari-608-branch/LayoutTests/http/tests/resourceLoadStatistics/third-party-cookie-blocking-on-sites-without-user-interaction-expected.txt (0 => 251353)

--- branches/safari-608-branch/LayoutTests/http/tests/resourceLoadStatistics/third-party-cookie-blocking-on-sites-without-user-interaction-expected.txt	(rev 0)
+++ branches/safari-608-branch/LayoutTests/http/tests/resourceLoadStatistics/third-party-cookie-blocking-on-sites-without-user-interaction-expected.txt	

[webkit-changes] [251352] branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/ SOAuthorization/SubFrameSOAuthorizationSession.h

[bshafiei]

Title: [251352] branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h








Revision 251352
Author bshaf...@apple.com
Date 2019-10-20 16:24:48 -0700 (Sun, 20 Oct 2019)


Log Message
Apply patch. rdar://problem/55954224

Modified Paths

branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h




Diff

Modified: branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h (251351 => 251352)

--- branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h	2019-10-20 17:33:46 UTC (rev 251351)
+++ branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h	2019-10-20 23:24:48 UTC (rev 251352)
@@ -29,6 +29,7 @@
 
 #include "FrameLoadState.h"
 #include "NavigationSOAuthorizationSession.h"
+#include 
 
 namespace IPC {
 class DataReference;
@@ -41,8 +42,9 @@
 using Callback = CompletionHandler;
 using SOAuthorizationSession::weakPtrFactory;
 using WeakValueType = SOAuthorizationSession::WeakValueType;
+using FrameIdentifier = uint64_t;
 
-static Ref create(SOAuthorization *, Ref&&, WebPageProxy&, Callback&&, WebCore::FrameIdentifier);
+static Ref create(SOAuthorization *, Ref&&, WebPageProxy&, Callback&&, FrameIdentifier);
 
 ~SubFrameSOAuthorizationSession();
 
@@ -49,7 +51,7 @@
 private:
 using Supplement = Variant, String>;
 
-SubFrameSOAuthorizationSession(SOAuthorization *, Ref&&, WebPageProxy&, Callback&&, WebCore::FrameIdentifier);
+SubFrameSOAuthorizationSession(SOAuthorization *, Ref&&, WebPageProxy&, Callback&&, FrameIdentifier);
 
 // SOAuthorizationSession
 void fallBackToWebPathInternal() final;
@@ -65,7 +67,7 @@
 void appendRequestToLoad(URL&&, Supplement&&);
 void loadRequestToFrame();
 
-WebCore::FrameIdentifier m_frameID;
+FrameIdentifier m_frameID;
 Deque> m_requestsToLoad;
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251348] branches/safari-608-branch

[bshafiei]

Title: [251348] branches/safari-608-branch








Revision 251348
Author bshaf...@apple.com
Date 2019-10-20 10:33:32 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250887. rdar://problem/56061121

Partially undo r250811
https://bugs.webkit.org/show_bug.cgi?id=202715


Reviewed by Chris Dumez.

Source/WebCore:

This patch changes the SerializedScriptValue to always wrap CryptoKey objects again.
CryptoKey objects could belong to an array or another object. In those cases, IDBObjectStore
cannot set the flag for the embedded Cryptokey objects. Neither can postMessage to unset
the flag. Therefore, there is no way to separate the serialization process into two and
this patch restores the old behaviour. However, the hardening part of r250811 is kept
and therefore the crash should still be prevented.

No new test, updated existing test

* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::putOrAdd):
(WebCore::JSC::setIsWrappingRequiredForCryptoKey): Deleted.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::readTerminal):
* crypto/CryptoKey.h:
(WebCore::CryptoKey::allows const):
(WebCore::CryptoKey::isWrappingRequired const): Deleted.
(WebCore::CryptoKey::setIsWrappingRequired): Deleted.
(): Deleted.
* dom/ScriptExecutionContext.h:

Tools:

* TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
Modified to crash if SerializedScriptValue doesn't wrap CryptoKey objects.

LayoutTests:

Some rebaselines.

* crypto/workers/subtle/ec-postMessage-worker-expected.txt:
* crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
* crypto/workers/subtle/rsa-postMessage-worker-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/LayoutTests/crypto/workers/subtle/ec-postMessage-worker-expected.txt
branches/safari-608-branch/LayoutTests/crypto/workers/subtle/hrsa-postMessage-worker-expected.txt
branches/safari-608-branch/LayoutTests/crypto/workers/subtle/rsa-postMessage-worker-expected.txt
branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp
branches/safari-608-branch/Source/WebCore/bindings/js/SerializedScriptValue.cpp
branches/safari-608-branch/Source/WebCore/crypto/CryptoKey.h
branches/safari-608-branch/Source/WebCore/dom/ScriptExecutionContext.h
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html
branches/safari-608-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (251347 => 251348)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-20 17:33:28 UTC (rev 251347)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-20 17:33:32 UTC (rev 251348)
@@ -1,5 +1,68 @@
 2019-10-15  Kocsen Chung  
 
+Cherry-pick r250887. rdar://problem/56061121
+
+Partially undo r250811
+https://bugs.webkit.org/show_bug.cgi?id=202715
+
+
+Reviewed by Chris Dumez.
+
+Source/WebCore:
+
+This patch changes the SerializedScriptValue to always wrap CryptoKey objects again.
+CryptoKey objects could belong to an array or another object. In those cases, IDBObjectStore
+cannot set the flag for the embedded Cryptokey objects. Neither can postMessage to unset
+the flag. Therefore, there is no way to separate the serialization process into two and
+this patch restores the old behaviour. However, the hardening part of r250811 is kept
+and therefore the crash should still be prevented.
+
+No new test, updated existing test
+
+* Modules/indexeddb/IDBObjectStore.cpp:
+(WebCore::IDBObjectStore::putOrAdd):
+(WebCore::JSC::setIsWrappingRequiredForCryptoKey): Deleted.
+* bindings/js/SerializedScriptValue.cpp:
+(WebCore::CloneSerializer::dumpIfTerminal):
+(WebCore::CloneDeserializer::readTerminal):
+* crypto/CryptoKey.h:
+(WebCore::CryptoKey::allows const):
+(WebCore::CryptoKey::isWrappingRequired const): Deleted.
+(WebCore::CryptoKey::setIsWrappingRequired): Deleted.
+(): Deleted.
+* dom/ScriptExecutionContext.h:
+
+Tools:
+
+* TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
+Modified to crash if SerializedScriptValue doesn't wrap CryptoKey objects.
+
+LayoutTests:
+
+Some rebaselines.
+
+* crypto/workers/subtle/ec-postMessage-worker-expected.txt:
+* crypto/workers/subtle/hrsa-postMessage-worker-expected.txt:
+* crypto/workers/subtle/rsa-postMessage-worker-expected.txt:
+
+git-svn-id: 

[webkit-changes] [251351] branches/safari-608-branch/Source/WebKit/NetworkProcess/ NetworkConnectionToWebProcess.cpp

[bshafiei]

Title: [251351] branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp








Revision 251351
Author bshaf...@apple.com
Date 2019-10-20 10:33:46 -0700 (Sun, 20 Oct 2019)


Log Message
Unreviewed build fix. rdar://problem/55927251

Modified Paths

branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp




Diff

Modified: branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp (251350 => 251351)

--- branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp	2019-10-20 17:33:43 UTC (rev 251350)
+++ branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp	2019-10-20 17:33:46 UTC (rev 251351)
@@ -711,8 +711,13 @@
 resourceLoadStatistics->hasStorageAccess(subFrameDomain, topFrameDomain, frameID, pageID, WTFMove(completionHandler));
 return;
 } else {
-storageSession()->hasCookies(subFrameDomain, WTFMove(completionHandler));
-return;
+auto* session = networkProcess().storageSession(sessionID);
+if (!session) {
+LOG_ERROR("Non-default storage session was requested, but there was no session for it. Please file a bug unless you just disabled private browsing, in which case it's an expected race.");
+} else {
+session->hasCookies(subFrameDomain, WTFMove(completionHandler));
+return;
+}
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251349] branches/safari-608-branch

[bshafiei]

Title: [251349] branches/safari-608-branch








Revision 251349
Author bshaf...@apple.com
Date 2019-10-20 10:33:37 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r251086. rdar://problem/56237429

[Cocoa] REGRESSION (r245672): Contenteditable with optical sizing freezes Safari
https://bugs.webkit.org/show_bug.cgi?id=202262

Reviewed by Tim Horton.

Source/WebKit:

r250640 didn't go far enough. We need to apply the same fix everywhere [NSFontDescriptor fontDescriptorWithFontAttributes:] is called.

* Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::decodeFontInternal):
* Shared/Cocoa/CoreTextHelpers.h: Added.
* Shared/Cocoa/CoreTextHelpers.mm: Added.
(fontDescriptorWithFontAttributes):
* SourcesCocoa.txt:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::updateFontManagerIfNeeded):
* UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
* WebKit.xcodeproj/project.pbxproj:

LayoutTests:

* fast/forms/contenteditable-font-optical-size-expected.txt: Added.
* fast/forms/contenteditable-font-optical-size.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm
branches/safari-608-branch/Source/WebKit/Shared/ios/WebAutocorrectionData.mm
branches/safari-608-branch/Source/WebKit/SourcesCocoa.txt
branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
branches/safari-608-branch/Source/WebKit/UIProcess/mac/WebPopupMenuProxyMac.mm
branches/safari-608-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

branches/safari-608-branch/LayoutTests/fast/forms/contenteditable-font-optical-size-expected.txt
branches/safari-608-branch/LayoutTests/fast/forms/contenteditable-font-optical-size.html
branches/safari-608-branch/Source/WebKit/Shared/Cocoa/CoreTextHelpers.h
branches/safari-608-branch/Source/WebKit/Shared/Cocoa/CoreTextHelpers.mm




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (251348 => 251349)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-20 17:33:32 UTC (rev 251348)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-20 17:33:37 UTC (rev 251349)
@@ -1,5 +1,47 @@
 2019-10-15  Kocsen Chung  
 
+Cherry-pick r251086. rdar://problem/56237429
+
+[Cocoa] REGRESSION (r245672): Contenteditable with optical sizing freezes Safari
+https://bugs.webkit.org/show_bug.cgi?id=202262
+
+Reviewed by Tim Horton.
+
+Source/WebKit:
+
+r250640 didn't go far enough. We need to apply the same fix everywhere [NSFontDescriptor fontDescriptorWithFontAttributes:] is called.
+
+* Shared/Cocoa/ArgumentCodersCocoa.mm:
+(IPC::decodeFontInternal):
+* Shared/Cocoa/CoreTextHelpers.h: Added.
+* Shared/Cocoa/CoreTextHelpers.mm: Added.
+(fontDescriptorWithFontAttributes):
+* SourcesCocoa.txt:
+* UIProcess/Cocoa/WebViewImpl.mm:
+(WebKit::WebViewImpl::updateFontManagerIfNeeded):
+* UIProcess/mac/WebPopupMenuProxyMac.mm:
+(WebKit::WebPopupMenuProxyMac::showPopupMenu):
+* WebKit.xcodeproj/project.pbxproj:
+
+LayoutTests:
+
+* fast/forms/contenteditable-font-optical-size-expected.txt: Added.
+* fast/forms/contenteditable-font-optical-size.html: Added.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-14  Myles C. Maxfield  
+
+[Cocoa] REGRESSION (r245672): Contenteditable with optical sizing freezes Safari
+https://bugs.webkit.org/show_bug.cgi?id=202262
+
+Reviewed by Tim Horton.
+
+* fast/forms/contenteditable-font-optical-size-expected.txt: Added.
+* fast/forms/contenteditable-font-optical-size.html: Added.
+
+2019-10-15  Kocsen Chung  
+
 Cherry-pick r250887. rdar://problem/56061121
 
 Partially undo r250811


Added: branches/safari-608-branch/LayoutTests/fast/forms/contenteditable-font-optical-size-expected.txt (0 => 251349)

--- branches/safari-608-branch/LayoutTests/fast/forms/contenteditable-font-optical-size-expected.txt	(rev 0)
+++ branches/safari-608-branch/LayoutTests/fast/forms/contenteditable-font-optical-size-expected.txt	2019-10-20 17:33:37 UTC (rev 251349)
@@ -0,0 +1,9 @@
+This test makes sure that contenteditable with optical size doesn't hang the browser. The test passes if there is no hang when typing occurs in the contenteditable element.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+Lorem ipsumabcde


Added: branches/safari-608-branch/LayoutTests/fast/forms/contenteditable-font-optical-size.html (0 => 251349)

--- 

[webkit-changes] [251347] branches/safari-608-branch/LayoutTests

[bshafiei]

Title: [251347] branches/safari-608-branch/LayoutTests








Revision 251347
Author bshaf...@apple.com
Date 2019-10-20 10:33:28 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250844. rdar://problem/56061121

Unreviewed, test gardening

* TestExpectations:
* platform/ios-simulator/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/LayoutTests/TestExpectations
branches/safari-608-branch/LayoutTests/platform/ios-simulator/TestExpectations




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (251346 => 251347)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-20 17:33:25 UTC (rev 251346)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-20 17:33:28 UTC (rev 251347)
@@ -1,5 +1,23 @@
 2019-10-15  Kocsen Chung  
 
+Cherry-pick r250844. rdar://problem/56061121
+
+Unreviewed, test gardening
+
+* TestExpectations:
+* platform/ios-simulator/TestExpectations:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-08  Jiewen Tan  
+
+Unreviewed, test gardening
+
+* TestExpectations:
+* platform/ios-simulator/TestExpectations:
+
+2019-10-15  Kocsen Chung  
+
 Cherry-pick r250929. rdar://problem/56280990
 
 RunResolver::rangeForRendererWithOffsets should check for range end


Modified: branches/safari-608-branch/LayoutTests/TestExpectations (251346 => 251347)

--- branches/safari-608-branch/LayoutTests/TestExpectations	2019-10-20 17:33:25 UTC (rev 251346)
+++ branches/safari-608-branch/LayoutTests/TestExpectations	2019-10-20 17:33:28 UTC (rev 251347)
@@ -3455,3 +3455,5 @@
 fast/text/design-system-ui-14.html [ ImageOnlyFailure ]
 fast/text/design-system-ui-15.html [ ImageOnlyFailure ]
 fast/text/design-system-ui-16.html [ ImageOnlyFailure ]
+
+webkit.org/b/202648 [ Debug ] crypto/workers/subtle/aes-indexeddb.html [ Skip ]


Modified: branches/safari-608-branch/LayoutTests/platform/ios-simulator/TestExpectations (251346 => 251347)

--- branches/safari-608-branch/LayoutTests/platform/ios-simulator/TestExpectations	2019-10-20 17:33:25 UTC (rev 251346)
+++ branches/safari-608-branch/LayoutTests/platform/ios-simulator/TestExpectations	2019-10-20 17:33:28 UTC (rev 251347)
@@ -124,4 +124,6 @@
 
 webkit.org/b/195466 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-width-1000px.html [ Pass Failure ]
 webkit.org/b/195466 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html [ Pass Failure ]
-webkit.org/b/195466 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/error-codes/error.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/195466 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/error-codes/error.html [ Pass Failure ]
+
+webkit.org/b/202648 crypto/workers/subtle/aes-indexeddb.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251350] branches/safari-608-branch

[bshafiei]

Title: [251350] branches/safari-608-branch








Revision 251350
Author bshaf...@apple.com
Date 2019-10-20 10:33:43 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250589. rdar://problem/55927251

Storage Access API: document.hasStorageAccess() should return true when the cookie policy allows access
https://bugs.webkit.org/show_bug.cgi?id=202435


Reviewed by Brent Fulgham.

Source/WebCore:

WebKit's Storage Access API implementation has so far only looked at whether ITP is
blocking cookie access or not. However, the default cookie policy is still in
effect underneath ITP. document.hasStorageAccess() should return true if the
third-party:
a) is not classified by ITP, and
b) has cookies which implies it can use cookies as third-party according to the
default cookie policy.

Tests: http/tests/storageAccess/has-storage-access-false-by-default-ephemeral.html
   http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-ephemeral.html
   http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies.html

* platform/network/NetworkStorageSession.h:
* platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::NetworkStorageSession::hasCookies const):
* platform/network/curl/NetworkStorageSessionCurl.cpp:
(WebCore::NetworkStorageSession::hasCookies const):
Not yet implemented. Always says false.
* platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::hasCookies const):
Not yet implemented. Always says false.

Source/WebKit:

WebKit's Storage Access API implementation has so far only looked at whether ITP is
blocking cookie access or not. However, the default cookie policy is still in
effect underneath ITP. document.hasStorageAccess() should return true if the
third-party:
a) is not classified by ITP, and
b) has cookies which implies it can use cookies as third-party according to the
default cookie policy.

* NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
(WebKit::ResourceLoadStatisticsMemoryStore::hasStorageAccess):
* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::hasCookies):
* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::hasStorageAccess):
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):

Tools:

This change makes sure topPrivatelyControlledDomain() correctly handles domains
with leading dots, as often used in cookie domains.

* TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
(TestWebKitAPI::TEST_F):

LayoutTests:

WebKit's Storage Access API implementation has so far only looked at whether ITP is
blocking cookie access or not. However, the default cookie policy is still in
effect underneath ITP. document.hasStorageAccess() should return true if the
third-party:
a) is not classified by ITP, and
b) has cookies which implies it can use cookies as third-party according to the
default cookie policy.

* http/tests/storageAccess/has-storage-access-false-by-default-ephemeral-expected.txt: Added.
* http/tests/storageAccess/has-storage-access-false-by-default-ephemeral.html: Copied from LayoutTests/http/tests/storageAccess/has-storage-access-true-if-feature-off.html.
* http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-ephemeral-expected.txt: Added.
* http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-ephemeral.html: Copied from LayoutTests/http/tests/storageAccess/has-storage-access-true-if-feature-off.html.
* http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-expected.txt: Added.
* http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies.html: Renamed from LayoutTests/http/tests/storageAccess/has-storage-access-true-if-feature-off.html.
* platform/ios/TestExpectations:
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/LayoutTests/platform/ios/TestExpectations
branches/safari-608-branch/LayoutTests/platform/mac-wk2/TestExpectations
branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/platform/network/NetworkStorageSession.h
branches/safari-608-branch/Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm
branches/safari-608-branch/Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp
branches/safari-608-branch/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp

[webkit-changes] [251334] branches/safari-608-branch

[bshafiei]

Title: [251334] branches/safari-608-branch








Revision 251334
Author bshaf...@apple.com
Date 2019-10-20 10:32:40 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250431. rdar://problem/55927251

Storage Access API: document.hasStorageAccess() should return false by default
https://bugs.webkit.org/show_bug.cgi?id=202281


Reviewed by Alex Christensen.

document.hasStorageAccess() should return false by default so that it only
returns true if the context has asked for and been granted storage access.

Source/WebKit:

* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::hasStorageAccess):
* NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
(WebKit::ResourceLoadStatisticsMemoryStore::hasStorageAccess):

LayoutTests:

* http/tests/storageAccess/has-storage-access-false-by-default-expected.txt: Added.
* http/tests/storageAccess/has-storage-access-false-by-default.html: Added.
* platform/ios/TestExpectations:
The new test is marked as [ Pass ].
* platform/mac-wk2/TestExpectations:
The new test is marked as [ Pass ].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/LayoutTests/platform/ios/TestExpectations
branches/safari-608-branch/LayoutTests/platform/mac-wk2/TestExpectations
branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
branches/safari-608-branch/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp


Added Paths

branches/safari-608-branch/LayoutTests/http/tests/storageAccess/has-storage-access-false-by-default-expected.txt
branches/safari-608-branch/LayoutTests/http/tests/storageAccess/has-storage-access-false-by-default.html




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (251333 => 251334)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-20 17:32:36 UTC (rev 251333)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-20 17:32:40 UTC (rev 251334)
@@ -1,5 +1,55 @@
 2019-10-15  Kocsen Chung  
 
+Cherry-pick r250431. rdar://problem/55927251
+
+Storage Access API: document.hasStorageAccess() should return false by default
+https://bugs.webkit.org/show_bug.cgi?id=202281
+
+
+Reviewed by Alex Christensen.
+
+document.hasStorageAccess() should return false by default so that it only
+returns true if the context has asked for and been granted storage access.
+
+Source/WebKit:
+
+* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
+(WebKit::ResourceLoadStatisticsDatabaseStore::hasStorageAccess):
+* NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
+(WebKit::ResourceLoadStatisticsMemoryStore::hasStorageAccess):
+
+LayoutTests:
+
+* http/tests/storageAccess/has-storage-access-false-by-default-expected.txt: Added.
+* http/tests/storageAccess/has-storage-access-false-by-default.html: Added.
+* platform/ios/TestExpectations:
+The new test is marked as [ Pass ].
+* platform/mac-wk2/TestExpectations:
+The new test is marked as [ Pass ].
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-09-27  John Wilander  
+
+Storage Access API: document.hasStorageAccess() should return false by default
+https://bugs.webkit.org/show_bug.cgi?id=202281
+
+
+Reviewed by Alex Christensen.
+
+document.hasStorageAccess() should return false by default so that it only
+returns true if the context has asked for and been granted storage access.
+
+* http/tests/storageAccess/has-storage-access-false-by-default-expected.txt: Added.
+* http/tests/storageAccess/has-storage-access-false-by-default.html: Added.
+* platform/ios/TestExpectations:
+The new test is marked as [ Pass ].
+* platform/mac-wk2/TestExpectations:
+The new test is marked as [ Pass ].
+
+2019-10-15  Kocsen Chung  
+
 Cherry-pick r249517. rdar://problem/5699
 
 Mail appears to be double inverting code copied from Notes, Xcode, or Terminal.


Added: branches/safari-608-branch/LayoutTests/http/tests/storageAccess/has-storage-access-false-by-default-expected.txt (0 => 251334)

--- branches/safari-608-branch/LayoutTests/http/tests/storageAccess/has-storage-access-false-by-default-expected.txt	(rev 0)
+++ branches/safari-608-branch/LayoutTests/http/tests/storageAccess/has-storage-access-false-by-default-expected.txt	2019-10-20 17:32:40 UTC (rev 251334)
@@ -0,0 +1,10 @@
+Tests that 

[webkit-changes] [251343] branches/safari-608-branch/Source/WebKit

[bshafiei]

Title: [251343] branches/safari-608-branch/Source/WebKit








Revision 251343
Author bshaf...@apple.com
Date 2019-10-20 10:33:12 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250780. rdar://problem/56061126

Provide options for DTTZ to happen in more situations
https://bugs.webkit.org/show_bug.cgi?id=202634


Reviewed by Antoine Quint.

Add two options that can be enabled to trigger double tap zooming
in more places.

Firstly, an option to keep listening for a double-tap-to-zoom if the
first tap found a click handler on the body or document element. The
tap will still be dispatched. This is probably the most common case
for disabling a DTTZ.

Secondly, an option to always keep listening for a double-tap-to-zoom,
even if there was a clickable (non-root) element under the first tap.

* Shared/WebPreferences.yaml: Add ZoomOnDoubleTapWhenRoot and AlwaysZoomOnDoubleTap.
* UIProcess/PageClient.h: The message from the WebProcess now tells the UIProcess if
the tapped element was a root-level (document or body).
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::handleSmartMagnificationInformationForPotentialTap):
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _endPotentialTapAndEnableDoubleTapGesturesIfNecessary]):
(-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:nodeIsRootLevel:]):
Handle the two new options.

* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::handleSmartMagnificationInformationForPotentialTap):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::potentialTapAtPosition): Check if the tap was on a root-level element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/Shared/WebPreferences.yaml
branches/safari-608-branch/Source/WebKit/UIProcess/PageClient.h
branches/safari-608-branch/Source/WebKit/UIProcess/WebPageProxy.h
branches/safari-608-branch/Source/WebKit/UIProcess/WebPageProxy.messages.in
branches/safari-608-branch/Source/WebKit/UIProcess/ios/PageClientImplIOS.h
branches/safari-608-branch/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
branches/safari-608-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
branches/safari-608-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
branches/safari-608-branch/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: branches/safari-608-branch/Source/WebKit/ChangeLog (251342 => 251343)

--- branches/safari-608-branch/Source/WebKit/ChangeLog	2019-10-20 17:33:08 UTC (rev 251342)
+++ branches/safari-608-branch/Source/WebKit/ChangeLog	2019-10-20 17:33:12 UTC (rev 251343)
@@ -1,5 +1,85 @@
 2019-10-15  Kocsen Chung  
 
+Cherry-pick r250780. rdar://problem/56061126
+
+Provide options for DTTZ to happen in more situations
+https://bugs.webkit.org/show_bug.cgi?id=202634
+
+
+Reviewed by Antoine Quint.
+
+Add two options that can be enabled to trigger double tap zooming
+in more places.
+
+Firstly, an option to keep listening for a double-tap-to-zoom if the
+first tap found a click handler on the body or document element. The
+tap will still be dispatched. This is probably the most common case
+for disabling a DTTZ.
+
+Secondly, an option to always keep listening for a double-tap-to-zoom,
+even if there was a clickable (non-root) element under the first tap.
+
+* Shared/WebPreferences.yaml: Add ZoomOnDoubleTapWhenRoot and AlwaysZoomOnDoubleTap.
+* UIProcess/PageClient.h: The message from the WebProcess now tells the UIProcess if
+the tapped element was a root-level (document or body).
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebPageProxy.messages.in:
+* UIProcess/ios/PageClientImplIOS.h:
+* UIProcess/ios/PageClientImplIOS.mm:
+(WebKit::PageClientImpl::handleSmartMagnificationInformationForPotentialTap):
+* UIProcess/ios/WKContentViewInteraction.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _endPotentialTapAndEnableDoubleTapGesturesIfNecessary]):
+(-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:nodeIsRootLevel:]):
+Handle the two new options.
+
+* UIProcess/ios/WebPageProxyIOS.mm:
+(WebKit::WebPageProxy::handleSmartMagnificationInformationForPotentialTap):
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::potentialTapAtPosition): 

[webkit-changes] [251336] branches/safari-608-branch/Source/JavaScriptCore

[bshafiei]

Title: [251336] branches/safari-608-branch/Source/_javascript_Core








Revision 251336
Author bshaf...@apple.com
Date 2019-10-20 10:32:45 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250629. rdar://problem/56280996

FTL OSR exit shouldn't bother updating get_by_id array profiles that have changed modes
https://bugs.webkit.org/show_bug.cgi?id=202493

Reviewed by Saam Barati.

I added this optimization for DFG but forgot to do it for the FTL
at the same time. This patch rectifies that.

* ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/_javascript_Core/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/ftl/FTLOSRExitCompiler.cpp




Diff

Modified: branches/safari-608-branch/Source/_javascript_Core/ChangeLog (251335 => 251336)

--- branches/safari-608-branch/Source/_javascript_Core/ChangeLog	2019-10-20 17:32:43 UTC (rev 251335)
+++ branches/safari-608-branch/Source/_javascript_Core/ChangeLog	2019-10-20 17:32:45 UTC (rev 251336)
@@ -1,5 +1,35 @@
 2019-10-15  Kocsen Chung  
 
+Cherry-pick r250629. rdar://problem/56280996
+
+FTL OSR exit shouldn't bother updating get_by_id array profiles that have changed modes
+https://bugs.webkit.org/show_bug.cgi?id=202493
+
+Reviewed by Saam Barati.
+
+I added this optimization for DFG but forgot to do it for the FTL
+at the same time. This patch rectifies that.
+
+* ftl/FTLOSRExitCompiler.cpp:
+(JSC::FTL::compileStub):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-02  Keith Miller  
+
+FTL OSR exit shouldn't bother updating get_by_id array profiles that have changed modes
+https://bugs.webkit.org/show_bug.cgi?id=202493
+
+Reviewed by Saam Barati.
+
+I added this optimization for DFG but forgot to do it for the FTL
+at the same time. This patch rectifies that.
+
+* ftl/FTLOSRExitCompiler.cpp:
+(JSC::FTL::compileStub):
+
+2019-10-15  Kocsen Chung  
+
 Cherry-pick r250585. rdar://problem/56280995
 
 ObjectAllocationSinkingPhase shouldn't insert hints for allocations which are no longer valid


Modified: branches/safari-608-branch/Source/_javascript_Core/ftl/FTLOSRExitCompiler.cpp (251335 => 251336)

--- branches/safari-608-branch/Source/_javascript_Core/ftl/FTLOSRExitCompiler.cpp	2019-10-20 17:32:43 UTC (rev 251335)
+++ branches/safari-608-branch/Source/_javascript_Core/ftl/FTLOSRExitCompiler.cpp	2019-10-20 17:32:45 UTC (rev 251336)
@@ -28,6 +28,7 @@
 
 #if ENABLE(FTL_JIT)
 
+#include "BytecodeStructs.h"
 #include "DFGOSRExitCompilerCommon.h"
 #include "DFGOSRExitPreparation.h"
 #include "FTLExitArgumentForOperand.h"
@@ -248,7 +249,15 @@
 
 if (exit.m_kind == BadCache || exit.m_kind == BadIndexingType) {
 CodeOrigin codeOrigin = exit.m_codeOriginForExitProfile;
-if (ArrayProfile* arrayProfile = jit.baselineCodeBlockFor(codeOrigin)->getArrayProfile(codeOrigin.bytecodeIndex())) {
+CodeBlock* codeBlock = jit.baselineCodeBlockFor(codeOrigin);
+if (ArrayProfile* arrayProfile = codeBlock->getArrayProfile(codeOrigin.bytecodeIndex())) {
+const Instruction* instruction = codeBlock->instructions().at(codeOrigin.bytecodeIndex()).ptr();
+CCallHelpers::Jump skipProfile;
+if (instruction->is()) {
+auto& metadata = instruction->as().metadata(codeBlock);
+skipProfile = jit.branch8(CCallHelpers::NotEqual, CCallHelpers::AbsoluteAddress(_modeMetadata.mode), CCallHelpers::TrustedImm32(static_cast(GetByIdMode::ArrayLength)));
+}
+
 jit.load32(MacroAssembler::Address(GPRInfo::regT0, JSCell::structureIDOffset()), GPRInfo::regT1);
 jit.store32(GPRInfo::regT1, arrayProfile->addressOfLastSeenStructureID());
 
@@ -266,6 +275,9 @@
 jit.lshift32(GPRInfo::regT1, GPRInfo::regT2);
 storeArrayModes.link();
 jit.or32(GPRInfo::regT2, MacroAssembler::AbsoluteAddress(arrayProfile->addressOfArrayModes()));
+
+if (skipProfile.isSet())
+skipProfile.link();
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251331] branches/safari-608-branch

[bshafiei]

Title: [251331] branches/safari-608-branch








Revision 251331
Author bshaf...@apple.com
Date 2019-10-20 10:32:28 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r249517. rdar://problem/5699

Mail appears to be double inverting code copied from Notes, Xcode, or Terminal.
https://bugs.webkit.org/show_bug.cgi?id=201368
rdar://problem/40529867

Reviewed by Ryosuke Niwa.

Source/WebCore:

Dark mode content that is pasted should have the inline styles inverse color
transformed by the color filter to match the color filtered document contents.

Layout Test: editing/pasteboard/paste-dark-mode-color-filtered.html
API Tests: PasteHTML.TransformColorsOfDarkContent, PasteHTML.DoesNotTransformColorsOfLightContent,
PasteRTFD.TransformColorsOfDarkContent, PasteRTFD.DoesNotTransformColorsOfLightContent

* editing/EditingStyle.cpp:
(WebCore::EditingStyle::inverseTransformColorIfNeeded): Added caret-color to the transformed properties.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::fragmentNeedsColorTransformed): Added.
(WebCore::ReplaceSelectionCommand::inverseTransformColor): Added.
(WebCore::ReplaceSelectionCommand::doApply): Call fragmentNeedsColorTransformed() and inverseTransformColor().
* editing/ReplaceSelectionCommand.h:

Tools:

Added Tests: PasteHTML.TransformColorsOfDarkContent, PasteHTML.DoesNotTransformColorsOfLightContent,
PasteRTFD.TransformColorsOfDarkContent, PasteRTFD.DoesNotTransformColorsOfLightContent

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
(createWebViewWithCustomPasteboardDataSetting): Added argument to enable color filter.
* TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
(createWebViewWithCustomPasteboardDataEnabled): Added argument to enable color filter.
* TestWebKitAPI/Tests/WebKitCocoa/rich-color-filtered.html: Added.
* TestWebKitAPI/cocoa/TestWKWebView.h:
* TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView forceDarkMode]):

LayoutTests:

* TestExpectations:
* editing/pasteboard/paste-dark-mode-color-filtered-expected.txt: Added.
* editing/pasteboard/paste-dark-mode-color-filtered.html: Added.
* platform/ios-12/TestExpectations:
* platform/ios/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/LayoutTests/TestExpectations
branches/safari-608-branch/LayoutTests/platform/ios/TestExpectations
branches/safari-608-branch/LayoutTests/platform/ios-12/TestExpectations
branches/safari-608-branch/LayoutTests/platform/mac/TestExpectations
branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/editing/EditingStyle.cpp
branches/safari-608-branch/Source/WebCore/editing/ReplaceSelectionCommand.cpp
branches/safari-608-branch/Source/WebCore/editing/ReplaceSelectionCommand.h
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
branches/safari-608-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm
branches/safari-608-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm
branches/safari-608-branch/Tools/TestWebKitAPI/cocoa/TestWKWebView.h
branches/safari-608-branch/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm


Added Paths

branches/safari-608-branch/LayoutTests/editing/pasteboard/paste-dark-mode-color-filtered-expected.txt
branches/safari-608-branch/LayoutTests/editing/pasteboard/paste-dark-mode-color-filtered.html
branches/safari-608-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/rich-color-filtered.html




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (251330 => 251331)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-20 15:09:21 UTC (rev 251330)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-20 17:32:28 UTC (rev 251331)
@@ -1,3 +1,71 @@
+2019-10-15  Kocsen Chung  
+
+Cherry-pick r249517. rdar://problem/5699
+
+Mail appears to be double inverting code copied from Notes, Xcode, or Terminal.
+https://bugs.webkit.org/show_bug.cgi?id=201368
+rdar://problem/40529867
+
+Reviewed by Ryosuke Niwa.
+
+Source/WebCore:
+
+Dark mode content that is pasted should have the inline styles inverse color
+transformed by the color filter to match the color filtered document contents.
+
+Layout Test: editing/pasteboard/paste-dark-mode-color-filtered.html
+API Tests: PasteHTML.TransformColorsOfDarkContent, PasteHTML.DoesNotTransformColorsOfLightContent,
+PasteRTFD.TransformColorsOfDarkContent, PasteRTFD.DoesNotTransformColorsOfLightContent
+
+* editing/EditingStyle.cpp:
+(WebCore::EditingStyle::inverseTransformColorIfNeeded): Added caret-color to the 

[webkit-changes] [251340] branches/safari-608-branch

[bshafiei]

Title: [251340] branches/safari-608-branch








Revision 251340
Author bshaf...@apple.com
Date 2019-10-20 10:33:02 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250729. rdar://problem/56280731

[WebAuthn] Implement _WKWebAuthenticationPanel SPI
https://bugs.webkit.org/show_bug.cgi?id=202559


Reviewed by Brent Fulgham.

Source/WebKit:

This patch implements _WKWebAuthenticationPanel SPI. Here is the structure:
1) API::WebAuthenticationPanel is the APIObject of _WKWebAuthenticationPanel. It is owned by AuthenticatorManager.
The lifetime of _WKWebAuthenticationPanel on the other hand is managed by clients. This binding is the surface
where clients could interact with WebKit's WebAuthentication implementation.
2) API::WebAuthenticationPanelClient is a base class representing _WKWebAuthenticationPanelDelegate. Its subclass
WebKit::WebAuthenticationPanelClient implements bridges to _WKWebAuthenticationPanelDelegate methods. It is owned by
API::WebAuthenticationPanel. A weak pointer of WebKit::WebAuthenticationPanelClient is kept in _WKWebAuthenticationPanel
to get the _WKWebAuthenticationPanelDelegate set by clients or nil otherwise. This binding is the surface where WebKit
interacts with clients.
3) WebAuthenticationPanelFlags is the mirror of enums within _WKWebAuthenticationPanel.

Implementation wise, this patch implements:
1) -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:], this is bridged from
the regular UIDelegate route. Noted, WKFrameInfo is nil for now, a follow up on Bug 202563 will take care of it. This
will be called from AuthenticatorManager::runPanel() which gates the start of discovery on the callback. For clients
that don't implement the delegate, the callback will always be called with _WKWebAuthenticationPanelResultUnavailable
to allow WebKit run on non-UI mode. A specific C API hack is added to always return _WKWebAuthenticationPanelResultPresented
in WebKitTestRunner for layout tests.
2) -[_WKWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:] will be implemented in Bug 200932.
3) -[_WKWebAuthenticationPanelDelegate panel:dismissWebAuthenticationPanelWithResult:], this is bridged from
API::WebAuthenticationPanel/API::WebAuthenticationPanelClient. This will be called whenever AuthenticatorManager::m_pendingCompletionHandler
is invoked. Depending on the respond, _WKWebAuthenticationResult will be returned accordingly. To facilitate that,
invokePendingCompletionHandler is crafted to bundle those two operations.
4) -[_WKWebAuthenticationPanel cancel] will be implemented in Bug 191523.

Besides the above, this patch also silents the NFC action sheet.

* Platform/spi/Cocoa/NearFieldSPI.h:
* Shared/API/APIObject.h:
* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
* Sources.txt:
* SourcesCocoa.txt:
* UIProcess/API/APIUIClient.h:
(API::UIClient::runWebAuthenticationPanel):
* UIProcess/API/APIWebAuthenticationPanel.cpp: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm.
(API::WebAuthenticationPanel::create):
(API::WebAuthenticationPanel::WebAuthenticationPanel):
(API::WebAuthenticationPanel::setClient):
* UIProcess/API/APIWebAuthenticationPanel.h: Copied from Source/WebKit/UIProcess/WebAuthentication/WebAuthenticationRequestData.h.
* UIProcess/API/APIWebAuthenticationPanelClient.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h.
(API::WebAuthenticationPanelClient::dismissPanel const):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/API/C/WKPageUIClient.h:
* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(-[_WKWebAuthenticationPanel dealloc]):
(-[_WKWebAuthenticationPanel relyingPartyID]):
(-[_WKWebAuthenticationPanel delegate]):
(-[_WKWebAuthenticationPanel setDelegate:]):
(-[_WKWebAuthenticationPanel _apiObject]):
(-[_WKWebAuthenticationPanel _initWithRelayingPartyID:]): Deleted.
* UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h:
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::webAuthenticationPanelResult):
(WebKit::UIDelegate::UIClient::runWebAuthenticationPanel):
* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::WebCore::isFeatureEnabled):
(WebKit::WebCore::getRpId):
(WebKit::AuthenticatorManager::handleRequest):
(WebKit::AuthenticatorManager::respondReceived):
(WebKit::AuthenticatorManager::startDiscovery):
(WebKit::AuthenticatorManager::initTimeOutTimer):
(WebKit::AuthenticatorManager::timeOutTimerFired):
(WebKit::AuthenticatorManager::runPanel):
(WebKit::AuthenticatorManager::startRequest):
(WebKit::AuthenticatorManager::invokePendingCompletionHandler):

[webkit-changes] [251333] branches/safari-608-branch

[bshafiei]

Title: [251333] branches/safari-608-branch








Revision 251333
Author bshaf...@apple.com
Date 2019-10-20 10:32:36 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250416. rdar://problem/55954224

SubFrameSOAuthorizationSession should ensure messages are posted in the right order to the parent frame
https://bugs.webkit.org/show_bug.cgi?id=202061


Reviewed by Youenn Fablet.

Source/WebKit:

This patch ensures messages that signal the process of SOAuthorization interception are posted in
the right order to the parent frame. Before this patch, there are chances that SOAuthorizationDidCancel
could be posted to the parent before SOAuthorizationDidStart. There are few causes that lead to
this race condition:
1) SubFrameSOAuthorizationSession::beforeStart posts SOAuthorizationDidStart in the next runloop. So
extension could have the chance to invoke SubFrameSOAuthorizationSession::fallBackToWebPathInternal
before SOAuthorizationDidStart is posted.
2) Even if the order is right in the UI process, it is not guaranteed that Web process will strictly
follow the order as the loading process is async.

To fix the issue:
1) SubFrameSOAuthorizationSession::beforeStart now posts SOAuthorizationDidStart in the same runloop.
2) Observer is introduced in FrameLoadState such that SubFrameSOAuthorizationSession could know if
the loading is finished. With this new capacity, SubFrameSOAuthorizationSession can ensure it only
posts next message when the previous message has been posted.

Implementation wise, a deque to queue requests is provided to maintain order.
1) When new request is added to the deque, SubFrameSOAuthorizationSession will only load the request
if it is the only element in the deque. Otherwise, it does nothing.
2) When SubFrameSOAuthorizationSession receives didFinishLoad, it pops the head of the queue and loads
the next request in the queue if any.
The above design should guarantee all requests are loaded in sequence.

* UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h:
* UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.mm:
(WebKit::SubFrameSOAuthorizationSession::SubFrameSOAuthorizationSession):
(WebKit::SubFrameSOAuthorizationSession::~SubFrameSOAuthorizationSession):
(WebKit::SubFrameSOAuthorizationSession::fallBackToWebPathInternal):
(WebKit::SubFrameSOAuthorizationSession::completeInternal):
(WebKit::SubFrameSOAuthorizationSession::beforeStart):
(WebKit::SubFrameSOAuthorizationSession::didFinishLoad):
(WebKit::SubFrameSOAuthorizationSession::appendRequestToLoad):
(WebKit::SubFrameSOAuthorizationSession::loadRequestToFrame):
(WebKit::SubFrameSOAuthorizationSession::loadDataToFrame): Deleted.
(WebKit::SubFrameSOAuthorizationSession::postDidCancelMessageToParent): Deleted.
* UIProcess/FrameLoadState.cpp:
(WebKit::FrameLoadState::addObserver):
(WebKit::FrameLoadState::removeObserver):
(WebKit::FrameLoadState::didFinishLoad):
* UIProcess/FrameLoadState.h:

Tools:

Adds tests that check the order of messages posted by SubFrameSOAuthorizationSession.

* TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
(-[TestSOAuthorizationScriptMessageHandler userContentController:didReceiveScriptMessage:]):
(resetState):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.mm
branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h
branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.mm
branches/safari-608-branch/Source/WebKit/UIProcess/FrameLoadState.cpp
branches/safari-608-branch/Source/WebKit/UIProcess/FrameLoadState.h
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm




Diff

Modified: branches/safari-608-branch/Source/WebKit/ChangeLog (251332 => 251333)

--- branches/safari-608-branch/Source/WebKit/ChangeLog	2019-10-20 17:32:33 UTC (rev 251332)
+++ branches/safari-608-branch/Source/WebKit/ChangeLog	2019-10-20 17:32:36 UTC (rev 251333)
@@ -1,3 +1,117 @@
+2019-10-15  Kocsen Chung  
+
+Cherry-pick r250416. rdar://problem/55954224
+
+SubFrameSOAuthorizationSession should ensure messages are posted in the right order to the parent frame
+https://bugs.webkit.org/show_bug.cgi?id=202061
+
+
+Reviewed by Youenn Fablet.
+
+Source/WebKit:
+
+This patch ensures messages that signal the process of SOAuthorization interception are posted in
+the right order to the parent frame. Before this patch, there are chances that 

[webkit-changes] [251342] branches/safari-608-branch/Source/WebKit

[bshafiei]

Title: [251342] branches/safari-608-branch/Source/WebKit








Revision 251342
Author bshaf...@apple.com
Date 2019-10-20 10:33:08 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250755. rdar://problem/56061126

Use a better name than allowFastClicksEverywhere
https://bugs.webkit.org/show_bug.cgi?id=202607


Reviewed by Tim Horton.

This preference name is quite confusing. Change it to
PreferFasterClickOverDoubleTap.

* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.h:
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::preferFasterClickOverDoubleTap const):
(WebKit::WebPageProxy::allowsFastClicksEverywhere const): Deleted.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:]):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/Shared/WebPreferences.yaml
branches/safari-608-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.h
branches/safari-608-branch/Source/WebKit/UIProcess/WebPageProxy.h
branches/safari-608-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
branches/safari-608-branch/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm




Diff

Modified: branches/safari-608-branch/Source/WebKit/ChangeLog (251341 => 251342)

--- branches/safari-608-branch/Source/WebKit/ChangeLog	2019-10-20 17:33:05 UTC (rev 251341)
+++ branches/safari-608-branch/Source/WebKit/ChangeLog	2019-10-20 17:33:08 UTC (rev 251342)
@@ -1,5 +1,51 @@
 2019-10-15  Kocsen Chung  
 
+Cherry-pick r250755. rdar://problem/56061126
+
+Use a better name than allowFastClicksEverywhere
+https://bugs.webkit.org/show_bug.cgi?id=202607
+
+
+Reviewed by Tim Horton.
+
+This preference name is quite confusing. Change it to
+PreferFasterClickOverDoubleTap.
+
+* Shared/WebPreferences.yaml:
+* Shared/WebPreferencesDefaultValues.h:
+* UIProcess/WebPageProxy.h:
+(WebKit::WebPageProxy::preferFasterClickOverDoubleTap const):
+(WebKit::WebPageProxy::allowsFastClicksEverywhere const): Deleted.
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:]):
+* UIProcess/ios/WebPageProxyIOS.mm:
+(WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-04  Dean Jackson  
+
+Use a better name than allowFastClicksEverywhere
+https://bugs.webkit.org/show_bug.cgi?id=202607
+
+
+Reviewed by Tim Horton.
+
+This preference name is quite confusing. Change it to
+PreferFasterClickOverDoubleTap.
+
+* Shared/WebPreferences.yaml:
+* Shared/WebPreferencesDefaultValues.h:
+* UIProcess/WebPageProxy.h:
+(WebKit::WebPageProxy::preferFasterClickOverDoubleTap const):
+(WebKit::WebPageProxy::allowsFastClicksEverywhere const): Deleted.
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:]):
+* UIProcess/ios/WebPageProxyIOS.mm:
+(WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):
+
+2019-10-15  Kocsen Chung  
+
 Cherry-pick r250751. rdar://problem/56280731
 
 Unreviewed, build fix after r250729


Modified: branches/safari-608-branch/Source/WebKit/Shared/WebPreferences.yaml (251341 => 251342)

--- branches/safari-608-branch/Source/WebKit/Shared/WebPreferences.yaml	2019-10-20 17:33:05 UTC (rev 251341)
+++ branches/safari-608-branch/Source/WebKit/Shared/WebPreferences.yaml	2019-10-20 17:33:08 UTC (rev 251342)
@@ -1534,17 +1534,17 @@
   type: bool
   defaultValue: true
   condition: PLATFORM(IOS_FAMILY)
-  humanReadableName: "Faster clicks"
+  humanReadableName: "Fast clicks"
   humanReadableDescription: "Support faster clicks on zoomable pages"
   webcoreBinding: none
   category: internal
 
-FastClicksEverywhere:
+PreferFasterClickOverDoubleTap:
   type: bool
-  defaultValue: DEFAULT_FAST_CLICKS_EVERYWHERE
+  defaultValue: DEFAULT_PREFER_FASTER_CLICK_OVER_DOUBLE_TAP
   condition: PLATFORM(IOS_FAMILY)
-  humanReadableName: "Fast clicks everywhere"
-  humanReadableDescription: "Force fast clicks on all pages"
+  humanReadableName: "Use fast clicks before double tap"
+  humanReadableDescription: "Prefer a faster click over a double 

[webkit-changes] [251341] branches/safari-608-branch/Source/WebKit

[bshafiei]

Title: [251341] branches/safari-608-branch/Source/WebKit








Revision 251341
Author bshaf...@apple.com
Date 2019-10-20 10:33:05 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250751. rdar://problem/56280731

Unreviewed, build fix after r250729

* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
* UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h




Diff

Modified: branches/safari-608-branch/Source/WebKit/ChangeLog (251340 => 251341)

--- branches/safari-608-branch/Source/WebKit/ChangeLog	2019-10-20 17:33:02 UTC (rev 251340)
+++ branches/safari-608-branch/Source/WebKit/ChangeLog	2019-10-20 17:33:05 UTC (rev 251341)
@@ -1,5 +1,23 @@
 2019-10-15  Kocsen Chung  
 
+Cherry-pick r250751. rdar://problem/56280731
+
+Unreviewed, build fix after r250729
+
+* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
+* UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-04  Jiewen Tan  
+
+Unreviewed, build fix after r250729
+
+* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
+* UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h:
+
+2019-10-15  Kocsen Chung  
+
 Cherry-pick r250729. rdar://problem/56280731
 
 [WebAuthn] Implement _WKWebAuthenticationPanel SPI


Modified: branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm (251340 => 251341)

--- branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm	2019-10-20 17:33:02 UTC (rev 251340)
+++ branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm	2019-10-20 17:33:05 UTC (rev 251341)
@@ -30,9 +30,13 @@
 #import 
 
 @implementation _WKWebAuthenticationPanel {
+#if ENABLE(WEB_AUTHN)
 WeakPtr _client;
+#endif
 }
 
+#if ENABLE(WEB_AUTHN)
+
 - (void)dealloc
 {
 _panel->~WebAuthenticationPanel();
@@ -59,10 +63,13 @@
 _panel->setClient(WTFMove(client));
 }
 
+#endif // ENABLE(WEB_AUTHN)
+
 - (void)cancel
 {
 }
 
+#if ENABLE(WEB_AUTHN)
 #pragma mark WKObject protocol implementation
 
 - (API::Object&)_apiObject
@@ -69,5 +76,6 @@
 {
 return *_panel;
 }
+#endif
 
 @end


Modified: branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h (251340 => 251341)

--- branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h	2019-10-20 17:33:02 UTC (rev 251340)
+++ branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanelInternal.h	2019-10-20 17:33:05 UTC (rev 251341)
@@ -27,6 +27,8 @@
 
 #import "_WKWebAuthenticationPanel.h"
 
+#if ENABLE(WEB_AUTHN)
+
 #import "APIWebAuthenticationPanel.h"
 #import "WKObject.h"
 
@@ -43,3 +45,5 @@
 API::ObjectStorage _panel;
 }
 @end
+
+#endif // ENABLE(WEB_AUTHN)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251337] branches/safari-608-branch/Source

[bshafiei]

Title: [251337] branches/safari-608-branch/Source








Revision 251337
Author bshaf...@apple.com
Date 2019-10-20 10:32:48 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250642. rdar://problem/56280704

[iOS] When hit testing for a context menu interaction, do not consider whether the element is contenteditable
https://bugs.webkit.org/show_bug.cgi?id=202498


Reviewed by Tim Horton.

Source/WebCore:

When the user selects a context menu action, WebKit performs a hit test in order to find the
acted-on element on the page. This is separate from the hit test performed to generate the
context menu's targeted preview. Since an arbitrary amount of time can elapse between
preview generation and action selection, this second hit-tests might return a different
element.

One case where we know a different element can be returned is in apps that dynamically
enable and disable editing. If editing is disabled when the first hit test occurs but is
enabled when the second one occurs, different elements will be returned due to
Frame::qualifyingNodeAtViewportLocation preferring to return the root editable element when
the approximate node is contenteditable.

While the appropriate long-term fix is to only hit-test once and use that element for both
preview generation and action selection, this patch implements a short-term fix to address
the specific problem in rdar://problem/54723131 by disabling the contenteditable behavior
described above for context menu interaction hit testing.

The long-term fix is tracked by .

* page/Frame.h:
* page/ios/FrameIOS.mm:
(WebCore::Frame::qualifyingNodeAtViewportLocation):
(WebCore::Frame::approximateNodeAtViewportLocationLegacy):
(WebCore::ancestorRespondingToClickEventsNodeQualifier):
(WebCore::Frame::nodeRespondingToClickEvents):
(WebCore::Frame::nodeRespondingToDoubleClickEvent):
(WebCore::Frame::nodeRespondingToInteraction):
(WebCore::Frame::nodeRespondingToScrollWheelEvents):

Source/WebKit:

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::startInteractionWithElementAtPosition): Changed to call
WebCore::Frame::nodeRespondingToInteraction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/page/Frame.h
branches/safari-608-branch/Source/WebCore/page/ios/FrameIOS.mm
branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (251336 => 251337)

--- branches/safari-608-branch/Source/WebCore/ChangeLog	2019-10-20 17:32:45 UTC (rev 251336)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2019-10-20 17:32:48 UTC (rev 251337)
@@ -1,5 +1,92 @@
 2019-10-15  Kocsen Chung  
 
+Cherry-pick r250642. rdar://problem/56280704
+
+[iOS] When hit testing for a context menu interaction, do not consider whether the element is contenteditable
+https://bugs.webkit.org/show_bug.cgi?id=202498
+
+
+Reviewed by Tim Horton.
+
+Source/WebCore:
+
+When the user selects a context menu action, WebKit performs a hit test in order to find the
+acted-on element on the page. This is separate from the hit test performed to generate the
+context menu's targeted preview. Since an arbitrary amount of time can elapse between
+preview generation and action selection, this second hit-tests might return a different
+element.
+
+One case where we know a different element can be returned is in apps that dynamically
+enable and disable editing. If editing is disabled when the first hit test occurs but is
+enabled when the second one occurs, different elements will be returned due to
+Frame::qualifyingNodeAtViewportLocation preferring to return the root editable element when
+the approximate node is contenteditable.
+
+While the appropriate long-term fix is to only hit-test once and use that element for both
+preview generation and action selection, this patch implements a short-term fix to address
+the specific problem in rdar://problem/54723131 by disabling the contenteditable behavior
+described above for context menu interaction hit testing.
+
+The long-term fix is tracked by .
+
+* page/Frame.h:
+* page/ios/FrameIOS.mm:
+(WebCore::Frame::qualifyingNodeAtViewportLocation):
+(WebCore::Frame::approximateNodeAtViewportLocationLegacy):
+(WebCore::ancestorRespondingToClickEventsNodeQualifier):
+(WebCore::Frame::nodeRespondingToClickEvents):
+(WebCore::Frame::nodeRespondingToDoubleClickEvent):
+(WebCore::Frame::nodeRespondingToInteraction):
+(WebCore::Frame::nodeRespondingToScrollWheelEvents):
+
+Source/WebKit:
+
+ 

[webkit-changes] [251339] branches/safari-608-branch/Source/WebCore

[bshafiei]

Title: [251339] branches/safari-608-branch/Source/WebCore








Revision 251339
Author bshaf...@apple.com
Date 2019-10-20 10:32:54 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250716. rdar://problem/56280993

AppleTV named as XSS-payloads trigger when AirPlay is used
https://bugs.webkit.org/show_bug.cgi?id=202534


Reviewed by Eric Carlson.

Ensure we escape an AirPlay's device name before inserting its name into the DOM.

* Modules/modern-media-controls/media/placard-support.js:
(PlacardSupport.prototype._updateAirPlayPlacard):
(PlacardSupport):
(escapeHTML):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/Modules/modern-media-controls/media/placard-support.js




Diff

Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (251338 => 251339)

--- branches/safari-608-branch/Source/WebCore/ChangeLog	2019-10-20 17:32:51 UTC (rev 251338)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2019-10-20 17:32:54 UTC (rev 251339)
@@ -1,5 +1,39 @@
 2019-10-15  Kocsen Chung  
 
+Cherry-pick r250716. rdar://problem/56280993
+
+AppleTV named as XSS-payloads trigger when AirPlay is used
+https://bugs.webkit.org/show_bug.cgi?id=202534
+
+
+Reviewed by Eric Carlson.
+
+Ensure we escape an AirPlay's device name before inserting its name into the DOM.
+
+* Modules/modern-media-controls/media/placard-support.js:
+(PlacardSupport.prototype._updateAirPlayPlacard):
+(PlacardSupport):
+(escapeHTML):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-03  Antoine Quint  
+
+AppleTV named as XSS-payloads trigger when AirPlay is used
+https://bugs.webkit.org/show_bug.cgi?id=202534
+
+
+Reviewed by Eric Carlson.
+
+Ensure we escape an AirPlay's device name before inserting its name into the DOM.
+
+* Modules/modern-media-controls/media/placard-support.js:
+(PlacardSupport.prototype._updateAirPlayPlacard):
+(PlacardSupport):
+(escapeHTML):
+
+2019-10-15  Kocsen Chung  
+
 Cherry-pick r250694. rdar://problem/56061131
 
 [iOS] WebContent process can be interrupted during suspension; loses "Now Playing" status


Modified: branches/safari-608-branch/Source/WebCore/Modules/modern-media-controls/media/placard-support.js (251338 => 251339)

--- branches/safari-608-branch/Source/WebCore/Modules/modern-media-controls/media/placard-support.js	2019-10-20 17:32:51 UTC (rev 251338)
+++ branches/safari-608-branch/Source/WebCore/Modules/modern-media-controls/media/placard-support.js	2019-10-20 17:32:54 UTC (rev 251339)
@@ -80,7 +80,7 @@
 
 switch(this.mediaController.host.externalDeviceType) {
 case 'airplay':
-deviceName = UIString("This video is playing on “%s”.", this.mediaController.host.externalDeviceDisplayName || UIString("Apple TV"));
+deviceName = UIString("This video is playing on “%s”.", escapeHTML(this.mediaController.host.externalDeviceDisplayName) || UIString("Apple TV"));
 break;
 case 'tvout':
 deviceName = UIString("This video is playing on the TV.");
@@ -90,3 +90,10 @@
 }
 
 }
+
+function escapeHTML(unsafeString)
+{
+var div = document.createElement("div");
+div.textContent = unsafeString;
+return div.innerHTML;
+}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251345] branches/safari-608-branch

[bshafiei]

Title: [251345] branches/safari-608-branch








Revision 251345
Author bshaf...@apple.com
Date 2019-10-20 10:33:22 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250833. rdar://problem/56280706

Apply patch. rdar://problem/55920073

git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-608.3.10.1-branch@250833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp
branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkProcess.h
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm




Diff

Modified: branches/safari-608-branch/Source/WebKit/ChangeLog (251344 => 251345)

--- branches/safari-608-branch/Source/WebKit/ChangeLog	2019-10-20 17:33:19 UTC (rev 251344)
+++ branches/safari-608-branch/Source/WebKit/ChangeLog	2019-10-20 17:33:22 UTC (rev 251345)
@@ -1,3 +1,34 @@
+2019-10-15  Alan Coon  
+
+Cherry-pick r250833. rdar://problem/56280706
+
+Apply patch. rdar://problem/55920073
+
+git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-608.3.10.1-branch@250833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-08  Alan Coon  
+
+Apply patch. rdar://problem/55920073
+
+2019-10-08  youenn fablet  
+
+Remove the protection to spin more than one service worker process at a time.
+rdar://problem/55044713
+
+Before site isolation, we were creating one service worker process for all domains.
+We now create one service worker process per domain, which makes the protection to only spin
+one service worker process potentially harmful: if two requests to create a service worker processes
+for two different domains are made, only one will actually succeed.
+This is reproduced by API test.
+
+At UIProcess side, there is already a check to see whether a service worker process for a given domain is launched.
+That protects against spinning several service worker processes for the same domain.
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
+(WebKit::NetworkProcess::createServerToContextConnection):
+* NetworkProcess/NetworkProcess.h:
+
 2019-10-15  Kocsen Chung  
 
 Cherry-pick r250780. rdar://problem/56061126


Modified: branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp (251344 => 251345)

--- branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2019-10-20 17:33:19 UTC (rev 251344)
+++ branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2019-10-20 17:33:22 UTC (rev 251345)
@@ -430,13 +430,10 @@
 #if ENABLE(SERVICE_WORKER)
 if (isServiceWorkerProcess && !m_webProcessConnections.isEmpty()) {
 ASSERT(parentProcessHasServiceWorkerEntitlement());
-ASSERT(m_waitingForServerToContextProcessConnection);
 auto contextConnection = WebSWServerToContextConnection::create(*this, registrableDomain, m_webProcessConnections.last()->connection());
 auto addResult = m_serverToContextConnections.add(WTFMove(registrableDomain), contextConnection.copyRef());
 ASSERT_UNUSED(addResult, addResult.isNewEntry);
 
-m_waitingForServerToContextProcessConnection = false;
-
 for (auto* server : SWServer::allServers())
 server->serverToContextConnectionCreated(contextConnection);
 }
@@ -2442,10 +2439,6 @@
 
 void NetworkProcess::createServerToContextConnection(const RegistrableDomain& registrableDomain, Optional sessionID)
 {
-if (m_waitingForServerToContextProcessConnection)
-return;
-
-m_waitingForServerToContextProcessConnection = true;
 if (sessionID)
 parentProcessConnection()->send(Messages::NetworkProcessProxy::EstablishWorkerContextConnectionToNetworkProcessForExplicitSession(registrableDomain, *sessionID), 0);
 else


Modified: branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkProcess.h (251344 => 251345)

--- branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkProcess.h	2019-10-20 17:33:19 UTC (rev 251344)
+++ branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkProcess.h	2019-10-20 17:33:22 UTC (rev 251345)
@@ -536,7 +536,6 @@
 
 #if ENABLE(SERVICE_WORKER)
 HashMap> m_serverToContextConnections;
-bool m_waitingForServerToContextProcessConnection { false };
 bool m_shouldDisableServiceWorkerProcessTerminationDelay { false };
 HashMap m_swDatabasePaths;
 HashMap> m_swServers;


Modified: branches/safari-608-branch/Tools/ChangeLog (251344 => 251345)

--- branches/safari-608-branch/Tools/ChangeLog	2019-10-20 17:33:19 UTC (rev 251344)
+++ 

[webkit-changes] [251332] branches/safari-608-branch

[bshafiei]

Title: [251332] branches/safari-608-branch








Revision 251332
Author bshaf...@apple.com
Date 2019-10-20 10:32:33 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r249959. rdar://problem/56280989

CheckArray on DirectArguments/ScopedArguments does not filter out slow put array storage
https://bugs.webkit.org/show_bug.cgi?id=201853


Reviewed by Yusuke Suzuki.

JSTests:

* stress/direct-arguments-check-array-filter-type.js: Added.
(foo):

Source/_javascript_Core:

We were claiming CheckArray for ScopedArguments/DirectArguments was filtering
out SlowPutArrayStorage. It does no such thing. We just check that the object
is either ScopedArguments/DirectArguments.

* dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::arrayModesThatPassFiltering const):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShapes const):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShape const): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/JSTests/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/dfg/DFGArrayMode.h


Added Paths

branches/safari-608-branch/JSTests/stress/direct-arguments-check-array-filter-type.js




Diff

Modified: branches/safari-608-branch/JSTests/ChangeLog (251331 => 251332)

--- branches/safari-608-branch/JSTests/ChangeLog	2019-10-20 17:32:28 UTC (rev 251331)
+++ branches/safari-608-branch/JSTests/ChangeLog	2019-10-20 17:32:33 UTC (rev 251332)
@@ -1,3 +1,43 @@
+2019-10-15  Kocsen Chung  
+
+Cherry-pick r249959. rdar://problem/56280989
+
+CheckArray on DirectArguments/ScopedArguments does not filter out slow put array storage
+https://bugs.webkit.org/show_bug.cgi?id=201853
+
+
+Reviewed by Yusuke Suzuki.
+
+JSTests:
+
+* stress/direct-arguments-check-array-filter-type.js: Added.
+(foo):
+
+Source/_javascript_Core:
+
+We were claiming CheckArray for ScopedArguments/DirectArguments was filtering
+out SlowPutArrayStorage. It does no such thing. We just check that the object
+is either ScopedArguments/DirectArguments.
+
+* dfg/DFGArrayMode.h:
+(JSC::DFG::ArrayMode::arrayModesThatPassFiltering const):
+(JSC::DFG::ArrayMode::arrayModesWithIndexingShapes const):
+(JSC::DFG::ArrayMode::arrayModesWithIndexingShape const): Deleted.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-09-17  Saam Barati  
+
+CheckArray on DirectArguments/ScopedArguments does not filter out slow put array storage
+https://bugs.webkit.org/show_bug.cgi?id=201853
+
+
+Reviewed by Yusuke Suzuki.
+
+* stress/direct-arguments-check-array-filter-type.js: Added.
+(foo):
+
 2019-09-30  Babak Shafiei  
 
 Cherry-pick r250058. rdar://problem/55826329


Added: branches/safari-608-branch/JSTests/stress/direct-arguments-check-array-filter-type.js (0 => 251332)

--- branches/safari-608-branch/JSTests/stress/direct-arguments-check-array-filter-type.js	(rev 0)
+++ branches/safari-608-branch/JSTests/stress/direct-arguments-check-array-filter-type.js	2019-10-20 17:32:33 UTC (rev 251332)
@@ -0,0 +1,12 @@
+//@ runDefault("--jitPolicyScale=0", "--useRandomizingFuzzerAgent=1", "--validateAbstractInterpreterState=1", "--validateAbstractInterpreterStateProbability=1.0",  "--useConcurrentJIT=0")
+
+function foo(a0, a1) {
+Function.__defineSetter__(0, ()=>{});
+Object.freeze(arguments);
+for (let i = 0; i < 3; i++) {}
+arguments[0];
+const x = 0;
+const y = 0;
+}
+
+foo();


Modified: branches/safari-608-branch/Source/_javascript_Core/ChangeLog (251331 => 251332)

--- branches/safari-608-branch/Source/_javascript_Core/ChangeLog	2019-10-20 17:32:28 UTC (rev 251331)
+++ branches/safari-608-branch/Source/_javascript_Core/ChangeLog	2019-10-20 17:32:33 UTC (rev 251332)
@@ -1,3 +1,49 @@
+2019-10-15  Kocsen Chung  
+
+Cherry-pick r249959. rdar://problem/56280989
+
+CheckArray on DirectArguments/ScopedArguments does not filter out slow put array storage
+https://bugs.webkit.org/show_bug.cgi?id=201853
+
+
+Reviewed by Yusuke Suzuki.
+
+JSTests:
+
+* stress/direct-arguments-check-array-filter-type.js: Added.
+(foo):
+
+Source/_javascript_Core:
+
+We were claiming CheckArray for ScopedArguments/DirectArguments was filtering
+out SlowPutArrayStorage. It does no such thing. We just check that the object
+is either ScopedArguments/DirectArguments.
+
+* dfg/DFGArrayMode.h:
+(JSC::DFG::ArrayMode::arrayModesThatPassFiltering const):
+(JSC::DFG::ArrayMode::arrayModesWithIndexingShapes const):
+(JSC::DFG::ArrayMode::arrayModesWithIndexingShape const): Deleted.
+
+ 

[webkit-changes] [251338] branches/safari-608-branch/Source/WebCore

[bshafiei]

Title: [251338] branches/safari-608-branch/Source/WebCore








Revision 251338
Author bshaf...@apple.com
Date 2019-10-20 10:32:51 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250694. rdar://problem/56061131

[iOS] WebContent process can be interrupted during suspension; loses "Now Playing" status
https://bugs.webkit.org/show_bug.cgi?id=202537


Reviewed by Eric Carlson.

Always deactivate the AVAudioSession when the last playing PlatformAudioSession ends playback and the application is in the background.

* platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::removeSession):
(WebCore::PlatformMediaSessionManager::processWillSuspend):
(WebCore::PlatformMediaSessionManager::maybeDeactivateAudioSession):
* platform/audio/PlatformMediaSessionManager.h:
(WebCore::PlatformMediaSessionManager::isApplicationInBackground const):
* platform/audio/ios/MediaSessionManagerIOS.h:
* platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::sessionWillEndPlayback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
branches/safari-608-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.h
branches/safari-608-branch/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h
branches/safari-608-branch/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm




Diff

Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (251337 => 251338)

--- branches/safari-608-branch/Source/WebCore/ChangeLog	2019-10-20 17:32:48 UTC (rev 251337)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2019-10-20 17:32:51 UTC (rev 251338)
@@ -1,5 +1,51 @@
 2019-10-15  Kocsen Chung  
 
+Cherry-pick r250694. rdar://problem/56061131
+
+[iOS] WebContent process can be interrupted during suspension; loses "Now Playing" status
+https://bugs.webkit.org/show_bug.cgi?id=202537
+
+
+Reviewed by Eric Carlson.
+
+Always deactivate the AVAudioSession when the last playing PlatformAudioSession ends playback and the application is in the background.
+
+* platform/audio/PlatformMediaSessionManager.cpp:
+(WebCore::PlatformMediaSessionManager::removeSession):
+(WebCore::PlatformMediaSessionManager::processWillSuspend):
+(WebCore::PlatformMediaSessionManager::maybeDeactivateAudioSession):
+* platform/audio/PlatformMediaSessionManager.h:
+(WebCore::PlatformMediaSessionManager::isApplicationInBackground const):
+* platform/audio/ios/MediaSessionManagerIOS.h:
+* platform/audio/ios/MediaSessionManagerIOS.mm:
+(WebCore::MediaSessionManageriOS::sessionWillEndPlayback):
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-03  Jer Noble  
+
+[iOS] WebContent process can be interrupted during suspension; loses "Now Playing" status
+https://bugs.webkit.org/show_bug.cgi?id=202537
+
+
+Reviewed by Eric Carlson.
+
+Always deactivate the AVAudioSession when the last playing PlatformAudioSession ends playback and the application is in the background.
+
+* platform/audio/PlatformMediaSessionManager.cpp:
+(WebCore::PlatformMediaSessionManager::removeSession):
+(WebCore::PlatformMediaSessionManager::processWillSuspend):
+(WebCore::PlatformMediaSessionManager::maybeDeactivateAudioSession):
+* platform/audio/PlatformMediaSessionManager.h:
+(WebCore::PlatformMediaSessionManager::isApplicationInBackground const):
+* platform/audio/ios/MediaSessionManagerIOS.h:
+* platform/audio/ios/MediaSessionManagerIOS.mm:
+(WebCore::MediaSessionManageriOS::sessionWillEndPlayback):
+
+2019-10-15  Kocsen Chung  
+
 Cherry-pick r250642. rdar://problem/56280704
 
 [iOS] When hit testing for a context menu interaction, do not consider whether the element is contenteditable


Modified: branches/safari-608-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp (251337 => 251338)

--- branches/safari-608-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp	2019-10-20 17:32:48 UTC (rev 251337)
+++ branches/safari-608-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp	2019-10-20 17:32:51 UTC (rev 251338)
@@ -166,10 +166,7 @@
 m_remoteCommandListener = nullptr;
 m_audioHardwareListener = nullptr;
 #if USE(AUDIO_SESSION)
-if (m_becameActive && shouldDeactivateAudioSession()) {
-AudioSession::sharedSession().tryToSetActive(false);
-m_becameActive = false;
-}
+

[webkit-changes] [251346] branches/safari-608-branch

[bshafiei]

Title: [251346] branches/safari-608-branch








Revision 251346
Author bshaf...@apple.com
Date 2019-10-20 10:33:25 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250929. rdar://problem/56280990

RunResolver::rangeForRendererWithOffsets should check for range end
https://bugs.webkit.org/show_bug.cgi?id=202761


Reviewed by Antti Koivisto.

Source/WebCore:

This patch ensures that when rangeForRenderer comes back with a collapsed run (empty range), rangeForRendererWithOffsets returns an empty range as well.

Test: fast/text/simple-line-layout-range-check-end.html

* rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::RunResolver::rangeForRendererWithOffsets const):

LayoutTests:

* fast/text/simple-line-layout-range-check-end-expected.txt: Added.
* fast/text/simple-line-layout-range-check-end.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/rendering/SimpleLineLayoutResolver.cpp


Added Paths

branches/safari-608-branch/LayoutTests/fast/text/simple-line-layout-range-check-end-expected.txt
branches/safari-608-branch/LayoutTests/fast/text/simple-line-layout-range-check-end.html




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (251345 => 251346)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-20 17:33:22 UTC (rev 251345)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-20 17:33:25 UTC (rev 251346)
@@ -1,5 +1,42 @@
 2019-10-15  Kocsen Chung  
 
+Cherry-pick r250929. rdar://problem/56280990
+
+RunResolver::rangeForRendererWithOffsets should check for range end
+https://bugs.webkit.org/show_bug.cgi?id=202761
+
+
+Reviewed by Antti Koivisto.
+
+Source/WebCore:
+
+This patch ensures that when rangeForRenderer comes back with a collapsed run (empty range), rangeForRendererWithOffsets returns an empty range as well.
+
+Test: fast/text/simple-line-layout-range-check-end.html
+
+* rendering/SimpleLineLayoutResolver.cpp:
+(WebCore::SimpleLineLayout::RunResolver::rangeForRendererWithOffsets const):
+
+LayoutTests:
+
+* fast/text/simple-line-layout-range-check-end-expected.txt: Added.
+* fast/text/simple-line-layout-range-check-end.html: Added.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-09  Zalan Bujtas  
+
+RunResolver::rangeForRendererWithOffsets should check for range end
+https://bugs.webkit.org/show_bug.cgi?id=202761
+
+
+Reviewed by Antti Koivisto.
+
+* fast/text/simple-line-layout-range-check-end-expected.txt: Added.
+* fast/text/simple-line-layout-range-check-end.html: Added.
+
+2019-10-15  Kocsen Chung  
+
 Cherry-pick r250811. rdar://problem/56061121
 
 Only wrapping CryptoKeys for IDB during serialization


Added: branches/safari-608-branch/LayoutTests/fast/text/simple-line-layout-range-check-end-expected.txt (0 => 251346)

--- branches/safari-608-branch/LayoutTests/fast/text/simple-line-layout-range-check-end-expected.txt	(rev 0)
+++ branches/safari-608-branch/LayoutTests/fast/text/simple-line-layout-range-check-end-expected.txt	2019-10-20 17:33:25 UTC (rev 251346)
@@ -0,0 +1,3 @@
+Pass if no crash or assert.
+text
+


Added: branches/safari-608-branch/LayoutTests/fast/text/simple-line-layout-range-check-end.html (0 => 251346)

--- branches/safari-608-branch/LayoutTests/fast/text/simple-line-layout-range-check-end.html	(rev 0)
+++ branches/safari-608-branch/LayoutTests/fast/text/simple-line-layout-range-check-end.html	2019-10-20 17:33:25 UTC (rev 251346)
@@ -0,0 +1,14 @@
+Pass if no crash or assert.
+
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+middle.after("text");
+
+var foo = document.createRange();
+foo.selectNodeContents(last);
+foo.setStartAfter(first);
+foo.getBoundingClientRect();
+


Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (251345 => 251346)

--- branches/safari-608-branch/Source/WebCore/ChangeLog	2019-10-20 17:33:22 UTC (rev 251345)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2019-10-20 17:33:25 UTC (rev 251346)
@@ -1,5 +1,46 @@
 2019-10-15  Kocsen Chung  
 
+Cherry-pick r250929. rdar://problem/56280990
+
+RunResolver::rangeForRendererWithOffsets should check for range end
+https://bugs.webkit.org/show_bug.cgi?id=202761
+
+
+Reviewed by Antti Koivisto.
+
+Source/WebCore:
+
+This patch ensures that when rangeForRenderer comes back with a collapsed run (empty range), rangeForRendererWithOffsets returns an empty range as well.
+
+Test: 

[webkit-changes] [251335] branches/safari-608-branch

[bshafiei]

Title: [251335] branches/safari-608-branch








Revision 251335
Author bshaf...@apple.com
Date 2019-10-20 10:32:43 -0700 (Sun, 20 Oct 2019)


Log Message
Cherry-pick r250585. rdar://problem/56280995

ObjectAllocationSinkingPhase shouldn't insert hints for allocations which are no longer valid
https://bugs.webkit.org/show_bug.cgi?id=199361


Reviewed by Yusuke Suzuki.

JSTests:

* stress/allocation-sinking-hints-are-valid-ssa-2.js: Added.
(main.fn):
(main.executor):
(main):
* stress/allocation-sinking-hints-are-valid-ssa.js: Added.
(main.fn):
(main.executor):
(main):

Source/_javascript_Core:

In a prior fix to the object allocation sinking phase, I added code where we
made sure to insert PutHints over Phis for fields of an object at control flow
merge points. However, that code didn't consider that the base of the PutHint
may no longer be a valid heap location. This could cause us to emit invalid
SSA code by referring to a node which does not dominate the PutHint location.
This patch fixes the bug to only emit the PutHints when valid.

This patch also makes it so that DFGValidate actually validates that the graph
is in valid SSA form. E.g, any use of a node N must be dominated by N.

* dfg/DFGObjectAllocationSinkingPhase.cpp:
* dfg/DFGValidate.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/JSTests/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp
branches/safari-608-branch/Source/_javascript_Core/dfg/DFGValidate.cpp


Added Paths

branches/safari-608-branch/JSTests/stress/allocation-sinking-hints-are-valid-ssa-2.js
branches/safari-608-branch/JSTests/stress/allocation-sinking-hints-are-valid-ssa.js




Diff

Modified: branches/safari-608-branch/JSTests/ChangeLog (251334 => 251335)

--- branches/safari-608-branch/JSTests/ChangeLog	2019-10-20 17:32:40 UTC (rev 251334)
+++ branches/safari-608-branch/JSTests/ChangeLog	2019-10-20 17:32:43 UTC (rev 251335)
@@ -1,5 +1,62 @@
 2019-10-15  Kocsen Chung  
 
+Cherry-pick r250585. rdar://problem/56280995
+
+ObjectAllocationSinkingPhase shouldn't insert hints for allocations which are no longer valid
+https://bugs.webkit.org/show_bug.cgi?id=199361
+
+
+Reviewed by Yusuke Suzuki.
+
+JSTests:
+
+* stress/allocation-sinking-hints-are-valid-ssa-2.js: Added.
+(main.fn):
+(main.executor):
+(main):
+* stress/allocation-sinking-hints-are-valid-ssa.js: Added.
+(main.fn):
+(main.executor):
+(main):
+
+Source/_javascript_Core:
+
+In a prior fix to the object allocation sinking phase, I added code where we
+made sure to insert PutHints over Phis for fields of an object at control flow
+merge points. However, that code didn't consider that the base of the PutHint
+may no longer be a valid heap location. This could cause us to emit invalid
+SSA code by referring to a node which does not dominate the PutHint location.
+This patch fixes the bug to only emit the PutHints when valid.
+
+This patch also makes it so that DFGValidate actually validates that the graph
+is in valid SSA form. E.g, any use of a node N must be dominated by N.
+
+* dfg/DFGObjectAllocationSinkingPhase.cpp:
+* dfg/DFGValidate.cpp:
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-01  Saam Barati  
+
+ObjectAllocationSinkingPhase shouldn't insert hints for allocations which are no longer valid
+https://bugs.webkit.org/show_bug.cgi?id=199361
+
+
+Reviewed by Yusuke Suzuki.
+
+* stress/allocation-sinking-hints-are-valid-ssa-2.js: Added.
+(main.fn):
+(main.executor):
+(main):
+* stress/allocation-sinking-hints-are-valid-ssa.js: Added.
+(main.fn):
+(main.executor):
+(main):
+
+2019-10-15  Kocsen Chung  
+
 Cherry-pick r249959. rdar://problem/56280989
 
 CheckArray on DirectArguments/ScopedArguments does not filter out slow put array storage


Added: branches/safari-608-branch/JSTests/stress/allocation-sinking-hints-are-valid-ssa-2.js (0 => 251335)

--- branches/safari-608-branch/JSTests/stress/allocation-sinking-hints-are-valid-ssa-2.js	(rev 0)
+++ branches/safari-608-branch/JSTests/stress/allocation-sinking-hints-are-valid-ssa-2.js	2019-10-20 17:32:43 UTC (rev 251335)
@@ -0,0 +1,31 @@
+function main() {
+const arr = [0];
+function executor(resolve, ...reject) {
+arr;
+if (resolve > arr) {
+const fn = () => {
+return fn;
+};
+for 

[webkit-changes] [250509] branches/safari-608-branch/Source/WebCore

[bshafiei]

Title: [250509] branches/safari-608-branch/Source/WebCore








Revision 250509
Author bshaf...@apple.com
Date 2019-09-30 01:30:51 -0700 (Mon, 30 Sep 2019)


Log Message
Cherry-pick r249930. rdar://problem/55826316

AX: USER: VO: Messages > Message > Shift-VO-M doesn't reveal correct actions
https://bugs.webkit.org/show_bug.cgi?id=201840

Patch by Eric Liang  on 2019-09-16
Reviewed by Chris Fleizach.

menuForEvent: expects event-position in window's space, but we pass the position in Core's space. In this case, we need to convert core's space to window's space.
Tested that existing tests passed with WK1 and WK2

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm




Diff

Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (250508 => 250509)

--- branches/safari-608-branch/Source/WebCore/ChangeLog	2019-09-30 08:30:48 UTC (rev 250508)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2019-09-30 08:30:51 UTC (rev 250509)
@@ -1,5 +1,36 @@
 2019-09-30  Babak Shafiei  
 
+Cherry-pick r249930. rdar://problem/55826316
+
+AX: USER: VO: Messages > Message > Shift-VO-M doesn't reveal correct actions
+https://bugs.webkit.org/show_bug.cgi?id=201840
+
+Patch by Eric Liang  on 2019-09-16
+Reviewed by Chris Fleizach.
+
+menuForEvent: expects event-position in window's space, but we pass the position in Core's space. In this case, we need to convert core's space to window's space.
+Tested that existing tests passed with WK1 and WK2
+
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-09-16  Eric Liang  
+
+AX: USER: VO: Messages > Message > Shift-VO-M doesn't reveal correct actions
+https://bugs.webkit.org/show_bug.cgi?id=201840
+
+Reviewed by Chris Fleizach.
+
+menuForEvent: expects event-position in window's space, but we pass the position in Core's space. In this case, we need to convert core's space to window's space.
+Tested that existing tests passed with WK1 and WK2
+
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):
+
+2019-09-30  Babak Shafiei  
+
 Cherry-pick r249077. rdar://problem/55826882
 
 Crash under TimerBase::setNextFireTime() in the NetworkProcess


Modified: branches/safari-608-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (250508 => 250509)

--- branches/safari-608-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm	2019-09-30 08:30:48 UTC (rev 250508)
+++ branches/safari-608-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm	2019-09-30 08:30:51 UTC (rev 250509)
@@ -3777,19 +3777,23 @@
 IntRect rect = snappedIntRect(m_object->elementRect());
 FrameView* frameView = m_object->documentFrameView();
 
-// On WK2, we need to account for the scroll position.
-// On WK1, this isn't necessary, it's taken care of by the attachment views.
-if (frameView && !frameView->platformWidget()) {
+// On WK2, we need to account for the scroll position with regards to root view.
+// On WK1, we need to convert rect to window space to match mouse clicking.
+if (frameView) {
 // Find the appropriate scroll view to use to convert the contents to the window.
 for (AccessibilityObject* parent = m_object->parentObject(); parent; parent = parent->parentObject()) {
 if (is(*parent)) {
-ScrollView* scrollView = downcast(*parent).scrollView();
-rect = scrollView->contentsToRootView(rect);
+if (auto scrollView = downcast(*parent).scrollView()) {
+if (!frameView->platformWidget())
+rect = scrollView->contentsToRootView(rect);
+else
+rect = scrollView->contentsToWindow(rect);
+}
 break;
 }
 }
 }
-
+
 page->contextMenuController().showContextMenuAt(page->mainFrame(), rect.center());
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250508] branches/safari-608-branch

[bshafiei]

Title: [250508] branches/safari-608-branch








Revision 250508
Author bshaf...@apple.com
Date 2019-09-30 01:30:48 -0700 (Mon, 30 Sep 2019)


Log Message
Cherry-pick r249926. rdar://problem/55826870

[JSC] Perform check again when we found non-BMP characters
https://bugs.webkit.org/show_bug.cgi?id=201647

Reviewed by Yusuke Suzuki.

JSTests:

* stress/regexp-unicode-surrogate-pair-increment-should-involve-length-check.js: Added.
* stress/regexp-unicode-within-string.js: Updated test to eliminate the bogus print().
(testRegExpInbounds):

Source/_javascript_Core:

We need to check for end of input for non-BMP characters when matching a character class that contains
both BMP and non-BMP characters.  In advanceIndexAfterCharacterClassTermMatch() we were checking for
end of input for both BMP and non-BMP characters.  For BMP characters, this check is redundant.
After moving the check to after the "is BMP check", we need to decrement index after reaching the failure
label to back out the index++ for the first surrogate of the non-BMP character.

Added the same kind of check in generateCharacterClassOnce().  In that case, we have pre-checked the
first character (surrogate) for a non-BMP codepoint, so we just need to check for end of input before
we increment for the second surrogate.

While writing tests, I found an off by one error in backtrackCharacterClassGreedy() and changed the
loop to check the count at loop top instead of loop bottom.

* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::advanceIndexAfterCharacterClassTermMatch):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/JSTests/ChangeLog
branches/safari-608-branch/JSTests/stress/regexp-unicode-within-string.js
branches/safari-608-branch/Source/_javascript_Core/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/yarr/YarrJIT.cpp
branches/safari-608-branch/Source/_javascript_Core/yarr/YarrPattern.h


Added Paths

branches/safari-608-branch/JSTests/stress/regexp-unicode-surrogate-pair-increment-should-involve-length-check.js




Diff

Modified: branches/safari-608-branch/JSTests/ChangeLog (250507 => 250508)

--- branches/safari-608-branch/JSTests/ChangeLog	2019-09-30 08:30:45 UTC (rev 250507)
+++ branches/safari-608-branch/JSTests/ChangeLog	2019-09-30 08:30:48 UTC (rev 250508)
@@ -1,5 +1,56 @@
 2019-09-30  Babak Shafiei  
 
+Cherry-pick r249926. rdar://problem/55826870
+
+[JSC] Perform check again when we found non-BMP characters
+https://bugs.webkit.org/show_bug.cgi?id=201647
+
+Reviewed by Yusuke Suzuki.
+
+JSTests:
+
+* stress/regexp-unicode-surrogate-pair-increment-should-involve-length-check.js: Added.
+* stress/regexp-unicode-within-string.js: Updated test to eliminate the bogus print().
+(testRegExpInbounds):
+
+Source/_javascript_Core:
+
+We need to check for end of input for non-BMP characters when matching a character class that contains
+both BMP and non-BMP characters.  In advanceIndexAfterCharacterClassTermMatch() we were checking for
+end of input for both BMP and non-BMP characters.  For BMP characters, this check is redundant.
+After moving the check to after the "is BMP check", we need to decrement index after reaching the failure
+label to back out the index++ for the first surrogate of the non-BMP character.
+
+Added the same kind of check in generateCharacterClassOnce().  In that case, we have pre-checked the
+first character (surrogate) for a non-BMP codepoint, so we just need to check for end of input before
+we increment for the second surrogate.
+
+While writing tests, I found an off by one error in backtrackCharacterClassGreedy() and changed the
+loop to check the count at loop top instead of loop bottom.
+
+* yarr/YarrJIT.cpp:
+(JSC::Yarr::YarrGenerator::advanceIndexAfterCharacterClassTermMatch):
+(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
+(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
+(JSC::Yarr::YarrGenerator::backtrackCharacterClassGreedy):
+(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-09-16  Michael Saboff  
+
+[JSC] Perform check again when we found non-BMP characters
+https://bugs.webkit.org/show_bug.cgi?id=201647
+
+Reviewed by Yusuke Suzuki.
+
+* stress/regexp-unicode-surrogate-pair-increment-should-involve-length-check.js: Added.
+  

[webkit-changes] [250506] branches/safari-608-branch/Source/WebCore

[bshafiei]

Title: [250506] branches/safari-608-branch/Source/WebCore








Revision 250506
Author bshaf...@apple.com
Date 2019-09-30 01:30:43 -0700 (Mon, 30 Sep 2019)


Log Message
Cherry-pick r249077. rdar://problem/55826882

Crash under TimerBase::setNextFireTime() in the NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=201097


Reviewed by Ryosuke Niwa.

NetworkStateNotifier is a WebCore/platform class used by both WebKitLegacy and WebKit2 in the NetworkProcess.
On iOS, the lambda in the implementation of NetworkStateNotifier::startObserving() may get called by the
underlying framework on a non-main thread and we therefore want to go back to the main thread before calling
NetworkStateNotifier::singleton().updateStateSoon(). This is important because updateStateSoon() will schedule
a WebCore::Timer. The issue is that the code was using WebThreadRun() to go back the the main thread. While
this works fine in iOS WK1, it does not do what we want in WebKit2 in the network process. Indeed, before there
is no WebThread in the network process, WebThreadRun() will simply run the block on whatever thread we're one.
This would lead to crashes when trying to schedule the Timer in updateStateSoon(). To address the issue, we now
use callOnMainThread().

* platform/network/ios/NetworkStateNotifierIOS.mm:
(WebCore::NetworkStateNotifier::startObserving):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/platform/network/ios/NetworkStateNotifierIOS.mm




Diff

Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (250505 => 250506)

--- branches/safari-608-branch/Source/WebCore/ChangeLog	2019-09-30 08:30:40 UTC (rev 250505)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2019-09-30 08:30:43 UTC (rev 250506)
@@ -1,5 +1,52 @@
 2019-09-30  Babak Shafiei  
 
+Cherry-pick r249077. rdar://problem/55826882
+
+Crash under TimerBase::setNextFireTime() in the NetworkProcess
+https://bugs.webkit.org/show_bug.cgi?id=201097
+
+
+Reviewed by Ryosuke Niwa.
+
+NetworkStateNotifier is a WebCore/platform class used by both WebKitLegacy and WebKit2 in the NetworkProcess.
+On iOS, the lambda in the implementation of NetworkStateNotifier::startObserving() may get called by the
+underlying framework on a non-main thread and we therefore want to go back to the main thread before calling
+NetworkStateNotifier::singleton().updateStateSoon(). This is important because updateStateSoon() will schedule
+a WebCore::Timer. The issue is that the code was using WebThreadRun() to go back the the main thread. While
+this works fine in iOS WK1, it does not do what we want in WebKit2 in the network process. Indeed, before there
+is no WebThread in the network process, WebThreadRun() will simply run the block on whatever thread we're one.
+This would lead to crashes when trying to schedule the Timer in updateStateSoon(). To address the issue, we now
+use callOnMainThread().
+
+* platform/network/ios/NetworkStateNotifierIOS.mm:
+(WebCore::NetworkStateNotifier::startObserving):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-08-23  Chris Dumez  
+
+Crash under TimerBase::setNextFireTime() in the NetworkProcess
+https://bugs.webkit.org/show_bug.cgi?id=201097
+
+
+Reviewed by Ryosuke Niwa.
+
+NetworkStateNotifier is a WebCore/platform class used by both WebKitLegacy and WebKit2 in the NetworkProcess.
+On iOS, the lambda in the implementation of NetworkStateNotifier::startObserving() may get called by the
+underlying framework on a non-main thread and we therefore want to go back to the main thread before calling
+NetworkStateNotifier::singleton().updateStateSoon(). This is important because updateStateSoon() will schedule
+a WebCore::Timer. The issue is that the code was using WebThreadRun() to go back the the main thread. While
+this works fine in iOS WK1, it does not do what we want in WebKit2 in the network process. Indeed, before there
+is no WebThread in the network process, WebThreadRun() will simply run the block on whatever thread we're one.
+This would lead to crashes when trying to schedule the Timer in updateStateSoon(). To address the issue, we now
+use callOnMainThread().
+
+* platform/network/ios/NetworkStateNotifierIOS.mm:
+(WebCore::NetworkStateNotifier::startObserving):
+
+2019-09-30  Babak Shafiei  
+
 Cherry-pick r248591. rdar://problem/55826878
 
 FrameLoader::open can execute scritps via style recalc in Frame::setDocument


Modified: 

[webkit-changes] [250511] branches/safari-608-branch/Source/WebKit

[bshafiei]

Title: [250511] branches/safari-608-branch/Source/WebKit








Revision 250511
Author bshaf...@apple.com
Date 2019-09-30 01:30:55 -0700 (Mon, 30 Sep 2019)


Log Message
Cherry-pick r250394. rdar://problem/55826250

Crash under WebPage::beginPrinting when m_printContext becomes null due to synchronous layout
https://bugs.webkit.org/show_bug.cgi?id=202171


Reviewed by Tim Horton.

Speculatively fix a null pointer dereference crash in WebPage::beginPrinting.

WebPage::beginPrinting creates a PrintContext, stores it in m_printContext, then calls
PrintContext::begin which forces a synchronous, paginated layout. If a post-layout task
executes script, that might result in the WebPage being closed and m_printContext being set
to nullptr.

Guard against this in WebPage::beginPrinting by adding a null check before calling
PrintContext::computePageRects.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::beginPrinting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp




Diff

Modified: branches/safari-608-branch/Source/WebKit/ChangeLog (250510 => 250511)

--- branches/safari-608-branch/Source/WebKit/ChangeLog	2019-09-30 08:30:53 UTC (rev 250510)
+++ branches/safari-608-branch/Source/WebKit/ChangeLog	2019-09-30 08:30:55 UTC (rev 250511)
@@ -1,3 +1,50 @@
+2019-09-30  Babak Shafiei  
+
+Cherry-pick r250394. rdar://problem/55826250
+
+Crash under WebPage::beginPrinting when m_printContext becomes null due to synchronous layout
+https://bugs.webkit.org/show_bug.cgi?id=202171
+
+
+Reviewed by Tim Horton.
+
+Speculatively fix a null pointer dereference crash in WebPage::beginPrinting.
+
+WebPage::beginPrinting creates a PrintContext, stores it in m_printContext, then calls
+PrintContext::begin which forces a synchronous, paginated layout. If a post-layout task
+executes script, that might result in the WebPage being closed and m_printContext being set
+to nullptr.
+
+Guard against this in WebPage::beginPrinting by adding a null check before calling
+PrintContext::computePageRects.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::beginPrinting):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-09-26  Andy Estes  
+
+Crash under WebPage::beginPrinting when m_printContext becomes null due to synchronous layout
+https://bugs.webkit.org/show_bug.cgi?id=202171
+
+
+Reviewed by Tim Horton.
+
+Speculatively fix a null pointer dereference crash in WebPage::beginPrinting.
+
+WebPage::beginPrinting creates a PrintContext, stores it in m_printContext, then calls
+PrintContext::begin which forces a synchronous, paginated layout. If a post-layout task
+executes script, that might result in the WebPage being closed and m_printContext being set
+to nullptr.
+
+Guard against this in WebPage::beginPrinting by adding a null check before calling
+PrintContext::computePageRects.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::beginPrinting):
+
 2019-09-29  Alan Coon  
 
 Cherry-pick r250345. rdar://problem/55825352


Modified: branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp (250510 => 250511)

--- branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2019-09-30 08:30:53 UTC (rev 250510)
+++ branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2019-09-30 08:30:55 UTC (rev 250511)
@@ -4705,6 +4705,14 @@
 auto computedPageSize = m_printContext->computedPageSize(FloatSize(printInfo.availablePaperWidth, printInfo.availablePaperHeight), printInfo.margin);
 m_printContext->begin(computedPageSize.width(), computedPageSize.height());
 
+// PrintContext::begin() performed a synchronous layout which might have executed a
+// script that closed the WebPage, clearing m_printContext.
+// See  for cases of this happening.
+if (!m_printContext) {
+unfreezeLayerTree(LayerTreeFreezeReason::Printing);
+return;
+}
+
 float fullPageHeight;
 m_printContext->computePageRects(FloatRect(0, 0, computedPageSize.width(), computedPageSize.height()), 0, 0, printInfo.pageSetupScaleFactor, fullPageHeight, true);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250502] branches/safari-608-branch/Source/WebCore

[bshafiei]

Title: [250502] branches/safari-608-branch/Source/WebCore








Revision 250502
Author bshaf...@apple.com
Date 2019-09-30 01:30:31 -0700 (Mon, 30 Sep 2019)


Log Message
Cherry-pick r248173. rdar://problem/55826879

Harden NodeRareData::m_connectedFrameCount
https://bugs.webkit.org/show_bug.cgi?id=200300

Reviewed by Geoffrey Garen.

Use unsinged integer type in NodeRareData::m_connectedFrameCount since it's padded anyway.

* dom/Node.cpp:
(WebCore::Node::decrementConnectedSubframeCount): Check that hasRareNode() is true in release builds.
* dom/NodeRareData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/dom/Node.cpp
branches/safari-608-branch/Source/WebCore/dom/NodeRareData.h




Diff

Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (250501 => 250502)

--- branches/safari-608-branch/Source/WebCore/ChangeLog	2019-09-30 08:30:28 UTC (rev 250501)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2019-09-30 08:30:31 UTC (rev 250502)
@@ -1,5 +1,36 @@
 2019-09-30  Babak Shafiei  
 
+Cherry-pick r248173. rdar://problem/55826879
+
+Harden NodeRareData::m_connectedFrameCount
+https://bugs.webkit.org/show_bug.cgi?id=200300
+
+Reviewed by Geoffrey Garen.
+
+Use unsinged integer type in NodeRareData::m_connectedFrameCount since it's padded anyway.
+
+* dom/Node.cpp:
+(WebCore::Node::decrementConnectedSubframeCount): Check that hasRareNode() is true in release builds.
+* dom/NodeRareData.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-08-02  Ryosuke Niwa  
+
+Harden NodeRareData::m_connectedFrameCount
+https://bugs.webkit.org/show_bug.cgi?id=200300
+
+Reviewed by Geoffrey Garen.
+
+Use unsinged integer type in NodeRareData::m_connectedFrameCount since it's padded anyway.
+
+* dom/Node.cpp:
+(WebCore::Node::decrementConnectedSubframeCount): Check that hasRareNode() is true in release builds.
+* dom/NodeRareData.h:
+
+2019-09-30  Babak Shafiei  
+
 Cherry-pick r248172. rdar://problem/55826873
 
 Document::resume should delay resetting of form control elements.


Modified: branches/safari-608-branch/Source/WebCore/dom/Node.cpp (250501 => 250502)

--- branches/safari-608-branch/Source/WebCore/dom/Node.cpp	2019-09-30 08:30:28 UTC (rev 250501)
+++ branches/safari-608-branch/Source/WebCore/dom/Node.cpp	2019-09-30 08:30:31 UTC (rev 250502)
@@ -2554,6 +2554,9 @@
 
 void Node::decrementConnectedSubframeCount(unsigned amount)
 {
+ASSERT(rareData());
+if (!hasRareData())
+return; // Defend against type confusion when the above assertion fails. See webkit.org/b/200300.
 rareData()->decrementConnectedSubframeCount(amount);
 }
 


Modified: branches/safari-608-branch/Source/WebCore/dom/NodeRareData.h (250501 => 250502)

--- branches/safari-608-branch/Source/WebCore/dom/NodeRareData.h	2019-09-30 08:30:28 UTC (rev 250501)
+++ branches/safari-608-branch/Source/WebCore/dom/NodeRareData.h	2019-09-30 08:30:31 UTC (rev 250502)
@@ -29,6 +29,7 @@
 #include "QualifiedName.h"
 #include "TagCollection.h"
 #include 
+#include 
 #include 
 
 namespace WebCore {
@@ -319,7 +320,7 @@
 #endif
 
 private:
-unsigned m_connectedFrameCount : 10; // Must fit Page::maxNumberOfFrames.
+unsigned m_connectedFrameCount; // Must fit Page::maxNumberOfFrames.
 
 std::unique_ptr m_nodeLists;
 std::unique_ptr m_mutationObserverData;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250510] branches/safari-608-branch

[bshafiei]

Title: [250510] branches/safari-608-branch








Revision 250510
Author bshaf...@apple.com
Date 2019-09-30 01:30:53 -0700 (Mon, 30 Sep 2019)


Log Message
Cherry-pick r250058. rdar://problem/55826329

Phantom insertion phase may disagree with arguments forwarding about live ranges
https://bugs.webkit.org/show_bug.cgi?id=200715


Reviewed by Yusuke Suzuki.

JSTests:

* stress/phantom-insertion-live-range-should-agree-with-arguments-forwarding.js: Added.
(main.v23):
(main.try.v43):
(main.):
(main):

Source/_javascript_Core:

The issue is that Phantom insertion phase was disagreeing about live ranges
from the arguments forwarding phase. The effect is that Phantom insertion
would insert a Phantom creating a longer live range than what arguments
forwarding was analyzing. Arguments forwarding will look for the last DFG
use or the last bytecode use of a variable it wants to eliminate. It then
does an interference analysis to ensure that nothing clobbers other variables
it needs to recover the sunken allocation during OSR exit.

Phantom insertion works by ordering the program into OSR exit epochs. If a value was used
in the current epoch, there is no need to insert a phantom for it. We
determine where we might need a Phantom by looking at bytecode kills. In this
analysis, we have a mapping from bytecode local to DFG node. However, we
sometimes forgot to remove the entry when a local is killed. So, if the first
kill of a variable is in the same OSR exit epoch, we won't insert a Phantom by design.
However, if the variable gets killed again, we might errantly insert a Phantom
for the prior variable which should've already been killed. The solution is to
clear the entry in our mapping when a variable is killed.

The program in question was like this:

1: DirectArguments
...
2: MovHint(@1, loc1) // arguments forwarding treats this as the final kill for @1
...
clobber things needed for recovery
...

Arguments elimination would transform the program since between @1 and
@2, nothing clobbers values needed for exit and nothing escapes @1. The
program becomes:

1: PhantomDirectArguments
...
2: MovHint(@1, loc1) // arguments forwarding treats this as the final kill for @1
...
clobber things needed for recovery of @1
...

Phantom insertion would then transform the program into:

1: PhantomDirectArguments
...
2: MovHint(@1, loc1) // arguments forwarding treats this as the final kill for @1
...
clobber things needed for recovery of @1
...
3: Phantom(@1)
...

This is wrong because Phantom insertion and arguments forwarding must agree on live
ranges, otherwise the interference analysis performed by arguments forwarding will
not correctly analyze up until where the value might be recovered.

* dfg/DFGPhantomInsertionPhase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/JSTests/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/dfg/DFGPhantomInsertionPhase.cpp


Added Paths

branches/safari-608-branch/JSTests/stress/phantom-insertion-live-range-should-agree-with-arguments-forwarding.js




Diff

Modified: branches/safari-608-branch/JSTests/ChangeLog (250509 => 250510)

--- branches/safari-608-branch/JSTests/ChangeLog	2019-09-30 08:30:51 UTC (rev 250509)
+++ branches/safari-608-branch/JSTests/ChangeLog	2019-09-30 08:30:53 UTC (rev 250510)
@@ -1,5 +1,98 @@
 2019-09-30  Babak Shafiei  
 
+Cherry-pick r250058. rdar://problem/55826329
+
+Phantom insertion phase may disagree with arguments forwarding about live ranges
+https://bugs.webkit.org/show_bug.cgi?id=200715
+
+
+Reviewed by Yusuke Suzuki.
+
+JSTests:
+
+* stress/phantom-insertion-live-range-should-agree-with-arguments-forwarding.js: Added.
+(main.v23):
+(main.try.v43):
+(main.):
+(main):
+
+Source/_javascript_Core:
+
+The issue is that Phantom insertion phase was disagreeing about live ranges
+from the arguments forwarding phase. The effect is that Phantom insertion
+would insert a Phantom creating a longer live range than what arguments
+forwarding was analyzing. Arguments forwarding will look for the last DFG
+use or the last bytecode use of a variable it wants to eliminate. It then
+does an interference analysis to ensure that nothing clobbers other variables
+it needs to recover the sunken allocation during OSR exit.
+
+Phantom insertion works by ordering the program into OSR exit epochs. If a value was used
+in the current epoch, there is no need to insert a phantom for it. We
+determine where we might need a Phantom by looking at bytecode kills. In this

[webkit-changes] [250505] branches/safari-608-branch

[bshafiei]

Title: [250505] branches/safari-608-branch








Revision 250505
Author bshaf...@apple.com
Date 2019-09-30 01:30:40 -0700 (Mon, 30 Sep 2019)


Log Message
Cherry-pick r248951. rdar://problem/55826863

[JSC] incorrent JIT lead to StackOverflow
https://bugs.webkit.org/show_bug.cgi?id=197823

Reviewed by Tadeu Zagallo.

JSTests:

New test.

* stress/bound-function-stack-overflow.js: Added.
(foo):
(catch):

Source/_javascript_Core:

Added stack overflow check to the bound function thunk generator.  Added a new C++ operation
throwStackOverflowErrorFromThunk() to throw the error.

* jit/JITOperations.cpp:
* jit/JITOperations.h:
* jit/ThunkGenerators.cpp:
(JSC::boundThisNoArgsFunctionCallGenerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/JSTests/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/jit/JITOperations.cpp
branches/safari-608-branch/Source/_javascript_Core/jit/JITOperations.h
branches/safari-608-branch/Source/_javascript_Core/jit/ThunkGenerators.cpp


Added Paths

branches/safari-608-branch/JSTests/stress/bound-function-stack-overflow.js




Diff

Modified: branches/safari-608-branch/JSTests/ChangeLog (250504 => 250505)

--- branches/safari-608-branch/JSTests/ChangeLog	2019-09-30 08:30:37 UTC (rev 250504)
+++ branches/safari-608-branch/JSTests/ChangeLog	2019-09-30 08:30:40 UTC (rev 250505)
@@ -1,5 +1,48 @@
 2019-09-30  Babak Shafiei  
 
+Cherry-pick r248951. rdar://problem/55826863
+
+[JSC] incorrent JIT lead to StackOverflow
+https://bugs.webkit.org/show_bug.cgi?id=197823
+
+Reviewed by Tadeu Zagallo.
+
+JSTests:
+
+New test.
+
+* stress/bound-function-stack-overflow.js: Added.
+(foo):
+(catch):
+
+Source/_javascript_Core:
+
+Added stack overflow check to the bound function thunk generator.  Added a new C++ operation
+throwStackOverflowErrorFromThunk() to throw the error.
+
+* jit/JITOperations.cpp:
+* jit/JITOperations.h:
+* jit/ThunkGenerators.cpp:
+(JSC::boundThisNoArgsFunctionCallGenerator):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-08-21  Michael Saboff  
+
+[JSC] incorrent JIT lead to StackOverflow
+https://bugs.webkit.org/show_bug.cgi?id=197823
+
+Reviewed by Tadeu Zagallo.
+
+New test.
+
+* stress/bound-function-stack-overflow.js: Added.
+(foo):
+(catch):
+
+2019-09-30  Babak Shafiei  
+
 Cherry-pick r248796. rdar://problem/55826874
 
 [Re-land] ProxyObject should not be allow to access its target's private properties.


Added: branches/safari-608-branch/JSTests/stress/bound-function-stack-overflow.js (0 => 250505)

--- branches/safari-608-branch/JSTests/stress/bound-function-stack-overflow.js	(rev 0)
+++ branches/safari-608-branch/JSTests/stress/bound-function-stack-overflow.js	2019-09-30 08:30:40 UTC (rev 250505)
@@ -0,0 +1,34 @@
+// This test verifies that we check for out of stack errors from recursively bound functions.
+// It should exit without any output.
+
+let expectedException = "RangeError: Maximum call stack size exceeded.";
+let actualException = false;
+
+function foo()
+{
+}
+
+for (var i = 0; i < 5000; ++i) {
+foo = foo.bind(1);
+Object.defineProperty(foo, "name", { value: "bar", writable: true, enumerable: true, writable: true });
+}
+
+try {
+foo("x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", 
+"x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", 
+"x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", 
+"x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", 
+"x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", 
+"x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", 
+"x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", 
+"x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", 
+"x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", 
+"x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x", "x");
+} catch (e) {
+actualException = e;
+}
+
+if (!actualException)
+throw "Expected \"" + expectedException + "\" exception, but no exceptoion was thrown";
+else if (actualException != 

[webkit-changes] [250503] branches/safari-608-branch

[bshafiei]

Title: [250503] branches/safari-608-branch








Revision 250503
Author bshaf...@apple.com
Date 2019-09-30 01:30:35 -0700 (Mon, 30 Sep 2019)


Log Message
Cherry-pick r248591. rdar://problem/55826878

FrameLoader::open can execute scritps via style recalc in Frame::setDocument
https://bugs.webkit.org/show_bug.cgi?id=200377

Reviewed by Antti Koivisto.

Source/WebCore:

Fixed the bug that FrameLoader::open can execute arbitrary author scripts via post style update callbacks
by adding PostResolutionCallbackDisabler, WidgetHierarchyUpdatesSuspensionScope, and NavigationDisabler
to CachedFrameBase::restore and FrameLoader::open.

This ensures all frames are restored from the page cache before any of them would start running scripts.

Test: fast/frames/restoring-page-cache-should-not-run-scripts-via-style-update.html

* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::open):
* page/FrameViewLayoutContext.cpp:
(WebCore::FrameViewLayoutContext::layout): Fixed the debug assertion. The layout of a document may be
updated while we're preparing to put a page into the page cache.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers): Ditto.

LayoutTests:

Added a regression test.

* fast/frames/restoring-page-cache-should-not-run-scripts-via-style-update-expected.txt: Added.
* fast/frames/restoring-page-cache-should-not-run-scripts-via-style-update.html: Added.
* platform/win/TestExpectations: Skip the newly added test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/LayoutTests/platform/win/TestExpectations
branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/history/CachedFrame.cpp
branches/safari-608-branch/Source/WebCore/loader/FrameLoader.cpp
branches/safari-608-branch/Source/WebCore/page/FrameViewLayoutContext.cpp
branches/safari-608-branch/Source/WebCore/rendering/RenderLayerCompositor.cpp


Added Paths

branches/safari-608-branch/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts-via-style-update-expected.txt
branches/safari-608-branch/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts-via-style-update.html




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (250502 => 250503)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-09-30 08:30:31 UTC (rev 250502)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-09-30 08:30:35 UTC (rev 250503)
@@ -1,5 +1,58 @@
 2019-09-30  Babak Shafiei  
 
+Cherry-pick r248591. rdar://problem/55826878
+
+FrameLoader::open can execute scritps via style recalc in Frame::setDocument
+https://bugs.webkit.org/show_bug.cgi?id=200377
+
+Reviewed by Antti Koivisto.
+
+Source/WebCore:
+
+Fixed the bug that FrameLoader::open can execute arbitrary author scripts via post style update callbacks
+by adding PostResolutionCallbackDisabler, WidgetHierarchyUpdatesSuspensionScope, and NavigationDisabler
+to CachedFrameBase::restore and FrameLoader::open.
+
+This ensures all frames are restored from the page cache before any of them would start running scripts.
+
+Test: fast/frames/restoring-page-cache-should-not-run-scripts-via-style-update.html
+
+* history/CachedFrame.cpp:
+(WebCore::CachedFrameBase::restore):
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::open):
+* page/FrameViewLayoutContext.cpp:
+(WebCore::FrameViewLayoutContext::layout): Fixed the debug assertion. The layout of a document may be
+updated while we're preparing to put a page into the page cache.
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::updateCompositingLayers): Ditto.
+
+LayoutTests:
+
+Added a regression test.
+
+* fast/frames/restoring-page-cache-should-not-run-scripts-via-style-update-expected.txt: Added.
+* fast/frames/restoring-page-cache-should-not-run-scripts-via-style-update.html: Added.
+* platform/win/TestExpectations: Skip the newly added test.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-08-12  Ryosuke Niwa  
+
+FrameLoader::open can execute scritps via style recalc in Frame::setDocument
+https://bugs.webkit.org/show_bug.cgi?id=200377
+
+Reviewed by Antti Koivisto.
+
+Added a regression test.
+
+* fast/frames/restoring-page-cache-should-not-run-scripts-via-style-update-expected.txt: Added.
+* fast/frames/restoring-page-cache-should-not-run-scripts-via-style-update.html: Added.
+* platform/win/TestExpectations: Skip the newly 

[webkit-changes] [250504] branches/safari-608-branch

[bshafiei]

Title: [250504] branches/safari-608-branch








Revision 250504
Author bshaf...@apple.com
Date 2019-09-30 01:30:37 -0700 (Mon, 30 Sep 2019)


Log Message
Cherry-pick r248796. rdar://problem/55826874

[Re-land] ProxyObject should not be allow to access its target's private properties.
https://bugs.webkit.org/show_bug.cgi?id=200739


Reviewed by Yusuke Suzuki.

JSTests:

* stress/proxy-should-not-be-allowed-to-access-private-properties-of-target.js: Copied from JSTests/stress/proxy-should-not-be-allowed-to-access-private-properties-of-target.js.
* stress/proxy-with-private-symbols.js:

Source/_javascript_Core:

Re-landing this after r200829 which resolves the test262 failure uncovered by this patch.

* runtime/ProxyObject.cpp:
(JSC::performProxyGet):
(JSC::ProxyObject::performInternalMethodGetOwnProperty):
(JSC::ProxyObject::performHasProperty):
(JSC::ProxyObject::performPut):
(JSC::ProxyObject::performDelete):
(JSC::ProxyObject::performDefineOwnProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/JSTests/ChangeLog
branches/safari-608-branch/JSTests/stress/proxy-with-private-symbols.js
branches/safari-608-branch/Source/_javascript_Core/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/runtime/ProxyObject.cpp


Added Paths

branches/safari-608-branch/JSTests/stress/proxy-should-not-be-allowed-to-access-private-properties-of-target.js




Diff

Modified: branches/safari-608-branch/JSTests/ChangeLog (250503 => 250504)

--- branches/safari-608-branch/JSTests/ChangeLog	2019-09-30 08:30:35 UTC (rev 250503)
+++ branches/safari-608-branch/JSTests/ChangeLog	2019-09-30 08:30:37 UTC (rev 250504)
@@ -1,3 +1,45 @@
+2019-09-30  Babak Shafiei  
+
+Cherry-pick r248796. rdar://problem/55826874
+
+[Re-land] ProxyObject should not be allow to access its target's private properties.
+https://bugs.webkit.org/show_bug.cgi?id=200739
+
+
+Reviewed by Yusuke Suzuki.
+
+JSTests:
+
+* stress/proxy-should-not-be-allowed-to-access-private-properties-of-target.js: Copied from JSTests/stress/proxy-should-not-be-allowed-to-access-private-properties-of-target.js.
+* stress/proxy-with-private-symbols.js:
+
+Source/_javascript_Core:
+
+Re-landing this after r200829 which resolves the test262 failure uncovered by this patch.
+
+* runtime/ProxyObject.cpp:
+(JSC::performProxyGet):
+(JSC::ProxyObject::performInternalMethodGetOwnProperty):
+(JSC::ProxyObject::performHasProperty):
+(JSC::ProxyObject::performPut):
+(JSC::ProxyObject::performDelete):
+(JSC::ProxyObject::performDefineOwnProperty):
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-08-16  Mark Lam  
+
+[Re-land] ProxyObject should not be allow to access its target's private properties.
+https://bugs.webkit.org/show_bug.cgi?id=200739
+
+
+Reviewed by Yusuke Suzuki.
+
+* stress/proxy-should-not-be-allowed-to-access-private-properties-of-target.js: Copied from JSTests/stress/proxy-should-not-be-allowed-to-access-private-properties-of-target.js.
+* stress/proxy-with-private-symbols.js:
+
 2019-09-23  Alan Coon  
 
 Cherry-pick r250116. rdar://problem/55608003


Added: branches/safari-608-branch/JSTests/stress/proxy-should-not-be-allowed-to-access-private-properties-of-target.js (0 => 250504)

--- branches/safari-608-branch/JSTests/stress/proxy-should-not-be-allowed-to-access-private-properties-of-target.js	(rev 0)
+++ branches/safari-608-branch/JSTests/stress/proxy-should-not-be-allowed-to-access-private-properties-of-target.js	2019-09-30 08:30:37 UTC (rev 250504)
@@ -0,0 +1,21 @@
+var foo = (function* bar() {
+try {
+yield* x;
+} finally {
+try {
+y;
+} finally {
+return;
+}
+}
+}) ();
+
+var x = new Proxy(foo, {});
+try {
+x.next();
+} catch (e) {
+exception = e;
+}
+
+if (exception != 'TypeError: |this| should be a generator')
+throw "FAILED";


Modified: branches/safari-608-branch/JSTests/stress/proxy-with-private-symbols.js (250503 => 250504)

--- branches/safari-608-branch/JSTests/stress/proxy-with-private-symbols.js	2019-09-30 08:30:35 UTC (rev 250503)
+++ branches/safari-608-branch/JSTests/stress/proxy-with-private-symbols.js	2019-09-30 08:30:37 UTC (rev 250504)
@@ -81,7 +81,7 @@
 assert(e.message === "%ArrayIteratorPrototype%.next requires that |this| be an Array Iterator instance");
 threw = true;
 }
-assert(!threw);
+assert(threw);
 assert(!sawPrivateSymbolAsString);
 sawPrivateSymbolAsString = false;
 }


Modified: 

[webkit-changes] [250500] branches/safari-608-branch/Source/JavaScriptCore

[bshafiei]

Title: [250500] branches/safari-608-branch/Source/_javascript_Core








Revision 250500
Author bshaf...@apple.com
Date 2019-09-30 01:30:23 -0700 (Mon, 30 Sep 2019)


Log Message
Cherry-pick r247799. rdar://problem/55826880

performJITMemcpy should be PACed with a non-zero diversifier when passed and called via a pointer.
https://bugs.webkit.org/show_bug.cgi?id=200100


Reviewed by Yusuke Suzuki.

* assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::CopyFunction::CopyFunction):
(JSC::ARM64Assembler::CopyFunction::operator()):
- I choose to use ptrauth_auth_function() here instead of retagCodePtr() because
  retagCodePtr() would auth, assert, and re-pac the pointer.  This is needed in
  general because retagCodePtr() doesn't know that you will consume the pointer
  immediately (and therefore crash imminently if a failed auth is encountered).
  Since we know here that we will call with the auth'ed pointer immediately, we
  can skip the assert.

  This also has the benefit of letting Clang do a peephole optimization to emit
  a blrab instruction with the intended diversifier, instead of emitting multiple
  instructions to auth the pointer into a C function, and then using a blraaz to
  do a C function call.

(JSC::ARM64Assembler::linkJumpOrCall):
(JSC::ARM64Assembler::linkCompareAndBranch):
(JSC::ARM64Assembler::linkConditionalBranch):
(JSC::ARM64Assembler::linkTestAndBranch):
* assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::copyCompactAndLinkCode):
* runtime/JSCPtrTag.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/_javascript_Core/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/assembler/ARM64Assembler.h
branches/safari-608-branch/Source/_javascript_Core/assembler/LinkBuffer.cpp
branches/safari-608-branch/Source/_javascript_Core/runtime/JSCPtrTag.h




Diff

Modified: branches/safari-608-branch/Source/_javascript_Core/ChangeLog (250499 => 250500)

--- branches/safari-608-branch/Source/_javascript_Core/ChangeLog	2019-09-30 07:55:07 UTC (rev 250499)
+++ branches/safari-608-branch/Source/_javascript_Core/ChangeLog	2019-09-30 08:30:23 UTC (rev 250500)
@@ -1,3 +1,71 @@
+2019-09-30  Babak Shafiei  
+
+Cherry-pick r247799. rdar://problem/55826880
+
+performJITMemcpy should be PACed with a non-zero diversifier when passed and called via a pointer.
+https://bugs.webkit.org/show_bug.cgi?id=200100
+
+
+Reviewed by Yusuke Suzuki.
+
+* assembler/ARM64Assembler.h:
+(JSC::ARM64Assembler::CopyFunction::CopyFunction):
+(JSC::ARM64Assembler::CopyFunction::operator()):
+- I choose to use ptrauth_auth_function() here instead of retagCodePtr() because
+  retagCodePtr() would auth, assert, and re-pac the pointer.  This is needed in
+  general because retagCodePtr() doesn't know that you will consume the pointer
+  immediately (and therefore crash imminently if a failed auth is encountered).
+  Since we know here that we will call with the auth'ed pointer immediately, we
+  can skip the assert.
+
+  This also has the benefit of letting Clang do a peephole optimization to emit
+  a blrab instruction with the intended diversifier, instead of emitting multiple
+  instructions to auth the pointer into a C function, and then using a blraaz to
+  do a C function call.
+
+(JSC::ARM64Assembler::linkJumpOrCall):
+(JSC::ARM64Assembler::linkCompareAndBranch):
+(JSC::ARM64Assembler::linkConditionalBranch):
+(JSC::ARM64Assembler::linkTestAndBranch):
+* assembler/LinkBuffer.cpp:
+(JSC::LinkBuffer::copyCompactAndLinkCode):
+* runtime/JSCPtrTag.h:
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-07-24  Mark Lam  
+
+performJITMemcpy should be PACed with a non-zero diversifier when passed and called via a pointer.
+https://bugs.webkit.org/show_bug.cgi?id=200100
+
+
+Reviewed by Yusuke Suzuki.
+
+* assembler/ARM64Assembler.h:
+(JSC::ARM64Assembler::CopyFunction::CopyFunction):
+(JSC::ARM64Assembler::CopyFunction::operator()):
+- I choose to use ptrauth_auth_function() here instead of retagCodePtr() because
+  retagCodePtr() would auth, assert, and re-pac the pointer.  This is needed in
+  general because retagCodePtr() doesn't know that you will consume the pointer
+  immediately (and therefore crash imminently if a failed auth is encountered).
+  Since we know here that we will call with the auth'ed pointer immediately, we
+  can skip the assert.
+
+  This also has the benefit of letting Clang do a peephole optimization to emit
+  a blrab 

[webkit-changes] [250507] branches/safari-608-branch

[bshafiei]

Title: [250507] branches/safari-608-branch








Revision 250507
Author bshaf...@apple.com
Date 2019-09-30 01:30:45 -0700 (Mon, 30 Sep 2019)


Log Message
Cherry-pick r249777. rdar://problem/55826876

JSC crashes due to stack overflow while building RegExp
https://bugs.webkit.org/show_bug.cgi?id=201649

Reviewed by Yusuke Suzuki.

JSTests:

New regression test.

* stress/regexp-bol-optimize-out-of-stack.js: Added.
(test):
(catch):

Source/_javascript_Core:

Check for running out of stack when we are optimizing RegExp containing BOL terms or
other deep copying of disjunctions.

* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::copyDisjunction):
(JSC::Yarr::YarrPatternConstructor::copyTerm):
(JSC::Yarr::YarrPatternConstructor::error):
(JSC::Yarr::YarrPattern::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/JSTests/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/ChangeLog
branches/safari-608-branch/Source/_javascript_Core/yarr/YarrPattern.cpp


Added Paths

branches/safari-608-branch/JSTests/stress/regexp-bol-optimize-out-of-stack.js




Diff

Modified: branches/safari-608-branch/JSTests/ChangeLog (250506 => 250507)

--- branches/safari-608-branch/JSTests/ChangeLog	2019-09-30 08:30:43 UTC (rev 250506)
+++ branches/safari-608-branch/JSTests/ChangeLog	2019-09-30 08:30:45 UTC (rev 250507)
@@ -1,5 +1,49 @@
 2019-09-30  Babak Shafiei  
 
+Cherry-pick r249777. rdar://problem/55826876
+
+JSC crashes due to stack overflow while building RegExp
+https://bugs.webkit.org/show_bug.cgi?id=201649
+
+Reviewed by Yusuke Suzuki.
+
+JSTests:
+
+New regression test.
+
+* stress/regexp-bol-optimize-out-of-stack.js: Added.
+(test):
+(catch):
+
+Source/_javascript_Core:
+
+Check for running out of stack when we are optimizing RegExp containing BOL terms or
+other deep copying of disjunctions.
+
+* yarr/YarrPattern.cpp:
+(JSC::Yarr::YarrPatternConstructor::copyDisjunction):
+(JSC::Yarr::YarrPatternConstructor::copyTerm):
+(JSC::Yarr::YarrPatternConstructor::error):
+(JSC::Yarr::YarrPattern::compile):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-09-10  Michael Saboff  
+
+JSC crashes due to stack overflow while building RegExp
+https://bugs.webkit.org/show_bug.cgi?id=201649
+
+Reviewed by Yusuke Suzuki.
+
+New regression test.
+
+* stress/regexp-bol-optimize-out-of-stack.js: Added.
+(test):
+(catch):
+
+2019-09-30  Babak Shafiei  
+
 Cherry-pick r248951. rdar://problem/55826863
 
 [JSC] incorrent JIT lead to StackOverflow


Added: branches/safari-608-branch/JSTests/stress/regexp-bol-optimize-out-of-stack.js (0 => 250507)

--- branches/safari-608-branch/JSTests/stress/regexp-bol-optimize-out-of-stack.js	(rev 0)
+++ branches/safari-608-branch/JSTests/stress/regexp-bol-optimize-out-of-stack.js	2019-09-30 08:30:45 UTC (rev 250507)
@@ -0,0 +1,16 @@
+// This test that the beginning of line (bol) optimization throws when we run out of stack space.
+
+let expectedException = "SyntaxError: Invalid regular _expression_: regular _expression_ too large";
+
+function test()
+{
+let source = Array(5).join("(") + /(?:^|:|,)(?:\s*\[)+/g.toString() + Array(5).join(")");
+RegExp(source);
+}
+
+try {
+test();
+} catch(e) {
+if (e != expectedException)
+   throw "Expected \"" + expectedException + "\" exception, but got \"" + e + "\"";
+}


Modified: branches/safari-608-branch/Source/_javascript_Core/ChangeLog (250506 => 250507)

--- branches/safari-608-branch/Source/_javascript_Core/ChangeLog	2019-09-30 08:30:43 UTC (rev 250506)
+++ branches/safari-608-branch/Source/_javascript_Core/ChangeLog	2019-09-30 08:30:45 UTC (rev 250507)
@@ -1,5 +1,52 @@
 2019-09-30  Babak Shafiei  
 
+Cherry-pick r249777. rdar://problem/55826876
+
+JSC crashes due to stack overflow while building RegExp
+https://bugs.webkit.org/show_bug.cgi?id=201649
+
+Reviewed by Yusuke Suzuki.
+
+JSTests:
+
+New regression test.
+
+* stress/regexp-bol-optimize-out-of-stack.js: Added.
+(test):
+(catch):
+
+Source/_javascript_Core:
+
+Check for running out of stack when we are optimizing RegExp containing BOL terms or
+other deep copying of disjunctions.
+
+* yarr/YarrPattern.cpp:
+(JSC::Yarr::YarrPatternConstructor::copyDisjunction):
+(JSC::Yarr::YarrPatternConstructor::copyTerm):
+(JSC::Yarr::YarrPatternConstructor::error):
+(JSC::Yarr::YarrPattern::compile):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249777 

[webkit-changes] [250501] branches/safari-608-branch

[bshafiei]

Title: [250501] branches/safari-608-branch








Revision 250501
Author bshaf...@apple.com
Date 2019-09-30 01:30:28 -0700 (Mon, 30 Sep 2019)


Log Message
Cherry-pick r248172. rdar://problem/55826873

Document::resume should delay resetting of form control elements.
https://bugs.webkit.org/show_bug.cgi?id=200376

Reviewed by Geoffrey Garen.

Source/WebCore:

Delay the execution of form control element resets until the next task
to avoid synchronously mutating DOM during page cache restoration.

Test: fast/frames/restoring-page-cache-should-not-run-scripts.html

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::resumeFromDocumentSuspension):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::resumeFromDocumentSuspension):

LayoutTests:

Added a regression test.

* fast/frames/restoring-page-cache-should-not-run-scripts-expected.txt: Added.
* fast/frames/restoring-page-cache-should-not-run-scripts.html: Added.
* platform/win/TestExpectations: Skip this test on Windows since navigating to blob fails on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/LayoutTests/platform/win/TestExpectations
branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/html/HTMLFormElement.cpp
branches/safari-608-branch/Source/WebCore/html/HTMLInputElement.cpp


Added Paths

branches/safari-608-branch/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts-expected.txt
branches/safari-608-branch/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts.html




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (250500 => 250501)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-09-30 08:30:23 UTC (rev 250500)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-09-30 08:30:28 UTC (rev 250501)
@@ -1,3 +1,48 @@
+2019-09-30  Babak Shafiei  
+
+Cherry-pick r248172. rdar://problem/55826873
+
+Document::resume should delay resetting of form control elements.
+https://bugs.webkit.org/show_bug.cgi?id=200376
+
+Reviewed by Geoffrey Garen.
+
+Source/WebCore:
+
+Delay the execution of form control element resets until the next task
+to avoid synchronously mutating DOM during page cache restoration.
+
+Test: fast/frames/restoring-page-cache-should-not-run-scripts.html
+
+* html/HTMLFormElement.cpp:
+(WebCore::HTMLFormElement::resumeFromDocumentSuspension):
+* html/HTMLInputElement.cpp:
+(WebCore::HTMLInputElement::resumeFromDocumentSuspension):
+
+LayoutTests:
+
+Added a regression test.
+
+* fast/frames/restoring-page-cache-should-not-run-scripts-expected.txt: Added.
+* fast/frames/restoring-page-cache-should-not-run-scripts.html: Added.
+* platform/win/TestExpectations: Skip this test on Windows since navigating to blob fails on Windows.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-08-02  Ryosuke Niwa  
+
+Document::resume should delay resetting of form control elements.
+https://bugs.webkit.org/show_bug.cgi?id=200376
+
+Reviewed by Geoffrey Garen.
+
+Added a regression test.
+
+* fast/frames/restoring-page-cache-should-not-run-scripts-expected.txt: Added.
+* fast/frames/restoring-page-cache-should-not-run-scripts.html: Added.
+* platform/win/TestExpectations: Skip this test on Windows since navigating to blob fails on Windows.
+
 2019-09-29  Alan Coon  
 
 Cherry-pick r249893. rdar://problem/55825342


Added: branches/safari-608-branch/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts-expected.txt (0 => 250501)

--- branches/safari-608-branch/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts-expected.txt	(rev 0)
+++ branches/safari-608-branch/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts-expected.txt	2019-09-30 08:30:28 UTC (rev 250501)
@@ -0,0 +1,3 @@
+This tests that pageshow event is fired before the focus elements are reset when a document in the page cache is restored.
+
+PASS


Added: branches/safari-608-branch/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts.html (0 => 250501)

--- branches/safari-608-branch/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts.html	(rev 0)
+++ branches/safari-608-branch/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts.html	2019-09-30 08:30:28 UTC (rev 250501)
@@ -0,0 +1,73 @@
+
+
+
+This tests that pageshow event is fired before the focus elements are reset when a document in the page cache is restored.
+
+
+
+if (window.testRunner) {
+

[webkit-changes] [250499] branches/safari-608-branch/Source/WebCore

[bshafiei]

Title: [250499] branches/safari-608-branch/Source/WebCore








Revision 250499
Author bshaf...@apple.com
Date 2019-09-30 00:55:07 -0700 (Mon, 30 Sep 2019)


Log Message
Revert r250483. rdar://problem/55825351

Modified Paths

branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/loader/cache/CachedResourceLoader.cpp
branches/safari-608-branch/Source/WebCore/platform/network/HTTPHeaderNames.in




Diff

Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (250498 => 250499)

--- branches/safari-608-branch/Source/WebCore/ChangeLog	2019-09-30 05:15:40 UTC (rev 250498)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2019-09-30 07:55:07 UTC (rev 250499)
@@ -1,3 +1,7 @@
+2019-09-30  Babak Shafiei  
+
+Revert r250483. rdar://problem/55825351
+
 2019-09-29  Alan Coon  
 
 Cherry-pick r250483. rdar://problem/55825351


Modified: branches/safari-608-branch/Source/WebCore/loader/cache/CachedResourceLoader.cpp (250498 => 250499)

--- branches/safari-608-branch/Source/WebCore/loader/cache/CachedResourceLoader.cpp	2019-09-30 05:15:40 UTC (rev 250498)
+++ branches/safari-608-branch/Source/WebCore/loader/cache/CachedResourceLoader.cpp	2019-09-30 07:55:07 UTC (rev 250499)
@@ -87,10 +87,6 @@
 #include "CachedTextTrack.h"
 #endif
 
-#if PLATFORM(IOS_FAMILY)
-#include "Device.h"
-#endif
-
 #undef RELEASE_LOG_IF_ALLOWED
 #define RELEASE_LOG_IF_ALLOWED(fmt, ...) RELEASE_LOG_IF(isAlwaysOnLoggingAllowed(), Network, "%p - CachedResourceLoader::" fmt, this, ##__VA_ARGS__)
 
@@ -871,18 +867,6 @@
 }
 }
 
-// FIXME: This is temporary for .
-#if PLATFORM(IOS) && !PLATFORM(IOSMAC)
-if (!page.sessionID().isEphemeral() && deviceHasIPadCapability() && request.resourceRequest().url().protocolIs("https")) {
-RegistrableDomain registrableDomain(request.resourceRequest().url());
-if (registrableDomain.string().startsWith("google.")) {
-auto host = request.resourceRequest().url().host();
-if (host.startsWithIgnoringASCIICase("google.") || host.startsWithIgnoringASCIICase("www.google.") || host.startsWithIgnoringASCIICase("images.google."))
-request.resourceRequest().setHTTPHeaderField(HTTPHeaderName::XTempTablet, "1"_s);
-}
-}
-#endif
-
 LoadTiming loadTiming;
 loadTiming.markStartTimeAndFetchStart();
 InitiatorContext initiatorContext = request.options().initiatorContext;


Modified: branches/safari-608-branch/Source/WebCore/platform/network/HTTPHeaderNames.in (250498 => 250499)

--- branches/safari-608-branch/Source/WebCore/platform/network/HTTPHeaderNames.in	2019-09-30 05:15:40 UTC (rev 250498)
+++ branches/safari-608-branch/Source/WebCore/platform/network/HTTPHeaderNames.in	2019-09-30 07:55:07 UTC (rev 250499)
@@ -104,7 +104,6 @@
 X-WebKit-CSP
 X-WebKit-CSP-Report-Only
 X-XSS-Protection
-X-Temp-Tablet
 
 // These headers are specific to GStreamer.
 Icy-MetaInt






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [250493] branches/safari-608-branch

[bshafiei]

Title: [250493] branches/safari-608-branch








Revision 250493
Author bshaf...@apple.com
Date 2019-09-29 16:50:52 -0700 (Sun, 29 Sep 2019)


Log Message
Apply patch. rdar://problem/55801087

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/LayoutTests/http/tests/blink/sendbeacon/beacon-cross-origin-expected.txt
branches/safari-608-branch/LayoutTests/http/tests/navigation/ping-attribute/anchor-cross-origin.html
branches/safari-608-branch/LayoutTests/http/tests/navigation/ping-attribute/area-cross-origin.html
branches/safari-608-branch/LayoutTests/http/tests/referrer-policy/no-referrer-when-downgrade/cross-origin-http-http.html
branches/safari-608-branch/LayoutTests/http/tests/referrer-policy/no-referrer-when-downgrade/cross-origin-http.https.html
branches/safari-608-branch/LayoutTests/http/tests/referrer-policy/no-referrer-when-downgrade/same-origin.html
branches/safari-608-branch/LayoutTests/http/tests/referrer-policy/unsafe-url/cross-origin-http-http.html
branches/safari-608-branch/LayoutTests/http/tests/referrer-policy/unsafe-url/cross-origin-http.https.html
branches/safari-608-branch/LayoutTests/http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled.php
branches/safari-608-branch/LayoutTests/http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies.php
branches/safari-608-branch/LayoutTests/http/tests/security/referrer-policy-header.html
branches/safari-608-branch/LayoutTests/platform/ios/TestExpectations
branches/safari-608-branch/LayoutTests/platform/ios-wk2/TestExpectations
branches/safari-608-branch/LayoutTests/platform/mac-wk1/TestExpectations
branches/safari-608-branch/LayoutTests/platform/mac-wk2/TestExpectations
branches/safari-608-branch/LayoutTests/platform/win/TestExpectations
branches/safari-608-branch/LayoutTests/platform/wincairo/TestExpectations
branches/safari-608-branch/LayoutTests/platform/wk2/TestExpectations
branches/safari-608-branch/LayoutTests/resources/js-test.js
branches/safari-608-branch/LayoutTests/resources/testharnessreport.js
branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp
branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkProcess.h
branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkProcess.messages.in
branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkSession.cpp
branches/safari-608-branch/Source/WebKit/NetworkProcess/NetworkSession.h
branches/safari-608-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h
branches/safari-608-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
branches/safari-608-branch/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
branches/safari-608-branch/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h
branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h
branches/safari-608-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
branches/safari-608-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
branches/safari-608-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
branches/safari-608-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/TestWebKitAPI/WKWebViewConfigurationExtras.h
branches/safari-608-branch/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
branches/safari-608-branch/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
branches/safari-608-branch/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
branches/safari-608-branch/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
branches/safari-608-branch/Tools/WebKitTestRunner/TestController.cpp
branches/safari-608-branch/Tools/WebKitTestRunner/TestController.h
branches/safari-608-branch/Tools/WebKitTestRunner/TestInvocation.cpp
branches/safari-608-branch/Tools/WebKitTestRunner/TestInvocation.h


Added Paths

branches/safari-608-branch/LayoutTests/http/tests/resourceLoadStatistics/strip-referrer-to-origin-for-third-party-redirects-expected.txt
branches/safari-608-branch/LayoutTests/http/tests/resourceLoadStatistics/strip-referrer-to-origin-for-third-party-redirects.html
branches/safari-608-branch/LayoutTests/http/tests/resourceLoadStatistics/strip-referrer-to-origin-for-third-party-requests-expected.txt
branches/safari-608-branch/LayoutTests/http/tests/resourceLoadStatistics/strip-referrer-to-origin-for-third-party-requests.html


Removed Paths

branches/safari-608-branch/LayoutTests/http/tests/resourceLoadStatistics/strip-referrer-to-origin-for-prevalent-subresource-redirects-expected.txt
branches/safari-608-branch/LayoutTests/http/tests/resourceLoadStatistics/strip-referrer-to-origin-for-prevalent-subresource-redirects.html

[webkit-changes] [249606] tags/Safari-608.2.11.1.3/

[bshafiei]

Title: [249606] tags/Safari-608.2.11.1.3/








Revision 249606
Author bshaf...@apple.com
Date 2019-09-06 20:19:32 -0700 (Fri, 06 Sep 2019)


Log Message
Tag Safari-608.2.11.1.3.

Added Paths

tags/Safari-608.2.11.1.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [248935] branches/safari-608-branch/Source

[bshafiei]

Title: [248935] branches/safari-608-branch/Source








Revision 248935
Author bshaf...@apple.com
Date 2019-08-20 22:59:57 -0700 (Tue, 20 Aug 2019)


Log Message
Cherry-pick r248902. rdar://problem/54543355

Unsafe usage of CookieStorageObserver from a background thread
https://bugs.webkit.org/show_bug.cgi?id=200920

Reviewed by Alex Christensen.

Source/WebCore:

Unsafe usage of CookieStorageObserver from a background thread. CookieStorageObserver gets
constructed / destructed on the main thread. However, CookieStorageObserver::cookiesDidChange()
gets called on a background thread and tries to ref |this|. Even though CookieStorageObserver
is ThreadSafeRefCounted, this is still unsafe because the CookieStorageObserver destructor may
already be running on the main thread when CookieStorageObserver::cookiesDidChange() gets called
on the background thread.

* platform/network/NetworkStorageSession.h:
* platform/network/cocoa/CookieStorageObserver.h:
* platform/network/cocoa/CookieStorageObserver.mm:
(WebCore::CookieStorageObserver::CookieStorageObserver):
(WebCore::CookieStorageObserver::cookiesDidChange):
(WebCore::CookieStorageObserver::create): Deleted.
* platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::NetworkStorageSession::cookieStorageObserver const):

Source/WebKit:

* UIProcess/API/APIHTTPCookieStore.h:
* UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm:
(API::HTTPCookieStore::startObservingChangesToDefaultUIProcessCookieStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/platform/network/NetworkStorageSession.h
branches/safari-608-branch/Source/WebCore/platform/network/cocoa/CookieStorageObserver.h
branches/safari-608-branch/Source/WebCore/platform/network/cocoa/CookieStorageObserver.mm
branches/safari-608-branch/Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm
branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/UIProcess/API/APIHTTPCookieStore.h
branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm




Diff

Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (248934 => 248935)

--- branches/safari-608-branch/Source/WebCore/ChangeLog	2019-08-21 05:59:53 UTC (rev 248934)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2019-08-21 05:59:57 UTC (rev 248935)
@@ -1,3 +1,62 @@
+2019-08-20  Babak Shafiei  
+
+Cherry-pick r248902. rdar://problem/54543355
+
+Unsafe usage of CookieStorageObserver from a background thread
+https://bugs.webkit.org/show_bug.cgi?id=200920
+
+Reviewed by Alex Christensen.
+
+Source/WebCore:
+
+Unsafe usage of CookieStorageObserver from a background thread. CookieStorageObserver gets
+constructed / destructed on the main thread. However, CookieStorageObserver::cookiesDidChange()
+gets called on a background thread and tries to ref |this|. Even though CookieStorageObserver
+is ThreadSafeRefCounted, this is still unsafe because the CookieStorageObserver destructor may
+already be running on the main thread when CookieStorageObserver::cookiesDidChange() gets called
+on the background thread.
+
+* platform/network/NetworkStorageSession.h:
+* platform/network/cocoa/CookieStorageObserver.h:
+* platform/network/cocoa/CookieStorageObserver.mm:
+(WebCore::CookieStorageObserver::CookieStorageObserver):
+(WebCore::CookieStorageObserver::cookiesDidChange):
+(WebCore::CookieStorageObserver::create): Deleted.
+* platform/network/cocoa/NetworkStorageSessionCocoa.mm:
+(WebCore::NetworkStorageSession::cookieStorageObserver const):
+
+Source/WebKit:
+
+* UIProcess/API/APIHTTPCookieStore.h:
+* UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm:
+(API::HTTPCookieStore::startObservingChangesToDefaultUIProcessCookieStore):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-08-20  Chris Dumez  
+
+Unsafe usage of CookieStorageObserver from a background thread
+https://bugs.webkit.org/show_bug.cgi?id=200920
+
+Reviewed by Alex Christensen.
+
+Unsafe usage of CookieStorageObserver from a background thread. CookieStorageObserver gets
+constructed / destructed on the main thread. However, CookieStorageObserver::cookiesDidChange()
+gets called on a background thread and tries to ref |this|. Even though CookieStorageObserver
+is ThreadSafeRefCounted, this is still unsafe because the CookieStorageObserver destructor may
+already be running on the main thread when CookieStorageObserver::cookiesDidChange() gets called
+on the 

[webkit-changes] [248937] branches/safari-608-branch/Source/WebKit

[bshafiei]

Title: [248937] branches/safari-608-branch/Source/WebKit








Revision 248937
Author bshaf...@apple.com
Date 2019-08-20 23:00:02 -0700 (Tue, 20 Aug 2019)


Log Message
Cherry-pick r248928. rdar://problem/54543351

[iOS] REGRESSION (248501): gmail.com images are still not shown on some versions of iPhone iOS13
https://bugs.webkit.org/show_bug.cgi?id=200948

Patch by Said Abou-Hallawa  on 2019-08-20
Reviewed by Tim Horton.

Apply the gmail.com quirk for all iPhone iOS versions till the gmail.com
bug is fixed.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::platformUserAgent const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: branches/safari-608-branch/Source/WebKit/ChangeLog (248936 => 248937)

--- branches/safari-608-branch/Source/WebKit/ChangeLog	2019-08-21 06:00:00 UTC (rev 248936)
+++ branches/safari-608-branch/Source/WebKit/ChangeLog	2019-08-21 06:00:02 UTC (rev 248937)
@@ -1,5 +1,36 @@
 2019-08-20  Babak Shafiei  
 
+Cherry-pick r248928. rdar://problem/54543351
+
+[iOS] REGRESSION (248501): gmail.com images are still not shown on some versions of iPhone iOS13
+https://bugs.webkit.org/show_bug.cgi?id=200948
+
+Patch by Said Abou-Hallawa  on 2019-08-20
+Reviewed by Tim Horton.
+
+Apply the gmail.com quirk for all iPhone iOS versions till the gmail.com
+bug is fixed.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::platformUserAgent const):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-08-20  Said Abou-Hallawa  
+
+[iOS] REGRESSION (248501): gmail.com images are still not shown on some versions of iPhone iOS13
+https://bugs.webkit.org/show_bug.cgi?id=200948
+
+Reviewed by Tim Horton.
+
+Apply the gmail.com quirk for all iPhone iOS versions till the gmail.com
+bug is fixed.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::platformUserAgent const):
+
+2019-08-20  Babak Shafiei  
+
 Cherry-pick r248902. rdar://problem/54543355
 
 Unsafe usage of CookieStorageObserver from a background thread


Modified: branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (248936 => 248937)

--- branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm	2019-08-21 06:00:00 UTC (rev 248936)
+++ branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm	2019-08-21 06:00:02 UTC (rev 248937)
@@ -3791,7 +3791,7 @@
 if (!document)
 return String();
 
-if (document->quirks().shouldAvoidUsingIOS13ForGmail() && osNameForUserAgent() == "iPhone OS" && systemMarketingVersionForUserAgentString() == "13_1")
+if (document->quirks().shouldAvoidUsingIOS13ForGmail() && osNameForUserAgent() == "iPhone OS")
 return standardUserAgentWithApplicationName({ }, "12_1_3");
 
 return String();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [248934] branches/safari-608-branch/Source/WebInspectorUI

[bshafiei]

Title: [248934] branches/safari-608-branch/Source/WebInspectorUI








Revision 248934
Author bshaf...@apple.com
Date 2019-08-20 22:59:53 -0700 (Tue, 20 Aug 2019)


Log Message
Cherry-pick r247867. rdar://problem/54543378

Web Inspector: AXI: Audit: Typo of "some" as "somee"
https://bugs.webkit.org/show_bug.cgi?id=200166

Patch by Greg Doolittle  on 2019-07-26
Reviewed by Devin Rousso.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Controllers/AuditManager.js:
(WI.AuditManager.prototype._addDefaultTests):
(WI.AuditManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebInspectorUI/ChangeLog
branches/safari-608-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
branches/safari-608-branch/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js




Diff

Modified: branches/safari-608-branch/Source/WebInspectorUI/ChangeLog (248933 => 248934)

--- branches/safari-608-branch/Source/WebInspectorUI/ChangeLog	2019-08-21 05:25:34 UTC (rev 248933)
+++ branches/safari-608-branch/Source/WebInspectorUI/ChangeLog	2019-08-21 05:59:53 UTC (rev 248934)
@@ -1,3 +1,32 @@
+2019-08-20  Babak Shafiei  
+
+Cherry-pick r247867. rdar://problem/54543378
+
+Web Inspector: AXI: Audit: Typo of "some" as "somee"
+https://bugs.webkit.org/show_bug.cgi?id=200166
+
+Patch by Greg Doolittle  on 2019-07-26
+Reviewed by Devin Rousso.
+
+* Localizations/en.lproj/localizedStrings.js:
+* UserInterface/Controllers/AuditManager.js:
+(WI.AuditManager.prototype._addDefaultTests):
+(WI.AuditManager):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-07-26  Greg Doolittle  
+
+Web Inspector: AXI: Audit: Typo of "some" as "somee"
+https://bugs.webkit.org/show_bug.cgi?id=200166
+
+Reviewed by Devin Rousso.
+
+* Localizations/en.lproj/localizedStrings.js:
+* UserInterface/Controllers/AuditManager.js:
+(WI.AuditManager.prototype._addDefaultTests):
+(WI.AuditManager):
+
 2019-07-15  Devin Rousso  
 
 Web Inspector: Device Settings: update Safari user agent from 12.2 to 13.0


Modified: branches/safari-608-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (248933 => 248934)

--- branches/safari-608-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2019-08-21 05:25:34 UTC (rev 248933)
+++ branches/safari-608-branch/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2019-08-21 05:59:53 UTC (rev 248934)
@@ -1110,7 +1110,7 @@
 localizedStrings["This test will pass with all of the child nodes of the  element in the accessibility tree."] = "This test will pass with all of the child nodes of the  element in the accessibility tree.";
 localizedStrings["This test will pass with data indicating whether the  element has any click event listeners."] = "This test will pass with data indicating whether the  element has any click event listeners.";
 localizedStrings["This test will pass with data indicating whether the  element has any event listeners."] = "This test will pass with data indicating whether the  element has any event listeners.";
-localizedStrings["This test will pass with somee basic information about each resource."] = "This test will pass with somee basic information about each resource.";
+localizedStrings["This test will pass with some basic information about each resource."] = "This test will pass with some basic information about each resource.";
 localizedStrings["This test will pass with the active descendant (\u0022%s\u0022) of the  element, if it exists."] = "This test will pass with the active descendant (\u0022%s\u0022) of the  element, if it exists.";
 localizedStrings["This test will pass with the contents of the main resource."] = "This test will pass with the contents of the main resource.";
 localizedStrings["This test will pass with the node that would handle mouse events for the  element, if applicable."] = "This test will pass with the node that would handle mouse events for the  element, if applicable.";


Modified: branches/safari-608-branch/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js (248933 => 248934)

--- branches/safari-608-branch/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js	2019-08-21 05:25:34 UTC (rev 248933)
+++ branches/safari-608-branch/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js	2019-08-21 05:59:53 UTC (rev 248934)
@@ -1032,7 +1032,7 @@
 new WI.AuditTestCase("hasEventListeners-click", removeWhitespace(hasEventListenersClick), {description: WI.UIString("This test will pass with data indicating whether the  element has any click event listeners."), supports: 3}),
 

[webkit-changes] [248936] branches/safari-608-branch

[bshafiei]

Title: [248936] branches/safari-608-branch








Revision 248936
Author bshaf...@apple.com
Date 2019-08-20 23:00:00 -0700 (Tue, 20 Aug 2019)


Log Message
Cherry-pick r248909. rdar://problem/54543354

Clicking the search icon on ae.com hangs the web content process
https://bugs.webkit.org/show_bug.cgi?id=200889


Reviewed by Ryosuke Niwa.

Source/WebCore:

The hang occurs under FrameSelection::selectionAtSentenceStart, while computing an EditorState to send to the UI
process. This act of determining whether the given positon is at the start of sentence entails moving backwards
from the start of the current visible selection until the start of a paragraph or sentence is found, using
VisiblePosition::previous to iterate backwards through VisiblePositions.

However, on this website, VisiblePosition::previous ends up just returning the current position, and we loop
infinitely as a result because we never actually move backwards. This happens because VisiblePosition::previous
first uses previousVisuallyDistinctCandidate to find a candidate Position before the current position, but when
the position is canonicalized to create a VisiblePosition, it is moved back to its original Position as the deep
equivalent.

In the attached test case (which is representative of the relevant part of the DOM on ae.com), we try to find
the previous VisiblePosition from (#c, 0). The previous visually distinct candidate we initially find is
(#b, 0), since:

1. The enclosing renderer is a RenderBlock with a non-zero height.
2. The enclosing renderer has no rendered children.
3. The position is at the first editing position in the node (i.e. the span element).

However, when canonicalizing the position, we find that neither the upstream nor the downstream position is a
candidate because both the upstream and downstream nodes end up well outside of the span (the upstream node ends
up being at the start of the body element, and the downstream position ends up right before the start of #c's
container). The downstream position is at the end of a text node with a leading newline, it's not a candidate
because its last caret offset is less than the length of the text node.

As a result, even though the given position (#b, 0) is a candidate itself, its downstream and upstream positions
are not. Thus, VisiblePosition::canonicalPosition expands the scope of its candidate positions to the next
closest candidate positions; the next candidate position is (#c, 0). Both of these candidates are outside of the
containing block, so we (somewhat arbitrarily) break the tie by choosing the next visible position, bringing us
back to (#c, 0).

There are several ways to fix this, one of which involves fixing the downstream/upstream positions of (#b, 0) so
that they no longer jump out of the containing block of #b and cause (#b, 0) to be an invalid visible position
despite being a candidate position. This can be achieved by adjusting the heuristic in
endsOfNodeAreVisuallyDistinctPositions (used when moving upstream or downstream). Currently, this helper
function returns false for #b because they contain a single (non-rendered) whitespace character. Removing this
extraneous whitespace character actually causes the problem to stop reproducing, since #b and #c no longer
contain any child nodes. This is important because the heuristic in Position::downstream attempts to keep the
downstream position within the confines of the enclosing visual boundary, which (currently) ends up being the
entire body element because endsOfNodeAreVisuallyDistinctPositions returns false for #b.

To avoid this scenario, we teach endsOfNodeAreVisuallyDistinctPositions to treat inline-block containers that
are empty (that is, contain no rendered content) but may have children for editing in the same way as inline-
block containers that don't have any children; in both scenarios, they may contain a candidate position, so we
should treat the ends of the container node as being visually distinct.

Doing so causes the downstream position of (#b, 0) to be kept within the immediate containing span element,
which then allows (#b, 0) to be a canonical VisiblePosition.

Tests:  fast/events/focus-anchor-with-tabindex-hang.html
editing/selection/modify-backward-inline-block-containers.html

* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::previous const):

LayoutTests:

* editing/selection/modify-backward-inline-block-containers-expected.txt: Added.
* editing/selection/modify-backward-inline-block-containers.html: Added.

Add a layout test to ensure that the selection may be moved through empty inline-block containers that span the
width of the page.

* fast/events/focus-anchor-with-tabindex-hang-expected.txt: Added.
* 

[webkit-changes] [248845] branches/safari-608-branch/Source

[bshafiei]

Title: [248845] branches/safari-608-branch/Source








Revision 248845
Author bshaf...@apple.com
Date 2019-08-18 23:05:57 -0700 (Sun, 18 Aug 2019)


Log Message
Cherry-pick r248832. rdar://problem/54454547

[Mac] Use the PID of the WebContent process when issuing local file read sandbox extensions
https://bugs.webkit.org/show_bug.cgi?id=200543

Source/WebKit:

Reviewed by Brent Fulgham.

Adopt SPI to issue a process-specific sandbox extension for local file read, passing it the process
identifier of the WebContent process.

* Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtensionImpl::sandboxExtensionForType):
(WebKit::SandboxExtension::createHandleForReadByPid):
* Shared/SandboxExtension.h:
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::createSandboxExtensionsIfNeeded):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::loadFile):

Source/WTF:

Reviewed by Brent Fulgham.

Add new SPI.

* wtf/Platform.h:
* wtf/spi/darwin/SandboxSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WTF/ChangeLog
branches/safari-608-branch/Source/WTF/wtf/Platform.h
branches/safari-608-branch/Source/WTF/wtf/spi/darwin/SandboxSPI.h
branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm
branches/safari-608-branch/Source/WebKit/Shared/SandboxExtension.h
branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
branches/safari-608-branch/Source/WebKit/UIProcess/WebPageProxy.cpp




Diff

Modified: branches/safari-608-branch/Source/WTF/ChangeLog (248844 => 248845)

--- branches/safari-608-branch/Source/WTF/ChangeLog	2019-08-19 06:03:44 UTC (rev 248844)
+++ branches/safari-608-branch/Source/WTF/ChangeLog	2019-08-19 06:05:57 UTC (rev 248845)
@@ -1,5 +1,54 @@
 2019-08-18  Babak Shafiei  
 
+Cherry-pick r248832. rdar://problem/54454547
+
+[Mac] Use the PID of the WebContent process when issuing local file read sandbox extensions
+https://bugs.webkit.org/show_bug.cgi?id=200543
+
+Source/WebKit:
+
+Reviewed by Brent Fulgham.
+
+Adopt SPI to issue a process-specific sandbox extension for local file read, passing it the process
+identifier of the WebContent process.
+
+* Shared/Cocoa/SandboxExtensionCocoa.mm:
+(WebKit::SandboxExtensionImpl::sandboxExtensionForType):
+(WebKit::SandboxExtension::createHandleForReadByPid):
+* Shared/SandboxExtension.h:
+* UIProcess/Cocoa/WebPageProxyCocoa.mm:
+(WebKit::WebPageProxy::createSandboxExtensionsIfNeeded):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
+(WebKit::WebPageProxy::loadFile):
+
+Source/WTF:
+
+Reviewed by Brent Fulgham.
+
+Add new SPI.
+
+* wtf/Platform.h:
+* wtf/spi/darwin/SandboxSPI.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-08-18  Per Arne Vollan  
+
+[Mac] Use the PID of the WebContent process when issuing local file read sandbox extensions
+https://bugs.webkit.org/show_bug.cgi?id=200543
+
+
+Reviewed by Brent Fulgham.
+
+Add new SPI.
+
+* wtf/Platform.h:
+* wtf/spi/darwin/SandboxSPI.h:
+
+2019-08-18  Babak Shafiei  
+
 Cherry-pick r248823. rdar://problem/54454713
 
 Source/WebKit:


Modified: branches/safari-608-branch/Source/WTF/wtf/Platform.h (248844 => 248845)

--- branches/safari-608-branch/Source/WTF/wtf/Platform.h	2019-08-19 06:03:44 UTC (rev 248844)
+++ branches/safari-608-branch/Source/WTF/wtf/Platform.h	2019-08-19 06:05:57 UTC (rev 248845)
@@ -1530,6 +1530,10 @@
 #define HAVE_SANDBOX_ISSUE_MACH_EXTENSION_TO_PROCESS_BY_PID 1
 #endif
 
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400)
+#define HAVE_SANDBOX_ISSUE_READ_EXTENSION_TO_PROCESS_BY_PID 1
+#endif
+
 #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 13)
 #define HAVE_MDNS_FAST_REGISTRATION 1
 #endif


Modified: branches/safari-608-branch/Source/WTF/wtf/spi/darwin/SandboxSPI.h (248844 => 248845)

--- branches/safari-608-branch/Source/WTF/wtf/spi/darwin/SandboxSPI.h	2019-08-19 06:03:44 UTC (rev 248844)
+++ branches/safari-608-branch/Source/WTF/wtf/spi/darwin/SandboxSPI.h	2019-08-19 06:05:57 UTC (rev 248845)
@@ -61,9 +61,12 @@
 extern const char *const APP_SANDBOX_READ_WRITE;
 extern const enum sandbox_filter_type SANDBOX_CHECK_NO_REPORT;
 
+extern const uint32_t SANDBOX_EXTENSION_USER_INTENT;
+
 char *sandbox_extension_issue_file(const char *extension_class, const char *path, uint32_t flags);
 

[webkit-changes] [248842] branches/safari-608-branch

[bshafiei]

Title: [248842] branches/safari-608-branch








Revision 248842
Author bshaf...@apple.com
Date 2019-08-18 23:03:38 -0700 (Sun, 18 Aug 2019)


Log Message
Cherry-pick r248815. rdar://problem/54454993

[macOS] Emoji with variation selectors are rendered in text style, not emoji style
https://bugs.webkit.org/show_bug.cgi?id=200830


Reviewed by Simon Fraser.

Source/WebCore:

When mapping characters to glyphs, Core Text is giving us the deleted glyph ID, which is unexpected.
We were treating it as a valid glyph ID, but it rather should be treated as an invalid glyph ID.

Test: fast/text/emoji-variation-selector.html

* platform/graphics/mac/GlyphPageMac.cpp:
(WebCore::GlyphPage::fill):

LayoutTests:

* fast/text/emoji-variation-selector-expected-mismatch.html: Added.
* fast/text/emoji-variation-selector.html: Added.
* platform/win/TestExpectations: Mark as failing on Windows, because it doesn't support variation selectors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/LayoutTests/platform/win/TestExpectations
branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp


Added Paths

branches/safari-608-branch/LayoutTests/fast/text/emoji-variation-selector-expected-mismatch.html
branches/safari-608-branch/LayoutTests/fast/text/emoji-variation-selector.html




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (248841 => 248842)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-08-19 06:03:34 UTC (rev 248841)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-08-19 06:03:38 UTC (rev 248842)
@@ -1,5 +1,45 @@
 2019-08-18  Babak Shafiei  
 
+Cherry-pick r248815. rdar://problem/54454993
+
+[macOS] Emoji with variation selectors are rendered in text style, not emoji style
+https://bugs.webkit.org/show_bug.cgi?id=200830
+
+
+Reviewed by Simon Fraser.
+
+Source/WebCore:
+
+When mapping characters to glyphs, Core Text is giving us the deleted glyph ID, which is unexpected.
+We were treating it as a valid glyph ID, but it rather should be treated as an invalid glyph ID.
+
+Test: fast/text/emoji-variation-selector.html
+
+* platform/graphics/mac/GlyphPageMac.cpp:
+(WebCore::GlyphPage::fill):
+
+LayoutTests:
+
+* fast/text/emoji-variation-selector-expected-mismatch.html: Added.
+* fast/text/emoji-variation-selector.html: Added.
+* platform/win/TestExpectations: Mark as failing on Windows, because it doesn't support variation selectors.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-08-16  Myles C. Maxfield  
+
+[macOS] Emoji with variation selectors are rendered in text style, not emoji style
+https://bugs.webkit.org/show_bug.cgi?id=200830
+
+
+Reviewed by Simon Fraser.
+
+* fast/text/emoji-variation-selector-expected-mismatch.html: Added.
+* fast/text/emoji-variation-selector.html: Added.
+* platform/win/TestExpectations: Mark as failing on Windows, because it doesn't support variation selectors.
+
+2019-08-18  Babak Shafiei  
+
 Cherry-pick r248733. rdar://problem/54454989
 
 Occasional hang under -[UIKeyboardTaskQueue lockWhenReadyForMainThread] when long-pressing non-editable text


Added: branches/safari-608-branch/LayoutTests/fast/text/emoji-variation-selector-expected-mismatch.html (0 => 248842)

--- branches/safari-608-branch/LayoutTests/fast/text/emoji-variation-selector-expected-mismatch.html	(rev 0)
+++ branches/safari-608-branch/LayoutTests/fast/text/emoji-variation-selector-expected-mismatch.html	2019-08-19 06:03:38 UTC (rev 248842)
@@ -0,0 +1,10 @@
+
+
+
+
+
+
+
+
+
+


Added: branches/safari-608-branch/LayoutTests/fast/text/emoji-variation-selector.html (0 => 248842)

--- branches/safari-608-branch/LayoutTests/fast/text/emoji-variation-selector.html	(rev 0)
+++ branches/safari-608-branch/LayoutTests/fast/text/emoji-variation-selector.html	2019-08-19 06:03:38 UTC (rev 248842)
@@ -0,0 +1,10 @@
+
+
+
+
+
+
+
+
+
+


Modified: branches/safari-608-branch/LayoutTests/platform/win/TestExpectations (248841 => 248842)

--- branches/safari-608-branch/LayoutTests/platform/win/TestExpectations	2019-08-19 06:03:34 UTC (rev 248841)
+++ branches/safari-608-branch/LayoutTests/platform/win/TestExpectations	2019-08-19 06:03:38 UTC (rev 248842)
@@ -4427,3 +4427,6 @@
 webkit.org/b/198112 http/tests/security/showModalDialog-sync-cross-origin-page-load2.html [ Skip ]
 
 webkit.org/b/198679 fast/events/fire-mousedown-while-pressing-mouse-button.html [ Failure ]
+
+# Variation selectors are not implemented on 

[webkit-changes] [248843] branches/safari-608-branch

[bshafiei]

Title: [248843] branches/safari-608-branch








Revision 248843
Author bshaf...@apple.com
Date 2019-08-18 23:03:40 -0700 (Sun, 18 Aug 2019)


Log Message
Cherry-pick r248819. rdar://problem/54455005

Content in  should override "touch-action" set in embedding document
https://bugs.webkit.org/show_bug.cgi?id=200204


Reviewed by Antoine Quint.

Source/WebKit:

Subframes where content doesn't use any touch-action properties won't generate event region for their main layer.
As a result the touch-action property gets computed in UI process to the parent frames touch-action (instead of 'auto').

* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
(WebKit::touchActionsForPoint):

If the topmost layer hit is a WKChildScrollView we know its content layer didn't have an event region.
This means we should return the default value 'auto'.

LayoutTests:

* pointerevents/ios/touch-action-none-with-frame-inside-expected.txt: Added.
* pointerevents/ios/touch-action-none-with-frame-inside.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm


Added Paths

branches/safari-608-branch/LayoutTests/pointerevents/ios/touch-action-none-with-frame-inside-expected.txt
branches/safari-608-branch/LayoutTests/pointerevents/ios/touch-action-none-with-frame-inside.html




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (248842 => 248843)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-08-19 06:03:38 UTC (rev 248842)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-08-19 06:03:40 UTC (rev 248843)
@@ -1,5 +1,45 @@
 2019-08-18  Babak Shafiei  
 
+Cherry-pick r248819. rdar://problem/54455005
+
+Content in  should override "touch-action" set in embedding document
+https://bugs.webkit.org/show_bug.cgi?id=200204
+
+
+Reviewed by Antoine Quint.
+
+Source/WebKit:
+
+Subframes where content doesn't use any touch-action properties won't generate event region for their main layer.
+As a result the touch-action property gets computed in UI process to the parent frames touch-action (instead of 'auto').
+
+* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
+(WebKit::touchActionsForPoint):
+
+If the topmost layer hit is a WKChildScrollView we know its content layer didn't have an event region.
+This means we should return the default value 'auto'.
+
+LayoutTests:
+
+* pointerevents/ios/touch-action-none-with-frame-inside-expected.txt: Added.
+* pointerevents/ios/touch-action-none-with-frame-inside.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-08-17  Antti Koivisto  
+
+Content in  should override "touch-action" set in embedding document
+https://bugs.webkit.org/show_bug.cgi?id=200204
+
+
+Reviewed by Antoine Quint.
+
+* pointerevents/ios/touch-action-none-with-frame-inside-expected.txt: Added.
+* pointerevents/ios/touch-action-none-with-frame-inside.html: Added.
+
+2019-08-18  Babak Shafiei  
+
 Cherry-pick r248815. rdar://problem/54454993
 
 [macOS] Emoji with variation selectors are rendered in text style, not emoji style


Added: branches/safari-608-branch/LayoutTests/pointerevents/ios/touch-action-none-with-frame-inside-expected.txt (0 => 248843)

--- branches/safari-608-branch/LayoutTests/pointerevents/ios/touch-action-none-with-frame-inside-expected.txt	(rev 0)
+++ branches/safari-608-branch/LayoutTests/pointerevents/ios/touch-action-none-with-frame-inside-expected.txt	2019-08-19 06:03:40 UTC (rev 248843)
@@ -0,0 +1,6 @@
+
+
+
+Frame: ''
+
+Scrolled


Added: branches/safari-608-branch/LayoutTests/pointerevents/ios/touch-action-none-with-frame-inside.html (0 => 248843)

--- branches/safari-608-branch/LayoutTests/pointerevents/ios/touch-action-none-with-frame-inside.html	(rev 0)
+++ branches/safari-608-branch/LayoutTests/pointerevents/ios/touch-action-none-with-frame-inside.html	2019-08-19 06:03:40 UTC (rev 248843)
@@ -0,0 +1,48 @@
+ 
+
+
+
+
+body { touch-action:none }
+
+