[webkit-changes] [217224] trunk/Source

2017-05-22 Thread wenson_hsieh
Title: [217224] trunk/Source Revision 217224 Author wenson_hs...@apple.com Date 2017-05-22 11:02:33 -0700 (Mon, 22 May 2017) Log Message Remove unused documentIsHandlingNonDefaultDrag plumbing for WebKit2 https://bugs.webkit.org/show_bug.cgi?id=172453 Reviewed by Tim Horton.

[webkit-changes] [217284] trunk

2017-05-23 Thread wenson_hsieh
Title: [217284] trunk Revision 217284 Author wenson_hs...@apple.com Date 2017-05-23 11:27:21 -0700 (Tue, 23 May 2017) Log Message Multiple links should be inserted separately when performing data interaction https://bugs.webkit.org/show_bug.cgi?id=172489 Reviewed by Dan Bernstein.

[webkit-changes] [217382] trunk

2017-05-24 Thread wenson_hsieh
Title: [217382] trunk Revision 217382 Author wenson_hs...@apple.com Date 2017-05-24 12:01:43 -0700 (Wed, 24 May 2017) Log Message Plumb additional image metadata to item providers when beginning data interaction on an image https://bugs.webkit.org/show_bug.cgi?id=172536 Reviewed by

[webkit-changes] [217375] trunk/Source/WebKit2

2017-05-24 Thread wenson_hsieh
Title: [217375] trunk/Source/WebKit2 Revision 217375 Author wenson_hs...@apple.com Date 2017-05-24 11:38:53 -0700 (Wed, 24 May 2017) Log Message [WK2] Remove workaround to disable zooming to the focus rect while performing a data interaction https://bugs.webkit.org/show_bug.cgi?id=172546

[webkit-changes] [217497] trunk/Tools

2017-05-26 Thread wenson_hsieh
Title: [217497] trunk/Tools Revision 217497 Author wenson_hs...@apple.com Date 2017-05-26 11:20:27 -0700 (Fri, 26 May 2017) Log Message Add test resources back into TestWebKitAPI Copy Resources phase Rubber-stamped by Beth Dakin. Add two files back into the Copy Resources phase after

[webkit-changes] [217501] trunk/Source/WebCore

2017-05-26 Thread wenson_hsieh
Title: [217501] trunk/Source/WebCore Revision 217501 Author wenson_hs...@apple.com Date 2017-05-26 13:22:29 -0700 (Fri, 26 May 2017) Log Message Unreviewed, fix the build using the latest SDK Add deprecation guards around newly introduced (and deprecated) SPI. *

[webkit-changes] [217074] trunk

2017-05-18 Thread wenson_hsieh
Title: [217074] trunk Revision 217074 Author wenson_hs...@apple.com Date 2017-05-18 16:20:34 -0700 (Thu, 18 May 2017) Log Message Selection around attachment elements should not persist when beginning a drag https://bugs.webkit.org/show_bug.cgi?id=172319 Reviewed by Tim Horton.

[webkit-changes] [217136] trunk/Tools

2017-05-19 Thread wenson_hsieh
Title: [217136] trunk/Tools Revision 217136 Author wenson_hs...@apple.com Date 2017-05-19 11:41:22 -0700 (Fri, 19 May 2017) Log Message Unreviewed, fix the build on the latest internal SDK. * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: (TestWebKitAPI::TEST): Modified Paths

[webkit-changes] [217083] trunk/Source/WebCore

2017-05-18 Thread wenson_hsieh
Title: [217083] trunk/Source/WebCore Revision 217083 Author wenson_hs...@apple.com Date 2017-05-18 18:44:56 -0700 (Thu, 18 May 2017) Log Message Attachment drag preview should not have the attachment outline https://bugs.webkit.org/show_bug.cgi?id=172327 Reviewed by Tim Horton. When

[webkit-changes] [217332] trunk

2017-05-24 Thread wenson_hsieh
Title: [217332] trunk Revision 217332 Author wenson_hs...@apple.com Date 2017-05-24 00:21:22 -0700 (Wed, 24 May 2017) Log Message Respect image UTIs when writing to item providers when beginning data interaction on an image https://bugs.webkit.org/show_bug.cgi?id=172436 Reviewed by

[webkit-changes] [217748] trunk/Source/WebCore

2017-06-02 Thread wenson_hsieh
Title: [217748] trunk/Source/WebCore Revision 217748 Author wenson_hs...@apple.com Date 2017-06-02 19:27:27 -0700 (Fri, 02 Jun 2017) Log Message REGRESSION(r216212): RenderReplaced::paint() should not save and restore the context unless it has to

[webkit-changes] [217818] trunk

2017-06-05 Thread wenson_hsieh
Title: [217818] trunk Revision 217818 Author wenson_hs...@apple.com Date 2017-06-05 21:47:39 -0700 (Mon, 05 Jun 2017) Log Message Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types https://bugs.webkit.org/show_bug.cgi?id=172891 Reviewed by

[webkit-changes] [218343] trunk

2017-06-15 Thread wenson_hsieh
Title: [218343] trunk Revision 218343 Author wenson_hs...@apple.com Date 2017-06-15 11:11:52 -0700 (Thu, 15 Jun 2017) Log Message Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading

[webkit-changes] [218224] trunk/Source/WebKit2

2017-06-13 Thread wenson_hsieh
Title: [218224] trunk/Source/WebKit2 Revision 218224 Author wenson_hs...@apple.com Date 2017-06-13 17:10:06 -0700 (Tue, 13 Jun 2017) Log Message Add missing availability declarations to SPI in WKUIDelegatePrivate.h https://bugs.webkit.org/show_bug.cgi?id=173336 Reviewed by Tim Horton.

[webkit-changes] [218380] trunk/Source/WebKit/mac

2017-06-15 Thread wenson_hsieh
Title: [218380] trunk/Source/WebKit/mac Revision 218380 Author wenson_hs...@apple.com Date 2017-06-15 21:06:04 -0700 (Thu, 15 Jun 2017) Log Message [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default https://bugs.webkit.org/show_bug.cgi?id=173454

[webkit-changes] [218180] trunk

2017-06-13 Thread wenson_hsieh
Title: [218180] trunk Revision 218180 Author wenson_hs...@apple.com Date 2017-06-13 09:58:13 -0700 (Tue, 13 Jun 2017) Log Message Unable to paste text that was copied from a page into the universal search field https://bugs.webkit.org/show_bug.cgi?id=173293 Reviewed by Ryosuke Niwa.

[webkit-changes] [218014] trunk

2017-06-09 Thread wenson_hsieh
Title: [218014] trunk Revision 218014 Author wenson_hs...@apple.com Date 2017-06-09 13:10:59 -0700 (Fri, 09 Jun 2017) Log Message [iOS DnD] Add a hook to perform two-step drops in editable content https://bugs.webkit.org/show_bug.cgi?id=172992 Reviewed by Tim Horton. Source/WebCore:

[webkit-changes] [216094] trunk/Source/WebCore

2017-05-02 Thread wenson_hsieh
Title: [216094] trunk/Source/WebCore Revision 216094 Author wenson_hs...@apple.com Date 2017-05-02 14:13:04 -0700 (Tue, 02 May 2017) Log Message Remove an extraneous call to dispatch_group_async in WebItemProviderPasteboard.mm https://bugs.webkit.org/show_bug.cgi?id=171561 Reviewed by

[webkit-changes] [216257] trunk/Source/WebCore

2017-05-05 Thread wenson_hsieh
Title: [216257] trunk/Source/WebCore Revision 216257 Author wenson_hs...@apple.com Date 2017-05-05 12:20:32 -0700 (Fri, 05 May 2017) Log Message Add SPI to WebItemProviderPasteboard to synchronously load data with a given timeout https://bugs.webkit.org/show_bug.cgi?id=171725 Reviewed

[webkit-changes] [216212] trunk

2017-05-04 Thread wenson_hsieh
Title: [216212] trunk Revision 216212 Author wenson_hs...@apple.com Date 2017-05-04 15:28:22 -0700 (Thu, 04 May 2017) Log Message [WK2] Add support for keeping the selection in a focused editable element when dragging begins https://bugs.webkit.org/show_bug.cgi?id=171585 Reviewed by

[webkit-changes] [216213] trunk/Source/WebKit2

2017-05-04 Thread wenson_hsieh
Title: [216213] trunk/Source/WebKit2 Revision 216213 Author wenson_hs...@apple.com Date 2017-05-04 15:35:31 -0700 (Thu, 04 May 2017) Log Message [WK2] Image action sheets sometimes do not dismiss when beginning data interaction https://bugs.webkit.org/show_bug.cgi?id=171687 Reviewed by

[webkit-changes] [216042] trunk/Tools

2017-05-01 Thread wenson_hsieh
Title: [216042] trunk/Tools Revision 216042 Author wenson_hs...@apple.com Date 2017-05-01 16:18:15 -0700 (Mon, 01 May 2017) Log Message Unreviewed, fix the build on a new internal SDK Replace usages of NSItemProviderRepresentationVisibilityAll with

[webkit-changes] [216470] trunk/Source/WebCore

2017-05-08 Thread wenson_hsieh
Title: [216470] trunk/Source/WebCore Revision 216470 Author wenson_hs...@apple.com Date 2017-05-08 18:45:20 -0700 (Mon, 08 May 2017) Log Message Guard DragController::cleanupAfterSystemDrag to only clear drag state on Mac https://bugs.webkit.org/show_bug.cgi?id=171771 Reviewed by Tim

[webkit-changes] [218855] trunk

2017-06-27 Thread wenson_hsieh
Title: [218855] trunk Revision 218855 Author wenson_hs...@apple.com Date 2017-06-27 17:36:31 -0700 (Tue, 27 Jun 2017) Log Message [iOS DnD] Support dragging out of contenteditable areas without a prior selection https://bugs.webkit.org/show_bug.cgi?id=173854 Reviewed by Ryosuke Niwa

[webkit-changes] [221893] trunk/Tools

2017-09-11 Thread wenson_hsieh
Title: [221893] trunk/Tools Revision 221893 Author wenson_hs...@apple.com Date 2017-09-11 16:34:03 -0700 (Mon, 11 Sep 2017) Log Message [iOS WK2] ExternalSourceDataTransferItemGetAsEntry tests produce inconsistent results on test automation bots

[webkit-changes] [221900] trunk

2017-09-11 Thread wenson_hsieh
Title: [221900] trunk Revision 221900 Author wenson_hs...@apple.com Date 2017-09-11 19:09:28 -0700 (Mon, 11 Sep 2017) Log Message [iOS WK2] Support tapping to add items to the current drag session in web content https://bugs.webkit.org/show_bug.cgi?id=176421 Reviewed by Tim Horton.

[webkit-changes] [222245] trunk

2017-09-19 Thread wenson_hsieh
Title: [45] trunk Revision 45 Author wenson_hs...@apple.com Date 2017-09-19 19:20:28 -0700 (Tue, 19 Sep 2017) Log Message REGRESSION (r215613): Incorrect corners clipping with border-radius https://bugs.webkit.org/show_bug.cgi?id=176498 Reviewed by Tim Horton. Source/WebCore:

[webkit-changes] [222220] trunk

2017-09-19 Thread wenson_hsieh
Title: [20] trunk Revision 20 Author wenson_hs...@apple.com Date 2017-09-19 13:25:47 -0700 (Tue, 19 Sep 2017) Log Message createMarkupInternal should protect its pointer to the Range's common ancestor https://bugs.webkit.org/show_bug.cgi?id=177033 Reviewed by Tim Horton.

[webkit-changes] [222005] trunk

2017-09-13 Thread wenson_hsieh
Title: [222005] trunk Revision 222005 Author wenson_hs...@apple.com Date 2017-09-13 18:49:05 -0700 (Wed, 13 Sep 2017) Log Message Submitting a form can cause HTMLFormElement's associated elements vector to be mutated during iteration https://bugs.webkit.org/show_bug.cgi?id=176368

[webkit-changes] [222046] trunk/LayoutTests

2017-09-14 Thread wenson_hsieh
Title: [222046] trunk/LayoutTests Revision 222046 Author wenson_hs...@apple.com Date 2017-09-14 12:55:02 -0700 (Thu, 14 Sep 2017) Log Message fast/forms/append-children-during-form-submission.html fails due to a text diff on iOS https://bugs.webkit.org/show_bug.cgi?id=176908 Reviewed by

[webkit-changes] [222114] trunk

2017-09-15 Thread wenson_hsieh
Title: [222114] trunk Revision 222114 Author wenson_hs...@apple.com Date 2017-09-15 15:18:51 -0700 (Fri, 15 Sep 2017) Log Message Avoid style recomputation when forwarding a focus event to an text field's input type https://bugs.webkit.org/show_bug.cgi?id=176160 Reviewed by Ryosuke

[webkit-changes] [222904] trunk/Source/WebCore

2017-10-05 Thread wenson_hsieh
Title: [222904] trunk/Source/WebCore Revision 222904 Author wenson_hs...@apple.com Date 2017-10-05 01:06:16 -0700 (Thu, 05 Oct 2017) Log Message Address post-review feedback following r222885 https://bugs.webkit.org/show_bug.cgi?id=177853 Reviewed by Ryosuke Niwa and Dan Bates. *

[webkit-changes] [222991] trunk

2017-10-06 Thread wenson_hsieh
Title: [222991] trunk Revision 222991 Author wenson_hs...@apple.com Date 2017-10-06 11:53:00 -0700 (Fri, 06 Oct 2017) Log Message [iOS] Tweak support for classifying form controls (followup to r222487) https://bugs.webkit.org/show_bug.cgi?id=177917 Reviewed by Dean Jackson.

[webkit-changes] [223017] trunk/Source/WebKit

2017-10-06 Thread wenson_hsieh
Title: [223017] trunk/Source/WebKit Revision 223017 Author wenson_hs...@apple.com Date 2017-10-06 19:36:59 -0700 (Fri, 06 Oct 2017) Log Message [iOS WK2] API tests added in r222991 are failing in iOS 11 test runners https://bugs.webkit.org/show_bug.cgi?id=178037 Reviewed by Tim Horton.

[webkit-changes] [223034] trunk

2017-10-08 Thread wenson_hsieh
Title: [223034] trunk Revision 223034 Author wenson_hs...@apple.com Date 2017-10-08 14:58:28 -0700 (Sun, 08 Oct 2017) Log Message DataTransfer.items does not contain items for custom types supplied via add or setData https://bugs.webkit.org/show_bug.cgi?id=178016 Reviewed by Darin

[webkit-changes] [222743] trunk/Tools

2017-10-02 Thread wenson_hsieh
Title: [222743] trunk/Tools Revision 222743 Author wenson_hs...@apple.com Date 2017-10-02 14:31:46 -0700 (Mon, 02 Oct 2017) Log Message Guard iOS webkitGetAsEntry API tests on older iOS versions Unreviewed test gardening. After r222688, these tests require custom pasteboard data to be

[webkit-changes] [222768] trunk

2017-10-02 Thread wenson_hsieh
Title: [222768] trunk Revision 222768 Author wenson_hs...@apple.com Date 2017-10-02 22:10:29 -0700 (Mon, 02 Oct 2017) Log Message REGRESSION(r222595): Intermittent crash while accessing DataTransferItemList https://bugs.webkit.org/show_bug.cgi?id=177791 Reviewed by Ryosuke Niwa.

[webkit-changes] [223050] trunk/Source/WebCore

2017-10-09 Thread wenson_hsieh
Title: [223050] trunk/Source/WebCore Revision 223050 Author wenson_hs...@apple.com Date 2017-10-09 10:27:15 -0700 (Mon, 09 Oct 2017) Log Message Unreviewed, fix the Windows build after r223031 Speculative build fix; no change in behavior. * page/EventHandler.h:

[webkit-changes] [223054] trunk/Source/WebCore

2017-10-09 Thread wenson_hsieh
Title: [223054] trunk/Source/WebCore Revision 223054 Author wenson_hs...@apple.com Date 2017-10-09 11:04:00 -0700 (Mon, 09 Oct 2017) Log Message Unreviewed, another build fix attempt after r223031 The default constructor of DragTargetResponse is also invoked via initializer list in

[webkit-changes] [223340] trunk

2017-10-16 Thread wenson_hsieh
Title: [223340] trunk Revision 223340 Author wenson_hs...@apple.com Date 2017-10-16 00:59:39 -0700 (Mon, 16 Oct 2017) Log Message On ToT, event.dataTransfer.getData("text/uri-list") returns an empty string when dragging an image https://bugs.webkit.org/show_bug.cgi?id=178301 Reviewed

[webkit-changes] [223410] trunk/Source/WebCore

2017-10-16 Thread wenson_hsieh
Title: [223410] trunk/Source/WebCore Revision 223410 Author wenson_hs...@apple.com Date 2017-10-16 09:21:09 -0700 (Mon, 16 Oct 2017) Log Message Unreviewed, fix the tvOS build after r223340. Add a new #define in PlatformPasteboardIOS.mm for item provider support, and guard usages of

[webkit-changes] [223471] trunk

2017-10-17 Thread wenson_hsieh
Title: [223471] trunk Revision 223471 Author wenson_hs...@apple.com Date 2017-10-16 23:56:00 -0700 (Mon, 16 Oct 2017) Log Message Allow reading data and blob URLs via DataTransfer when the pasteboard contains files https://bugs.webkit.org/show_bug.cgi?id=178377 Reviewed by Ryosuke Niwa.

[webkit-changes] [223456] trunk/Source/WebKit

2017-10-16 Thread wenson_hsieh
Title: [223456] trunk/Source/WebKit Revision 223456 Author wenson_hs...@apple.com Date 2017-10-16 22:00:00 -0700 (Mon, 16 Oct 2017) Log Message Unreviewed, fix the iOS build after r223431 Remove an unused variable captured in a lambda. * NetworkProcess/cocoa/NetworkSessionCocoa.mm:

[webkit-changes] [223278] trunk

2017-10-13 Thread wenson_hsieh
Title: [223278] trunk Revision 223278 Author wenson_hs...@apple.com Date 2017-10-13 00:14:29 -0700 (Fri, 13 Oct 2017) Log Message "text/html" data is not exposed when dragging and dropping across origins https://bugs.webkit.org/show_bug.cgi?id=178253 Reviewed by Ryosuke Niwa.

[webkit-changes] [221343] trunk

2017-08-29 Thread wenson_hsieh
Title: [221343] trunk Revision 221343 Author wenson_hs...@apple.com Date 2017-08-29 22:09:23 -0700 (Tue, 29 Aug 2017) Log Message REGRESSION(r210287) On drop, event.dataTransfer.getData("text") returns an empty string when dragging an image https://bugs.webkit.org/show_bug.cgi?id=170637

[webkit-changes] [221870] trunk

2017-09-11 Thread wenson_hsieh
Title: [221870] trunk Revision 221870 Author wenson_hs...@apple.com Date 2017-09-11 12:06:00 -0700 (Mon, 11 Sep 2017) Log Message [iOS DnD] Elements in the DOM with the `draggable` attribute should be draggable https://bugs.webkit.org/show_bug.cgi?id=176664 Reviewed by Tim Horton.

[webkit-changes] [221660] trunk

2017-09-05 Thread wenson_hsieh
Title: [221660] trunk Revision 221660 Author wenson_hs...@apple.com Date 2017-09-05 19:41:52 -0700 (Tue, 05 Sep 2017) Log Message [iOS WK2] Add plumbing for WKContentView to ask the web process for additional drag items https://bugs.webkit.org/show_bug.cgi?id=176348 Work towards

[webkit-changes] [221751] trunk

2017-09-07 Thread wenson_hsieh
Title: [221751] trunk Revision 221751 Author wenson_hs...@apple.com Date 2017-09-07 13:12:18 -0700 (Thu, 07 Sep 2017) Log Message [Directory Upload] Extend drag and drop support to iOS https://bugs.webkit.org/show_bug.cgi?id=176492 Reviewed by Tim Horton. Source/WebCore: Adds support

[webkit-changes] [221738] trunk/Source/WebCore/PAL

2017-09-07 Thread wenson_hsieh
Title: [221738] trunk/Source/WebCore/PAL Revision 221738 Author wenson_hs...@apple.com Date 2017-09-07 10:03:49 -0700 (Thu, 07 Sep 2017) Log Message [Mac] Stop importing NSFunctionBar_Private.h in NSTouchBarSPI.h on the macOS 10.13+ SDK https://bugs.webkit.org/show_bug.cgi?id=176521

[webkit-changes] [221952] trunk

2017-09-12 Thread wenson_hsieh
Title: [221952] trunk Revision 221952 Author wenson_hs...@apple.com Date 2017-09-12 18:05:28 -0700 (Tue, 12 Sep 2017) Log Message [iOS DnD] Support DataTransfer.getData and DataTransfer.setData when dragging or dropping https://bugs.webkit.org/show_bug.cgi?id=176672 Reviewed by Ryosuke

[webkit-changes] [221907] trunk

2017-09-12 Thread wenson_hsieh
Title: [221907] trunk Revision 221907 Author wenson_hs...@apple.com Date 2017-09-11 23:59:48 -0700 (Mon, 11 Sep 2017) Log Message [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS https://bugs.webkit.org/show_bug.cgi?id=176721 Reviewed by Tim Horton.

[webkit-changes] [222522] trunk/Tools

2017-09-26 Thread wenson_hsieh
Title: [222522] trunk/Tools Revision 222522 Author wenson_hs...@apple.com Date 2017-09-26 13:49:52 -0700 (Tue, 26 Sep 2017) Log Message [ios-simulator] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing https://bugs.webkit.org/show_bug.cgi?id=177271

[webkit-changes] [222609] trunk/Source/WebCore

2017-09-28 Thread wenson_hsieh
Title: [222609] trunk/Source/WebCore Revision 222609 Author wenson_hs...@apple.com Date 2017-09-28 07:53:11 -0700 (Thu, 28 Sep 2017) Log Message Unreviewed, rolling out r222606. The debug assertion hit in these API tests should be fixed by r222608. Reverted changeset:

[webkit-changes] [222608] trunk/Source/WebCore

2017-09-28 Thread wenson_hsieh
Title: [222608] trunk/Source/WebCore Revision 222608 Author wenson_hs...@apple.com Date 2017-09-28 07:47:59 -0700 (Thu, 28 Sep 2017) Log Message [iOS WK2] DataTransfer DataInteractionTests debug assert under -_preLoadedDataConformingToType:forItemProviderAtIndex:

[webkit-changes] [222685] trunk/LayoutTests

2017-09-30 Thread wenson_hsieh
Title: [222685] trunk/LayoutTests Revision 222685 Author wenson_hs...@apple.com Date 2017-09-30 16:33:09 -0700 (Sat, 30 Sep 2017) Log Message Add a layout test test that exercises setData and getData for non-normalized types https://bugs.webkit.org/show_bug.cgi?id=177707 Reviewed by

[webkit-changes] [222683] trunk/Source/WebCore

2017-09-30 Thread wenson_hsieh
Title: [222683] trunk/Source/WebCore Revision 222683 Author wenson_hs...@apple.com Date 2017-09-30 14:25:50 -0700 (Sat, 30 Sep 2017) Log Message [iOS WK2] API test EditorStateTests.ContentViewHasTextInContentEditableElement is a flaky failure

[webkit-changes] [222687] trunk/LayoutTests

2017-09-30 Thread wenson_hsieh
Title: [222687] trunk/LayoutTests Revision 222687 Author wenson_hs...@apple.com Date 2017-09-30 22:00:03 -0700 (Sat, 30 Sep 2017) Log Message Augment editing/pasteboard/data-transfer-get-data-non-normalized-types.html to check whitespace stripping

[webkit-changes] [222654] trunk

2017-09-29 Thread wenson_hsieh
Title: [222654] trunk Revision 222654 Author wenson_hs...@apple.com Date 2017-09-29 11:33:32 -0700 (Fri, 29 Sep 2017) Log Message [iOS WK2] Implement -[WKContentView hasText] for compatibility with the UITextInput protocol https://bugs.webkit.org/show_bug.cgi?id=177662 Reviewed by Tim

[webkit-changes] [222659] trunk/Source/WebCore

2017-09-29 Thread wenson_hsieh
Title: [222659] trunk/Source/WebCore Revision 222659 Author wenson_hs...@apple.com Date 2017-09-29 11:53:23 -0700 (Fri, 29 Sep 2017) Log Message [iOS] Remove unused pre-iOS 11 codepaths for writing to the pasteboard https://bugs.webkit.org/show_bug.cgi?id=177669 Reviewed by Tim Horton.

[webkit-changes] [222596] trunk/Source/WebCore

2017-09-27 Thread wenson_hsieh
Title: [222596] trunk/Source/WebCore Revision 222596 Author wenson_hs...@apple.com Date 2017-09-27 20:18:50 -0700 (Wed, 27 Sep 2017) Log Message Unreviewed, fix the internal build after r222595. Add missing iOS compiler guards. * platform/ios/PlatformPasteboardIOS.mm:

[webkit-changes] [222597] trunk/Source/WebCore

2017-09-27 Thread wenson_hsieh
Title: [222597] trunk/Source/WebCore Revision 222597 Author wenson_hs...@apple.com Date 2017-09-27 20:58:19 -0700 (Wed, 27 Sep 2017) Log Message Unreviewed, fix the internal build after r222596 and r222595. Guarding code in PlatformPasteboardIOS.mm TARGET_OS_IPHONE did not have the

[webkit-changes] [221233] trunk

2017-08-27 Thread wenson_hsieh
Title: [221233] trunk Revision 221233 Author wenson_hs...@apple.com Date 2017-08-27 18:22:55 -0700 (Sun, 27 Aug 2017) Log Message [iOS WK2] Web process crashes after changing selection to the end of the document when speaking a selection https://bugs.webkit.org/show_bug.cgi?id=176011

[webkit-changes] [221234] trunk

2017-08-27 Thread wenson_hsieh
Title: [221234] trunk Revision 221234 Author wenson_hs...@apple.com Date 2017-08-27 22:12:56 -0700 (Sun, 27 Aug 2017) Log Message Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events. https://bugs.webkit.org/show_bug.cgi?id=170955 Reviewed by

[webkit-changes] [221128] trunk

2017-08-23 Thread wenson_hsieh
Title: [221128] trunk Revision 221128 Author wenson_hs...@apple.com Date 2017-08-23 21:12:55 -0700 (Wed, 23 Aug 2017) Log Message DeleteSelectionCommand should be robust when starting and ending editable positions cannot be found https://bugs.webkit.org/show_bug.cgi?id=175914 Reviewed

[webkit-changes] [221199] trunk

2017-08-25 Thread wenson_hsieh
Title: [221199] trunk Revision 221199 Author wenson_hs...@apple.com Date 2017-08-25 12:04:23 -0700 (Fri, 25 Aug 2017) Log Message Using the touchbar, both align left and align justify send a beforeinput event with the 'formatJustifyLeft' inputType.

[webkit-changes] [220865] trunk

2017-08-17 Thread wenson_hsieh
Title: [220865] trunk Revision 220865 Author wenson_hs...@apple.com Date 2017-08-17 11:34:15 -0700 (Thu, 17 Aug 2017) Log Message [iOS] Respect type fidelities when copying image elements to the pasteboard https://bugs.webkit.org/show_bug.cgi?id=175638 Reviewed by Ryosuke Niwa.

[webkit-changes] [221595] trunk

2017-09-04 Thread wenson_hsieh
Title: [221595] trunk Revision 221595 Author wenson_hs...@apple.com Date 2017-09-04 16:36:20 -0700 (Mon, 04 Sep 2017) Log Message [iOS DnD] Refactor drag and drop logic in WKContentView in preparation for supporting multiple drag items in a drag session

[webkit-changes] [222885] trunk

2017-10-04 Thread wenson_hsieh
Title: [222885] trunk Revision 222885 Author wenson_hs...@apple.com Date 2017-10-04 15:28:08 -0700 (Wed, 04 Oct 2017) Log Message Add basic support for the version of DataTransferItemList.add that takes a File https://bugs.webkit.org/show_bug.cgi?id=177853 Reviewed by Ryosuke Niwa.

[webkit-changes] [223625] trunk

2017-10-18 Thread wenson_hsieh
Title: [223625] trunk Revision 223625 Author wenson_hs...@apple.com Date 2017-10-18 13:20:37 -0700 (Wed, 18 Oct 2017) Log Message Unreviewed, rolling out r223291. Source/WebCore: After further investigation, this removed codepath is something Mail may want to re-adopt. Additionally,

[webkit-changes] [223862] trunk/Source/WebCore

2017-10-23 Thread wenson_hsieh
Title: [223862] trunk/Source/WebCore Revision 223862 Author wenson_hs...@apple.com Date 2017-10-23 16:40:18 -0700 (Mon, 23 Oct 2017) Log Message Unreviewed, fix the Windows build after r223860 UTIUtilities only exists on Cocoa platforms, so we need to guard it accordingly. *

[webkit-changes] [223860] trunk/Source/WebCore

2017-10-23 Thread wenson_hsieh
Title: [223860] trunk/Source/WebCore Revision 223860 Author wenson_hs...@apple.com Date 2017-10-23 15:37:33 -0700 (Mon, 23 Oct 2017) Log Message [iOS] DocumentWriter::createDocument can spend ~100ms unnecessarily converting image UTIs to MIME types

[webkit-changes] [223827] trunk/Source/WebKit

2017-10-22 Thread wenson_hsieh
Title: [223827] trunk/Source/WebKit Revision 223827 Author wenson_hs...@apple.com Date 2017-10-22 19:20:19 -0700 (Sun, 22 Oct 2017) Log Message [iOS] WebProcess::initializeWebProcess spends ~150ms spinning up AVSystemController on some devices

[webkit-changes] [225252] trunk

2017-11-28 Thread wenson_hsieh
Title: [225252] trunk Revision 225252 Author wenson_hs...@apple.com Date 2017-11-28 18:06:22 -0800 (Tue, 28 Nov 2017) Log Message Allow attachment elements with no appearance to defer rendering to child nodes https://bugs.webkit.org/show_bug.cgi?id=180117 Reviewed by Tim Horton.

[webkit-changes] [225311] trunk

2017-11-29 Thread wenson_hsieh
Title: [225311] trunk Revision 225311 Author wenson_hs...@apple.com Date 2017-11-29 18:23:44 -0800 (Wed, 29 Nov 2017) Log Message [Attachment Support] Implement SPI for clients to make an attachment element display in-place https://bugs.webkit.org/show_bug.cgi?id=180153 Reviewed by Tim

[webkit-changes] [225332] trunk/Tools

2017-11-30 Thread wenson_hsieh
Title: [225332] trunk/Tools Revision 225332 Author wenson_hs...@apple.com Date 2017-11-30 10:58:06 -0800 (Thu, 30 Nov 2017) Log Message WKAttachmentTests.InPlaceImageAttachmentToggleDisplayMode times out on macOS bots https://bugs.webkit.org/show_bug.cgi?id=180200 Reviewed by Alexey

[webkit-changes] [225446] trunk/Source/WebKit

2017-12-02 Thread wenson_hsieh
Title: [225446] trunk/Source/WebKit Revision 225446 Author wenson_hs...@apple.com Date 2017-12-02 00:47:19 -0800 (Sat, 02 Dec 2017) Log Message Make some minor adjustments to TouchBarMenuData and TouchBarMenuItemData https://bugs.webkit.org/show_bug.cgi?id=180305 Reviewed by Joseph

[webkit-changes] [225505] trunk/Source/WebKit

2017-12-04 Thread wenson_hsieh
Title: [225505] trunk/Source/WebKit Revision 225505 Author wenson_hs...@apple.com Date 2017-12-04 16:13:09 -0800 (Mon, 04 Dec 2017) Log Message Rename a static helper in TouchBarMenuItemData.cpp to match style guidelines. https://bugs.webkit.org/show_bug.cgi?id=180305 Reviewed by Andy

[webkit-changes] [226093] trunk

2017-12-18 Thread wenson_hsieh
Title: [226093] trunk Revision 226093 Author wenson_hs...@apple.com Date 2017-12-18 20:03:21 -0800 (Mon, 18 Dec 2017) Log Message [Attachment Support] Support representing pasted or dropped content using attachment elements https://bugs.webkit.org/show_bug.cgi?id=180892 Reviewed by Tim

[webkit-changes] [226122] trunk/Source/WebCore

2017-12-19 Thread wenson_hsieh
Title: [226122] trunk/Source/WebCore Revision 226122 Author wenson_hs...@apple.com Date 2017-12-19 09:03:48 -0800 (Tue, 19 Dec 2017) Log Message Unreviewed, try to fix the Windows build after r226097. * editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendCustomAttributes):

[webkit-changes] [226148] trunk/Source/WebKitLegacy/mac

2017-12-19 Thread wenson_hsieh
Title: [226148] trunk/Source/WebKitLegacy/mac Revision 226148 Author wenson_hs...@apple.com Date 2017-12-19 15:12:00 -0800 (Tue, 19 Dec 2017) Log Message API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra

[webkit-changes] [226164] trunk/Tools

2017-12-19 Thread wenson_hsieh
Title: [226164] trunk/Tools Revision 226164 Author wenson_hs...@apple.com Date 2017-12-19 17:31:21 -0800 (Tue, 19 Dec 2017) Log Message Unreviewed, rebaseline an API test result for El Capitan and Sierra. * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm: (TestWebKitAPI::TEST):

[webkit-changes] [226089] trunk/Source/WebCore

2017-12-18 Thread wenson_hsieh
Title: [226089] trunk/Source/WebCore Revision 226089 Author wenson_hs...@apple.com Date 2017-12-18 17:39:22 -0800 (Mon, 18 Dec 2017) Log Message Unreviewed, attempt to fix watch and TV builds after r226085 Explicitly include a header in WebContentReaderCocoa.mm. *

[webkit-changes] [226085] trunk

2017-12-18 Thread wenson_hsieh
Title: [226085] trunk Revision 226085 Author wenson_hs...@apple.com Date 2017-12-18 16:19:17 -0800 (Mon, 18 Dec 2017) Log Message [Attachment Support] Insert images as inline attachments when pasting and dropping https://bugs.webkit.org/show_bug.cgi?id=180853 Reviewed by Tim Horton.

[webkit-changes] [226097] trunk

2017-12-18 Thread wenson_hsieh
Title: [226097] trunk Revision 226097 Author wenson_hs...@apple.com Date 2017-12-18 21:38:47 -0800 (Mon, 18 Dec 2017) Log Message [Attachment Support] The 'webkitattachmentbloburl' attribute should not persist after markup serialization https://bugs.webkit.org/show_bug.cgi?id=180924

[webkit-changes] [224708] trunk/Tools

2017-11-10 Thread wenson_hsieh
Title: [224708] trunk/Tools Revision 224708 Author wenson_hs...@apple.com Date 2017-11-10 15:13:19 -0800 (Fri, 10 Nov 2017) Log Message Finish rolling out r224544 Rubber-stamped by Tim Horton. Now that https://bugs.webkit.org/show_bug.cgi?id=179431 has been fixed, we can once again

[webkit-changes] [224755] trunk

2017-11-13 Thread wenson_hsieh
Title: [224755] trunk Revision 224755 Author wenson_hs...@apple.com Date 2017-11-13 07:30:39 -0800 (Mon, 13 Nov 2017) Log Message [Attachment Support] Implement SPI for clients to request data for a given attachment https://bugs.webkit.org/show_bug.cgi?id=179586 Reviewed by Darin

[webkit-changes] [224512] trunk

2017-11-06 Thread wenson_hsieh
Title: [224512] trunk Revision 224512 Author wenson_hs...@apple.com Date 2017-11-06 13:46:54 -0800 (Mon, 06 Nov 2017) Log Message [Attachment Support] Implement delegate hooks for attachment element insertion and removal https://bugs.webkit.org/show_bug.cgi?id=179016 Reviewed by Tim

[webkit-changes] [224517] trunk/Tools

2017-11-06 Thread wenson_hsieh
Title: [224517] trunk/Tools Revision 224517 Author wenson_hs...@apple.com Date 2017-11-06 16:45:08 -0800 (Mon, 06 Nov 2017) Log Message Unreviewed, fix the internal build after updating to a newer SDK There shouldn't be any need to include and implement these method stubs anymore, even

[webkit-changes] [224521] trunk/Tools

2017-11-06 Thread wenson_hsieh
Title: [224521] trunk/Tools Revision 224521 Author wenson_hs...@apple.com Date 2017-11-06 16:55:08 -0800 (Mon, 06 Nov 2017) Log Message Remove stray logging from a newly added API test This was only for debugging purposes, and should have been removed before landing. Rubber-stamped by

[webkit-changes] [224649] trunk

2017-11-09 Thread wenson_hsieh
Title: [224649] trunk Revision 224649 Author wenson_hs...@apple.com Date 2017-11-09 15:26:55 -0800 (Thu, 09 Nov 2017) Log Message Inserting an image, selecting, underlining, and then deleting leaves the typing style with both "-webkit-text-decorations-in-effect" and "text-decoration"

[webkit-changes] [224593] trunk

2017-11-08 Thread wenson_hsieh
Title: [224593] trunk Revision 224593 Author wenson_hs...@apple.com Date 2017-11-08 13:10:00 -0800 (Wed, 08 Nov 2017) Log Message [Attachment Support] Implement delegate hooks for attachment element insertion and removal https://bugs.webkit.org/show_bug.cgi?id=179016 Reviewed by Tim

[webkit-changes] [225422] trunk

2017-12-01 Thread wenson_hsieh
Title: [225422] trunk Revision 225422 Author wenson_hs...@apple.com Date 2017-12-01 15:36:41 -0800 (Fri, 01 Dec 2017) Log Message [Attachment Support] Implement SPI for clients to update a given attachment's data https://bugs.webkit.org/show_bug.cgi?id=180184 Reviewed by Tim Horton.

[webkit-changes] [223897] trunk/Source/WebCore

2017-10-24 Thread wenson_hsieh
Title: [223897] trunk/Source/WebCore Revision 223897 Author wenson_hs...@apple.com Date 2017-10-24 10:38:44 -0700 (Tue, 24 Oct 2017) Log Message [iOS] MediaPlayer::isAvailable() takes ~150 ms during web process initialization https://bugs.webkit.org/show_bug.cgi?id=178713 Reviewed by

[webkit-changes] [224238] trunk

2017-10-31 Thread wenson_hsieh
Title: [224238] trunk Revision 224238 Author wenson_hs...@apple.com Date 2017-10-31 12:29:12 -0700 (Tue, 31 Oct 2017) Log Message [Attachment Support] Implement WKWebView SPI for inserting attachment elements https://bugs.webkit.org/show_bug.cgi?id=179013 Reviewed by Tim Horton.

[webkit-changes] [224256] trunk/Source/WebKit

2017-10-31 Thread wenson_hsieh
Title: [224256] trunk/Source/WebKit Revision 224256 Author wenson_hs...@apple.com Date 2017-10-31 15:41:22 -0700 (Tue, 31 Oct 2017) Log Message Followup to r224238: API::Attachment should generate a _WKAttachment ObjC wrapper https://bugs.webkit.org/show_bug.cgi?id=179080 Reviewed by

[webkit-changes] [231396] trunk

2018-05-04 Thread wenson_hsieh
Title: [231396] trunk Revision 231396 Author wenson_hs...@apple.com Date 2018-05-04 21:39:52 -0700 (Fri, 04 May 2018) Log Message [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart https://bugs.webkit.org/show_bug.cgi?id=185289 Reviewed by Tim

[webkit-changes] [231508] trunk/Tools

2018-05-08 Thread wenson_hsieh
Title: [231508] trunk/Tools Revision 231508 Author wenson_hs...@apple.com Date 2018-05-08 13:16:44 -0700 (Tue, 08 May 2018) Log Message [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396 https://bugs.webkit.org/show_bug.cgi?id=185414 Reviewed by Tim Horton.

[webkit-changes] [231779] trunk

2018-05-14 Thread wenson_hsieh
Title: [231779] trunk Revision 231779 Author wenson_hs...@apple.com Date 2018-05-14 18:07:36 -0700 (Mon, 14 May 2018) Log Message [Extra zoom mode] Google search results are excessively zoomed in https://bugs.webkit.org/show_bug.cgi?id=185347 Reviewed by Tim Horton. Source/WebCore:

[webkit-changes] [231784] trunk/Source/WebCore

2018-05-14 Thread wenson_hsieh
Title: [231784] trunk/Source/WebCore Revision 231784 Author wenson_hs...@apple.com Date 2018-05-14 20:00:27 -0700 (Mon, 14 May 2018) Log Message Unreviewed, fix the iOS build after r231779 Also address a minor in-person review comment by returning "extrazoom" instead of the empty

[webkit-changes] [231537] trunk/Source/WebCore

2018-05-08 Thread wenson_hsieh
Title: [231537] trunk/Source/WebCore Revision 231537 Author wenson_hs...@apple.com Date 2018-05-08 21:14:48 -0700 (Tue, 08 May 2018) Log Message Unreviewed, fix the internal iOS build Add a missing import statement in an implementation file. * editing/cocoa/WebContentReaderCocoa.mm:

<    1   2   3   4   5   6   7   8   9   10   >