[webkit-changes] [238050] trunk

2018-11-09 Thread wenson_hsieh
Title: [238050] trunk Revision 238050 Author wenson_hs...@apple.com Date 2018-11-09 12:16:32 -0800 (Fri, 09 Nov 2018) Log Message [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists https://bugs.webkit.org/show_bug.cgi?id=191410 Reviewed by Dean Jackson.

[webkit-changes] [238080] trunk

2018-11-11 Thread wenson_hsieh
Title: [238080] trunk Revision 238080 Author wenson_hs...@apple.com Date 2018-11-11 17:39:27 -0800 (Sun, 11 Nov 2018) Log Message Implement a new edit command to change the enclosing list type https://bugs.webkit.org/show_bug.cgi?id=191487 Reviewed by Ryosuke Niwa. Source/WebCore:

[webkit-changes] [238146] trunk

2018-11-13 Thread wenson_hsieh
Title: [238146] trunk Revision 238146 Author wenson_hs...@apple.com Date 2018-11-13 14:30:27 -0800 (Tue, 13 Nov 2018) Log Message [iOS] Do not show selection UI for editable elements with opacity near zero https://bugs.webkit.org/show_bug.cgi?id=191442 Reviewed by Simon Fraser.

[webkit-changes] [237842] trunk

2018-11-05 Thread wenson_hsieh
Title: [237842] trunk Revision 237842 Author wenson_hs...@apple.com Date 2018-11-05 20:07:36 -0800 (Mon, 05 Nov 2018) Log Message [iOS] Swatch appears squished and off-center in inputs of type color https://bugs.webkit.org/show_bug.cgi?id=191279 Reviewed by Tim Horton. Source/WebCore:

[webkit-changes] [238020] trunk/Source/WebKit

2018-11-08 Thread wenson_hsieh
Title: [238020] trunk/Source/WebKit Revision 238020 Author wenson_hs...@apple.com Date 2018-11-08 22:49:35 -0800 (Thu, 08 Nov 2018) Log Message Unreviewed, try to fix the 32-bit macOS build * WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::showDefinitionForAttributedString):

[webkit-changes] [238188] trunk

2018-11-14 Thread wenson_hsieh
Title: [238188] trunk Revision 238188 Author wenson_hs...@apple.com Date 2018-11-14 11:27:29 -0800 (Wed, 14 Nov 2018) Log Message [iOS] A few drag and drop tests are crashing after r238146 https://bugs.webkit.org/show_bug.cgi?id=191617 Reviewed by Dean Jackson. Source/WebKit: The

[webkit-changes] [238186] trunk

2018-11-14 Thread wenson_hsieh
Title: [238186] trunk Revision 238186 Author wenson_hs...@apple.com Date 2018-11-14 11:00:04 -0800 (Wed, 14 Nov 2018) Log Message Source/WebKit: [Cocoa] [WebKit2] Hook up some more editing actions (-_pasteAndMatchStyle:, -makeTextWritingDirectionNatural:)

[webkit-changes] [237786] trunk/Tools

2018-11-04 Thread wenson_hsieh
Title: [237786] trunk/Tools Revision 237786 Author wenson_hs...@apple.com Date 2018-11-04 13:19:44 -0800 (Sun, 04 Nov 2018) Log Message [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm https://bugs.webkit.org/show_bug.cgi?id=191231

[webkit-changes] [236854] trunk

2018-10-04 Thread wenson_hsieh
Title: [236854] trunk Revision 236854 Author wenson_hs...@apple.com Date 2018-10-04 15:08:51 -0700 (Thu, 04 Oct 2018) Log Message [macOS] Fix some font attribute conversion bugs in preparation for "Font > Styles…" support in WebKit2 https://bugs.webkit.org/show_bug.cgi?id=190289

[webkit-changes] [236867] trunk

2018-10-04 Thread wenson_hsieh
Title: [236867] trunk Revision 236867 Author wenson_hs...@apple.com Date 2018-10-04 20:03:21 -0700 (Thu, 04 Oct 2018) Log Message [iOS] [WK2] Expose some more editing SPI on WKWebView https://bugs.webkit.org/show_bug.cgi?id=190232 Reviewed by Tim Horton. Source/WebKit: Exposes a few

[webkit-changes] [236865] trunk

2018-10-04 Thread wenson_hsieh
Title: [236865] trunk Revision 236865 Author wenson_hs...@apple.com Date 2018-10-04 17:47:05 -0700 (Thu, 04 Oct 2018) Log Message [Cocoa] Add SPI to expose typing attributes at the current selection on WKWebView https://bugs.webkit.org/show_bug.cgi?id=190119 Reviewed by Tim Horton.

[webkit-changes] [236955] trunk

2018-10-08 Thread wenson_hsieh
Title: [236955] trunk Revision 236955 Author wenson_hs...@apple.com Date 2018-10-08 18:52:49 -0700 (Mon, 08 Oct 2018) Log Message [Cocoa] [WK2] Add support for text alignment and text lists in font attributes https://bugs.webkit.org/show_bug.cgi?id=190342 Reviewed by Tim Horton.

[webkit-changes] [236951] trunk/Source/WebKit

2018-10-08 Thread wenson_hsieh
Title: [236951] trunk/Source/WebKit Revision 236951 Author wenson_hs...@apple.com Date 2018-10-08 17:11:54 -0700 (Mon, 08 Oct 2018) Log Message Followup to r236942: Make input type=color an internal feature https://bugs.webkit.org/show_bug.cgi?id=189162 Rubber-stamped by Dean Jackson.

[webkit-changes] [236958] trunk/Tools

2018-10-08 Thread wenson_hsieh
Title: [236958] trunk/Tools Revision 236958 Author wenson_hs...@apple.com Date 2018-10-08 20:28:31 -0700 (Mon, 08 Oct 2018) Log Message [macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12 https://bugs.webkit.org/show_bug.cgi?id=190386 Reviewed by Ryosuke Niwa. Unlike

[webkit-changes] [236770] trunk

2018-10-02 Thread wenson_hsieh
Title: [236770] trunk Revision 236770 Author wenson_hs...@apple.com Date 2018-10-02 15:53:37 -0700 (Tue, 02 Oct 2018) Log Message [WebKit2] Format > Bold and Format > Italic don't toggle between bold and italic style https://bugs.webkit.org/show_bug.cgi?id=179787 Reviewed by Tim

[webkit-changes] [236724] trunk

2018-10-02 Thread wenson_hsieh
Title: [236724] trunk Revision 236724 Author wenson_hs...@apple.com Date 2018-10-02 03:39:40 -0700 (Tue, 02 Oct 2018) Log Message [macOS] Implement a way for the UI process to request typing attributes at the current selection https://bugs.webkit.org/show_bug.cgi?id=189983 Reviewed by

[webkit-changes] [236691] trunk

2018-10-01 Thread wenson_hsieh
Title: [236691] trunk Revision 236691 Author wenson_hs...@apple.com Date 2018-10-01 13:59:19 -0700 (Mon, 01 Oct 2018) Log Message [iOS] Add SPI to customize the input accessory view when focusing an element https://bugs.webkit.org/show_bug.cgi?id=190152 Reviewed by Dan Bernstein.

[webkit-changes] [236634] trunk

2018-09-28 Thread wenson_hsieh
Title: [236634] trunk Revision 236634 Author wenson_hs...@apple.com Date 2018-09-28 19:12:57 -0700 (Fri, 28 Sep 2018) Log Message No DOM API to instantiate an attachment for an img element https://bugs.webkit.org/show_bug.cgi?id=189934 Reviewed by Ryosuke Niwa. Source/WebCore: Adds

[webkit-changes] [235504] trunk/Tools

2018-08-30 Thread wenson_hsieh
Title: [235504] trunk/Tools Revision 235504 Author wenson_hs...@apple.com Date 2018-08-30 07:35:27 -0700 (Thu, 30 Aug 2018) Log Message [iOS] TestWebKitAPI.PasteImage tests are flaky failures https://bugs.webkit.org/show_bug.cgi?id=185965 Reviewed by Andy Estes. These tests pass

[webkit-changes] [236445] trunk/Source

2018-09-24 Thread wenson_hsieh
Title: [236445] trunk/Source Revision 236445 Author wenson_hs...@apple.com Date 2018-09-24 17:17:29 -0700 (Mon, 24 Sep 2018) Log Message Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic https://bugs.webkit.org/show_bug.cgi?id=189918 Work towards Reviewed by Tim

[webkit-changes] [236468] trunk/Source/WebCore

2018-09-25 Thread wenson_hsieh
Title: [236468] trunk/Source/WebCore Revision 236468 Author wenson_hs...@apple.com Date 2018-09-25 11:59:38 -0700 (Tue, 25 Sep 2018) Log Message [iOS] Fix the open source iOS 12 build after r236445 https://bugs.webkit.org/show_bug.cgi?id=189953 Reviewed by Alex Christensen.

[webkit-changes] [238360] trunk

2018-11-17 Thread wenson_hsieh
Title: [238360] trunk Revision 238360 Author wenson_hs...@apple.com Date 2018-11-17 22:17:44 -0800 (Sat, 17 Nov 2018) Log Message [iOS] Remove all usages of UIItemProvider, UIItemProviderReading, and related classes https://bugs.webkit.org/show_bug.cgi?id=191819 Reviewed by Dan

[webkit-changes] [239573] trunk

2019-01-02 Thread wenson_hsieh
Title: [239573] trunk Revision 239573 Author wenson_hs...@apple.com Date 2019-01-02 12:28:24 -0800 (Wed, 02 Jan 2019) Log Message REGRESSION (r239441): [iOS] Selection UI sometimes doesn't change after tapping "select all" in the callout bar https://bugs.webkit.org/show_bug.cgi?id=193070

[webkit-changes] [239584] trunk

2019-01-02 Thread wenson_hsieh
Title: [239584] trunk Revision 239584 Author wenson_hs...@apple.com Date 2019-01-02 20:00:47 -0800 (Wed, 02 Jan 2019) Log Message Add support for using the current text selection as the find string on iOS https://bugs.webkit.org/show_bug.cgi?id=193034 Reviewed by Tim Horton.

[webkit-changes] [240159] trunk/Source/WebKit

2019-01-18 Thread wenson_hsieh
Title: [240159] trunk/Source/WebKit Revision 240159 Author wenson_hs...@apple.com Date 2019-01-18 11:10:04 -0800 (Fri, 18 Jan 2019) Log Message Remove some last vestiges of assisted node terminology in WebKit https://bugs.webkit.org/show_bug.cgi?id=193572 Reviewed by Tim Horton. *

[webkit-changes] [239931] trunk

2019-01-14 Thread wenson_hsieh
Title: [239931] trunk Revision 239931 Author wenson_hs...@apple.com Date 2019-01-14 12:09:58 -0800 (Mon, 14 Jan 2019) Log Message [iOS] Expose SPI to access the current sentence boundary and selection state https://bugs.webkit.org/show_bug.cgi?id=193398 Reviewed by Dean Jackson.

[webkit-changes] [240301] trunk/Tools

2019-01-22 Thread wenson_hsieh
Title: [240301] trunk/Tools Revision 240301 Author wenson_hs...@apple.com Date 2019-01-22 15:21:45 -0800 (Tue, 22 Jan 2019) Log Message [iOS] Multiple WKWebViewAutofillTests are flaky failures https://bugs.webkit.org/show_bug.cgi?id=189165 Reviewed by Tim Horton. These tests are

[webkit-changes] [240315] trunk/Source/WebCore

2019-01-22 Thread wenson_hsieh
Title: [240315] trunk/Source/WebCore Revision 240315 Author wenson_hs...@apple.com Date 2019-01-22 18:06:53 -0800 (Tue, 22 Jan 2019) Log Message Add some bindings-related bookkeeping to UndoManager and UndoItem https://bugs.webkit.org/show_bug.cgi?id=193111 Reviewed by Ryosuke Niwa.

[webkit-changes] [240352] trunk

2019-01-23 Thread wenson_hsieh
Title: [240352] trunk Revision 240352 Author wenson_hs...@apple.com Date 2019-01-23 12:09:54 -0800 (Wed, 23 Jan 2019) Log Message [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out https://bugs.webkit.org/show_bug.cgi?id=193182 Reviewed by Tim Horton.

[webkit-changes] [240342] trunk/Source

2019-01-23 Thread wenson_hsieh
Title: [240342] trunk/Source Revision 240342 Author wenson_hs...@apple.com Date 2019-01-23 09:30:05 -0800 (Wed, 23 Jan 2019) Log Message Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit https://bugs.webkit.org/show_bug.cgi?id=193706 Reviewed by Ryosuke Niwa.

[webkit-changes] [240139] trunk

2019-01-17 Thread wenson_hsieh
Title: [240139] trunk Revision 240139 Author wenson_hs...@apple.com Date 2019-01-17 20:15:24 -0800 (Thu, 17 Jan 2019) Log Message [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas https://bugs.webkit.org/show_bug.cgi?id=193494 Reviewed by

[webkit-changes] [240328] trunk/Source/WebCore

2019-01-22 Thread wenson_hsieh
Title: [240328] trunk/Source/WebCore Revision 240328 Author wenson_hs...@apple.com Date 2019-01-22 22:10:45 -0800 (Tue, 22 Jan 2019) Log Message Introduce CustomUndoStep.h and CustomUndoStep.cpp https://bugs.webkit.org/show_bug.cgi?id=193704 Reviewed by Ryosuke Niwa. This patch is

[webkit-changes] [239107] trunk/Source/WebCore

2018-12-12 Thread wenson_hsieh
Title: [239107] trunk/Source/WebCore Revision 239107 Author wenson_hs...@apple.com Date 2018-12-12 09:06:49 -0800 (Wed, 12 Dec 2018) Log Message [iOS] A few API tests are failing after r239086 https://bugs.webkit.org/show_bug.cgi?id=192608 Reviewed by Zalan Bujtas. These test failures

[webkit-changes] [239039] trunk

2018-12-10 Thread wenson_hsieh
Title: [239039] trunk Revision 239039 Author wenson_hs...@apple.com Date 2018-12-10 12:27:59 -0800 (Mon, 10 Dec 2018) Log Message [iOS] Caret is obscured by finger when dragging over an editable element https://bugs.webkit.org/show_bug.cgi?id=192499 Reviewed by Tim Horton.

[webkit-changes] [239184] trunk

2018-12-13 Thread wenson_hsieh
Title: [239184] trunk Revision 239184 Author wenson_hs...@apple.com Date 2018-12-13 15:25:20 -0800 (Thu, 13 Dec 2018) Log Message [iOS] Support dropping contact card data (public.vcard) in editable content https://bugs.webkit.org/show_bug.cgi?id=192570 Reviewed by Tim Horton.

[webkit-changes] [239314] trunk

2018-12-17 Thread wenson_hsieh
Title: [239314] trunk Revision 239314 Author wenson_hs...@apple.com Date 2018-12-17 20:04:44 -0800 (Mon, 17 Dec 2018) Log Message [iOS] Focusing a large editable element always scrolls to the top of the element https://bugs.webkit.org/show_bug.cgi?id=192745 Reviewed by Tim Horton.

[webkit-changes] [239318] trunk/Source/WebKit

2018-12-17 Thread wenson_hsieh
Title: [239318] trunk/Source/WebKit Revision 239318 Author wenson_hs...@apple.com Date 2018-12-17 21:23:10 -0800 (Mon, 17 Dec 2018) Log Message Unreviewed, fix the iOSMac engineering build again After r239311, `WebProcessProxy::fullKeyboardAccessEnabled` in `WebProcessProxyIOS.mm`

[webkit-changes] [239321] trunk/Source/WebKit

2018-12-17 Thread wenson_hsieh
Title: [239321] trunk/Source/WebKit Revision 239321 Author wenson_hs...@apple.com Date 2018-12-17 22:30:34 -0800 (Mon, 17 Dec 2018) Log Message Tap highlights should not be shown on iOSMac https://bugs.webkit.org/show_bug.cgi?id=192797 Reviewed by Tim Horton. WKWebViews in iOSMac

[webkit-changes] [239317] trunk/Source/WebKit

2018-12-17 Thread wenson_hsieh
Title: [239317] trunk/Source/WebKit Revision 239317 Author wenson_hs...@apple.com Date 2018-12-17 20:39:35 -0800 (Mon, 17 Dec 2018) Log Message Unreviewed, fix the iOSMac engineering build `generateRequestID()` is only invoked from code under `ENABLE(MEDIA_STREAM)`; move it under this

[webkit-changes] [239337] trunk

2018-12-18 Thread wenson_hsieh
Title: [239337] trunk Revision 239337 Author wenson_hs...@apple.com Date 2018-12-18 07:37:10 -0800 (Tue, 18 Dec 2018) Log Message Calling setValue() while typing should invoke -textDidChangeInTextField in the injected bundle https://bugs.webkit.org/show_bug.cgi?id=192785 Reviewed by

[webkit-changes] [239441] trunk

2018-12-20 Thread wenson_hsieh
Title: [239441] trunk Revision 239441 Author wenson_hs...@apple.com Date 2018-12-20 08:28:55 -0800 (Thu, 20 Dec 2018) Log Message [iOS] Focusing an editable element should scroll to reveal the selection https://bugs.webkit.org/show_bug.cgi?id=192802 Reviewed by Tim Horton.

[webkit-changes] [239482] trunk/LayoutTests

2018-12-20 Thread wenson_hsieh
Title: [239482] trunk/LayoutTests Revision 239482 Author wenson_hs...@apple.com Date 2018-12-20 17:32:14 -0800 (Thu, 20 Dec 2018) Log Message [iOS] Some layout tests are failing after r239441 https://bugs.webkit.org/show_bug.cgi?id=192957 Reviewed by Simon Fraser. Fix several failing

[webkit-changes] [239547] trunk/Source/WebKit

2018-12-23 Thread wenson_hsieh
Title: [239547] trunk/Source/WebKit Revision 239547 Author wenson_hs...@apple.com Date 2018-12-23 21:07:01 -0800 (Sun, 23 Dec 2018) Log Message [iOS] Remove some unnecessary editing SPI after https://bugs.webkit.org/show_bug.cgi?id=193019 Reviewed by Dan Bernstein. Remove these SPI

[webkit-changes] [239546] trunk/Source/WebKit

2018-12-23 Thread wenson_hsieh
Title: [239546] trunk/Source/WebKit Revision 239546 Author wenson_hs...@apple.com Date 2018-12-23 15:51:30 -0800 (Sun, 23 Dec 2018) Log Message Fix fast/ruby/ruby-base-merge-block-children-crash-2.html after r239543 https://bugs.webkit.org/show_bug.cgi?id=193015 Reviewed by Tim Horton.

[webkit-changes] [239543] trunk

2018-12-22 Thread wenson_hsieh
Title: [239543] trunk Revision 239543 Author wenson_hs...@apple.com Date 2018-12-22 22:38:24 -0800 (Sat, 22 Dec 2018) Log Message [iOS] Suppress native selection behaviors when focusing a very small editable element https://bugs.webkit.org/show_bug.cgi?id=193005 Reviewed by Tim Horton.

[webkit-changes] [239053] trunk

2018-12-10 Thread wenson_hsieh
Title: [239053] trunk Revision 239053 Author wenson_hs...@apple.com Date 2018-12-10 14:18:10 -0800 (Mon, 10 Dec 2018) Log Message [iOS] Unable to upload data that conforms to "public.item" but not "public.content" https://bugs.webkit.org/show_bug.cgi?id=192555 Reviewed by Tim Horton.

[webkit-changes] [239052] trunk/Source/WebKit

2018-12-10 Thread wenson_hsieh
Title: [239052] trunk/Source/WebKit Revision 239052 Author wenson_hs...@apple.com Date 2018-12-10 14:10:48 -0800 (Mon, 10 Dec 2018) Log Message Unreviewed, fix the iOS build after r239039. https://bugs.webkit.org/show_bug.cgi?id=192568 * UIProcess/ios/WKContentViewInteraction.mm:

[webkit-changes] [239086] trunk/Source/WebCore

2018-12-11 Thread wenson_hsieh
Title: [239086] trunk/Source/WebCore Revision 239086 Author wenson_hs...@apple.com Date 2018-12-11 13:13:32 -0800 (Tue, 11 Dec 2018) Log Message [iOS] Send the full list of file upload URLs and types in PasteboardItemInfo https://bugs.webkit.org/show_bug.cgi?id=192598 Work towards

[webkit-changes] [239511] trunk

2018-12-21 Thread wenson_hsieh
Title: [239511] trunk Revision 239511 Author wenson_hs...@apple.com Date 2018-12-21 11:40:41 -0800 (Fri, 21 Dec 2018) Log Message Setting the file wrapper and content type of an attachment to a PDF should update its image https://bugs.webkit.org/show_bug.cgi?id=192984 Reviewed by Tim

[webkit-changes] [238751] trunk

2018-11-30 Thread wenson_hsieh
Title: [238751] trunk Revision 238751 Author wenson_hs...@apple.com Date 2018-11-30 13:18:13 -0800 (Fri, 30 Nov 2018) Log Message Replace "auto fill" with "AutoFill" in some localizable strings https://bugs.webkit.org/show_bug.cgi?id=192233 Reviewed by Chris Fleizach. Source/WebCore:

[webkit-changes] [238661] trunk

2018-11-28 Thread wenson_hsieh
Title: [238661] trunk Revision 238661 Author wenson_hs...@apple.com Date 2018-11-28 21:25:07 -0800 (Wed, 28 Nov 2018) Log Message [iOSMac] Dropping text selections from web content into editable elements crashes the web process https://bugs.webkit.org/show_bug.cgi?id=192113 Reviewed by

[webkit-changes] [238954] trunk

2018-12-07 Thread wenson_hsieh
Title: [238954] trunk Revision 238954 Author wenson_hs...@apple.com Date 2018-12-07 10:37:58 -0800 (Fri, 07 Dec 2018) Log Message [Attachment Support] Cloned attachment elements lose their unique identifiers https://bugs.webkit.org/show_bug.cgi?id=192483 Reviewed by Tim Horton.

[webkit-changes] [238795] trunk

2018-12-03 Thread wenson_hsieh
Title: [238795] trunk Revision 238795 Author wenson_hs...@apple.com Date 2018-12-03 07:42:12 -0800 (Mon, 03 Dec 2018) Log Message [iOSMac] Unable to upload non-image files using drag and drop in WKWebView https://bugs.webkit.org/show_bug.cgi?id=192283 Reviewed by Ryosuke Niwa.

[webkit-changes] [238921] trunk/Tools

2018-12-05 Thread wenson_hsieh
Title: [238921] trunk/Tools Revision 238921 Author wenson_hs...@apple.com Date 2018-12-05 19:09:29 -0800 (Wed, 05 Dec 2018) Log Message [Cocoa] Share ClassMethodSwizzler and InstanceMethodSwizzler between TestWebKitAPI and WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=192437

[webkit-changes] [238939] trunk

2018-12-06 Thread wenson_hsieh
Title: [238939] trunk Revision 238939 Author wenson_hs...@apple.com Date 2018-12-06 13:22:19 -0800 (Thu, 06 Dec 2018) Log Message [iOS] WKWebView should match UITextView behavior when editing text with an RTL keyboard https://bugs.webkit.org/show_bug.cgi?id=187554 Reviewed by Tim

[webkit-changes] [239025] trunk/Tools

2018-12-09 Thread wenson_hsieh
Title: [239025] trunk/Tools Revision 239025 Author wenson_hs...@apple.com Date 2018-12-09 23:54:16 -0800 (Sun, 09 Dec 2018) Log Message [iOS] DragAndDropTests.RespectsExternalSourceFidelityRankings is flaky https://bugs.webkit.org/show_bug.cgi?id=192524 Reviewed by Ryosuke Niwa. This

[webkit-changes] [238728] trunk

2018-11-29 Thread wenson_hsieh
Title: [238728] trunk Revision 238728 Author wenson_hs...@apple.com Date 2018-11-29 23:22:00 -0800 (Thu, 29 Nov 2018) Log Message REGRESSION (r238635): Dragging a text selection within WKWebView causes the selection highlight to get into a bad state

[webkit-changes] [238894] trunk/Source

2018-12-05 Thread wenson_hsieh
Title: [238894] trunk/Source Revision 238894 Author wenson_hs...@apple.com Date 2018-12-05 09:51:03 -0800 (Wed, 05 Dec 2018) Log Message Turn WritingDirection into an enum class https://bugs.webkit.org/show_bug.cgi?id=192401 Work towards Reviewed by Dan Bernstein. Change

[webkit-changes] [238461] trunk

2018-11-23 Thread wenson_hsieh
Title: [238461] trunk Revision 238461 Author wenson_hs...@apple.com Date 2018-11-23 10:18:01 -0800 (Fri, 23 Nov 2018) Log Message Enable drag and drop support for iOSMac https://bugs.webkit.org/show_bug.cgi?id=191818 Reviewed by Dean Jackson. Source/_javascript_Core: *

[webkit-changes] [238471] trunk

2018-11-24 Thread wenson_hsieh
Title: [238471] trunk Revision 238471 Author wenson_hs...@apple.com Date 2018-11-24 13:06:09 -0800 (Sat, 24 Nov 2018) Log Message [Cocoa] Add WKWebView SPI to trigger and remove data detection https://bugs.webkit.org/show_bug.cgi?id=191918 Reviewed by Tim Horton. Source/WebCore: Add

[webkit-changes] [238473] trunk/Source

2018-11-24 Thread wenson_hsieh
Title: [238473] trunk/Source Revision 238473 Author wenson_hs...@apple.com Date 2018-11-24 17:45:54 -0800 (Sat, 24 Nov 2018) Log Message [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm https://bugs.webkit.org/show_bug.cgi?id=191945

[webkit-changes] [238380] trunk/Tools

2018-11-19 Thread wenson_hsieh
Title: [238380] trunk/Tools Revision 238380 Author wenson_hs...@apple.com Date 2018-11-19 13:37:00 -0800 (Mon, 19 Nov 2018) Log Message [iOS Debug] Assertion failure in NSComparisonResult UIContentSizeCategoryCompareToCategory() https://bugs.webkit.org/show_bug.cgi?id=190401 Reviewed

[webkit-changes] [238383] trunk/Tools

2018-11-19 Thread wenson_hsieh
Title: [238383] trunk/Tools Revision 238383 Author wenson_hs...@apple.com Date 2018-11-19 16:26:10 -0800 (Mon, 19 Nov 2018) Log Message Unreviewed, fix the internal iOS debug build after r238380 UICalloutBar should only be declared when the public (non-internal) SDK is used to build

[webkit-changes] [238485] trunk/Tools

2018-11-25 Thread wenson_hsieh
Title: [238485] trunk/Tools Revision 238485 Author wenson_hs...@apple.com Date 2018-11-25 14:59:07 -0800 (Sun, 25 Nov 2018) Log Message Unreviewed, fix the internal iOS 12 build after r238471 * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm: (TEST): Modified Paths

[webkit-changes] [238553] trunk/Source/WebKit

2018-11-27 Thread wenson_hsieh
Title: [238553] trunk/Source/WebKit Revision 238553 Author wenson_hs...@apple.com Date 2018-11-27 07:51:43 -0800 (Tue, 27 Nov 2018) Log Message WebKit.AddAndRemoveDataDetectors hits a debug assertion after r238515 https://bugs.webkit.org/show_bug.cgi?id=191996 Reviewed by Tim Horton.

[webkit-changes] [238584] trunk/Tools

2018-11-27 Thread wenson_hsieh
Title: [238584] trunk/Tools Revision 238584 Author wenson_hs...@apple.com Date 2018-11-27 15:54:06 -0800 (Tue, 27 Nov 2018) Log Message Unreviewed, fix the watchOS engineering build Disable a newly added API test, since DDScannerResult is unavailable on watchOS. *

[webkit-changes] [238438] trunk

2018-11-21 Thread wenson_hsieh
Title: [238438] trunk Revision 238438 Author wenson_hs...@apple.com Date 2018-11-21 21:03:59 -0800 (Wed, 21 Nov 2018) Log Message [Cocoa] [WebKit2] Add support for replacing find-in-page text matches https://bugs.webkit.org/show_bug.cgi?id=191786 Reviewed by Ryosuke Niwa.

[webkit-changes] [238454] trunk/Source

2018-11-22 Thread wenson_hsieh
Title: [238454] trunk/Source Revision 238454 Author wenson_hs...@apple.com Date 2018-11-22 19:10:34 -0800 (Thu, 22 Nov 2018) Log Message Address post-review feedback after r238438 https://bugs.webkit.org/show_bug.cgi?id=191913 Reviewed by Ryosuke Niwa. Source/WebCore: Replace `bool`

[webkit-changes] [238455] trunk/Source/WebKit

2018-11-22 Thread wenson_hsieh
Title: [238455] trunk/Source/WebKit Revision 238455 Author wenson_hs...@apple.com Date 2018-11-22 20:00:31 -0800 (Thu, 22 Nov 2018) Log Message [Cocoa] clang emits a warning when building WebKit after r238293 https://bugs.webkit.org/show_bug.cgi?id=191917 Reviewed by Dan Bernstein.

[webkit-changes] [238375] trunk

2018-11-19 Thread wenson_hsieh
Title: [238375] trunk Revision 238375 Author wenson_hs...@apple.com Date 2018-11-19 08:31:22 -0800 (Mon, 19 Nov 2018) Log Message Dragging image with a border-image larger than the image element crashes https://bugs.webkit.org/show_bug.cgi?id=191817 Reviewed by Ryosuke Niwa.

[webkit-changes] [238544] trunk

2018-11-26 Thread wenson_hsieh
Title: [238544] trunk Revision 238544 Author wenson_hs...@apple.com Date 2018-11-26 19:32:06 -0800 (Mon, 26 Nov 2018) Log Message [Cocoa] No way for clients to tell whether the content view is in the responder chain when the web view is https://bugs.webkit.org/show_bug.cgi?id=169212

[webkit-changes] [238507] trunk/Source/WebKit

2018-11-26 Thread wenson_hsieh
Title: [238507] trunk/Source/WebKit Revision 238507 Author wenson_hs...@apple.com Date 2018-11-26 11:55:30 -0800 (Mon, 26 Nov 2018) Log Message CompletionHandler-based async IPC messages only work when the completion handler takes a single argument

[webkit-changes] [238497] trunk/Source/WebKit

2018-11-26 Thread wenson_hsieh
Title: [238497] trunk/Source/WebKit Revision 238497 Author wenson_hs...@apple.com Date 2018-11-26 09:11:48 -0800 (Mon, 26 Nov 2018) Log Message Unreviewed, fix the internal 32-bit macOS 10.13 build after r238471 r238471 added an `#include WebPageMessages.h` in `WebPage.h`, which causes

[webkit-changes] [239750] trunk

2019-01-08 Thread wenson_hsieh
Title: [239750] trunk Revision 239750 Author wenson_hs...@apple.com Date 2019-01-08 16:10:24 -0800 (Tue, 08 Jan 2019) Log Message [iOS] Dispatch a synthetic mousedown event prior to starting drags https://bugs.webkit.org/show_bug.cgi?id=193229 Reviewed by Tim Horton. Source/WebCore:

[webkit-changes] [239685] trunk

2019-01-07 Thread wenson_hsieh
Title: [239685] trunk Revision 239685 Author wenson_hs...@apple.com Date 2019-01-07 10:50:39 -0800 (Mon, 07 Jan 2019) Log Message Native caret shows up alongside the page's caret when requesting desktop site on jsfiddle.net https://bugs.webkit.org/show_bug.cgi?id=193180 Reviewed by Tim

[webkit-changes] [239590] trunk

2019-01-03 Thread wenson_hsieh
Title: [239590] trunk Revision 239590 Author wenson_hs...@apple.com Date 2019-01-03 07:38:33 -0800 (Thu, 03 Jan 2019) Log Message [iOS] REGRESSION (r239441): Tab cycling to offscreen may not scroll it into view https://bugs.webkit.org/show_bug.cgi?id=193084 Reviewed by Simon Fraser.

[webkit-changes] [239589] trunk/Source/WebKit

2019-01-03 Thread wenson_hsieh
Title: [239589] trunk/Source/WebKit Revision 239589 Author wenson_hs...@apple.com Date 2019-01-03 07:34:34 -0800 (Thu, 03 Jan 2019) Log Message WebUndoStep's monotonically increasing identifier should be a WebUndoStepID instead of uint64_t https://bugs.webkit.org/show_bug.cgi?id=193100

[webkit-changes] [239627] trunk/Source

2019-01-04 Thread wenson_hsieh
Title: [239627] trunk/Source Revision 239627 Author wenson_hs...@apple.com Date 2019-01-04 11:56:51 -0800 (Fri, 04 Jan 2019) Log Message [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function https://bugs.webkit.org/show_bug.cgi?id=193129

[webkit-changes] [239842] trunk/Source/WebCore

2019-01-10 Thread wenson_hsieh
Title: [239842] trunk/Source/WebCore Revision 239842 Author wenson_hs...@apple.com Date 2019-01-10 13:46:30 -0800 (Thu, 10 Jan 2019) Log Message Bindings generator emits incorrect code when using VoidCallback as an IDL dictionary attribute https://bugs.webkit.org/show_bug.cgi?id=193328

[webkit-changes] [239864] trunk

2019-01-11 Thread wenson_hsieh
Title: [239864] trunk Revision 239864 Author wenson_hs...@apple.com Date 2019-01-11 10:28:06 -0800 (Fri, 11 Jan 2019) Log Message Introduce IDL files for runtime-enabled UndoManager and UndoItem _javascript_ API https://bugs.webkit.org/show_bug.cgi?id=193109 Reviewed by Ryosuke Niwa.

[webkit-changes] [239881] trunk

2019-01-11 Thread wenson_hsieh
Title: [239881] trunk Revision 239881 Author wenson_hs...@apple.com Date 2019-01-11 16:21:49 -0800 (Fri, 11 Jan 2019) Log Message [iOS] Precision drop state thrashes when dragging near the top edge of an editable element https://bugs.webkit.org/show_bug.cgi?id=193364 Reviewed by Tim

[webkit-changes] [239771] trunk/LayoutTests

2019-01-09 Thread wenson_hsieh
Title: [239771] trunk/LayoutTests Revision 239771 Author wenson_hs...@apple.com Date 2019-01-09 07:24:36 -0800 (Wed, 09 Jan 2019) Log Message [iOS] editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html often times out in internal automation

[webkit-changes] [239558] trunk/Source/WebKit

2018-12-28 Thread wenson_hsieh
Title: [239558] trunk/Source/WebKit Revision 239558 Author wenson_hs...@apple.com Date 2018-12-28 21:50:04 -0800 (Fri, 28 Dec 2018) Log Message Move WKEditCommandObjC and WKEditorUndoTargetObjC into a separate file https://bugs.webkit.org/show_bug.cgi?id=193049 Reviewed by Sam Weinig.

[webkit-changes] [239019] trunk/Source/WebKit

2018-12-09 Thread wenson_hsieh
Title: [239019] trunk/Source/WebKit Revision 239019 Author wenson_hs...@apple.com Date 2018-12-09 01:05:45 -0800 (Sun, 09 Dec 2018) Log Message [iOS device] Crash when attempting to call -[_WKAttachment info] for an editable image https://bugs.webkit.org/show_bug.cgi?id=192538 Reviewed

[webkit-changes] [239346] trunk/Source/WebKit

2018-12-18 Thread wenson_hsieh
Title: [239346] trunk/Source/WebKit Revision 239346 Author wenson_hs...@apple.com Date 2018-12-18 11:45:24 -0800 (Tue, 18 Dec 2018) Log Message Unreviewed, fix the 32-bit watchOS build after r239314 * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView

[webkit-changes] [239363] trunk/Source/WebKit

2018-12-18 Thread wenson_hsieh
Title: [239363] trunk/Source/WebKit Revision 239363 Author wenson_hs...@apple.com Date 2018-12-18 18:11:58 -0800 (Tue, 18 Dec 2018) Log Message [macOS] fast/forms/datalist/datalist-textinput-suggestions-order.html sometimes crashes after r239337

[webkit-changes] [239369] trunk

2018-12-18 Thread wenson_hsieh
Title: [239369] trunk Revision 239369 Author wenson_hs...@apple.com Date 2018-12-18 22:10:28 -0800 (Tue, 18 Dec 2018) Log Message [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages https://bugs.webkit.org/show_bug.cgi?id=192842 Reviewed by

[webkit-changes] [240452] trunk

2019-01-24 Thread wenson_hsieh
Title: [240452] trunk Revision 240452 Author wenson_hs...@apple.com Date 2019-01-24 15:30:37 -0800 (Thu, 24 Jan 2019) Log Message [iOS] Unable to make a selection in jsfiddle.net using arrow keys when requesting desktop site https://bugs.webkit.org/show_bug.cgi?id=193758 Reviewed by

[webkit-changes] [240539] trunk/Source/WebCore

2019-01-25 Thread wenson_hsieh
Title: [240539] trunk/Source/WebCore Revision 240539 Author wenson_hs...@apple.com Date 2019-01-25 19:38:57 -0800 (Fri, 25 Jan 2019) Log Message Document::updateMainArticleElementAfterLayout() should be a no-op when no client depends on knowing the main article element

[webkit-changes] [240556] trunk/Source/WebCore

2019-01-27 Thread wenson_hsieh
Title: [240556] trunk/Source/WebCore Revision 240556 Author wenson_hs...@apple.com Date 2019-01-27 15:51:29 -0800 (Sun, 27 Jan 2019) Log Message Remove a couple of PLATFORM defines intended for watchOS https://bugs.webkit.org/show_bug.cgi?id=193888 Reviewed by Alexey Proskuryakov.

[webkit-changes] [243753] trunk

2019-04-02 Thread wenson_hsieh
Title: [243753] trunk Revision 243753 Author wenson_hs...@apple.com Date 2019-04-02 12:46:30 -0700 (Tue, 02 Apr 2019) Log Message REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences] https://bugs.webkit.org/show_bug.cgi?id=196496 Reviewed by

[webkit-changes] [243787] trunk/Source/WebKit

2019-04-02 Thread wenson_hsieh
Title: [243787] trunk/Source/WebKit Revision 243787 Author wenson_hs...@apple.com Date 2019-04-02 21:58:04 -0700 (Tue, 02 Apr 2019) Log Message [Cocoa] Add new API around WKWebpagePreferences in WKNavigationDelegate and WKWebViewConfiguration

[webkit-changes] [243462] trunk/Tools

2019-03-25 Thread wenson_hsieh
Title: [243462] trunk/Tools Revision 243462 Author wenson_hs...@apple.com Date 2019-03-25 14:39:13 -0700 (Mon, 25 Mar 2019) Log Message Pull some API testing helper methods out of TestWKWebView https://bugs.webkit.org/show_bug.cgi?id=196212 Reviewed by Tim Horton. Refactor some more

[webkit-changes] [243797] trunk

2019-04-03 Thread wenson_hsieh
Title: [243797] trunk Revision 243797 Author wenson_hs...@apple.com Date 2019-04-03 08:02:07 -0700 (Wed, 03 Apr 2019) Log Message Add plumbing for a compatibility mode preference in WebKit https://bugs.webkit.org/show_bug.cgi?id=196005 Reviewed by Tim Horton. Source/WebKit: Add

[webkit-changes] [243800] trunk/Source/WebKit

2019-04-03 Thread wenson_hsieh
Title: [243800] trunk/Source/WebKit Revision 243800 Author wenson_hs...@apple.com Date 2019-04-03 09:02:06 -0700 (Wed, 03 Apr 2019) Log Message Add a WebKit internal feature flag to always enable modern compatibility mode by default https://bugs.webkit.org/show_bug.cgi?id=196526

[webkit-changes] [243798] trunk/Source

2019-04-03 Thread wenson_hsieh
Title: [243798] trunk/Source Revision 243798 Author wenson_hs...@apple.com Date 2019-04-03 08:22:10 -0700 (Wed, 03 Apr 2019) Log Message Introduce and add plumbing for a website policy for meta viewport tag handling https://bugs.webkit.org/show_bug.cgi?id=196285 Reviewed by Tim Horton.

[webkit-changes] [243836] trunk/Source/WebKit

2019-04-03 Thread wenson_hsieh
Title: [243836] trunk/Source/WebKit Revision 243836 Author wenson_hs...@apple.com Date 2019-04-03 16:30:15 -0700 (Wed, 03 Apr 2019) Log Message Add a WebKit internal feature flag to always enable modern compatibility mode by default https://bugs.webkit.org/show_bug.cgi?id=196526

[webkit-changes] [243909] trunk/Source/WebKit

2019-04-04 Thread wenson_hsieh
Title: [243909] trunk/Source/WebKit Revision 243909 Author wenson_hs...@apple.com Date 2019-04-04 14:56:38 -0700 (Thu, 04 Apr 2019) Log Message Changing default website policies shouldn't change default website policies in subsequent navigations

[webkit-changes] [243656] trunk

2019-03-29 Thread wenson_hsieh
Title: [243656] trunk Revision 243656 Author wenson_hs...@apple.com Date 2019-03-29 13:09:02 -0700 (Fri, 29 Mar 2019) Log Message REGRESSION (r243250): Text interactions are no longer suppressed when editing in some websites https://bugs.webkit.org/show_bug.cgi?id=196378 Reviewed by

[webkit-changes] [243519] trunk

2019-03-26 Thread wenson_hsieh
Title: [243519] trunk Revision 243519 Author wenson_hs...@apple.com Date 2019-03-26 14:15:16 -0700 (Tue, 26 Mar 2019) Log Message Implement async paste method on UIWKInteractionViewProtocol https://bugs.webkit.org/show_bug.cgi?id=196267 Reviewed by Tim Horton. Source/WebKit:

<    2   3   4   5   6   7   8   9   10   >