Title: [106522] trunk/Source/WebCore
- Revision
- 106522
- Author
- hara...@chromium.org
- Date
- 2012-02-01 18:27:18 -0800 (Wed, 01 Feb 2012)
Log Message
Remove [ObjCPrefix], [V8ConstructorTemplate], [allowAccessToNode],
[v8implname] and [v8referenceattr] from code generators
https://bugs.webkit.org/show_bug.cgi?id=77588
Reviewed by Adam Barth.
This patch removes [ObjCPrefix], [V8ConstructorTemplate], [allowAccessToNode],
[v8implname] and [v8referenceattr] from code generators, since they are not used
by any IDL files.
No tests. No changes in behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(IsConstructable):
(IsConstructorTemplate):
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (106521 => 106522)
--- trunk/Source/WebCore/ChangeLog 2012-02-02 02:19:01 UTC (rev 106521)
+++ trunk/Source/WebCore/ChangeLog 2012-02-02 02:27:18 UTC (rev 106522)
@@ -1,3 +1,28 @@
+2012-02-01 Kentaro Hara <hara...@chromium.org>
+
+ Remove [ObjCPrefix], [V8ConstructorTemplate], [allowAccessToNode],
+ [v8implname] and [v8referenceattr] from code generators
+ https://bugs.webkit.org/show_bug.cgi?id=77588
+
+ Reviewed by Adam Barth.
+
+ This patch removes [ObjCPrefix], [V8ConstructorTemplate], [allowAccessToNode],
+ [v8implname] and [v8referenceattr] from code generators, since they are not used
+ by any IDL files.
+
+ No tests. No changes in behavior.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateImplementation):
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ (GenerateHeader):
+ (GenerateImplementation):
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (IsConstructable):
+ (IsConstructorTemplate):
+ (GenerateNormalAttrGetter):
+ (GenerateFunctionCallString):
+
2012-02-01 Pablo Flouret <pab...@motorola.com>
Support targetOrigin = "/" in postMessage for sending messages to same origin as source document.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (106521 => 106522)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2012-02-02 02:19:01 UTC (rev 106521)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2012-02-02 02:27:18 UTC (rev 106522)
@@ -1711,10 +1711,6 @@
if ($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCCustom"} || $attribute->signature->extendedAttributes->{"CustomGetter"} || $attribute->signature->extendedAttributes->{"JSCCustomGetter"}) {
push(@implContent, " return castedThis->$implGetterFunctionName(exec);\n");
- } elsif ($attribute->signature->extendedAttributes->{"allowAccessToNode"}) {
- $implIncludes{"JSDOMBinding.h"} = 1;
- push(@implContent, " $implClassName* impl = static_cast<$implClassName*>(castedThis->impl());\n");
- push(@implContent, " return allowAccessToNode(exec, impl->$implGetterFunctionName()) ? " . NativeToJSValue($attribute->signature, 0, $implClassName, "impl->$implGetterFunctionName()", "castedThis") . " : jsUndefined();\n");
} elsif ($attribute->signature->extendedAttributes->{"CheckFrameSecurity"}) {
$implIncludes{"Document.h"} = 1;
$implIncludes{"JSDOMBinding.h"} = 1;
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm (106521 => 106522)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2012-02-02 02:19:01 UTC (rev 106521)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2012-02-02 02:27:18 UTC (rev 106522)
@@ -877,10 +877,8 @@
$typesToForwardDeclare{$param->type} = 1;
if ($parameterIndex >= 1) {
- my $paramPrefix = $param->extendedAttributes->{"ObjCPrefix"};
- $paramPrefix = $paramName unless defined($paramPrefix);
- $functionSig .= " $paramPrefix";
- $methodName .= $paramPrefix;
+ $functionSig .= " $paramName";
+ $methodName .= $paramName;
}
$functionSig .= ":($paramType)$paramName";
@@ -1504,9 +1502,7 @@
}
if ($parameterIndex >= 1) {
- my $paramPrefix = $param->extendedAttributes->{"ObjCPrefix"};
- $paramPrefix = $param->name unless defined($paramPrefix);
- $functionSig .= " $paramPrefix";
+ $functionSig .= " " . $param->name;
}
$functionSig .= ":($paramType)$paramName";
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (106521 => 106522)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-02-02 02:19:01 UTC (rev 106521)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-02-02 02:27:18 UTC (rev 106522)
@@ -705,7 +705,7 @@
{
my $dataNode = shift;
- return $dataNode->extendedAttributes->{"CustomConstructor"} || $dataNode->extendedAttributes->{"V8CustomConstructor"} || $dataNode->extendedAttributes->{"Constructor"} || $dataNode->extendedAttributes->{"V8ConstructorTemplate"} || $dataNode->extendedAttributes->{"ConstructorTemplate"};
+ return $dataNode->extendedAttributes->{"CustomConstructor"} || $dataNode->extendedAttributes->{"V8CustomConstructor"} || $dataNode->extendedAttributes->{"Constructor"} || $dataNode->extendedAttributes->{"ConstructorTemplate"};
}
sub IsConstructorTemplate
@@ -713,7 +713,7 @@
my $dataNode = shift;
my $template = shift;
- return ($dataNode->extendedAttributes->{"V8ConstructorTemplate"} && $dataNode->extendedAttributes->{"V8ConstructorTemplate"} eq $template) || ($dataNode->extendedAttributes->{"ConstructorTemplate"} && $dataNode->extendedAttributes->{"ConstructorTemplate"} eq $template);
+ return $dataNode->extendedAttributes->{"ConstructorTemplate"} && $dataNode->extendedAttributes->{"ConstructorTemplate"} eq $template;
}
sub GenerateDomainSafeFunctionGetter
@@ -865,9 +865,7 @@
}
# Generate security checks if necessary
- if ($attribute->signature->extendedAttributes->{"allowAccessToNode"}) {
- push(@implContentDecls, " if (!V8BindingSecurity::allowAccessToNode(V8BindingState::Only(), imp->$attrName()))\n return v8::Handle<v8::Value>();\n\n");
- } elsif ($attribute->signature->extendedAttributes->{"CheckFrameSecurity"}) {
+ if ($attribute->signature->extendedAttributes->{"CheckFrameSecurity"}) {
push(@implContentDecls, " if (!V8BindingSecurity::allowAccessToNode(V8BindingState::Only(), imp->contentDocument()))\n return v8::Handle<v8::Value>();\n\n");
}
@@ -877,10 +875,6 @@
push(@implContentDecls, " ExceptionCode ec = 0;\n");
}
- if ($attribute->signature->extendedAttributes->{"v8referenceattr"}) {
- $attrName = $attribute->signature->extendedAttributes->{"v8referenceattr"};
- }
-
my $returnType = GetTypeFromSignature($attribute->signature);
my $getterString;
my $callWith = $attribute->signature->extendedAttributes->{"CallWith"} || "";
@@ -3207,10 +3201,6 @@
my $isSVGTearOffType = ($codeGenerator->IsSVGTypeNeedingTearOff($returnType) and not $implClassName =~ /List$/);
$nativeReturnType = $codeGenerator->GetSVGWrappedTypeNeedingTearOff($returnType) if $isSVGTearOffType;
- if ($function->signature->extendedAttributes->{"v8implname"}) {
- $name = $function->signature->extendedAttributes->{"v8implname"};
- }
-
if ($function->signature->extendedAttributes->{"ImplementationFunction"}) {
$name = $function->signature->extendedAttributes->{"ImplementationFunction"};
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
