Title: [106532] trunk/Source/WebCore
- Revision
- 106532
- Author
- hara...@chromium.org
- Date
- 2012-02-01 22:24:28 -0800 (Wed, 01 Feb 2012)
Log Message
Remove [GenerateConstructor] from IDL files
https://bugs.webkit.org/show_bug.cgi?id=77598
Reviewed by Adam Barth.
[GenerateConstructor] is used in some IDL files but it is not implemented
in code generators. I could not find any history about [GenerateConstructor]
in code generators. This patch removes them from IDL files.
Maybe we want to replace [GenerateConstructor] with [Constructor] eventually,
but currently no tests are written for their constructors (e.g. "new DOMTokenList()").
So simply removing them would make sense.
No new tests. No change in behavior.
* dom/DOMStringList.idl:
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.idl:
* svg/SVGFEConvolveMatrixElement.idl:
* webaudio/AudioPannerNode.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (106531 => 106532)
--- trunk/Source/WebCore/ChangeLog 2012-02-02 05:10:31 UTC (rev 106531)
+++ trunk/Source/WebCore/ChangeLog 2012-02-02 06:24:28 UTC (rev 106532)
@@ -1,3 +1,26 @@
+2012-02-01 Kentaro Hara <hara...@chromium.org>
+
+ Remove [GenerateConstructor] from IDL files
+ https://bugs.webkit.org/show_bug.cgi?id=77598
+
+ Reviewed by Adam Barth.
+
+ [GenerateConstructor] is used in some IDL files but it is not implemented
+ in code generators. I could not find any history about [GenerateConstructor]
+ in code generators. This patch removes them from IDL files.
+
+ Maybe we want to replace [GenerateConstructor] with [Constructor] eventually,
+ but currently no tests are written for their constructors (e.g. "new DOMTokenList()").
+ So simply removing them would make sense.
+
+ No new tests. No change in behavior.
+
+ * dom/DOMStringList.idl:
+ * html/DOMSettableTokenList.idl:
+ * html/DOMTokenList.idl:
+ * svg/SVGFEConvolveMatrixElement.idl:
+ * webaudio/AudioPannerNode.idl:
+
2012-02-01 Eric Carlson <eric.carl...@apple.com>
Consider user's preferred language when choosing text tracks
Modified: trunk/Source/WebCore/dom/DOMStringList.idl (106531 => 106532)
--- trunk/Source/WebCore/dom/DOMStringList.idl 2012-02-02 05:10:31 UTC (rev 106531)
+++ trunk/Source/WebCore/dom/DOMStringList.idl 2012-02-02 06:24:28 UTC (rev 106532)
@@ -26,7 +26,6 @@
module core {
interface [
- GenerateConstructor,
HasIndexGetter
] DOMStringList {
readonly attribute unsigned long length;
Modified: trunk/Source/WebCore/html/DOMSettableTokenList.idl (106531 => 106532)
--- trunk/Source/WebCore/html/DOMSettableTokenList.idl 2012-02-02 05:10:31 UTC (rev 106531)
+++ trunk/Source/WebCore/html/DOMSettableTokenList.idl 2012-02-02 06:24:28 UTC (rev 106532)
@@ -25,7 +25,6 @@
module core {
interface [
- GenerateConstructor,
HasIndexGetter,
GenerateToJS
] DOMSettableTokenList : DOMTokenList {
Modified: trunk/Source/WebCore/html/DOMTokenList.idl (106531 => 106532)
--- trunk/Source/WebCore/html/DOMTokenList.idl 2012-02-02 05:10:31 UTC (rev 106531)
+++ trunk/Source/WebCore/html/DOMTokenList.idl 2012-02-02 06:24:28 UTC (rev 106532)
@@ -26,7 +26,6 @@
interface [
GenerateIsReachable=ImplElementRoot,
- GenerateConstructor,
HasIndexGetter
] DOMTokenList {
readonly attribute unsigned long length;
Modified: trunk/Source/WebCore/svg/SVGFEConvolveMatrixElement.idl (106531 => 106532)
--- trunk/Source/WebCore/svg/SVGFEConvolveMatrixElement.idl 2012-02-02 05:10:31 UTC (rev 106531)
+++ trunk/Source/WebCore/svg/SVGFEConvolveMatrixElement.idl 2012-02-02 06:24:28 UTC (rev 106532)
@@ -27,7 +27,6 @@
interface [
Conditional=SVG&FILTERS,
- GenerateConstructor,
DontCheckEnums
] SVGFEConvolveMatrixElement : SVGElement,
SVGFilterPrimitiveStandardAttributes {
Modified: trunk/Source/WebCore/webaudio/AudioPannerNode.idl (106531 => 106532)
--- trunk/Source/WebCore/webaudio/AudioPannerNode.idl 2012-02-02 05:10:31 UTC (rev 106531)
+++ trunk/Source/WebCore/webaudio/AudioPannerNode.idl 2012-02-02 06:24:28 UTC (rev 106532)
@@ -25,7 +25,6 @@
module audio {
interface [
Conditional=WEB_AUDIO,
- GenerateConstructor,
GenerateToJS
] AudioPannerNode : AudioNode {
// Panning model
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
