Title: [143502] trunk
Revision
143502
Author
k...@webkit.org
Date
2013-02-20 13:53:27 -0800 (Wed, 20 Feb 2013)

Log Message

[Chromium] Add runtime flag for CanvasPath
https://bugs.webkit.org/show_bug.cgi?id=109997

Reviewed by Adam Barth.

Source/WebCore:

Add runtime flag for Chromium.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setCanvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::canvasPathEnabled):
* html/canvas/DOMPath.idl:
* page/DOMWindow.idl:

Source/WebKit/chromium:

Add runtime flag for Chromium.

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableCanvasPath):
(WebKit):
(WebKit::WebRuntimeFeatures::isCanvasPathEnabled):

Tools:

Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
the constructor for Path on DOMWindow would never be activatable, since the script
is running after creating the DOMWindow object.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

Modified Paths

Diff

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (143501 => 143502)


--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-20 21:53:21 UTC (rev 143501)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-20 21:53:27 UTC (rev 143502)
@@ -4354,6 +4354,7 @@
 webkit.org/b/108508 platform/chromium/virtual/gpu/fast/canvas/canvas-path-constructors.html [ Failure ]
 webkit.org/b/108508 fast/canvas/canvas-path-object.html [ Failure ]
 webkit.org/b/108508 platform/chromium/virtual/gpu/fast/canvas/canvas-path-object.html [ Failure ]
+webkit.org/b/108508 inspector/profiler/canvas2d/canvas2d-api-changes.html [ Failure ]
 
 # This is won't fix, as the debug and release versions differ.
 

Modified: trunk/Source/WebCore/ChangeLog (143501 => 143502)


--- trunk/Source/WebCore/ChangeLog	2013-02-20 21:53:21 UTC (rev 143501)
+++ trunk/Source/WebCore/ChangeLog	2013-02-20 21:53:27 UTC (rev 143502)
@@ -1,3 +1,21 @@
+2013-02-15  Dirk Schulze  <k...@webkit.org>
+
+        [Chromium] Add runtime flag for CanvasPath
+        https://bugs.webkit.org/show_bug.cgi?id=109997
+
+        Reviewed by Adam Barth.
+
+        Add runtime flag for Chromium.
+
+        * bindings/generic/RuntimeEnabledFeatures.cpp:
+        (WebCore):
+        * bindings/generic/RuntimeEnabledFeatures.h:
+        (RuntimeEnabledFeatures):
+        (WebCore::RuntimeEnabledFeatures::setCanvasPathEnabled):
+        (WebCore::RuntimeEnabledFeatures::canvasPathEnabled):
+        * html/canvas/DOMPath.idl:
+        * page/DOMWindow.idl:
+
 2013-02-20  Laszlo Gombos  <l.gom...@samsung.com>
 
         Remove unnecessary includes for Platform.h from headers

Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (143501 => 143502)


--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp	2013-02-20 21:53:21 UTC (rev 143501)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp	2013-02-20 21:53:27 UTC (rev 143502)
@@ -54,6 +54,7 @@
 bool RuntimeEnabledFeatures::isDeviceMotionEnabled = true;
 bool RuntimeEnabledFeatures::isDeviceOrientationEnabled = true;
 bool RuntimeEnabledFeatures::isSpeechInputEnabled = true;
+bool RuntimeEnabledFeatures::isCanvasPathEnabled = false;
 bool RuntimeEnabledFeatures::isCSSExclusionsEnabled = false;
 bool RuntimeEnabledFeatures::isCSSRegionsEnabled = false;
 bool RuntimeEnabledFeatures::isLangAttributeAwareFormControlUIEnabled = false;

Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (143501 => 143502)


--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h	2013-02-20 21:53:21 UTC (rev 143501)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h	2013-02-20 21:53:27 UTC (rev 143502)
@@ -63,6 +63,14 @@
     static bool webkitIndexedDBEnabled() { return isIndexedDBEnabled; }
     static bool indexedDBEnabled() { return isIndexedDBEnabled; }
 
+#if ENABLE(CANVAS_PATH)
+    static void setCanvasPathEnabled(bool isEnabled) { isCanvasPathEnabled = isEnabled; }
+    static bool canvasPathEnabled() { return isCanvasPathEnabled; }
+#else
+    static void setCanvasPathEnabled(bool) { }
+    static bool canvasPathEnabled() { return false; }
+#endif
+
 #if ENABLE(CSS_EXCLUSIONS)
     static void setCSSExclusionsEnabled(bool isEnabled) { isCSSExclusionsEnabled = isEnabled; }
     static bool cssExclusionsEnabled() { return isCSSExclusionsEnabled; }
@@ -285,6 +293,7 @@
     static bool isDeviceMotionEnabled;
     static bool isDeviceOrientationEnabled;
     static bool isSpeechInputEnabled;
+    static bool isCanvasPathEnabled;
     static bool isCSSExclusionsEnabled;
     static bool isCSSRegionsEnabled;
     WEBCORE_TESTING static bool isLangAttributeAwareFormControlUIEnabled;

Modified: trunk/Source/WebCore/html/canvas/DOMPath.idl (143501 => 143502)


--- trunk/Source/WebCore/html/canvas/DOMPath.idl	2013-02-20 21:53:21 UTC (rev 143501)
+++ trunk/Source/WebCore/html/canvas/DOMPath.idl	2013-02-20 21:53:27 UTC (rev 143502)
@@ -27,6 +27,7 @@
  */
 
 interface [
+    V8EnabledAtRuntime=canvasPath,
     Constructor,
     Constructor(in DOMPath path),
 #if defined(ENABLE_SVG) && ENABLE_SVG

Modified: trunk/Source/WebCore/page/DOMWindow.idl (143501 => 143502)


--- trunk/Source/WebCore/page/DOMWindow.idl	2013-02-20 21:53:21 UTC (rev 143501)
+++ trunk/Source/WebCore/page/DOMWindow.idl	2013-02-20 21:53:27 UTC (rev 143502)
@@ -397,7 +397,7 @@
     attribute NotationConstructor Notation;
     attribute EntityConstructor Entity;
     attribute EntityReferenceConstructor EntityReference;
-    [Conditional=CANVAS_PATH] attribute DOMPathConstructor Path;
+    [Conditional=CANVAS_PATH, V8EnabledAtRuntime=canvasPath] attribute DOMPathConstructor Path;
     attribute ProcessingInstructionConstructor ProcessingInstruction;
     [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] attribute ShadowRootConstructor WebKitShadowRoot;
     [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] attribute HTMLContentElementConstructor HTMLContentElement;

Modified: trunk/Source/WebKit/chromium/ChangeLog (143501 => 143502)


--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-20 21:53:21 UTC (rev 143501)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-20 21:53:27 UTC (rev 143502)
@@ -1,3 +1,19 @@
+2013-02-15  Dirk Schulze  <k...@webkit.org>
+
+        [Chromium] Add runtime flag for CanvasPath
+        https://bugs.webkit.org/show_bug.cgi?id=109997
+
+        Reviewed by Adam Barth.
+
+        Add runtime flag for Chromium.
+
+        * public/WebRuntimeFeatures.h:
+        (WebRuntimeFeatures):
+        * src/WebRuntimeFeatures.cpp:
+        (WebKit::WebRuntimeFeatures::enableCanvasPath):
+        (WebKit):
+        (WebKit::WebRuntimeFeatures::isCanvasPathEnabled):
+
 2013-02-20  Mark Pilgrim  <pilg...@chromium.org>
 
         [Chromium] Move WebKitPlatformSupport declaration to Platform.h

Modified: trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h (143501 => 143502)


--- trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h	2013-02-20 21:53:21 UTC (rev 143501)
+++ trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h	2013-02-20 21:53:27 UTC (rev 143502)
@@ -149,6 +149,9 @@
     WEBKIT_EXPORT static void enableDialogElement(bool);
     WEBKIT_EXPORT static bool isDialogElementEnabled();
 
+    WEBKIT_EXPORT static void enableCanvasPath(bool);
+    WEBKIT_EXPORT static bool isCanvasPathEnabled();
+    
     WEBKIT_EXPORT static void enableCSSExclusions(bool);
     WEBKIT_EXPORT static bool isCSSExclusionsEnabled();
 

Modified: trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp (143501 => 143502)


--- trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp	2013-02-20 21:53:21 UTC (rev 143501)
+++ trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp	2013-02-20 21:53:27 UTC (rev 143502)
@@ -661,6 +661,16 @@
 #endif
 }
 
+void WebRuntimeFeatures::enableCanvasPath(bool enable)
+{
+    RuntimeEnabledFeatures::setCanvasPathEnabled(enable);
+}
+
+bool WebRuntimeFeatures::isCanvasPathEnabled()
+{
+    return RuntimeEnabledFeatures::canvasPathEnabled();
+}
+
 void WebRuntimeFeatures::enableCSSExclusions(bool enable)
 {
     RuntimeEnabledFeatures::setCSSExclusionsEnabled(enable);

Modified: trunk/Tools/ChangeLog (143501 => 143502)


--- trunk/Tools/ChangeLog	2013-02-20 21:53:21 UTC (rev 143501)
+++ trunk/Tools/ChangeLog	2013-02-20 21:53:27 UTC (rev 143502)
@@ -1,3 +1,17 @@
+2013-02-15  Dirk Schulze  <k...@webkit.org>
+
+        [Chromium] Add runtime flag for CanvasPath
+        https://bugs.webkit.org/show_bug.cgi?id=109997
+
+        Reviewed by Adam Barth.
+
+        Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
+        the constructor for Path on DOMWindow would never be activatable, since the script
+        is running after creating the DOMWindow object.
+
+        * DumpRenderTree/chromium/TestShell.cpp:
+        (TestShell::TestShell):
+
 2013-02-20  Jochen Eisinger  <joc...@chromium.org>
 
         [chromium] use a WebTestProxyBase pointer to identify the window we need the history for

Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (143501 => 143502)


--- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2013-02-20 21:53:21 UTC (rev 143501)
+++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2013-02-20 21:53:27 UTC (rev 143502)
@@ -150,6 +150,7 @@
     WebRuntimeFeatures::enableRequestAutocomplete(true);
     WebRuntimeFeatures::enableExperimentalContentSecurityPolicyFeatures(true);
     WebRuntimeFeatures::enableSeamlessIFrames(true);
+    WebRuntimeFeatures::enableCanvasPath(true);
 
     // 30 second is the same as the value in Mac DRT.
     // If we use a value smaller than the timeout value of
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to