Title: [155018] trunk/Source/WebCore
- Revision
- 155018
- Author
- akl...@apple.com
- Date
- 2013-09-03 21:49:23 -0700 (Tue, 03 Sep 2013)
Log Message
ASSERTION FAILED: frame().view() == this closing a page with SVG or video
<https://webkit.org/b/120645>
Reviewed by Antti Koivisto.
Have RenderSVGResourceContainer check if the document is being destroyed before
triggering any repaints. This replaces the previous check for a null RenderView
which meant basically the same thing.
We could add more and better assertions to catch unnecessary work during tree
teardown, but let's do that separately.
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::markClientForInvalidation):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (155017 => 155018)
--- trunk/Source/WebCore/ChangeLog 2013-09-04 04:27:57 UTC (rev 155017)
+++ trunk/Source/WebCore/ChangeLog 2013-09-04 04:49:23 UTC (rev 155018)
@@ -1,3 +1,20 @@
+2013-09-03 Andreas Kling <akl...@apple.com>
+
+ ASSERTION FAILED: frame().view() == this closing a page with SVG or video
+ <https://webkit.org/b/120645>
+
+ Reviewed by Antti Koivisto.
+
+ Have RenderSVGResourceContainer check if the document is being destroyed before
+ triggering any repaints. This replaces the previous check for a null RenderView
+ which meant basically the same thing.
+
+ We could add more and better assertions to catch unnecessary work during tree
+ teardown, but let's do that separately.
+
+ * rendering/svg/RenderSVGResourceContainer.cpp:
+ (WebCore::RenderSVGResourceContainer::markClientForInvalidation):
+
2013-09-03 Gyuyoung Kim <gyuyoung....@samsung.com>
Fix uninitialized build warning in make_names.pl
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp (155017 => 155018)
--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp 2013-09-04 04:27:57 UTC (rev 155017)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp 2013-09-04 04:49:23 UTC (rev 155018)
@@ -139,7 +139,8 @@
client->setNeedsBoundariesUpdate();
break;
case RepaintInvalidation:
- client->repaint();
+ if (!client->documentBeingDestroyed())
+ client->repaint();
break;
case ParentOnlyInvalidation:
break;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
