Title: [159745] trunk/Source/WebCore
- Revision
- 159745
- Author
- stav...@adobe.com
- Date
- 2013-11-25 04:14:52 -0800 (Mon, 25 Nov 2013)
Log Message
Removed obsolete FIXME after the landing of visual overflow patch (https://bugs.webkit.org/show_bug.cgi?id=118665).
https://bugs.webkit.org/show_bug.cgi?id=124833
Reviewed by Mihnea Ovidenie.
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layoutBlock):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (159744 => 159745)
--- trunk/Source/WebCore/ChangeLog 2013-11-25 11:36:11 UTC (rev 159744)
+++ trunk/Source/WebCore/ChangeLog 2013-11-25 12:14:52 UTC (rev 159745)
@@ -1,3 +1,13 @@
+2013-11-25 Radu Stavila <stav...@adobe.com>
+
+ Removed obsolete FIXME after the landing of visual overflow patch (https://bugs.webkit.org/show_bug.cgi?id=118665).
+ https://bugs.webkit.org/show_bug.cgi?id=124833
+
+ Reviewed by Mihnea Ovidenie.
+
+ * rendering/RenderRegion.cpp:
+ (WebCore::RenderRegion::layoutBlock):
+
2013-11-18 Sergio Villar Senin <svil...@igalia.com>
[CSS Grid Layout] Cache several vectors to avoid malloc/free churn
Modified: trunk/Source/WebCore/rendering/RenderRegion.cpp (159744 => 159745)
--- trunk/Source/WebCore/rendering/RenderRegion.cpp 2013-11-25 11:36:11 UTC (rev 159744)
+++ trunk/Source/WebCore/rendering/RenderRegion.cpp 2013-11-25 12:14:52 UTC (rev 159745)
@@ -324,17 +324,6 @@
// This can happen even if we are in the inConstrainedLayoutPhase and it will trigger a pathological layout of the flow thread.
m_flowThread->invalidateRegions();
}
-
- // FIXME: We need to find a way to set up overflow properly. Our flow thread hasn't gotten a layout
- // yet, so we can't look to it for correct information. It's possible we could wait until after the RenderFlowThread
- // gets a layout, and then try to propagate overflow information back to the region, and then mark for a second layout.
- // That second layout would then be able to use the information from the RenderFlowThread to set up overflow.
- //
- // The big problem though is that overflow needs to be region-specific. We can't simply use the RenderFlowThread's global
- // overflow values, since then we'd always think any narrow region had huge overflow (all the way to the width of the
- // RenderFlowThread itself).
- //
- // We'll need to expand RenderBoxRegionInfo to also hold left and right overflow values.
}
void RenderRegion::computeOverflowFromFlowThread()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
