Title: [166260] trunk/Tools
- Revision
- 166260
- Author
- aes...@apple.com
- Date
- 2014-03-25 15:20:02 -0700 (Tue, 25 Mar 2014)
Log Message
Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
* TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
(-[DownloadDelegate _download:didReceiveResponse:]):
(-[DownloadDelegate _download:didReceiveData:]):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (166259 => 166260)
--- trunk/Tools/ChangeLog 2014-03-25 22:01:25 UTC (rev 166259)
+++ trunk/Tools/ChangeLog 2014-03-25 22:20:02 UTC (rev 166260)
@@ -1,5 +1,13 @@
2014-03-25 Andy Estes <aes...@apple.com>
+ Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
+
+ * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
+ (-[DownloadDelegate _download:didReceiveResponse:]):
+ (-[DownloadDelegate _download:didReceiveData:]):
+
+2014-03-25 Andy Estes <aes...@apple.com>
+
Add some debug logging to an API test that's failing on Mountain Lion.
* TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm (166259 => 166260)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm 2014-03-25 22:01:25 UTC (rev 166259)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm 2014-03-25 22:20:02 UTC (rev 166260)
@@ -78,17 +78,16 @@
- (void)_download:(_WKDownload *)download didReceiveResponse:(NSURLResponse *)response
{
- NSLog(@"[response sourceURL]: %@\n", [response URL]);
- NSLog(@"[self sourceURL]: %@\n", [self sourceURL]);
EXPECT_EQ(_download, download);
EXPECT_TRUE(_expectedContentLength == 0);
EXPECT_TRUE(_receivedContentLength == 0);
- EXPECT_TRUE([[response URL] isEqual:[self sourceURL]]);
+ EXPECT_TRUE([[[response URL] path] isEqualToString:[[self sourceURL] path]]);
_expectedContentLength = [response expectedContentLength];
}
- (void)_download:(_WKDownload *)download didReceiveData:(uint64_t)length
{
+ NSLog(@"didReceiveData: %llu\n", length);
EXPECT_EQ(_download, download);
_receivedContentLength += length;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
