Title: [175382] trunk/Source/WTF
- Revision
- 175382
- Author
- jp...@apple.com
- Date
- 2014-10-30 14:35:03 -0700 (Thu, 30 Oct 2014)
Log Message
ASSERT(!m_deletionHasBegun) in RefCounted.h should be ASSERT_WITH_SECURITY_IMPLICATION
https://bugs.webkit.org/show_bug.cgi?id=138141
Reviewed by Alexey Proskuryakov.
* wtf/RefCounted.h:
(WTF::RefCountedBase::ref):
(WTF::RefCountedBase::relaxAdoptionRequirement):
(WTF::RefCountedBase::derefBase):
(WTF::adopted):
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (175381 => 175382)
--- trunk/Source/WTF/ChangeLog 2014-10-30 21:30:19 UTC (rev 175381)
+++ trunk/Source/WTF/ChangeLog 2014-10-30 21:35:03 UTC (rev 175382)
@@ -1,3 +1,16 @@
+2014-10-30 Jeffrey Pfau <jp...@apple.com>
+
+ ASSERT(!m_deletionHasBegun) in RefCounted.h should be ASSERT_WITH_SECURITY_IMPLICATION
+ https://bugs.webkit.org/show_bug.cgi?id=138141
+
+ Reviewed by Alexey Proskuryakov.
+
+ * wtf/RefCounted.h:
+ (WTF::RefCountedBase::ref):
+ (WTF::RefCountedBase::relaxAdoptionRequirement):
+ (WTF::RefCountedBase::derefBase):
+ (WTF::adopted):
+
2014-10-28 Milan Crha <mc...@redhat.com>
Use constants from wtf/MathExtras.h
Modified: trunk/Source/WTF/wtf/RefCounted.h (175381 => 175382)
--- trunk/Source/WTF/wtf/RefCounted.h 2014-10-30 21:30:19 UTC (rev 175381)
+++ trunk/Source/WTF/wtf/RefCounted.h 2014-10-30 21:35:03 UTC (rev 175382)
@@ -27,7 +27,7 @@
namespace WTF {
-#ifdef NDEBUG
+#if defined(NDEBUG) && !defined(ADDRESS_SANITIZER)
#define CHECK_REF_COUNTED_LIFECYCLE 0
#else
#define CHECK_REF_COUNTED_LIFECYCLE 1
@@ -41,7 +41,7 @@
void ref()
{
#if CHECK_REF_COUNTED_LIFECYCLE
- ASSERT(!m_deletionHasBegun);
+ ASSERT_WITH_SECURITY_IMPLICATION(!m_deletionHasBegun);
ASSERT(!m_adoptionIsRequired);
#endif
++m_refCount;
@@ -63,7 +63,7 @@
void relaxAdoptionRequirement()
{
#if CHECK_REF_COUNTED_LIFECYCLE
- ASSERT(!m_deletionHasBegun);
+ ASSERT_WITH_SECURITY_IMPLICATION(!m_deletionHasBegun);
ASSERT(m_adoptionIsRequired);
m_adoptionIsRequired = false;
#endif
@@ -91,7 +91,7 @@
bool derefBase()
{
#if CHECK_REF_COUNTED_LIFECYCLE
- ASSERT(!m_deletionHasBegun);
+ ASSERT_WITH_SECURITY_IMPLICATION(!m_deletionHasBegun);
ASSERT(!m_adoptionIsRequired);
#endif
@@ -132,7 +132,7 @@
{
if (!object)
return;
- ASSERT(!object->m_deletionHasBegun);
+ ASSERT_WITH_SECURITY_IMPLICATION(!object->m_deletionHasBegun);
object->m_adoptionIsRequired = false;
}
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
