Title: [178676] trunk/Source/WebKit/mac
- Revision
- 178676
- Author
- bda...@apple.com
- Date
- 2015-01-19 15:24:38 -0800 (Mon, 19 Jan 2015)
Log Message
REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is
offset by flipped-ness
https://bugs.webkit.org/show_bug.cgi?id=140643
-and corresponding-
rdar://problem/19489593
Reviewed by Tim Horton.
We universally flipped because we assumed that the root view was flipped and the
WebView was not. However, in Dictionary, the WebView is flipped! So this patch
fixes that assumption by checking the WebView’s flipped-ness.
* WebView/WebView.mm:
(-[WebView _convertRectFromRootView:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (178675 => 178676)
--- trunk/Source/WebKit/mac/ChangeLog 2015-01-19 23:09:36 UTC (rev 178675)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-01-19 23:24:38 UTC (rev 178676)
@@ -1,3 +1,19 @@
+2015-01-19 Beth Dakin <bda...@apple.com>
+
+ REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is
+ offset by flipped-ness
+ https://bugs.webkit.org/show_bug.cgi?id=140643
+ -and corresponding-
+ rdar://problem/19489593
+
+ Reviewed by Tim Horton.
+
+ We universally flipped because we assumed that the root view was flipped and the
+ WebView was not. However, in Dictionary, the WebView is flipped! So this patch
+ fixes that assumption by checking the WebView’s flipped-ness.
+ * WebView/WebView.mm:
+ (-[WebView _convertRectFromRootView:]):
+
2015-01-19 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r178653.
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (178675 => 178676)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2015-01-19 23:09:36 UTC (rev 178675)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2015-01-19 23:24:38 UTC (rev 178676)
@@ -8572,6 +8572,8 @@
- (NSRect)_convertRectFromRootView:(NSRect)rect
{
+ if (self.isFlipped)
+ return rect;
return NSMakeRect(rect.origin.x, [self bounds].size.height - rect.origin.y - rect.size.height, rect.size.width, rect.size.height);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
