Title: [180133] trunk/Source/WebCore
- Revision
- 180133
- Author
- s...@apple.com
- Date
- 2015-02-15 18:21:43 -0800 (Sun, 15 Feb 2015)
Log Message
Web Inspector: remove unused XHR replay code
https://bugs.webkit.org/show_bug.cgi?id=141622
Patch by Brian J. Burg <b...@cs.washington.edu> on 2015-02-15
Reviewed by Timothy Hatcher.
XHR Replay functionality became unused with the last frontend rewrite.
Remove instrumentation and data storage classes only used by this feature.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::documentThreadableLoaderStartedLoadingForClientImpl): Deleted.
(WebCore::InspectorInstrumentation::willLoadXHRImpl): Deleted.
(WebCore::InspectorInstrumentation::didFailXHRLoadingImpl): Deleted.
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::documentThreadableLoaderStartedLoadingForClient): Deleted.
(WebCore::InspectorInstrumentation::willLoadXHR): Deleted.
(WebCore::InspectorInstrumentation::didFailXHRLoading): Deleted.
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::didFinishXHRLoading):
(WebCore::InspectorResourceAgent::documentThreadableLoaderStartedLoadingForClient): Deleted.
(WebCore::InspectorResourceAgent::willLoadXHR): Deleted.
(WebCore::InspectorResourceAgent::didFailXHRLoading): Deleted.
(WebCore::InspectorResourceAgent::replayXHR): Deleted.
* inspector/InspectorResourceAgent.h:
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::clear):
(WebCore::XHRReplayData::create): Deleted.
(WebCore::XHRReplayData::XHRReplayData): Deleted.
(WebCore::NetworkResourcesData::xhrReplayData): Deleted.
(WebCore::NetworkResourcesData::setXHRReplayData): Deleted.
(WebCore::NetworkResourcesData::reuseXHRReplayData): Deleted.
* inspector/NetworkResourcesData.h:
(WebCore::XHRReplayData::method): Deleted.
(WebCore::XHRReplayData::url): Deleted.
(WebCore::XHRReplayData::async): Deleted.
(WebCore::XHRReplayData::formData): Deleted.
(WebCore::XHRReplayData::headers): Deleted.
(WebCore::XHRReplayData::includeCredentials): Deleted.
(WebCore::NetworkResourcesData::ResourceData::xhrReplayData): Deleted.
(WebCore::NetworkResourcesData::ResourceData::setXHRReplayData): Deleted.
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::internalAbort):
(WebCore::XMLHttpRequest::sendForInspectorXHRReplay): Deleted.
* xml/XMLHttpRequest.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (180132 => 180133)
--- trunk/Source/WebCore/ChangeLog 2015-02-16 02:17:38 UTC (rev 180132)
+++ trunk/Source/WebCore/ChangeLog 2015-02-16 02:21:43 UTC (rev 180133)
@@ -53,6 +53,18 @@
Crash when accessing an item in SVGTransformList and then removing a previous item from this list.
https://bugs.webkit.org/show_bug.cgi?id=141550.
+ Reviewed by David Kilzer.
+
+ * svg/properties/SVGMatrixTearOff.h:
+ (WebCore::SVGMatrixTearOff::create): Fix a compilation error on the release build.
+ The ASSERT() here references a parameter which is not used anywhere else. We need
+ to change it to ASSERT_UNUSED().
+
+2015-02-15 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ Crash when accessing an item in SVGTransformList and then removing a previous item from this list.
+ https://bugs.webkit.org/show_bug.cgi?id=141550.
+
Reviewed by Darin Adler.
Tests: LayoutTests/svg/dom/SVGTransformList-basics.xhtml: This test is modified to
Modified: trunk/Source/WebCore/svg/properties/SVGMatrixTearOff.h (180132 => 180133)
--- trunk/Source/WebCore/svg/properties/SVGMatrixTearOff.h 2015-02-16 02:17:38 UTC (rev 180132)
+++ trunk/Source/WebCore/svg/properties/SVGMatrixTearOff.h 2015-02-16 02:21:43 UTC (rev 180133)
@@ -32,7 +32,7 @@
// (for example: SVGTransform::matrix).
static Ref<SVGMatrixTearOff> create(SVGPropertyTearOff<SVGTransform>& parent, SVGMatrix& value)
{
- ASSERT(&parent.propertyReference().svgMatrix() == &value);
+ ASSERT_UNUSED(value, &parent.propertyReference().svgMatrix() == &value);
Ref<SVGMatrixTearOff> result = adoptRef(*new SVGMatrixTearOff(&parent));
parent.addChild(result->m_weakFactory.createWeakPtr());
return result;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
