Title: [180634] trunk/Source/WebCore
- Revision
- 180634
- Author
- bda...@apple.com
- Date
- 2015-02-25 12:54:35 -0800 (Wed, 25 Feb 2015)
Log Message
REGRESSION (r180018 ): Holding a rubber-band in place can get stuck
https://bugs.webkit.org/show_bug.cgi?id=142020
-and corresponding-
rdar://problem/19945216
Reviewed by Tom Horton.
It was a mistaken assumption that it was necessary to return false in the zero-
delta case. That is clearly conceptually wrong since false represents the DOM
doing something special with the event, which is clearly not the case if we never
even send the event to the DOM. Returning true will allow the rest of the
scrolling machinery the ability to handle the event.
* dom/Element.cpp:
(WebCore::Element::dispatchWheelEvent):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (180633 => 180634)
--- trunk/Source/WebCore/ChangeLog 2015-02-25 20:42:28 UTC (rev 180633)
+++ trunk/Source/WebCore/ChangeLog 2015-02-25 20:54:35 UTC (rev 180634)
@@ -1,3 +1,20 @@
+2015-02-25 Beth Dakin <bda...@apple.com>
+
+ REGRESSION (r180018 ): Holding a rubber-band in place can get stuck
+ https://bugs.webkit.org/show_bug.cgi?id=142020
+ -and corresponding-
+ rdar://problem/19945216
+
+ Reviewed by Tom Horton.
+
+ It was a mistaken assumption that it was necessary to return false in the zero-
+ delta case. That is clearly conceptually wrong since false represents the DOM
+ doing something special with the event, which is clearly not the case if we never
+ even send the event to the DOM. Returning true will allow the rest of the
+ scrolling machinery the ability to handle the event.
+ * dom/Element.cpp:
+ (WebCore::Element::dispatchWheelEvent):
+
2015-02-25 Ryosuke Niwa <rn...@webkit.org>
HTMLElement::collectStyleForPresentationAttribute duplicates a lot of code for contentEditableAttr
Modified: trunk/Source/WebCore/dom/Element.cpp (180633 => 180634)
--- trunk/Source/WebCore/dom/Element.cpp 2015-02-25 20:42:28 UTC (rev 180633)
+++ trunk/Source/WebCore/dom/Element.cpp 2015-02-25 20:54:35 UTC (rev 180634)
@@ -280,7 +280,7 @@
bool Element::dispatchWheelEvent(const PlatformWheelEvent& event)
{
if (!event.deltaX() && !event.deltaY())
- return false;
+ return true;
RefPtr<WheelEvent> wheelEvent = WheelEvent::create(event, document().defaultView());
return EventDispatcher::dispatchEvent(this, wheelEvent) && !wheelEvent->defaultHandled();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
