Title: [183654] trunk/Source/WebCore
Revision
183654
Author
bda...@apple.com
Date
2015-04-30 16:35:26 -0700 (Thu, 30 Apr 2015)

Log Message

Remove invalid assertion from MouseEvent::create()
https://bugs.webkit.org/show_bug.cgi?id=144477

Reviewed by Tim Horton.

mouseforcechanged events and mouseforcewillbegin trigger this assertion. The 
assertion does not seem valuable, so rather than changing it, just remove it.
* dom/MouseEvent.cpp:
(WebCore::MouseEvent::create):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (183653 => 183654)


--- trunk/Source/WebCore/ChangeLog	2015-04-30 23:26:11 UTC (rev 183653)
+++ trunk/Source/WebCore/ChangeLog	2015-04-30 23:35:26 UTC (rev 183654)
@@ -1,3 +1,15 @@
+2015-04-30  Beth Dakin  <bda...@apple.com>
+
+        Remove invalid assertion from MouseEvent::create()
+        https://bugs.webkit.org/show_bug.cgi?id=144477
+
+        Reviewed by Tim Horton.
+
+        mouseforcechanged events and mouseforcewillbegin trigger this assertion. The 
+        assertion does not seem valuable, so rather than changing it, just remove it.
+        * dom/MouseEvent.cpp:
+        (WebCore::MouseEvent::create):
+
 2015-04-30  Dean Jackson  <d...@apple.com>
 
         -apple-system-font-monospaced-numbers doesn't work on iOS

Modified: trunk/Source/WebCore/dom/MouseEvent.cpp (183653 => 183654)


--- trunk/Source/WebCore/dom/MouseEvent.cpp	2015-04-30 23:26:11 UTC (rev 183653)
+++ trunk/Source/WebCore/dom/MouseEvent.cpp	2015-04-30 23:35:26 UTC (rev 183654)
@@ -54,8 +54,6 @@
 
 Ref<MouseEvent> MouseEvent::create(const AtomicString& eventType, PassRefPtr<AbstractView> view, const PlatformMouseEvent& event, int detail, PassRefPtr<Node> relatedTarget)
 {
-    ASSERT(event.type() == PlatformEvent::MouseMoved || event.button() != NoButton);
-
     bool isMouseEnterOrLeave = eventType == eventNames().mouseenterEvent || eventType == eventNames().mouseleaveEvent;
     bool isCancelable = eventType != eventNames().mousemoveEvent && !isMouseEnterOrLeave;
     bool canBubble = !isMouseEnterOrLeave;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to