Title: [184028] trunk/Source/WebKit2
Revision
184028
Author
bda...@apple.com
Date
2015-05-08 16:18:21 -0700 (Fri, 08 May 2015)

Log Message

Shuffle touch-related code to keep the internal builds working
https://bugs.webkit.org/show_bug.cgi?id=144812

Reviewed by Benjamin Poulain.

* Shared/NativeWebTouchEvent.h:
* Shared/WebEvent.h:
* Shared/WebEventConversion.cpp:
* Shared/ios/NativeWebTouchEventIOS.mm:
(WebKit::NativeWebTouchEvent::extractWebTouchPoint):
(WebKit::extractWebTouchPoint): Deleted.
* Shared/ios/WebPlatformTouchPointIOS.cpp:

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (184027 => 184028)


--- trunk/Source/WebKit2/ChangeLog	2015-05-08 23:15:09 UTC (rev 184027)
+++ trunk/Source/WebKit2/ChangeLog	2015-05-08 23:18:21 UTC (rev 184028)
@@ -1,3 +1,18 @@
+2015-05-08  Beth Dakin  <bda...@apple.com>
+
+        Shuffle touch-related code to keep the internal builds working
+        https://bugs.webkit.org/show_bug.cgi?id=144812
+
+        Reviewed by Benjamin Poulain.
+
+        * Shared/NativeWebTouchEvent.h:
+        * Shared/WebEvent.h:
+        * Shared/WebEventConversion.cpp:
+        * Shared/ios/NativeWebTouchEventIOS.mm:
+        (WebKit::NativeWebTouchEvent::extractWebTouchPoint):
+        (WebKit::extractWebTouchPoint): Deleted.
+        * Shared/ios/WebPlatformTouchPointIOS.cpp:
+
 2015-05-08  Dan Bernstein  <m...@apple.com>
 
         <rdar://problem/20757196> NSInternalInconsistencyException raised in -[NSString encodeWithCoder:] beneath createEncodedObject when using WKRemoteObjectEncoder for Safari AutoFill

Modified: trunk/Source/WebKit2/Shared/NativeWebTouchEvent.h (184027 => 184028)


--- trunk/Source/WebKit2/Shared/NativeWebTouchEvent.h	2015-05-08 23:15:09 UTC (rev 184027)
+++ trunk/Source/WebKit2/Shared/NativeWebTouchEvent.h	2015-05-08 23:18:21 UTC (rev 184028)
@@ -56,6 +56,10 @@
 #endif
 
 private:
+#if PLATFORM(IOS)
+    Vector<WebPlatformTouchPoint> extractWebTouchPoint(const _UIWebTouchEvent*);
+#endif
+
 #if PLATFORM(GTK)
     GUniquePtr<GdkEvent> m_nativeEvent;
 #elif PLATFORM(EFL)

Modified: trunk/Source/WebKit2/Shared/WebEvent.h (184027 => 184028)


--- trunk/Source/WebKit2/Shared/WebEvent.h	2015-05-08 23:15:09 UTC (rev 184027)
+++ trunk/Source/WebKit2/Shared/WebEvent.h	2015-05-08 23:18:21 UTC (rev 184028)
@@ -299,6 +299,10 @@
     TouchPointState phase() const { return static_cast<TouchPointState>(m_phase); }
     TouchPointState state() const { return phase(); }
 
+#if ENABLE(IOS_TOUCH_EVENTS)
+#include <WebKitAdditions/WebEventIOS.h>
+#endif
+
     void encode(IPC::ArgumentEncoder&) const;
     static bool decode(IPC::ArgumentDecoder&, WebPlatformTouchPoint&);
 

Modified: trunk/Source/WebKit2/Shared/WebEventConversion.cpp (184027 => 184028)


--- trunk/Source/WebKit2/Shared/WebEventConversion.cpp	2015-05-08 23:15:09 UTC (rev 184027)
+++ trunk/Source/WebKit2/Shared/WebEventConversion.cpp	2015-05-08 23:18:21 UTC (rev 184028)
@@ -238,6 +238,9 @@
     }
 }
 
+#if ENABLE(IOS_TOUCH_EVENTS)
+#include <WebKitAdditions/WebEventConversionIOS.cpp>
+#else
 class WebKit2PlatformTouchPoint : public WebCore::PlatformTouchPoint {
 public:
 WebKit2PlatformTouchPoint(const WebPlatformTouchPoint& webTouchPoint)
@@ -245,6 +248,8 @@
 {
 }
 };
+#endif // ENABLE(IOS_TOUCH_EVENTS)
+
 #else
 
 class WebKit2PlatformTouchPoint : public WebCore::PlatformTouchPoint {

Modified: trunk/Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm (184027 => 184028)


--- trunk/Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm	2015-05-08 23:15:09 UTC (rev 184027)
+++ trunk/Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm	2015-05-08 23:18:21 UTC (rev 184028)
@@ -75,7 +75,10 @@
     return WebCore::IntPoint(position);
 }
 
-static inline Vector<WebPlatformTouchPoint> extractWebTouchPoint(const _UIWebTouchEvent* event)
+#if ENABLE(IOS_TOUCH_EVENTS)
+#import <WebKitAdditions/NativeWebTouchEventIOS.mm>
+#else
+Vector<WebPlatformTouchPoint> NativeWebTouchEvent::extractWebTouchPoint(const _UIWebTouchEvent* event)
 {
     unsigned touchCount = event->touchPointCount;
 
@@ -90,6 +93,7 @@
     }
     return touchPointList;
 }
+#endif
 
 NativeWebTouchEvent::NativeWebTouchEvent(const _UIWebTouchEvent* event)
     : WebTouchEvent(webEventTypeForUIWebTouchEventType(event->type), static_cast<Modifiers>(0), event->timestamp, extractWebTouchPoint(event), positionForCGPoint(event->locationInDocumentCoordinates), event->inJavaScriptGesture, event->scale, event->rotation)

Modified: trunk/Source/WebKit2/Shared/ios/WebPlatformTouchPointIOS.cpp (184027 => 184028)


--- trunk/Source/WebKit2/Shared/ios/WebPlatformTouchPointIOS.cpp	2015-05-08 23:15:09 UTC (rev 184027)
+++ trunk/Source/WebKit2/Shared/ios/WebPlatformTouchPointIOS.cpp	2015-05-08 23:18:21 UTC (rev 184028)
@@ -35,6 +35,9 @@
 
 namespace WebKit {
 
+#if ENABLE(IOS_TOUCH_EVENTS)
+#import <WebKitAdditions/WebPlatformTouchPointIOS.cpp>
+#else
 void WebPlatformTouchPoint::encode(IPC::ArgumentEncoder& encoder) const
 {
     encoder << m_identifier;
@@ -52,6 +55,7 @@
         return false;
     return true;
 }
+#endif // ENABLE(IOS_TOUCH_EVENTS)
 
 } // namespace WebKit
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to