Title: [184790] trunk/Source/WebKit2
- Revision
- 184790
- Author
- bda...@apple.com
- Date
- 2015-05-22 13:23:33 -0700 (Fri, 22 May 2015)
Log Message
Yellow highlight and DD popover don't go away when scrolling an iframe
https://bugs.webkit.org/show_bug.cgi?id=145312
-and corresponding-
rdar://problem/19692334
Reviewed by Tim Horton.
Match what Lookup already does for their popover and dismiss our popovers on
scroll.
* UIProcess/API/mac/WKView.mm:
(-[WKView scrollWheel:]):
This should not be needed anymore.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::pageDidScroll):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (184789 => 184790)
--- trunk/Source/WebKit2/ChangeLog 2015-05-22 20:00:52 UTC (rev 184789)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-22 20:23:33 UTC (rev 184790)
@@ -1,3 +1,21 @@
+2015-05-22 Beth Dakin <bda...@apple.com>
+
+ Yellow highlight and DD popover don't go away when scrolling an iframe
+ https://bugs.webkit.org/show_bug.cgi?id=145312
+ -and corresponding-
+ rdar://problem/19692334
+
+ Reviewed by Tim Horton.
+
+ Match what Lookup already does for their popover and dismiss our popovers on
+ scroll.
+ * UIProcess/API/mac/WKView.mm:
+ (-[WKView scrollWheel:]):
+
+ This should not be needed anymore.
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::pageDidScroll):
+
2015-05-22 Tim Horton <timothy_hor...@apple.com>
Remove action menu support
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (184789 => 184790)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-05-22 20:00:52 UTC (rev 184789)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-05-22 20:23:33 UTC (rev 184790)
@@ -1335,6 +1335,9 @@
if (_data->_ignoresAllEvents)
return;
+ if (event.phase == NSEventPhaseBegan)
+ [self _dismissContentRelativeChildWindowsWithAnimation:NO];
+
if (_data->_allowsBackForwardNavigationGestures) {
[self _ensureGestureController];
if (_data->_gestureController->handleScrollWheelEvent(event))
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (184789 => 184790)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2015-05-22 20:00:52 UTC (rev 184789)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2015-05-22 20:23:33 UTC (rev 184790)
@@ -3705,9 +3705,6 @@
void WebPageProxy::pageDidScroll()
{
m_uiClient->pageDidScroll(this);
-#if PLATFORM(MAC)
- m_pageClient.dismissContentRelativeChildWindows(false);
-#endif
}
void WebPageProxy::runOpenPanel(uint64_t frameID, const FileChooserSettings& settings)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
