Title: [186522] trunk/Source/WebKit2
- Revision
- 186522
- Author
- bda...@apple.com
- Date
- 2015-07-08 13:20:09 -0700 (Wed, 08 Jul 2015)
Log Message
InteractionInformationAtPosition bounds seem wrong on many sites, affects
apple.com
https://bugs.webkit.org/show_bug.cgi?id=146736
-and corresponding-
rdar://problem/21655549
Reviewed by Tim Horton.
http://trac.webkit.org/changeset/186132/ changed the bounds for
InteractionInformationAtPosition. The image-related changes are good, but the
link-related changes feel wrong on many sites. We should revert the change for now
and just use the absoluteBoundingBoxRect() for non-images.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186521 => 186522)
--- trunk/Source/WebKit2/ChangeLog 2015-07-08 20:09:50 UTC (rev 186521)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-08 20:20:09 UTC (rev 186522)
@@ -1,5 +1,22 @@
2015-07-08 Beth Dakin <bda...@apple.com>
+ InteractionInformationAtPosition bounds seem wrong on many sites, affects
+ apple.com
+ https://bugs.webkit.org/show_bug.cgi?id=146736
+ -and corresponding-
+ rdar://problem/21655549
+
+ Reviewed by Tim Horton.
+
+ http://trac.webkit.org/changeset/186132/ changed the bounds for
+ InteractionInformationAtPosition. The image-related changes are good, but the
+ link-related changes feel wrong on many sites. We should revert the change for now
+ and just use the absoluteBoundingBoxRect() for non-images.
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::getPositionInformation):
+
+2015-07-08 Beth Dakin <bda...@apple.com>
+
Add actions to image previews
https://bugs.webkit.org/show_bug.cgi?id=146702
-and corresponding-
Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (186521 => 186522)
--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2015-07-08 20:09:50 UTC (rev 186521)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2015-07-08 20:20:09 UTC (rev 186522)
@@ -2164,15 +2164,7 @@
if (element->renderer())
info.touchCalloutEnabled = element->renderer()->style().touchCalloutEnabled();
- if (element == linkElement) {
- RefPtr<Range> linkRange = rangeOfContents(*linkElement);
- Vector<FloatQuad> quads;
- linkRange->textQuads(quads);
- FloatRect linkBoundingBox;
- for (const auto& quad : quads)
- linkBoundingBox.unite(quad.enclosingBoundingBox());
- info.bounds = IntRect(linkBoundingBox);
- } else if (RenderElement* renderer = element->renderer()) {
+ if (RenderElement* renderer = element->renderer()) {
if (renderer->isRenderImage())
info.bounds = downcast<RenderImage>(*renderer).absoluteContentQuad().enclosingBoundingBox();
else
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
