Title: [187753] trunk/Source/WebKit2
Revision
187753
Author
cdu...@apple.com
Date
2015-08-03 12:35:55 -0700 (Mon, 03 Aug 2015)

Log Message

[WK2][NetworkCache] Do not munmap() on the main thread
https://bugs.webkit.org/show_bug.cgi?id=147569

Reviewed by Geoffrey Garen.

Do not munmap() on the main thread for performance reasons and
consistency as we already make sure to mmap() on another thread.

* NetworkProcess/cache/NetworkCacheDataCocoa.mm:
(WebKit::NetworkCache::Data::adoptMap):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (187752 => 187753)


--- trunk/Source/WebKit2/ChangeLog	2015-08-03 19:35:38 UTC (rev 187752)
+++ trunk/Source/WebKit2/ChangeLog	2015-08-03 19:35:55 UTC (rev 187753)
@@ -1,3 +1,16 @@
+2015-08-03  Chris Dumez  <cdu...@apple.com>
+
+        [WK2][NetworkCache] Do not munmap() on the main thread
+        https://bugs.webkit.org/show_bug.cgi?id=147569
+
+        Reviewed by Geoffrey Garen.
+
+        Do not munmap() on the main thread for performance reasons and
+        consistency as we already make sure to mmap() on another thread.
+
+        * NetworkProcess/cache/NetworkCacheDataCocoa.mm:
+        (WebKit::NetworkCache::Data::adoptMap):
+
 2015-08-03  Wenson Hsieh  <wenson_hs...@apple.com>
 
         Inputs with the autofocus attribute cause the keyboard to not deploy

Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheDataCocoa.mm (187752 => 187753)


--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheDataCocoa.mm	2015-08-03 19:35:38 UTC (rev 187752)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheDataCocoa.mm	2015-08-03 19:35:55 UTC (rev 187753)
@@ -98,7 +98,7 @@
 {
     ASSERT(map && map != MAP_FAILED);
     close(fd);
-    auto bodyMap = adoptDispatch(dispatch_data_create(map, size, dispatch_get_main_queue(), [map, size] {
+    auto bodyMap = adoptDispatch(dispatch_data_create(map, size, dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), [map, size] {
         munmap(map, size);
     }));
     return { bodyMap, Data::Backing::Map };
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to