Title: [187789] branches/safari-601.1-branch/Source/WebKit2
Revision
187789
Author
matthew_han...@apple.com
Date
2015-08-03 17:19:35 -0700 (Mon, 03 Aug 2015)

Log Message

Merge r187751. rdar://problem/22018044

Modified Paths

Diff

Modified: branches/safari-601.1-branch/Source/WebKit2/ChangeLog (187788 => 187789)


--- branches/safari-601.1-branch/Source/WebKit2/ChangeLog	2015-08-04 00:19:33 UTC (rev 187788)
+++ branches/safari-601.1-branch/Source/WebKit2/ChangeLog	2015-08-04 00:19:35 UTC (rev 187789)
@@ -1,3 +1,28 @@
+2015-08-03  Matthew Hanson  <matthew_han...@apple.com>
+
+        Merge r187751. rdar://problem/22018044
+
+    2015-08-03  Wenson Hsieh  <wenson_hs...@apple.com>
+
+            Inputs with the autofocus attribute cause the keyboard to not deploy
+            https://bugs.webkit.org/show_bug.cgi?id=147555
+            <rdar://problem/22018044>
+
+            Reviewed by Andreas Kling.
+
+            Upon submitting a form by pressing "Go" on the keyboard, an <input> on the next page with the
+            autofocus attribute may become non-interactible. When attempting to tap on the input, nothing
+            seems to happen. This is because the state of WebPage upon invoking WebPage::elementDidFocus
+            indicates (incorrectly) that the input element is already focused, and therefore hits an early
+            return. To solve this, we explicitly reset m_hasFocusedDueToUserInteraction upon transitioning
+            to a new page.
+
+            * WebProcess/WebPage/WebPage.cpp:
+            (WebKit::WebPage::didStartPageTransition): On iOS, resets m_hasFocusedDueToUserInteraction as
+                well. It was previously thought that this would be handled by blur() called on the assisted
+                element when submitting a form. However, pressing "Go" on the iOS keyboard is an implicit
+                submission and does not trigger a blur event.
+
 2015-07-31  Matthew Hanson  <matthew_han...@apple.com>
 
         Merge r187614. rdar://problem/22064327

Modified: branches/safari-601.1-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (187788 => 187789)


--- branches/safari-601.1-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2015-08-04 00:19:33 UTC (rev 187788)
+++ branches/safari-601.1-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2015-08-04 00:19:35 UTC (rev 187789)
@@ -2426,6 +2426,9 @@
 void WebPage::didStartPageTransition()
 {
     m_drawingArea->setLayerTreeStateIsFrozen(true);
+#if PLATFORM(IOS)
+    m_hasFocusedDueToUserInteraction = false;
+#endif
 }
 
 void WebPage::didCompletePageTransition()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to