Title: [187934] trunk
- Revision
- 187934
- Author
- commit-qu...@webkit.org
- Date
- 2015-08-04 20:33:18 -0700 (Tue, 04 Aug 2015)
Log Message
[EFL] Editing tests have been broken since r186694
https://bugs.webkit.org/show_bug.cgi?id=146888
Patch by Hunseop Jeong <hs85.je...@samsung.com> on 2015-08-04
Reviewed by Brent Fulgham.
Tools:
Restored some codes for the context click on GTK+ and EFL port.
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
LayoutTests:
Unskip the failure tests related with r186694.
* platform/efl/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (187933 => 187934)
--- trunk/LayoutTests/ChangeLog 2015-08-05 03:29:10 UTC (rev 187933)
+++ trunk/LayoutTests/ChangeLog 2015-08-05 03:33:18 UTC (rev 187934)
@@ -1,3 +1,14 @@
+2015-08-04 Hunseop Jeong <hs85.je...@samsung.com>
+
+ [EFL] Editing tests have been broken since r186694
+ https://bugs.webkit.org/show_bug.cgi?id=146888
+
+ Reviewed by Brent Fulgham.
+
+ Unskip the failure tests related with r186694.
+
+ * platform/efl/TestExpectations:
+
2015-08-04 Alexey Proskuryakov <a...@apple.com>
El Capitan test result gardening.
Modified: trunk/LayoutTests/platform/efl/TestExpectations (187933 => 187934)
--- trunk/LayoutTests/platform/efl/TestExpectations 2015-08-05 03:29:10 UTC (rev 187933)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2015-08-05 03:33:18 UTC (rev 187934)
@@ -2251,9 +2251,3 @@
webkit.org/b/146887 accessibility/table-fallback-roles-expose-element-attributes.html [ Failure ]
webkit.org/b/146887 accessibility/table-with-footer-section-above-body.html [ Failure ]
webkit.org/b/146887 accessibility/table-with-missing-aria-role-rows.html [ Failure ]
-
-webkit.org/b/146888 editing/selection/5354455-1.html [ Failure ]
-webkit.org/b/146888 editing/selection/5354455-2.html [ Failure ]
-webkit.org/b/146888 editing/spelling/context-menu-suggestions-multiword-selection.html [ Failure ]
-webkit.org/b/146888 editing/spelling/context-menu-suggestions-subword-selection.html [ Failure ]
-webkit.org/b/146888 editing/spelling/context-menu-suggestions.html [ Failure ]
Modified: trunk/Tools/ChangeLog (187933 => 187934)
--- trunk/Tools/ChangeLog 2015-08-05 03:29:10 UTC (rev 187933)
+++ trunk/Tools/ChangeLog 2015-08-05 03:33:18 UTC (rev 187934)
@@ -1,3 +1,15 @@
+2015-08-04 Hunseop Jeong <hs85.je...@samsung.com>
+
+ [EFL] Editing tests have been broken since r186694
+ https://bugs.webkit.org/show_bug.cgi?id=146888
+
+ Reviewed by Brent Fulgham.
+
+ Restored some codes for the context click on GTK+ and EFL port.
+
+ * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
+ (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
+
2015-08-04 Dewei Zhu <dewei_...@apple.com>
Install twisted package for http server when necessary.
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp (187933 => 187934)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp 2015-08-05 03:29:10 UTC (rev 187933)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp 2015-08-05 03:33:18 UTC (rev 187934)
@@ -475,7 +475,14 @@
WKBundleFrameRef mainFrame = WKBundlePageGetMainFrame(page);
JSContextRef context = WKBundleFrameGetJavaScriptContext(mainFrame);
#if ENABLE(CONTEXT_MENUS)
+#if PLATFORM(GTK) || PLATFORM(EFL)
+ // Do mouse context click.
+ mouseDown(2, 0);
+ mouseUp(2, 0);
+ WKRetainPtr<WKArrayRef> menuEntries = adoptWK(WKBundlePageCopyContextMenuItems(page));
+#else
WKRetainPtr<WKArrayRef> menuEntries = adoptWK(WKBundlePageCopyContextMenuAtPointInWindow(page, m_position));
+#endif
JSValueRef arrayResult = JSObjectMakeArray(context, 0, 0, 0);
JSObjectRef arrayObj = JSValueToObject(context, arrayResult, 0);
size_t entriesSize = WKArrayGetSize(menuEntries.get());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
