Title: [188401] trunk/Source/_javascript_Core
- Revision
- 188401
- Author
- gga...@apple.com
- Date
- 2015-08-13 14:06:46 -0700 (Thu, 13 Aug 2015)
Log Message
Periodic code deletion should delete RegExp code
https://bugs.webkit.org/show_bug.cgi?id=147990
Reviewed by Filip Pizlo.
The RegExp code cache was created for the sake of simple loops that
re-created the same RegExps. It's reasonable to delete it periodically.
* heap/Heap.cpp:
(JSC::Heap::deleteOldCode):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (188400 => 188401)
--- trunk/Source/_javascript_Core/ChangeLog 2015-08-13 20:42:11 UTC (rev 188400)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-08-13 21:06:46 UTC (rev 188401)
@@ -1,5 +1,18 @@
2015-08-13 Geoffrey Garen <gga...@apple.com>
+ Periodic code deletion should delete RegExp code
+ https://bugs.webkit.org/show_bug.cgi?id=147990
+
+ Reviewed by Filip Pizlo.
+
+ The RegExp code cache was created for the sake of simple loops that
+ re-created the same RegExps. It's reasonable to delete it periodically.
+
+ * heap/Heap.cpp:
+ (JSC::Heap::deleteOldCode):
+
+2015-08-13 Geoffrey Garen <gga...@apple.com>
+
RegExpCache::finalize should not delete code
https://bugs.webkit.org/show_bug.cgi?id=147987
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (188400 => 188401)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2015-08-13 20:42:11 UTC (rev 188400)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2015-08-13 21:06:46 UTC (rev 188401)
@@ -43,6 +43,7 @@
#include "JSCInlines.h"
#include "JSVirtualMachineInternal.h"
#include "RecursiveAllocationScope.h"
+#include "RegExpCache.h"
#include "Tracing.h"
#include "TypeProfilerLog.h"
#include "UnlinkedCodeBlock.h"
@@ -1143,6 +1144,7 @@
GCPHASE(DeleteOldCode);
if (gcStartTime - m_lastCodeDiscardTime > minute) {
+ m_vm->regExpCache()->deleteAllCode();
deleteAllCompiledCode();
m_lastCodeDiscardTime = WTF::monotonicallyIncreasingTime();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
