Title: [188635] trunk/Source/WebInspectorUI
Revision
188635
Author
nvasil...@apple.com
Date
2015-08-19 00:11:36 -0700 (Wed, 19 Aug 2015)

Log Message

REGRESSION (r188581): Web Inspector: Option-Enter no longer inserts a new line in the console
https://bugs.webkit.org/show_bug.cgi?id=148165

Make Option-Enter insert a new line, as it was before r188581.
Make Command-Enter keep executed command in the prompt.

Reviewed by Timothy Hatcher.

* UserInterface/Views/ConsolePrompt.js:
(WebInspector.ConsolePrompt): Deleted.
(WebInspector.ConsolePrompt.prototype._handleCommandEnterKey):
(WebInspector.ConsolePrompt.prototype._handleOptionEnterKey): Deleted.
(WebInspector.ConsolePrompt.prototype._handleCommandOptionEnterKey): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (188634 => 188635)


--- trunk/Source/WebInspectorUI/ChangeLog	2015-08-19 06:23:41 UTC (rev 188634)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-08-19 07:11:36 UTC (rev 188635)
@@ -1,3 +1,19 @@
+2015-08-19  Nikita Vasilyev  <nvasil...@apple.com>
+
+        REGRESSION (r188581): Web Inspector: Option-Enter no longer inserts a new line in the console
+        https://bugs.webkit.org/show_bug.cgi?id=148165
+
+        Make Option-Enter insert a new line, as it was before r188581.
+        Make Command-Enter keep executed command in the prompt.
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/ConsolePrompt.js:
+        (WebInspector.ConsolePrompt): Deleted.
+        (WebInspector.ConsolePrompt.prototype._handleCommandEnterKey):
+        (WebInspector.ConsolePrompt.prototype._handleOptionEnterKey): Deleted.
+        (WebInspector.ConsolePrompt.prototype._handleCommandOptionEnterKey): Deleted.
+
 2015-08-18  Joseph Pecoraro  <pecor...@apple.com>
 
         Web Inspector: Links for rules in <style> are incorrect, do not account for <style> offset in the document

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsolePrompt.js (188634 => 188635)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsolePrompt.js	2015-08-19 06:23:41 UTC (rev 188634)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsolePrompt.js	2015-08-19 07:11:36 UTC (rev 188635)
@@ -51,8 +51,6 @@
             "Ctrl-N": this._handleNextKey.bind(this),
             "Enter": this._handleEnterKey.bind(this),
             "Cmd-Enter": this._handleCommandEnterKey.bind(this),
-            "Alt-Enter": this._handleOptionEnterKey.bind(this),
-            "Cmd-Alt-Enter": this._handleCommandOptionEnterKey.bind(this),
             "Tab": this._handleTabKey.bind(this),
             "Esc": this._handleEscapeKey.bind(this)
         };
@@ -304,16 +302,6 @@
 
     _handleCommandEnterKey(codeMirror)
     {
-        this._handleEnterKey(codeMirror, true);
-    }
-
-    _handleOptionEnterKey(codeMirror)
-    {
-        this._handleEnterKey(codeMirror, false, true);
-    }
-
-    _handleCommandOptionEnterKey(codeMirror)
-    {
         this._handleEnterKey(codeMirror, true, true);
     }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to