Title: [188861] trunk/Source/WebInspectorUI
- Revision
- 188861
- Author
- mattba...@apple.com
- Date
- 2015-08-24 08:55:40 -0700 (Mon, 24 Aug 2015)
Log Message
Web Inspector: Rendering Frames filter checkboxes all become checked during recording
https://bugs.webkit.org/show_bug.cgi?id=148375
Reviewed by Timothy Hatcher.
* UserInterface/Views/ChartDetailsSectionRow.js:
(WebInspector.ChartDetailsSectionRow.prototype._createLegend):
Removed incorrect code that forced checked to true.
* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart):
Persist legend item checkbox state when updating the chart.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (188860 => 188861)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-24 15:23:21 UTC (rev 188860)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-24 15:55:40 UTC (rev 188861)
@@ -1,3 +1,18 @@
+2015-08-24 Matt Baker <mattba...@apple.com>
+
+ Web Inspector: Rendering Frames filter checkboxes all become checked during recording
+ https://bugs.webkit.org/show_bug.cgi?id=148375
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ChartDetailsSectionRow.js:
+ (WebInspector.ChartDetailsSectionRow.prototype._createLegend):
+ Removed incorrect code that forced checked to true.
+
+ * UserInterface/Views/TimelineSidebarPanel.js:
+ (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart):
+ Persist legend item checkbox state when updating the chart.
+
2015-08-23 Matt Baker <mattba...@apple.com>
Web Inspector: Filtered style not applied to graph elements during timeline recording
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js (188860 => 188861)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js 2015-08-24 15:23:21 UTC (rev 188860)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js 2015-08-24 15:55:40 UTC (rev 188861)
@@ -181,7 +181,7 @@
keyElement = document.createElement("input");
keyElement.type = "checkbox";
keyElement.classList.add(className);
- keyElement.checked = item.checked || true;
+ keyElement.checked = item.checked;
keyElement[WebInspector.ChartDetailsSectionRow.DataItemIdSymbol] = item.id;
keyElement.addEventListener("change", this._legendItemCheckboxValueChanged.bind(this));
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js (188860 => 188861)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js 2015-08-24 15:23:21 UTC (rev 188860)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js 2015-08-24 15:55:40 UTC (rev 188861)
@@ -896,11 +896,13 @@
var chart = this._frameSelectionChartRow;
var records = getSelectedRecords.call(this);
var chartData = Object.keys(WebInspector.RenderingFrameTimelineRecord.TaskType).map(function(taskTypeKey) {
- var taskType = WebInspector.RenderingFrameTimelineRecord.TaskType[taskTypeKey];
- var label = WebInspector.RenderingFrameTimelineRecord.displayNameForTaskType(taskType);
- var value = records.reduce(function(previousValue, currentValue) { return previousValue + currentValue.durationForTask(taskType); }, 0);
- var color = this._chartColors.get(taskType);
- return {id: taskType, label, value, color, checkbox: taskType !== WebInspector.RenderingFrameTimelineRecord.TaskType.Other};
+ let taskType = WebInspector.RenderingFrameTimelineRecord.TaskType[taskTypeKey];
+ let label = WebInspector.RenderingFrameTimelineRecord.displayNameForTaskType(taskType);
+ let value = records.reduce(function(previousValue, currentValue) { return previousValue + currentValue.durationForTask(taskType); }, 0);
+ let color = this._chartColors.get(taskType);
+ let checkbox = taskType !== WebInspector.RenderingFrameTimelineRecord.TaskType.Other;
+ let checked = checkbox && !this._renderingFrameTaskFilter.has(taskType);
+ return {id: taskType, label, value, color, checkbox, checked};
}, this);
this._frameSelectionChartRow.data = ""
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
