Title: [188945] trunk/Tools
- Revision
- 188945
- Author
- gyuyoung....@webkit.org
- Date
- 2015-08-25 22:47:59 -0700 (Tue, 25 Aug 2015)
Log Message
Remove python tests for PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=148463
Reviewed by Andy Estes.
As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(PassPtrTest): Deleted.
(PassPtrTest.assert_pass_ptr_check): Deleted.
(PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
(PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
(PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
(PassPtrTest.test_ref_ptr_parameter_value): Deleted.
(PassPtrTest.test_ref_ptr_member_variable): Deleted.
(PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (188944 => 188945)
--- trunk/Tools/ChangeLog 2015-08-26 05:17:34 UTC (rev 188944)
+++ trunk/Tools/ChangeLog 2015-08-26 05:47:59 UTC (rev 188945)
@@ -1,3 +1,22 @@
+2015-08-25 Gyuyoung Kim <gyuyoung....@webkit.org>
+
+ Remove python tests for PassRefPtr
+ https://bugs.webkit.org/show_bug.cgi?id=148463
+
+ Reviewed by Andy Estes.
+
+ As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
+
+ * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+ (PassPtrTest): Deleted.
+ (PassPtrTest.assert_pass_ptr_check): Deleted.
+ (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
+ (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
+ (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
+ (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
+ (PassPtrTest.test_ref_ptr_member_variable): Deleted.
+ (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
+
2015-08-25 Andy Estes <aes...@apple.com>
[iOS] run-webkit-tests fails if watchOS SDK is installed
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (188944 => 188945)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2015-08-26 05:17:34 UTC (rev 188944)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2015-08-26 05:47:59 UTC (rev 188945)
@@ -3617,88 +3617,6 @@
'virtual method(s), one declared at line 3. [runtime/virtual] [4]'])
-class PassPtrTest(CppStyleTestBase):
- # For http://webkit.org/coding/RefPtr.html
-
- def assert_pass_ptr_check(self, code, expected_message):
- """Check warnings for Pass*Ptr are as expected.
-
- Args:
- code: C++ source code expected to generate a warning message.
- expected_message: Message expected to be generated by the C++ code.
- """
- self.assertEqual(expected_message,
- self.perform_pass_ptr_check(code))
-
- def test_pass_ref_ptr_in_function(self):
- self.assert_pass_ptr_check(
- 'int myFunction()\n'
- '{\n'
- ' PassRefPtr<Type1> variable = variable2;\n'
- '}',
- 'Local variables should never be PassRefPtr (see '
- 'http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5]')
-
- def test_pass_other_type_ptr_in_function(self):
- self.assert_pass_ptr_check(
- 'int myFunction()\n'
- '{\n'
- ' PassOtherTypePtr<Type1> variable;\n'
- '}',
- 'Local variables should never be PassOtherTypePtr (see '
- 'http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5]')
-
- def test_pass_ref_ptr_return_value(self):
- self.assert_pass_ptr_check(
- 'PassRefPtr<Type1>\n'
- 'myFunction(int)\n'
- '{\n'
- '}',
- '')
- self.assert_pass_ptr_check(
- 'PassRefPtr<Type1> myFunction(int)\n'
- '{\n'
- '}',
- '')
- self.assert_pass_ptr_check(
- 'PassRefPtr<Type1> myFunction();\n',
- '')
- self.assert_pass_ptr_check(
- 'RefPtr<Type1> myFunction(int)\n'
- '{\n'
- '}',
- '')
-
- def test_ref_ptr_parameter_value(self):
- self.assert_pass_ptr_check(
- 'int myFunction(PassRefPtr<Type1>)\n'
- '{\n'
- '}',
- '')
- self.assert_pass_ptr_check(
- 'int myFunction(RefPtr<Type1>)\n'
- '{\n'
- '}',
- 'The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]')
- self.assert_pass_ptr_check(
- 'int myFunction(RefPtr<Type1>&)\n'
- '{\n'
- '}',
- '')
- self.assert_pass_ptr_check(
- 'int myFunction(RefPtr<Type1>*)\n'
- '{\n'
- '}',
- '')
-
- def test_ref_ptr_member_variable(self):
- self.assert_pass_ptr_check(
- 'class Foo {'
- ' RefPtr<Type1> m_other;\n'
- '};\n',
- '')
-
-
class LeakyPatternTest(CppStyleTestBase):
def assert_leaky_pattern_check(self, code, expected_message):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
