Title: [190341] trunk/Source/WebInspectorUI
- Revision
- 190341
- Author
- commit-qu...@webkit.org
- Date
- 2015-09-29 22:57:41 -0700 (Tue, 29 Sep 2015)
Log Message
Web Inspector: Missing completions for Symbol objects, console.error warning
https://bugs.webkit.org/show_bug.cgi?id=149641
Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-09-29
Reviewed by Darin Adler.
* UserInterface/Controllers/_javascript_RuntimeCompletionProvider.js:
(WebInspector._javascript_RuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.getCompletions):
(WebInspector._javascript_RuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.evaluated):
Include completions for symbol types.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (190340 => 190341)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-09-30 05:55:44 UTC (rev 190340)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-09-30 05:57:41 UTC (rev 190341)
@@ -1,3 +1,15 @@
+2015-09-29 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Missing completions for Symbol objects, console.error warning
+ https://bugs.webkit.org/show_bug.cgi?id=149641
+
+ Reviewed by Darin Adler.
+
+ * UserInterface/Controllers/_javascript_RuntimeCompletionProvider.js:
+ (WebInspector._javascript_RuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.getCompletions):
+ (WebInspector._javascript_RuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.evaluated):
+ Include completions for symbol types.
+
2015-09-28 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Hitting ESC while editing element tag name leaves element in bad state
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_RuntimeCompletionProvider.js (190340 => 190341)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_RuntimeCompletionProvider.js 2015-09-30 05:55:44 UTC (rev 190340)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_RuntimeCompletionProvider.js 2015-09-30 05:57:41 UTC (rev 190341)
@@ -162,6 +162,8 @@
object = new Number(0);
else if (primitiveType === "boolean")
object = new Boolean(false);
+ else if (primitiveType === "symbol")
+ object = Symbol();
else
object = this;
@@ -183,7 +185,7 @@
result.callFunctionJSON(getArrayCompletions, undefined, receivedArrayPropertyNames.bind(this));
else if (result.type === "object" || result.type === "function")
result.callFunctionJSON(getCompletions, undefined, receivedPropertyNames.bind(this));
- else if (result.type === "string" || result.type === "number" || result.type === "boolean")
+ else if (result.type === "string" || result.type === "number" || result.type === "boolean" || result.type === "symbol")
WebInspector.runtimeManager.evaluateInInspectedWindow("(" + getCompletions + ")(\"" + result.type + "\")", "completion", false, true, true, false, false, receivedPropertyNamesFromEvaluate.bind(this));
else
console.error("Unknown result type: " + result.type);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
