Title: [190451] trunk
- Revision
- 190451
- Author
- wenson_hs...@apple.com
- Date
- 2015-10-01 21:27:32 -0700 (Thu, 01 Oct 2015)
Log Message
Convert focused-input-should-assist-on-touch.html into an automated test
https://bugs.webkit.org/show_bug.cgi?id=149724
Reviewed by Simon Fraser.
.:
Remove a manual test that can now be rewritten as an automated test.
* ManualTests/ios/focused-input-should-assist-on-touch.html: Removed.
LayoutTests:
Tests that an input that focuses itself on touch and then prevents default is
able to trigger node assistance, even when it is already focused before the
user gesture.
* fast/events/ios/focused-input-should-assist-on-touch-expected.txt: Added.
* fast/events/ios/focused-input-should-assist-on-touch.html: Added.
Modified Paths
Added Paths
Removed Paths
Diff
Modified: trunk/ChangeLog (190450 => 190451)
--- trunk/ChangeLog 2015-10-02 03:45:53 UTC (rev 190450)
+++ trunk/ChangeLog 2015-10-02 04:27:32 UTC (rev 190451)
@@ -1,3 +1,14 @@
+2015-10-01 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Convert focused-input-should-assist-on-touch.html into an automated test
+ https://bugs.webkit.org/show_bug.cgi?id=149724
+
+ Reviewed by Simon Fraser.
+
+ Remove a manual test that can now be rewritten as an automated test.
+
+ * ManualTests/ios/focused-input-should-assist-on-touch.html: Removed.
+
2015-10-01 Brent Fulgham <bfulg...@apple.com>
[Win] Unreviewed CMake build fix.
Modified: trunk/LayoutTests/ChangeLog (190450 => 190451)
--- trunk/LayoutTests/ChangeLog 2015-10-02 03:45:53 UTC (rev 190450)
+++ trunk/LayoutTests/ChangeLog 2015-10-02 04:27:32 UTC (rev 190451)
@@ -1,3 +1,17 @@
+2015-10-01 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Convert focused-input-should-assist-on-touch.html into an automated test
+ https://bugs.webkit.org/show_bug.cgi?id=149724
+
+ Reviewed by Simon Fraser.
+
+ Tests that an input that focuses itself on touch and then prevents default is
+ able to trigger node assistance, even when it is already focused before the
+ user gesture.
+
+ * fast/events/ios/focused-input-should-assist-on-touch-expected.txt: Added.
+ * fast/events/ios/focused-input-should-assist-on-touch.html: Added.
+
2015-10-01 Dean Jackson <d...@apple.com>
Rollout r190446 for the moment. It broke the build.
Added: trunk/LayoutTests/fast/events/ios/focused-input-should-assist-on-touch-expected.txt (0 => 190451)
--- trunk/LayoutTests/fast/events/ios/focused-input-should-assist-on-touch-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/ios/focused-input-should-assist-on-touch-expected.txt 2015-10-02 04:27:32 UTC (rev 190451)
@@ -0,0 +1,2 @@
+
+Successfully showed keyboard.
Added: trunk/LayoutTests/fast/events/ios/focused-input-should-assist-on-touch.html (0 => 190451)
--- trunk/LayoutTests/fast/events/ios/focused-input-should-assist-on-touch.html (rev 0)
+++ trunk/LayoutTests/fast/events/ios/focused-input-should-assist-on-touch.html 2015-10-02 04:27:32 UTC (rev 190451)
@@ -0,0 +1,62 @@
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
+
+<html>
+<head>
+ <meta name="viewport" content="initial-scale=1.0">
+ <script id="ui-script" type="text/plain">
+ (function() {
+ uiController.didShowKeyboardCallback = function() {
+ uiController.uiScriptComplete("Successfully showed keyboard.");
+ }
+ uiController.singleTapAtPoint(50, 25, function() { });
+ })();
+ </script>
+
+ <script>
+ if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+ }
+
+ function getUIScript()
+ {
+ return document.getElementById("ui-script").text;
+ }
+
+ function handleTouchEvent(event)
+ {
+ event.target.focus();
+ event.preventDefault();
+ }
+
+ function runTest()
+ {
+ if (window.testRunner && testRunner.runUIScript)
+ testRunner.runUIScript(getUIScript(), function(result) {
+ document.getElementById("console").textContent = result;
+ testRunner.notifyDone();
+ });
+ else
+ document.getElementById("console").textContent = "This tests that a node can be assisted when focused due to a touch event, even when the focus does not change. Tapping the below input should show the keyboard. Best run using WKTR."
+ }
+ </script>
+
+ <style>
+ input:focus {
+ outline: none;
+ border: 1px solid #4D90FE;
+ }
+
+ input {
+ width: 100px;
+ height: 50px;
+ }
+ </style>
+
+</head>
+
+<body style="margin: 0;" _onload_="runTest()">
+ <input autofocus _ontouchstart_="handleTouchEvent(event)"></input>
+ <div id="console">Failed to show keyboard.</div>
+</body>
+</html>
Deleted: trunk/ManualTests/ios/focused-input-should-assist-on-touch.html (190450 => 190451)
--- trunk/ManualTests/ios/focused-input-should-assist-on-touch.html 2015-10-02 03:45:53 UTC (rev 190450)
+++ trunk/ManualTests/ios/focused-input-should-assist-on-touch.html 2015-10-02 04:27:32 UTC (rev 190451)
@@ -1,25 +0,0 @@
-<html>
-<head>
- <meta name="viewport" content="width=device-width, initial-scale=1">
- <script>
- function handleTouchEvent(event) {
- event.target.focus();
- event.preventDefault();
- }
- </script>
-
- <style>
- input:focus {
- outline: none;
- border: 1px solid #4D90FE;
- }
- </style>
-
-</head>
-
-<body style="margin: 0;">
- <p>This tests checks that a node can be assisted when focused due to a touch event, even when the focus does not change.</p>
- <p>Tapping the below input should show the keyboard.</p>
- <input autofocus _ontouchstart_="handleTouchEvent(event);"></input>
-</body>
-</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
