Title: [190628] trunk/Source/WebCore
- Revision
- 190628
- Author
- timothy_hor...@apple.com
- Date
- 2015-10-06 11:20:29 -0700 (Tue, 06 Oct 2015)
Log Message
Tile map shows a green rect when threaded scrolling is disabled
https://bugs.webkit.org/show_bug.cgi?id=149716
Reviewed by Darin Adler.
Green is supposed to indicate that we're using the fast path; if threaded
scrolling is disabled, we're definitely not doing that.
* platform/graphics/TiledBacking.h:
* platform/graphics/ca/TileController.cpp:
(WebCore::TileController::TileController):
* platform/graphics/ca/TileCoverageMap.cpp:
(WebCore::TileCoverageMap::update):
Default to the "we have no ScrollingCoordinator" purple indication;
if a ScrollingCoordinator comes along it will setScrollingModeIndication
and change it from this default.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (190627 => 190628)
--- trunk/Source/WebCore/ChangeLog 2015-10-06 18:06:34 UTC (rev 190627)
+++ trunk/Source/WebCore/ChangeLog 2015-10-06 18:20:29 UTC (rev 190628)
@@ -1,3 +1,22 @@
+2015-10-06 Tim Horton <timothy_hor...@apple.com>
+
+ Tile map shows a green rect when threaded scrolling is disabled
+ https://bugs.webkit.org/show_bug.cgi?id=149716
+
+ Reviewed by Darin Adler.
+
+ Green is supposed to indicate that we're using the fast path; if threaded
+ scrolling is disabled, we're definitely not doing that.
+
+ * platform/graphics/TiledBacking.h:
+ * platform/graphics/ca/TileController.cpp:
+ (WebCore::TileController::TileController):
+ * platform/graphics/ca/TileCoverageMap.cpp:
+ (WebCore::TileCoverageMap::update):
+ Default to the "we have no ScrollingCoordinator" purple indication;
+ if a ScrollingCoordinator comes along it will setScrollingModeIndication
+ and change it from this default.
+
2015-10-06 Zalan Bujtas <za...@apple.com>
Remove redundant isComposited() function and replace
Modified: trunk/Source/WebCore/platform/graphics/TiledBacking.h (190627 => 190628)
--- trunk/Source/WebCore/platform/graphics/TiledBacking.h 2015-10-06 18:06:34 UTC (rev 190627)
+++ trunk/Source/WebCore/platform/graphics/TiledBacking.h 2015-10-06 18:20:29 UTC (rev 190628)
@@ -35,6 +35,7 @@
class PlatformCALayer;
enum ScrollingModeIndication {
+ SynchronousScrollingBecauseOfLackOfScrollingCoordinatorIndication,
SynchronousScrollingBecauseOfStyleIndication,
SynchronousScrollingBecauseOfEventHandlersIndication,
AsyncScrollingIndication
Modified: trunk/Source/WebCore/platform/graphics/ca/TileController.cpp (190627 => 190628)
--- trunk/Source/WebCore/platform/graphics/ca/TileController.cpp 2015-10-06 18:06:34 UTC (rev 190627)
+++ trunk/Source/WebCore/platform/graphics/ca/TileController.cpp 2015-10-06 18:20:29 UTC (rev 190628)
@@ -70,7 +70,7 @@
, m_tilesAreOpaque(false)
, m_hasTilesWithTemporaryScaleFactor(false)
, m_tileDebugBorderWidth(0)
- , m_indicatorMode(AsyncScrollingIndication)
+ , m_indicatorMode(SynchronousScrollingBecauseOfLackOfScrollingCoordinatorIndication)
, m_topContentInset(0)
{
}
Modified: trunk/Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp (190627 => 190628)
--- trunk/Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp 2015-10-06 18:06:34 UTC (rev 190627)
+++ trunk/Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp 2015-10-06 18:20:29 UTC (rev 190628)
@@ -101,6 +101,9 @@
Color visibleRectIndicatorColor;
switch (m_controller.indicatorMode()) {
+ case SynchronousScrollingBecauseOfLackOfScrollingCoordinatorIndication:
+ visibleRectIndicatorColor = Color(200, 80, 255);
+ break;
case SynchronousScrollingBecauseOfStyleIndication:
visibleRectIndicatorColor = Color(255, 0, 0);
break;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
