Title: [190646] trunk/Websites/perf.webkit.org
- Revision
- 190646
- Author
- rn...@webkit.org
- Date
- 2015-10-06 14:21:44 -0700 (Tue, 06 Oct 2015)
Log Message
V2 UI fails to show the data for the very first point in charts
https://bugs.webkit.org/show_bug.cgi?id=149857
Reviewed by Chris Dumez.
The bug was caused by seriesBetweenPoints returning null for when point.seriesIndex is 0.
Explicitly check the type of this property instead.
* public/v2/data.js:
(TimeSeries.prototype.seriesBetweenPoints):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (190645 => 190646)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-10-06 21:04:03 UTC (rev 190645)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-10-06 21:21:44 UTC (rev 190646)
@@ -1,5 +1,18 @@
2015-10-06 Ryosuke Niwa <rn...@webkit.org>
+ V2 UI fails to show the data for the very first point in charts
+ https://bugs.webkit.org/show_bug.cgi?id=149857
+
+ Reviewed by Chris Dumez.
+
+ The bug was caused by seriesBetweenPoints returning null for when point.seriesIndex is 0.
+ Explicitly check the type of this property instead.
+
+ * public/v2/data.js:
+ (TimeSeries.prototype.seriesBetweenPoints):
+
+2015-10-06 Ryosuke Niwa <rn...@webkit.org>
+
Perf dashboard should have the capability to test local UI with production data
https://bugs.webkit.org/show_bug.cgi?id=149834
Modified: trunk/Websites/perf.webkit.org/public/v2/data.js (190645 => 190646)
--- trunk/Websites/perf.webkit.org/public/v2/data.js 2015-10-06 21:04:03 UTC (rev 190645)
+++ trunk/Websites/perf.webkit.org/public/v2/data.js 2015-10-06 21:21:44 UTC (rev 190646)
@@ -477,7 +477,7 @@
TimeSeries.prototype.seriesBetweenPoints = function (startPoint, endPoint)
{
- if (!startPoint.seriesIndex || !endPoint.seriesIndex)
+ if (typeof(startPoint.seriesIndex) != "number" || typeof(endPoint.seriesIndex) != "number")
return null;
return this._series.slice(startPoint.seriesIndex, endPoint.seriesIndex + 1);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
