Title: [191316] trunk/Source/WebCore
Revision
191316
Author
o...@webkit.org
Date
2015-10-19 14:21:44 -0700 (Mon, 19 Oct 2015)

Log Message

Fix the binding generator after r191176
https://bugs.webkit.org/show_bug.cgi?id=150320

Reviewed by Darin Adler.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::getConstructData):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (191315 => 191316)


--- trunk/Source/WebCore/ChangeLog	2015-10-19 20:39:47 UTC (rev 191315)
+++ trunk/Source/WebCore/ChangeLog	2015-10-19 21:21:44 UTC (rev 191316)
@@ -1,3 +1,15 @@
+2015-10-19  Csaba Osztrogonác  <o...@webkit.org>
+
+        Fix the binding generator after r191176
+        https://bugs.webkit.org/show_bug.cgi?id=150320
+
+        Reviewed by Darin Adler.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateConstructorHelperMethods):
+        * bindings/scripts/test/JS/JSTestInterface.cpp:
+        (WebCore::JSTestInterfaceConstructor::getConstructData):
+
 2015-10-19  Commit Queue  <commit-qu...@webkit.org>
 
         Unreviewed, rolling out r191307.

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (191315 => 191316)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2015-10-19 20:39:47 UTC (rev 191315)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2015-10-19 21:21:44 UTC (rev 191316)
@@ -4927,9 +4927,10 @@
 
     my $conditionalString = $codeGenerator->GenerateConstructorConditionalString($interface);
     if ($conditionalString) {
-        push(@$outputArray, "template<> ConstructType ${constructorClassName}::getConstructData(JSCell*, ConstructData& constructData)\n");
+        push(@$outputArray, "template<> ConstructType ${constructorClassName}::getConstructData(JSCell* cell, ConstructData& constructData)\n");
         push(@$outputArray, "{\n");
         push(@$outputArray, "#if $conditionalString\n");
+        push(@$outputArray, "    UNUSED_PARAM(cell);\n");
         push(@$outputArray, "    constructData.native.function = construct;\n");
         push(@$outputArray, "    return ConstructTypeHost;\n");
         push(@$outputArray, "#else\n");

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp (191315 => 191316)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp	2015-10-19 20:39:47 UTC (rev 191315)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp	2015-10-19 21:21:44 UTC (rev 191316)
@@ -276,9 +276,10 @@
     reifyStaticProperties(vm, JSTestInterfaceConstructorTableValues, *this);
 }
 
-template<> ConstructType JSTestInterfaceConstructor::getConstructData(JSCell*, ConstructData& constructData)
+template<> ConstructType JSTestInterfaceConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
 {
 #if ENABLE(TEST_INTERFACE)
+    UNUSED_PARAM(cell);
     constructData.native.function = construct;
     return ConstructTypeHost;
 #else
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to