Title: [191390] trunk/Source/WebKit2
Revision
191390
Author
cdu...@apple.com
Date
2015-10-21 10:12:35 -0700 (Wed, 21 Oct 2015)

Log Message

Add assertions to NetworkCache::Entry constructor to make sure a key's type is "resource"
https://bugs.webkit.org/show_bug.cgi?id=150369

Reviewed by Antti Koivisto.

Add assertions to NetworkCache::Entry constructor to make sure a key's
type is "resource" now that the NetworkCache storage supports other
types of entries.

* NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::Entry):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (191389 => 191390)


--- trunk/Source/WebKit2/ChangeLog	2015-10-21 17:08:17 UTC (rev 191389)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-21 17:12:35 UTC (rev 191390)
@@ -1,3 +1,17 @@
+2015-10-21  Chris Dumez  <cdu...@apple.com>
+
+        Add assertions to NetworkCache::Entry constructor to make sure a key's type is "resource"
+        https://bugs.webkit.org/show_bug.cgi?id=150369
+
+        Reviewed by Antti Koivisto.
+
+        Add assertions to NetworkCache::Entry constructor to make sure a key's
+        type is "resource" now that the NetworkCache storage supports other
+        types of entries.
+
+        * NetworkProcess/cache/NetworkCacheEntry.cpp:
+        (WebKit::NetworkCache::Entry::Entry):
+
 2015-10-21  Carlos Garcia Campos  <cgar...@igalia.com>
 
         NetworkProcess: DNS prefetch happens in the Web Process

Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheEntry.cpp (191389 => 191390)


--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheEntry.cpp	2015-10-21 17:08:17 UTC (rev 191389)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheEntry.cpp	2015-10-21 17:12:35 UTC (rev 191390)
@@ -46,6 +46,7 @@
     , m_varyingRequestHeaders(varyingRequestHeaders)
     , m_buffer(WTF::move(buffer))
 {
+    ASSERT(m_key.type() == "resource");
 }
 
 Entry::Entry(const Storage::Record& storageEntry)
@@ -53,6 +54,7 @@
     , m_timeStamp(storageEntry.timeStamp)
     , m_sourceStorageRecord(storageEntry)
 {
+    ASSERT(m_key.type() == "resource");
 }
 
 Storage::Record Entry::encodeAsStorageRecord() const
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to