Title: [191641] trunk/Source/WebCore
- Revision
- 191641
- Author
- commit-qu...@webkit.org
- Date
- 2015-10-27 14:44:27 -0700 (Tue, 27 Oct 2015)
Log Message
Web Inspector: Do not send RenderingFrame TimelineRecords that have no children
https://bugs.webkit.org/show_bug.cgi?id=150600
Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-10-27
Reviewed by Timothy Hatcher.
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
The frontend already filters out empty RenderingFrame records
(in TimelineManager.prototype._processRecord). Filter them out
on the backend to reduce protocol traffic / noise.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (191640 => 191641)
--- trunk/Source/WebCore/ChangeLog 2015-10-27 21:42:20 UTC (rev 191640)
+++ trunk/Source/WebCore/ChangeLog 2015-10-27 21:44:27 UTC (rev 191641)
@@ -1,3 +1,16 @@
+2015-10-27 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Do not send RenderingFrame TimelineRecords that have no children
+ https://bugs.webkit.org/show_bug.cgi?id=150600
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/InspectorTimelineAgent.cpp:
+ (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
+ The frontend already filters out empty RenderingFrame records
+ (in TimelineManager.prototype._processRecord). Filter them out
+ on the backend to reduce protocol traffic / noise.
+
2015-10-27 Alex Christensen <achristen...@webkit.org>
Cancel navigation policy checks like we do content policy checks.
Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp (191640 => 191641)
--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2015-10-27 21:42:20 UTC (rev 191640)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2015-10-27 21:44:27 UTC (rev 191641)
@@ -704,6 +704,11 @@
TimelineRecordEntry entry = m_recordStack.last();
m_recordStack.removeLast();
ASSERT_UNUSED(type, entry.type == type);
+
+ // Don't send RenderingFrame records that have no children to reduce noise.
+ if (entry.type == TimelineRecordType::RenderingFrame && !entry.children->length())
+ return;
+
didCompleteRecordEntry(entry);
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
