Title: [192817] trunk/Websites/perf.webkit.org
- Revision
- 192817
- Author
- rn...@webkit.org
- Date
- 2015-11-30 13:09:42 -0800 (Mon, 30 Nov 2015)
Log Message
Perf dashboard should always show comparison to baseline and target even if one is missing
https://bugs.webkit.org/show_bug.cgi?id=151510
Reviewed by Darin Adler.
Show the comparison status against the baseline when baseline is present but target is missing.
To make the code more readable, this patch splits the logic into three cases:
1. Both baseline and target are present
2. Only baseline is present
3. Only target is present
Also extracted a helper function to construct the label.
* public/v2/app.js:
(.labelForDiff): Added.
(App.Pane.computeStatus):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (192816 => 192817)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-11-30 21:05:25 UTC (rev 192816)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-11-30 21:09:42 UTC (rev 192817)
@@ -1,3 +1,23 @@
+2015-11-30 Ryosuke Niwa <rn...@webkit.org>
+
+ Perf dashboard should always show comparison to baseline and target even if one is missing
+ https://bugs.webkit.org/show_bug.cgi?id=151510
+
+ Reviewed by Darin Adler.
+
+ Show the comparison status against the baseline when baseline is present but target is missing.
+
+ To make the code more readable, this patch splits the logic into three cases:
+ 1. Both baseline and target are present
+ 2. Only baseline is present
+ 3. Only target is present
+
+ Also extracted a helper function to construct the label.
+
+ * public/v2/app.js:
+ (.labelForDiff): Added.
+ (App.Pane.computeStatus):
+
2015-11-23 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r192716 and r192717.
Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (192816 => 192817)
--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-11-30 21:05:25 UTC (rev 192816)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-11-30 21:09:42 UTC (rev 192817)
@@ -486,15 +486,27 @@
var className = '';
var formatter = d3.format('.3p');
+ function labelForDiff(diff, name) { return formatter(Math.abs(diff)) + ' ' + (diff > 0 ? 'above' : 'below') + ' ' + name; }
+
var smallerIsBetter = chartData.smallerIsBetter;
- if (diffFromBaseline !== undefined && diffFromBaseline > 0 == smallerIsBetter) {
- label = formatter(Math.abs(diffFromBaseline)) + ' ' + (smallerIsBetter ? 'above' : 'below') + ' baseline';
- className = 'worse';
- } else if (diffFromTarget !== undefined && diffFromTarget < 0 == smallerIsBetter) {
- label = formatter(Math.abs(diffFromTarget)) + ' ' + (smallerIsBetter ? 'below' : 'above') + ' target';
- className = 'better';
- } else if (diffFromTarget !== undefined)
- label = formatter(Math.abs(diffFromTarget)) + ' until target';
+ if (diffFromBaseline !== undefined && diffFromTarget !== undefined) {
+ if (diffFromBaseline > 0 == smallerIsBetter) {
+ label = labelForDiff(diffFromBaseline, 'baseline');
+ className = 'worse';
+ } else if (diffFromTarget < 0 == smallerIsBetter) {
+ label = labelForDiff(diffFromBaseline, 'target');
+ className = 'better';
+ } else
+ label = formatter(Math.abs(diffFromTarget)) + ' until target';
+ } else if (diffFromBaseline !== undefined) {
+ label = labelForDiff(diffFromBaseline, 'baseline');
+ if (diffFromBaseline > 0 == smallerIsBetter)
+ className = 'worse';
+ } else if (diffFromTarget !== undefined) {
+ label = labelForDiff(diffFromTarget, 'target');
+ if (diffFromTarget < 0 == smallerIsBetter)
+ className = 'better';
+ }
var valueDelta = null;
var relativeDelta = null;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes