Title: [193812] trunk
- Revision
- 193812
- Author
- gyuyoung....@webkit.org
- Date
- 2015-12-09 01:58:07 -0800 (Wed, 09 Dec 2015)
Log Message
[EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
https://bugs.webkit.org/show_bug.cgi?id=151942
Reviewed by Darin Adler.
Source/WebKit2:
As wkpreference settings were moved from EwkView to WKPreferenceEfl, the offline-web-application-cache feature
is enabled by default when running API test. It seems this option should be enabled by MiniBrowser.
* UIProcess/efl/WebPreferencesEfl.cpp:
(WebKit::WebPreferences::platformInitializeStore): Remove to enable web application cache feature here.
Tools:
* MiniBrowser/efl/main.c:
(window_create): Enable offline web application cache feature on MiniBrowser.
(elm_main):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (193811 => 193812)
--- trunk/Source/WebKit2/ChangeLog 2015-12-09 09:42:39 UTC (rev 193811)
+++ trunk/Source/WebKit2/ChangeLog 2015-12-09 09:58:07 UTC (rev 193812)
@@ -1,3 +1,16 @@
+2015-12-09 Gyuyoung Kim <gyuyoung....@webkit.org>
+
+ [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
+ https://bugs.webkit.org/show_bug.cgi?id=151942
+
+ Reviewed by Darin Adler.
+
+ As wkpreference settings were moved from EwkView to WKPreferenceEfl, the offline-web-application-cache feature
+ is enabled by default when running API test. It seems this option should be enabled by MiniBrowser.
+
+ * UIProcess/efl/WebPreferencesEfl.cpp:
+ (WebKit::WebPreferences::platformInitializeStore): Remove to enable web application cache feature here.
+
2015-12-09 Ryuan Choi <ryuan.c...@navercorp.com>
[CoordinatedGraphics] layerTreeHost always exist in CoordinatedDrawingArea
Modified: trunk/Source/WebKit2/UIProcess/efl/WebPreferencesEfl.cpp (193811 => 193812)
--- trunk/Source/WebKit2/UIProcess/efl/WebPreferencesEfl.cpp 2015-12-09 09:42:39 UTC (rev 193811)
+++ trunk/Source/WebKit2/UIProcess/efl/WebPreferencesEfl.cpp 2015-12-09 09:58:07 UTC (rev 193812)
@@ -35,7 +35,6 @@
setWebGLEnabled(true);
setFullScreenEnabled(true);
setWebAudioEnabled(true);
- setOfflineWebApplicationCacheEnabled(true);
#if ENABLE(SPELLCHECK)
setAsynchronousSpellCheckingEnabled(true);
#endif
Modified: trunk/Tools/ChangeLog (193811 => 193812)
--- trunk/Tools/ChangeLog 2015-12-09 09:42:39 UTC (rev 193811)
+++ trunk/Tools/ChangeLog 2015-12-09 09:58:07 UTC (rev 193812)
@@ -1,3 +1,14 @@
+2015-12-09 Gyuyoung Kim <gyuyoung....@webkit.org>
+
+ [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
+ https://bugs.webkit.org/show_bug.cgi?id=151942
+
+ Reviewed by Darin Adler.
+
+ * MiniBrowser/efl/main.c:
+ (window_create): Enable offline web application cache feature on MiniBrowser.
+ (elm_main):
+
2015-12-08 Aakash Jain <aakash_j...@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=151243
Modified: trunk/Tools/MiniBrowser/efl/main.c (193811 => 193812)
--- trunk/Tools/MiniBrowser/efl/main.c 2015-12-09 09:42:39 UTC (rev 193811)
+++ trunk/Tools/MiniBrowser/efl/main.c 2015-12-09 09:58:07 UTC (rev 193812)
@@ -47,6 +47,7 @@
static Eina_Bool encoding_detector_enabled = EINA_FALSE;
static Eina_Bool frame_flattening_enabled = EINA_FALSE;
static Eina_Bool local_storage_enabled = EINA_TRUE;
+static Eina_Bool offline_web_application_cache_enabled = EINA_TRUE;
static Eina_Bool fullscreen_enabled = EINA_FALSE;
static Eina_Bool spell_checking_enabled = EINA_FALSE;
static Eina_Bool web_security_enabled = EINA_TRUE;
@@ -2354,6 +2355,7 @@
ewk_settings_encoding_detector_enabled_set(settings, encoding_detector_enabled);
ewk_settings_frame_flattening_enabled_set(settings, frame_flattening_enabled);
ewk_settings_local_storage_enabled_set(settings, local_storage_enabled);
+ ewk_settings_offline_web_application_cache_enabled_set(settings, offline_web_application_cache_enabled);
INFO("HTML5 local storage is %s for this view.", local_storage_enabled ? "enabled" : "disabled");
ewk_settings_developer_extras_enabled_set(settings, EINA_TRUE);
ewk_settings_preferred_minimum_contents_width_set(settings, 0);
@@ -2420,6 +2422,7 @@
ECORE_GETOPT_VALUE_STR(background_color_string),
ECORE_GETOPT_VALUE_BOOL(frame_flattening_enabled),
ECORE_GETOPT_VALUE_BOOL(local_storage_enabled),
+ ECORE_GETOPT_VALUE_BOOL(offline_web_application_cache_enabled),
ECORE_GETOPT_VALUE_BOOL(fullscreen_enabled),
ECORE_GETOPT_VALUE_BOOL(spell_checking_enabled),
ECORE_GETOPT_VALUE_BOOL(touch_events_enabled),
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
