Title: [193832] trunk
Revision
193832
Author
calva...@igalia.com
Date
2015-12-09 07:34:28 -0800 (Wed, 09 Dec 2015)

Log Message

[Streams API] pipeThrough test failing
https://bugs.webkit.org/show_bug.cgi?id=152061

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

* web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt: Expectations.

Source/WebCore:

Test: imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through.html

* Modules/streams/ReadableStream.js:
(pipeThrough): Mimic destructuring for the streams parameter.

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (193831 => 193832)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2015-12-09 15:01:26 UTC (rev 193831)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2015-12-09 15:34:28 UTC (rev 193832)
@@ -1,5 +1,14 @@
 2015-12-09  Xabier Rodriguez Calvar  <calva...@igalia.com>
 
+        [Streams API] pipeThrough test failing
+        https://bugs.webkit.org/show_bug.cgi?id=152061
+
+        Reviewed by Youenn Fablet.
+
+        * web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt: Expectations.
+
+2015-12-09  Xabier Rodriguez Calvar  <calva...@igalia.com>
+
         [Streams API] Import the web-platform-tests directly from the spec
         https://bugs.webkit.org/show_bug.cgi?id=152051
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt (193831 => 193832)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt	2015-12-09 15:01:26 UTC (rev 193831)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt	2015-12-09 15:34:28 UTC (rev 193832)
@@ -2,7 +2,7 @@
 PASS ReadableStream.prototype.pipeThrough should work generically on its this and its arguments 
 PASS ReadableStream.prototype.pipeThrough should throw when its first argument is not convertible to an object 
 PASS ReadableStream.prototype.pipeThrough should throw when "this" has no pipeTo method 
-FAIL ReadableStream.prototype.pipeThrough should rethrow errors from accessing pipeTo, readable, or writable assert_unreached: pipeTo should not be called Reached unreachable code
+PASS ReadableStream.prototype.pipeThrough should rethrow errors from accessing pipeTo, readable, or writable 
 PASS ReadableStream.prototype.pipeThrough should work with missing readable, writable, or options 
 FAIL Load pipe-through.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
 FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')

Modified: trunk/Source/WebCore/ChangeLog (193831 => 193832)


--- trunk/Source/WebCore/ChangeLog	2015-12-09 15:01:26 UTC (rev 193831)
+++ trunk/Source/WebCore/ChangeLog	2015-12-09 15:34:28 UTC (rev 193832)
@@ -1,3 +1,15 @@
+2015-12-09  Xabier Rodriguez Calvar  <calva...@igalia.com>
+
+        [Streams API] pipeThrough test failing
+        https://bugs.webkit.org/show_bug.cgi?id=152061
+
+        Reviewed by Youenn Fablet.
+
+        Test: imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through.html
+
+        * Modules/streams/ReadableStream.js:
+        (pipeThrough): Mimic destructuring for the streams parameter.
+
 2015-12-09  Frederic Wang  <fred.w...@free.fr>
 
         Bad position of large operators inside an munderover element

Modified: trunk/Source/WebCore/Modules/streams/ReadableStream.js (193831 => 193832)


--- trunk/Source/WebCore/Modules/streams/ReadableStream.js	2015-12-09 15:01:26 UTC (rev 193831)
+++ trunk/Source/WebCore/Modules/streams/ReadableStream.js	2015-12-09 15:34:28 UTC (rev 193832)
@@ -94,8 +94,10 @@
 {
     "use strict";
 
-    this.pipeTo(streams.writable, options);
-    return streams.readable;
+    const writable = streams.writable;
+    const readable = streams.readable;
+    this.pipeTo(writable, options);
+    return readable;
 }
 
 function pipeTo(destination, options)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to