Title: [195161] trunk/LayoutTests
Revision
195161
Author
mmaxfi...@apple.com
Date
2016-01-15 17:55:03 -0800 (Fri, 15 Jan 2016)

Log Message

Content blocking console messages are not deterministic for one test
https://bugs.webkit.org/show_bug.cgi?id=153051

Unreviewed.

Console messages will print the line number of whichever _javascript_ line is
being parsed. However, font requests (and therefore content blockers) are
not run in response to script. The solution is to add the webfont style
from script, so the line number is deterministic.

* http/tests/contentextensions/font-display-none-repeated-layout.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (195160 => 195161)


--- trunk/LayoutTests/ChangeLog	2016-01-16 01:03:47 UTC (rev 195160)
+++ trunk/LayoutTests/ChangeLog	2016-01-16 01:55:03 UTC (rev 195161)
@@ -1,3 +1,17 @@
+2016-01-15  Myles C. Maxfield  <mmaxfi...@apple.com>
+
+        Content blocking console messages are not deterministic for one test
+        https://bugs.webkit.org/show_bug.cgi?id=153051
+
+        Unreviewed.
+
+        Console messages will print the line number of whichever _javascript_ line is
+        being parsed. However, font requests (and therefore content blockers) are
+        not run in response to script. The solution is to add the webfont style
+        from script, so the line number is deterministic.
+
+        * http/tests/contentextensions/font-display-none-repeated-layout.html:
+
 2016-01-15  Chris Dumez  <cdu...@apple.com>
 
         Drop obsolete HTMLDocument.width / height attributes

Modified: trunk/LayoutTests/http/tests/contentextensions/font-display-none-repeated-layout.html (195160 => 195161)


--- trunk/LayoutTests/http/tests/contentextensions/font-display-none-repeated-layout.html	2016-01-16 01:03:47 UTC (rev 195160)
+++ trunk/LayoutTests/http/tests/contentextensions/font-display-none-repeated-layout.html	2016-01-16 01:55:03 UTC (rev 195161)
@@ -2,14 +2,7 @@
 <html>
 <head>
 <script src=""
-<style>
-@font-face {
-    font-family: "WebFont";
-    src: url("../resources/Ahem.woff") format("woff");
-}
-#contents {
-    font-family: "WebFont";
-}
+<style id="style">
 </style>
 </head>
 <body>
@@ -17,6 +10,11 @@
 <div id="contents">Hello</div>
 <div id="console"></div>
 <script>
+var style = document.getElementById("style");
+style.sheet.insertRule("@font-face { font-family: 'WebFont'; src: url('../resources/Ahem.woff') format('woff'); }", 0);
+style.sheet.insertRule("#contents { font-family: 'WebFont'; }", 1);
+document.body.offsetRight;
+
 description("Make sure that a content-blocker rule which is triggered by a webfont and causes display:none on an element doesn't cause looping layouts.");
 
 window.jsTestIsAsync = true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to