Title: [203686] trunk/Source
- Revision
- 203686
- Author
- da...@apple.com
- Date
- 2016-07-25 09:37:04 -0700 (Mon, 25 Jul 2016)
Log Message
Speed up make process slightly by improving "list of files" idiom
https://bugs.webkit.org/show_bug.cgi?id=160164
Reviewed by Mark Lam.
* DerivedSources.make: Change rules that build lists of files to only run when
DerivedSources.make has been modified since the last time they were run. Since the
list of files are inside this file, this is safe, and this is faster than always
comparing and regenerating the file containing the list of files each time.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (203685 => 203686)
--- trunk/Source/_javascript_Core/ChangeLog 2016-07-25 16:30:59 UTC (rev 203685)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-07-25 16:37:04 UTC (rev 203686)
@@ -1,3 +1,15 @@
+2016-07-25 Darin Adler <da...@apple.com>
+
+ Speed up make process slightly by improving "list of files" idiom
+ https://bugs.webkit.org/show_bug.cgi?id=160164
+
+ Reviewed by Mark Lam.
+
+ * DerivedSources.make: Change rules that build lists of files to only run when
+ DerivedSources.make has been modified since the last time they were run. Since the
+ list of files are inside this file, this is safe, and this is faster than always
+ comparing and regenerating the file containing the list of files each time.
+
2016-07-24 Youenn Fablet <you...@apple.com>
[Fetch API] Request should be created with any HeadersInit data
Modified: trunk/Source/_javascript_Core/DerivedSources.make (203685 => 203686)
--- trunk/Source/_javascript_Core/DerivedSources.make 2016-07-25 16:30:59 UTC (rev 203685)
+++ trunk/Source/_javascript_Core/DerivedSources.make 2016-07-25 16:37:04 UTC (rev 203686)
@@ -117,8 +117,7 @@
# The combined output file depends on the contents of builtins and generator scripts, so
# adding, modifying, or removing builtins or scripts will trigger regeneration of files.
-.PHONY: force
-_javascript_Core_BUILTINS_DEPENDENCIES_LIST : $(_javascript_Core_SCRIPTS_DIR)/UpdateContents.py force
+_javascript_Core_BUILTINS_DEPENDENCIES_LIST : $(_javascript_Core_SCRIPTS_DIR)/UpdateContents.py DerivedSources.make
$(PYTHON) $(_javascript_Core_SCRIPTS_DIR)/UpdateContents.py '$(_javascript_Core_BUILTINS_SOURCES) $(BUILTINS_GENERATOR_SCRIPTS)' $@
JSCBuiltins.h: $(BUILTINS_GENERATOR_SCRIPTS) $(_javascript_Core_BUILTINS_SOURCES) _javascript_Core_BUILTINS_DEPENDENCIES_LIST
Modified: trunk/Source/WebCore/ChangeLog (203685 => 203686)
--- trunk/Source/WebCore/ChangeLog 2016-07-25 16:30:59 UTC (rev 203685)
+++ trunk/Source/WebCore/ChangeLog 2016-07-25 16:37:04 UTC (rev 203686)
@@ -1,3 +1,15 @@
+2016-07-25 Darin Adler <da...@apple.com>
+
+ Speed up make process slightly by improving "list of files" idiom
+ https://bugs.webkit.org/show_bug.cgi?id=160164
+
+ Reviewed by Mark Lam.
+
+ * DerivedSources.make: Change rules that build lists of files to only run when
+ DerivedSources.make has been modified since the last time they were run. Since the
+ list of files are inside this file, this is safe, and this is faster than always
+ comparing and regenerating the file containing the list of files each time.
+
2016-07-24 Wenson Hsieh <wenson_hs...@apple.com>
The web process hangs when computing elements-based snap points for a container with large max scroll offset
Modified: trunk/Source/WebCore/DerivedSources.make (203685 => 203686)
--- trunk/Source/WebCore/DerivedSources.make 2016-07-25 16:30:59 UTC (rev 203685)
+++ trunk/Source/WebCore/DerivedSources.make 2016-07-25 16:37:04 UTC (rev 203686)
@@ -1327,16 +1327,15 @@
WebCoreJSBuiltins.cpp \
WebCoreJSBuiltinInternals.h \
WebCoreJSBuiltinInternals.cpp \
+#
# Adding/removing scripts should trigger regeneration, but changing which builtins are
# generated should not affect other builtins when not passing '--combined' to the generator.
-.PHONY: force
-
-WebCore_BUILTINS_SOURCES_LIST : $(_javascript_Core_SCRIPTS_DIR)/UpdateContents.py force
+WebCore_BUILTINS_SOURCES_LIST : $(_javascript_Core_SCRIPTS_DIR)/UpdateContents.py DerivedSources.make
$(PYTHON) $(_javascript_Core_SCRIPTS_DIR)/UpdateContents.py '$(WebCore_BUILTINS_SOURCES)' $@
-WebCore_BUILTINS_DEPENDENCIES_LIST : $(_javascript_Core_SCRIPTS_DIR)/UpdateContents.py force
+WebCore_BUILTINS_DEPENDENCIES_LIST : $(_javascript_Core_SCRIPTS_DIR)/UpdateContents.py DerivedSources.make
$(PYTHON) $(_javascript_Core_SCRIPTS_DIR)/UpdateContents.py '$(BUILTINS_GENERATOR_SCRIPTS)' $@
$(firstword $(WebCore_BUILTINS_WRAPPERS)): WebCore_BUILTINS_SOURCES_LIST $(BUILTINS_GENERATOR_SCRIPTS) WebCore_BUILTINS_DEPENDENCIES_LIST
@@ -1400,4 +1399,3 @@
$(PYTHON) $(WebCore)/AVFoundationSupport.py $(WEBKIT_LIBRARIES) > $@
endif # Windows_NT
-
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
