Title: [208604] trunk/Source/WebInspectorUI
- Revision
- 208604
- Author
- nvasil...@apple.com
- Date
- 2016-11-11 12:38:57 -0800 (Fri, 11 Nov 2016)
Log Message
Web Inspector: Call RuntimeAgent.disableControlFlowProfiler when Code Coverage Profiler is turned off
https://bugs.webkit.org/show_bug.cgi?id=163407
<rdar://problem/28764230>
Reviewed by Timothy Hatcher.
Turning Type Profiler off by clicking [T] icon now disables its backend by calling RuntimeAgent.disableTypeProfiler().
* UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (208603 => 208604)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-11-11 20:16:03 UTC (rev 208603)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-11-11 20:38:57 UTC (rev 208604)
@@ -1,5 +1,18 @@
2016-11-11 Nikita Vasilyev <nvasil...@apple.com>
+ Web Inspector: Call RuntimeAgent.disableControlFlowProfiler when Code Coverage Profiler is turned off
+ https://bugs.webkit.org/show_bug.cgi?id=163407
+ <rdar://problem/28764230>
+
+ Reviewed by Timothy Hatcher.
+
+ Turning Type Profiler off by clicking [T] icon now disables its backend by calling RuntimeAgent.disableTypeProfiler().
+
+ * UserInterface/Views/SourceCodeTextEditor.js:
+ (WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):
+
+2016-11-11 Nikita Vasilyev <nvasil...@apple.com>
+
Web Inspector: Settings tab: make the header smaller to fit more content
https://bugs.webkit.org/show_bug.cgi?id=164613
<rdar://problem/29206007>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (208603 => 208604)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2016-11-11 20:16:03 UTC (rev 208603)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2016-11-11 20:38:57 UTC (rev 208604)
@@ -1876,12 +1876,7 @@
if (!this._typeTokenScrollHandler)
this._enableScrollEventsForTypeTokenAnnotator();
} else {
- // Because we disable type profiling when exiting the inspector, there is no need to call
- // RuntimeAgent.disableTypeProfiler() here. If we were to call it here, _javascript_Core would
- // compile out all the necessary type profiling information, so if a user were to quickly press then
- // unpress the type profiling button, we wouldn't be able to re-show type information which would
- // provide a confusing user experience.
-
+ RuntimeAgent.disableTypeProfiler();
this._typeTokenAnnotator.clear();
if (this._typeTokenScrollHandler)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
