Title: [208608] trunk/Source/WebCore
Revision
208608
Author
hy...@apple.com
Date
2016-11-11 13:55:44 -0800 (Fri, 11 Nov 2016)

Log Message

[CSS Parser] Fix time unit parsing
https://bugs.webkit.org/show_bug.cgi?id=164649

Reviewed by Dean Jackson.
        
Make sure that a unitless value gets changed to milliseconds properly.

* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeTime):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (208607 => 208608)


--- trunk/Source/WebCore/ChangeLog	2016-11-11 21:50:11 UTC (rev 208607)
+++ trunk/Source/WebCore/ChangeLog	2016-11-11 21:55:44 UTC (rev 208608)
@@ -1,3 +1,15 @@
+2016-11-11  Dave Hyatt  <hy...@apple.com>
+
+        [CSS Parser] Fix time unit parsing
+        https://bugs.webkit.org/show_bug.cgi?id=164649
+
+        Reviewed by Dean Jackson.
+        
+        Make sure that a unitless value gets changed to milliseconds properly.
+
+        * css/parser/CSSPropertyParserHelpers.cpp:
+        (WebCore::CSSPropertyParserHelpers::consumeTime):
+
 2016-11-11  Keith Rollin  <krol...@apple.com>
 
         Reduce number of platformMemoryUsage calls

Modified: trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp (208607 => 208608)


--- trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp	2016-11-11 21:50:11 UTC (rev 208607)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp	2016-11-11 21:55:44 UTC (rev 208608)
@@ -310,7 +310,7 @@
         if (valueRange == ValueRangeNonNegative && token.numericValue() < 0)
             return nullptr;
         if (unit == CSSPrimitiveValue::UnitTypes::CSS_MS || unit == CSSPrimitiveValue::UnitTypes::CSS_S)
-            return CSSValuePool::singleton().createValue(range.consumeIncludingWhitespace().numericValue(), token.unitType());
+            return CSSValuePool::singleton().createValue(range.consumeIncludingWhitespace().numericValue(), unit);
         return nullptr;
     }
     CalcParser calcParser(range, valueRange);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to