Title: [211655] trunk/Source/WebKit2
Revision
211655
Author
ander...@apple.com
Date
2017-02-03 15:08:17 -0800 (Fri, 03 Feb 2017)

Log Message

Revert toString behavior to what we had in the last version we shipped
https://bugs.webkit.org/show_bug.cgi?id=167814
rdar://problem/30344753

Reviewed by Tim Horton.

This is a speculative fix for a crash that we've seen on recent builds. It simply reverts the toString call back to
what we have in the last version of Safari we shipped.

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (211654 => 211655)


--- trunk/Source/WebKit2/ChangeLog	2017-02-03 22:40:28 UTC (rev 211654)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-03 23:08:17 UTC (rev 211655)
@@ -1,3 +1,17 @@
+2017-02-03  Anders Carlsson  <ander...@apple.com>
+
+        Revert toString behavior to what we had in the last version we shipped
+        https://bugs.webkit.org/show_bug.cgi?id=167814
+        rdar://problem/30344753
+
+        Reviewed by Tim Horton.
+
+        This is a speculative fix for a crash that we've seen on recent builds. It simply reverts the toString call back to
+        what we have in the last version of Safari we shipped.
+
+        * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
+        (WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
+
 2017-02-03  Chris Dumez  <cdu...@apple.com>
 
         Dismiss HTML form validation popover when pressing Escape key

Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp (211654 => 211655)


--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp	2017-02-03 22:40:28 UTC (rev 211654)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp	2017-02-03 23:08:17 UTC (rev 211655)
@@ -167,7 +167,7 @@
     }
 
     if (value.isString()) {
-        NPString npString = createNPString(asString(value)->value(exec).utf8());
+        NPString npString = createNPString(value.toString(exec)->value(exec).utf8());
         STRINGN_TO_NPVARIANT(npString.UTF8Characters, npString.UTF8Length, variant);
         return;
     }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to