Title: [211798] releases/WebKitGTK/webkit-2.14/Source/WebKit2
- Revision
- 211798
- Author
- carlo...@webkit.org
- Date
- 2017-02-07 01:34:18 -0800 (Tue, 07 Feb 2017)
Log Message
Merge r211277 - [GTK] Stop forcing accelerated compositing by default
https://bugs.webkit.org/show_bug.cgi?id=167492
Reviewed by Žan Doberšek.
We are now ready to bring back the on demand accelerated compositing mode with the threaded
compositor. Unfortunately, having AC always enabled brought a lot of issues for many people. Not only it
requires a lot more memory but also caused rendering issues (or even nothing rendered at all) with some graphics
drivers. People started to use WEBKIT_DISABLE_COMPOSITING_MODE as a workaround, but that was not expected to be
used by users. So, entering/leaving AC when required by web contents is not actually the solution but a huge
improvement for many people. If we are eventually ready to force AC mode again, we'll change this again. Note
that we still have WEBKIT_DISABLE_COMPOSITING_MODE, but now also WEBKIT_FORCE_COMPOSITING_MODE for testing and debugging.
* UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformInitializeStore):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog (211797 => 211798)
--- releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog 2017-02-07 09:34:12 UTC (rev 211797)
+++ releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog 2017-02-07 09:34:18 UTC (rev 211798)
@@ -1,3 +1,21 @@
+2017-01-27 Carlos Garcia Campos <cgar...@igalia.com>
+
+ [GTK] Stop forcing accelerated compositing by default
+ https://bugs.webkit.org/show_bug.cgi?id=167492
+
+ Reviewed by Žan Doberšek.
+
+ We are now ready to bring back the on demand accelerated compositing mode with the threaded
+ compositor. Unfortunately, having AC always enabled brought a lot of issues for many people. Not only it
+ requires a lot more memory but also caused rendering issues (or even nothing rendered at all) with some graphics
+ drivers. People started to use WEBKIT_DISABLE_COMPOSITING_MODE as a workaround, but that was not expected to be
+ used by users. So, entering/leaving AC when required by web contents is not actually the solution but a huge
+ improvement for many people. If we are eventually ready to force AC mode again, we'll change this again. Note
+ that we still have WEBKIT_DISABLE_COMPOSITING_MODE, but now also WEBKIT_FORCE_COMPOSITING_MODE for testing and debugging.
+
+ * UIProcess/gtk/WebPreferencesGtk.cpp:
+ (WebKit::WebPreferences::platformInitializeStore):
+
2017-01-30 Carlos Garcia Campos <cgar...@igalia.com>
[GTK] Do not release OpenGL resource immediately when leaving accelerated compositing mode
Modified: releases/WebKitGTK/webkit-2.14/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp (211797 => 211798)
--- releases/WebKitGTK/webkit-2.14/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp 2017-02-07 09:34:12 UTC (rev 211797)
+++ releases/WebKitGTK/webkit-2.14/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp 2017-02-07 09:34:18 UTC (rev 211798)
@@ -44,16 +44,12 @@
#if !ENABLE(OPENGL)
setAcceleratedCompositingEnabled(false);
#else
-#if USE(COORDINATED_GRAPHICS_THREADED)
- setForceCompositingMode(true);
-#else
- const char* force_compositing = getenv("WEBKIT_FORCE_COMPOSITING_MODE");
- if (force_compositing && strcmp(force_compositing, "0"))
+ const char* forceCompositing = getenv("WEBKIT_FORCE_COMPOSITING_MODE");
+ if (forceCompositing && strcmp(forceCompositing, "0"))
setForceCompositingMode(true);
-#endif
- const char* disable_compositing = getenv("WEBKIT_DISABLE_COMPOSITING_MODE");
- if (disable_compositing && strcmp(disable_compositing, "0")) {
+ const char* disableCompositing = getenv("WEBKIT_DISABLE_COMPOSITING_MODE");
+ if (disableCompositing && strcmp(disableCompositing, "0")) {
setAcceleratedCompositingEnabled(false);
return;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
