Title: [212232] trunk/Source/WebKit2
Revision
212232
Author
commit-qu...@webkit.org
Date
2017-02-13 10:37:27 -0800 (Mon, 13 Feb 2017)

Log Message

[WebRTC] libwebrtc socket factory is not assigning the right socket type
https://bugs.webkit.org/show_bug.cgi?id=168233

Patch by Youenn Fablet <youe...@gmail.com> on 2017-02-13
Reviewed by Brent Fulgham.

* WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp:
(WebKit::LibWebRTCSocketFactory::CreateUdpSocket):
(WebKit::LibWebRTCSocketFactory::CreateClientTcpSocket):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (212231 => 212232)


--- trunk/Source/WebKit2/ChangeLog	2017-02-13 18:32:46 UTC (rev 212231)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-13 18:37:27 UTC (rev 212232)
@@ -1,3 +1,14 @@
+2017-02-13  Youenn Fablet  <youe...@gmail.com>
+
+        [WebRTC] libwebrtc socket factory is not assigning the right socket type
+        https://bugs.webkit.org/show_bug.cgi?id=168233
+
+        Reviewed by Brent Fulgham.
+
+        * WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp:
+        (WebKit::LibWebRTCSocketFactory::CreateUdpSocket):
+        (WebKit::LibWebRTCSocketFactory::CreateClientTcpSocket):
+
 2017-02-13  Michael Catanzaro  <mcatanz...@igalia.com>
 
         [GTK] Unreviewed, add missing precondition check

Modified: trunk/Source/WebKit2/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp (212231 => 212232)


--- trunk/Source/WebKit2/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp	2017-02-13 18:32:46 UTC (rev 212231)
+++ trunk/Source/WebKit2/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp	2017-02-13 18:37:27 UTC (rev 212232)
@@ -61,7 +61,7 @@
 
 rtc::AsyncPacketSocket* LibWebRTCSocketFactory::CreateUdpSocket(const rtc::SocketAddress& socketAddress, uint16_t minPort, uint16_t maxPort)
 {
-    auto socket = std::make_unique<LibWebRTCSocket>(*this, ++s_uniqueSocketIdentifier, LibWebRTCSocket::Type::ServerTCP, socketAddress, rtc::SocketAddress());
+    auto socket = std::make_unique<LibWebRTCSocket>(*this, ++s_uniqueSocketIdentifier, LibWebRTCSocket::Type::UDP, socketAddress, rtc::SocketAddress());
     m_sockets.set(socket->identifier(), socket.get());
 
     auto identifier = socket->identifier();
@@ -78,7 +78,7 @@
 
 rtc::AsyncPacketSocket* LibWebRTCSocketFactory::CreateClientTcpSocket(const rtc::SocketAddress& localSocketAddress, const rtc::SocketAddress& remoteSocketAddress, const rtc::ProxyInfo&, const std::string&, int options)
 {
-    auto socket = std::make_unique<LibWebRTCSocket>(*this, ++s_uniqueSocketIdentifier, LibWebRTCSocket::Type::ServerTCP, localSocketAddress, remoteSocketAddress);
+    auto socket = std::make_unique<LibWebRTCSocket>(*this, ++s_uniqueSocketIdentifier, LibWebRTCSocket::Type::ClientTCP, localSocketAddress, remoteSocketAddress);
     socket->setState(LibWebRTCSocket::STATE_CONNECTING);
     m_sockets.set(socket->identifier(), socket.get());
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to