Title: [212548] trunk/Source/WebCore
- Revision
- 212548
- Author
- carlo...@webkit.org
- Date
- 2017-02-17 06:46:32 -0800 (Fri, 17 Feb 2017)
Log Message
[SOUP] Stop removing the fragment identifier from resource requests
https://bugs.webkit.org/show_bug.cgi?id=168509
Reviewed by Sergio Villar Senin.
I don't know why, but have always removed the fragment identifier from the URL when creating the SoupURI that
is passed to libsoup. Maybe it was a bug in a very old version of libsoup, but it doesn't look necessary anymore
and it's causing several layout test failures.
Fixes: http/tests/svg/svg-use-external.html
imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-same-origin-with-hash.html
imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/runtime-error-same-origin-with-hash.html
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::createSoupURI): Do not remove the fragment identifier from the URL.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (212547 => 212548)
--- trunk/Source/WebCore/ChangeLog 2017-02-17 14:44:44 UTC (rev 212547)
+++ trunk/Source/WebCore/ChangeLog 2017-02-17 14:46:32 UTC (rev 212548)
@@ -1,3 +1,21 @@
+2017-02-17 Carlos Garcia Campos <cgar...@igalia.com>
+
+ [SOUP] Stop removing the fragment identifier from resource requests
+ https://bugs.webkit.org/show_bug.cgi?id=168509
+
+ Reviewed by Sergio Villar Senin.
+
+ I don't know why, but have always removed the fragment identifier from the URL when creating the SoupURI that
+ is passed to libsoup. Maybe it was a bug in a very old version of libsoup, but it doesn't look necessary anymore
+ and it's causing several layout test failures.
+
+ Fixes: http/tests/svg/svg-use-external.html
+ imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-same-origin-with-hash.html
+ imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/runtime-error-same-origin-with-hash.html
+
+ * platform/network/soup/ResourceRequestSoup.cpp:
+ (WebCore::ResourceRequest::createSoupURI): Do not remove the fragment identifier from the URL.
+
2017-02-16 Yusuke Suzuki <utatane....@gmail.com>
[JSC] Drop PassRefPtr from ArrayBuffer
Modified: trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp (212547 => 212548)
--- trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp 2017-02-17 14:44:44 UTC (rev 212547)
+++ trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp 2017-02-17 14:46:32 UTC (rev 212548)
@@ -208,13 +208,7 @@
return GUniquePtr<SoupURI>(soup_uri_new(urlString.utf8().data()));
}
- GUniquePtr<SoupURI> soupURI;
- if (m_url.hasFragmentIdentifier()) {
- URL url = ""
- url.removeFragmentIdentifier();
- soupURI.reset(soup_uri_new(url.string().utf8().data()));
- } else
- soupURI = m_url.createSoupURI();
+ GUniquePtr<SoupURI> soupURI = m_url.createSoupURI();
// Versions of libsoup prior to 2.42 have a soup_uri_new that will convert empty passwords that are not
// prefixed by a colon into null. Some parts of soup like the SoupAuthenticationManager will only be active
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
