Title: [213744] trunk/Source/WebInspectorUI
- Revision
- 213744
- Author
- mattba...@apple.com
- Date
- 2017-03-10 17:56:08 -0800 (Fri, 10 Mar 2017)
Log Message
Web Inspector: Only show "Break on..." menu if backend supports DOM breakpoints
https://bugs.webkit.org/show_bug.cgi?id=169488
Reviewed by Joseph Pecoraro.
* UserInterface/Controllers/DOMBreakpointTreeController.js:
(WebInspector.DOMBreakpointTreeController.appendBreakpointContextMenuItems):
Added assert to catch future cases where UI is being added when
backend support doesn't exist.
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._populateNodeContextMenu):
Check for backend support.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (213743 => 213744)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-03-11 01:39:44 UTC (rev 213743)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-03-11 01:56:08 UTC (rev 213744)
@@ -1,3 +1,19 @@
+2017-03-10 Matt Baker <mattba...@apple.com>
+
+ Web Inspector: Only show "Break on..." menu if backend supports DOM breakpoints
+ https://bugs.webkit.org/show_bug.cgi?id=169488
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Controllers/DOMBreakpointTreeController.js:
+ (WebInspector.DOMBreakpointTreeController.appendBreakpointContextMenuItems):
+ Added assert to catch future cases where UI is being added when
+ backend support doesn't exist.
+
+ * UserInterface/Views/DOMTreeElement.js:
+ (WebInspector.DOMTreeElement.prototype._populateNodeContextMenu):
+ Check for backend support.
+
2017-03-10 Devin Rousso <dcrousso+web...@gmail.com>
Web Inspector: popover with compositing reasons in Layers sidebar has hard to read layout
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js (213743 => 213744)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js 2017-03-11 01:39:44 UTC (rev 213743)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js 2017-03-11 01:56:08 UTC (rev 213744)
@@ -44,6 +44,8 @@
static appendBreakpointContextMenuItems(contextMenu, domNode, allowEditing)
{
+ console.assert(WebInspector.domDebuggerManager.supported);
+
let subMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Break on…"));
let breakpoints = WebInspector.domDebuggerManager.domBreakpointsForNode(domNode);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (213743 => 213744)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2017-03-11 01:39:44 UTC (rev 213743)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2017-03-11 01:56:08 UTC (rev 213744)
@@ -760,7 +760,7 @@
contextMenu.appendItem(WebInspector.UIString("Jump to Definition"), this._showCustomElementDefinition.bind(this));
}
- if (node.nodeType() === Node.ELEMENT_NODE) {
+ if (WebInspector.domDebuggerManager.supported && node.nodeType() === Node.ELEMENT_NODE) {
contextMenu.appendSeparator();
const allowEditing = false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
