Diff
Modified: trunk/LayoutTests/ChangeLog (214535 => 214536)
--- trunk/LayoutTests/ChangeLog 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/LayoutTests/ChangeLog 2017-03-29 15:58:29 UTC (rev 214536)
@@ -1,3 +1,16 @@
+2017-03-29 Youenn Fablet <you...@apple.com>
+
+ Move DTMF WebRTC extension behind its own compile flag
+ https://bugs.webkit.org/show_bug.cgi?id=170226
+
+ Reviewed by Eric Carlson.
+
+ * TestExpectations:
+ * platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
+ * platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
+ * platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
+ * platform/mac/js/dom/global-constructors-attributes-expected.txt:
+
2017-03-29 Carlos Alberto Lopez Perez <clo...@igalia.com>
[GTK][OWR] Rebaseline fast/mediastream/RTCPeerConnection-addIceCandidate.html after r214527
Modified: trunk/LayoutTests/TestExpectations (214535 => 214536)
--- trunk/LayoutTests/TestExpectations 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/LayoutTests/TestExpectations 2017-03-29 15:58:29 UTC (rev 214536)
@@ -718,6 +718,7 @@
fast/mediastream/RTCPeerConnection-overloaded-operations-params.html [ Skip ]
fast/mediastream/RTCRtpSender-replaceTrack.html [ Skip ]
fast/mediastream/RTCPeerConnection-icecandidate-event.html [ Pass Failure ]
+fast/mediastream/RTCPeerConnection-dtmf.html [ Failure ]
# Need updating wptserve
imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm [ Skip ]
Modified: trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt (214535 => 214536)
--- trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2017-03-29 15:58:29 UTC (rev 214536)
@@ -1268,11 +1268,6 @@
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').value is RTCDTMFToneChangeEvent
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'RTCIceCandidate').value is RTCIceCandidate
PASS Object.getOwnPropertyDescriptor(global, 'RTCIceCandidate').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'RTCIceCandidate').hasOwnProperty('set') is false
Modified: trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt (214535 => 214536)
--- trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt 2017-03-29 15:58:29 UTC (rev 214536)
@@ -1258,11 +1258,6 @@
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').value is RTCDTMFToneChangeEvent
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'RTCIceCandidate').value is RTCIceCandidate
PASS Object.getOwnPropertyDescriptor(global, 'RTCIceCandidate').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'RTCIceCandidate').hasOwnProperty('set') is false
Modified: trunk/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt (214535 => 214536)
--- trunk/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt 2017-03-29 15:58:29 UTC (rev 214536)
@@ -1263,11 +1263,6 @@
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').value is RTCDTMFToneChangeEvent
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'RTCIceCandidate').value is RTCIceCandidate
PASS Object.getOwnPropertyDescriptor(global, 'RTCIceCandidate').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'RTCIceCandidate').hasOwnProperty('set') is false
Modified: trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt (214535 => 214536)
--- trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt 2017-03-29 15:58:29 UTC (rev 214536)
@@ -1248,11 +1248,6 @@
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').value is RTCDTMFToneChangeEvent
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'RTCDTMFToneChangeEvent').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'RTCIceCandidate').value is RTCIceCandidate
PASS Object.getOwnPropertyDescriptor(global, 'RTCIceCandidate').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'RTCIceCandidate').hasOwnProperty('set') is false
Modified: trunk/Source/WebCore/ChangeLog (214535 => 214536)
--- trunk/Source/WebCore/ChangeLog 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/Source/WebCore/ChangeLog 2017-03-29 15:58:29 UTC (rev 214536)
@@ -1,3 +1,25 @@
+2017-03-29 Youenn Fablet <you...@apple.com>
+
+ Move DTMF WebRTC extension behind its own compile flag
+ https://bugs.webkit.org/show_bug.cgi?id=170226
+
+ Reviewed by Eric Carlson.
+
+ Moving RTCDTMFSender and RTCDTMFToneChangeEvent behinf a WEB_RTC_DTMF compile flag.
+ This compile flag is not set on any supported platform yet.
+ Disabling related test and updated test expectations.
+
+ * Modules/mediastream/RTCDTMFSender.cpp:
+ * Modules/mediastream/RTCDTMFSender.h:
+ * Modules/mediastream/RTCDTMFSender.idl:
+ * Modules/mediastream/RTCDTMFToneChangeEvent.cpp:
+ * Modules/mediastream/RTCDTMFToneChangeEvent.h:
+ * Modules/mediastream/RTCDTMFToneChangeEvent.idl:
+ * dom/EventNames.in:
+ * dom/EventTargetFactory.in:
+ * platform/mediastream/RTCDTMFSenderHandler.h:
+ * platform/mediastream/RTCDTMFSenderHandlerClient.h:
+
2017-03-29 Antoine Quint <grao...@apple.com>
[mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
Modified: trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp (214535 => 214536)
--- trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp 2017-03-29 15:58:29 UTC (rev 214536)
@@ -26,7 +26,7 @@
#include "config.h"
#include "RTCDTMFSender.h"
-#if ENABLE(WEB_RTC)
+#if ENABLE(WEB_RTC_DTMF)
#include "MediaStreamTrack.h"
#include "RTCDTMFSenderHandler.h"
Modified: trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.h (214535 => 214536)
--- trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.h 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.h 2017-03-29 15:58:29 UTC (rev 214536)
@@ -25,7 +25,7 @@
#pragma once
-#if ENABLE(WEB_RTC)
+#if ENABLE(WEB_RTC_DTMF)
#include "ActiveDOMObject.h"
#include "EventTarget.h"
Modified: trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.idl (214535 => 214536)
--- trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.idl 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.idl 2017-03-29 15:58:29 UTC (rev 214536)
@@ -26,7 +26,7 @@
[
ActiveDOMObject,
- Conditional=WEB_RTC,
+ Conditional=WEB_RTC_DTMF,
EnabledAtRuntime=PeerConnection,
NoInterfaceObject,
] interface RTCDTMFSender : EventTarget {
Modified: trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp (214535 => 214536)
--- trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp 2017-03-29 15:58:29 UTC (rev 214536)
@@ -26,7 +26,7 @@
#include "config.h"
#include "RTCDTMFToneChangeEvent.h"
-#if ENABLE(WEB_RTC)
+#if ENABLE(WEB_RTC_DTMF)
#include "EventNames.h"
Modified: trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.h (214535 => 214536)
--- trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.h 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.h 2017-03-29 15:58:29 UTC (rev 214536)
@@ -25,7 +25,7 @@
#pragma once
-#if ENABLE(WEB_RTC)
+#if ENABLE(WEB_RTC_DTMF)
#include "Event.h"
#include <wtf/text/AtomicString.h>
Modified: trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.idl (214535 => 214536)
--- trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.idl 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.idl 2017-03-29 15:58:29 UTC (rev 214536)
@@ -25,7 +25,7 @@
*/
[
- Conditional=WEB_RTC,
+ Conditional=WEB_RTC_DTMF,
Constructor(DOMString type, optional RTCDTMFToneChangeEventInit eventInitDict),
EnabledAtRuntime=PeerConnection,
] interface RTCDTMFToneChangeEvent : Event {
@@ -33,7 +33,7 @@
};
[
- Conditional=WEB_RTC,
+ Conditional=WEB_RTC_DTMF,
EnabledAtRuntime=PeerConnection
] dictionary RTCDTMFToneChangeEventInit : EventInit {
required DOMString tone;
Modified: trunk/Source/WebCore/dom/EventNames.in (214535 => 214536)
--- trunk/Source/WebCore/dom/EventNames.in 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/Source/WebCore/dom/EventNames.in 2017-03-29 15:58:29 UTC (rev 214536)
@@ -45,7 +45,7 @@
MediaStreamTrackEvent conditional=MEDIA_STREAM
RTCPeerConnectionIceEvent conditional=WEB_RTC
RTCDataChannelEvent conditional=WEB_RTC
-RTCDTMFToneChangeEvent conditional=WEB_RTC
+RTCDTMFToneChangeEvent conditional=WEB_RTC_DTMF
RTCTrackEvent conditional=WEB_RTC
SpeechSynthesisEvent conditional=SPEECH_SYNTHESIS
WebGLContextEvent conditional=WEBGL
Modified: trunk/Source/WebCore/dom/EventTargetFactory.in (214535 => 214536)
--- trunk/Source/WebCore/dom/EventTargetFactory.in 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/Source/WebCore/dom/EventTargetFactory.in 2017-03-29 15:58:29 UTC (rev 214536)
@@ -25,7 +25,7 @@
Notification conditional=NOTIFICATIONS|LEGACY_NOTIFICATIONS
Performance conditional=WEB_TIMING
RTCDataChannel conditional=WEB_RTC
-RTCDTMFSender conditional=WEB_RTC
+RTCDTMFSender conditional=WEB_RTC_DTMF
RTCPeerConnection conditional=WEB_RTC
SourceBuffer conditional=MEDIA_SOURCE
SourceBufferList conditional=MEDIA_SOURCE
Modified: trunk/Source/WebCore/platform/mediastream/RTCDTMFSenderHandler.h (214535 => 214536)
--- trunk/Source/WebCore/platform/mediastream/RTCDTMFSenderHandler.h 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/Source/WebCore/platform/mediastream/RTCDTMFSenderHandler.h 2017-03-29 15:58:29 UTC (rev 214536)
@@ -26,7 +26,7 @@
#pragma once
-#if ENABLE(WEB_RTC)
+#if ENABLE(WEB_RTC_DTMF)
#include <wtf/text/WTFString.h>
Modified: trunk/Source/WebCore/platform/mediastream/RTCDTMFSenderHandlerClient.h (214535 => 214536)
--- trunk/Source/WebCore/platform/mediastream/RTCDTMFSenderHandlerClient.h 2017-03-29 15:33:15 UTC (rev 214535)
+++ trunk/Source/WebCore/platform/mediastream/RTCDTMFSenderHandlerClient.h 2017-03-29 15:58:29 UTC (rev 214536)
@@ -26,7 +26,7 @@
#pragma once
-#if ENABLE(WEB_RTC)
+#if ENABLE(WEB_RTC_DTMF)
namespace WebCore {
